1. 14 8月, 2019 7 次提交
  2. 13 8月, 2019 2 次提交
    • D
      qemuxml2xmltest: Redirect access to FW descriptor dirs · 92832577
      Daniel Henrique Barboza 提交于
      If /etc/qemu/firmware directory exists, but is not readable then
      qemuxml2xmltest fails. This is because once domain XML is parsed
      it is validated. For that domain capabilities are needed.
      However, when constructing domain capabilities, FW descriptors
      are loaded and this is the point where the test fails, because it
      fails to open one of the directories.
      
      Fixes: 5b9819ee domain capabilities: Expose firmware auto selection feature
      Signed-off-by: NDaniel Henrique Barboza <danielhb413@gmail.com>
      Signed-off-by: NMichal Privoznik <mprivozn@redhat.com>
      92832577
    • L
      util: allow tap-based guest interfaces to have MAC address prefix 0xFE · a60ee914
      Laine Stump 提交于
      Back in July 2010, commit 6ea90b84 (meant to resolve
      https://bugzilla.redhat.com/571991 ) added code to set the MAC address
      of any tap device to the associated guest interface's MAC, but with
      the first byte replaced with 0xFE. This was done in order to assure
      that
      
      1) the tap MAC and guest interface MAC were different (otherwise L2
         forwarding through the tap would not work, and the kernel would
         repeatedly issue a warning stating as much).
      
      2) any bridge device that had one of these taps attached would *not*
         take on the MAC of the tap (leading to network instability as
         guests started and stopped)
      
      A couple years later, https://bugzilla.redhat.com/798467 was filed,
      complaining that a user could configure a tap-based guest interface to
      have a MAC address that itself had a first byte of 0xFE, silently
      (other than the kernel warning messages) resulting in a non-working
      configuration. This was fixed by commit 5d571045, which logged an
      error and failed the guest start / interface attach if the MAC's first
      byte was 0xFE.
      
      Although this restriction only reduces the potential pool of MAC
      addresses from 2^46 (last two bits of byte 1 must be set to 10) by
      2^32 (still 4 orders of magnitude larger than the entire IPv4 address
      space), it also means that management software that autogenerates MAC
      addresses must have special code to avoid an 0xFE prefix. Now after 7
      years, someone has noticed this restriction and requested that we
      remove it.
      
      So instead of failing when 0xFE is found as the first byte, this patch
      removes the restriction by just replacing the first byte in the tap
      device MAC with 0xFA if the first byte in the guest interface is
      0xFE. 0xFA is the next-highest value that still has 10 as the lowest
      two bits, and still
      
      2) meets the requirement of "tap MAC must be different from guest
         interface MAC", and
      
      3) is high enough that there should never be an issue of the attached
         bridge device taking on the MAC of the tap.
      
      The result is that *any* MAC can be chosen by management software
      (although it would still not work correctly if a multicast MAC (lowest
      bit of first byte set to 1) was chosen), but that's a different
      issue).
      Signed-off-by: NLaine Stump <laine@redhat.com>
      Reviewed-by: Michal Privoznik <mprivozn@redhat.com
      a60ee914
  3. 12 8月, 2019 6 次提交
  4. 10 8月, 2019 1 次提交
    • D
      build: bump min libxml2 to 2.9.1 · e4c05240
      Daniel P. Berrangé 提交于
      The various distros have the following libxml2 vesions:
      
              CentOS 7: 2.9.1
        Debian Stretch: 2.9.4
         FreeBSD Ports: 2.9.9
      Ubuntu 16.04 LTS: 2.9.3
      
      Based on this sampling, we can reasonably bump libxml2 min
      version to 2.9.1
      
      The 'query_raw' struct field was added in version 2.6.28,
      so can be assumed to exist.
      Signed-off-by: NDaniel P. Berrangé <berrange@redhat.com>
      e4c05240
  5. 09 8月, 2019 24 次提交