- 10 7月, 2018 13 次提交
-
-
由 Peter Krempa 提交于
To allow using -blockdev with RBD we need to support the recently added RBD authentication. Signed-off-by: NPeter Krempa <pkrempa@redhat.com> Reviewed-by: NJán Tomko <jtomko@redhat.com>
-
由 Peter Krempa 提交于
It builds the string for '-device' from a virDomainDiskDef. Signed-off-by: NPeter Krempa <pkrempa@redhat.com> Reviewed-by: NJán Tomko <jtomko@redhat.com>
-
由 Peter Krempa 提交于
Aggregate the code for the two separate formats used according to the machine type and add some supporting code so that the function is actually readable. Signed-off-by: NPeter Krempa <pkrempa@redhat.com> Reviewed-by: NJán Tomko <jtomko@redhat.com>
-
由 Peter Krempa 提交于
qemuBulildFloppyCommandLineOptions built its own version of the -drive alias. Replace it by qemuAliasDiskDriveFromDisk. Signed-off-by: NPeter Krempa <pkrempa@redhat.com> Reviewed-by: NJán Tomko <jtomko@redhat.com>
-
由 Peter Krempa 提交于
Further split qemuBuildDiskCommandLine to separate formatting of the source part. Signed-off-by: NPeter Krempa <pkrempa@redhat.com> Reviewed-by: NJán Tomko <jtomko@redhat.com>
-
由 Peter Krempa 提交于
SD card hotplug should not be implemented until they can be used via -blockdev. Signed-off-by: NPeter Krempa <pkrempa@redhat.com> Reviewed-by: NJán Tomko <jtomko@redhat.com>
-
由 Peter Krempa 提交于
Change the semantics to exactly opposite and rename it to qemuDiskBusNeedsDriveArg. This will be necessary as some devices can't be used with -blockdev. Signed-off-by: NPeter Krempa <pkrempa@redhat.com> Reviewed-by: NJán Tomko <jtomko@redhat.com>
-
由 Peter Krempa 提交于
The sectors read from the backing image need to be written to the top level image. If a disk is marked read-only the image can't be written. QEMU handled that by disabling copy_on_read and reporting a warning: -drive file=/var/lib/libvirt/images/c,format=qcow2,if=none, id=drive-scsi0-0-1,readonly=on,copy-on-read=on: warning: disabling copy-on-read on read-only drive Signed-off-by: NPeter Krempa <pkrempa@redhat.com> Reviewed-by: NJán Tomko <jtomko@redhat.com>
-
由 Peter Krempa 提交于
After commit c95f50cb we always set a disk format in the post parse callback so the code that mandates use of explicit format for shareable disks no longer makes sense. Signed-off-by: NPeter Krempa <pkrempa@redhat.com> Reviewed-by: NJán Tomko <jtomko@redhat.com>
-
由 Erik Skultety 提交于
There wasn't an explicit type case to the video type enum in qemuDomainDeviceDefValidateVideo, _TYPE_GOP was also missing from the switch. Signed-off-by: NErik Skultety <eskultet@redhat.com> Reviewed-by: NJohn Ferlan <jferlan@redhat.com>
-
由 Erik Skultety 提交于
Move the video post parse bits into a separate helper as the logic is going to be extended in the future. Signed-off-by: NErik Skultety <eskultet@redhat.com> Reviewed-by: NJohn Ferlan <jferlan@redhat.com>
-
由 Erik Skultety 提交于
Future patches rely on the ability to reset the contents of the virDomainVideoDef structure rather than re-allocating it. Signed-off-by: NErik Skultety <eskultet@redhat.com> Reviewed-by: NJohn Ferlan <jferlan@redhat.com>
-
由 Erik Skultety 提交于
Since 133fb140 moved the validation of a video device into a separate function, the code handling PCI slot assignment for video devices has been the same for both the primary device and the secondary devices. Let's merge these and thus handle all the devices within the existing 'for' loop. Signed-off-by: NErik Skultety <eskultet@redhat.com> Reviewed-by: NJohn Ferlan <jferlan@redhat.com>
-
- 09 7月, 2018 10 次提交
-
-
由 Erik Skultety 提交于
QEMU uses a shorthand '-sdl' which maps to '-display sdl'. However, if there are any options to be passed to SDL, the full command version must be used. Everything seemingly worked for us until commit 5038b300 introduced OpenGL support for SDL and added ',gl=on/off' option which as mentioned above could have never worked with the shorthand version of the command. Indeed starting a domain with an SDL display and OpenGL enabled, QEMU produces a rather cryptic error: -sdl: Could not open 'gl=on': No such file or directory This patch provides fixes to both the SDL cmdline generation and the test suite. Signed-off-by: NErik Skultety <eskultet@redhat.com> Reviewed-by: NJohn Ferlan <jferlan@redhat.com>
-
由 Erik Skultety 提交于
Signed-off-by: NErik Skultety <eskultet@redhat.com> Reviewed-by: NJohn Ferlan <jferlan@redhat.com>
-
由 Erik Skultety 提交于
Adding the 'default' case to our enum-typecasted switches is the current safety trend, so add it here for mdevs too. Signed-off-by: NErik Skultety <eskultet@redhat.com> Reviewed-by: NJohn Ferlan <jferlan@redhat.com>
-
由 Erik Skultety 提交于
It should be the command line helper who takes care of the iteration rather than the caller. Signed-off-by: NErik Skultety <eskultet@redhat.com> Reviewed-by: NJohn Ferlan <jferlan@redhat.com>
-
由 Erik Skultety 提交于
It's pointless to check the same thing multiple times. Fix the indentation along the way too. Signed-off-by: NErik Skultety <eskultet@redhat.com> Reviewed-by: NJohn Ferlan <jferlan@redhat.com>
-
由 Boris Fiuczynski 提交于
Rename qemuBulildFloppyCommandLineOptions into qemuBuildFloppyCommandLineOptions. Signed-off-by: NBoris Fiuczynski <fiuczy@linux.ibm.com>
-
由 Peter Krempa 提交于
qemu changed the output field name for the architecture from 'arch' to 'target'. Note the change and fix the code so that the arch-specific extraction works. https://bugzilla.redhat.com/show_bug.cgi?id=1598829Signed-off-by: NPeter Krempa <pkrempa@redhat.com> Reviewed-by: NDaniel P. Berrangé <berrange@redhat.com>
-
由 Peter Krempa 提交于
The wraper is quite pointless and also the 'arch' field may depend on whether query-cpus-fast is used. Signed-off-by: NPeter Krempa <pkrempa@redhat.com> Reviewed-by: NDaniel P. Berrangé <berrange@redhat.com>
-
由 Michal Privoznik 提交于
This function is called from various clean up paths (e.g. from qemuBuildInterfaceCommandLine). However, depending on the stage the interface creation process failed at, net->ifname might still be not filled in when control jumps to cleanup label. If that is the case return early (avoiding useless error message produced in virNWFilterBindingLookupByPortDev) as there is no NWFilter to tear down anyway. Signed-off-by: NMichal Privoznik <mprivozn@redhat.com> Reviewed-by: NErik Skultety <eskultet@redhat.com>
-
由 Michal Privoznik 提交于
After 6b770f9a both @netsource and @srcprops are leaked because of early return introduced in the commit. ==1812== 644 bytes in 4 blocks are definitely lost in loss record 835 of 885 ==1812== at 0x4C2F12F: realloc (vg_replace_malloc.c:785) ==1812== by 0x8846393: xmlSaveUriRealloc (in /usr/lib64/libxml2.so.2.9.8) ==1812== by 0x8846B1C: xmlSaveUri (in /usr/lib64/libxml2.so.2.9.8) ==1812== by 0x5DDA619: virURIFormat (viruri.c:256) ==1812== by 0x56E941B: qemuBuildNetworkDriveURI (qemu_command.c:781) ==1812== by 0x56E979A: qemuBuildNetworkDriveStr (qemu_command.c:859) ==1812== by 0x56F3A0B: qemuBuildSCSIiSCSIHostdevDrvStr (qemu_command.c:4664) ==1812== by 0x56F3D1F: qemuBuildSCSIHostdevDrvStr (qemu_command.c:4732) ==1812== by 0x56F57F7: qemuBuildHostdevCommandLine (qemu_command.c:5337) ==1812== by 0x570303A: qemuBuildCommandLine (qemu_command.c:10376) ==1812== by 0x57604EE: qemuProcessCreatePretendCmd (qemu_process.c:6649) ==1812== by 0x11352A: testCompareXMLToArgv (qemuxml2argvtest.c:566) Signed-off-by: NMichal Privoznik <mprivozn@redhat.com>
-
- 06 7月, 2018 5 次提交
-
-
由 Julio Faracco 提交于
This commit renames and adds other macros to support aother filesystems when a reflink is performed. After that, XFS filesystems (and others) with reflink support will be able to clone. Resolves: https://bugzilla.redhat.com/show_bug.cgi?id=1565004Signed-off-by: NJulio Faracco <jcfaracco@gmail.com> Signed-off-by: NMichal Privoznik <mprivozn@redhat.com>
-
由 Daniel P. Berrangé 提交于
When support was adding for passing a pre-opened listener socket to UNIX chardevs, it accidentally passed the listener socket for client mode chardevs too with predictable amounts of fail resulting. This affects libvirt when using QEMU >= 2.12 Expand the unit test coverage to validate that we are only doing FD passing when operating in server mode. https://bugzilla.redhat.com/show_bug.cgi?id=1598440Tested-by: NRichard W.M. Jones <rjones@redhat.com> Reported-by: NRichard W.M. Jones <rjones@redhat.com> Signed-off-by: NDaniel P. Berrangé <berrange@redhat.com>
-
由 Daniel P. Berrangé 提交于
QEMU chardevs have a bug which makes the vhostuser backend complain about lack of support for FD passing when validating the chardev. While this is ultimately QEMU's responsibility to fix, libvirt needs to avoid tickling the bug. Simply disabling chardev FD passing just for vhostuser's chardev is the most prudent approach, avoiding need for a QEMU version number check. Signed-off-by: NDaniel P. Berrangé <berrange@redhat.com>
-
由 Daniel P. Berrangé 提交于
There are two boolean parameters passed to qemuBuildChrChardevStr, and soon there will be a third. It will be clearer to understand from callers' POV if we use named flags instead. Signed-off-by: NDaniel P. Berrangé <berrange@redhat.com>
-
由 Daniel P. Berrangé 提交于
The vhostuser network backend is only supported with the UNIX domain socket chardev backend, so passing around chardevStdioLogd is not required. Signed-off-by: NDaniel P. Berrangé <berrange@redhat.com>
-
- 05 7月, 2018 1 次提交
-
-
由 Luyao Huang 提交于
If the code jump to the cleanup before assigning value to @xml libvirtd may crash when it tries to free an uninitialized pointer. backtrace: 0 0x00007ffff428d59c in free () from /lib64/libc.so.6 1 0x00007ffff721314a in virFree (ptrptr=ptrptr@entry=0x7fffc67f1b00) at util/viralloc.c:582 2 0x00007ffff7345ac4 in virDomainConfNWFilterInstantiate (vmname=<optimized out>, vmuuid=vmuuid@entry=0x7fffc0181ca8 "߉\237\\۔H\262\206z\340\302f\265\233z", net=<optimized out>, ignoreExists=ignoreExists@entry=true) at conf/domain_nwfilter.c:122 3 0x00007fffca5a77f6 in qemuProcessFiltersInstantiate (ignoreExists=true, def=0x7fffc0181ca0) at qemu/qemu_process.c:3028 4 qemuProcessReconnect (opaque=<optimized out>) at qemu/qemu_process.c:7653 5 0x00007ffff72c4895 in virThreadHelper (data=<optimized out>) at util/virthread.c:206 6 0x00007ffff45dcdd5 in start_thread () from /lib64/libpthread.so.0 7 0x00007ffff4305ead in clone () from /lib64/libc.so.6 Signed-off-by: NLuyao Huang <lhuang@redhat.com>
-
- 04 7月, 2018 11 次提交
-
-
由 Michal Privoznik 提交于
https://bugzilla.redhat.com/show_bug.cgi?id=1598087 We are mentioning the positive outcome of the function and not the case when live detaching a device is denied and event is issued. Signed-off-by: NMichal Privoznik <mprivozn@redhat.com> Reviewed-by: NJiri Denemark <jdenemar@redhat.com>
-
由 Michal Privoznik 提交于
https://bugzilla.redhat.com/show_bug.cgi?id=1598084 When creating a snapshot with --quiesce an async job is grabbed and just before executing guest fs-freeze command an agent job is grabbed. This is achieved by calling qemuDomainObjBeginJobInternal(job = QEMU_JOB_NONE, agentJob = QEMU_AGENT_JOB_MODIFY); Since there already is an async job set on the domain (by the same thread) qemuDomainNestedJobAllowed(priv, job) is consulted if @job is allowed by job mask. But this function returns false (meaning sync @job is not allowed) which leads to a deadlock. Signed-off-by: NMichal Privoznik <mprivozn@redhat.com> Reviewed-by: NJiri Denemark <jdenemar@redhat.com>
-
由 Marcos Paulo de Souza 提交于
By using this macro we can avoid boilerplate code to check for arrays of objects from ESX driver. This replacement was done using the coccinelle script bellow: @@ identifier ptr; @@ -if (!ptr || *ptr) { ... } +ESX_VI_CHECK_ARG_LIST(ptr); Signed-off-by: NMarcos Paulo de Souza <marcos.souza.org@gmail.com>
-
由 Marcos Paulo de Souza 提交于
This macro avoids code duplication when checking for arrays of objects. Signed-off-by: NMarcos Paulo de Souza <marcos.souza.org@gmail.com> Signed-off-by: NMichal Privoznik <mprivozn@redhat.com>
-
由 Bobo Du 提交于
the libvirtd pid file is not match the os process pid number which is smaller than before. this would be exist if the libvirtd process coredump or the os process was killed which the next pid number is smaller. you can be also edit the pid file to write the longer number than before,then restart the libvirtd service. Signed-off-by: NBobo Du <dubo163@126.com>
-
由 Pavel Hrdina 提交于
The same check is done by virNWFilterBindingObjListAdd(). The main issue with the current code is that if the object already exists we would leak 'def' because 'obj' would be set and the cleanup code frees 'def' only if 'obj' is NULL. Reviewed-by: NDaniel P. Berrangé <berrange@redhat.com> Signed-off-by: NPavel Hrdina <phrdina@redhat.com>
-
由 Anya Harter 提交于
never used outside domain_addr.c Signed-off-by: NAnya Harter <aharter@redhat.com> Reviewed-by: NPavel Hrdina <phrdina@redhat.com>
-
由 Anya Harter 提交于
SetCreate, SetAddControllers, Reserve last uses of these functions outside domain_addr.c removed in commit: 40c284f0 Assign never used outside domain_addr.c move Assign and Reserve above their first call within domain_addr.c Signed-off-by: NAnya Harter <aharter@redhat.com> Reviewed-by: NPavel Hrdina <phrdina@redhat.com>
-
由 Anya Harter 提交于
Allocate, Validate, SetCreate last uses of these functions outside domain_addr.c removed in commit: 7bdd06b4Signed-off-by: NAnya Harter <aharter@redhat.com> Reviewed-by: NPavel Hrdina <phrdina@redhat.com>
-
由 Anya Harter 提交于
never used outside domain_addr.c Signed-off-by: NAnya Harter <aharter@redhat.com> Reviewed-by: NPavel Hrdina <phrdina@redhat.com>
-
由 Michal Privoznik 提交于
The function call esxVI_LookupVirtualMachineByName(occurrence = OptionalItem) and then checks if @virtualMachine is NULL. If it is an error is reported. The same result can be achieved by setting occurrence to RequiredItem. Signed-off-by: NMichal Privoznik <mprivozn@redhat.com>
-