Skip to content

L
libvirt

openeuler / libvirt

通知 3
Star 0
Fork 0
L
libvirt
切换分支/标签
  1. 12 11月, 2019 2 次提交
  3. 11 11月, 2019 8 次提交
    • D
      python: sanitize indentation after line continuations · 3df69e62
      由 Daniel P. Berrangé 提交于 
      Line continuations should be 4 space indented unless a previous opening
brace required different alignment.

docs/apibuild.py:2014:24: E126 continuation line over-indented for hanging indent
                       token[0], token[1]))
                       ^
docs/apibuild.py:74:3: E121 continuation line under-indented for hanging indent
  "ATTRIBUTE_UNUSED": (0, "macro keyword"),
  ^
...more...
Signed-off-by: NDaniel P. Berrangé <berrange@redhat.com>
      3df69e62
    • D
      python: sanitize spaces either side of operators · 43d29cb4
      由 Daniel P. Berrangé 提交于 
      There should be a single space either side of operators. Inline
comments should have two spaces before the '#'

src/hyperv/hyperv_wmi_generator.py:130:45: E261 at least two spaces before inline comment
            source += '    { "", "", 0 },\n' # null terminated
                                            ^
src/esx/esx_vi_generator.py:417:25: E221 multiple spaces before operator
    FEATURE__DESERIALIZE  = (1 << 6)
                        ^
tests/cputestdata/cpu-cpuid.py:187:78: E225 missing whitespace around operator
                f.write("  <msr index='0x%x' edx='0x%08x' eax='0x%08x'/>\n" %(
                                                                             ^
docs/apibuild.py:524:47: E226 missing whitespace around arithmetic operator
                            self.line = line[i+2:]
                                              ^
...more...
Signed-off-by: NDaniel P. Berrangé <berrange@redhat.com>
      43d29cb4
    • D
      python: sanitize blank line usage · bc59247d
      由 Daniel P. Berrangé 提交于 
      Coding style expects 1 blank line between each method and 2 blank lines
before each class.

docs/apibuild.py:171:5: E303 too many blank lines (2)
    def set_header(self, header):
    ^
docs/apibuild.py:230:1: E302 expected 2 blank lines, found 1
class index:
^
docs/apibuild.py:175:5: E301 expected 1 blank line, found 0
    def set_module(self, module):
    ^
...more...
Signed-off-by: NDaniel P. Berrangé <berrange@redhat.com>
      bc59247d
    • D
      python: avoid bare 'except:' clause · 2ba699cb
      由 Daniel P. Berrangé 提交于 
      Exception catching statements should always match on a class name, the
most specific one possible. Rather than analyse the code to look at what
the most specific one is, this just uses the base Exception class.

docs/apibuild.py:255:9: E722 do not use bare 'except'
        except:
        ^
docs/apibuild.py:279:9: E722 do not use bare 'except'
        except:
        ^
...more...
Signed-off-by: NDaniel P. Berrangé <berrange@redhat.com>
      2ba699cb
    • D
      python: avoid variable named 'l' · cfdd871f
      由 Daniel P. Berrangé 提交于 
      Python code style recommends avoiding a variable named 'l' as it is
visually similar to '1'.

docs/apibuild.py:482:13: E741 ambiguous variable name 'l'
            l = len(line)
            ^
docs/apibuild.py:503:21: E741 ambiguous variable name 'l'
                    l = len(line)
                    ^
...more...
Signed-off-by: NDaniel P. Berrangé <berrange@redhat.com>
      cfdd871f
    • D
      python: mark regex strings with 'r' prefix · d5c5d8af
      由 Daniel P. Berrangé 提交于 
      When writing regexes special regex matches like "\d" can get
misinterpreted as normal string escape sequences:

docs/apibuild.py:1359:51: W605 invalid escape sequence '\d'
                        value = value + re.sub("^(\d+)U$", "\\1", token[1])
                                                  ^
docs/apibuild.py:2134:31: W605 invalid escape sequence '\('
                m = re.match("\(?1<<(\d+)\)?", info[0])
                              ^
docs/apibuild.py:2134:38: W605 invalid escape sequence '\d'
                m = re.match("\(?1<<(\d+)\)?", info[0])
                                     ^
docs/apibuild.py:2134:42: W605 invalid escape sequence '\)'
                m = re.match("\(?1<<(\d+)\)?", info[0])
                                         ^

To avoid this probem all regexes should use the r"...." syntax for their
strings, which disables normal string escape sequences.
Signed-off-by: NDaniel P. Berrangé <berrange@redhat.com>
      d5c5d8af
    • D
      python: fix use of undeclared variables in python scripts · 524b377e
      由 Daniel P. Berrangé 提交于 
      docs/apibuild.py:2436:65: F821 undefined name 'first_letter'
                        chunks.append(["chunk%s" % (chunk - 1), first_letter, letter])
                                                                ^
src/hyperv/hyperv_wmi_generator.py:415:57: F821 undefined name 'number'
        report_error("line %d: invalid block header" % (number))
                                                        ^
Signed-off-by: NDaniel P. Berrangé <berrange@redhat.com>
      524b377e
    • D
      docs: remove some dead code in apibuild.py · 55cbe0fb
      由 Daniel P. Berrangé 提交于 
      Signed-off-by: NDaniel P. Berrangé <berrange@redhat.com>
      55cbe0fb
  5. 09 11月, 2019 2 次提交
  7. 07 11月, 2019 1 次提交
  9. 06 11月, 2019 2 次提交
  11. 05 11月, 2019 4 次提交
  13. 02 11月, 2019 1 次提交
  15. 01 11月, 2019 2 次提交
  17. 23 10月, 2019 18 次提交