1. 13 11月, 2017 1 次提交
  2. 07 11月, 2017 3 次提交
  3. 06 11月, 2017 1 次提交
    • J
      conf: Don't inline virDomainNetTypeSharesHostView · bce925da
      Jiri Denemark 提交于
      When coverage build is enabled, gcc complains about it:
      
      In file included from qemu/qemu_agent.h:29:0,
                       from qemu/qemu_driver.c:47:
      qemu/qemu_driver.c: In function 'qemuDomainSetInterfaceParameters':
      ./conf/domain_conf.h:3397:1: error: inlining failed in call to
      'virDomainNetTypeSharesHostView': call is unlikely and code size would
      grow [-Werror=inline]
       virDomainNetTypeSharesHostView(const virDomainNetDef *net)
       ^
      Signed-off-by: NJiri Denemark <jdenemar@redhat.com>
      bce925da
  4. 04 11月, 2017 1 次提交
  5. 03 11月, 2017 1 次提交
    • A
      Remove backslash alignment attempts · 3e7db8d3
      Andrea Bolognani 提交于
      Right-aligning backslashes when defining macros or using complex
      commands in Makefiles looks cute, but as soon as any changes is
      required to the code you end up with either distractingly broken
      alignment or unnecessarily big diffs where most of the changes
      are just pushing all backslashes a few characters to one side.
      
      Generated using
      
        $ git grep -El '[[:blank:]][[:blank:]]\\$' | \
          grep -E '*\.([chx]|am|mk)$$' | \
          while read f; do \
            sed -Ei 's/[[:blank:]]*[[:blank:]]\\$/ \\/g' "$f"; \
          done
      Signed-off-by: NAndrea Bolognani <abologna@redhat.com>
      3e7db8d3
  6. 23 10月, 2017 2 次提交
  7. 22 10月, 2017 1 次提交
    • M
      conf: Parse user supplied aliases · c14f1ed2
      Michal Privoznik 提交于
      If driver that is calling the parse supports user supplied
      aliases, they can be parsed even for inactive XMLs. However, to
      avoid any clashes with aliases that libvirt generates, the user
      ones have to have "ua-" prefix.
      
      Note, that some drivers don't have notion of device aliases at
      all. Also, in order to support user supplied aliases some extra
      checks need to be done (e.g. during hotplug). Therefore we can't
      just enable this feature for all the drivers. Thus we need a flag
      that drivers set to tell parsing code that they can handle user
      supplied device aliases.
      Signed-off-by: NMichal Privoznik <mprivozn@redhat.com>
      c14f1ed2
  8. 20 10月, 2017 2 次提交
    • J
      conf: Add/Allow parsing the encryption in the disk source · 37537a7c
      John Ferlan 提交于
      Since the virStorageEncryptionPtr encryption; is a member of
       _virStorageSource it really should be allowed to be a subelement
      of the disk <source> for various disk formats:
      
         Source{File|Dir|Block|Volume}
         SourceProtocol{RBD|ISCSI|NBD|Gluster|Simple|HTTP}
      
      NB: Simple includes sheepdog, ftp, ftps, tftp
      
      That way we can set up to allow the <encryption> element to be
      formatted within the disk source, but we still need to be wary
      from whence the element was read - see keep track and when it
      comes to format the data, ensure it's written in the correct place.
      
      Modify the qemuxml2argvtest to add a parse failure when there is an
      <encryption> as a child of <disk> *and* an <encryption> as a child
      of <source>.
      
      The virschematest will read the new test files and validate from a
      RNG viewpoint things are fine.
      37537a7c
    • J
      conf: Add/Allow parsing the auth in the disk source · 8002d3cb
      John Ferlan 提交于
      Since the virStorageAuthDefPtr auth; is a member of _virStorageSource
      it really should be allowed to be a subelement of the disk <source>
      for the RBD and iSCSI prototcols. That way we can set up to allow
      the <auth> element to be formatted within the disk source.
      
      Since we've allowed the <auth> to be a child of <disk>, we'll need
      to keep track of how it was read so that when writing out we'll know
      whether to format as child of <disk> or <source>. For the argv2xml
      parsing, let's format under <source> as a preference. Do not allow
      <auth> to be both a child of <disk> and <source>.
      
      Modify the qemuxml2argvtest to add a parse failure when there is an
      <auth> as a child of <disk> *and* an <auth> as a child of <source>.
      
      Add tests to validate that if the <auth> was found in <source>, then
      the resulting xml2xml and xml2arg works just fine.  The two new .args
      file are exact copies of the non "-source" version of the file.
      
      The virschematest will read the new test files and validate from a
      RNG viewpoint things are fine
      
      Update the virstoragefile, virstoragetest, and args2xml file to show
      the "preference" to place <auth> as a child of <source>.
      8002d3cb
  9. 19 10月, 2017 8 次提交
  10. 18 10月, 2017 1 次提交
  11. 17 10月, 2017 4 次提交
    • P
      Terminate backing chains explicitly · a693fdba
      Peter Krempa 提交于
      Express a properly terminated backing chain by putting a
      virStorageSource of type VIR_STORAGE_TYPE_NONE in the chain. The newly
      used helpers simplify this greatly.
      
      The change fixes a bug as formatting an incomplete backing chain and
      parsing it back would end up in expressing a terminated chain since
      src->backingStoreRaw was not populated. By relying on the terminator
      object this can be now processed appropriately.
      a693fdba
    • P
      util: storagefile: Add helpers to check presence of backing store · 0a294a8e
      Peter Krempa 提交于
      Add helpers that will simplify checking if a backing file is valid or
      whether it has backing store. The helper virStorageSourceIsBacking
      returns true if the given virStorageSource is a valid backing store
      member. virStorageSourceHasBacking returns true if the virStorageSource
      has a backing store child.
      
      Adding these functions creates a central points for further refactors.
      0a294a8e
    • P
      util: storage: Store backing chain index in virStorageSource · c6231a6a
      Peter Krempa 提交于
      The backing store indexes were not bound to the storage sources in any
      way. To allow us to bind a given alias to a given storage source we need
      to save the index in virStorageSource. The backing store ids are now
      generated when detecting the backing chain.
      
      Since we don't re-detect the backing chain after snapshots, the
      numbering needs to be fixed there.
      c6231a6a
    • P
      conf: domain: Simplify return from backing store parser · 8b13c37f
      Peter Krempa 提交于
      Use VIR_STEAL_PTR to remove conditional cleanup.
      8b13c37f
  12. 14 10月, 2017 3 次提交
  13. 05 10月, 2017 2 次提交
  14. 04 10月, 2017 3 次提交
  15. 28 9月, 2017 1 次提交
    • A
      util: Add TLS attributes to virStorageSource · f1705485
      Ashish Mittal 提交于
      Add an optional virTristateBool haveTLS to virStorageSource to
      manage whether a storage source will be using TLS.
      
      Sample XML for a VxHS disk:
      
      <disk type='network' device='disk'>
        <driver name='qemu' type='raw' cache='none'/>
        <source protocol='vxhs' name='eb90327c-8302-4725-9e1b-4e85ed4dc251' tls='yes'>
          <host name='192.168.0.1' port='9999'/>
        </source>
        <target dev='vda' bus='virtio'/>
      </disk>
      
      Additionally add a tlsFromConfig boolean to control whether the TLS
      setting was due to domain configuration or qemu.conf global setting
      in order to decide whether to Format the haveTLS setting for either
      a live or saved domain configuration file.
      
      Update the qemuxml2xmltest in order to add a test to show the proper
      parsing.
      
      Also update the docs to describe the tls attribute.
      Signed-off-by: NAshish Mittal <Ashish.Mittal@veritas.com>
      Signed-off-by: NJohn Ferlan <jferlan@redhat.com>
      f1705485
  16. 27 9月, 2017 1 次提交
  17. 26 9月, 2017 1 次提交
  18. 22 9月, 2017 1 次提交
  19. 21 9月, 2017 2 次提交
  20. 20 9月, 2017 1 次提交