提交 ef6147c4 编写于 作者: E Eric Blake

phyp: avoid a logic bug

Ever since commit ebc46f, the destroy function built two command
variants but only used one.  I went with the variant that matches
the idiom used in the counterpart of phypBuildStoragePool.

* src/phyp/phyp_driver.c (phypDestroyStoragePool): Avoid
clobbering cmd.  Fix error message typo.
上级 dbe3bad9
......@@ -2936,19 +2936,10 @@ phypDestroyStoragePool(virStoragePoolPtr pool)
return -1;
}
cmd = virBufferContentAndReset(&buf);
if (virAsprintf(&cmd,
"viosvrcmd -m %s --id %d -c "
"'rmsp %s'", managed_system, vios_id,
pool->name) < 0) {
virReportOOMError();
goto cleanup;
}
ret = phypExec(session, cmd, &exit_status, conn);
if (exit_status < 0) {
VIR_ERROR(_("Unable to create Storage Pool: %s"), ret);
VIR_ERROR(_("Unable to destroy Storage Pool: %s"), ret);
goto cleanup;
}
......
Markdown is supported
0% .
You are about to add 0 people to the discussion. Proceed with caution.
先完成此消息的编辑!
想要评论请 注册