qemu_cgroup.c 37.9 KB
Newer Older
1 2 3
/*
 * qemu_cgroup.c: QEMU cgroup management
 *
4
 * Copyright (C) 2006-2015 Red Hat, Inc.
5 6 7 8 9 10 11 12 13 14 15 16 17
 * Copyright (C) 2006 Daniel P. Berrange
 *
 * This library is free software; you can redistribute it and/or
 * modify it under the terms of the GNU Lesser General Public
 * License as published by the Free Software Foundation; either
 * version 2.1 of the License, or (at your option) any later version.
 *
 * This library is distributed in the hope that it will be useful,
 * but WITHOUT ANY WARRANTY; without even the implied warranty of
 * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the GNU
 * Lesser General Public License for more details.
 *
 * You should have received a copy of the GNU Lesser General Public
18
 * License along with this library.  If not, see
O
Osier Yang 已提交
19
 * <http://www.gnu.org/licenses/>.
20 21 22 23 24 25 26
 *
 * Author: Daniel P. Berrange <berrange@redhat.com>
 */

#include <config.h>

#include "qemu_cgroup.h"
27
#include "qemu_domain.h"
28
#include "qemu_process.h"
29
#include "vircgroup.h"
30
#include "virlog.h"
31
#include "viralloc.h"
32
#include "virerror.h"
33
#include "domain_audit.h"
34
#include "virscsi.h"
35
#include "virstring.h"
36
#include "virfile.h"
37
#include "virtypedparam.h"
38
#include "virnuma.h"
39 40 41

#define VIR_FROM_THIS VIR_FROM_QEMU

42 43
VIR_LOG_INIT("qemu.qemu_cgroup");

44 45 46 47
static const char *const defaultDeviceACL[] = {
    "/dev/null", "/dev/full", "/dev/zero",
    "/dev/random", "/dev/urandom",
    "/dev/ptmx", "/dev/kvm", "/dev/kqemu",
48
    "/dev/rtc", "/dev/hpet", "/dev/vfio/vfio",
49 50 51 52 53
    NULL,
};
#define DEVICE_PTY_MAJOR 136
#define DEVICE_SND_MAJOR 116

54 55 56 57 58
static int
qemuSetImageCgroupInternal(virDomainObjPtr vm,
                           virStorageSourcePtr src,
                           bool deny,
                           bool forceReadonly)
59
{
60
    qemuDomainObjPrivatePtr priv = vm->privateData;
61
    int perms = VIR_CGROUP_DEVICE_READ;
62
    int ret;
63

64 65 66 67 68 69 70 71 72 73 74 75 76 77 78 79 80
    if (!virCgroupHasController(priv->cgroup,
                                VIR_CGROUP_CONTROLLER_DEVICES))
        return 0;

    if (!src->path || !virStorageSourceIsLocalStorage(src)) {
        VIR_DEBUG("Not updating cgroups for disk path '%s', type: %s",
                  NULLSTR(src->path), virStorageTypeToString(src->type));
        return 0;
    }

    if (deny) {
        perms |= VIR_CGROUP_DEVICE_WRITE | VIR_CGROUP_DEVICE_MKNOD;

        VIR_DEBUG("Deny path %s", src->path);

        ret = virCgroupDenyDevicePath(priv->cgroup, src->path, perms);
    } else {
81
        if (!src->readonly && !forceReadonly)
82 83 84 85 86 87 88 89 90 91 92 93 94
            perms |= VIR_CGROUP_DEVICE_WRITE;

        VIR_DEBUG("Allow path %s, perms: %s",
                  src->path, virCgroupGetDevicePermsString(perms));

        ret = virCgroupAllowDevicePath(priv->cgroup, src->path, perms);
    }

    virDomainAuditCgroupPath(vm, priv->cgroup,
                             deny ? "deny" : "allow",
                             src->path,
                             virCgroupGetDevicePermsString(perms),
                             ret == 0);
95 96 97 98

    /* Get this for root squash NFS */
    if (ret < 0 &&
        virLastErrorIsSystemErrno(EACCES)) {
99
        VIR_DEBUG("Ignoring EACCES for %s", src->path);
100 101
        virResetLastError();
        ret = 0;
102
    }
103

104
    return ret;
105 106 107
}


108 109 110 111 112 113 114 115 116
int
qemuSetImageCgroup(virDomainObjPtr vm,
                   virStorageSourcePtr src,
                   bool deny)
{
    return qemuSetImageCgroupInternal(vm, src, deny, false);
}


117 118 119
int
qemuSetupDiskCgroup(virDomainObjPtr vm,
                    virDomainDiskDefPtr disk)
120
{
121
    virStorageSourcePtr next;
122
    bool forceReadonly = false;
123

124
    for (next = disk->src; next; next = next->backingStore) {
125
        if (qemuSetImageCgroupInternal(vm, next, false, forceReadonly) < 0)
126
            return -1;
127 128 129

        /* setup only the top level image for read-write */
        forceReadonly = true;
130
    }
131 132

    return 0;
133 134 135
}


136 137 138
int
qemuTeardownDiskCgroup(virDomainObjPtr vm,
                       virDomainDiskDefPtr disk)
139
{
140
    virStorageSourcePtr next;
141

142 143 144 145
    for (next = disk->src; next; next = next->backingStore) {
        if (qemuSetImageCgroup(vm, next, true) < 0)
            return -1;
    }
146

147
    return 0;
148 149
}

150

151
static int
152
qemuSetupChrSourceCgroup(virDomainDefPtr def ATTRIBUTE_UNUSED,
153
                         virDomainChrSourceDefPtr dev,
154
                         void *opaque)
155
{
156 157
    virDomainObjPtr vm = opaque;
    qemuDomainObjPrivatePtr priv = vm->privateData;
158
    int ret;
159

160
    if (dev->type != VIR_DOMAIN_CHR_TYPE_DEV)
161 162
        return 0;

163
    VIR_DEBUG("Process path '%s' for device", dev->data.file.path);
164

165 166
    ret = virCgroupAllowDevicePath(priv->cgroup, dev->data.file.path,
                                   VIR_CGROUP_DEVICE_RW);
167
    virDomainAuditCgroupPath(vm, priv->cgroup, "allow",
168
                             dev->data.file.path, "rw", ret == 0);
169

170
    return ret;
171 172
}

173 174 175 176 177
static int
qemuSetupChardevCgroup(virDomainDefPtr def,
                       virDomainChrDefPtr dev,
                       void *opaque)
{
178
    return qemuSetupChrSourceCgroup(def, &dev->source, opaque);
179 180 181 182 183 184
}


static int
qemuSetupTPMCgroup(virDomainDefPtr def,
                   virDomainTPMDefPtr dev,
185
                   void *opaque)
186
{
187
    int ret = 0;
188 189 190

    switch (dev->type) {
    case VIR_DOMAIN_TPM_TYPE_PASSTHROUGH:
191 192
        ret = qemuSetupChrSourceCgroup(def, &dev->data.passthrough.source,
                                       opaque);
193 194 195 196 197
        break;
    case VIR_DOMAIN_TPM_TYPE_LAST:
        break;
    }

198
    return ret;
199 200
}

201

202
static int
203
qemuSetupHostUSBDeviceCgroup(virUSBDevicePtr dev ATTRIBUTE_UNUSED,
204 205
                             const char *path,
                             void *opaque)
206
{
207 208
    virDomainObjPtr vm = opaque;
    qemuDomainObjPrivatePtr priv = vm->privateData;
209
    int ret;
210 211

    VIR_DEBUG("Process path '%s' for USB device", path);
212 213 214
    ret = virCgroupAllowDevicePath(priv->cgroup, path,
                                   VIR_CGROUP_DEVICE_RW);
    virDomainAuditCgroupPath(vm, priv->cgroup, "allow", path, "rw", ret == 0);
215

216
    return ret;
217 218
}

219
static int
220
qemuSetupHostSCSIDeviceCgroup(virSCSIDevicePtr dev ATTRIBUTE_UNUSED,
221 222 223 224 225
                              const char *path,
                              void *opaque)
{
    virDomainObjPtr vm = opaque;
    qemuDomainObjPrivatePtr priv = vm->privateData;
226
    int ret;
227 228 229

    VIR_DEBUG("Process path '%s' for SCSI device", path);

230 231 232 233
    ret = virCgroupAllowDevicePath(priv->cgroup, path,
                                   virSCSIDeviceGetReadonly(dev) ?
                                   VIR_CGROUP_DEVICE_READ :
                                   VIR_CGROUP_DEVICE_RW);
234 235

    virDomainAuditCgroupPath(vm, priv->cgroup, "allow", path,
236
                             virSCSIDeviceGetReadonly(dev) ? "r" : "rw", ret == 0);
237

238
    return ret;
239
}
240

241 242 243 244 245 246
int
qemuSetupHostdevCGroup(virDomainObjPtr vm,
                       virDomainHostdevDefPtr dev)
{
    int ret = -1;
    qemuDomainObjPrivatePtr priv = vm->privateData;
247
    virDomainHostdevSubsysUSBPtr usbsrc = &dev->source.subsys.u.usb;
248
    virDomainHostdevSubsysPCIPtr pcisrc = &dev->source.subsys.u.pci;
249
    virDomainHostdevSubsysSCSIPtr scsisrc = &dev->source.subsys.u.scsi;
250
    virPCIDevicePtr pci = NULL;
251
    virUSBDevicePtr usb = NULL;
252
    virSCSIDevicePtr scsi = NULL;
253 254 255 256 257 258 259 260 261 262 263 264 265 266
    char *path = NULL;

    /* currently this only does something for PCI devices using vfio
     * for device assignment, but it is called for *all* hostdev
     * devices.
     */

    if (!virCgroupHasController(priv->cgroup, VIR_CGROUP_CONTROLLER_DEVICES))
        return 0;

    if (dev->mode == VIR_DOMAIN_HOSTDEV_MODE_SUBSYS) {

        switch (dev->source.subsys.type) {
        case VIR_DOMAIN_HOSTDEV_SUBSYS_TYPE_PCI:
267
            if (pcisrc->backend == VIR_DOMAIN_HOSTDEV_PCI_BACKEND_VFIO) {
268
                int rv;
269

270 271 272 273
                pci = virPCIDeviceNew(pcisrc->addr.domain,
                                      pcisrc->addr.bus,
                                      pcisrc->addr.slot,
                                      pcisrc->addr.function);
274 275 276
                if (!pci)
                    goto cleanup;

277
                if (!(path = virPCIDeviceGetIOMMUGroupDev(pci)))
278 279 280
                    goto cleanup;

                VIR_DEBUG("Cgroup allow %s for PCI device assignment", path);
281
                rv = virCgroupAllowDevicePath(priv->cgroup, path,
282 283
                                              VIR_CGROUP_DEVICE_RW);
                virDomainAuditCgroupPath(vm, priv->cgroup,
284 285
                                         "allow", path, "rw", rv == 0);
                if (rv < 0)
286 287 288
                    goto cleanup;
            }
            break;
289 290 291 292 293 294 295 296

        case VIR_DOMAIN_HOSTDEV_SUBSYS_TYPE_USB:
            /* NB: hostdev->missing wasn't previously checked in the
             * case of hotplug, only when starting a domain. Now it is
             * always checked, and the cgroup setup skipped if true.
             */
            if (dev->missing)
                break;
297
            if ((usb = virUSBDeviceNew(usbsrc->bus, usbsrc->device,
298 299 300 301
                                       NULL)) == NULL) {
                goto cleanup;
            }

302
            /* oddly, qemuSetupHostUSBDeviceCgroup doesn't ever
303 304
             * reference the usb object we just created
             */
305
            if (virUSBDeviceFileIterate(usb, qemuSetupHostUSBDeviceCgroup,
306 307 308 309
                                        vm) < 0) {
                goto cleanup;
            }
            break;
310

311
        case VIR_DOMAIN_HOSTDEV_SUBSYS_TYPE_SCSI: {
312 313 314 315 316 317 318 319 320 321 322 323 324 325 326 327 328 329 330
            if (scsisrc->protocol ==
                VIR_DOMAIN_HOSTDEV_SCSI_PROTOCOL_TYPE_ISCSI) {
                virDomainHostdevSubsysSCSIiSCSIPtr iscsisrc = &scsisrc->u.iscsi;
                /* Follow qemuSetupDiskCgroup() and qemuSetImageCgroupInternal()
                 * which does nothing for non local storage
                 */
                VIR_DEBUG("Not updating cgroups for hostdev iSCSI path '%s'",
                          iscsisrc->path);
            } else {
                virDomainHostdevSubsysSCSIHostPtr scsihostsrc =
                    &scsisrc->u.host;
                if ((scsi = virSCSIDeviceNew(NULL,
                                             scsihostsrc->adapter,
                                             scsihostsrc->bus,
                                             scsihostsrc->target,
                                             scsihostsrc->unit,
                                             dev->readonly,
                                             dev->shareable)) == NULL)
                    goto cleanup;
331

332 333 334 335 336
                if (virSCSIDeviceFileIterate(scsi,
                                             qemuSetupHostSCSIDeviceCgroup,
                                             vm) < 0)
                    goto cleanup;
            }
337 338
            break;
        }
339

340 341 342 343 344 345
        default:
            break;
        }
    }

    ret = 0;
346
 cleanup:
347
    virPCIDeviceFree(pci);
348
    virUSBDeviceFree(usb);
349
    virSCSIDeviceFree(scsi);
350 351 352 353 354 355 356 357 358 359
    VIR_FREE(path);
    return ret;
}

int
qemuTeardownHostdevCgroup(virDomainObjPtr vm,
                       virDomainHostdevDefPtr dev)
{
    int ret = -1;
    qemuDomainObjPrivatePtr priv = vm->privateData;
360
    virDomainHostdevSubsysPCIPtr pcisrc = &dev->source.subsys.u.pci;
361 362 363 364 365 366 367 368 369 370 371 372 373 374 375
    virPCIDevicePtr pci = NULL;
    char *path = NULL;

    /* currently this only does something for PCI devices using vfio
     * for device assignment, but it is called for *all* hostdev
     * devices.
     */

    if (!virCgroupHasController(priv->cgroup, VIR_CGROUP_CONTROLLER_DEVICES))
        return 0;

    if (dev->mode == VIR_DOMAIN_HOSTDEV_MODE_SUBSYS) {

        switch (dev->source.subsys.type) {
        case VIR_DOMAIN_HOSTDEV_SUBSYS_TYPE_PCI:
376
            if (pcisrc->backend == VIR_DOMAIN_HOSTDEV_PCI_BACKEND_VFIO) {
377
                int rv;
378

379 380 381 382
                pci = virPCIDeviceNew(pcisrc->addr.domain,
                                      pcisrc->addr.bus,
                                      pcisrc->addr.slot,
                                      pcisrc->addr.function);
383 384 385
                if (!pci)
                    goto cleanup;

386
                if (!(path = virPCIDeviceGetIOMMUGroupDev(pci)))
387 388 389
                    goto cleanup;

                VIR_DEBUG("Cgroup deny %s for PCI device assignment", path);
390
                rv = virCgroupDenyDevicePath(priv->cgroup, path,
391 392
                                             VIR_CGROUP_DEVICE_RWM);
                virDomainAuditCgroupPath(vm, priv->cgroup,
393 394
                                         "deny", path, "rwm", rv == 0);
                if (rv < 0)
395 396 397
                    goto cleanup;
            }
            break;
398 399 400
        case VIR_DOMAIN_HOSTDEV_SUBSYS_TYPE_USB:
            /* nothing to tear down for USB */
            break;
401 402 403 404 405 406
        default:
            break;
        }
    }

    ret = 0;
407
 cleanup:
408 409 410 411 412
    virPCIDeviceFree(pci);
    VIR_FREE(path);
    return ret;
}

413 414 415 416
static int
qemuSetupBlkioCgroup(virDomainObjPtr vm)
{
    qemuDomainObjPrivatePtr priv = vm->privateData;
417
    size_t i;
418 419 420 421 422 423 424 425 426 427 428 429

    if (!virCgroupHasController(priv->cgroup,
                                VIR_CGROUP_CONTROLLER_BLKIO)) {
        if (vm->def->blkio.weight || vm->def->blkio.ndevices) {
            virReportError(VIR_ERR_CONFIG_UNSUPPORTED, "%s",
                           _("Block I/O tuning is not available on this host"));
            return -1;
        } else {
            return 0;
        }
    }

430 431 432
    if (vm->def->blkio.weight != 0 &&
        virCgroupSetBlkioWeight(priv->cgroup, vm->def->blkio.weight) < 0)
        return -1;
433 434 435

    if (vm->def->blkio.ndevices) {
        for (i = 0; i < vm->def->blkio.ndevices; i++) {
436
            virBlkioDevicePtr dev = &vm->def->blkio.devices[i];
437 438 439 440 441 442 443 444 445 446 447 448 449 450 451 452 453 454 455 456 457 458 459
            if (dev->weight &&
                (virCgroupSetBlkioDeviceWeight(priv->cgroup, dev->path,
                                               dev->weight) < 0))
                return -1;

            if (dev->riops &&
                (virCgroupSetBlkioDeviceReadIops(priv->cgroup, dev->path,
                                                 dev->riops) < 0))
                return -1;

            if (dev->wiops &&
                (virCgroupSetBlkioDeviceWriteIops(priv->cgroup, dev->path,
                                                  dev->wiops) < 0))
                return -1;

            if (dev->rbps &&
                (virCgroupSetBlkioDeviceReadBps(priv->cgroup, dev->path,
                                                dev->rbps) < 0))
                return -1;

            if (dev->wbps &&
                (virCgroupSetBlkioDeviceWriteBps(priv->cgroup, dev->path,
                                                 dev->wbps) < 0))
460 461 462 463 464 465 466
                return -1;
        }
    }

    return 0;
}

467

468 469 470 471 472
static int
qemuSetupMemoryCgroup(virDomainObjPtr vm)
{
    qemuDomainObjPrivatePtr priv = vm->privateData;

E
Eric Blake 已提交
473
    if (!virCgroupHasController(priv->cgroup, VIR_CGROUP_CONTROLLER_MEMORY)) {
474 475 476
        if (virMemoryLimitIsSet(vm->def->mem.hard_limit) ||
            virMemoryLimitIsSet(vm->def->mem.soft_limit) ||
            virMemoryLimitIsSet(vm->def->mem.swap_hard_limit)) {
477 478 479
            virReportError(VIR_ERR_CONFIG_UNSUPPORTED, "%s",
                           _("Memory cgroup is not available on this host"));
            return -1;
O
Osier Yang 已提交
480 481
        } else {
            return 0;
482 483 484
        }
    }

485 486 487
    if (virMemoryLimitIsSet(vm->def->mem.hard_limit))
        if (virCgroupSetMemoryHardLimit(priv->cgroup, vm->def->mem.hard_limit) < 0)
            return -1;
488

489 490 491
    if (virMemoryLimitIsSet(vm->def->mem.soft_limit))
        if (virCgroupSetMemorySoftLimit(priv->cgroup, vm->def->mem.soft_limit) < 0)
            return -1;
492

493 494 495
    if (virMemoryLimitIsSet(vm->def->mem.swap_hard_limit))
        if (virCgroupSetMemSwapHardLimit(priv->cgroup, vm->def->mem.swap_hard_limit) < 0)
            return -1;
496 497 498 499 500

    return 0;
}


501 502 503 504 505 506 507
static int
qemuSetupDevicesCgroup(virQEMUDriverPtr driver,
                       virDomainObjPtr vm)
{
    qemuDomainObjPrivatePtr priv = vm->privateData;
    virQEMUDriverConfigPtr cfg = NULL;
    const char *const *deviceACL = NULL;
508
    int rv = -1;
509
    int ret = -1;
510
    size_t i;
511 512 513 514

    if (!virCgroupHasController(priv->cgroup, VIR_CGROUP_CONTROLLER_DEVICES))
        return 0;

515 516 517 518 519
    rv = virCgroupDenyAllDevices(priv->cgroup);
    virDomainAuditCgroup(vm, priv->cgroup, "deny", "all", rv == 0);
    if (rv < 0) {
        if (virLastErrorIsSystemErrno(EPERM)) {
            virResetLastError();
520 521 522 523 524 525 526
            VIR_WARN("Group devices ACL is not accessible, disabling whitelisting");
            return 0;
        }

        goto cleanup;
    }

527
    for (i = 0; i < vm->def->ndisks; i++) {
528 529 530 531
        if (qemuSetupDiskCgroup(vm, vm->def->disks[i]) < 0)
            goto cleanup;
    }

532
    rv = virCgroupAllowDeviceMajor(priv->cgroup, 'c', DEVICE_PTY_MAJOR,
533 534
                                   VIR_CGROUP_DEVICE_RW);
    virDomainAuditCgroupMajor(vm, priv->cgroup, "allow", DEVICE_PTY_MAJOR,
535 536
                              "pty", "rw", rv == 0);
    if (rv < 0)
537 538 539 540 541 542 543 544
        goto cleanup;

    cfg = virQEMUDriverGetConfig(driver);
    deviceACL = cfg->cgroupDeviceACL ?
                (const char *const *)cfg->cgroupDeviceACL :
                defaultDeviceACL;

    if (vm->def->nsounds &&
545
        ((!vm->def->ngraphics && cfg->nogfxAllowHostAudio) ||
546 547
         (vm->def->graphics &&
          ((vm->def->graphics[0]->type == VIR_DOMAIN_GRAPHICS_TYPE_VNC &&
548
           cfg->vncAllowHostAudio) ||
549
           (vm->def->graphics[0]->type == VIR_DOMAIN_GRAPHICS_TYPE_SDL))))) {
550
        rv = virCgroupAllowDeviceMajor(priv->cgroup, 'c', DEVICE_SND_MAJOR,
551 552
                                       VIR_CGROUP_DEVICE_RW);
        virDomainAuditCgroupMajor(vm, priv->cgroup, "allow", DEVICE_SND_MAJOR,
553 554
                                  "sound", "rw", rv == 0);
        if (rv < 0)
555 556 557
            goto cleanup;
    }

558
    for (i = 0; deviceACL[i] != NULL; i++) {
559
        if (!virFileExists(deviceACL[i])) {
N
Nehal J Wani 已提交
560
            VIR_DEBUG("Ignoring non-existent device %s", deviceACL[i]);
561 562 563
            continue;
        }

564
        rv = virCgroupAllowDevicePath(priv->cgroup, deviceACL[i],
565
                                      VIR_CGROUP_DEVICE_RW);
566 567 568
        virDomainAuditCgroupPath(vm, priv->cgroup, "allow", deviceACL[i], "rw", rv == 0);
        if (rv < 0 &&
            !virLastErrorIsSystemErrno(ENOENT))
569 570 571 572 573 574 575 576 577 578 579 580 581 582 583 584 585 586 587 588
            goto cleanup;
    }

    if (virDomainChrDefForeach(vm->def,
                               true,
                               qemuSetupChardevCgroup,
                               vm) < 0)
        goto cleanup;

    if (vm->def->tpm &&
        (qemuSetupTPMCgroup(vm->def,
                            vm->def->tpm,
                            vm) < 0))
        goto cleanup;

    for (i = 0; i < vm->def->nhostdevs; i++) {
        if (qemuSetupHostdevCGroup(vm, vm->def->hostdevs[i]) < 0)
            goto cleanup;
    }

589 590 591
    for (i = 0; i < vm->def->nrngs; i++) {
        if (vm->def->rngs[i]->backend == VIR_DOMAIN_RNG_BACKEND_RANDOM) {
            VIR_DEBUG("Setting Cgroup ACL for RNG device");
592 593
            rv = virCgroupAllowDevicePath(priv->cgroup,
                                          vm->def->rngs[i]->source.file,
594 595
                                          VIR_CGROUP_DEVICE_RW);
            virDomainAuditCgroupPath(vm, priv->cgroup, "allow",
596 597
                                     vm->def->rngs[i]->source.file,
                                     "rw", rv == 0);
598 599 600 601
            if (rv < 0 &&
                !virLastErrorIsSystemErrno(ENOENT))
                goto cleanup;
        }
602 603
    }

604
    ret = 0;
605
 cleanup:
606 607 608 609 610
    virObjectUnref(cfg);
    return ret;
}


611
int
612
qemuSetupCpusetMems(virDomainObjPtr vm)
613
{
614
    virCgroupPtr cgroup_temp = NULL;
615
    qemuDomainObjPrivatePtr priv = vm->privateData;
616
    virDomainNumatuneMemMode mode;
617
    char *mem_mask = NULL;
618 619 620 621 622
    int ret = -1;

    if (!virCgroupHasController(priv->cgroup, VIR_CGROUP_CONTROLLER_CPUSET))
        return 0;

623 624
    if (virDomainNumatuneGetMode(vm->def->numa, -1, &mode) < 0 ||
        mode != VIR_DOMAIN_NUMATUNE_MEM_STRICT)
625 626
        return 0;

627
    if (virDomainNumatuneMaybeFormatNodeset(vm->def->numa,
628
                                            priv->autoNodeset,
629
                                            &mem_mask, -1) < 0)
630
        goto cleanup;
631

632
    if (mem_mask)
J
John Ferlan 已提交
633 634
        if (virCgroupNewThread(priv->cgroup, VIR_CGROUP_THREAD_EMULATOR, 0,
                               false, &cgroup_temp) < 0 ||
635
            virCgroupSetCpusetMems(cgroup_temp, mem_mask) < 0)
636
            goto cleanup;
637

638 639 640
    ret = 0;
 cleanup:
    VIR_FREE(mem_mask);
641
    virCgroupFree(&cgroup_temp);
642 643 644 645 646
    return ret;
}


static int
647
qemuSetupCpusetCgroup(virDomainObjPtr vm)
648 649 650 651 652 653
{
    qemuDomainObjPrivatePtr priv = vm->privateData;

    if (!virCgroupHasController(priv->cgroup, VIR_CGROUP_CONTROLLER_CPUSET))
        return 0;

654 655 656
    if (virCgroupSetCpusetMemoryMigrate(priv->cgroup, true) < 0)
        return -1;

657
    return 0;
658 659 660
}


661
static int
662 663
qemuSetupCpuCgroup(virQEMUDriverPtr driver,
                   virDomainObjPtr vm)
664 665
{
    qemuDomainObjPrivatePtr priv = vm->privateData;
666 667 668 669
    virObjectEventPtr event = NULL;
    virTypedParameterPtr eventParams = NULL;
    int eventNparams = 0;
    int eventMaxparams = 0;
670 671

    if (!virCgroupHasController(priv->cgroup, VIR_CGROUP_CONTROLLER_CPU)) {
672
       if (vm->def->cputune.sharesSpecified) {
673 674 675 676 677 678 679 680
           virReportError(VIR_ERR_CONFIG_UNSUPPORTED, "%s",
                          _("CPU tuning is not available on this host"));
           return -1;
       } else {
           return 0;
       }
    }

681 682 683 684 685 686 687
    if (vm->def->cputune.sharesSpecified) {
        unsigned long long val;
        if (virCgroupSetCpuShares(priv->cgroup, vm->def->cputune.shares) < 0)
            return -1;

        if (virCgroupGetCpuShares(priv->cgroup, &val) < 0)
            return -1;
688 689 690 691
        if (vm->def->cputune.shares != val) {
            vm->def->cputune.shares = val;
            if (virTypedParamsAddULLong(&eventParams, &eventNparams,
                                        &eventMaxparams,
692
                                        VIR_DOMAIN_TUNABLE_CPU_CPU_SHARES,
693 694 695 696 697 698 699
                                        val) < 0)
                return -1;

            event = virDomainEventTunableNewFromObj(vm, eventParams, eventNparams);
        }

        if (event)
700
            qemuDomainEventQueue(driver, event);
701
    }
702 703 704 705 706

    return 0;
}


707
static int
708
qemuInitCgroup(virQEMUDriverPtr driver,
709 710 711
               virDomainObjPtr vm,
               size_t nnicindexes,
               int *nicindexes)
712
{
713
    int ret = -1;
714 715 716
    qemuDomainObjPrivatePtr priv = vm->privateData;
    virQEMUDriverConfigPtr cfg = virQEMUDriverGetConfig(driver);

717
    if (!virQEMUDriverIsPrivileged(driver))
718 719
        goto done;

720 721 722
    if (!virCgroupAvailable())
        goto done;

723 724
    virCgroupFree(&priv->cgroup);

725
    if (!vm->def->resource) {
726 727
        virDomainResourceDefPtr res;

728
        if (VIR_ALLOC(res) < 0)
729
            goto cleanup;
730

731
        if (VIR_STRDUP(res->partition, "/machine") < 0) {
732 733 734 735 736
            VIR_FREE(res);
            goto cleanup;
        }

        vm->def->resource = res;
737 738
    }

739 740 741 742 743 744
    if (vm->def->resource->partition[0] != '/') {
        virReportError(VIR_ERR_CONFIG_UNSUPPORTED,
                       _("Resource partition '%s' must start with '/'"),
                       vm->def->resource->partition);
        goto cleanup;
    }
745 746 747

    if (virCgroupNewMachine(vm->def->name,
                            "qemu",
748
                            true,
749 750 751 752
                            vm->def->uuid,
                            NULL,
                            vm->pid,
                            false,
753
                            nnicindexes, nicindexes,
754 755 756
                            vm->def->resource->partition,
                            cfg->cgroupControllers,
                            &priv->cgroup) < 0) {
757 758
        if (virCgroupNewIgnoreError())
            goto done;
759

760 761
        goto cleanup;
    }
762

763
 done:
764
    ret = 0;
765
 cleanup:
766 767 768
    virObjectUnref(cfg);
    return ret;
}
769

770 771 772
static void
qemuRestoreCgroupState(virDomainObjPtr vm)
{
773
    char *mem_mask = NULL;
774
    char *nodeset = NULL;
775 776
    int empty = -1;
    qemuDomainObjPrivatePtr priv = vm->privateData;
777
    size_t i = 0;
778
    virBitmapPtr all_nodes;
779
    virCgroupPtr cgroup_temp = NULL;
780 781 782 783 784 785 786 787

    if (!(all_nodes = virNumaGetHostNodeset()))
        goto error;

    if (!(mem_mask = virBitmapFormat(all_nodes)))
        goto error;

    if ((empty = virCgroupHasEmptyTasks(priv->cgroup,
788
                                        VIR_CGROUP_CONTROLLER_CPUSET)) <= 0)
789 790 791 792 793
        goto error;

    if (virCgroupSetCpusetMems(priv->cgroup, mem_mask) < 0)
        goto error;

794
    for (i = 0; i < priv->nvcpupids; i++) {
J
John Ferlan 已提交
795 796
        if (virCgroupNewThread(priv->cgroup, VIR_CGROUP_THREAD_VCPU, i,
                               false, &cgroup_temp) < 0 ||
797 798 799 800 801
            virCgroupSetCpusetMemoryMigrate(cgroup_temp, true) < 0 ||
            virCgroupGetCpusetMems(cgroup_temp, &nodeset) < 0 ||
            virCgroupSetCpusetMems(cgroup_temp, nodeset) < 0)
            goto cleanup;

802
        VIR_FREE(nodeset);
803 804 805
        virCgroupFree(&cgroup_temp);
    }

806 807 808
    for (i = 0; i < vm->def->niothreadids; i++) {
        if (virCgroupNewThread(priv->cgroup, VIR_CGROUP_THREAD_IOTHREAD,
                               vm->def->iothreadids[i]->iothread_id,
J
John Ferlan 已提交
809
                               false, &cgroup_temp) < 0 ||
810 811 812 813 814
            virCgroupSetCpusetMemoryMigrate(cgroup_temp, true) < 0 ||
            virCgroupGetCpusetMems(cgroup_temp, &nodeset) < 0 ||
            virCgroupSetCpusetMems(cgroup_temp, nodeset) < 0)
            goto cleanup;

815
        VIR_FREE(nodeset);
816 817 818
        virCgroupFree(&cgroup_temp);
    }

J
John Ferlan 已提交
819 820
    if (virCgroupNewThread(priv->cgroup, VIR_CGROUP_THREAD_EMULATOR, 0,
                           false, &cgroup_temp) < 0 ||
821 822 823 824 825
        virCgroupSetCpusetMemoryMigrate(cgroup_temp, true) < 0 ||
        virCgroupGetCpusetMems(cgroup_temp, &nodeset) < 0 ||
        virCgroupSetCpusetMems(cgroup_temp, nodeset) < 0)
        goto cleanup;

826 827
 cleanup:
    VIR_FREE(mem_mask);
828
    VIR_FREE(nodeset);
829
    virBitmapFree(all_nodes);
830
    virCgroupFree(&cgroup_temp);
831 832 833 834 835 836 837
    return;

 error:
    virResetLastError();
    VIR_DEBUG("Couldn't restore cgroups to meaningful state");
    goto cleanup;
}
838 839 840 841 842 843 844 845 846

int
qemuConnectCgroup(virQEMUDriverPtr driver,
                  virDomainObjPtr vm)
{
    virQEMUDriverConfigPtr cfg = virQEMUDriverGetConfig(driver);
    qemuDomainObjPrivatePtr priv = vm->privateData;
    int ret = -1;

847
    if (!virQEMUDriverIsPrivileged(driver))
848 849 850 851 852 853 854
        goto done;

    if (!virCgroupAvailable())
        goto done;

    virCgroupFree(&priv->cgroup);

855 856 857
    if (virCgroupNewDetectMachine(vm->def->name,
                                  "qemu",
                                  vm->pid,
858
                                  cfg->cgroupControllers,
859
                                  &priv->cgroup) < 0)
860
        goto cleanup;
861

862 863
    qemuRestoreCgroupState(vm);

864
 done:
865
    ret = 0;
866
 cleanup:
867
    virObjectUnref(cfg);
868
    return ret;
869 870
}

871 872
int
qemuSetupCgroup(virQEMUDriverPtr driver,
873 874 875
                virDomainObjPtr vm,
                size_t nnicindexes,
                int *nicindexes)
876
{
877
    qemuDomainObjPrivatePtr priv = vm->privateData;
878
    int ret = -1;
879

880 881 882 883 884 885
    if (!vm->pid) {
        virReportError(VIR_ERR_INTERNAL_ERROR, "%s",
                       _("Cannot setup cgroups until process is started"));
        return -1;
    }

886
    if (qemuInitCgroup(driver, vm, nnicindexes, nicindexes) < 0)
887
        return -1;
888

889
    if (!priv->cgroup)
890
        return 0;
891

892 893
    if (qemuSetupDevicesCgroup(driver, vm) < 0)
        goto cleanup;
894

895 896
    if (qemuSetupBlkioCgroup(vm) < 0)
        goto cleanup;
897

898 899
    if (qemuSetupMemoryCgroup(vm) < 0)
        goto cleanup;
900

901
    if (qemuSetupCpuCgroup(driver, vm) < 0)
902
        goto cleanup;
903

904
    if (qemuSetupCpusetCgroup(vm) < 0)
905
        goto cleanup;
906

907
    ret = 0;
908
 cleanup:
909
    return ret;
910 911
}

912 913 914 915
int
qemuSetupCgroupVcpuBW(virCgroupPtr cgroup,
                      unsigned long long period,
                      long long quota)
916 917 918 919 920 921 922 923
{
    unsigned long long old_period;

    if (period == 0 && quota == 0)
        return 0;

    if (period) {
        /* get old period, and we can rollback if set quota failed */
924
        if (virCgroupGetCpuCfsPeriod(cgroup, &old_period) < 0)
925 926
            return -1;

927
        if (virCgroupSetCpuCfsPeriod(cgroup, period) < 0)
928 929 930
            return -1;
    }

931 932 933
    if (quota &&
        virCgroupSetCpuCfsQuota(cgroup, quota) < 0)
        goto error;
934 935 936

    return 0;

937
 error:
938
    if (period) {
939 940 941 942 943 944
        virErrorPtr saved = virSaveLastError();
        ignore_value(virCgroupSetCpuCfsPeriod(cgroup, old_period));
        if (saved) {
            virSetError(saved);
            virFreeError(saved);
        }
945 946 947 948 949
    }

    return -1;
}

950

951
int
952 953
qemuSetupCgroupCpusetCpus(virCgroupPtr cgroup,
                          virBitmapPtr cpumask)
954
{
955
    int ret = -1;
956 957
    char *new_cpus = NULL;

958
    if (!(new_cpus = virBitmapFormat(cpumask)))
959 960
        goto cleanup;

961
    if (virCgroupSetCpusetCpus(cgroup, new_cpus) < 0)
962 963
        goto cleanup;

964
    ret = 0;
965
 cleanup:
966
    VIR_FREE(new_cpus);
967
    return ret;
968 969
}

970 971
int
qemuSetupCgroupForVcpu(virDomainObjPtr vm)
972 973 974
{
    virCgroupPtr cgroup_vcpu = NULL;
    qemuDomainObjPrivatePtr priv = vm->privateData;
975
    virDomainDefPtr def = vm->def;
976
    size_t i, j;
977 978
    unsigned long long period = vm->def->cputune.period;
    long long quota = vm->def->cputune.quota;
979
    char *mem_mask = NULL;
980
    virDomainNumatuneMemMode mem_mode;
981

982
    if ((period || quota) &&
983
        !virCgroupHasController(priv->cgroup, VIR_CGROUP_CONTROLLER_CPU)) {
984 985
        virReportError(VIR_ERR_CONFIG_UNSUPPORTED, "%s",
                       _("cgroup cpu is required for scheduler tuning"));
H
Hu Tao 已提交
986 987 988
        return -1;
    }

989 990 991 992 993 994 995 996 997
    /*
     * If CPU cgroup controller is not initialized here, then we need
     * neither period nor quota settings.  And if CPUSET controller is
     * not initialized either, then there's nothing to do anyway.
     */
    if (!virCgroupHasController(priv->cgroup, VIR_CGROUP_CONTROLLER_CPU) &&
        !virCgroupHasController(priv->cgroup, VIR_CGROUP_CONTROLLER_CPUSET))
        return 0;

998
    /* We are trying to setup cgroups for CPU pinning, which can also be done
999
     * with virProcessSetAffinity, thus the lack of cgroups is not fatal here.
1000
     */
1001
    if (priv->cgroup == NULL)
1002 1003
        return 0;

1004
    if (priv->nvcpupids == 0 || priv->vcpupids[0] == vm->pid) {
1005
        /* If we don't know VCPU<->PID mapping or all vcpu runs in the same
W
Wen Congyang 已提交
1006
         * thread, we cannot control each vcpu.
1007
         */
1008
        return 0;
1009 1010
    }

1011 1012
    if (virDomainNumatuneGetMode(vm->def->numa, -1, &mem_mode) == 0 &&
        mem_mode == VIR_DOMAIN_NUMATUNE_MEM_STRICT &&
1013
        virDomainNumatuneMaybeFormatNodeset(vm->def->numa,
1014 1015 1016 1017
                                            priv->autoNodeset,
                                            &mem_mask, -1) < 0)
        goto cleanup;

1018
    for (i = 0; i < priv->nvcpupids; i++) {
1019
        virCgroupFree(&cgroup_vcpu);
J
John Ferlan 已提交
1020 1021
        if (virCgroupNewThread(priv->cgroup, VIR_CGROUP_THREAD_VCPU, i,
                               true, &cgroup_vcpu) < 0)
1022 1023 1024
            goto cleanup;

        /* move the thread for vcpu to sub dir */
1025
        if (virCgroupAddTask(cgroup_vcpu, priv->vcpupids[i]) < 0)
1026 1027
            goto cleanup;

1028 1029 1030 1031
        if (mem_mask &&
            virCgroupSetCpusetMems(cgroup_vcpu, mem_mask) < 0)
            goto cleanup;

1032
        if (period || quota) {
H
Hu Tao 已提交
1033 1034
            if (qemuSetupCgroupVcpuBW(cgroup_vcpu, period, quota) < 0)
                goto cleanup;
1035 1036
        }

1037
        /* Set vcpupin in cgroup if vcpupin xml is provided */
1038
        if (virCgroupHasController(priv->cgroup, VIR_CGROUP_CONTROLLER_CPUSET)) {
1039
            virBitmapPtr cpumap = NULL;
M
Martin Kletzander 已提交
1040

1041 1042 1043 1044 1045
            /* try to use the default cpu maps */
            if (vm->def->placement_mode == VIR_DOMAIN_CPU_PLACEMENT_MODE_AUTO)
                cpumap = priv->autoCpuset;
            else
                cpumap = vm->def->cpumask;
M
Martin Kletzander 已提交
1046

1047 1048 1049 1050 1051 1052
            /* lookup a more specific pinning info */
            for (j = 0; j < def->cputune.nvcpupin; j++) {
                if (def->cputune.vcpupin[j]->id == i) {
                    cpumap = def->cputune.vcpupin[j]->cpumask;
                    break;
                }
M
Martin Kletzander 已提交
1053
            }
1054 1055 1056 1057

            if (!cpumap)
                continue;

1058
            if (qemuSetupCgroupCpusetCpus(cgroup_vcpu, cpumap) < 0)
1059
                goto cleanup;
M
Martin Kletzander 已提交
1060
        }
1061
    }
1062
    virCgroupFree(&cgroup_vcpu);
1063
    VIR_FREE(mem_mask);
1064 1065 1066

    return 0;

1067
 cleanup:
1068 1069 1070 1071
    if (cgroup_vcpu) {
        virCgroupRemove(cgroup_vcpu);
        virCgroupFree(&cgroup_vcpu);
    }
1072
    VIR_FREE(mem_mask);
1073

1074 1075 1076
    return -1;
}

1077
int
1078
qemuSetupCgroupForEmulator(virDomainObjPtr vm)
1079
{
1080
    virBitmapPtr cpumask = NULL;
1081
    virCgroupPtr cgroup_emulator = NULL;
1082
    virDomainDefPtr def = vm->def;
1083
    qemuDomainObjPrivatePtr priv = vm->privateData;
1084 1085
    unsigned long long period = vm->def->cputune.emulator_period;
    long long quota = vm->def->cputune.emulator_quota;
1086

1087
    if ((period || quota) &&
1088
        !virCgroupHasController(priv->cgroup, VIR_CGROUP_CONTROLLER_CPU)) {
1089 1090 1091 1092 1093
        virReportError(VIR_ERR_CONFIG_UNSUPPORTED, "%s",
                       _("cgroup cpu is required for scheduler tuning"));
        return -1;
    }

1094 1095 1096 1097 1098 1099 1100 1101 1102
    /*
     * If CPU cgroup controller is not initialized here, then we need
     * neither period nor quota settings.  And if CPUSET controller is
     * not initialized either, then there's nothing to do anyway.
     */
    if (!virCgroupHasController(priv->cgroup, VIR_CGROUP_CONTROLLER_CPU) &&
        !virCgroupHasController(priv->cgroup, VIR_CGROUP_CONTROLLER_CPUSET))
        return 0;

1103
    if (priv->cgroup == NULL)
1104 1105
        return 0; /* Not supported, so claim success */

J
John Ferlan 已提交
1106 1107
    if (virCgroupNewThread(priv->cgroup, VIR_CGROUP_THREAD_EMULATOR, 0,
                           true, &cgroup_emulator) < 0)
1108 1109
        goto cleanup;

1110
    if (virCgroupMoveTask(priv->cgroup, cgroup_emulator) < 0)
1111
        goto cleanup;
1112

1113
    if (def->cputune.emulatorpin)
1114
        cpumask = def->cputune.emulatorpin;
1115 1116
    else if (def->placement_mode == VIR_DOMAIN_CPU_PLACEMENT_MODE_AUTO)
        cpumask = priv->autoCpuset;
1117
    else if (def->cpumask)
1118 1119 1120
        cpumask = def->cpumask;

    if (cpumask) {
1121
        if (virCgroupHasController(priv->cgroup, VIR_CGROUP_CONTROLLER_CPUSET) &&
1122
            qemuSetupCgroupCpusetCpus(cgroup_emulator, cpumask) < 0)
1123
            goto cleanup;
H
Hu Tao 已提交
1124
    }
1125

1126
    if (period || quota) {
1127 1128 1129 1130
        if (virCgroupHasController(priv->cgroup, VIR_CGROUP_CONTROLLER_CPU) &&
            qemuSetupCgroupVcpuBW(cgroup_emulator, period,
                                  quota) < 0)
            goto cleanup;
1131 1132
    }

1133 1134 1135
    virCgroupFree(&cgroup_emulator);
    return 0;

1136
 cleanup:
1137 1138 1139 1140 1141
    if (cgroup_emulator) {
        virCgroupRemove(cgroup_emulator);
        virCgroupFree(&cgroup_emulator);
    }

1142
    return -1;
1143
}
1144

1145 1146 1147 1148 1149 1150
int
qemuSetupCgroupForIOThreads(virDomainObjPtr vm)
{
    virCgroupPtr cgroup_iothread = NULL;
    qemuDomainObjPrivatePtr priv = vm->privateData;
    virDomainDefPtr def = vm->def;
1151
    size_t i;
1152 1153
    unsigned long long period = vm->def->cputune.period;
    long long quota = vm->def->cputune.quota;
1154
    char *mem_mask = NULL;
1155
    virDomainNumatuneMemMode mem_mode;
1156 1157 1158 1159 1160 1161 1162 1163 1164 1165 1166 1167 1168 1169 1170 1171 1172 1173 1174 1175 1176 1177 1178

    if ((period || quota) &&
        !virCgroupHasController(priv->cgroup, VIR_CGROUP_CONTROLLER_CPU)) {
        virReportError(VIR_ERR_CONFIG_UNSUPPORTED, "%s",
                       _("cgroup cpu is required for scheduler tuning"));
        return -1;
    }

    /*
     * If CPU cgroup controller is not initialized here, then we need
     * neither period nor quota settings.  And if CPUSET controller is
     * not initialized either, then there's nothing to do anyway.
     */
    if (!virCgroupHasController(priv->cgroup, VIR_CGROUP_CONTROLLER_CPU) &&
        !virCgroupHasController(priv->cgroup, VIR_CGROUP_CONTROLLER_CPUSET))
        return 0;

    /* We are trying to setup cgroups for CPU pinning, which can also be done
     * with virProcessSetAffinity, thus the lack of cgroups is not fatal here.
     */
    if (priv->cgroup == NULL)
        return 0;

1179 1180
    if (virDomainNumatuneGetMode(vm->def->numa, -1, &mem_mode) == 0 &&
        mem_mode == VIR_DOMAIN_NUMATUNE_MEM_STRICT &&
1181
        virDomainNumatuneMaybeFormatNodeset(vm->def->numa,
1182 1183 1184 1185
                                            priv->autoNodeset,
                                            &mem_mask, -1) < 0)
        goto cleanup;

1186
    for (i = 0; i < def->niothreadids; i++) {
1187 1188 1189
        /* IOThreads are numbered 1..n, although the array is 0..n-1,
         * so we will account for that here
         */
1190 1191
        if (virCgroupNewThread(priv->cgroup, VIR_CGROUP_THREAD_IOTHREAD,
                               def->iothreadids[i]->iothread_id,
J
John Ferlan 已提交
1192
                               true, &cgroup_iothread) < 0)
1193 1194 1195
            goto cleanup;

        /* move the thread for iothread to sub dir */
1196 1197
        if (virCgroupAddTask(cgroup_iothread,
                             def->iothreadids[i]->thread_id) < 0)
1198 1199 1200 1201 1202 1203 1204
            goto cleanup;

        if (period || quota) {
            if (qemuSetupCgroupVcpuBW(cgroup_iothread, period, quota) < 0)
                goto cleanup;
        }

1205 1206 1207 1208
        if (mem_mask &&
            virCgroupSetCpusetMems(cgroup_iothread, mem_mask) < 0)
            goto cleanup;

1209 1210 1211
        /* Set iothreadpin in cgroup if iothreadpin xml is provided */
        if (virCgroupHasController(priv->cgroup,
                                   VIR_CGROUP_CONTROLLER_CPUSET)) {
1212
            virBitmapPtr cpumask = NULL;
1213

1214 1215 1216
            if (def->iothreadids[i]->cpumask)
                cpumask = def->iothreadids[i]->cpumask;
            else if (def->placement_mode == VIR_DOMAIN_CPU_PLACEMENT_MODE_AUTO)
1217 1218 1219
                cpumask = priv->autoCpuset;
            else
                cpumask = def->cpumask;
1220

1221
            if (cpumask &&
1222
                qemuSetupCgroupCpusetCpus(cgroup_iothread, cpumask) < 0)
1223
                goto cleanup;
1224 1225 1226 1227
        }

        virCgroupFree(&cgroup_iothread);
    }
1228
    VIR_FREE(mem_mask);
1229 1230 1231 1232 1233 1234 1235 1236

    return 0;

 cleanup:
    if (cgroup_iothread) {
        virCgroupRemove(cgroup_iothread);
        virCgroupFree(&cgroup_iothread);
    }
1237
    VIR_FREE(mem_mask);
1238 1239 1240 1241

    return -1;
}

1242
int
1243 1244
qemuRemoveCgroup(virQEMUDriverPtr driver,
                 virDomainObjPtr vm)
1245
{
1246
    qemuDomainObjPrivatePtr priv = vm->privateData;
1247

1248
    if (priv->cgroup == NULL)
1249 1250
        return 0; /* Not supported, so claim success */

1251 1252
    if (virCgroupTerminateMachine(vm->def->name,
                                  "qemu",
1253
                                  virQEMUDriverIsPrivileged(driver)) < 0) {
1254 1255 1256 1257
        if (!virCgroupNewIgnoreError())
            VIR_DEBUG("Failed to terminate cgroup for %s", vm->def->name);
    }

1258
    return virCgroupRemove(priv->cgroup);
1259 1260
}

1261 1262
int
qemuAddToCgroup(virDomainObjPtr vm)
1263
{
1264
    qemuDomainObjPrivatePtr priv = vm->privateData;
1265

1266
    if (priv->cgroup == NULL)
1267 1268
        return 0; /* Not supported, so claim success */

1269
    return 0;
1270
}