storage_backend_iscsi.c 24.1 KB
Newer Older
1 2 3
/*
 * storage_backend_iscsi.c: storage backend for iSCSI handling
 *
E
Eric Blake 已提交
4
 * Copyright (C) 2007-2008, 2010-2012 Red Hat, Inc.
5 6 7 8 9 10 11 12 13 14 15 16 17
 * Copyright (C) 2007-2008 Daniel P. Berrange
 *
 * This library is free software; you can redistribute it and/or
 * modify it under the terms of the GNU Lesser General Public
 * License as published by the Free Software Foundation; either
 * version 2.1 of the License, or (at your option) any later version.
 *
 * This library is distributed in the hope that it will be useful,
 * but WITHOUT ANY WARRANTY; without even the implied warranty of
 * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the GNU
 * Lesser General Public License for more details.
 *
 * You should have received a copy of the GNU Lesser General Public
18
 * License along with this library.  If not, see
O
Osier Yang 已提交
19
 * <http://www.gnu.org/licenses/>.
20 21 22 23 24 25
 *
 * Author: Daniel P. Berrange <berrange@redhat.com>
 */

#include <config.h>

26
#include <dirent.h>
27 28 29 30 31 32 33 34 35
#include <sys/socket.h>
#include <netdb.h>
#include <sys/types.h>
#include <sys/wait.h>
#include <string.h>
#include <stdio.h>
#include <regex.h>
#include <fcntl.h>
#include <unistd.h>
D
David Allan 已提交
36
#include <sys/stat.h>
37

38
#include "virerror.h"
39
#include "storage_backend_scsi.h"
40
#include "storage_backend_iscsi.h"
41
#include "viralloc.h"
42
#include "virlog.h"
E
Eric Blake 已提交
43
#include "virfile.h"
44
#include "vircommand.h"
45
#include "virrandom.h"
46
#include "virstring.h"
47

48 49
#define VIR_FROM_THIS VIR_FROM_STORAGE

50
static int
51
virStorageBackendISCSITargetIP(const char *hostname,
52 53 54 55 56 57 58
                               char *ipaddr,
                               size_t ipaddrlen)
{
    struct addrinfo hints;
    struct addrinfo *result = NULL;
    int ret;

59
    memset(&hints, 0, sizeof(hints));
60 61 62 63 64 65 66
    hints.ai_flags = AI_ADDRCONFIG;
    hints.ai_family = AF_INET;
    hints.ai_socktype = SOCK_STREAM;
    hints.ai_protocol = 0;

    ret = getaddrinfo(hostname, NULL, &hints, &result);
    if (ret != 0) {
67 68 69
        virReportError(VIR_ERR_INTERNAL_ERROR,
                       _("host lookup failed %s"),
                       gai_strerror(ret));
70 71 72 73
        return -1;
    }

    if (result == NULL) {
74 75 76
        virReportError(VIR_ERR_INTERNAL_ERROR,
                       _("no IP address for target %s"),
                       hostname);
77 78 79 80 81 82
        return -1;
    }

    if (getnameinfo(result->ai_addr, result->ai_addrlen,
                    ipaddr, ipaddrlen, NULL, 0,
                    NI_NUMERICHOST) < 0) {
83 84 85
        virReportError(VIR_ERR_INTERNAL_ERROR,
                       _("cannot format ip addr for %s"),
                       hostname);
86 87 88 89 90 91 92 93
        freeaddrinfo(result);
        return -1;
    }

    freeaddrinfo(result);
    return 0;
}

94 95 96 97 98 99
static char *
virStorageBackendISCSIPortal(virStoragePoolSourcePtr source)
{
    char ipaddr[NI_MAXHOST];
    char *portal;

100
    if (source->nhost != 1) {
101 102
        virReportError(VIR_ERR_CONFIG_UNSUPPORTED, "%s",
                       _("Expected exactly 1 host for the storage pool"));
103 104 105 106
        return NULL;
    }

    if (virStorageBackendISCSITargetIP(source->hosts[0].name,
107 108 109 110
                                       ipaddr, sizeof(ipaddr)) < 0)
        return NULL;

    if (virAsprintf(&portal, "%s:%d,1", ipaddr,
111 112
                    source->hosts[0].port ?
                    source->hosts[0].port : 3260) < 0) {
113 114 115 116 117 118 119 120
        virReportOOMError();
        return NULL;
    }

    return portal;
}


121
static int
122
virStorageBackendISCSIExtractSession(virStoragePoolObjPtr pool,
123 124 125 126 127
                                     char **const groups,
                                     void *data)
{
    char **session = data;

128 129
    if (STREQ(groups[1], pool->def->source.devices[0].path))
        return VIR_STRDUP(*session, groups[0]);
130 131 132 133
    return 0;
}

static char *
134
virStorageBackendISCSISession(virStoragePoolObjPtr pool,
135
                              int probe)
136 137
{
    /*
138
     * # iscsiadm --mode session
139 140 141 142 143 144 145 146 147 148 149 150 151
     * tcp: [1] 192.168.122.170:3260,1 demo-tgt-b
     * tcp: [2] 192.168.122.170:3260,1 demo-tgt-a
     *
     * Pull out 2nd and 4th fields
     */
    const char *regexes[] = {
        "^tcp:\\s+\\[(\\S+)\\]\\s+\\S+\\s+(\\S+)\\s*$"
    };
    int vars[] = {
        2,
    };
    char *session = NULL;

152 153
    virCommandPtr cmd = virCommandNewArgList(ISCSIADM, "--mode", "session", NULL);

154 155 156 157
    /* Note that we ignore the exitstatus.  Older versions of iscsiadm tools
     * returned an exit status of > 0, even if they succeeded.  We will just
     * rely on whether session got filled in properly.
     */
158
    if (virStorageBackendRunProgRegex(pool,
159
                                      cmd,
160 161 162 163
                                      1,
                                      regexes,
                                      vars,
                                      virStorageBackendISCSIExtractSession,
164
                                      &session, NULL) < 0)
165
        goto cleanup;
166

167 168
    if (session == NULL &&
        !probe) {
169 170
        virReportError(VIR_ERR_INTERNAL_ERROR,
                       "%s", _("cannot find session"));
171
        goto cleanup;
172 173
    }

174 175
cleanup:
    virCommandFree(cmd);
176 177 178
    return session;
}

D
David Allan 已提交
179 180 181 182

#define LINE_SIZE 4096

static int
183
virStorageBackendIQNFound(const char *initiatoriqn,
D
David Allan 已提交
184 185 186 187 188
                          char **ifacename)
{
    int ret = IQN_MISSING, fd = -1;
    char ebuf[64];
    FILE *fp = NULL;
E
Eric Blake 已提交
189
    char *line = NULL, *newline = NULL, *iqn = NULL, *token = NULL;
190 191
    virCommandPtr cmd = virCommandNewArgList(ISCSIADM,
                                             "--mode", "iface", NULL);
D
David Allan 已提交
192 193 194

    if (VIR_ALLOC_N(line, LINE_SIZE) != 0) {
        ret = IQN_ERROR;
195 196 197
        virReportError(VIR_ERR_INTERNAL_ERROR,
                       _("Could not allocate memory for output of '%s'"),
                       ISCSIADM);
D
David Allan 已提交
198 199 200 201 202
        goto out;
    }

    memset(line, 0, LINE_SIZE);

203 204
    virCommandSetOutputFD(cmd, &fd);
    if (virCommandRunAsync(cmd, NULL) < 0) {
D
David Allan 已提交
205 206 207 208
        ret = IQN_ERROR;
        goto out;
    }

209
    if ((fp = VIR_FDOPEN(fd, "r")) == NULL) {
210 211 212 213
        virReportError(VIR_ERR_INTERNAL_ERROR,
                       _("Failed to open stream for file descriptor "
                         "when reading output from '%s': '%s'"),
                       ISCSIADM, virStrerror(errno, ebuf, sizeof(ebuf)));
D
David Allan 已提交
214 215 216 217 218 219 220 221
        ret = IQN_ERROR;
        goto out;
    }

    while (fgets(line, LINE_SIZE, fp) != NULL) {
        newline = strrchr(line, '\n');
        if (newline == NULL) {
            ret = IQN_ERROR;
222 223 224 225
            virReportError(VIR_ERR_INTERNAL_ERROR,
                           _("Unexpected line > %d characters "
                             "when parsing output of '%s'"),
                           LINE_SIZE, ISCSIADM);
D
David Allan 已提交
226 227 228 229 230 231 232 233 234 235
            goto out;
        }
        *newline = '\0';

        iqn = strrchr(line, ',');
        if (iqn == NULL) {
            continue;
        }
        iqn++;

236
        if (STREQ(iqn, initiatoriqn)) {
E
Eric Blake 已提交
237 238 239
            token = strchr(line, ' ');
            if (!token) {
                ret = IQN_ERROR;
240 241 242
                virReportError(VIR_ERR_INTERNAL_ERROR,
                               _("Missing space when parsing output "
                                 "of '%s'"), ISCSIADM);
E
Eric Blake 已提交
243 244
                goto out;
            }
245
            if (VIR_STRNDUP(*ifacename, line, token - line) < 0) {
D
David Allan 已提交
246 247 248 249 250 251 252 253 254
                ret = IQN_ERROR;
                goto out;
            }
            VIR_DEBUG("Found interface '%s' with IQN '%s'", *ifacename, iqn);
            ret = IQN_FOUND;
            break;
        }
    }

255 256 257
    if (virCommandWait(cmd, NULL) < 0)
        ret = IQN_ERROR;

D
David Allan 已提交
258 259
out:
    if (ret == IQN_MISSING) {
260
        VIR_DEBUG("Could not find interface with IQN '%s'", iqn);
D
David Allan 已提交
261 262 263
    }

    VIR_FREE(line);
264 265
    VIR_FORCE_FCLOSE(fp);
    VIR_FORCE_CLOSE(fd);
266
    virCommandFree(cmd);
D
David Allan 已提交
267 268 269 270 271 272

    return ret;
}


static int
273
virStorageBackendCreateIfaceIQN(const char *initiatoriqn,
274
                                char **ifacename)
D
David Allan 已提交
275 276
{
    int ret = -1, exitstatus = -1;
277 278
    char *temp_ifacename;
    virCommandPtr cmd = NULL;
D
David Allan 已提交
279

280 281 282 283 284 285
    if (virAsprintf(&temp_ifacename,
                    "libvirt-iface-%08llx",
                    (unsigned long long)virRandomBits(30)) < 0) {
        virReportOOMError();
        return -1;
    }
D
David Allan 已提交
286 287

    VIR_DEBUG("Attempting to create interface '%s' with IQN '%s'",
288
              temp_ifacename, initiatoriqn);
D
David Allan 已提交
289

290 291 292 293 294
    cmd = virCommandNewArgList(ISCSIADM,
                               "--mode", "iface",
                               "--interface", temp_ifacename,
                               "--op", "new",
                               NULL);
D
David Allan 已提交
295 296 297 298
    /* Note that we ignore the exitstatus.  Older versions of iscsiadm
     * tools returned an exit status of > 0, even if they succeeded.
     * We will just rely on whether the interface got created
     * properly. */
299
    if (virCommandRun(cmd, &exitstatus) < 0) {
300 301 302
        virReportError(VIR_ERR_INTERNAL_ERROR,
                       _("Failed to run command '%s' to create new iscsi interface"),
                       ISCSIADM);
303
        goto cleanup;
D
David Allan 已提交
304
    }
305
    virCommandFree(cmd);
D
David Allan 已提交
306

307 308 309 310 311 312 313 314
    cmd = virCommandNewArgList(ISCSIADM,
                               "--mode", "iface",
                               "--interface", temp_ifacename,
                               "--op", "update",
                               "--name", "iface.initiatorname",
                               "--value",
                               initiatoriqn,
                               NULL);
D
David Allan 已提交
315 316 317
    /* Note that we ignore the exitstatus.  Older versions of iscsiadm tools
     * returned an exit status of > 0, even if they succeeded.  We will just
     * rely on whether iface file got updated properly. */
318
    if (virCommandRun(cmd, &exitstatus) < 0) {
319 320 321
        virReportError(VIR_ERR_INTERNAL_ERROR,
                       _("Failed to run command '%s' to update iscsi interface with IQN '%s'"),
                       ISCSIADM, initiatoriqn);
322
        goto cleanup;
D
David Allan 已提交
323 324 325
    }

    /* Check again to make sure the interface was created. */
326
    if (virStorageBackendIQNFound(initiatoriqn, ifacename) != IQN_FOUND) {
D
David Allan 已提交
327 328
        VIR_DEBUG("Failed to find interface '%s' with IQN '%s' "
                  "after attempting to create it",
329
                  &temp_ifacename[0], initiatoriqn);
330
        goto cleanup;
D
David Allan 已提交
331 332
    } else {
        VIR_DEBUG("Interface '%s' with IQN '%s' was created successfully",
333
                  *ifacename, initiatoriqn);
D
David Allan 已提交
334 335 336 337
    }

    ret = 0;

338 339 340
cleanup:
    virCommandFree(cmd);
    VIR_FREE(temp_ifacename);
D
David Allan 已提交
341 342 343 344 345 346
    if (ret != 0)
        VIR_FREE(*ifacename);
    return ret;
}


347

D
David Allan 已提交
348
static int
349 350 351 352
virStorageBackendISCSIConnection(const char *portal,
                                 const char *initiatoriqn,
                                 const char *target,
                                 const char **extraargv)
D
David Allan 已提交
353 354
{
    int ret = -1;
355 356 357 358 359 360 361
    const char *const baseargv[] = {
        ISCSIADM,
        "--mode", "node",
        "--portal", portal,
        "--targetname", target,
        NULL
    };
362
    virCommandPtr cmd;
D
David Allan 已提交
363 364
    char *ifacename = NULL;

365 366
    cmd = virCommandNewArgs(baseargv);
    virCommandAddArgSet(cmd, extraargv);
D
David Allan 已提交
367

368 369 370 371 372 373
    if (initiatoriqn) {
        switch (virStorageBackendIQNFound(initiatoriqn, &ifacename)) {
        case IQN_FOUND:
            VIR_DEBUG("ifacename: '%s'", ifacename);
            break;
        case IQN_MISSING:
374 375
            if (virStorageBackendCreateIfaceIQN(initiatoriqn,
                                                &ifacename) != 0) {
376 377 378 379 380 381 382
                goto cleanup;
            }
            break;
        case IQN_ERROR:
        default:
            goto cleanup;
        }
383
        virCommandAddArgList(cmd, "--interface", ifacename, NULL);
D
David Allan 已提交
384
    }
385

386
    if (virCommandRun(cmd, NULL) < 0)
387
        goto cleanup;
D
David Allan 已提交
388 389 390

    ret = 0;

391
cleanup:
392
    virCommandFree(cmd);
D
David Allan 已提交
393 394 395
    VIR_FREE(ifacename);

    return ret;
396 397
}

398 399 400 401 402 403 404 405 406 407 408 409 410 411 412 413 414 415 416 417 418 419 420 421 422 423 424 425 426 427 428 429 430 431 432 433
static int
virStorageBackendISCSIGetHostNumber(const char *sysfs_path,
                                    uint32_t *host)
{
    int retval = 0;
    DIR *sysdir = NULL;
    struct dirent *dirent = NULL;

    VIR_DEBUG("Finding host number from '%s'", sysfs_path);

    virFileWaitForDevices();

    sysdir = opendir(sysfs_path);

    if (sysdir == NULL) {
        virReportSystemError(errno,
                             _("Failed to opendir path '%s'"), sysfs_path);
        retval = -1;
        goto out;
    }

    while ((dirent = readdir(sysdir))) {
        if (STREQLEN(dirent->d_name, "target", strlen("target"))) {
            if (sscanf(dirent->d_name,
                       "target%u:", host) != 1) {
                VIR_DEBUG("Failed to parse target '%s'", dirent->d_name);
                retval = -1;
                break;
            }
        }
    }

    closedir(sysdir);
out:
    return retval;
}
434

435
static int
436
virStorageBackendISCSIFindLUs(virStoragePoolObjPtr pool,
437
                              const char *session)
438
{
439
    char *sysfs_path;
440 441
    int retval = 0;
    uint32_t host;
442

443 444 445 446 447
    if (virAsprintf(&sysfs_path,
                    "/sys/class/iscsi_session/session%s/device", session) < 0) {
        virReportOOMError();
        return -1;
    }
448

449
    if (virStorageBackendISCSIGetHostNumber(sysfs_path, &host) < 0) {
450
        virReportSystemError(errno,
451 452
                             _("Failed to get host number for iSCSI session "
                               "with path '%s'"),
453
                             sysfs_path);
454
        retval = -1;
455 456
    }

457
    if (virStorageBackendSCSIFindLUs(pool, host) < 0) {
458
        virReportSystemError(errno,
459 460
                             _("Failed to find LUs on host %u"), host);
        retval = -1;
461 462
    }

463 464
    VIR_FREE(sysfs_path);

465 466
    return retval;
}
467 468

static int
469
virStorageBackendISCSIRescanLUNs(virStoragePoolObjPtr pool ATTRIBUTE_UNUSED,
470 471
                                 const char *session)
{
472 473 474 475 476 477 478 479
    virCommandPtr cmd = virCommandNewArgList(ISCSIADM,
                                             "--mode", "session",
                                             "-r", session,
                                             "-R",
                                             NULL);
    int ret = virCommandRun(cmd, NULL);
    virCommandFree(cmd);
    return ret;
480 481
}

482 483 484 485
struct virStorageBackendISCSITargetList {
    size_t ntargets;
    char **targets;
};
486 487

static int
488 489 490
virStorageBackendISCSIGetTargets(virStoragePoolObjPtr pool ATTRIBUTE_UNUSED,
                                 char **const groups,
                                 void *data)
491
{
492 493 494
    struct virStorageBackendISCSITargetList *list = data;
    char *target;

495
    if (VIR_STRDUP(target, groups[1]) < 0)
496 497 498 499 500 501 502 503 504 505 506 507 508 509 510 511 512 513 514 515 516 517 518 519 520 521 522 523 524 525 526 527 528 529 530 531 532 533 534 535 536 537 538 539 540 541 542
        return -1;

    if (VIR_REALLOC_N(list->targets, list->ntargets + 1) < 0) {
        VIR_FREE(target);
        virReportOOMError();
        return -1;
    }

    list->targets[list->ntargets] = target;
    list->ntargets++;

    return 0;
}

static int
virStorageBackendISCSITargetAutologin(const char *portal,
                                      const char *initiatoriqn,
                                      const char *target,
                                      bool enable)
{
    const char *extraargv[] = { "--op", "update",
                                "--name", "node.startup",
                                "--value", enable ? "automatic" : "manual",
                                NULL };

    return virStorageBackendISCSIConnection(portal, initiatoriqn, target, extraargv);
}


static int
virStorageBackendISCSIScanTargets(const char *portal,
                                  const char *initiatoriqn,
                                  size_t *ntargetsret,
                                  char ***targetsret)
{
    /**
     *
     * The output of sendtargets is very simple, just two columns,
     * portal then target name
     *
     * 192.168.122.185:3260,1 iqn.2004-04.com:fedora14:iscsi.demo0.bf6d84
     * 192.168.122.185:3260,1 iqn.2004-04.com:fedora14:iscsi.demo1.bf6d84
     * 192.168.122.185:3260,1 iqn.2004-04.com:fedora14:iscsi.demo2.bf6d84
     * 192.168.122.185:3260,1 iqn.2004-04.com:fedora14:iscsi.demo3.bf6d84
     */
    const char *regexes[] = {
        "^\\s*(\\S+)\\s+(\\S+)\\s*$"
543
    };
544 545
    int vars[] = { 2 };
    struct virStorageBackendISCSITargetList list;
546 547 548 549 550 551 552
    size_t i;
    int ret = -1;
    virCommandPtr cmd = virCommandNewArgList(ISCSIADM,
                                             "--mode", "discovery",
                                             "--type", "sendtargets",
                                             "--portal", portal,
                                             NULL);
553 554 555 556

    memset(&list, 0, sizeof(list));

    if (virStorageBackendRunProgRegex(NULL, /* No pool for callback */
557
                                      cmd,
558 559 560 561
                                      1,
                                      regexes,
                                      vars,
                                      virStorageBackendISCSIGetTargets,
562 563
                                      &list, NULL) < 0)
        goto cleanup;
564 565 566 567 568 569 570 571 572 573 574 575 576 577 578 579 580 581 582 583 584 585 586

    for (i = 0 ; i < list.ntargets ; i++) {
        /* We have to ignore failure, because we can't undo
         * the results of 'sendtargets', unless we go scrubbing
         * around in the dirt in /var/lib/iscsi.
         */
        if (virStorageBackendISCSITargetAutologin(portal,
                                                  initiatoriqn,
                                                  list.targets[i], false) < 0)
            VIR_WARN("Unable to disable auto-login on iSCSI target %s: %s",
                     portal, list.targets[i]);
    }

    if (ntargetsret && targetsret) {
        *ntargetsret = list.ntargets;
        *targetsret = list.targets;
    } else {
        for (i = 0 ; i < list.ntargets ; i++) {
            VIR_FREE(list.targets[i]);
        }
        VIR_FREE(list.targets);
    }

587 588 589 590
    ret = 0;
cleanup:
    virCommandFree(cmd);
    return ret;
591 592 593
}


594 595 596
static char *
virStorageBackendISCSIFindPoolSources(virConnectPtr conn ATTRIBUTE_UNUSED,
                                      const char *srcSpec,
E
Eric Blake 已提交
597
                                      unsigned int flags)
598 599 600 601 602 603 604 605 606 607 608 609 610
{
    virStoragePoolSourcePtr source = NULL;
    size_t ntargets = 0;
    char **targets = NULL;
    char *ret = NULL;
    int i;
    virStoragePoolSourceList list = {
        .type = VIR_STORAGE_POOL_ISCSI,
        .nsources = 0,
        .sources = NULL
    };
    char *portal = NULL;

E
Eric Blake 已提交
611 612
    virCheckFlags(0, NULL);

613 614 615 616 617 618 619
    if (!srcSpec) {
        virReportError(VIR_ERR_INVALID_ARG,
                       "%s", _("hostname and device path "
                               "must be specified for iscsi sources"));
        return NULL;
    }

620 621 622 623
    if (!(source = virStoragePoolDefParseSourceString(srcSpec,
                                                      list.type)))
        return NULL;

624
    if (source->nhost != 1) {
625 626
        virReportError(VIR_ERR_CONFIG_UNSUPPORTED, "%s",
                       _("Expected exactly 1 host for the storage pool"));
627 628 629
        goto cleanup;
    }

630 631 632 633 634 635 636 637 638 639 640 641 642 643
    if (!(portal = virStorageBackendISCSIPortal(source)))
        goto cleanup;

    if (virStorageBackendISCSIScanTargets(portal,
                                          source->initiator.iqn,
                                          &ntargets, &targets) < 0)
        goto cleanup;

    if (VIR_ALLOC_N(list.sources, ntargets) < 0) {
        virReportOOMError();
        goto cleanup;
    }

    for (i = 0 ; i < ntargets ; i++) {
E
Eric Blake 已提交
644 645
        if (VIR_ALLOC_N(list.sources[i].devices, 1) < 0 ||
            VIR_ALLOC_N(list.sources[i].hosts, 1) < 0) {
646 647 648
            virReportOOMError();
            goto cleanup;
        }
E
Eric Blake 已提交
649 650
        list.sources[i].nhost = 1;
        list.sources[i].hosts[0] = source->hosts[0];
651 652 653 654 655 656 657 658 659 660 661 662 663
        list.sources[i].initiator = source->initiator;
        list.sources[i].ndevice = 1;
        list.sources[i].devices[0].path = targets[i];
        list.nsources++;
    }

    if (!(ret = virStoragePoolSourceListFormat(&list))) {
        virReportOOMError();
        goto cleanup;
    }

cleanup:
    if (list.sources) {
E
Eric Blake 已提交
664 665
        for (i = 0 ; i < ntargets ; i++) {
            VIR_FREE(list.sources[i].hosts);
666
            VIR_FREE(list.sources[i].devices);
E
Eric Blake 已提交
667
        }
668 669 670 671 672 673 674 675 676 677
        VIR_FREE(list.sources);
    }
    for (i = 0 ; i < ntargets ; i++)
        VIR_FREE(targets[i]);
    VIR_FREE(targets);
    VIR_FREE(portal);
    virStoragePoolSourceFree(source);
    return ret;
}

678 679 680 681 682 683 684 685 686 687
static int
virStorageBackendISCSICheckPool(virConnectPtr conn ATTRIBUTE_UNUSED,
                                virStoragePoolObjPtr pool,
                                bool *isActive)
{
    char *session = NULL;
    int ret = -1;

    *isActive = false;

688
    if (pool->def->source.nhost != 1) {
689 690
         virReportError(VIR_ERR_CONFIG_UNSUPPORTED, "%s",
                        _("Expected exactly 1 host for the storage pool"));
691 692 693 694
        return -1;
    }

    if (pool->def->source.hosts[0].name == NULL) {
695 696
        virReportError(VIR_ERR_INTERNAL_ERROR,
                       "%s", _("missing source host"));
697 698 699 700 701
        return -1;
    }

    if (pool->def->source.ndevice != 1 ||
        pool->def->source.devices[0].path == NULL) {
702 703
        virReportError(VIR_ERR_INTERNAL_ERROR,
                       "%s", _("missing source device"));
704 705 706 707 708 709 710 711 712 713 714 715 716
        return -1;
    }

    if ((session = virStorageBackendISCSISession(pool, 1)) != NULL) {
        *isActive = true;
        VIR_FREE(session);
    }
    ret = 0;

    return ret;
}


717
static int
718
virStorageBackendISCSIStartPool(virConnectPtr conn ATTRIBUTE_UNUSED,
719 720 721
                                virStoragePoolObjPtr pool)
{
    char *portal = NULL;
722 723 724
    char *session = NULL;
    int ret = -1;
    const char *loginargv[] = { "--login", NULL };
725

726
    if (pool->def->source.nhost != 1) {
727 728
         virReportError(VIR_ERR_CONFIG_UNSUPPORTED, "%s",
                        _("Expected exactly 1 host for the storage pool"));
729 730 731 732
        return -1;
    }

    if (pool->def->source.hosts[0].name == NULL) {
733 734
        virReportError(VIR_ERR_INTERNAL_ERROR,
                       "%s", _("missing source host"));
735 736 737 738 739
        return -1;
    }

    if (pool->def->source.ndevice != 1 ||
        pool->def->source.devices[0].path == NULL) {
740 741
        virReportError(VIR_ERR_INTERNAL_ERROR,
                       "%s", _("missing source device"));
742 743 744
        return -1;
    }

745
    if ((session = virStorageBackendISCSISession(pool, 1)) == NULL) {
746 747 748 749 750 751
        if ((portal = virStorageBackendISCSIPortal(&pool->def->source)) == NULL)
            goto cleanup;
        /*
         * iscsiadm doesn't let you login to a target, unless you've
         * first issued a 'sendtargets' command to the portal :-(
         */
752 753 754
        if (virStorageBackendISCSIScanTargets(portal,
                                              pool->def->source.initiator.iqn,
                                              NULL, NULL) < 0)
755 756 757 758 759 760 761
            goto cleanup;

        if (virStorageBackendISCSIConnection(portal,
                                             pool->def->source.initiator.iqn,
                                             pool->def->source.devices[0].path,
                                             loginargv) < 0)
            goto cleanup;
762
    }
763 764 765
    ret = 0;

cleanup:
766
    VIR_FREE(portal);
767 768
    VIR_FREE(session);
    return ret;
769 770 771
}

static int
772
virStorageBackendISCSIRefreshPool(virConnectPtr conn ATTRIBUTE_UNUSED,
773 774 775 776 777 778
                                  virStoragePoolObjPtr pool)
{
    char *session = NULL;

    pool->def->allocation = pool->def->capacity = pool->def->available = 0;

779
    if ((session = virStorageBackendISCSISession(pool, 0)) == NULL)
780
        goto cleanup;
781
    if (virStorageBackendISCSIRescanLUNs(pool, session) < 0)
782
        goto cleanup;
783
    if (virStorageBackendISCSIFindLUs(pool, session) < 0)
784
        goto cleanup;
785
    VIR_FREE(session);
786 787 788 789

    return 0;

 cleanup:
790
    VIR_FREE(session);
791 792 793 794 795
    return -1;
}


static int
796
virStorageBackendISCSIStopPool(virConnectPtr conn ATTRIBUTE_UNUSED,
797 798
                               virStoragePoolObjPtr pool)
{
799
    const char *logoutargv[] = { "--logout", NULL };
800
    char *portal;
801
    int ret = -1;
802

803
    if ((portal = virStorageBackendISCSIPortal(&pool->def->source)) == NULL)
804 805
        return -1;

806 807 808 809 810 811
    if (virStorageBackendISCSIConnection(portal,
                                         pool->def->source.initiator.iqn,
                                         pool->def->source.devices[0].path,
                                         logoutargv) < 0)
        goto cleanup;
    ret = 0;
812

813 814 815
cleanup:
    VIR_FREE(portal);
    return ret;
816 817 818
}

virStorageBackend virStorageBackendISCSI = {
819
    .type = VIR_STORAGE_POOL_ISCSI,
820

821
    .checkPool = virStorageBackendISCSICheckPool,
822 823 824
    .startPool = virStorageBackendISCSIStartPool,
    .refreshPool = virStorageBackendISCSIRefreshPool,
    .stopPool = virStorageBackendISCSIStopPool,
825
    .findPoolSources = virStorageBackendISCSIFindPoolSources,
826
};