storage_backend_iscsi.c 21.5 KB
Newer Older
1 2 3
/*
 * storage_backend_iscsi.c: storage backend for iSCSI handling
 *
J
Jim Meyering 已提交
4
 * Copyright (C) 2007-2008, 2010 Red Hat, Inc.
5 6 7 8 9 10 11 12 13 14 15 16 17 18 19 20 21 22 23 24 25 26 27 28 29 30 31 32 33 34 35
 * Copyright (C) 2007-2008 Daniel P. Berrange
 *
 * This library is free software; you can redistribute it and/or
 * modify it under the terms of the GNU Lesser General Public
 * License as published by the Free Software Foundation; either
 * version 2.1 of the License, or (at your option) any later version.
 *
 * This library is distributed in the hope that it will be useful,
 * but WITHOUT ANY WARRANTY; without even the implied warranty of
 * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the GNU
 * Lesser General Public License for more details.
 *
 * You should have received a copy of the GNU Lesser General Public
 * License along with this library; if not, write to the Free Software
 * Foundation, Inc., 59 Temple Place, Suite 330, Boston, MA 02111-1307  USA
 *
 * Author: Daniel P. Berrange <berrange@redhat.com>
 */

#include <config.h>

#include <sys/socket.h>
#include <netdb.h>
#include <sys/types.h>
#include <sys/wait.h>
#include <string.h>
#include <stdio.h>
#include <regex.h>
#include <fcntl.h>
#include <unistd.h>
#include <dirent.h>
D
David Allan 已提交
36
#include <sys/stat.h>
37

38
#include "virterror_internal.h"
39
#include "storage_backend_scsi.h"
40 41
#include "storage_backend_iscsi.h"
#include "util.h"
42
#include "memory.h"
D
David Allan 已提交
43
#include "logging.h"
44
#include "files.h"
45

46 47
#define VIR_FROM_THIS VIR_FROM_STORAGE

48
static int
49
virStorageBackendISCSITargetIP(const char *hostname,
50 51 52 53 54 55 56 57 58 59 60 61 62 63 64
                               char *ipaddr,
                               size_t ipaddrlen)
{
    struct addrinfo hints;
    struct addrinfo *result = NULL;
    int ret;

    memset(&hints, 0, sizeof hints);
    hints.ai_flags = AI_ADDRCONFIG;
    hints.ai_family = AF_INET;
    hints.ai_socktype = SOCK_STREAM;
    hints.ai_protocol = 0;

    ret = getaddrinfo(hostname, NULL, &hints, &result);
    if (ret != 0) {
65
        virStorageReportError(VIR_ERR_INTERNAL_ERROR,
66 67 68 69 70 71
                              _("host lookup failed %s"),
                              gai_strerror(ret));
        return -1;
    }

    if (result == NULL) {
72
        virStorageReportError(VIR_ERR_INTERNAL_ERROR,
73 74 75 76 77 78 79 80
                              _("no IP address for target %s"),
                              hostname);
        return -1;
    }

    if (getnameinfo(result->ai_addr, result->ai_addrlen,
                    ipaddr, ipaddrlen, NULL, 0,
                    NI_NUMERICHOST) < 0) {
81
        virStorageReportError(VIR_ERR_INTERNAL_ERROR,
82 83 84 85 86 87 88 89 90 91
                              _("cannot format ip addr for %s"),
                              hostname);
        freeaddrinfo(result);
        return -1;
    }

    freeaddrinfo(result);
    return 0;
}

92 93 94 95 96 97 98 99 100 101 102 103 104 105 106 107 108 109 110 111 112
static char *
virStorageBackendISCSIPortal(virStoragePoolSourcePtr source)
{
    char ipaddr[NI_MAXHOST];
    char *portal;

    if (virStorageBackendISCSITargetIP(source->host.name,
                                       ipaddr, sizeof(ipaddr)) < 0)
        return NULL;

    if (virAsprintf(&portal, "%s:%d,1", ipaddr,
                    source->host.port ?
                    source->host.port : 3260) < 0) {
        virReportOOMError();
        return NULL;
    }

    return portal;
}


113
static int
114
virStorageBackendISCSIExtractSession(virStoragePoolObjPtr pool,
115 116 117 118 119 120 121
                                     char **const groups,
                                     void *data)
{
    char **session = data;

    if (STREQ(groups[1], pool->def->source.devices[0].path)) {
        if ((*session = strdup(groups[0])) == NULL) {
122
            virReportOOMError();
123 124 125 126 127 128 129 130
            return -1;
        }
    }

    return 0;
}

static char *
131
virStorageBackendISCSISession(virStoragePoolObjPtr pool,
132
                              int probe)
133 134
{
    /*
135
     * # iscsiadm --mode session
136 137 138 139 140 141 142 143 144 145 146
     * tcp: [1] 192.168.122.170:3260,1 demo-tgt-b
     * tcp: [2] 192.168.122.170:3260,1 demo-tgt-a
     *
     * Pull out 2nd and 4th fields
     */
    const char *regexes[] = {
        "^tcp:\\s+\\[(\\S+)\\]\\s+\\S+\\s+(\\S+)\\s*$"
    };
    int vars[] = {
        2,
    };
147
    const char *const prog[] = {
148
        ISCSIADM, "--mode", "session", NULL
149 150 151
    };
    char *session = NULL;

152 153 154 155
    /* Note that we ignore the exitstatus.  Older versions of iscsiadm tools
     * returned an exit status of > 0, even if they succeeded.  We will just
     * rely on whether session got filled in properly.
     */
156
    if (virStorageBackendRunProgRegex(pool,
157 158 159 160 161
                                      prog,
                                      1,
                                      regexes,
                                      vars,
                                      virStorageBackendISCSIExtractSession,
162 163
                                      &session,
                                      NULL) < 0)
164 165
        return NULL;

166 167
    if (session == NULL &&
        !probe) {
168
        virStorageReportError(VIR_ERR_INTERNAL_ERROR,
J
Jim Meyering 已提交
169
                              "%s", _("cannot find session"));
170 171 172 173 174 175
        return NULL;
    }

    return session;
}

D
David Allan 已提交
176 177 178 179

#define LINE_SIZE 4096

static int
180
virStorageBackendIQNFound(const char *initiatoriqn,
D
David Allan 已提交
181 182 183 184 185 186 187 188 189 190 191 192 193 194
                          char **ifacename)
{
    int ret = IQN_MISSING, fd = -1;
    char ebuf[64];
    FILE *fp = NULL;
    pid_t child = 0;
    char *line = NULL, *newline = NULL, *iqn = NULL, *token = NULL,
        *saveptr = NULL;
    const char *const prog[] = {
        ISCSIADM, "--mode", "iface", NULL
    };

    if (VIR_ALLOC_N(line, LINE_SIZE) != 0) {
        ret = IQN_ERROR;
195
        virStorageReportError(VIR_ERR_INTERNAL_ERROR,
D
David Allan 已提交
196 197 198 199 200 201 202
                              _("Could not allocate memory for output of '%s'"),
                              prog[0]);
        goto out;
    }

    memset(line, 0, LINE_SIZE);

203
    if (virExec(prog, NULL, NULL, &child, -1, &fd, NULL, VIR_EXEC_NONE) < 0) {
204
        virStorageReportError(VIR_ERR_INTERNAL_ERROR,
D
David Allan 已提交
205
                              _("Failed to run '%s' when looking for existing interface with IQN '%s'"),
206
                              prog[0], initiatoriqn);
D
David Allan 已提交
207 208 209 210 211

        ret = IQN_ERROR;
        goto out;
    }

212
    if ((fp = VIR_FDOPEN(fd, "r")) == NULL) {
213
        virStorageReportError(VIR_ERR_INTERNAL_ERROR,
D
David Allan 已提交
214 215 216 217 218 219 220 221 222 223 224
                              _("Failed to open stream for file descriptor "
                                "when reading output from '%s': '%s'"),
                              prog[0], virStrerror(errno, ebuf, sizeof ebuf));
        ret = IQN_ERROR;
        goto out;
    }

    while (fgets(line, LINE_SIZE, fp) != NULL) {
        newline = strrchr(line, '\n');
        if (newline == NULL) {
            ret = IQN_ERROR;
225
            virStorageReportError(VIR_ERR_INTERNAL_ERROR,
D
David Allan 已提交
226 227 228 229 230 231 232 233 234 235 236 237 238
                                  _("Unexpected line > %d characters "
                                    "when parsing output of '%s'"),
                                  LINE_SIZE, prog[0]);
            goto out;
        }
        *newline = '\0';

        iqn = strrchr(line, ',');
        if (iqn == NULL) {
            continue;
        }
        iqn++;

239
        if (STREQ(iqn, initiatoriqn)) {
D
David Allan 已提交
240 241 242 243
            token = strtok_r(line, " ", &saveptr);
            *ifacename = strdup(token);
            if (*ifacename == NULL) {
                ret = IQN_ERROR;
244
                virReportOOMError();
D
David Allan 已提交
245 246 247 248 249 250 251 252 253 254
                goto out;
            }
            VIR_DEBUG("Found interface '%s' with IQN '%s'", *ifacename, iqn);
            ret = IQN_FOUND;
            break;
        }
    }

out:
    if (ret == IQN_MISSING) {
255
        VIR_DEBUG("Could not find interface with IQN '%s'", iqn);
D
David Allan 已提交
256 257 258
    }

    VIR_FREE(line);
259 260
    VIR_FORCE_FCLOSE(fp);
    VIR_FORCE_CLOSE(fd);
D
David Allan 已提交
261 262 263 264 265 266

    return ret;
}


static int
267
virStorageBackendCreateIfaceIQN(const char *initiatoriqn,
268
                                char **ifacename)
D
David Allan 已提交
269 270 271 272 273
{
    int ret = -1, exitstatus = -1;
    char temp_ifacename[32];

    if (virRandomInitialize(time(NULL) ^ getpid()) == -1) {
274
        virStorageReportError(VIR_ERR_INTERNAL_ERROR, "%s",
D
David Allan 已提交
275 276 277 278 279 280 281 282 283 284 285 286 287
                              _("Failed to initialize random generator "
                                "when creating iscsi interface"));
        goto out;
    }

    snprintf(temp_ifacename, sizeof(temp_ifacename), "libvirt-iface-%08x", virRandom(1024 * 1024 * 1024));

    const char *const cmdargv1[] = {
        ISCSIADM, "--mode", "iface", "--interface",
        &temp_ifacename[0], "--op", "new", NULL
    };

    VIR_DEBUG("Attempting to create interface '%s' with IQN '%s'",
288
              &temp_ifacename[0], initiatoriqn);
D
David Allan 已提交
289 290 291 292 293

    /* Note that we ignore the exitstatus.  Older versions of iscsiadm
     * tools returned an exit status of > 0, even if they succeeded.
     * We will just rely on whether the interface got created
     * properly. */
294
    if (virRun(cmdargv1, &exitstatus) < 0) {
295
        virStorageReportError(VIR_ERR_INTERNAL_ERROR,
D
David Allan 已提交
296 297 298 299 300 301 302 303
                              _("Failed to run command '%s' to create new iscsi interface"),
                              cmdargv1[0]);
        goto out;
    }

    const char *const cmdargv2[] = {
        ISCSIADM, "--mode", "iface", "--interface", &temp_ifacename[0],
        "--op", "update", "--name", "iface.initiatorname", "--value",
304
        initiatoriqn, NULL
D
David Allan 已提交
305 306 307 308 309
    };

    /* Note that we ignore the exitstatus.  Older versions of iscsiadm tools
     * returned an exit status of > 0, even if they succeeded.  We will just
     * rely on whether iface file got updated properly. */
310
    if (virRun(cmdargv2, &exitstatus) < 0) {
311
        virStorageReportError(VIR_ERR_INTERNAL_ERROR,
D
David Allan 已提交
312
                              _("Failed to run command '%s' to update iscsi interface with IQN '%s'"),
313
                              cmdargv2[0], initiatoriqn);
D
David Allan 已提交
314 315 316 317
        goto out;
    }

    /* Check again to make sure the interface was created. */
318
    if (virStorageBackendIQNFound(initiatoriqn, ifacename) != IQN_FOUND) {
D
David Allan 已提交
319 320
        VIR_DEBUG("Failed to find interface '%s' with IQN '%s' "
                  "after attempting to create it",
321
                  &temp_ifacename[0], initiatoriqn);
D
David Allan 已提交
322 323 324
        goto out;
    } else {
        VIR_DEBUG("Interface '%s' with IQN '%s' was created successfully",
325
                  *ifacename, initiatoriqn);
D
David Allan 已提交
326 327 328 329 330 331 332 333 334 335 336
    }

    ret = 0;

out:
    if (ret != 0)
        VIR_FREE(*ifacename);
    return ret;
}


337

D
David Allan 已提交
338
static int
339 340 341 342
virStorageBackendISCSIConnection(const char *portal,
                                 const char *initiatoriqn,
                                 const char *target,
                                 const char **extraargv)
D
David Allan 已提交
343 344
{
    int ret = -1;
345 346 347 348 349 350 351 352 353
    const char *const baseargv[] = {
        ISCSIADM,
        "--mode", "node",
        "--portal", portal,
        "--targetname", target,
        NULL
    };
    int i;
    int nargs = 0;
D
David Allan 已提交
354
    char *ifacename = NULL;
355
    const char **cmdargv;
D
David Allan 已提交
356

357 358 359 360 361 362
    for (i = 0 ; baseargv[i] != NULL ; i++)
        nargs++;
    for (i = 0 ; extraargv[i] != NULL ; i++)
        nargs++;
    if (initiatoriqn)
        nargs += 2;
D
David Allan 已提交
363

364 365 366
    if (VIR_ALLOC_N(cmdargv, nargs+1) < 0) {
        virReportOOMError();
        return -1;
D
David Allan 已提交
367 368
    }

369 370 371 372 373
    nargs = 0;
    for (i = 0 ; baseargv[i] != NULL ; i++)
        cmdargv[nargs++] = baseargv[i];
    for (i = 0 ; extraargv[i] != NULL ; i++)
        cmdargv[nargs++] = extraargv[i];
D
David Allan 已提交
374

375 376 377 378 379 380 381 382 383 384 385 386 387 388 389 390 391
    if (initiatoriqn) {
        switch (virStorageBackendIQNFound(initiatoriqn, &ifacename)) {
        case IQN_FOUND:
            VIR_DEBUG("ifacename: '%s'", ifacename);
            break;
        case IQN_MISSING:
            if (virStorageBackendCreateIfaceIQN(initiatoriqn, &ifacename) != 0) {
                goto cleanup;
            }
            break;
        case IQN_ERROR:
        default:
            goto cleanup;
        }

        cmdargv[nargs++] = "--interface";
        cmdargv[nargs++] = ifacename;
D
David Allan 已提交
392
    }
393 394 395 396
    cmdargv[nargs++] = NULL;

    if (virRun(cmdargv, NULL) < 0)
        goto cleanup;
D
David Allan 已提交
397 398 399

    ret = 0;

400 401
cleanup:
    VIR_FREE(cmdargv);
D
David Allan 已提交
402 403 404
    VIR_FREE(ifacename);

    return ret;
405 406
}

407

408
static int
409
virStorageBackendISCSIFindLUs(virStoragePoolObjPtr pool,
410
                              const char *session)
411
{
412
    char sysfs_path[PATH_MAX];
413 414
    int retval = 0;
    uint32_t host;
415 416 417 418

    snprintf(sysfs_path, PATH_MAX,
             "/sys/class/iscsi_session/session%s/device", session);

419
    if (virStorageBackendSCSIGetHostNumber(sysfs_path, &host) < 0) {
420
        virReportSystemError(errno,
421 422
                             _("Failed to get host number for iSCSI session "
                               "with path '%s'"),
423
                             sysfs_path);
424
        retval = -1;
425 426
    }

427
    if (virStorageBackendSCSIFindLUs(pool, host) < 0) {
428
        virReportSystemError(errno,
429 430
                             _("Failed to find LUs on host %u"), host);
        retval = -1;
431 432 433 434
    }

    return retval;
}
435 436

static int
437
virStorageBackendISCSIRescanLUNs(virStoragePoolObjPtr pool ATTRIBUTE_UNUSED,
438 439
                                 const char *session)
{
440
    const char *const cmdargv[] = {
441 442 443
        ISCSIADM, "--mode", "session", "-r", session, "-R", NULL,
    };

444
    if (virRun(cmdargv, NULL) < 0)
445 446 447 448 449
        return -1;

    return 0;
}

450 451 452 453
struct virStorageBackendISCSITargetList {
    size_t ntargets;
    char **targets;
};
454 455

static int
456 457 458
virStorageBackendISCSIGetTargets(virStoragePoolObjPtr pool ATTRIBUTE_UNUSED,
                                 char **const groups,
                                 void *data)
459
{
460 461 462 463 464 465 466 467 468 469 470 471 472 473 474 475 476 477 478 479 480 481 482 483 484 485 486 487 488 489 490 491 492 493 494 495 496 497 498 499 500 501 502 503 504 505 506 507 508 509 510 511 512
    struct virStorageBackendISCSITargetList *list = data;
    char *target;

    if (!(target = strdup(groups[1]))) {
        virReportOOMError();
        return -1;
    }

    if (VIR_REALLOC_N(list->targets, list->ntargets + 1) < 0) {
        VIR_FREE(target);
        virReportOOMError();
        return -1;
    }

    list->targets[list->ntargets] = target;
    list->ntargets++;

    return 0;
}

static int
virStorageBackendISCSITargetAutologin(const char *portal,
                                      const char *initiatoriqn,
                                      const char *target,
                                      bool enable)
{
    const char *extraargv[] = { "--op", "update",
                                "--name", "node.startup",
                                "--value", enable ? "automatic" : "manual",
                                NULL };

    return virStorageBackendISCSIConnection(portal, initiatoriqn, target, extraargv);
}


static int
virStorageBackendISCSIScanTargets(const char *portal,
                                  const char *initiatoriqn,
                                  size_t *ntargetsret,
                                  char ***targetsret)
{
    /**
     *
     * The output of sendtargets is very simple, just two columns,
     * portal then target name
     *
     * 192.168.122.185:3260,1 iqn.2004-04.com:fedora14:iscsi.demo0.bf6d84
     * 192.168.122.185:3260,1 iqn.2004-04.com:fedora14:iscsi.demo1.bf6d84
     * 192.168.122.185:3260,1 iqn.2004-04.com:fedora14:iscsi.demo2.bf6d84
     * 192.168.122.185:3260,1 iqn.2004-04.com:fedora14:iscsi.demo3.bf6d84
     */
    const char *regexes[] = {
        "^\\s*(\\S+)\\s+(\\S+)\\s*$"
513
    };
514 515 516 517 518 519 520 521 522 523 524 525 526 527 528 529 530 531 532
    int vars[] = { 2 };
    const char *const cmdsendtarget[] = {
        ISCSIADM, "--mode", "discovery", "--type", "sendtargets",
        "--portal", portal, NULL
    };
    struct virStorageBackendISCSITargetList list;
    int i;
    int exitstatus;

    memset(&list, 0, sizeof(list));

    if (virStorageBackendRunProgRegex(NULL, /* No pool for callback */
                                      cmdsendtarget,
                                      1,
                                      regexes,
                                      vars,
                                      virStorageBackendISCSIGetTargets,
                                      &list,
                                      &exitstatus) < 0) {
533
        virStorageReportError(VIR_ERR_INTERNAL_ERROR,
534 535 536 537 538 539 540 541
                              "%s", _("iscsiadm command failed"));
                              return -1;
    }

    if (exitstatus != 0) {
        virStorageReportError(VIR_ERR_INTERNAL_ERROR,
                              _("iscsiadm sendtargets command failed with exitstatus %d"),
                              exitstatus);
542
        return -1;
543
    }
544 545 546 547 548 549 550 551 552 553 554 555 556 557 558 559 560 561 562 563 564 565 566

    for (i = 0 ; i < list.ntargets ; i++) {
        /* We have to ignore failure, because we can't undo
         * the results of 'sendtargets', unless we go scrubbing
         * around in the dirt in /var/lib/iscsi.
         */
        if (virStorageBackendISCSITargetAutologin(portal,
                                                  initiatoriqn,
                                                  list.targets[i], false) < 0)
            VIR_WARN("Unable to disable auto-login on iSCSI target %s: %s",
                     portal, list.targets[i]);
    }

    if (ntargetsret && targetsret) {
        *ntargetsret = list.ntargets;
        *targetsret = list.targets;
    } else {
        for (i = 0 ; i < list.ntargets ; i++) {
            VIR_FREE(list.targets[i]);
        }
        VIR_FREE(list.targets);
    }

567
    return 0;
568 569 570
}


571 572 573 574 575 576 577 578 579 580 581 582 583 584 585 586 587 588 589 590 591 592 593 594 595 596 597 598 599 600 601 602 603 604 605 606 607 608 609 610 611 612 613 614 615 616 617 618 619 620 621 622 623 624 625 626 627 628 629 630 631 632 633 634 635
static char *
virStorageBackendISCSIFindPoolSources(virConnectPtr conn ATTRIBUTE_UNUSED,
                                      const char *srcSpec,
                                      unsigned int flags ATTRIBUTE_UNUSED)
{
    virStoragePoolSourcePtr source = NULL;
    size_t ntargets = 0;
    char **targets = NULL;
    char *ret = NULL;
    int i;
    virStoragePoolSourceList list = {
        .type = VIR_STORAGE_POOL_ISCSI,
        .nsources = 0,
        .sources = NULL
    };
    char *portal = NULL;

    if (!(source = virStoragePoolDefParseSourceString(srcSpec,
                                                      list.type)))
        return NULL;

    if (!(portal = virStorageBackendISCSIPortal(source)))
        goto cleanup;

    if (virStorageBackendISCSIScanTargets(portal,
                                          source->initiator.iqn,
                                          &ntargets, &targets) < 0)
        goto cleanup;

    if (VIR_ALLOC_N(list.sources, ntargets) < 0) {
        virReportOOMError();
        goto cleanup;
    }

    for (i = 0 ; i < ntargets ; i++) {
        if (VIR_ALLOC_N(list.sources[i].devices, 1) < 0) {
            virReportOOMError();
            goto cleanup;
        }
        list.sources[i].host = source->host;
        list.sources[i].initiator = source->initiator;
        list.sources[i].ndevice = 1;
        list.sources[i].devices[0].path = targets[i];
        list.nsources++;
    }

    if (!(ret = virStoragePoolSourceListFormat(&list))) {
        virReportOOMError();
        goto cleanup;
    }

cleanup:
    if (list.sources) {
        for (i = 0 ; i < ntargets ; i++)
            VIR_FREE(list.sources[i].devices);
        VIR_FREE(list.sources);
    }
    for (i = 0 ; i < ntargets ; i++)
        VIR_FREE(targets[i]);
    VIR_FREE(targets);
    VIR_FREE(portal);
    virStoragePoolSourceFree(source);
    return ret;
}

636
static int
637
virStorageBackendISCSIStartPool(virConnectPtr conn ATTRIBUTE_UNUSED,
638 639 640
                                virStoragePoolObjPtr pool)
{
    char *portal = NULL;
641 642 643
    char *session = NULL;
    int ret = -1;
    const char *loginargv[] = { "--login", NULL };
644 645

    if (pool->def->source.host.name == NULL) {
646
        virStorageReportError(VIR_ERR_INTERNAL_ERROR,
J
Jim Meyering 已提交
647
                              "%s", _("missing source host"));
648 649 650 651 652
        return -1;
    }

    if (pool->def->source.ndevice != 1 ||
        pool->def->source.devices[0].path == NULL) {
653
        virStorageReportError(VIR_ERR_INTERNAL_ERROR,
J
Jim Meyering 已提交
654
                              "%s", _("missing source device"));
655 656 657
        return -1;
    }

658
    if ((session = virStorageBackendISCSISession(pool, 1)) == NULL) {
659 660 661 662 663 664
        if ((portal = virStorageBackendISCSIPortal(&pool->def->source)) == NULL)
            goto cleanup;
        /*
         * iscsiadm doesn't let you login to a target, unless you've
         * first issued a 'sendtargets' command to the portal :-(
         */
665 666 667
        if (virStorageBackendISCSIScanTargets(portal,
                                              pool->def->source.initiator.iqn,
                                              NULL, NULL) < 0)
668 669 670 671 672 673 674
            goto cleanup;

        if (virStorageBackendISCSIConnection(portal,
                                             pool->def->source.initiator.iqn,
                                             pool->def->source.devices[0].path,
                                             loginargv) < 0)
            goto cleanup;
675
    }
676 677 678 679 680
    ret = 0;

cleanup:
    VIR_FREE(session);
    return ret;
681 682 683
}

static int
684
virStorageBackendISCSIRefreshPool(virConnectPtr conn ATTRIBUTE_UNUSED,
685 686 687 688 689 690
                                  virStoragePoolObjPtr pool)
{
    char *session = NULL;

    pool->def->allocation = pool->def->capacity = pool->def->available = 0;

691
    if ((session = virStorageBackendISCSISession(pool, 0)) == NULL)
692
        goto cleanup;
693
    if (virStorageBackendISCSIRescanLUNs(pool, session) < 0)
694
        goto cleanup;
695
    if (virStorageBackendISCSIFindLUs(pool, session) < 0)
696
        goto cleanup;
697
    VIR_FREE(session);
698 699 700 701

    return 0;

 cleanup:
702
    VIR_FREE(session);
703 704 705 706 707
    return -1;
}


static int
708
virStorageBackendISCSIStopPool(virConnectPtr conn ATTRIBUTE_UNUSED,
709 710
                               virStoragePoolObjPtr pool)
{
711
    const char *logoutargv[] = { "--logout", NULL };
712
    char *portal;
713
    int ret = -1;
714

715
    if ((portal = virStorageBackendISCSIPortal(&pool->def->source)) == NULL)
716 717
        return -1;

718 719 720 721 722 723
    if (virStorageBackendISCSIConnection(portal,
                                         pool->def->source.initiator.iqn,
                                         pool->def->source.devices[0].path,
                                         logoutargv) < 0)
        goto cleanup;
    ret = 0;
724

725 726 727
cleanup:
    VIR_FREE(portal);
    return ret;
728 729 730
}

virStorageBackend virStorageBackendISCSI = {
731
    .type = VIR_STORAGE_POOL_ISCSI,
732

733 734 735
    .startPool = virStorageBackendISCSIStartPool,
    .refreshPool = virStorageBackendISCSIRefreshPool,
    .stopPool = virStorageBackendISCSIStopPool,
736
    .findPoolSources = virStorageBackendISCSIFindPoolSources,
737
};