bridge_driver.c 102.2 KB
Newer Older
1
/*
2
 * bridge_driver.c: core driver methods for managing network
3
 *
E
Eric Blake 已提交
4
 * Copyright (C) 2006-2011 Red Hat, Inc.
5 6 7 8 9 10 11 12 13 14 15 16 17 18 19 20 21 22 23 24 25 26 27 28 29 30 31 32 33 34 35 36 37 38 39 40 41 42 43 44 45
 * Copyright (C) 2006 Daniel P. Berrange
 *
 * This library is free software; you can redistribute it and/or
 * modify it under the terms of the GNU Lesser General Public
 * License as published by the Free Software Foundation; either
 * version 2.1 of the License, or (at your option) any later version.
 *
 * This library is distributed in the hope that it will be useful,
 * but WITHOUT ANY WARRANTY; without even the implied warranty of
 * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the GNU
 * Lesser General Public License for more details.
 *
 * You should have received a copy of the GNU Lesser General Public
 * License along with this library; if not, write to the Free Software
 * Foundation, Inc., 59 Temple Place, Suite 330, Boston, MA 02111-1307  USA
 *
 * Author: Daniel P. Berrange <berrange@redhat.com>
 */

#include <config.h>

#include <sys/types.h>
#include <sys/poll.h>
#include <dirent.h>
#include <limits.h>
#include <string.h>
#include <stdio.h>
#include <stdarg.h>
#include <stdlib.h>
#include <unistd.h>
#include <errno.h>
#include <sys/utsname.h>
#include <sys/stat.h>
#include <fcntl.h>
#include <signal.h>
#include <paths.h>
#include <pwd.h>
#include <stdio.h>
#include <sys/wait.h>
#include <sys/ioctl.h>

46
#include "virterror_internal.h"
47
#include "datatypes.h"
48
#include "bridge_driver.h"
49 50 51 52
#include "network_conf.h"
#include "driver.h"
#include "buf.h"
#include "util.h"
53
#include "command.h"
54 55 56 57
#include "memory.h"
#include "uuid.h"
#include "iptables.h"
#include "bridge.h"
58
#include "interface.h"
59
#include "logging.h"
60
#include "dnsmasq.h"
61
#include "util/network.h"
62
#include "configmake.h"
63

64 65
#define NETWORK_PID_DIR LOCALSTATEDIR "/run/libvirt/network"
#define NETWORK_STATE_DIR LOCALSTATEDIR "/lib/libvirt/network"
66

67
#define DNSMASQ_STATE_DIR LOCALSTATEDIR "/lib/libvirt/dnsmasq"
68
#define RADVD_STATE_DIR LOCALSTATEDIR "/lib/libvirt/radvd"
69

70 71
#define VIR_FROM_THIS VIR_FROM_NETWORK

72
#define networkReportError(code, ...)                                   \
73
    virReportErrorHelper(VIR_FROM_NETWORK, code, __FILE__,              \
74
                         __FUNCTION__, __LINE__, __VA_ARGS__)
75

76 77
/* Main driver state */
struct network_driver {
78
    virMutex lock;
79

80
    virNetworkObjList networks;
81 82 83 84 85 86 87 88

    iptablesContext *iptables;
    brControl *brctl;
    char *networkConfigDir;
    char *networkAutostartDir;
    char *logDir;
};

89 90 91

static void networkDriverLock(struct network_driver *driver)
{
92
    virMutexLock(&driver->lock);
93 94 95
}
static void networkDriverUnlock(struct network_driver *driver)
{
96
    virMutexUnlock(&driver->lock);
97 98
}

99 100
static int networkShutdown(void);

101 102 103 104 105 106 107
static int networkStartNetwork(struct network_driver *driver,
                               virNetworkObjPtr network);

static int networkShutdownNetwork(struct network_driver *driver,
                                  virNetworkObjPtr network);

static int networkStartNetworkVirtual(struct network_driver *driver,
108
                                     virNetworkObjPtr network);
109

110 111 112 113 114 115 116
static int networkShutdownNetworkVirtual(struct network_driver *driver,
                                        virNetworkObjPtr network);

static int networkStartNetworkExternal(struct network_driver *driver,
                                     virNetworkObjPtr network);

static int networkShutdownNetworkExternal(struct network_driver *driver,
117
                                        virNetworkObjPtr network);
118

119 120
static void networkReloadIptablesRules(struct network_driver *driver);

121 122
static struct network_driver *driverState = NULL;

123
static char *
124
networkDnsmasqLeaseFileNameDefault(const char *netname)
125 126 127 128 129 130 131 132
{
    char *leasefile;

    virAsprintf(&leasefile, DNSMASQ_STATE_DIR "/%s.leases",
                netname);
    return leasefile;
}

133 134 135
networkDnsmasqLeaseFileNameFunc networkDnsmasqLeaseFileName =
    networkDnsmasqLeaseFileNameDefault;

136 137 138 139 140 141 142 143 144 145 146 147 148 149 150 151 152 153 154
static char *
networkRadvdPidfileBasename(const char *netname)
{
    /* this is simple but we want to be sure it's consistently done */
    char *pidfilebase;

    virAsprintf(&pidfilebase, "%s-radvd", netname);
    return pidfilebase;
}

static char *
networkRadvdConfigFileName(const char *netname)
{
    char *configfile;

    virAsprintf(&configfile, RADVD_STATE_DIR "/%s-radvd.conf",
                netname);
    return configfile;
}
155

156 157 158
static char *
networkBridgeDummyNicName(const char *brname)
{
159
    static const char dummyNicSuffix[] = "-nic";
160 161
    char *nicname;

162 163 164 165 166 167 168 169 170 171 172 173 174 175
    if (strlen(brname) + sizeof(dummyNicSuffix) > IFNAMSIZ) {
        /* because the length of an ifname is limited to IFNAMSIZ-1
         * (usually 15), and we're adding 4 more characters, we must
         * truncate the original name to 11 to fit. In order to catch
         * a possible numeric ending (eg virbr0, virbr1, etc), we grab
         * the first 8 and last 3 characters of the string.
         */
         virAsprintf(&nicname, "%.*s%s%s",
                     /* space for last 3 chars + "-nic" + NULL */
                     (int)(IFNAMSIZ - (3 + sizeof(dummyNicSuffix))),
                     brname, brname + strlen(brname) - 3, dummyNicSuffix);
    } else {
         virAsprintf(&nicname, "%s%s", brname, dummyNicSuffix);
    }
176 177 178
    return nicname;
}

179 180 181 182 183 184 185 186 187 188 189
static void
networkFindActiveConfigs(struct network_driver *driver) {
    unsigned int i;

    for (i = 0 ; i < driver->networks.count ; i++) {
        virNetworkObjPtr obj = driver->networks.objs[i];
        virNetworkDefPtr tmp;
        char *config;

        virNetworkObjLock(obj);

190
        if ((config = virNetworkConfigFile(NETWORK_STATE_DIR,
191 192 193 194 195 196 197 198 199 200 201 202
                                           obj->def->name)) == NULL) {
            virNetworkObjUnlock(obj);
            continue;
        }

        if (access(config, R_OK) < 0) {
            VIR_FREE(config);
            virNetworkObjUnlock(obj);
            continue;
        }

        /* Try and load the live config */
203
        tmp = virNetworkDefParseFile(config);
204 205 206 207 208 209 210 211 212 213 214
        VIR_FREE(config);
        if (tmp) {
            obj->newDef = obj->def;
            obj->def = tmp;
        }

        /* If bridge exists, then mark it active */
        if (obj->def->bridge &&
            brHasBridge(driver->brctl, obj->def->bridge) == 0) {
            obj->active = 1;

215 216 217 218 219 220 221 222 223 224 225 226 227 228 229 230 231
            /* Try and read dnsmasq/radvd pids if any */
            if (obj->def->ips && (obj->def->nips > 0)) {
                char *pidpath, *radvdpidbase;

                if (virFileReadPid(NETWORK_PID_DIR, obj->def->name,
                                   &obj->dnsmasqPid) == 0) {
                    /* Check that it's still alive */
                    if (kill(obj->dnsmasqPid, 0) != 0)
                        obj->dnsmasqPid = -1;
                    if (virAsprintf(&pidpath, "/proc/%d/exe", obj->dnsmasqPid) < 0) {
                        virReportOOMError();
                        goto cleanup;
                    }
                    if (virFileLinkPointsTo(pidpath, DNSMASQ) == 0)
                        obj->dnsmasqPid = -1;
                    VIR_FREE(pidpath);
                }
232

233
                if (!(radvdpidbase = networkRadvdPidfileBasename(obj->def->name))) {
234
                    virReportOOMError();
235 236
                    goto cleanup;
                }
237 238 239 240 241 242 243 244 245 246 247 248 249 250 251
                if (virFileReadPid(NETWORK_PID_DIR, radvdpidbase,
                                   &obj->radvdPid) == 0) {
                    /* Check that it's still alive */
                    if (kill(obj->radvdPid, 0) != 0)
                        obj->radvdPid = -1;
                    if (virAsprintf(&pidpath, "/proc/%d/exe", obj->radvdPid) < 0) {
                        virReportOOMError();
                        VIR_FREE(radvdpidbase);
                        goto cleanup;
                    }
                    if (virFileLinkPointsTo(pidpath, RADVD) == 0)
                        obj->radvdPid = -1;
                    VIR_FREE(pidpath);
                }
                VIR_FREE(radvdpidbase);
252 253 254
            }
        }

255
    cleanup:
256 257 258 259 260
        virNetworkObjUnlock(obj);
    }
}


261 262 263
static void
networkAutostartConfigs(struct network_driver *driver) {
    unsigned int i;
264

265
    for (i = 0 ; i < driver->networks.count ; i++) {
266
        virNetworkObjLock(driver->networks.objs[i]);
267
        if (driver->networks.objs[i]->autostart &&
268 269
            !virNetworkObjIsActive(driver->networks.objs[i])) {
            if (networkStartNetwork(driver, driver->networks.objs[i]) < 0) {
270
            /* failed to start but already logged */
271
            }
272
        }
273
        virNetworkObjUnlock(driver->networks.objs[i]);
274 275 276 277 278 279 280 281 282
    }
}

/**
 * networkStartup:
 *
 * Initialization function for the QEmu daemon
 */
static int
283
networkStartup(int privileged) {
284 285
    uid_t uid = geteuid();
    char *base = NULL;
286
    int err;
287 288

    if (VIR_ALLOC(driverState) < 0)
289
        goto error;
290

291 292 293 294
    if (virMutexInit(&driverState->lock) < 0) {
        VIR_FREE(driverState);
        goto error;
    }
295 296
    networkDriverLock(driverState);

297
    if (privileged) {
298
        if (virAsprintf(&driverState->logDir,
299
                        "%s/log/libvirt/qemu", LOCALSTATEDIR) == -1)
300 301
            goto out_of_memory;

302
        if ((base = strdup (SYSCONFDIR "/libvirt")) == NULL)
303 304
            goto out_of_memory;
    } else {
305
        char *userdir = virGetUserDirectory(uid);
306 307 308

        if (!userdir)
            goto error;
309

310
        if (virAsprintf(&driverState->logDir,
311 312
                        "%s/.libvirt/qemu/log", userdir) == -1) {
            VIR_FREE(userdir);
313
            goto out_of_memory;
314
        }
315

316 317
        if (virAsprintf(&base, "%s/.libvirt", userdir) == -1) {
            VIR_FREE(userdir);
318 319
            goto out_of_memory;
        }
320
        VIR_FREE(userdir);
321 322 323 324 325
    }

    /* Configuration paths are either ~/.libvirt/qemu/... (session) or
     * /etc/libvirt/qemu/... (system).
     */
326
    if (virAsprintf(&driverState->networkConfigDir, "%s/qemu/networks", base) == -1)
327 328
        goto out_of_memory;

329 330
    if (virAsprintf(&driverState->networkAutostartDir, "%s/qemu/networks/autostart",
                    base) == -1)
331 332 333 334
        goto out_of_memory;

    VIR_FREE(base);

335
    if ((err = brInit(&driverState->brctl))) {
336
        virReportSystemError(err, "%s",
337 338 339 340 341
                             _("cannot initialize bridge support"));
        goto error;
    }

    if (!(driverState->iptables = iptablesContextNew())) {
342
        goto out_of_memory;
343 344 345
    }


346
    if (virNetworkLoadAllConfigs(&driverState->networks,
347
                                 driverState->networkConfigDir,
348 349 350
                                 driverState->networkAutostartDir) < 0)
        goto error;

351
    networkFindActiveConfigs(driverState);
352
    networkReloadIptablesRules(driverState);
353 354
    networkAutostartConfigs(driverState);

355 356
    networkDriverUnlock(driverState);

357 358
    return 0;

359
out_of_memory:
360
    virReportOOMError();
361 362

error:
363 364 365
    if (driverState)
        networkDriverUnlock(driverState);

366
    VIR_FREE(base);
367
    networkShutdown();
368 369 370 371 372 373 374 375 376 377 378
    return -1;
}

/**
 * networkReload:
 *
 * Function to restart the QEmu daemon, it will recheck the configuration
 * files and update its state and the networking
 */
static int
networkReload(void) {
379 380 381
    if (!driverState)
        return 0;

382
    networkDriverLock(driverState);
383
    virNetworkLoadAllConfigs(&driverState->networks,
384 385
                             driverState->networkConfigDir,
                             driverState->networkAutostartDir);
386
    networkReloadIptablesRules(driverState);
387
    networkAutostartConfigs(driverState);
388
    networkDriverUnlock(driverState);
389 390 391 392 393 394 395 396 397 398 399 400 401
    return 0;
}

/**
 * networkActive:
 *
 * Checks if the QEmu daemon is active, i.e. has an active domain or
 * an active network
 *
 * Returns 1 if active, 0 otherwise
 */
static int
networkActive(void) {
402
    unsigned int i;
403
    int active = 0;
404

405 406 407
    if (!driverState)
        return 0;

408
    networkDriverLock(driverState);
409 410
    for (i = 0 ; i < driverState->networks.count ; i++) {
        virNetworkObjPtr net = driverState->networks.objs[i];
411
        virNetworkObjLock(net);
D
Daniel P. Berrange 已提交
412
        if (virNetworkObjIsActive(net))
413
            active = 1;
414
        virNetworkObjUnlock(net);
415
    }
416
    networkDriverUnlock(driverState);
417
    return active;
418 419 420 421 422 423 424 425 426 427 428 429
}

/**
 * networkShutdown:
 *
 * Shutdown the QEmu daemon, it will stop all active domains and networks
 */
static int
networkShutdown(void) {
    if (!driverState)
        return -1;

430 431
    networkDriverLock(driverState);

432
    /* free inactive networks */
433
    virNetworkObjListFree(&driverState->networks);
434 435 436 437 438 439 440 441 442 443

    VIR_FREE(driverState->logDir);
    VIR_FREE(driverState->networkConfigDir);
    VIR_FREE(driverState->networkAutostartDir);

    if (driverState->brctl)
        brShutdown(driverState->brctl);
    if (driverState->iptables)
        iptablesContextFree(driverState->iptables);

444
    networkDriverUnlock(driverState);
445
    virMutexDestroy(&driverState->lock);
446

447 448 449 450 451 452
    VIR_FREE(driverState);

    return 0;
}


453 454 455 456
static int
networkBuildDnsmasqHostsfile(dnsmasqContext *dctx,
                             virNetworkIpDefPtr ipdef,
                             virNetworkDNSDefPtr dnsdef)
457
{
458
    unsigned int i, j;
459

460 461 462
    for (i = 0; i < ipdef->nhosts; i++) {
        virNetworkDHCPHostDefPtr host = &(ipdef->hosts[i]);
        if ((host->mac) && VIR_SOCKET_HAS_ADDR(&host->ip))
463 464
            if (dnsmasqAddDhcpHost(dctx, host->mac, &host->ip, host->name) < 0)
                return -1;
465
    }
466

467 468 469 470 471
    if (dnsdef) {
        for (i = 0; i < dnsdef->nhosts; i++) {
            virNetworkDNSHostsDefPtr host = &(dnsdef->hosts[i]);
            if (VIR_SOCKET_HAS_ADDR(&host->ip)) {
                for (j = 0; j < host->nnames; j++)
472 473
                    if (dnsmasqAddHost(dctx, &host->ip, host->names[j]) < 0)
                        return -1;
474 475
            }
        }
476 477
    }

478
    return 0;
479 480 481
}


482
static int
483
networkBuildDnsmasqArgv(virNetworkObjPtr network,
484
                        virNetworkIpDefPtr ipdef,
485
                        const char *pidfile,
486 487 488
                        virCommandPtr cmd,
                        dnsmasqContext *dctx)
{
489
    int r, ret = -1;
490
    int nbleases = 0;
491 492
    int ii;
    virNetworkIpDefPtr tmpipdef;
493 494

    /*
495
     * NB, be careful about syntax for dnsmasq options in long format.
496 497 498 499 500 501 502 503 504 505 506 507 508
     *
     * If the flag has a mandatory argument, it can be given using
     * either syntax:
     *
     *     --foo bar
     *     --foo=bar
     *
     * If the flag has a optional argument, it *must* be given using
     * the syntax:
     *
     *     --foo=bar
     *
     * It is hard to determine whether a flag is optional or not,
509 510
     * without reading the dnsmasq source :-( The manpage is not
     * very explicit on this.
511
     */
512 513 514 515 516

    /*
     * Needed to ensure dnsmasq uses same algorithm for processing
     * multiple namedriver entries in /etc/resolv.conf as GLibC.
     */
517
    virCommandAddArgList(cmd, "--strict-order", "--bind-interfaces", NULL);
518

519 520
    if (network->def->domain)
        virCommandAddArgList(cmd, "--domain", network->def->domain, NULL);
521

522 523
    if (pidfile)
        virCommandAddArgPair(cmd, "--pid-file", pidfile);
524

525
    /* *no* conf file */
526
    virCommandAddArg(cmd, "--conf-file=");
527

528 529 530
    virCommandAddArgList(cmd,
                         "--except-interface", "lo",
                         NULL);
531

532 533 534 535 536 537 538
    /* If this is an isolated network, set the default route option
     * (3) to be empty to avoid setting a default route that's
     * guaranteed to not work.
     */
    if (network->def->forwardType == VIR_NETWORK_FORWARD_NONE)
        virCommandAddArg(cmd, "--dhcp-option=3");

539 540 541 542 543 544 545 546 547 548 549 550 551 552 553 554 555 556
    if (network->def->dns != NULL) {
        virNetworkDNSDefPtr dns = network->def->dns;
        int i;

        for (i = 0; i < dns->ntxtrecords; i++) {
            char *record = NULL;
            if (virAsprintf(&record, "%s,%s",
                            dns->txtrecords[i].name,
                            dns->txtrecords[i].value) < 0) {
                virReportOOMError();
                goto cleanup;
            }

            virCommandAddArgPair(cmd, "--txt-record", record);
            VIR_FREE(record);
        }
    }

557 558 559 560 561 562 563 564 565 566 567 568 569 570 571 572 573 574
    /*
     * --interface does not actually work with dnsmasq < 2.47,
     * due to DAD for ipv6 addresses on the interface.
     *
     * virCommandAddArgList(cmd, "--interface", ipdef->bridge, NULL);
     *
     * So listen on all defined IPv[46] addresses
     */
    for (ii = 0;
         (tmpipdef = virNetworkDefGetIpByIndex(network->def, AF_UNSPEC, ii));
         ii++) {
        char *ipaddr = virSocketFormatAddr(&tmpipdef->address);
        if (!ipaddr)
            goto cleanup;
        virCommandAddArgList(cmd, "--listen-address", ipaddr, NULL);
        VIR_FREE(ipaddr);
    }

575
    if (ipdef) {
576 577 578 579 580 581 582 583 584 585 586
        for (r = 0 ; r < ipdef->nranges ; r++) {
            char *saddr = virSocketFormatAddr(&ipdef->ranges[r].start);
            if (!saddr)
                goto cleanup;
            char *eaddr = virSocketFormatAddr(&ipdef->ranges[r].end);
            if (!eaddr) {
                VIR_FREE(saddr);
                goto cleanup;
            }
            virCommandAddArg(cmd, "--dhcp-range");
            virCommandAddArgFormat(cmd, "%s,%s", saddr, eaddr);
587
            VIR_FREE(saddr);
588 589 590
            VIR_FREE(eaddr);
            nbleases += virSocketGetRange(&ipdef->ranges[r].start,
                                          &ipdef->ranges[r].end);
591
        }
592

593 594 595 596 597 598 599 600 601 602 603 604 605
        /*
         * For static-only DHCP, i.e. with no range but at least one host element,
         * we have to add a special --dhcp-range option to enable the service in
         * dnsmasq.
         */
        if (!ipdef->nranges && ipdef->nhosts) {
            char *bridgeaddr = virSocketFormatAddr(&ipdef->address);
            if (!bridgeaddr)
                goto cleanup;
            virCommandAddArg(cmd, "--dhcp-range");
            virCommandAddArgFormat(cmd, "%s,static", bridgeaddr);
            VIR_FREE(bridgeaddr);
        }
606

607
        if (ipdef->nranges > 0) {
608 609 610 611 612
            char *leasefile = networkDnsmasqLeaseFileName(network->def->name);
            if (!leasefile)
                goto cleanup;
            virCommandAddArgFormat(cmd, "--dhcp-leasefile=%s", leasefile);
            VIR_FREE(leasefile);
613 614
            virCommandAddArgFormat(cmd, "--dhcp-lease-max=%d", nbleases);
        }
615

616 617
        if (ipdef->nranges || ipdef->nhosts)
            virCommandAddArg(cmd, "--dhcp-no-override");
618

619 620 621 622
        /* add domain to any non-qualified hostnames in /etc/hosts or addn-hosts */
        if (network->def->domain)
           virCommandAddArg(cmd, "--expand-hosts");

623 624 625 626 627 628 629 630 631
        if (networkBuildDnsmasqHostsfile(dctx, ipdef, network->def->dns) < 0)
            goto cleanup;

        if (dctx->hostsfile->nhosts)
            virCommandAddArgPair(cmd, "--dhcp-hostsfile",
                                 dctx->hostsfile->path);
        if (dctx->addnhostsfile->nhosts)
            virCommandAddArgPair(cmd, "--addn-hosts",
                                 dctx->addnhostsfile->path);
632

633 634 635 636 637 638 639 640 641
        if (ipdef->tftproot) {
            virCommandAddArgList(cmd, "--enable-tftp",
                                 "--tftp-root", ipdef->tftproot,
                                 NULL);
        }
        if (ipdef->bootfile) {
            virCommandAddArg(cmd, "--dhcp-boot");
            if (VIR_SOCKET_HAS_ADDR(&ipdef->bootserver)) {
                char *bootserver = virSocketFormatAddr(&ipdef->bootserver);
642

643 644 645 646 647 648 649 650
                if (!bootserver)
                    goto cleanup;
                virCommandAddArgFormat(cmd, "%s%s%s",
                                       ipdef->bootfile, ",,", bootserver);
                VIR_FREE(bootserver);
            } else {
                virCommandAddArg(cmd, ipdef->bootfile);
            }
651
        }
652 653
    }

654 655 656
    ret = 0;
cleanup:
    return ret;
657 658
}

659 660
int
networkBuildDhcpDaemonCommandLine(virNetworkObjPtr network, virCommandPtr *cmdout,
661
                                  char *pidfile, dnsmasqContext *dctx)
662
{
663
    virCommandPtr cmd = NULL;
664
    int ret = -1, ii;
665
    virNetworkIpDefPtr ipdef;
666 667

    network->dnsmasqPid = -1;
668

669 670 671 672 673 674 675
    /* Look for first IPv4 address that has dhcp defined. */
    /* We support dhcp config on 1 IPv4 interface only. */
    for (ii = 0;
         (ipdef = virNetworkDefGetIpByIndex(network->def, AF_INET, ii));
         ii++) {
        if (ipdef->nranges || ipdef->nhosts)
            break;
676
    }
677
    /* If no IPv4 addresses had dhcp info, pick the first (if there were any). */
678
    if (!ipdef)
679 680 681 682 683 684 685 686
        ipdef = virNetworkDefGetIpByIndex(network->def, AF_INET, 0);

    /* If there are no IP addresses at all (v4 or v6), return now, since
     * there won't be any address for dnsmasq to listen on anyway.
     * If there are any addresses, even if no dhcp ranges or static entries,
     * we should continue and run dnsmasq, just for the DNS capabilities.
     */
    if (!virNetworkDefGetIpByIndex(network->def, AF_UNSPEC, 0))
687
        return 0;
688

689
    cmd = virCommandNew(DNSMASQ);
690
    if (networkBuildDnsmasqArgv(network, ipdef, pidfile, cmd, dctx) < 0) {
691 692 693 694 695 696 697 698 699 700 701 702 703 704 705 706 707 708
        goto cleanup;
    }

    if (cmdout)
        *cmdout = cmd;
    ret = 0;
cleanup:
    if (ret < 0)
        virCommandFree(cmd);
    return ret;
}

static int
networkStartDhcpDaemon(virNetworkObjPtr network)
{
    virCommandPtr cmd = NULL;
    char *pidfile = NULL;
    int ret = -1;
709
    dnsmasqContext *dctx = NULL;
710

711 712
    if (virFileMakePath(NETWORK_PID_DIR) < 0) {
        virReportSystemError(errno,
713 714
                             _("cannot create directory %s"),
                             NETWORK_PID_DIR);
715
        goto cleanup;
716
    }
717 718
    if (virFileMakePath(NETWORK_STATE_DIR) < 0) {
        virReportSystemError(errno,
719 720
                             _("cannot create directory %s"),
                             NETWORK_STATE_DIR);
721
        goto cleanup;
722 723 724
    }

    if (!(pidfile = virFilePid(NETWORK_PID_DIR, network->def->name))) {
725
        virReportOOMError();
726
        goto cleanup;
727 728
    }

729 730
    if (virFileMakePath(DNSMASQ_STATE_DIR) < 0) {
        virReportSystemError(errno,
731 732 733 734 735
                             _("cannot create directory %s"),
                             DNSMASQ_STATE_DIR);
        goto cleanup;
    }

736 737 738 739 740 741 742 743 744 745
    dctx = dnsmasqContextNew(network->def->name, DNSMASQ_STATE_DIR);
    if (dctx == NULL)
        goto cleanup;

    ret = networkBuildDhcpDaemonCommandLine(network, &cmd, pidfile, dctx);
    if (ret < 0)
        goto cleanup;

    ret = dnsmasqSave(dctx);
    if (ret < 0)
746
        goto cleanup;
747

748
    if (virCommandRun(cmd, NULL) < 0)
749 750 751
        goto cleanup;

    /*
752 753 754 755 756
     * There really is no race here - when dnsmasq daemonizes, its
     * leader process stays around until its child has actually
     * written its pidfile. So by time virCommandRun exits it has
     * waitpid'd and guaranteed the proess has started and written a
     * pid
757 758 759 760 761
     */

    if (virFileReadPid(NETWORK_PID_DIR, network->def->name,
                       &network->dnsmasqPid) < 0)
        goto cleanup;
762

763 764 765
    ret = 0;
cleanup:
    VIR_FREE(pidfile);
766
    virCommandFree(cmd);
767
    dnsmasqContextFree(dctx);
768 769 770
    return ret;
}

771 772 773 774 775 776 777 778 779
static int
networkStartRadvd(virNetworkObjPtr network)
{
    char *pidfile = NULL;
    char *radvdpidbase = NULL;
    virBuffer configbuf = VIR_BUFFER_INITIALIZER;;
    char *configstr = NULL;
    char *configfile = NULL;
    virCommandPtr cmd = NULL;
780
    int ret = -1, ii;
781 782 783 784
    virNetworkIpDefPtr ipdef;

    network->radvdPid = -1;

E
Eric Blake 已提交
785
    if (!virFileIsExecutable(RADVD)) {
786 787 788 789 790 791 792
        virReportSystemError(errno,
                             _("Cannot find %s - "
                               "Possibly the package isn't installed"),
                             RADVD);
        goto cleanup;
    }

793 794
    if (virFileMakePath(NETWORK_PID_DIR) < 0) {
        virReportSystemError(errno,
795 796 797 798
                             _("cannot create directory %s"),
                             NETWORK_PID_DIR);
        goto cleanup;
    }
799 800
    if (virFileMakePath(RADVD_STATE_DIR) < 0) {
        virReportSystemError(errno,
801 802 803 804 805 806 807 808 809 810 811 812 813 814 815 816
                             _("cannot create directory %s"),
                             RADVD_STATE_DIR);
        goto cleanup;
    }

    /* construct pidfile name */
    if (!(radvdpidbase = networkRadvdPidfileBasename(network->def->name))) {
        virReportOOMError();
        goto cleanup;
    }
    if (!(pidfile = virFilePid(NETWORK_PID_DIR, radvdpidbase))) {
        virReportOOMError();
        goto cleanup;
    }

    /* create radvd config file appropriate for this network */
817
    virBufferAsprintf(&configbuf, "interface %s\n"
818 819 820 821 822 823 824 825 826 827 828 829 830 831 832 833 834 835 836 837 838
                      "{\n"
                      "  AdvSendAdvert on;\n"
                      "  AdvManagedFlag off;\n"
                      "  AdvOtherConfigFlag off;\n"
                      "\n",
                      network->def->bridge);
    for (ii = 0;
         (ipdef = virNetworkDefGetIpByIndex(network->def, AF_INET6, ii));
         ii++) {
        int prefix;
        char *netaddr;

        prefix = virNetworkIpDefPrefix(ipdef);
        if (prefix < 0) {
            networkReportError(VIR_ERR_INTERNAL_ERROR,
                               _("bridge  '%s' has an invalid prefix"),
                               network->def->bridge);
            goto cleanup;
        }
        if (!(netaddr = virSocketFormatAddr(&ipdef->address)))
            goto cleanup;
839
        virBufferAsprintf(&configbuf,
840 841 842 843 844 845 846 847 848 849 850 851 852 853 854 855 856 857 858 859 860 861 862 863 864 865 866 867 868 869 870 871 872 873 874 875 876 877 878 879 880 881 882 883 884 885 886 887 888 889 890 891 892 893 894 895 896 897 898 899 900 901 902 903 904 905 906 907 908
                          "  prefix %s/%d\n"
                          "  {\n"
                          "    AdvOnLink on;\n"
                          "    AdvAutonomous on;\n"
                          "    AdvRouterAddr off;\n"
                          "  };\n",
                          netaddr, prefix);
        VIR_FREE(netaddr);
    }

    virBufferAddLit(&configbuf, "};\n");

    if (virBufferError(&configbuf)) {
        virReportOOMError();
        goto cleanup;
    }
    if (!(configstr = virBufferContentAndReset(&configbuf))) {
        virReportOOMError();
        goto cleanup;
    }

    /* construct the filename */
    if (!(configfile = networkRadvdConfigFileName(network->def->name))) {
        virReportOOMError();
        goto cleanup;
    }
    /* write the file */
    if (virFileWriteStr(configfile, configstr, 0600) < 0) {
        virReportSystemError(errno,
                             _("couldn't write radvd config file '%s'"),
                             configfile);
        goto cleanup;
    }

    /* prevent radvd from daemonizing itself with "--debug 1", and use
     * a dummy pidfile name - virCommand will create the pidfile we
     * want to use (this is necessary because radvd's internal
     * daemonization and pidfile creation causes a race, and the
     * virFileReadPid() below will fail if we use them).
     * Unfortunately, it isn't possible to tell radvd to not create
     * its own pidfile, so we just let it do so, with a slightly
     * different name. Unused, but harmless.
     */
    cmd = virCommandNewArgList(RADVD, "--debug", "1",
                               "--config", configfile,
                               "--pidfile", NULL);
    virCommandAddArgFormat(cmd, "%s-bin", pidfile);

    virCommandSetPidFile(cmd, pidfile);
    virCommandDaemonize(cmd);

    if (virCommandRun(cmd, NULL) < 0)
        goto cleanup;

    if (virFileReadPid(NETWORK_PID_DIR, radvdpidbase,
                       &network->radvdPid) < 0)
        goto cleanup;

    ret = 0;
cleanup:
    virCommandFree(cmd);
    VIR_FREE(configfile);
    VIR_FREE(configstr);
    virBufferFreeAndReset(&configbuf);
    VIR_FREE(radvdpidbase);
    VIR_FREE(pidfile);
    return ret;
}

909
static int
910
networkAddMasqueradingIptablesRules(struct network_driver *driver,
911 912
                                    virNetworkObjPtr network,
                                    virNetworkIpDefPtr ipdef)
913 914
{
    int prefix = virNetworkIpDefPrefix(ipdef);
915
    const char *forwardIf = virNetworkDefForwardIf(network->def, 0);
916 917 918 919 920 921 922

    if (prefix < 0) {
        networkReportError(VIR_ERR_INTERNAL_ERROR,
                           _("Invalid prefix or netmask for '%s'"),
                           network->def->bridge);
        goto masqerr1;
    }
923

924
    /* allow forwarding packets from the bridge interface */
925
    if (iptablesAddForwardAllowOut(driver->iptables,
926
                                   &ipdef->address,
927
                                   prefix,
928
                                   network->def->bridge,
929
                                   forwardIf) < 0) {
930 931 932
        networkReportError(VIR_ERR_SYSTEM_ERROR,
                           _("failed to add iptables rule to allow forwarding from '%s'"),
                           network->def->bridge);
933 934 935
        goto masqerr1;
    }

936 937 938
    /* allow forwarding packets to the bridge interface if they are
     * part of an existing connection
     */
939
    if (iptablesAddForwardAllowRelatedIn(driver->iptables,
940
                                         &ipdef->address,
941
                                         prefix,
942
                                         network->def->bridge,
943
                                         forwardIf) < 0) {
944 945 946
        networkReportError(VIR_ERR_SYSTEM_ERROR,
                           _("failed to add iptables rule to allow forwarding to '%s'"),
                           network->def->bridge);
947 948 949
        goto masqerr2;
    }

950 951 952 953 954
    /*
     * Enable masquerading.
     *
     * We need to end up with 3 rules in the table in this order
     *
E
Eric Blake 已提交
955 956
     *  1. protocol=tcp with sport mapping restriction
     *  2. protocol=udp with sport mapping restriction
957 958 959
     *  3. generic any protocol
     *
     * The sport mappings are required, because default IPtables
E
Eric Blake 已提交
960
     * MASQUERADE maintain port numbers unchanged where possible.
961 962 963 964 965 966 967 968 969 970 971 972 973
     *
     * NFS can be configured to only "trust" port numbers < 1023.
     *
     * Guests using NAT thus need to be prevented from having port
     * numbers < 1023, otherwise they can bypass the NFS "security"
     * check on the source port number.
     *
     * Since we use '--insert' to add rules to the header of the
     * chain, we actually need to add them in the reverse of the
     * order just mentioned !
     */

    /* First the generic masquerade rule for other protocols */
974
    if (iptablesAddForwardMasquerade(driver->iptables,
975
                                     &ipdef->address,
976
                                     prefix,
977
                                     forwardIf,
978 979
                                     NULL) < 0) {
        networkReportError(VIR_ERR_SYSTEM_ERROR,
980 981 982 983
                           forwardIf ?
                           _("failed to add iptables rule to enable masquerading to %s") :
                           _("failed to add iptables rule to enable masquerading"),
                           forwardIf);
984 985 986
        goto masqerr3;
    }

987
    /* UDP with a source port restriction */
988
    if (iptablesAddForwardMasquerade(driver->iptables,
989
                                     &ipdef->address,
990
                                     prefix,
991
                                     forwardIf,
992 993
                                     "udp") < 0) {
        networkReportError(VIR_ERR_SYSTEM_ERROR,
994 995 996 997
                           forwardIf ?
                           _("failed to add iptables rule to enable UDP masquerading to %s") :
                           _("failed to add iptables rule to enable UDP masquerading"),
                           forwardIf);
998 999 1000 1001
        goto masqerr4;
    }

    /* TCP with a source port restriction */
1002
    if (iptablesAddForwardMasquerade(driver->iptables,
1003
                                     &ipdef->address,
1004
                                     prefix,
1005
                                     forwardIf,
1006 1007
                                     "tcp") < 0) {
        networkReportError(VIR_ERR_SYSTEM_ERROR,
1008 1009 1010 1011
                           forwardIf ?
                           _("failed to add iptables rule to enable TCP masquerading to %s") :
                           _("failed to add iptables rule to enable TCP masquerading"),
                           forwardIf);
1012 1013 1014
        goto masqerr5;
    }

1015
    return 0;
1016

1017 1018
 masqerr5:
    iptablesRemoveForwardMasquerade(driver->iptables,
1019
                                    &ipdef->address,
1020
                                    prefix,
1021
                                    forwardIf,
1022 1023 1024
                                    "udp");
 masqerr4:
    iptablesRemoveForwardMasquerade(driver->iptables,
1025
                                    &ipdef->address,
1026
                                    prefix,
1027
                                    forwardIf,
1028
                                    NULL);
1029 1030
 masqerr3:
    iptablesRemoveForwardAllowRelatedIn(driver->iptables,
1031
                                        &ipdef->address,
1032
                                        prefix,
1033
                                        network->def->bridge,
1034
                                        forwardIf);
1035 1036
 masqerr2:
    iptablesRemoveForwardAllowOut(driver->iptables,
1037
                                  &ipdef->address,
1038
                                  prefix,
1039
                                  network->def->bridge,
1040
                                  forwardIf);
1041
 masqerr1:
1042
    return -1;
1043 1044
}

1045 1046 1047 1048 1049 1050
static void
networkRemoveMasqueradingIptablesRules(struct network_driver *driver,
                                       virNetworkObjPtr network,
                                       virNetworkIpDefPtr ipdef)
{
    int prefix = virNetworkIpDefPrefix(ipdef);
1051
    const char *forwardIf = virNetworkDefForwardIf(network->def, 0);
1052 1053 1054 1055 1056

    if (prefix >= 0) {
        iptablesRemoveForwardMasquerade(driver->iptables,
                                        &ipdef->address,
                                        prefix,
1057
                                        forwardIf,
1058 1059 1060 1061
                                        "tcp");
        iptablesRemoveForwardMasquerade(driver->iptables,
                                        &ipdef->address,
                                        prefix,
1062
                                        forwardIf,
1063 1064 1065 1066
                                        "udp");
        iptablesRemoveForwardMasquerade(driver->iptables,
                                        &ipdef->address,
                                        prefix,
1067
                                        forwardIf,
1068 1069 1070 1071 1072 1073
                                        NULL);

        iptablesRemoveForwardAllowRelatedIn(driver->iptables,
                                            &ipdef->address,
                                            prefix,
                                            network->def->bridge,
1074
                                            forwardIf);
1075 1076 1077 1078
        iptablesRemoveForwardAllowOut(driver->iptables,
                                      &ipdef->address,
                                      prefix,
                                      network->def->bridge,
1079
                                      forwardIf);
1080 1081 1082
    }
}

1083
static int
1084
networkAddRoutingIptablesRules(struct network_driver *driver,
1085
                               virNetworkObjPtr network,
1086 1087
                               virNetworkIpDefPtr ipdef)
{
1088
    int prefix = virNetworkIpDefPrefix(ipdef);
1089
    const char *forwardIf = virNetworkDefForwardIf(network->def, 0);
1090 1091 1092 1093 1094 1095 1096

    if (prefix < 0) {
        networkReportError(VIR_ERR_INTERNAL_ERROR,
                           _("Invalid prefix or netmask for '%s'"),
                           network->def->bridge);
        goto routeerr1;
    }
1097

1098
    /* allow routing packets from the bridge interface */
1099
    if (iptablesAddForwardAllowOut(driver->iptables,
1100
                                   &ipdef->address,
1101
                                   prefix,
1102
                                   network->def->bridge,
1103
                                   forwardIf) < 0) {
1104 1105 1106
        networkReportError(VIR_ERR_SYSTEM_ERROR,
                           _("failed to add iptables rule to allow routing from '%s'"),
                           network->def->bridge);
1107 1108 1109 1110
        goto routeerr1;
    }

    /* allow routing packets to the bridge interface */
1111
    if (iptablesAddForwardAllowIn(driver->iptables,
1112
                                  &ipdef->address,
1113
                                  prefix,
1114
                                  network->def->bridge,
1115
                                  forwardIf) < 0) {
1116 1117 1118
        networkReportError(VIR_ERR_SYSTEM_ERROR,
                           _("failed to add iptables rule to allow routing to '%s'"),
                           network->def->bridge);
1119 1120 1121
        goto routeerr2;
    }

1122
    return 0;
1123

1124
routeerr2:
1125
    iptablesRemoveForwardAllowOut(driver->iptables,
1126
                                  &ipdef->address,
1127
                                  prefix,
1128
                                  network->def->bridge,
1129
                                  forwardIf);
1130
routeerr1:
1131
    return -1;
1132 1133
}

1134 1135 1136 1137 1138 1139
static void
networkRemoveRoutingIptablesRules(struct network_driver *driver,
                                  virNetworkObjPtr network,
                                  virNetworkIpDefPtr ipdef)
{
    int prefix = virNetworkIpDefPrefix(ipdef);
1140
    const char *forwardIf = virNetworkDefForwardIf(network->def, 0);
1141 1142 1143 1144 1145 1146

    if (prefix >= 0) {
        iptablesRemoveForwardAllowIn(driver->iptables,
                                     &ipdef->address,
                                     prefix,
                                     network->def->bridge,
1147
                                     forwardIf);
1148 1149 1150 1151 1152

        iptablesRemoveForwardAllowOut(driver->iptables,
                                      &ipdef->address,
                                      prefix,
                                      network->def->bridge,
1153
                                      forwardIf);
1154 1155 1156
    }
}

1157 1158 1159 1160 1161 1162 1163 1164 1165 1166 1167 1168 1169 1170 1171 1172 1173 1174 1175 1176 1177 1178 1179 1180 1181 1182 1183 1184 1185 1186 1187 1188 1189 1190 1191 1192
/* Add all once/network rules required for IPv6 (if any IPv6 addresses are defined) */
static int
networkAddGeneralIp6tablesRules(struct network_driver *driver,
                               virNetworkObjPtr network)
{

    if (!virNetworkDefGetIpByIndex(network->def, AF_INET6, 0))
        return 0;

    /* Catch all rules to block forwarding to/from bridges */

    if (iptablesAddForwardRejectOut(driver->iptables, AF_INET6,
                                    network->def->bridge) < 0) {
        networkReportError(VIR_ERR_SYSTEM_ERROR,
                           _("failed to add ip6tables rule to block outbound traffic from '%s'"),
                           network->def->bridge);
        goto err1;
    }

    if (iptablesAddForwardRejectIn(driver->iptables, AF_INET6,
                                   network->def->bridge) < 0) {
        networkReportError(VIR_ERR_SYSTEM_ERROR,
                           _("failed to add ip6tables rule to block inbound traffic to '%s'"),
                           network->def->bridge);
        goto err2;
    }

    /* Allow traffic between guests on the same bridge */
    if (iptablesAddForwardAllowCross(driver->iptables, AF_INET6,
                                     network->def->bridge) < 0) {
        networkReportError(VIR_ERR_SYSTEM_ERROR,
                           _("failed to add ip6tables rule to allow cross bridge traffic on '%s'"),
                           network->def->bridge);
        goto err3;
    }

1193 1194 1195 1196 1197 1198 1199 1200 1201 1202 1203 1204 1205 1206 1207 1208 1209
    /* allow DNS over IPv6 */
    if (iptablesAddTcpInput(driver->iptables, AF_INET6,
                            network->def->bridge, 53) < 0) {
        networkReportError(VIR_ERR_SYSTEM_ERROR,
                           _("failed to add ip6tables rule to allow DNS requests from '%s'"),
                           network->def->bridge);
        goto err4;
    }

    if (iptablesAddUdpInput(driver->iptables, AF_INET6,
                            network->def->bridge, 53) < 0) {
        networkReportError(VIR_ERR_SYSTEM_ERROR,
                           _("failed to add ip6tables rule to allow DNS requests from '%s'"),
                           network->def->bridge);
        goto err5;
    }

1210 1211 1212
    return 0;

    /* unwind in reverse order from the point of failure */
1213 1214 1215 1216
err5:
    iptablesRemoveTcpInput(driver->iptables, AF_INET6, network->def->bridge, 53);
err4:
    iptablesRemoveForwardAllowCross(driver->iptables, AF_INET6, network->def->bridge);
1217 1218 1219 1220 1221 1222 1223 1224 1225 1226 1227 1228 1229 1230 1231 1232 1233 1234 1235 1236
err3:
    iptablesRemoveForwardRejectIn(driver->iptables, AF_INET6, network->def->bridge);
err2:
    iptablesRemoveForwardRejectOut(driver->iptables, AF_INET6, network->def->bridge);
err1:
    return -1;
}

static void
networkRemoveGeneralIp6tablesRules(struct network_driver *driver,
                                  virNetworkObjPtr network)
{
    if (!virNetworkDefGetIpByIndex(network->def, AF_INET6, 0))
        return;

    iptablesRemoveForwardAllowCross(driver->iptables, AF_INET6, network->def->bridge);
    iptablesRemoveForwardRejectIn(driver->iptables, AF_INET6, network->def->bridge);
    iptablesRemoveForwardRejectOut(driver->iptables, AF_INET6, network->def->bridge);
}

1237
static int
1238 1239 1240 1241 1242 1243 1244 1245 1246 1247 1248 1249 1250 1251
networkAddGeneralIptablesRules(struct network_driver *driver,
                               virNetworkObjPtr network)
{
    int ii;
    virNetworkIpDefPtr ipv4def;

    /* First look for first IPv4 address that has dhcp or tftpboot defined. */
    /* We support dhcp config on 1 IPv4 interface only. */
    for (ii = 0;
         (ipv4def = virNetworkDefGetIpByIndex(network->def, AF_INET, ii));
         ii++) {
        if (ipv4def->nranges || ipv4def->nhosts || ipv4def->tftproot)
            break;
    }
1252 1253

    /* allow DHCP requests through to dnsmasq */
1254

1255 1256
    if (iptablesAddTcpInput(driver->iptables, AF_INET,
                            network->def->bridge, 67) < 0) {
1257 1258 1259
        networkReportError(VIR_ERR_SYSTEM_ERROR,
                           _("failed to add iptables rule to allow DHCP requests from '%s'"),
                           network->def->bridge);
1260 1261 1262
        goto err1;
    }

1263 1264
    if (iptablesAddUdpInput(driver->iptables, AF_INET,
                            network->def->bridge, 67) < 0) {
1265 1266 1267
        networkReportError(VIR_ERR_SYSTEM_ERROR,
                           _("failed to add iptables rule to allow DHCP requests from '%s'"),
                           network->def->bridge);
1268 1269 1270
        goto err2;
    }

1271 1272 1273 1274 1275 1276 1277 1278 1279 1280 1281
    /* If we are doing local DHCP service on this network, attempt to
     * add a rule that will fixup the checksum of DHCP response
     * packets back to the guests (but report failure without
     * aborting, since not all iptables implementations support it).
     */

    if (ipv4def && (ipv4def->nranges || ipv4def->nhosts) &&
        (iptablesAddOutputFixUdpChecksum(driver->iptables,
                                         network->def->bridge, 68) < 0)) {
        VIR_WARN("Could not add rule to fixup DHCP response checksums "
                 "on network '%s'.", network->def->name);
1282
        VIR_WARN("May need to update iptables package & kernel to support CHECKSUM rule.");
1283 1284
    }

1285
    /* allow DNS requests through to dnsmasq */
1286 1287
    if (iptablesAddTcpInput(driver->iptables, AF_INET,
                            network->def->bridge, 53) < 0) {
1288 1289 1290
        networkReportError(VIR_ERR_SYSTEM_ERROR,
                           _("failed to add iptables rule to allow DNS requests from '%s'"),
                           network->def->bridge);
1291 1292 1293
        goto err3;
    }

1294 1295
    if (iptablesAddUdpInput(driver->iptables, AF_INET,
                            network->def->bridge, 53) < 0) {
1296 1297 1298
        networkReportError(VIR_ERR_SYSTEM_ERROR,
                           _("failed to add iptables rule to allow DNS requests from '%s'"),
                           network->def->bridge);
1299 1300 1301
        goto err4;
    }

1302 1303
    /* allow TFTP requests through to dnsmasq if necessary */
    if (ipv4def && ipv4def->tftproot &&
1304 1305
        iptablesAddUdpInput(driver->iptables, AF_INET,
                            network->def->bridge, 69) < 0) {
1306 1307 1308
        networkReportError(VIR_ERR_SYSTEM_ERROR,
                           _("failed to add iptables rule to allow TFTP requests from '%s'"),
                           network->def->bridge);
1309
        goto err5;
1310 1311
    }

1312 1313
    /* Catch all rules to block forwarding to/from bridges */

1314 1315
    if (iptablesAddForwardRejectOut(driver->iptables, AF_INET,
                                    network->def->bridge) < 0) {
1316 1317 1318
        networkReportError(VIR_ERR_SYSTEM_ERROR,
                           _("failed to add iptables rule to block outbound traffic from '%s'"),
                           network->def->bridge);
1319
        goto err6;
1320 1321
    }

1322 1323
    if (iptablesAddForwardRejectIn(driver->iptables, AF_INET,
                                   network->def->bridge) < 0) {
1324 1325 1326
        networkReportError(VIR_ERR_SYSTEM_ERROR,
                           _("failed to add iptables rule to block inbound traffic to '%s'"),
                           network->def->bridge);
1327
        goto err7;
1328 1329 1330
    }

    /* Allow traffic between guests on the same bridge */
1331 1332
    if (iptablesAddForwardAllowCross(driver->iptables, AF_INET,
                                     network->def->bridge) < 0) {
1333 1334 1335
        networkReportError(VIR_ERR_SYSTEM_ERROR,
                           _("failed to add iptables rule to allow cross bridge traffic on '%s'"),
                           network->def->bridge);
1336
        goto err8;
1337 1338
    }

1339 1340 1341 1342 1343
    /* add IPv6 general rules, if needed */
    if (networkAddGeneralIp6tablesRules(driver, network) < 0) {
        goto err9;
    }

1344
    return 0;
1345

1346
    /* unwind in reverse order from the point of failure */
1347 1348
err9:
    iptablesRemoveForwardAllowCross(driver->iptables, AF_INET, network->def->bridge);
1349
err8:
1350
    iptablesRemoveForwardRejectIn(driver->iptables, AF_INET, network->def->bridge);
1351
err7:
1352
    iptablesRemoveForwardRejectOut(driver->iptables, AF_INET, network->def->bridge);
1353 1354
err6:
    if (ipv4def && ipv4def->tftproot) {
1355
        iptablesRemoveUdpInput(driver->iptables, AF_INET, network->def->bridge, 69);
1356
    }
1357
err5:
1358
    iptablesRemoveUdpInput(driver->iptables, AF_INET, network->def->bridge, 53);
1359
err4:
1360
    iptablesRemoveTcpInput(driver->iptables, AF_INET, network->def->bridge, 53);
1361
err3:
1362
    iptablesRemoveUdpInput(driver->iptables, AF_INET, network->def->bridge, 67);
1363
err2:
1364
    iptablesRemoveTcpInput(driver->iptables, AF_INET, network->def->bridge, 67);
1365
err1:
1366
    return -1;
1367 1368 1369
}

static void
1370 1371 1372 1373 1374
networkRemoveGeneralIptablesRules(struct network_driver *driver,
                                  virNetworkObjPtr network)
{
    int ii;
    virNetworkIpDefPtr ipv4def;
1375

1376 1377
    networkRemoveGeneralIp6tablesRules(driver, network);

1378 1379 1380 1381 1382
    for (ii = 0;
         (ipv4def = virNetworkDefGetIpByIndex(network->def, AF_INET, ii));
         ii++) {
        if (ipv4def->nranges || ipv4def->nhosts || ipv4def->tftproot)
            break;
1383
    }
1384

1385 1386 1387
    iptablesRemoveForwardAllowCross(driver->iptables, AF_INET, network->def->bridge);
    iptablesRemoveForwardRejectIn(driver->iptables, AF_INET, network->def->bridge);
    iptablesRemoveForwardRejectOut(driver->iptables, AF_INET, network->def->bridge);
1388
    if (ipv4def && ipv4def->tftproot) {
1389
        iptablesRemoveUdpInput(driver->iptables, AF_INET, network->def->bridge, 69);
1390
    }
1391 1392
    iptablesRemoveUdpInput(driver->iptables, AF_INET, network->def->bridge, 53);
    iptablesRemoveTcpInput(driver->iptables, AF_INET, network->def->bridge, 53);
1393 1394 1395 1396
    if (ipv4def && (ipv4def->nranges || ipv4def->nhosts)) {
        iptablesRemoveOutputFixUdpChecksum(driver->iptables,
                                           network->def->bridge, 68);
    }
1397 1398
    iptablesRemoveUdpInput(driver->iptables, AF_INET, network->def->bridge, 67);
    iptablesRemoveTcpInput(driver->iptables, AF_INET, network->def->bridge, 67);
1399 1400
}

1401 1402 1403 1404 1405
static int
networkAddIpSpecificIptablesRules(struct network_driver *driver,
                                  virNetworkObjPtr network,
                                  virNetworkIpDefPtr ipdef)
{
1406 1407 1408
    /* NB: in the case of IPv6, routing rules are added when the
     * forward mode is NAT. This is because IPv6 has no NAT.
     */
1409

1410 1411 1412 1413 1414 1415 1416 1417
    if (network->def->forwardType == VIR_NETWORK_FORWARD_NAT) {
        if (VIR_SOCKET_IS_FAMILY(&ipdef->address, AF_INET))
            return networkAddMasqueradingIptablesRules(driver, network, ipdef);
        else if (VIR_SOCKET_IS_FAMILY(&ipdef->address, AF_INET6))
            return networkAddRoutingIptablesRules(driver, network, ipdef);
    } else if (network->def->forwardType == VIR_NETWORK_FORWARD_ROUTE) {
        return networkAddRoutingIptablesRules(driver, network, ipdef);
    }
1418 1419 1420 1421 1422 1423 1424 1425
    return 0;
}

static void
networkRemoveIpSpecificIptablesRules(struct network_driver *driver,
                                     virNetworkObjPtr network,
                                     virNetworkIpDefPtr ipdef)
{
1426 1427 1428 1429 1430 1431
    if (network->def->forwardType == VIR_NETWORK_FORWARD_NAT) {
        if (VIR_SOCKET_IS_FAMILY(&ipdef->address, AF_INET))
            networkRemoveMasqueradingIptablesRules(driver, network, ipdef);
        else if (VIR_SOCKET_IS_FAMILY(&ipdef->address, AF_INET6))
            networkRemoveRoutingIptablesRules(driver, network, ipdef);
    } else if (network->def->forwardType == VIR_NETWORK_FORWARD_ROUTE) {
1432
        networkRemoveRoutingIptablesRules(driver, network, ipdef);
1433
    }
1434 1435 1436 1437 1438 1439 1440 1441 1442 1443 1444 1445 1446 1447 1448 1449 1450 1451 1452 1453 1454 1455 1456 1457 1458 1459 1460 1461 1462 1463 1464 1465 1466 1467 1468 1469 1470 1471 1472 1473 1474 1475 1476 1477 1478 1479 1480 1481 1482 1483 1484 1485 1486
}

/* Add all rules for all ip addresses (and general rules) on a network */
static int
networkAddIptablesRules(struct network_driver *driver,
                        virNetworkObjPtr network)
{
    int ii;
    virNetworkIpDefPtr ipdef;

    /* Add "once per network" rules */
    if (networkAddGeneralIptablesRules(driver, network) < 0)
        return -1;

    for (ii = 0;
         (ipdef = virNetworkDefGetIpByIndex(network->def, AF_UNSPEC, ii));
         ii++) {
        /* Add address-specific iptables rules */
        if (networkAddIpSpecificIptablesRules(driver, network, ipdef) < 0) {
            goto err;
        }
    }
    return 0;

err:
    /* The final failed call to networkAddIpSpecificIptablesRules will
     * have removed any rules it created, but we need to remove those
     * added for previous IP addresses.
     */
    while ((--ii >= 0) &&
           (ipdef = virNetworkDefGetIpByIndex(network->def, AF_UNSPEC, ii))) {
        networkRemoveIpSpecificIptablesRules(driver, network, ipdef);
    }
    networkRemoveGeneralIptablesRules(driver, network);
    return -1;
}

/* Remove all rules for all ip addresses (and general rules) on a network */
static void
networkRemoveIptablesRules(struct network_driver *driver,
                           virNetworkObjPtr network)
{
    int ii;
    virNetworkIpDefPtr ipdef;

    for (ii = 0;
         (ipdef = virNetworkDefGetIpByIndex(network->def, AF_UNSPEC, ii));
         ii++) {
        networkRemoveIpSpecificIptablesRules(driver, network, ipdef);
    }
    networkRemoveGeneralIptablesRules(driver, network);
}

1487 1488 1489 1490 1491
static void
networkReloadIptablesRules(struct network_driver *driver)
{
    unsigned int i;

1492
    VIR_INFO("Reloading iptables rules");
1493 1494 1495 1496

    for (i = 0 ; i < driver->networks.count ; i++) {
        virNetworkObjLock(driver->networks.objs[i]);
        if (virNetworkObjIsActive(driver->networks.objs[i])) {
1497 1498 1499 1500
            networkRemoveIptablesRules(driver, driver->networks.objs[i]);
            if (networkAddIptablesRules(driver, driver->networks.objs[i]) < 0) {
                /* failed to add but already logged */
            }
1501 1502 1503 1504 1505
        }
        virNetworkObjUnlock(driver->networks.objs[i]);
    }
}

1506
/* Enable IP Forwarding. Return 0 for success, -1 for failure. */
1507
static int
1508
networkEnableIpForwarding(bool enableIPv4, bool enableIPv6)
1509
{
1510 1511 1512 1513 1514 1515
    int ret = 0;
    if (enableIPv4)
        ret = virFileWriteStr("/proc/sys/net/ipv4/ip_forward", "1\n", 0);
    if (enableIPv6 && ret == 0)
        ret = virFileWriteStr("/proc/sys/net/ipv6/conf/all/forwarding", "1\n", 0);
    return ret;
1516 1517
}

1518 1519
#define SYSCTL_PATH "/proc/sys"

1520 1521
static int
networkSetIPv6Sysctls(virNetworkObjPtr network)
1522 1523 1524 1525
{
    char *field = NULL;
    int ret = -1;

1526 1527 1528 1529 1530 1531 1532 1533 1534
    if (!virNetworkDefGetIpByIndex(network->def, AF_INET6, 0)) {
        /* Only set disable_ipv6 if there are no ipv6 addresses defined for
         * the network.
         */
        if (virAsprintf(&field, SYSCTL_PATH "/net/ipv6/conf/%s/disable_ipv6",
                        network->def->bridge) < 0) {
            virReportOOMError();
            goto cleanup;
        }
1535

1536 1537 1538 1539 1540 1541
        if (access(field, W_OK) < 0 && errno == ENOENT) {
            VIR_DEBUG("ipv6 appears to already be disabled on %s",
                      network->def->bridge);
            ret = 0;
            goto cleanup;
        }
1542

1543 1544 1545 1546 1547 1548 1549
        if (virFileWriteStr(field, "1", 0) < 0) {
            virReportSystemError(errno,
                                 _("cannot write to %s to disable IPv6 on bridge %s"),
                                 field, network->def->bridge);
            goto cleanup;
        }
        VIR_FREE(field);
1550 1551
    }

1552 1553 1554 1555 1556 1557 1558 1559 1560
    /* The rest of the ipv6 sysctl tunables should always be set,
     * whether or not we're using ipv6 on this bridge.
     */

    /* Prevent guests from hijacking the host network by sending out
     * their own router advertisements.
     */
    if (virAsprintf(&field, SYSCTL_PATH "/net/ipv6/conf/%s/accept_ra",
                    network->def->bridge) < 0) {
1561
        virReportOOMError();
1562 1563 1564
        goto cleanup;
    }

1565
    if (virFileWriteStr(field, "0", 0) < 0) {
1566
        virReportSystemError(errno,
1567 1568 1569 1570 1571
                             _("cannot disable %s"), field);
        goto cleanup;
    }
    VIR_FREE(field);

1572 1573 1574 1575 1576
    /* All interfaces used as a gateway (which is what this is, by
     * definition), must always have autoconf=0.
     */
    if (virAsprintf(&field, SYSCTL_PATH "/net/ipv6/conf/%s/autoconf",
                    network->def->bridge) < 0) {
1577
        virReportOOMError();
1578 1579 1580
        goto cleanup;
    }

1581
    if (virFileWriteStr(field, "1", 0) < 0) {
1582
        virReportSystemError(errno,
1583 1584 1585 1586 1587 1588 1589 1590 1591 1592
                             _("cannot enable %s"), field);
        goto cleanup;
    }

    ret = 0;
cleanup:
    VIR_FREE(field);
    return ret;
}

1593 1594 1595 1596 1597 1598
#define PROC_NET_ROUTE "/proc/net/route"

/* XXX: This function can be a lot more exhaustive, there are certainly
 *      other scenarios where we can ruin host network connectivity.
 * XXX: Using a proper library is preferred over parsing /proc
 */
1599 1600
static int
networkCheckRouteCollision(virNetworkObjPtr network)
1601
{
1602
    int ret = 0, len;
1603 1604 1605 1606 1607
    char *cur, *buf = NULL;
    enum {MAX_ROUTE_SIZE = 1024*64};

    /* Read whole routing table into memory */
    if ((len = virFileReadAll(PROC_NET_ROUTE, MAX_ROUTE_SIZE, &buf)) < 0)
1608
        goto out;
1609 1610 1611 1612 1613 1614 1615 1616 1617 1618 1619 1620 1621 1622 1623 1624 1625 1626

    /* Dropping the last character shouldn't hurt */
    if (len > 0)
        buf[len-1] = '\0';

    VIR_DEBUG("%s output:\n%s", PROC_NET_ROUTE, buf);

    if (!STRPREFIX (buf, "Iface"))
        goto out;

    /* First line is just headings, skip it */
    cur = strchr(buf, '\n');
    if (cur)
        cur++;

    while (cur) {
        char iface[17], dest[128], mask[128];
        unsigned int addr_val, mask_val;
1627 1628
        virNetworkIpDefPtr ipdef;
        int num, ii;
1629 1630 1631 1632 1633 1634 1635 1636 1637 1638 1639 1640 1641 1642 1643 1644 1645 1646 1647 1648 1649 1650 1651 1652 1653 1654 1655 1656

        /* NUL-terminate the line, so sscanf doesn't go beyond a newline.  */
        char *nl = strchr(cur, '\n');
        if (nl) {
            *nl++ = '\0';
        }

        num = sscanf(cur, "%16s %127s %*s %*s %*s %*s %*s %127s",
                     iface, dest, mask);
        cur = nl;

        if (num != 3) {
            VIR_DEBUG("Failed to parse %s", PROC_NET_ROUTE);
            continue;
        }

        if (virStrToLong_ui(dest, NULL, 16, &addr_val) < 0) {
            VIR_DEBUG("Failed to convert network address %s to uint", dest);
            continue;
        }

        if (virStrToLong_ui(mask, NULL, 16, &mask_val) < 0) {
            VIR_DEBUG("Failed to convert network mask %s to uint", mask);
            continue;
        }

        addr_val &= mask_val;

1657 1658 1659 1660 1661 1662 1663 1664 1665 1666 1667 1668 1669 1670 1671 1672 1673 1674 1675 1676 1677 1678 1679 1680
        for (ii = 0;
             (ipdef = virNetworkDefGetIpByIndex(network->def, AF_INET, ii));
             ii++) {

            unsigned int net_dest;
            virSocketAddr netmask;

            if (virNetworkIpDefNetmask(ipdef, &netmask) < 0) {
                VIR_WARN("Failed to get netmask of '%s'",
                         network->def->bridge);
                continue;
            }

            net_dest = (ipdef->address.data.inet4.sin_addr.s_addr &
                        netmask.data.inet4.sin_addr.s_addr);

            if ((net_dest == addr_val) &&
                (netmask.data.inet4.sin_addr.s_addr == mask_val)) {
                networkReportError(VIR_ERR_INTERNAL_ERROR,
                                   _("Network is already in use by interface %s"),
                                   iface);
                ret = -1;
                goto out;
            }
1681 1682 1683 1684 1685 1686 1687 1688
        }
    }

out:
    VIR_FREE(buf);
    return ret;
}

1689 1690 1691 1692
static int
networkAddAddrToBridge(struct network_driver *driver,
                       virNetworkObjPtr network,
                       virNetworkIpDefPtr ipdef)
1693
{
1694 1695 1696 1697 1698 1699 1700 1701 1702 1703 1704 1705 1706 1707 1708 1709 1710 1711 1712 1713 1714
    int prefix = virNetworkIpDefPrefix(ipdef);

    if (prefix < 0) {
        networkReportError(VIR_ERR_INTERNAL_ERROR,
                           _("bridge '%s' has an invalid netmask or IP address"),
                           network->def->bridge);
        return -1;
    }

    if (brAddInetAddress(driver->brctl, network->def->bridge,
                         &ipdef->address, prefix) < 0) {
        networkReportError(VIR_ERR_INTERNAL_ERROR,
                           _("cannot set IP address on bridge '%s'"),
                           network->def->bridge);
        return -1;
    }

    return 0;
}

static int
1715
networkStartNetworkVirtual(struct network_driver *driver,
1716 1717 1718
                          virNetworkObjPtr network)
{
    int ii, err;
1719
    bool v4present = false, v6present = false;
1720 1721
    virErrorPtr save_err = NULL;
    virNetworkIpDefPtr ipdef;
1722
    char *macTapIfName = NULL;
1723

1724 1725
    /* Check to see if any network IP collides with an existing route */
    if (networkCheckRouteCollision(network) < 0)
1726 1727
        return -1;

1728
    /* Create and configure the bridge device */
1729
    if ((err = brAddBridge(driver->brctl, network->def->bridge))) {
1730
        virReportSystemError(err,
1731 1732
                             _("cannot create bridge '%s'"),
                             network->def->bridge);
1733 1734 1735
        return -1;
    }

1736 1737 1738 1739 1740 1741 1742 1743 1744 1745 1746 1747 1748 1749 1750 1751 1752 1753 1754 1755 1756 1757 1758
    if (network->def->mac_specified) {
        /* To set a mac for the bridge, we need to define a dummy tap
         * device, set its mac, then attach it to the bridge. As long
         * as its mac address is lower than any other interface that
         * gets attached, the bridge will always maintain this mac
         * address.
         */
        macTapIfName = networkBridgeDummyNicName(network->def->bridge);
        if (!macTapIfName) {
            virReportOOMError();
            goto err0;
        }
        if ((err = brAddTap(driver->brctl, network->def->bridge,
                            &macTapIfName, network->def->mac, 0, false, NULL))) {
            virReportSystemError(err,
                                 _("cannot create dummy tap device '%s' to set mac"
                                   " address on bridge '%s'"),
                                 macTapIfName, network->def->bridge);
            VIR_FREE(macTapIfName);
            goto err0;
        }
    }

1759
    /* Set bridge options */
E
Eric Blake 已提交
1760 1761
    if (brSetForwardDelay(driver->brctl, network->def->bridge,
                          network->def->delay)) {
1762 1763 1764
        networkReportError(VIR_ERR_INTERNAL_ERROR,
                           _("cannot set forward delay on bridge '%s'"),
                           network->def->bridge);
1765
        goto err1;
1766 1767
    }

E
Eric Blake 已提交
1768 1769
    if (brSetEnableSTP(driver->brctl, network->def->bridge,
                       network->def->stp ? 1 : 0)) {
1770
        networkReportError(VIR_ERR_INTERNAL_ERROR,
1771 1772
                           _("cannot set STP '%s' on bridge '%s'"),
                           network->def->stp ? "on" : "off", network->def->bridge);
1773
        goto err1;
1774 1775
    }

1776 1777 1778 1779
    /* Disable IPv6 on the bridge if there are no IPv6 addresses
     * defined, and set other IPv6 sysctl tunables appropriately.
     */
    if (networkSetIPv6Sysctls(network) < 0)
1780
        goto err1;
1781

1782 1783 1784 1785 1786 1787 1788 1789 1790
    /* Add "once per network" rules */
    if (networkAddIptablesRules(driver, network) < 0)
        goto err1;

    for (ii = 0;
         (ipdef = virNetworkDefGetIpByIndex(network->def, AF_UNSPEC, ii));
         ii++) {
        if (VIR_SOCKET_IS_FAMILY(&ipdef->address, AF_INET))
            v4present = true;
1791 1792
        if (VIR_SOCKET_IS_FAMILY(&ipdef->address, AF_INET6))
            v6present = true;
1793

1794 1795 1796
        /* Add the IP address/netmask to the bridge */
        if (networkAddAddrToBridge(driver, network, ipdef) < 0) {
            goto err2;
1797
        }
1798 1799
    }

1800
    /* Bring up the bridge interface */
1801
    if ((err = brSetInterfaceUp(driver->brctl, network->def->bridge, 1))) {
1802
        virReportSystemError(err,
1803 1804
                             _("failed to bring the bridge '%s' up"),
                             network->def->bridge);
1805
        goto err2;
1806 1807
    }

1808
    /* If forwardType != NONE, turn on global IP forwarding */
1809
    if (network->def->forwardType != VIR_NETWORK_FORWARD_NONE &&
1810
        networkEnableIpForwarding(v4present, v6present) < 0) {
1811
        virReportSystemError(errno, "%s",
1812
                             _("failed to enable IP forwarding"));
1813
        goto err3;
1814 1815
    }

1816

1817 1818
    /* start dnsmasq if there are any IP addresses (v4 or v6) */
    if ((v4present || v6present) && networkStartDhcpDaemon(network) < 0)
1819
        goto err3;
1820

1821 1822 1823 1824
    /* start radvd if there are any ipv6 addresses */
    if (v6present && networkStartRadvd(network) < 0)
        goto err4;

1825
    VIR_FREE(macTapIfName);
1826 1827 1828

    return 0;

1829 1830 1831 1832
 err4:
    if (!save_err)
        save_err = virSaveLastError();

1833 1834 1835 1836 1837
    if (network->dnsmasqPid > 0) {
        kill(network->dnsmasqPid, SIGTERM);
        network->dnsmasqPid = -1;
    }

1838 1839 1840
 err3:
    if (!save_err)
        save_err = virSaveLastError();
1841
    if ((err = brSetInterfaceUp(driver->brctl, network->def->bridge, 0))) {
1842
        char ebuf[1024];
1843
        VIR_WARN("Failed to bring down bridge '%s' : %s",
1844
                 network->def->bridge, virStrerror(err, ebuf, sizeof ebuf));
1845 1846
    }

1847 1848 1849 1850 1851 1852
 err2:
    if (!save_err)
        save_err = virSaveLastError();
    networkRemoveIptablesRules(driver, network);

 err1:
1853 1854 1855 1856 1857 1858 1859 1860 1861
    if (!save_err)
        save_err = virSaveLastError();

    if ((err = brDeleteTap(driver->brctl, macTapIfName))) {
        char ebuf[1024];
        VIR_WARN("Failed to delete dummy tap device '%s' on bridge '%s' : %s",
                 macTapIfName, network->def->bridge,
                 virStrerror(err, ebuf, sizeof ebuf));
    }
1862
    VIR_FREE(macTapIfName);
1863 1864

 err0:
1865 1866
    if (!save_err)
        save_err = virSaveLastError();
1867
    if ((err = brDeleteBridge(driver->brctl, network->def->bridge))) {
1868
        char ebuf[1024];
1869
        VIR_WARN("Failed to delete bridge '%s' : %s",
1870
                 network->def->bridge, virStrerror(err, ebuf, sizeof ebuf));
1871 1872
    }

1873 1874 1875 1876
    if (save_err) {
        virSetError(save_err);
        virFreeError(save_err);
    }
1877 1878 1879
    return -1;
}

1880
static int networkShutdownNetworkVirtual(struct network_driver *driver,
1881 1882
                                        virNetworkObjPtr network)
{
1883
    int err;
1884
    char ebuf[1024];
1885

1886 1887 1888 1889 1890 1891 1892 1893 1894 1895 1896 1897 1898
    if (network->radvdPid > 0) {
        char *radvdpidbase;

        kill(network->radvdPid, SIGTERM);
        /* attempt to delete the pidfile we created */
        if (!(radvdpidbase = networkRadvdPidfileBasename(network->def->name))) {
            virReportOOMError();
        } else {
            virFileDeletePid(NETWORK_PID_DIR, radvdpidbase);
            VIR_FREE(radvdpidbase);
        }
    }

1899 1900 1901
    if (network->dnsmasqPid > 0)
        kill(network->dnsmasqPid, SIGTERM);

1902
    if (network->def->mac_specified) {
1903
        char *macTapIfName = networkBridgeDummyNicName(network->def->bridge);
1904 1905 1906 1907 1908 1909 1910 1911 1912 1913 1914 1915
        if (!macTapIfName) {
            virReportOOMError();
        } else {
            if ((err = brDeleteTap(driver->brctl, macTapIfName))) {
                VIR_WARN("Failed to delete dummy tap device '%s' on bridge '%s' : %s",
                         macTapIfName, network->def->bridge,
                         virStrerror(err, ebuf, sizeof ebuf));
            }
            VIR_FREE(macTapIfName);
        }
    }

1916
    if ((err = brSetInterfaceUp(driver->brctl, network->def->bridge, 0))) {
1917
        VIR_WARN("Failed to bring down bridge '%s' : %s",
1918
                 network->def->bridge, virStrerror(err, ebuf, sizeof ebuf));
1919 1920
    }

1921 1922
    networkRemoveIptablesRules(driver, network);

1923
    if ((err = brDeleteBridge(driver->brctl, network->def->bridge))) {
1924
        VIR_WARN("Failed to delete bridge '%s' : %s",
1925
                 network->def->bridge, virStrerror(err, ebuf, sizeof ebuf));
1926 1927
    }

1928
    /* See if its still alive and really really kill it */
1929
    if (network->dnsmasqPid > 0 &&
1930
        (kill(network->dnsmasqPid, 0) == 0))
1931 1932
        kill(network->dnsmasqPid, SIGKILL);
    network->dnsmasqPid = -1;
1933 1934 1935 1936 1937 1938

    if (network->radvdPid > 0 &&
        (kill(network->radvdPid, 0) == 0))
        kill(network->radvdPid, SIGKILL);
    network->radvdPid = -1;

1939 1940 1941 1942 1943 1944 1945 1946 1947 1948 1949 1950 1951 1952 1953 1954 1955 1956 1957 1958 1959 1960 1961 1962 1963 1964 1965 1966 1967 1968 1969 1970 1971 1972 1973 1974 1975 1976 1977 1978 1979 1980 1981 1982 1983 1984 1985 1986 1987 1988 1989 1990 1991 1992 1993 1994 1995 1996 1997 1998 1999 2000 2001 2002 2003 2004 2005 2006 2007 2008 2009 2010 2011 2012 2013 2014 2015 2016 2017 2018 2019 2020 2021 2022 2023 2024 2025 2026 2027 2028 2029 2030 2031 2032 2033 2034 2035 2036 2037 2038 2039 2040 2041 2042 2043 2044 2045 2046 2047 2048 2049 2050 2051
    return 0;
}

static int
networkStartNetworkExternal(struct network_driver *driver ATTRIBUTE_UNUSED,
                            virNetworkObjPtr network ATTRIBUTE_UNUSED)
{
    /* put anything here that needs to be done each time a network of
     * type BRIDGE, PRIVATE, VEPA, or PASSTHROUGH is started. On
     * failure, undo anything you've done, and return -1. On success
     * return 0.
     */
    return 0;
}

static int networkShutdownNetworkExternal(struct network_driver *driver ATTRIBUTE_UNUSED,
                                        virNetworkObjPtr network ATTRIBUTE_UNUSED)
{
    /* put anything here that needs to be done each time a network of
     * type BRIDGE, PRIVATE, VEPA, or PASSTHROUGH is shutdown. On
     * failure, undo anything you've done, and return -1. On success
     * return 0.
     */
    return 0;
}

static int
networkStartNetwork(struct network_driver *driver,
                    virNetworkObjPtr network)
{
    int ret = 0;

    if (virNetworkObjIsActive(network)) {
        networkReportError(VIR_ERR_OPERATION_INVALID,
                           "%s", _("network is already active"));
        return -1;
    }

    switch (network->def->forwardType) {

    case VIR_NETWORK_FORWARD_NONE:
    case VIR_NETWORK_FORWARD_NAT:
    case VIR_NETWORK_FORWARD_ROUTE:
        ret = networkStartNetworkVirtual(driver, network);
        break;

    case VIR_NETWORK_FORWARD_BRIDGE:
    case VIR_NETWORK_FORWARD_PRIVATE:
    case VIR_NETWORK_FORWARD_VEPA:
    case VIR_NETWORK_FORWARD_PASSTHROUGH:
        ret = networkStartNetworkExternal(driver, network);
        break;
    }

    if (ret < 0)
        return ret;

    /* Persist the live configuration now that anything autogenerated
     * is setup.
     */
    if ((ret = virNetworkSaveConfig(NETWORK_STATE_DIR, network->def)) < 0) {
        goto error;
    }

    VIR_INFO("Starting up network '%s'", network->def->name);
    network->active = 1;

error:
    if (ret < 0) {
        virErrorPtr save_err = virSaveLastError();
        int save_errno = errno;
        networkShutdownNetwork(driver, network);
        virSetError(save_err);
        virFreeError(save_err);
        errno = save_errno;
    }
    return ret;
}

static int networkShutdownNetwork(struct network_driver *driver,
                                        virNetworkObjPtr network)
{
    int ret = 0;
    char *stateFile;

    VIR_INFO("Shutting down network '%s'", network->def->name);

    if (!virNetworkObjIsActive(network))
        return 0;

    stateFile = virNetworkConfigFile(NETWORK_STATE_DIR, network->def->name);
    if (!stateFile)
        return -1;

    unlink(stateFile);
    VIR_FREE(stateFile);

    switch (network->def->forwardType) {

    case VIR_NETWORK_FORWARD_NONE:
    case VIR_NETWORK_FORWARD_NAT:
    case VIR_NETWORK_FORWARD_ROUTE:
        ret = networkShutdownNetworkVirtual(driver, network);
        break;

    case VIR_NETWORK_FORWARD_BRIDGE:
    case VIR_NETWORK_FORWARD_PRIVATE:
    case VIR_NETWORK_FORWARD_VEPA:
    case VIR_NETWORK_FORWARD_PASSTHROUGH:
        ret = networkShutdownNetworkExternal(driver, network);
        break;
    }

2052 2053 2054 2055 2056 2057 2058 2059
    network->active = 0;

    if (network->newDef) {
        virNetworkDefFree(network->def);
        network->def = network->newDef;
        network->newDef = NULL;
    }

2060
    return ret;
2061 2062 2063
}


2064 2065 2066 2067 2068
static virNetworkPtr networkLookupByUUID(virConnectPtr conn,
                                         const unsigned char *uuid) {
    struct network_driver *driver = conn->networkPrivateData;
    virNetworkObjPtr network;
    virNetworkPtr ret = NULL;
2069

2070
    networkDriverLock(driver);
2071
    network = virNetworkFindByUUID(&driver->networks, uuid);
2072
    networkDriverUnlock(driver);
2073
    if (!network) {
2074 2075
        networkReportError(VIR_ERR_NO_NETWORK,
                           "%s", _("no network with matching uuid"));
2076
        goto cleanup;
2077 2078
    }

2079 2080 2081
    ret = virGetNetwork(conn, network->def->name, network->def->uuid);

cleanup:
2082 2083
    if (network)
        virNetworkObjUnlock(network);
2084
    return ret;
2085 2086
}

2087 2088 2089 2090 2091 2092
static virNetworkPtr networkLookupByName(virConnectPtr conn,
                                         const char *name) {
    struct network_driver *driver = conn->networkPrivateData;
    virNetworkObjPtr network;
    virNetworkPtr ret = NULL;

2093
    networkDriverLock(driver);
2094
    network = virNetworkFindByName(&driver->networks, name);
2095
    networkDriverUnlock(driver);
2096
    if (!network) {
2097 2098
        networkReportError(VIR_ERR_NO_NETWORK,
                           _("no network with matching name '%s'"), name);
2099
        goto cleanup;
2100 2101
    }

2102 2103 2104
    ret = virGetNetwork(conn, network->def->name, network->def->uuid);

cleanup:
2105 2106
    if (network)
        virNetworkObjUnlock(network);
2107
    return ret;
2108 2109 2110 2111
}

static virDrvOpenStatus networkOpenNetwork(virConnectPtr conn,
                                           virConnectAuthPtr auth ATTRIBUTE_UNUSED,
2112 2113 2114 2115
                                           unsigned int flags)
{
    virCheckFlags(VIR_CONNECT_RO, VIR_DRV_OPEN_ERROR);

2116 2117 2118 2119 2120 2121 2122 2123 2124 2125 2126 2127 2128
    if (!driverState)
        return VIR_DRV_OPEN_DECLINED;

    conn->networkPrivateData = driverState;
    return VIR_DRV_OPEN_SUCCESS;
}

static int networkCloseNetwork(virConnectPtr conn) {
    conn->networkPrivateData = NULL;
    return 0;
}

static int networkNumNetworks(virConnectPtr conn) {
2129
    int nactive = 0, i;
2130
    struct network_driver *driver = conn->networkPrivateData;
2131

2132 2133 2134
    networkDriverLock(driver);
    for (i = 0 ; i < driver->networks.count ; i++) {
        virNetworkObjLock(driver->networks.objs[i]);
D
Daniel P. Berrange 已提交
2135
        if (virNetworkObjIsActive(driver->networks.objs[i]))
2136
            nactive++;
2137 2138 2139
        virNetworkObjUnlock(driver->networks.objs[i]);
    }
    networkDriverUnlock(driver);
2140

2141 2142 2143 2144
    return nactive;
}

static int networkListNetworks(virConnectPtr conn, char **const names, int nnames) {
2145
    struct network_driver *driver = conn->networkPrivateData;
2146
    int got = 0, i;
2147

2148
    networkDriverLock(driver);
2149
    for (i = 0 ; i < driver->networks.count && got < nnames ; i++) {
2150
        virNetworkObjLock(driver->networks.objs[i]);
D
Daniel P. Berrange 已提交
2151
        if (virNetworkObjIsActive(driver->networks.objs[i])) {
2152
            if (!(names[got] = strdup(driver->networks.objs[i]->def->name))) {
2153
                virNetworkObjUnlock(driver->networks.objs[i]);
2154
                virReportOOMError();
2155 2156 2157 2158
                goto cleanup;
            }
            got++;
        }
2159
        virNetworkObjUnlock(driver->networks.objs[i]);
2160
    }
2161 2162
    networkDriverUnlock(driver);

2163 2164 2165
    return got;

 cleanup:
2166
    networkDriverUnlock(driver);
2167 2168 2169 2170 2171 2172
    for (i = 0 ; i < got ; i++)
        VIR_FREE(names[i]);
    return -1;
}

static int networkNumDefinedNetworks(virConnectPtr conn) {
2173
    int ninactive = 0, i;
2174
    struct network_driver *driver = conn->networkPrivateData;
2175

2176 2177 2178
    networkDriverLock(driver);
    for (i = 0 ; i < driver->networks.count ; i++) {
        virNetworkObjLock(driver->networks.objs[i]);
D
Daniel P. Berrange 已提交
2179
        if (!virNetworkObjIsActive(driver->networks.objs[i]))
2180
            ninactive++;
2181 2182 2183
        virNetworkObjUnlock(driver->networks.objs[i]);
    }
    networkDriverUnlock(driver);
2184

2185 2186 2187 2188
    return ninactive;
}

static int networkListDefinedNetworks(virConnectPtr conn, char **const names, int nnames) {
2189
    struct network_driver *driver = conn->networkPrivateData;
2190
    int got = 0, i;
2191

2192
    networkDriverLock(driver);
2193
    for (i = 0 ; i < driver->networks.count && got < nnames ; i++) {
2194
        virNetworkObjLock(driver->networks.objs[i]);
D
Daniel P. Berrange 已提交
2195
        if (!virNetworkObjIsActive(driver->networks.objs[i])) {
2196
            if (!(names[got] = strdup(driver->networks.objs[i]->def->name))) {
2197
                virNetworkObjUnlock(driver->networks.objs[i]);
2198
                virReportOOMError();
2199 2200 2201 2202
                goto cleanup;
            }
            got++;
        }
2203
        virNetworkObjUnlock(driver->networks.objs[i]);
2204
    }
2205
    networkDriverUnlock(driver);
2206 2207 2208
    return got;

 cleanup:
2209
    networkDriverUnlock(driver);
2210 2211 2212 2213 2214
    for (i = 0 ; i < got ; i++)
        VIR_FREE(names[i]);
    return -1;
}

2215 2216 2217

static int networkIsActive(virNetworkPtr net)
{
2218
    struct network_driver *driver = net->conn->networkPrivateData;
2219 2220 2221 2222 2223 2224 2225
    virNetworkObjPtr obj;
    int ret = -1;

    networkDriverLock(driver);
    obj = virNetworkFindByUUID(&driver->networks, net->uuid);
    networkDriverUnlock(driver);
    if (!obj) {
2226
        networkReportError(VIR_ERR_NO_NETWORK, NULL);
2227 2228 2229 2230 2231 2232 2233 2234 2235 2236 2237 2238
        goto cleanup;
    }
    ret = virNetworkObjIsActive(obj);

cleanup:
    if (obj)
        virNetworkObjUnlock(obj);
    return ret;
}

static int networkIsPersistent(virNetworkPtr net)
{
2239
    struct network_driver *driver = net->conn->networkPrivateData;
2240 2241 2242 2243 2244 2245 2246
    virNetworkObjPtr obj;
    int ret = -1;

    networkDriverLock(driver);
    obj = virNetworkFindByUUID(&driver->networks, net->uuid);
    networkDriverUnlock(driver);
    if (!obj) {
2247
        networkReportError(VIR_ERR_NO_NETWORK, NULL);
2248 2249 2250 2251 2252 2253 2254 2255 2256 2257 2258
        goto cleanup;
    }
    ret = obj->persistent;

cleanup:
    if (obj)
        virNetworkObjUnlock(obj);
    return ret;
}


2259
static virNetworkPtr networkCreate(virConnectPtr conn, const char *xml) {
2260
    struct network_driver *driver = conn->networkPrivateData;
2261
    virNetworkDefPtr def;
2262
    virNetworkObjPtr network = NULL;
2263
    virNetworkPtr ret = NULL;
2264

2265 2266
    networkDriverLock(driver);

2267
    if (!(def = virNetworkDefParseString(xml)))
2268
        goto cleanup;
2269

2270 2271 2272
    if (virNetworkObjIsDuplicate(&driver->networks, def, 1) < 0)
        goto cleanup;

2273 2274 2275 2276 2277 2278
    /* Only the three L3 network types that are configured by libvirt
     * need to have a bridge device name / mac address provided
     */
    if (def->forwardType == VIR_NETWORK_FORWARD_NONE ||
        def->forwardType == VIR_NETWORK_FORWARD_NAT ||
        def->forwardType == VIR_NETWORK_FORWARD_ROUTE) {
2279

2280 2281 2282 2283 2284
        if (virNetworkSetBridgeName(&driver->networks, def, 1))
            goto cleanup;

        virNetworkSetBridgeMacAddr(def);
    }
2285

2286
    if (!(network = virNetworkAssignDef(&driver->networks,
2287 2288 2289
                                        def)))
        goto cleanup;
    def = NULL;
2290

2291
    if (networkStartNetwork(driver, network) < 0) {
2292 2293
        virNetworkRemoveInactive(&driver->networks,
                                 network);
2294
        network = NULL;
2295
        goto cleanup;
2296 2297
    }

2298
    VIR_INFO("Creating network '%s'", network->def->name);
2299 2300 2301 2302
    ret = virGetNetwork(conn, network->def->name, network->def->uuid);

cleanup:
    virNetworkDefFree(def);
2303 2304 2305
    if (network)
        virNetworkObjUnlock(network);
    networkDriverUnlock(driver);
2306
    return ret;
2307 2308 2309
}

static virNetworkPtr networkDefine(virConnectPtr conn, const char *xml) {
2310
    struct network_driver *driver = conn->networkPrivateData;
2311
    virNetworkIpDefPtr ipdef, ipv4def = NULL;
2312
    virNetworkDefPtr def;
2313
    virNetworkObjPtr network = NULL;
2314
    virNetworkPtr ret = NULL;
2315
    int ii;
2316
    dnsmasqContext* dctx = NULL;
2317

2318 2319
    networkDriverLock(driver);

2320
    if (!(def = virNetworkDefParseString(xml)))
2321
        goto cleanup;
2322

E
Eric Blake 已提交
2323
    if (virNetworkObjIsDuplicate(&driver->networks, def, 0) < 0)
2324 2325
        goto cleanup;

2326 2327 2328 2329 2330 2331
    /* Only the three L3 network types that are configured by libvirt
     * need to have a bridge device name / mac address provided
     */
    if (def->forwardType == VIR_NETWORK_FORWARD_NONE ||
        def->forwardType == VIR_NETWORK_FORWARD_NAT ||
        def->forwardType == VIR_NETWORK_FORWARD_ROUTE) {
2332

2333 2334 2335 2336 2337
        if (virNetworkSetBridgeName(&driver->networks, def, 1))
            goto cleanup;

        virNetworkSetBridgeMacAddr(def);
    }
2338

2339
    if (!(network = virNetworkAssignDef(&driver->networks,
2340 2341 2342
                                        def)))
        goto cleanup;
    def = NULL;
2343

2344 2345
    network->persistent = 1;

2346
    if (virNetworkSaveConfig(driver->networkConfigDir,
2347
                             network->newDef ? network->newDef : network->def) < 0) {
2348 2349
        virNetworkRemoveInactive(&driver->networks,
                                 network);
2350
        network = NULL;
2351
        goto cleanup;
2352 2353
    }

2354
    /* We only support dhcp on one IPv4 address per defined network */
2355 2356 2357 2358 2359 2360 2361 2362 2363 2364 2365 2366 2367 2368 2369 2370
    for (ii = 0;
         (ipdef = virNetworkDefGetIpByIndex(network->def, AF_UNSPEC, ii));
         ii++) {
        if (VIR_SOCKET_IS_FAMILY(&ipdef->address, AF_INET)) {
            if (ipdef->nranges || ipdef->nhosts) {
                if (ipv4def) {
                    networkReportError(VIR_ERR_CONFIG_UNSUPPORTED,
                                       "%s", _("Multiple dhcp sections found. dhcp is supported only for a single IPv4 address on each network"));
                    goto cleanup;
                } else {
                    ipv4def = ipdef;
                }
            }
        }
    }
    if (ipv4def) {
2371 2372 2373 2374
        dctx = dnsmasqContextNew(network->def->name, DNSMASQ_STATE_DIR);
        if (dctx == NULL ||
            networkBuildDnsmasqHostsfile(dctx, ipv4def, network->def->dns) < 0 ||
            dnsmasqSave(dctx) < 0)
2375 2376 2377
            goto cleanup;
    }

2378
    VIR_INFO("Defining network '%s'", network->def->name);
2379 2380 2381 2382
    ret = virGetNetwork(conn, network->def->name, network->def->uuid);

cleanup:
    virNetworkDefFree(def);
2383
    dnsmasqContextFree(dctx);
2384 2385 2386
    if (network)
        virNetworkObjUnlock(network);
    networkDriverUnlock(driver);
2387
    return ret;
2388 2389 2390
}

static int networkUndefine(virNetworkPtr net) {
2391
    struct network_driver *driver = net->conn->networkPrivateData;
2392
    virNetworkObjPtr network;
2393 2394
    virNetworkIpDefPtr ipdef;
    bool dhcp_present = false, v6present = false;
2395
    int ret = -1, ii;
2396

2397 2398
    networkDriverLock(driver);

2399
    network = virNetworkFindByUUID(&driver->networks, net->uuid);
2400
    if (!network) {
2401
        networkReportError(VIR_ERR_NO_NETWORK,
2402 2403
                           "%s", _("no network with matching uuid"));
        goto cleanup;
2404 2405
    }

D
Daniel P. Berrange 已提交
2406
    if (virNetworkObjIsActive(network)) {
2407
        networkReportError(VIR_ERR_OPERATION_INVALID,
2408 2409
                           "%s", _("network is still active"));
        goto cleanup;
2410 2411
    }

2412
    if (virNetworkDeleteConfig(driver->networkConfigDir,
2413 2414
                               driver->networkAutostartDir,
                               network) < 0)
2415
        goto cleanup;
2416

2417 2418
    /* we only support dhcp on one IPv4 address per defined network */
    for (ii = 0;
2419
         (ipdef = virNetworkDefGetIpByIndex(network->def, AF_UNSPEC, ii));
2420
         ii++) {
2421 2422 2423 2424 2425 2426
        if (VIR_SOCKET_IS_FAMILY(&ipdef->address, AF_INET)) {
            if (ipdef->nranges || ipdef->nhosts)
                dhcp_present = true;
        } else if (VIR_SOCKET_IS_FAMILY(&ipdef->address, AF_INET6)) {
            v6present = true;
        }
2427
    }
2428 2429

    if (dhcp_present) {
2430
        char *leasefile;
2431 2432 2433 2434 2435 2436
        dnsmasqContext *dctx = dnsmasqContextNew(network->def->name, DNSMASQ_STATE_DIR);
        if (dctx == NULL)
            goto cleanup;

        dnsmasqDelete(dctx);
        dnsmasqContextFree(dctx);
2437 2438 2439 2440 2441 2442

        leasefile = networkDnsmasqLeaseFileName(network->def->name);
        if (!leasefile)
            goto cleanup;
        unlink(leasefile);
        VIR_FREE(leasefile);
2443 2444
    }

2445 2446 2447 2448 2449 2450 2451 2452 2453 2454 2455 2456 2457 2458 2459 2460 2461 2462 2463 2464 2465
    if (v6present) {
        char *configfile = networkRadvdConfigFileName(network->def->name);

        if (!configfile) {
            virReportOOMError();
            goto cleanup;
        }
        unlink(configfile);
        VIR_FREE(configfile);

        char *radvdpidbase = networkRadvdPidfileBasename(network->def->name);

        if (!(radvdpidbase)) {
            virReportOOMError();
            goto cleanup;
        }
        virFileDeletePid(NETWORK_PID_DIR, radvdpidbase);
        VIR_FREE(radvdpidbase);

    }

2466
    VIR_INFO("Undefining network '%s'", network->def->name);
2467 2468
    virNetworkRemoveInactive(&driver->networks,
                             network);
2469
    network = NULL;
2470
    ret = 0;
2471

2472
cleanup:
2473 2474 2475
    if (network)
        virNetworkObjUnlock(network);
    networkDriverUnlock(driver);
2476
    return ret;
2477 2478 2479
}

static int networkStart(virNetworkPtr net) {
2480 2481 2482
    struct network_driver *driver = net->conn->networkPrivateData;
    virNetworkObjPtr network;
    int ret = -1;
2483

2484
    networkDriverLock(driver);
2485
    network = virNetworkFindByUUID(&driver->networks, net->uuid);
2486

2487
    if (!network) {
2488
        networkReportError(VIR_ERR_NO_NETWORK,
2489 2490
                           "%s", _("no network with matching uuid"));
        goto cleanup;
2491 2492
    }

2493
    ret = networkStartNetwork(driver, network);
2494 2495

cleanup:
2496 2497
    if (network)
        virNetworkObjUnlock(network);
2498
    networkDriverUnlock(driver);
2499
    return ret;
2500 2501 2502
}

static int networkDestroy(virNetworkPtr net) {
2503 2504 2505
    struct network_driver *driver = net->conn->networkPrivateData;
    virNetworkObjPtr network;
    int ret = -1;
2506

2507
    networkDriverLock(driver);
2508
    network = virNetworkFindByUUID(&driver->networks, net->uuid);
2509

2510
    if (!network) {
2511
        networkReportError(VIR_ERR_NO_NETWORK,
2512 2513
                           "%s", _("no network with matching uuid"));
        goto cleanup;
2514 2515
    }

D
Daniel P. Berrange 已提交
2516
    if (!virNetworkObjIsActive(network)) {
2517
        networkReportError(VIR_ERR_OPERATION_INVALID,
2518 2519 2520 2521
                           "%s", _("network is not active"));
        goto cleanup;
    }

2522
    ret = networkShutdownNetwork(driver, network);
2523
    if (!network->persistent) {
2524 2525 2526 2527
        virNetworkRemoveInactive(&driver->networks,
                                 network);
        network = NULL;
    }
2528

2529
cleanup:
2530 2531
    if (network)
        virNetworkObjUnlock(network);
2532
    networkDriverUnlock(driver);
2533 2534 2535
    return ret;
}

2536
static char *networkGetXMLDesc(virNetworkPtr net,
2537
                               unsigned int flags)
2538
{
2539 2540 2541
    struct network_driver *driver = net->conn->networkPrivateData;
    virNetworkObjPtr network;
    char *ret = NULL;
2542

2543 2544
    virCheckFlags(0, NULL);

2545
    networkDriverLock(driver);
2546
    network = virNetworkFindByUUID(&driver->networks, net->uuid);
2547 2548
    networkDriverUnlock(driver);

2549
    if (!network) {
2550
        networkReportError(VIR_ERR_NO_NETWORK,
2551 2552
                           "%s", _("no network with matching uuid"));
        goto cleanup;
2553 2554
    }

2555
    ret = virNetworkDefFormat(network->def);
2556 2557

cleanup:
2558 2559
    if (network)
        virNetworkObjUnlock(network);
2560
    return ret;
2561 2562 2563
}

static char *networkGetBridgeName(virNetworkPtr net) {
2564 2565 2566 2567
    struct network_driver *driver = net->conn->networkPrivateData;
    virNetworkObjPtr network;
    char *bridge = NULL;

2568
    networkDriverLock(driver);
2569
    network = virNetworkFindByUUID(&driver->networks, net->uuid);
2570 2571
    networkDriverUnlock(driver);

2572
    if (!network) {
2573
        networkReportError(VIR_ERR_NO_NETWORK,
2574 2575
                           "%s", _("no network with matching id"));
        goto cleanup;
2576 2577
    }

2578
    if (!(network->def->bridge)) {
2579
        networkReportError(VIR_ERR_INTERNAL_ERROR,
2580 2581 2582 2583 2584
                           _("network '%s' does not have a bridge name."),
                           network->def->name);
        goto cleanup;
    }

2585
    bridge = strdup(network->def->bridge);
2586
    if (!bridge)
2587
        virReportOOMError();
2588 2589

cleanup:
2590 2591
    if (network)
        virNetworkObjUnlock(network);
2592 2593 2594 2595 2596
    return bridge;
}

static int networkGetAutostart(virNetworkPtr net,
                             int *autostart) {
2597 2598 2599
    struct network_driver *driver = net->conn->networkPrivateData;
    virNetworkObjPtr network;
    int ret = -1;
2600

2601
    networkDriverLock(driver);
2602
    network = virNetworkFindByUUID(&driver->networks, net->uuid);
2603
    networkDriverUnlock(driver);
2604
    if (!network) {
2605
        networkReportError(VIR_ERR_NO_NETWORK,
2606
                           "%s", _("no network with matching uuid"));
2607
        goto cleanup;
2608 2609 2610
    }

    *autostart = network->autostart;
2611
    ret = 0;
2612

2613
cleanup:
2614 2615
    if (network)
        virNetworkObjUnlock(network);
2616
    return ret;
2617 2618 2619
}

static int networkSetAutostart(virNetworkPtr net,
2620
                               int autostart) {
2621 2622
    struct network_driver *driver = net->conn->networkPrivateData;
    virNetworkObjPtr network;
2623
    char *configFile = NULL, *autostartLink = NULL;
2624
    int ret = -1;
2625

2626
    networkDriverLock(driver);
2627
    network = virNetworkFindByUUID(&driver->networks, net->uuid);
2628

2629
    if (!network) {
2630
        networkReportError(VIR_ERR_NO_NETWORK,
2631
                           "%s", _("no network with matching uuid"));
2632
        goto cleanup;
2633 2634
    }

2635
    if (!network->persistent) {
2636
        networkReportError(VIR_ERR_OPERATION_INVALID,
2637
                           "%s", _("cannot set autostart for transient network"));
2638 2639 2640
        goto cleanup;
    }

2641 2642
    autostart = (autostart != 0);

2643
    if (network->autostart != autostart) {
2644
        if ((configFile = virNetworkConfigFile(driver->networkConfigDir, network->def->name)) == NULL)
2645
            goto cleanup;
2646
        if ((autostartLink = virNetworkConfigFile(driver->networkAutostartDir, network->def->name)) == NULL)
2647 2648
            goto cleanup;

2649
        if (autostart) {
2650
            if (virFileMakePath(driver->networkAutostartDir) < 0) {
2651
                virReportSystemError(errno,
2652 2653
                                     _("cannot create autostart directory '%s'"),
                                     driver->networkAutostartDir);
2654 2655
                goto cleanup;
            }
2656

2657
            if (symlink(configFile, autostartLink) < 0) {
2658
                virReportSystemError(errno,
2659
                                     _("Failed to create symlink '%s' to '%s'"),
2660
                                     autostartLink, configFile);
2661 2662 2663
                goto cleanup;
            }
        } else {
2664
            if (unlink(autostartLink) < 0 && errno != ENOENT && errno != ENOTDIR) {
2665
                virReportSystemError(errno,
2666
                                     _("Failed to delete symlink '%s'"),
2667
                                     autostartLink);
2668 2669
                goto cleanup;
            }
2670 2671
        }

2672
        network->autostart = autostart;
2673
    }
2674
    ret = 0;
2675

2676
cleanup:
2677 2678
    VIR_FREE(configFile);
    VIR_FREE(autostartLink);
2679 2680
    if (network)
        virNetworkObjUnlock(network);
2681
    networkDriverUnlock(driver);
2682
    return ret;
2683 2684 2685 2686 2687
}


static virNetworkDriver networkDriver = {
    "Network",
2688 2689 2690 2691 2692 2693 2694 2695 2696 2697 2698 2699 2700 2701 2702 2703 2704 2705 2706
    .open = networkOpenNetwork, /* 0.2.0 */
    .close = networkCloseNetwork, /* 0.2.0 */
    .numOfNetworks = networkNumNetworks, /* 0.2.0 */
    .listNetworks = networkListNetworks, /* 0.2.0 */
    .numOfDefinedNetworks = networkNumDefinedNetworks, /* 0.2.0 */
    .listDefinedNetworks = networkListDefinedNetworks, /* 0.2.0 */
    .networkLookupByUUID = networkLookupByUUID, /* 0.2.0 */
    .networkLookupByName = networkLookupByName, /* 0.2.0 */
    .networkCreateXML = networkCreate, /* 0.2.0 */
    .networkDefineXML = networkDefine, /* 0.2.0 */
    .networkUndefine = networkUndefine, /* 0.2.0 */
    .networkCreate = networkStart, /* 0.2.0 */
    .networkDestroy = networkDestroy, /* 0.2.0 */
    .networkGetXMLDesc = networkGetXMLDesc, /* 0.2.0 */
    .networkGetBridgeName = networkGetBridgeName, /* 0.2.0 */
    .networkGetAutostart = networkGetAutostart, /* 0.2.1 */
    .networkSetAutostart = networkSetAutostart, /* 0.2.1 */
    .networkIsActive = networkIsActive, /* 0.7.3 */
    .networkIsPersistent = networkIsPersistent, /* 0.7.3 */
2707 2708 2709
};

static virStateDriver networkStateDriver = {
2710
    "Network",
2711 2712 2713 2714 2715 2716 2717 2718 2719 2720 2721
    networkStartup,
    networkShutdown,
    networkReload,
    networkActive,
};

int networkRegister(void) {
    virRegisterNetworkDriver(&networkDriver);
    virRegisterStateDriver(&networkStateDriver);
    return 0;
}
2722 2723 2724 2725 2726 2727 2728 2729 2730 2731 2732 2733 2734 2735 2736 2737 2738 2739 2740 2741 2742 2743 2744 2745 2746 2747 2748 2749 2750 2751 2752 2753 2754 2755 2756 2757 2758 2759 2760 2761 2762 2763 2764 2765 2766 2767 2768 2769 2770 2771 2772 2773 2774 2775 2776 2777 2778 2779 2780 2781 2782 2783 2784 2785 2786 2787 2788 2789 2790 2791 2792 2793 2794 2795 2796 2797 2798 2799 2800 2801 2802 2803 2804 2805 2806 2807 2808 2809 2810 2811 2812 2813 2814 2815 2816 2817 2818 2819 2820 2821 2822 2823 2824 2825 2826 2827 2828 2829 2830 2831 2832 2833 2834 2835 2836 2837 2838 2839 2840 2841 2842 2843 2844 2845 2846 2847 2848 2849 2850 2851 2852 2853 2854 2855 2856 2857 2858 2859 2860 2861 2862 2863 2864 2865 2866 2867 2868 2869 2870 2871 2872 2873 2874 2875 2876 2877 2878 2879 2880 2881 2882 2883 2884 2885 2886 2887 2888 2889 2890 2891 2892 2893 2894 2895 2896 2897 2898 2899 2900 2901 2902 2903 2904 2905 2906 2907 2908 2909 2910 2911 2912 2913 2914 2915 2916 2917 2918 2919 2920 2921 2922 2923 2924 2925 2926 2927 2928 2929 2930 2931 2932 2933 2934 2935 2936 2937 2938 2939 2940 2941 2942 2943 2944 2945 2946 2947 2948 2949 2950 2951 2952 2953 2954 2955 2956 2957 2958 2959 2960 2961 2962 2963 2964 2965 2966 2967 2968 2969 2970 2971 2972 2973 2974 2975 2976 2977 2978 2979 2980 2981 2982 2983 2984 2985 2986 2987 2988 2989 2990 2991 2992 2993 2994 2995 2996 2997 2998 2999 3000 3001 3002 3003 3004 3005 3006 3007 3008 3009 3010 3011 3012 3013 3014 3015 3016 3017 3018 3019 3020 3021 3022 3023 3024 3025 3026 3027 3028 3029 3030 3031 3032 3033 3034 3035 3036 3037 3038 3039 3040 3041 3042 3043 3044 3045 3046 3047 3048 3049 3050 3051 3052 3053 3054 3055 3056 3057 3058 3059 3060 3061 3062 3063 3064 3065 3066 3067 3068 3069 3070 3071 3072 3073 3074 3075 3076 3077 3078 3079 3080 3081 3082 3083 3084 3085 3086 3087 3088 3089 3090 3091 3092 3093

/********************************************************/

/* Private API to deal with logical switch capabilities.
 * These functions are exported so that other parts of libvirt can
 * call them, but are not part of the public API and not in the
 * driver's function table. If we ever have more than one network
 * driver, we will need to present these functions via a second
 * "backend" function table.
 */

/* networkAllocateActualDevice:
 * @iface: the original NetDef from the domain
 *
 * Looks up the network reference by iface, allocates a physical
 * device from that network (if appropriate), and returns with the
 * virDomainActualNetDef filled in accordingly. If there are no
 * changes to be made in the netdef, then just leave the actualdef
 * empty.
 *
 * Returns 0 on success, -1 on failure.
 */
int
networkAllocateActualDevice(virDomainNetDefPtr iface)
{
    struct network_driver *driver = driverState;
    virNetworkObjPtr network;
    virNetworkDefPtr netdef;
    int ret = -1;

    if (iface->type != VIR_DOMAIN_NET_TYPE_NETWORK)
        return 0;

    virDomainActualNetDefFree(iface->data.network.actual);
    iface->data.network.actual = NULL;

    networkDriverLock(driver);
    network = virNetworkFindByName(&driver->networks, iface->data.network.name);
    networkDriverUnlock(driver);
    if (!network) {
        networkReportError(VIR_ERR_NO_NETWORK,
                           _("no network with matching name '%s'"),
                           iface->data.network.name);
        goto cleanup;
    }

    netdef = network->def;
    if ((netdef->forwardType == VIR_NETWORK_FORWARD_BRIDGE) &&
        netdef->bridge) {

        /* <forward type='bridge'/> <bridge name='xxx'/>
         * is VIR_DOMAIN_NET_TYPE_BRIDGE
         */

        if (VIR_ALLOC(iface->data.network.actual) < 0) {
            virReportOOMError();
            goto cleanup;
        }

        iface->data.network.actual->type = VIR_DOMAIN_NET_TYPE_BRIDGE;
        iface->data.network.actual->data.bridge.brname = strdup(netdef->bridge);
        if (!iface->data.network.actual->data.bridge.brname) {
            virReportOOMError();
            goto cleanup;
        }

    } else if ((netdef->forwardType == VIR_NETWORK_FORWARD_BRIDGE) ||
               (netdef->forwardType == VIR_NETWORK_FORWARD_PRIVATE) ||
               (netdef->forwardType == VIR_NETWORK_FORWARD_VEPA) ||
               (netdef->forwardType == VIR_NETWORK_FORWARD_PASSTHROUGH)) {
        virVirtualPortProfileParamsPtr virtport = NULL;

        /* <forward type='bridge|private|vepa|passthrough'> are all
         * VIR_DOMAIN_NET_TYPE_DIRECT.
         */

        if (VIR_ALLOC(iface->data.network.actual) < 0) {
            virReportOOMError();
            goto cleanup;
        }

        /* Set type=direct and appropriate <source mode='xxx'/> */
        iface->data.network.actual->type = VIR_DOMAIN_NET_TYPE_DIRECT;
        switch (netdef->forwardType) {
        case VIR_NETWORK_FORWARD_BRIDGE:
            iface->data.network.actual->data.direct.mode = VIR_MACVTAP_MODE_BRIDGE;
            break;
        case VIR_NETWORK_FORWARD_PRIVATE:
            iface->data.network.actual->data.direct.mode = VIR_MACVTAP_MODE_PRIVATE;
            break;
        case VIR_NETWORK_FORWARD_VEPA:
            iface->data.network.actual->data.direct.mode = VIR_MACVTAP_MODE_VEPA;
            break;
        case VIR_NETWORK_FORWARD_PASSTHROUGH:
            iface->data.network.actual->data.direct.mode = VIR_MACVTAP_MODE_PASSTHRU;
            break;
        }

        /* Find the most specific virtportprofile and copy it */
        if (iface->data.network.virtPortProfile) {
            virtport = iface->data.network.virtPortProfile;
        } else {
            virPortGroupDefPtr portgroup
               = virPortGroupFindByName(netdef, iface->data.network.portgroup);
            if (portgroup)
                virtport = portgroup->virtPortProfile;
            else
                virtport = netdef->virtPortProfile;
        }
        if (virtport) {
            if (VIR_ALLOC(iface->data.network.actual->data.direct.virtPortProfile) < 0) {
                virReportOOMError();
                goto cleanup;
            }
            /* There are no pointers in a virtualPortProfile, so a shallow copy
             * is sufficient
             */
            *iface->data.network.actual->data.direct.virtPortProfile = *virtport;
        }
        /* If there is only a single device, just return it (caller will detect
         * any error if exclusive use is required but could not be acquired).
         */
        if (netdef->nForwardIfs == 0) {
            networkReportError(VIR_ERR_INTERNAL_ERROR,
                               _("network '%s' uses a direct mode, but has no forward dev and no interface pool"),
                               netdef->name);
            goto cleanup;
        } else {
            int ii;
            virNetworkForwardIfDefPtr dev = NULL;

            /* pick an interface from the pool */

            /* PASSTHROUGH mode, and PRIVATE Mode + 802.1Qbh both require
             * exclusive access to a device, so current usageCount must be
             * 0.  Other modes can share, so just search for the one with
             * the lowest usageCount.
             */
            if ((netdef->forwardType == VIR_NETWORK_FORWARD_PASSTHROUGH) ||
                ((netdef->forwardType == VIR_NETWORK_FORWARD_PRIVATE) &&
                 iface->data.network.actual->data.direct.virtPortProfile &&
                 (iface->data.network.actual->data.direct.virtPortProfile->virtPortType
                  == VIR_VIRTUALPORT_8021QBH))) {
                /* pick first dev with 0 usageCount */

                for (ii = 0; ii < netdef->nForwardIfs; ii++) {
                    if (netdef->forwardIfs[ii].usageCount == 0) {
                        dev = &netdef->forwardIfs[ii];
                        break;
                    }
                }
            } else {
                /* pick least used dev */
                dev = &netdef->forwardIfs[0];
                for (ii = 1; ii < netdef->nForwardIfs; ii++) {
                    if (netdef->forwardIfs[ii].usageCount < dev->usageCount)
                        dev = &netdef->forwardIfs[ii];
                }
            }
            /* dev points at the physical device we want to use */
            if (!dev) {
                networkReportError(VIR_ERR_INTERNAL_ERROR,
                                   _("network '%s' requires exclusive access to interfaces, but none are available"),
                               netdef->name);
                goto cleanup;
            }
            iface->data.network.actual->data.direct.linkdev = strdup(dev->dev);
            if (!iface->data.network.actual->data.direct.linkdev) {
                virReportOOMError();
                goto cleanup;
            }
            /* we are now assured of success, so mark the allocation */
            dev->usageCount++;
            VIR_DEBUG("Using physical device %s, usageCount %d",
                      dev->dev, dev->usageCount);
        }
    }

    ret = 0;
cleanup:
    if (network)
        virNetworkObjUnlock(network);
    if (ret < 0) {
        virDomainActualNetDefFree(iface->data.network.actual);
        iface->data.network.actual = NULL;
    }
    return ret;
}

/* networkNotifyActualDevice:
 * @iface:  the domain's NetDef with an "actual" device already filled in.
 *
 * Called to notify the network driver when libvirtd is restarted and
 * finds an already running domain. If appropriate it will force an
 * allocation of the actual->direct.linkdev to get everything back in
 * order.
 *
 * Returns 0 on success, -1 on failure.
 */
int
networkNotifyActualDevice(virDomainNetDefPtr iface)
{
    struct network_driver *driver = driverState;
    virNetworkObjPtr network;
    virNetworkDefPtr netdef;
    char *actualDev;
    int ret = -1;

    if (iface->type != VIR_DOMAIN_NET_TYPE_NETWORK)
       return 0;

    if (!iface->data.network.actual ||
        (virDomainNetGetActualType(iface) != VIR_DOMAIN_NET_TYPE_DIRECT)) {
        VIR_DEBUG("Nothing to claim from network %s", iface->data.network.name);
        return 0;
    }

    networkDriverLock(driver);
    network = virNetworkFindByName(&driver->networks, iface->data.network.name);
    networkDriverUnlock(driver);
    if (!network) {
        networkReportError(VIR_ERR_NO_NETWORK,
                           _("no network with matching name '%s'"),
                           iface->data.network.name);
        goto cleanup;
    }

    actualDev = virDomainNetGetActualDirectDev(iface);
    if (!actualDev) {
        networkReportError(VIR_ERR_INTERNAL_ERROR,
                           "%s", _("the interface uses a direct mode, but has no source dev"));
            goto cleanup;
        }

    netdef = network->def;
    if (netdef->nForwardIfs == 0) {
        networkReportError(VIR_ERR_INTERNAL_ERROR,
                           _("network '%s' uses a direct mode, but has no forward dev and no interface pool"),
                           netdef->name);
        goto cleanup;
    } else {
        int ii;
        virNetworkForwardIfDefPtr dev = NULL;

        /* find the matching interface in the pool and increment its usageCount */

        for (ii = 0; ii < netdef->nForwardIfs; ii++) {
            if (STREQ(actualDev, netdef->forwardIfs[ii].dev)) {
                dev = &netdef->forwardIfs[ii];
                break;
            }
        }
        /* dev points at the physical device we want to use */
        if (!dev) {
            networkReportError(VIR_ERR_INTERNAL_ERROR,
                               _("network '%s' doesn't have dev='%s' in use by domain"),
                               netdef->name, actualDev);
            goto cleanup;
        }

        /* PASSTHROUGH mode, and PRIVATE Mode + 802.1Qbh both require
         * exclusive access to a device, so current usageCount must be
         * 0 in those cases.
         */
        if ((dev->usageCount > 0) &&
            ((netdef->forwardType == VIR_NETWORK_FORWARD_PASSTHROUGH) ||
             ((netdef->forwardType == VIR_NETWORK_FORWARD_PRIVATE) &&
              iface->data.network.actual->data.direct.virtPortProfile &&
              (iface->data.network.actual->data.direct.virtPortProfile->virtPortType
               == VIR_VIRTUALPORT_8021QBH)))) {
            networkReportError(VIR_ERR_INTERNAL_ERROR,
                               _("network '%s' claims dev='%s' is already in use by a different domain"),
                               netdef->name, actualDev);
            goto cleanup;
        }
        /* we are now assured of success, so mark the allocation */
        dev->usageCount++;
        VIR_DEBUG("Using physical device %s, usageCount %d",
                  dev->dev, dev->usageCount);
    }

    ret = 0;
cleanup:
    if (network)
        virNetworkObjUnlock(network);
    return ret;
}


/* networkReleaseActualDevice:
 * @iface:  a domain's NetDef (interface definition)
 *
 * Given a domain <interface> element that previously had its <actual>
 * element filled in (and possibly a physical device allocated to it),
 * free up the physical device for use by someone else, and free the
 * virDomainActualNetDef.
 *
 * Returns 0 on success, -1 on failure.
 */
int
networkReleaseActualDevice(virDomainNetDefPtr iface)
{
    struct network_driver *driver = driverState;
    virNetworkObjPtr network = NULL;
    virNetworkDefPtr netdef;
    char *actualDev;
    int ret = -1;

    if (iface->type != VIR_DOMAIN_NET_TYPE_NETWORK)
       return 0;

    if (!iface->data.network.actual ||
        (virDomainNetGetActualType(iface) != VIR_DOMAIN_NET_TYPE_DIRECT)) {
        VIR_DEBUG("Nothing to release to network %s", iface->data.network.name);
        ret = 0;
        goto cleanup;
    }

    networkDriverLock(driver);
    network = virNetworkFindByName(&driver->networks, iface->data.network.name);
    networkDriverUnlock(driver);
    if (!network) {
        networkReportError(VIR_ERR_NO_NETWORK,
                           _("no network with matching name '%s'"),
                           iface->data.network.name);
        goto cleanup;
    }

    actualDev = virDomainNetGetActualDirectDev(iface);
    if (!actualDev) {
        networkReportError(VIR_ERR_INTERNAL_ERROR,
                           "%s", _("the interface uses a direct mode, but has no source dev"));
            goto cleanup;
        }

    netdef = network->def;
    if (netdef->nForwardIfs == 0) {
        networkReportError(VIR_ERR_INTERNAL_ERROR,
                           _("network '%s' uses a direct mode, but has no forward dev and no interface pool"),
                           netdef->name);
        goto cleanup;
    } else {
        int ii;
        virNetworkForwardIfDefPtr dev = NULL;

        for (ii = 0; ii < netdef->nForwardIfs; ii++) {
            if (STREQ(actualDev, netdef->forwardIfs[ii].dev)) {
                dev = &netdef->forwardIfs[ii];
                break;
            }
        }
        /* dev points at the physical device we've been using */
        if (!dev) {
            networkReportError(VIR_ERR_INTERNAL_ERROR,
                               _("network '%s' doesn't have dev='%s' in use by domain"),
                               netdef->name, actualDev);
            goto cleanup;
        }

        dev->usageCount--;
        VIR_DEBUG("Releasing physical device %s, usageCount %d",
                  dev->dev, dev->usageCount);
    }

    ret = 0;
cleanup:
    if (network)
        virNetworkObjUnlock(network);
    virDomainActualNetDefFree(iface->data.network.actual);
    iface->data.network.actual = NULL;
    return ret;
}
3094 3095 3096 3097 3098 3099 3100 3101 3102 3103 3104 3105 3106 3107 3108 3109 3110 3111 3112 3113 3114 3115 3116 3117 3118 3119 3120 3121 3122 3123 3124 3125 3126 3127 3128 3129 3130 3131 3132 3133 3134 3135 3136 3137 3138 3139 3140 3141 3142 3143 3144 3145 3146 3147 3148 3149 3150 3151 3152 3153 3154 3155 3156 3157 3158 3159 3160 3161 3162 3163 3164 3165 3166 3167 3168 3169 3170 3171 3172 3173 3174 3175 3176 3177 3178 3179 3180 3181 3182 3183 3184 3185 3186 3187 3188 3189 3190 3191 3192 3193

/*
 * networkGetNetworkAddress:
 * @netname: the name of a network
 * @netaddr: string representation of IP address for that network.
 *
 * Attempt to return an IP (v4) address associated with the named
 * network. If a libvirt virtual network, that will be provided in the
 * configuration. For host bridge and direct (macvtap) networks, we
 * must do an ioctl to learn the address.
 *
 * Note: This function returns the 1st IPv4 address it finds. It might
 * be useful if it was more flexible, but the current use (getting a
 * listen address for qemu's vnc/spice graphics server) can only use a
 * single address anyway.
 *
 * Returns 0 on success, and puts a string (which must be free'd by
 * the caller) into *netaddr. Returns -1 on failure or -2 if
 * completely unsupported.
 */
int
networkGetNetworkAddress(const char *netname, char **netaddr)
{
    int ret = -1;
    struct network_driver *driver = driverState;
    virNetworkObjPtr network = NULL;
    virNetworkDefPtr netdef;
    virNetworkIpDefPtr ipdef;
    virSocketAddr addr;
    virSocketAddrPtr addrptr = NULL;
    char *devname = NULL;

    *netaddr = NULL;
    networkDriverLock(driver);
    network = virNetworkFindByName(&driver->networks, netname);
    networkDriverUnlock(driver);
    if (!network) {
        networkReportError(VIR_ERR_NO_NETWORK,
                           _("no network with matching name '%s'"),
                           netname);
        goto cleanup;
    }
    netdef = network->def;

    switch (netdef->forwardType) {
    case VIR_NETWORK_FORWARD_NONE:
    case VIR_NETWORK_FORWARD_NAT:
    case VIR_NETWORK_FORWARD_ROUTE:
        /* if there's an ipv4def, get it's address */
        ipdef = virNetworkDefGetIpByIndex(netdef, AF_INET, 0);
        if (!ipdef) {
            networkReportError(VIR_ERR_INTERNAL_ERROR,
                               _("network '%s' doesn't have an IPv4 address"),
                               netdef->name);
            break;
        }
        addrptr = &ipdef->address;
        break;

    case VIR_NETWORK_FORWARD_BRIDGE:
        if ((devname = netdef->bridge))
            break;
        /*
         * fall through if netdef->bridge wasn't set, since this is
         * also a direct-mode interface.
         */
    case VIR_NETWORK_FORWARD_PRIVATE:
    case VIR_NETWORK_FORWARD_VEPA:
    case VIR_NETWORK_FORWARD_PASSTHROUGH:
        if ((netdef->nForwardIfs > 0) && netdef->forwardIfs)
            devname = netdef->forwardIfs[0].dev;

        if (!devname) {
            networkReportError(VIR_ERR_INTERNAL_ERROR,
                               _("network '%s' has no associated interface or bridge"),
                               netdef->name);
        }
        break;
    }

    if (devname) {
        if (ifaceGetIPAddress(devname, &addr)) {
            virReportSystemError(errno,
                                 _("Failed to get IP address for '%s' (network '%s')"),
                                 devname, netdef->name);
        } else {
            addrptr = &addr;
        }
    }

    if (addrptr &&
        (*netaddr = virSocketFormatAddr(addrptr))) {
        ret = 0;
    }

cleanup:
    if (network)
        virNetworkObjUnlock(network);
    return ret;
}