virnetserverclient.c 41.6 KB
Newer Older
1 2 3
/*
 * virnetserverclient.c: generic network RPC server client
 *
4
 * Copyright (C) 2006-2013 Red Hat, Inc.
5 6 7 8 9 10 11 12 13 14 15 16 17
 * Copyright (C) 2006 Daniel P. Berrange
 *
 * This library is free software; you can redistribute it and/or
 * modify it under the terms of the GNU Lesser General Public
 * License as published by the Free Software Foundation; either
 * version 2.1 of the License, or (at your option) any later version.
 *
 * This library is distributed in the hope that it will be useful,
 * but WITHOUT ANY WARRANTY; without even the implied warranty of
 * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the GNU
 * Lesser General Public License for more details.
 *
 * You should have received a copy of the GNU Lesser General Public
18
 * License along with this library.  If not, see
O
Osier Yang 已提交
19
 * <http://www.gnu.org/licenses/>.
20 21 22 23 24 25
 *
 * Author: Daniel P. Berrange <berrange@redhat.com>
 */

#include <config.h>

26
#include "internal.h"
27
#if WITH_SASL
28 29 30 31 32
# include <sasl/sasl.h>
#endif

#include "virnetserverclient.h"

33
#include "virlog.h"
34
#include "virerror.h"
35
#include "viralloc.h"
36
#include "virthread.h"
37
#include "virkeepalive.h"
38 39
#include "virstring.h"
#include "virutil.h"
40 41 42 43 44 45 46 47 48 49 50 51 52 53 54 55 56 57 58 59 60 61 62

#define VIR_FROM_THIS VIR_FROM_RPC

/* Allow for filtering of incoming messages to a custom
 * dispatch processing queue, instead of the workers.
 * This allows for certain types of messages to be handled
 * strictly "in order"
 */

typedef struct _virNetServerClientFilter virNetServerClientFilter;
typedef virNetServerClientFilter *virNetServerClientFilterPtr;

struct _virNetServerClientFilter {
    int id;
    virNetServerClientFilterFunc func;
    void *opaque;

    virNetServerClientFilterPtr next;
};


struct _virNetServerClient
{
63
    virObjectLockable parent;
64

65
    bool wantClose;
66
    bool delayedClose;
67 68 69
    virNetSocketPtr sock;
    int auth;
    bool readonly;
70
#if WITH_GNUTLS
71 72
    virNetTLSContextPtr tlsCtxt;
    virNetTLSSessionPtr tls;
73
#endif
74
#if WITH_SASL
75 76
    virNetSASLSessionPtr sasl;
#endif
M
Michal Privoznik 已提交
77 78
    int sockTimer; /* Timer to be fired upon cached data,
                    * so we jump out from poll() immediately */
79

80 81 82

    virIdentityPtr identity;

83 84 85 86 87 88 89 90 91 92 93 94 95 96 97 98 99 100 101 102 103 104 105
    /* Count of messages in the 'tx' queue,
     * and the server worker pool queue
     * ie RPC calls in progress. Does not count
     * async events which are not used for
     * throttling calculations */
    size_t nrequests;
    size_t nrequests_max;
    /* Zero or one messages being received. Zero if
     * nrequests >= max_clients and throttling */
    virNetMessagePtr rx;
    /* Zero or many messages waiting for transmit
     * back to client, including async events */
    virNetMessagePtr tx;

    /* Filters to capture messages that would otherwise
     * end up on the 'dx' queue */
    virNetServerClientFilterPtr filters;
    int nextFilterID;

    virNetServerClientDispatchFunc dispatchFunc;
    void *dispatchOpaque;

    void *privateData;
106
    virFreeCallback privateDataFreeFunc;
107
    virNetServerClientPrivPreExecRestart privateDataPreExecRestart;
108
    virNetServerClientCloseFunc privateDataCloseFunc;
109 110

    virKeepAlivePtr keepalive;
111 112 113
};


114 115 116 117 118
static virClassPtr virNetServerClientClass;
static void virNetServerClientDispose(void *obj);

static int virNetServerClientOnceInit(void)
{
119
    if (!(virNetServerClientClass = virClassNew(virClassForObjectLockable(),
120
                                                "virNetServerClient",
121 122 123 124 125 126 127 128 129 130
                                                sizeof(virNetServerClient),
                                                virNetServerClientDispose)))
        return -1;

    return 0;
}

VIR_ONCE_GLOBAL_INIT(virNetServerClient)


131 132
static void virNetServerClientDispatchEvent(virNetSocketPtr sock, int events, void *opaque);
static void virNetServerClientUpdateEvent(virNetServerClientPtr client);
M
Michal Privoznik 已提交
133
static void virNetServerClientDispatchRead(virNetServerClientPtr client);
134 135
static int virNetServerClientSendMessageLocked(virNetServerClientPtr client,
                                               virNetMessagePtr msg);
136 137 138 139 140 141 142 143 144 145

/*
 * @client: a locked client object
 */
static int
virNetServerClientCalculateHandleMode(virNetServerClientPtr client) {
    int mode = 0;


    VIR_DEBUG("tls=%p hs=%d, rx=%p tx=%p",
146
#ifdef WITH_GNUTLS
147 148
              client->tls,
              client->tls ? virNetTLSSessionGetHandshakeStatus(client->tls) : -1,
149 150 151
#else
              NULL, -1,
#endif
152 153 154 155 156
              client->rx,
              client->tx);
    if (!client->sock || client->wantClose)
        return 0;

157
#if WITH_GNUTLS
158 159 160 161 162 163 164 165 166 167 168 169 170 171 172 173
    if (client->tls) {
        switch (virNetTLSSessionGetHandshakeStatus(client->tls)) {
        case VIR_NET_TLS_HANDSHAKE_RECVING:
            mode |= VIR_EVENT_HANDLE_READABLE;
            break;
        case VIR_NET_TLS_HANDSHAKE_SENDING:
            mode |= VIR_EVENT_HANDLE_WRITABLE;
            break;
        default:
        case VIR_NET_TLS_HANDSHAKE_COMPLETE:
            if (client->rx)
                mode |= VIR_EVENT_HANDLE_READABLE;
            if (client->tx)
                mode |= VIR_EVENT_HANDLE_WRITABLE;
        }
    } else {
174
#endif
175 176
        /* If there is a message on the rx queue, and
         * we're not in middle of a delayedClose, then
177
         * we're wanting more input */
178
        if (client->rx && !client->delayedClose)
179 180 181 182 183 184
            mode |= VIR_EVENT_HANDLE_READABLE;

        /* If there are one or more messages to send back to client,
           then monitor for writability on socket */
        if (client->tx)
            mode |= VIR_EVENT_HANDLE_WRITABLE;
185
#if WITH_GNUTLS
186
    }
187
#endif
188
    VIR_DEBUG("mode=%o", mode);
189 190 191 192 193 194 195 196 197 198 199
    return mode;
}

/*
 * @server: a locked or unlocked server object
 * @client: a locked client object
 */
static int virNetServerClientRegisterEvent(virNetServerClientPtr client)
{
    int mode = virNetServerClientCalculateHandleMode(client);

200 201 202 203
    if (!client->sock)
        return -1;

    virObjectRef(client);
204
    VIR_DEBUG("Registering client event callback %d", mode);
205
    if (virNetSocketAddIOCallback(client->sock,
206 207
                                  mode,
                                  virNetServerClientDispatchEvent,
208
                                  client,
209 210
                                  virObjectFreeCallback) < 0) {
        virObjectUnref(client);
211
        return -1;
212
    }
213 214 215 216 217 218 219 220 221 222 223 224 225 226 227 228 229

    return 0;
}

/*
 * @client: a locked client object
 */
static void virNetServerClientUpdateEvent(virNetServerClientPtr client)
{
    int mode;

    if (!client->sock)
        return;

    mode = virNetServerClientCalculateHandleMode(client);

    virNetSocketUpdateIOCallback(client->sock, mode);
M
Michal Privoznik 已提交
230 231 232

    if (client->rx && virNetSocketHasCachedData(client->sock))
        virEventUpdateTimeout(client->sockTimer, 0);
233 234 235
}


236 237 238
int virNetServerClientAddFilter(virNetServerClientPtr client,
                                virNetServerClientFilterFunc func,
                                void *opaque)
239 240
{
    virNetServerClientFilterPtr filter;
241
    virNetServerClientFilterPtr *place;
242
    int ret;
243 244 245

    if (VIR_ALLOC(filter) < 0) {
        virReportOOMError();
246
        return -1;
247 248
    }

249
    virObjectLock(client);
250

251 252 253 254
    filter->id = client->nextFilterID++;
    filter->func = func;
    filter->opaque = opaque;

255 256 257 258
    place = &client->filters;
    while (*place)
        place = &(*place)->next;
    *place = filter;
259 260 261

    ret = filter->id;

262
    virObjectUnlock(client);
263

264 265 266
    return ret;
}

267 268
void virNetServerClientRemoveFilter(virNetServerClientPtr client,
                                    int filterID)
269 270 271
{
    virNetServerClientFilterPtr tmp, prev;

272
    virObjectLock(client);
273

274 275 276 277 278 279 280 281 282 283 284 285
    prev = NULL;
    tmp = client->filters;
    while (tmp) {
        if (tmp->id == filterID) {
            if (prev)
                prev->next = tmp->next;
            else
                client->filters = tmp->next;

            VIR_FREE(tmp);
            break;
        }
E
Eric Blake 已提交
286
        prev = tmp;
287 288 289
        tmp = tmp->next;
    }

290
    virObjectUnlock(client);
291 292 293
}


294
#ifdef WITH_GNUTLS
295 296 297 298 299 300 301 302 303 304 305 306 307 308 309
/* Check the client's access. */
static int
virNetServerClientCheckAccess(virNetServerClientPtr client)
{
    virNetMessagePtr confirm;

    /* Verify client certificate. */
    if (virNetTLSContextCheckCertificate(client->tlsCtxt, client->tls) < 0)
        return -1;

    if (client->tx) {
        VIR_DEBUG("client had unexpected data pending tx after access check");
        return -1;
    }

310
    if (!(confirm = virNetMessageNew(false)))
311 312 313 314 315 316 317
        return -1;

    /* Checks have succeeded.  Write a '\1' byte back to the client to
     * indicate this (otherwise the socket is abruptly closed).
     * (NB. The '\1' byte is sent in an encrypted record).
     */
    confirm->bufferLength = 1;
318 319 320 321 322
    if (VIR_ALLOC_N(confirm->buffer, confirm->bufferLength) < 0) {
        virReportOOMError();
        virNetMessageFree(confirm);
        return -1;
    }
323 324 325 326 327 328 329
    confirm->bufferOffset = 0;
    confirm->buffer[0] = '\1';

    client->tx = confirm;

    return 0;
}
330 331
#endif

332

M
Michal Privoznik 已提交
333 334 335 336
static void virNetServerClientSockTimerFunc(int timer,
                                            void *opaque)
{
    virNetServerClientPtr client = opaque;
337
    virObjectLock(client);
M
Michal Privoznik 已提交
338 339 340 341 342
    virEventUpdateTimeout(timer, -1);
    /* Although client->rx != NULL when this timer is enabled, it might have
     * changed since the client was unlocked in the meantime. */
    if (client->rx)
        virNetServerClientDispatchRead(client);
343
    virObjectUnlock(client);
M
Michal Privoznik 已提交
344 345
}

346

347 348 349
static virNetServerClientPtr
virNetServerClientNewInternal(virNetSocketPtr sock,
                              int auth,
350
#ifdef WITH_GNUTLS
351 352
                              virNetTLSContextPtr tls,
#endif
353
                              bool readonly,
354
                              size_t nrequests_max)
355 356 357
{
    virNetServerClientPtr client;

358
    if (virNetServerClientInitialize() < 0)
359 360
        return NULL;

361
    if (!(client = virObjectLockableNew(virNetServerClientClass)))
362 363
        return NULL;

364
    client->sock = virObjectRef(sock);
365 366
    client->auth = auth;
    client->readonly = readonly;
367
#ifdef WITH_GNUTLS
368
    client->tlsCtxt = virObjectRef(tls);
369
#endif
370
    client->nrequests_max = nrequests_max;
371

M
Michal Privoznik 已提交
372 373 374 375 376
    client->sockTimer = virEventAddTimeout(-1, virNetServerClientSockTimerFunc,
                                           client, NULL);
    if (client->sockTimer < 0)
        goto error;

377
    /* Prepare one for packet receive */
378
    if (!(client->rx = virNetMessageNew(true)))
379 380
        goto error;
    client->rx->bufferLength = VIR_NET_MESSAGE_LEN_MAX;
381 382 383 384
    if (VIR_ALLOC_N(client->rx->buffer, client->rx->bufferLength) < 0) {
        virReportOOMError();
        goto error;
    }
385 386
    client->nrequests = 1;

387
    PROBE(RPC_SERVER_CLIENT_NEW,
388 389
          "client=%p sock=%p",
          client, client->sock);
390 391 392 393

    return client;

error:
394
    virObjectUnref(client);
395 396 397 398
    return NULL;
}


399 400 401 402
virNetServerClientPtr virNetServerClientNew(virNetSocketPtr sock,
                                            int auth,
                                            bool readonly,
                                            size_t nrequests_max,
403
#ifdef WITH_GNUTLS
404
                                            virNetTLSContextPtr tls,
405
#endif
406
                                            virNetServerClientPrivNew privNew,
407
                                            virNetServerClientPrivPreExecRestart privPreExecRestart,
408 409 410 411 412
                                            virFreeCallback privFree,
                                            void *privOpaque)
{
    virNetServerClientPtr client;

413
    VIR_DEBUG("sock=%p auth=%d tls=%p", sock, auth,
414
#ifdef WITH_GNUTLS
415 416 417 418 419
              tls
#else
              NULL
#endif
        );
420

421
    if (!(client = virNetServerClientNewInternal(sock, auth,
422
#ifdef WITH_GNUTLS
423 424 425
                                                 tls,
#endif
                                                 readonly, nrequests_max)))
426 427 428 429 430 431 432 433
        return NULL;

    if (privNew) {
        if (!(client->privateData = privNew(client, privOpaque))) {
            virObjectUnref(client);
            return NULL;
        }
        client->privateDataFreeFunc = privFree;
434
        client->privateDataPreExecRestart = privPreExecRestart;
435 436 437 438 439 440
    }

    return client;
}


441 442 443 444 445 446 447 448 449 450 451 452 453 454 455 456 457 458 459 460 461 462 463 464 465 466 467 468 469 470 471 472 473 474 475 476 477 478 479 480 481 482 483
virNetServerClientPtr virNetServerClientNewPostExecRestart(virJSONValuePtr object,
                                                           virNetServerClientPrivNewPostExecRestart privNew,
                                                           virNetServerClientPrivPreExecRestart privPreExecRestart,
                                                           virFreeCallback privFree,
                                                           void *privOpaque)
{
    virJSONValuePtr child;
    virNetServerClientPtr client = NULL;
    virNetSocketPtr sock;
    int auth;
    bool readonly;
    unsigned int nrequests_max;

    if (virJSONValueObjectGetNumberInt(object, "auth", &auth) < 0) {
        virReportError(VIR_ERR_INTERNAL_ERROR, "%s",
                       _("Missing auth field in JSON state document"));
        return NULL;
    }
    if (virJSONValueObjectGetBoolean(object, "readonly", &readonly) < 0) {
        virReportError(VIR_ERR_INTERNAL_ERROR, "%s",
                       _("Missing readonly field in JSON state document"));
        return NULL;
    }
    if (virJSONValueObjectGetNumberUint(object, "nrequests_max",
                                        (unsigned int *)&nrequests_max) < 0) {
        virReportError(VIR_ERR_INTERNAL_ERROR, "%s",
                       _("Missing nrequests_client_max field in JSON state document"));
        return NULL;
    }

    if (!(child = virJSONValueObjectGet(object, "sock"))) {
        virReportError(VIR_ERR_INTERNAL_ERROR, "%s",
                       _("Missing sock field in JSON state document"));
        return NULL;
    }

    if (!(sock = virNetSocketNewPostExecRestart(child))) {
        virObjectUnref(sock);
        return NULL;
    }

    if (!(client = virNetServerClientNewInternal(sock,
                                                 auth,
484
#ifdef WITH_GNUTLS
485 486
                                                 NULL,
#endif
487
                                                 readonly,
488
                                                 nrequests_max))) {
489 490 491 492 493 494 495 496 497 498 499 500 501 502 503 504 505 506 507 508 509 510 511 512 513 514 515 516 517 518 519 520 521 522 523
        virObjectUnref(sock);
        return NULL;
    }
    virObjectUnref(sock);

    if (privNew) {
        if (!(child = virJSONValueObjectGet(object, "privateData"))) {
            virReportError(VIR_ERR_INTERNAL_ERROR, "%s",
                           _("Missing privateData field in JSON state document"));
            goto error;
        }
        if (!(client->privateData = privNew(client, child, privOpaque))) {
            goto error;
        }
        client->privateDataFreeFunc = privFree;
        client->privateDataPreExecRestart = privPreExecRestart;
    }


    return client;

error:
    virObjectUnref(client);
    return NULL;
}


virJSONValuePtr virNetServerClientPreExecRestart(virNetServerClientPtr client)
{
    virJSONValuePtr object = virJSONValueNewObject();
    virJSONValuePtr child;

    if (!object)
        return NULL;

524
    virObjectLock(client);
525 526 527 528 529 530 531 532 533 534 535 536 537 538 539 540 541 542 543 544 545 546 547 548 549

    if (virJSONValueObjectAppendNumberInt(object, "auth", client->auth) < 0)
        goto error;
    if (virJSONValueObjectAppendBoolean(object, "readonly", client->readonly) < 0)
        goto error;
    if (virJSONValueObjectAppendNumberUint(object, "nrequests_max", client->nrequests_max) < 0)
        goto error;

    if (!(child = virNetSocketPreExecRestart(client->sock)))
        goto error;

    if (virJSONValueObjectAppend(object, "sock", child) < 0) {
        virJSONValueFree(child);
        goto error;
    }

    if (client->privateData && client->privateDataPreExecRestart &&
        !(child = client->privateDataPreExecRestart(client, client->privateData)))
        goto error;

    if (virJSONValueObjectAppend(object, "privateData", child) < 0) {
        virJSONValueFree(child);
        goto error;
    }

550
    virObjectUnlock(client);
551 552 553
    return object;

error:
554
    virObjectUnlock(client);
555 556 557 558 559
    virJSONValueFree(object);
    return NULL;
}


560 561 562
int virNetServerClientGetAuth(virNetServerClientPtr client)
{
    int auth;
563
    virObjectLock(client);
564
    auth = client->auth;
565
    virObjectUnlock(client);
566 567 568
    return auth;
}

569 570 571 572 573 574 575
void virNetServerClientSetAuth(virNetServerClientPtr client, int auth)
{
    virObjectLock(client);
    client->auth = auth;
    virObjectUnlock(client);
}

576 577 578
bool virNetServerClientGetReadonly(virNetServerClientPtr client)
{
    bool readonly;
579
    virObjectLock(client);
580
    readonly = client->readonly;
581
    virObjectUnlock(client);
582 583 584 585
    return readonly;
}


586
#ifdef WITH_GNUTLS
587 588 589
bool virNetServerClientHasTLSSession(virNetServerClientPtr client)
{
    bool has;
590
    virObjectLock(client);
591
    has = client->tls ? true : false;
592
    virObjectUnlock(client);
593 594 595
    return has;
}

596 597 598 599 600 601 602 603 604 605

virNetTLSSessionPtr virNetServerClientGetTLSSession(virNetServerClientPtr client)
{
    virNetTLSSessionPtr tls;
    virObjectLock(client);
    tls = client->tls;
    virObjectUnlock(client);
    return tls;
}

606 607 608
int virNetServerClientGetTLSKeySize(virNetServerClientPtr client)
{
    int size = 0;
609
    virObjectLock(client);
610 611
    if (client->tls)
        size = virNetTLSSessionGetKeySize(client->tls);
612
    virObjectUnlock(client);
613 614
    return size;
}
615
#endif
616 617 618

int virNetServerClientGetFD(virNetServerClientPtr client)
{
619
    int fd = -1;
620
    virObjectLock(client);
621 622
    if (client->sock)
        fd = virNetSocketGetFD(client->sock);
623
    virObjectUnlock(client);
624 625 626
    return fd;
}

627 628 629 630 631 632 633 634 635 636 637 638

bool virNetServerClientIsLocal(virNetServerClientPtr client)
{
    bool local = false;
    virObjectLock(client);
    if (client->sock)
        local = virNetSocketIsLocal(client->sock);
    virObjectUnlock(client);
    return local;
}


639
int virNetServerClientGetUNIXIdentity(virNetServerClientPtr client,
640 641
                                      uid_t *uid, gid_t *gid, pid_t *pid,
                                      unsigned long long *timestamp)
642
{
643
    int ret = -1;
644
    virObjectLock(client);
645
    if (client->sock)
646 647 648
        ret = virNetSocketGetUNIXIdentity(client->sock,
                                          uid, gid, pid,
                                          timestamp);
649
    virObjectUnlock(client);
650 651 652
    return ret;
}

653

654 655 656 657
static virIdentityPtr
virNetServerClientCreateIdentity(virNetServerClientPtr client)
{
    char *processid = NULL;
658
    char *processtime = NULL;
659 660 661 662 663 664 665 666 667 668 669 670 671
    char *username = NULL;
    char *groupname = NULL;
#if WITH_SASL
    char *saslname = NULL;
#endif
    char *x509dname = NULL;
    char *seccontext = NULL;
    virIdentityPtr ret = NULL;

    if (client->sock && virNetSocketIsLocal(client->sock)) {
        gid_t gid;
        uid_t uid;
        pid_t pid;
672 673 674 675
        unsigned long long timestamp;
        if (virNetSocketGetUNIXIdentity(client->sock,
                                        &uid, &gid, &pid,
                                        &timestamp) < 0)
676 677 678 679 680 681
            goto cleanup;

        if (!(username = virGetUserName(uid)))
            goto cleanup;
        if (!(groupname = virGetGroupName(gid)))
            goto cleanup;
682 683 684 685 686 687 688
        if (virAsprintf(&processid, "%llu",
                        (unsigned long long)pid) < 0) {
            virReportOOMError();
            goto cleanup;
        }
        if (virAsprintf(&processtime, "%llu",
                        timestamp) < 0) {
689 690 691 692 693 694 695 696
            virReportOOMError();
            goto cleanup;
        }
    }

#if WITH_SASL
    if (client->sasl) {
        const char *identity = virNetSASLSessionGetIdentity(client->sasl);
697
        if (VIR_STRDUP(saslname, identity) < 0)
698 699 700 701
            goto cleanup;
    }
#endif

702
#if WITH_GNUTLS
703 704
    if (client->tls) {
        const char *identity = virNetTLSSessionGetX509DName(client->tls);
705
        if (VIR_STRDUP(x509dname, identity) < 0)
706 707
            goto cleanup;
    }
708
#endif
709 710

    if (client->sock &&
711
        virNetSocketGetSELinuxContext(client->sock, &seccontext) < 0)
712 713 714 715 716 717 718 719 720 721 722 723 724 725 726 727 728 729 730 731
        goto cleanup;

    if (!(ret = virIdentityNew()))
        goto cleanup;

    if (username &&
        virIdentitySetAttr(ret,
                           VIR_IDENTITY_ATTR_UNIX_USER_NAME,
                           username) < 0)
        goto error;
    if (groupname &&
        virIdentitySetAttr(ret,
                           VIR_IDENTITY_ATTR_UNIX_GROUP_NAME,
                           groupname) < 0)
        goto error;
    if (processid &&
        virIdentitySetAttr(ret,
                           VIR_IDENTITY_ATTR_UNIX_PROCESS_ID,
                           processid) < 0)
        goto error;
732 733 734 735 736
    if (processtime &&
        virIdentitySetAttr(ret,
                           VIR_IDENTITY_ATTR_UNIX_PROCESS_TIME,
                           processtime) < 0)
        goto error;
737 738 739 740 741 742 743 744 745 746 747 748 749 750
#if HAVE_SASL
    if (saslname &&
        virIdentitySetAttr(ret,
                           VIR_IDENTITY_ATTR_SASL_USER_NAME,
                           saslname) < 0)
        goto error;
#endif
    if (x509dname &&
        virIdentitySetAttr(ret,
                           VIR_IDENTITY_ATTR_X509_DISTINGUISHED_NAME,
                           x509dname) < 0)
        goto error;
    if (seccontext &&
        virIdentitySetAttr(ret,
751
                           VIR_IDENTITY_ATTR_SELINUX_CONTEXT,
752 753 754 755 756 757 758
                           seccontext) < 0)
        goto error;

cleanup:
    VIR_FREE(username);
    VIR_FREE(groupname);
    VIR_FREE(processid);
759
    VIR_FREE(processtime);
760 761 762 763 764 765 766 767 768 769 770 771 772 773 774 775 776 777 778 779 780 781 782 783 784 785 786
    VIR_FREE(seccontext);
#if HAVE_SASL
    VIR_FREE(saslname);
#endif
    VIR_FREE(x509dname);
    return ret;

error:
    virObjectUnref(ret);
    ret = NULL;
    goto cleanup;
}


virIdentityPtr virNetServerClientGetIdentity(virNetServerClientPtr client)
{
    virIdentityPtr ret = NULL;
    virObjectLock(client);
    if (!client->identity)
        client->identity = virNetServerClientCreateIdentity(client);
    if (client->identity)
        ret = virObjectRef(client->identity);
    virObjectUnlock(client);
    return ret;
}


787 788
int virNetServerClientGetSELinuxContext(virNetServerClientPtr client,
                                        char **context)
789 790 791 792 793
{
    int ret = 0;
    *context = NULL;
    virObjectLock(client);
    if (client->sock)
794
        ret = virNetSocketGetSELinuxContext(client->sock, context);
795 796 797 798 799
    virObjectUnlock(client);
    return ret;
}


800 801 802
bool virNetServerClientIsSecure(virNetServerClientPtr client)
{
    bool secure = false;
803
    virObjectLock(client);
804
#if WITH_GNUTLS
805 806
    if (client->tls)
        secure = true;
807
#endif
808
#if WITH_SASL
809 810 811
    if (client->sasl)
        secure = true;
#endif
812
    if (client->sock && virNetSocketIsLocal(client->sock))
813
        secure = true;
814
    virObjectUnlock(client);
815 816 817 818
    return secure;
}


819
#if WITH_SASL
820 821 822 823 824 825 826 827
void virNetServerClientSetSASLSession(virNetServerClientPtr client,
                                      virNetSASLSessionPtr sasl)
{
    /* We don't set the sasl session on the socket here
     * because we need to send out the auth confirmation
     * in the clear. Only once we complete the next 'tx'
     * operation do we switch to SASL mode
     */
828
    virObjectLock(client);
829
    client->sasl = virObjectRef(sasl);
830
    virObjectUnlock(client);
831
}
832 833 834 835 836 837 838 839 840 841


virNetSASLSessionPtr virNetServerClientGetSASLSession(virNetServerClientPtr client)
{
    virNetSASLSessionPtr sasl;
    virObjectLock(client);
    sasl = client->sasl;
    virObjectUnlock(client);
    return sasl;
}
842 843 844 845 846 847
#endif


void *virNetServerClientGetPrivateData(virNetServerClientPtr client)
{
    void *data;
848
    virObjectLock(client);
849
    data = client->privateData;
850
    virObjectUnlock(client);
851 852 853 854
    return data;
}


855 856 857
void virNetServerClientSetCloseHook(virNetServerClientPtr client,
                                    virNetServerClientCloseFunc cf)
{
858
    virObjectLock(client);
859
    client->privateDataCloseFunc = cf;
860
    virObjectUnlock(client);
861 862 863
}


864 865 866 867
void virNetServerClientSetDispatcher(virNetServerClientPtr client,
                                     virNetServerClientDispatchFunc func,
                                     void *opaque)
{
868
    virObjectLock(client);
869 870
    client->dispatchFunc = func;
    client->dispatchOpaque = opaque;
871
    virObjectUnlock(client);
872 873 874 875 876
}


const char *virNetServerClientLocalAddrString(virNetServerClientPtr client)
{
877 878
    if (!client->sock)
        return NULL;
879 880 881 882 883 884
    return virNetSocketLocalAddrString(client->sock);
}


const char *virNetServerClientRemoteAddrString(virNetServerClientPtr client)
{
885 886
    if (!client->sock)
        return NULL;
887 888 889 890
    return virNetSocketRemoteAddrString(client->sock);
}


891
void virNetServerClientDispose(void *obj)
892
{
893
    virNetServerClientPtr client = obj;
894

895 896 897
    PROBE(RPC_SERVER_CLIENT_DISPOSE,
          "client=%p", client);

898 899
    virObjectUnref(client->identity);

900 901 902 903
    if (client->privateData &&
        client->privateDataFreeFunc)
        client->privateDataFreeFunc(client->privateData);

904
#if WITH_SASL
905
    virObjectUnref(client->sasl);
906
#endif
M
Michal Privoznik 已提交
907 908
    if (client->sockTimer > 0)
        virEventRemoveTimeout(client->sockTimer);
909
#if WITH_GNUTLS
910 911
    virObjectUnref(client->tls);
    virObjectUnref(client->tlsCtxt);
912
#endif
913
    virObjectUnref(client->sock);
914
    virObjectUnlock(client);
915 916 917 918 919 920 921 922 923 924 925 926 927
}


/*
 *
 * We don't free stuff here, merely disconnect the client's
 * network socket & resources.
 *
 * Full free of the client is done later in a safe point
 * where it can be guaranteed it is no longer in use
 */
void virNetServerClientClose(virNetServerClientPtr client)
{
928
    virNetServerClientCloseFunc cf;
929
    virKeepAlivePtr ka;
930

931
    virObjectLock(client);
932
    VIR_DEBUG("client=%p", client);
933
    if (!client->sock) {
934
        virObjectUnlock(client);
935 936 937
        return;
    }

938 939 940 941
    if (client->keepalive) {
        virKeepAliveStop(client->keepalive);
        ka = client->keepalive;
        client->keepalive = NULL;
942
        virObjectRef(client);
943
        virObjectUnlock(client);
944
        virObjectUnref(ka);
945
        virObjectLock(client);
946
        virObjectUnref(client);
947 948
    }

949 950
    if (client->privateDataCloseFunc) {
        cf = client->privateDataCloseFunc;
951
        virObjectRef(client);
952
        virObjectUnlock(client);
953
        (cf)(client);
954
        virObjectLock(client);
955
        virObjectUnref(client);
956 957
    }

958 959 960 961 962 963
    /* Do now, even though we don't close the socket
     * until end, to ensure we don't get invoked
     * again due to tls shutdown */
    if (client->sock)
        virNetSocketRemoveIOCallback(client->sock);

964
#if WITH_GNUTLS
965
    if (client->tls) {
966
        virObjectUnref(client->tls);
967 968
        client->tls = NULL;
    }
969
#endif
970
    client->wantClose = true;
971 972 973 974 975 976 977 978 979 980 981 982

    while (client->rx) {
        virNetMessagePtr msg
            = virNetMessageQueueServe(&client->rx);
        virNetMessageFree(msg);
    }
    while (client->tx) {
        virNetMessagePtr msg
            = virNetMessageQueueServe(&client->tx);
        virNetMessageFree(msg);
    }

983
    if (client->sock) {
984
        virObjectUnref(client->sock);
985 986 987
        client->sock = NULL;
    }

988
    virObjectUnlock(client);
989 990 991 992 993 994
}


bool virNetServerClientIsClosed(virNetServerClientPtr client)
{
    bool closed;
995
    virObjectLock(client);
996
    closed = client->sock == NULL ? true : false;
997
    virObjectUnlock(client);
998 999 1000
    return closed;
}

1001 1002
void virNetServerClientDelayedClose(virNetServerClientPtr client)
{
1003
    virObjectLock(client);
1004
    client->delayedClose = true;
1005
    virObjectUnlock(client);
1006 1007 1008
}

void virNetServerClientImmediateClose(virNetServerClientPtr client)
1009
{
1010
    virObjectLock(client);
1011
    client->wantClose = true;
1012
    virObjectUnlock(client);
1013 1014 1015 1016 1017
}

bool virNetServerClientWantClose(virNetServerClientPtr client)
{
    bool wantClose;
1018
    virObjectLock(client);
1019
    wantClose = client->wantClose;
1020
    virObjectUnlock(client);
1021 1022 1023 1024 1025 1026
    return wantClose;
}


int virNetServerClientInit(virNetServerClientPtr client)
{
1027
    virObjectLock(client);
1028

1029
#if WITH_GNUTLS
1030
    if (!client->tlsCtxt) {
1031
#endif
1032 1033 1034
        /* Plain socket, so prepare to read first message */
        if (virNetServerClientRegisterEvent(client) < 0)
            goto error;
1035
#if WITH_GNUTLS
1036 1037 1038 1039 1040 1041 1042 1043 1044 1045 1046 1047 1048 1049 1050 1051 1052 1053 1054 1055 1056 1057 1058 1059 1060 1061 1062 1063
    } else {
        int ret;

        if (!(client->tls = virNetTLSSessionNew(client->tlsCtxt,
                                                NULL)))
            goto error;

        virNetSocketSetTLSSession(client->sock,
                                  client->tls);

        /* Begin the TLS handshake. */
        ret = virNetTLSSessionHandshake(client->tls);
        if (ret == 0) {
            /* Unlikely, but ...  Next step is to check the certificate. */
            if (virNetServerClientCheckAccess(client) < 0)
                goto error;

            /* Handshake & cert check OK,  so prepare to read first message */
            if (virNetServerClientRegisterEvent(client) < 0)
                goto error;
        } else if (ret > 0) {
            /* Most likely, need to do more handshake data */
            if (virNetServerClientRegisterEvent(client) < 0)
                goto error;
        } else {
            goto error;
        }
    }
1064
#endif
1065

1066
    virObjectUnlock(client);
1067 1068 1069 1070
    return 0;

error:
    client->wantClose = true;
1071
    virObjectUnlock(client);
1072 1073 1074 1075 1076 1077 1078 1079 1080 1081 1082 1083 1084 1085 1086 1087 1088 1089
    return -1;
}



/*
 * Read data into buffer using wire decoding (plain or TLS)
 *
 * Returns:
 *   -1 on error or EOF
 *    0 on EAGAIN
 *    n number of bytes
 */
static ssize_t virNetServerClientRead(virNetServerClientPtr client)
{
    ssize_t ret;

    if (client->rx->bufferLength <= client->rx->bufferOffset) {
1090 1091 1092
        virReportError(VIR_ERR_RPC,
                       _("unexpected zero/negative length request %lld"),
                       (long long int)(client->rx->bufferLength - client->rx->bufferOffset));
1093 1094 1095 1096 1097 1098 1099 1100 1101 1102 1103 1104 1105 1106 1107 1108 1109 1110 1111 1112 1113 1114
        client->wantClose = true;
        return -1;
    }

    ret = virNetSocketRead(client->sock,
                           client->rx->buffer + client->rx->bufferOffset,
                           client->rx->bufferLength - client->rx->bufferOffset);

    if (ret <= 0)
        return ret;

    client->rx->bufferOffset += ret;
    return ret;
}


/*
 * Read data until we get a complete message to process
 */
static void virNetServerClientDispatchRead(virNetServerClientPtr client)
{
readmore:
1115 1116 1117 1118 1119
    if (client->rx->nfds == 0) {
        if (virNetServerClientRead(client) < 0) {
            client->wantClose = true;
            return; /* Error */
        }
1120 1121 1122 1123 1124 1125 1126
    }

    if (client->rx->bufferOffset < client->rx->bufferLength)
        return; /* Still not read enough */

    /* Either done with length word header */
    if (client->rx->bufferLength == VIR_NET_MESSAGE_LEN_MAX) {
1127 1128
        if (virNetMessageDecodeLength(client->rx) < 0) {
            client->wantClose = true;
1129
            return;
1130
        }
1131 1132 1133 1134 1135 1136 1137 1138 1139

        virNetServerClientUpdateEvent(client);

        /* Try and read payload immediately instead of going back
           into poll() because chances are the data is already
           waiting for us */
        goto readmore;
    } else {
        /* Grab the completed message */
1140
        virNetMessagePtr msg = client->rx;
1141
        virNetMessagePtr response = NULL;
1142
        virNetServerClientFilterPtr filter;
1143
        size_t i;
1144 1145 1146

        /* Decode the header so we can use it for routing decisions */
        if (virNetMessageDecodeHeader(msg) < 0) {
1147
            virNetMessageQueueServe(&client->rx);
1148 1149 1150 1151 1152
            virNetMessageFree(msg);
            client->wantClose = true;
            return;
        }

1153 1154
        /* Now figure out if we need to read more data to get some
         * file descriptors */
1155 1156
        if (msg->header.type == VIR_NET_CALL_WITH_FDS &&
            virNetMessageDecodeNumFDs(msg) < 0) {
1157
            virNetMessageQueueServe(&client->rx);
1158 1159
            virNetMessageFree(msg);
            client->wantClose = true;
1160
            return; /* Error */
1161
        }
1162 1163

        /* Try getting the file descriptors (may fail if blocking) */
1164
        for (i = msg->donefds; i < msg->nfds; i++) {
1165 1166
            int rv;
            if ((rv = virNetSocketRecvFD(client->sock, &(msg->fds[i]))) < 0) {
1167
                virNetMessageQueueServe(&client->rx);
1168 1169 1170 1171
                virNetMessageFree(msg);
                client->wantClose = true;
                return;
            }
1172 1173 1174 1175 1176 1177 1178 1179 1180 1181 1182 1183 1184
            if (rv == 0) /* Blocking */
                break;
            msg->donefds++;
        }

        /* Need to poll() until FDs arrive */
        if (msg->donefds < msg->nfds) {
            /* Because DecodeHeader/NumFDs reset bufferOffset, we
             * put it back to what it was, so everything works
             * again next time we run this method
             */
            client->rx->bufferOffset = client->rx->bufferLength;
            return;
1185 1186
        }

1187 1188
        /* Definitely finished reading, so remove from queue */
        virNetMessageQueueServe(&client->rx);
1189 1190 1191 1192 1193 1194
        PROBE(RPC_SERVER_CLIENT_MSG_RX,
              "client=%p len=%zu prog=%u vers=%u proc=%u type=%u status=%u serial=%u",
              client, msg->bufferLength,
              msg->header.prog, msg->header.vers, msg->header.proc,
              msg->header.type, msg->header.status, msg->header.serial);

1195 1196 1197 1198 1199 1200 1201 1202 1203 1204
        if (virKeepAliveCheckMessage(client->keepalive, msg, &response)) {
            virNetMessageFree(msg);
            client->nrequests--;
            msg = NULL;

            if (response &&
                virNetServerClientSendMessageLocked(client, response) < 0)
                virNetMessageFree(response);
        }

1205
        /* Maybe send off for queue against a filter */
1206 1207 1208 1209 1210 1211 1212 1213 1214 1215 1216 1217 1218 1219 1220
        if (msg) {
            filter = client->filters;
            while (filter) {
                int ret = filter->func(client, msg, filter->opaque);
                if (ret < 0) {
                    virNetMessageFree(msg);
                    msg = NULL;
                    if (ret < 0)
                        client->wantClose = true;
                    break;
                }
                if (ret > 0) {
                    msg = NULL;
                    break;
                }
1221

1222 1223
                filter = filter->next;
            }
1224 1225 1226 1227
        }

        /* Send off to for normal dispatch to workers */
        if (msg) {
1228
            virObjectRef(client);
1229 1230 1231 1232
            if (!client->dispatchFunc ||
                client->dispatchFunc(client, msg, client->dispatchOpaque) < 0) {
                virNetMessageFree(msg);
                client->wantClose = true;
1233
                virObjectUnref(client);
1234 1235 1236 1237 1238 1239
                return;
            }
        }

        /* Possibly need to create another receive buffer */
        if (client->nrequests < client->nrequests_max) {
1240
            if (!(client->rx = virNetMessageNew(true))) {
1241
                client->wantClose = true;
E
Eric Blake 已提交
1242 1243
            } else {
                client->rx->bufferLength = VIR_NET_MESSAGE_LEN_MAX;
1244 1245 1246 1247 1248 1249 1250
                if (VIR_ALLOC_N(client->rx->buffer,
                                client->rx->bufferLength) < 0) {
                    virReportOOMError();
                    client->wantClose = true;
                } else {
                    client->nrequests++;
                }
1251 1252 1253 1254 1255 1256 1257 1258 1259 1260 1261 1262 1263 1264 1265 1266 1267 1268 1269 1270
            }
        }
        virNetServerClientUpdateEvent(client);
    }
}


/*
 * Send client->tx using no encoding
 *
 * Returns:
 *   -1 on error or EOF
 *    0 on EAGAIN
 *    n number of bytes
 */
static ssize_t virNetServerClientWrite(virNetServerClientPtr client)
{
    ssize_t ret;

    if (client->tx->bufferLength < client->tx->bufferOffset) {
1271 1272 1273
        virReportError(VIR_ERR_RPC,
                       _("unexpected zero/negative length request %lld"),
                       (long long int)(client->tx->bufferLength - client->tx->bufferOffset));
1274 1275 1276 1277 1278 1279 1280 1281 1282 1283 1284 1285 1286 1287 1288 1289 1290 1291 1292 1293 1294 1295 1296 1297 1298 1299
        client->wantClose = true;
        return -1;
    }

    if (client->tx->bufferLength == client->tx->bufferOffset)
        return 1;

    ret = virNetSocketWrite(client->sock,
                            client->tx->buffer + client->tx->bufferOffset,
                            client->tx->bufferLength - client->tx->bufferOffset);
    if (ret <= 0)
        return ret; /* -1 error, 0 = egain */

    client->tx->bufferOffset += ret;
    return ret;
}


/*
 * Process all queued client->tx messages until
 * we would block on I/O
 */
static void
virNetServerClientDispatchWrite(virNetServerClientPtr client)
{
    while (client->tx) {
1300 1301 1302 1303 1304 1305 1306 1307 1308
        if (client->tx->bufferOffset < client->tx->bufferLength) {
            ssize_t ret;
            ret = virNetServerClientWrite(client);
            if (ret < 0) {
                client->wantClose = true;
                return;
            }
            if (ret == 0)
                return; /* Would block on write EAGAIN */
1309 1310 1311 1312
        }

        if (client->tx->bufferOffset == client->tx->bufferLength) {
            virNetMessagePtr msg;
1313 1314
            size_t i;

1315
            for (i = client->tx->donefds; i < client->tx->nfds; i++) {
1316 1317
                int rv;
                if ((rv = virNetSocketSendFD(client->sock, client->tx->fds[i])) < 0) {
1318 1319 1320
                    client->wantClose = true;
                    return;
                }
1321 1322 1323
                if (rv == 0) /* Blocking */
                    return;
                client->tx->donefds++;
1324 1325
            }

1326
#if WITH_SASL
1327 1328 1329 1330 1331
            /* Completed this 'tx' operation, so now read for all
             * future rx/tx to be under a SASL SSF layer
             */
            if (client->sasl) {
                virNetSocketSetSASLSession(client->sock, client->sasl);
1332
                virObjectUnref(client->sasl);
1333 1334 1335 1336 1337 1338 1339
                client->sasl = NULL;
            }
#endif

            /* Get finished msg from head of tx queue */
            msg = virNetMessageQueueServe(&client->tx);

1340
            if (msg->tracked) {
1341 1342 1343 1344 1345
                client->nrequests--;
                /* See if the recv queue is currently throttled */
                if (!client->rx &&
                    client->nrequests < client->nrequests_max) {
                    /* Ready to recv more messages */
1346
                    virNetMessageClear(msg);
1347 1348 1349 1350 1351 1352
                    msg->bufferLength = VIR_NET_MESSAGE_LEN_MAX;
                    if (VIR_ALLOC_N(msg->buffer, msg->bufferLength) < 0) {
                        virReportOOMError();
                        virNetMessageFree(msg);
                        return;
                    }
1353 1354 1355 1356 1357 1358 1359 1360 1361
                    client->rx = msg;
                    msg = NULL;
                    client->nrequests++;
                }
            }

            virNetMessageFree(msg);

            virNetServerClientUpdateEvent(client);
1362 1363 1364

            if (client->delayedClose)
                client->wantClose = true;
1365 1366 1367 1368
         }
    }
}

1369

1370
#if WITH_GNUTLS
1371 1372 1373 1374 1375 1376 1377 1378 1379 1380 1381 1382 1383 1384 1385 1386
static void
virNetServerClientDispatchHandshake(virNetServerClientPtr client)
{
    int ret;
    /* Continue the handshake. */
    ret = virNetTLSSessionHandshake(client->tls);
    if (ret == 0) {
        /* Finished.  Next step is to check the certificate. */
        if (virNetServerClientCheckAccess(client) < 0)
            client->wantClose = true;
        else
            virNetServerClientUpdateEvent(client);
    } else if (ret > 0) {
        /* Carry on waiting for more handshake. Update
           the events just in case handshake data flow
           direction has changed */
1387
        virNetServerClientUpdateEvent(client);
1388 1389 1390 1391 1392
    } else {
        /* Fatal error in handshake */
        client->wantClose = true;
    }
}
1393
#endif
1394 1395 1396 1397 1398 1399

static void
virNetServerClientDispatchEvent(virNetSocketPtr sock, int events, void *opaque)
{
    virNetServerClientPtr client = opaque;

1400
    virObjectLock(client);
1401 1402 1403

    if (client->sock != sock) {
        virNetSocketRemoveIOCallback(sock);
1404
        virObjectUnlock(client);
1405 1406 1407 1408 1409
        return;
    }

    if (events & (VIR_EVENT_HANDLE_WRITABLE |
                  VIR_EVENT_HANDLE_READABLE)) {
1410
#if WITH_GNUTLS
1411 1412 1413 1414 1415
        if (client->tls &&
            virNetTLSSessionGetHandshakeStatus(client->tls) !=
            VIR_NET_TLS_HANDSHAKE_COMPLETE) {
            virNetServerClientDispatchHandshake(client);
        } else {
1416
#endif
1417 1418
            if (events & VIR_EVENT_HANDLE_WRITABLE)
                virNetServerClientDispatchWrite(client);
M
Michal Privoznik 已提交
1419 1420
            if (events & VIR_EVENT_HANDLE_READABLE &&
                client->rx)
1421
                virNetServerClientDispatchRead(client);
1422
#if WITH_GNUTLS
1423
        }
1424
#endif
1425 1426 1427 1428 1429 1430 1431 1432
    }

    /* NB, will get HANGUP + READABLE at same time upon
     * disconnect */
    if (events & (VIR_EVENT_HANDLE_ERROR |
                  VIR_EVENT_HANDLE_HANGUP))
        client->wantClose = true;

1433
    virObjectUnlock(client);
1434 1435 1436
}


1437 1438 1439
static int
virNetServerClientSendMessageLocked(virNetServerClientPtr client,
                                    virNetMessagePtr msg)
1440 1441 1442 1443 1444
{
    int ret = -1;
    VIR_DEBUG("msg=%p proc=%d len=%zu offset=%zu",
              msg, msg->header.proc,
              msg->bufferLength, msg->bufferOffset);
1445

1446
    msg->donefds = 0;
1447
    if (client->sock && !client->wantClose) {
1448 1449 1450 1451 1452
        PROBE(RPC_SERVER_CLIENT_MSG_TX_QUEUE,
              "client=%p len=%zu prog=%u vers=%u proc=%u type=%u status=%u serial=%u",
              client, msg->bufferLength,
              msg->header.prog, msg->header.vers, msg->header.proc,
              msg->header.type, msg->header.status, msg->header.serial);
1453 1454 1455 1456 1457 1458
        virNetMessageQueuePush(&client->tx, msg);

        virNetServerClientUpdateEvent(client);
        ret = 0;
    }

1459 1460 1461 1462 1463 1464 1465 1466
    return ret;
}

int virNetServerClientSendMessage(virNetServerClientPtr client,
                                  virNetMessagePtr msg)
{
    int ret;

1467
    virObjectLock(client);
1468
    ret = virNetServerClientSendMessageLocked(client, msg);
1469
    virObjectUnlock(client);
1470

1471 1472 1473 1474 1475 1476 1477
    return ret;
}


bool virNetServerClientNeedAuth(virNetServerClientPtr client)
{
    bool need = false;
1478
    virObjectLock(client);
1479
    if (client->auth)
1480
        need = true;
1481
    virObjectUnlock(client);
1482 1483
    return need;
}
1484 1485 1486 1487 1488 1489 1490 1491 1492 1493 1494 1495 1496 1497 1498 1499 1500 1501 1502 1503 1504 1505 1506 1507


static void
virNetServerClientKeepAliveDeadCB(void *opaque)
{
    virNetServerClientImmediateClose(opaque);
}

static int
virNetServerClientKeepAliveSendCB(void *opaque,
                                  virNetMessagePtr msg)
{
    return virNetServerClientSendMessage(opaque, msg);
}


int
virNetServerClientInitKeepAlive(virNetServerClientPtr client,
                                int interval,
                                unsigned int count)
{
    virKeepAlivePtr ka;
    int ret = -1;

1508
    virObjectLock(client);
1509 1510 1511 1512

    if (!(ka = virKeepAliveNew(interval, count, client,
                               virNetServerClientKeepAliveSendCB,
                               virNetServerClientKeepAliveDeadCB,
1513
                               virObjectFreeCallback)))
1514 1515
        goto cleanup;
    /* keepalive object has a reference to client */
1516
    virObjectRef(client);
1517 1518 1519 1520

    client->keepalive = ka;

cleanup:
1521
    virObjectUnlock(client);
1522 1523 1524 1525 1526 1527 1528 1529

    return ret;
}

int
virNetServerClientStartKeepAlive(virNetServerClientPtr client)
{
    int ret;
1530
    virObjectLock(client);
1531
    ret = virKeepAliveStart(client->keepalive, 0, 0);
1532
    virObjectUnlock(client);
1533 1534
    return ret;
}