virnetserverclient.c 41.7 KB
Newer Older
1 2 3 4 5 6 7 8 9 10 11 12 13 14 15 16 17
/*
 * virnetserverclient.c: generic network RPC server client
 *
 * Copyright (C) 2006-2011 Red Hat, Inc.
 * Copyright (C) 2006 Daniel P. Berrange
 *
 * This library is free software; you can redistribute it and/or
 * modify it under the terms of the GNU Lesser General Public
 * License as published by the Free Software Foundation; either
 * version 2.1 of the License, or (at your option) any later version.
 *
 * This library is distributed in the hope that it will be useful,
 * but WITHOUT ANY WARRANTY; without even the implied warranty of
 * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the GNU
 * Lesser General Public License for more details.
 *
 * You should have received a copy of the GNU Lesser General Public
18
 * License along with this library.  If not, see
O
Osier Yang 已提交
19
 * <http://www.gnu.org/licenses/>.
20 21 22 23 24 25
 *
 * Author: Daniel P. Berrange <berrange@redhat.com>
 */

#include <config.h>

26
#if WITH_SASL
27 28 29 30 31
# include <sasl/sasl.h>
#endif

#include "virnetserverclient.h"

32
#include "virlog.h"
33
#include "virerror.h"
34
#include "viralloc.h"
35
#include "virthread.h"
36
#include "virkeepalive.h"
37 38
#include "virstring.h"
#include "virutil.h"
39 40 41 42 43 44 45 46 47 48 49 50 51 52 53 54 55 56 57 58 59 60 61

#define VIR_FROM_THIS VIR_FROM_RPC

/* Allow for filtering of incoming messages to a custom
 * dispatch processing queue, instead of the workers.
 * This allows for certain types of messages to be handled
 * strictly "in order"
 */

typedef struct _virNetServerClientFilter virNetServerClientFilter;
typedef virNetServerClientFilter *virNetServerClientFilterPtr;

struct _virNetServerClientFilter {
    int id;
    virNetServerClientFilterFunc func;
    void *opaque;

    virNetServerClientFilterPtr next;
};


struct _virNetServerClient
{
62
    virObjectLockable parent;
63

64
    bool wantClose;
65
    bool delayedClose;
66 67 68
    virNetSocketPtr sock;
    int auth;
    bool readonly;
69
#if WITH_GNUTLS
70 71
    virNetTLSContextPtr tlsCtxt;
    virNetTLSSessionPtr tls;
72
#endif
73
#if WITH_SASL
74 75
    virNetSASLSessionPtr sasl;
#endif
M
Michal Privoznik 已提交
76 77
    int sockTimer; /* Timer to be fired upon cached data,
                    * so we jump out from poll() immediately */
78

79 80 81

    virIdentityPtr identity;

82 83 84 85 86 87 88 89 90 91 92 93 94 95 96 97 98 99 100 101 102 103 104
    /* Count of messages in the 'tx' queue,
     * and the server worker pool queue
     * ie RPC calls in progress. Does not count
     * async events which are not used for
     * throttling calculations */
    size_t nrequests;
    size_t nrequests_max;
    /* Zero or one messages being received. Zero if
     * nrequests >= max_clients and throttling */
    virNetMessagePtr rx;
    /* Zero or many messages waiting for transmit
     * back to client, including async events */
    virNetMessagePtr tx;

    /* Filters to capture messages that would otherwise
     * end up on the 'dx' queue */
    virNetServerClientFilterPtr filters;
    int nextFilterID;

    virNetServerClientDispatchFunc dispatchFunc;
    void *dispatchOpaque;

    void *privateData;
105
    virFreeCallback privateDataFreeFunc;
106
    virNetServerClientPrivPreExecRestart privateDataPreExecRestart;
107
    virNetServerClientCloseFunc privateDataCloseFunc;
108 109

    virKeepAlivePtr keepalive;
110 111 112
};


113 114 115 116 117
static virClassPtr virNetServerClientClass;
static void virNetServerClientDispose(void *obj);

static int virNetServerClientOnceInit(void)
{
118
    if (!(virNetServerClientClass = virClassNew(virClassForObjectLockable(),
119
                                                "virNetServerClient",
120 121 122 123 124 125 126 127 128 129
                                                sizeof(virNetServerClient),
                                                virNetServerClientDispose)))
        return -1;

    return 0;
}

VIR_ONCE_GLOBAL_INIT(virNetServerClient)


130 131
static void virNetServerClientDispatchEvent(virNetSocketPtr sock, int events, void *opaque);
static void virNetServerClientUpdateEvent(virNetServerClientPtr client);
M
Michal Privoznik 已提交
132
static void virNetServerClientDispatchRead(virNetServerClientPtr client);
133 134
static int virNetServerClientSendMessageLocked(virNetServerClientPtr client,
                                               virNetMessagePtr msg);
135 136 137 138 139 140 141 142 143 144

/*
 * @client: a locked client object
 */
static int
virNetServerClientCalculateHandleMode(virNetServerClientPtr client) {
    int mode = 0;


    VIR_DEBUG("tls=%p hs=%d, rx=%p tx=%p",
145
#ifdef WITH_GNUTLS
146 147
              client->tls,
              client->tls ? virNetTLSSessionGetHandshakeStatus(client->tls) : -1,
148 149 150
#else
              NULL, -1,
#endif
151 152 153 154 155
              client->rx,
              client->tx);
    if (!client->sock || client->wantClose)
        return 0;

156
#if WITH_GNUTLS
157 158 159 160 161 162 163 164 165 166 167 168 169 170 171 172
    if (client->tls) {
        switch (virNetTLSSessionGetHandshakeStatus(client->tls)) {
        case VIR_NET_TLS_HANDSHAKE_RECVING:
            mode |= VIR_EVENT_HANDLE_READABLE;
            break;
        case VIR_NET_TLS_HANDSHAKE_SENDING:
            mode |= VIR_EVENT_HANDLE_WRITABLE;
            break;
        default:
        case VIR_NET_TLS_HANDSHAKE_COMPLETE:
            if (client->rx)
                mode |= VIR_EVENT_HANDLE_READABLE;
            if (client->tx)
                mode |= VIR_EVENT_HANDLE_WRITABLE;
        }
    } else {
173
#endif
174 175
        /* If there is a message on the rx queue, and
         * we're not in middle of a delayedClose, then
176
         * we're wanting more input */
177
        if (client->rx && !client->delayedClose)
178 179 180 181 182 183
            mode |= VIR_EVENT_HANDLE_READABLE;

        /* If there are one or more messages to send back to client,
           then monitor for writability on socket */
        if (client->tx)
            mode |= VIR_EVENT_HANDLE_WRITABLE;
184
#if WITH_GNUTLS
185
    }
186
#endif
187
    VIR_DEBUG("mode=%o", mode);
188 189 190 191 192 193 194 195 196 197 198
    return mode;
}

/*
 * @server: a locked or unlocked server object
 * @client: a locked client object
 */
static int virNetServerClientRegisterEvent(virNetServerClientPtr client)
{
    int mode = virNetServerClientCalculateHandleMode(client);

199 200 201 202
    if (!client->sock)
        return -1;

    virObjectRef(client);
203
    VIR_DEBUG("Registering client event callback %d", mode);
204
    if (virNetSocketAddIOCallback(client->sock,
205 206
                                  mode,
                                  virNetServerClientDispatchEvent,
207
                                  client,
208 209
                                  virObjectFreeCallback) < 0) {
        virObjectUnref(client);
210
        return -1;
211
    }
212 213 214 215 216 217 218 219 220 221 222 223 224 225 226 227 228

    return 0;
}

/*
 * @client: a locked client object
 */
static void virNetServerClientUpdateEvent(virNetServerClientPtr client)
{
    int mode;

    if (!client->sock)
        return;

    mode = virNetServerClientCalculateHandleMode(client);

    virNetSocketUpdateIOCallback(client->sock, mode);
M
Michal Privoznik 已提交
229 230 231

    if (client->rx && virNetSocketHasCachedData(client->sock))
        virEventUpdateTimeout(client->sockTimer, 0);
232 233 234
}


235 236 237
int virNetServerClientAddFilter(virNetServerClientPtr client,
                                virNetServerClientFilterFunc func,
                                void *opaque)
238 239
{
    virNetServerClientFilterPtr filter;
240
    virNetServerClientFilterPtr *place;
241
    int ret;
242 243 244

    if (VIR_ALLOC(filter) < 0) {
        virReportOOMError();
245
        return -1;
246 247
    }

248
    virObjectLock(client);
249

250 251 252 253
    filter->id = client->nextFilterID++;
    filter->func = func;
    filter->opaque = opaque;

254 255 256 257
    place = &client->filters;
    while (*place)
        place = &(*place)->next;
    *place = filter;
258 259 260

    ret = filter->id;

261
    virObjectUnlock(client);
262

263 264 265
    return ret;
}

266 267
void virNetServerClientRemoveFilter(virNetServerClientPtr client,
                                    int filterID)
268 269 270
{
    virNetServerClientFilterPtr tmp, prev;

271
    virObjectLock(client);
272

273 274 275 276 277 278 279 280 281 282 283 284
    prev = NULL;
    tmp = client->filters;
    while (tmp) {
        if (tmp->id == filterID) {
            if (prev)
                prev->next = tmp->next;
            else
                client->filters = tmp->next;

            VIR_FREE(tmp);
            break;
        }
E
Eric Blake 已提交
285
        prev = tmp;
286 287 288
        tmp = tmp->next;
    }

289
    virObjectUnlock(client);
290 291 292
}


293
#ifdef WITH_GNUTLS
294 295 296 297 298 299 300 301 302 303 304 305 306 307 308
/* Check the client's access. */
static int
virNetServerClientCheckAccess(virNetServerClientPtr client)
{
    virNetMessagePtr confirm;

    /* Verify client certificate. */
    if (virNetTLSContextCheckCertificate(client->tlsCtxt, client->tls) < 0)
        return -1;

    if (client->tx) {
        VIR_DEBUG("client had unexpected data pending tx after access check");
        return -1;
    }

309
    if (!(confirm = virNetMessageNew(false)))
310 311 312 313 314 315 316
        return -1;

    /* Checks have succeeded.  Write a '\1' byte back to the client to
     * indicate this (otherwise the socket is abruptly closed).
     * (NB. The '\1' byte is sent in an encrypted record).
     */
    confirm->bufferLength = 1;
317 318 319 320 321
    if (VIR_ALLOC_N(confirm->buffer, confirm->bufferLength) < 0) {
        virReportOOMError();
        virNetMessageFree(confirm);
        return -1;
    }
322 323 324 325 326 327 328
    confirm->bufferOffset = 0;
    confirm->buffer[0] = '\1';

    client->tx = confirm;

    return 0;
}
329 330
#endif

331

M
Michal Privoznik 已提交
332 333 334 335
static void virNetServerClientSockTimerFunc(int timer,
                                            void *opaque)
{
    virNetServerClientPtr client = opaque;
336
    virObjectLock(client);
M
Michal Privoznik 已提交
337 338 339 340 341
    virEventUpdateTimeout(timer, -1);
    /* Although client->rx != NULL when this timer is enabled, it might have
     * changed since the client was unlocked in the meantime. */
    if (client->rx)
        virNetServerClientDispatchRead(client);
342
    virObjectUnlock(client);
M
Michal Privoznik 已提交
343 344
}

345

346 347 348
static virNetServerClientPtr
virNetServerClientNewInternal(virNetSocketPtr sock,
                              int auth,
349
#ifdef WITH_GNUTLS
350 351
                              virNetTLSContextPtr tls,
#endif
352
                              bool readonly,
353
                              size_t nrequests_max)
354 355 356
{
    virNetServerClientPtr client;

357
    if (virNetServerClientInitialize() < 0)
358 359
        return NULL;

360
    if (!(client = virObjectLockableNew(virNetServerClientClass)))
361 362
        return NULL;

363
    client->sock = virObjectRef(sock);
364 365
    client->auth = auth;
    client->readonly = readonly;
366
#ifdef WITH_GNUTLS
367
    client->tlsCtxt = virObjectRef(tls);
368
#endif
369
    client->nrequests_max = nrequests_max;
370

M
Michal Privoznik 已提交
371 372 373 374 375
    client->sockTimer = virEventAddTimeout(-1, virNetServerClientSockTimerFunc,
                                           client, NULL);
    if (client->sockTimer < 0)
        goto error;

376
    /* Prepare one for packet receive */
377
    if (!(client->rx = virNetMessageNew(true)))
378 379
        goto error;
    client->rx->bufferLength = VIR_NET_MESSAGE_LEN_MAX;
380 381 382 383
    if (VIR_ALLOC_N(client->rx->buffer, client->rx->bufferLength) < 0) {
        virReportOOMError();
        goto error;
    }
384 385
    client->nrequests = 1;

386
    PROBE(RPC_SERVER_CLIENT_NEW,
387 388
          "client=%p sock=%p",
          client, client->sock);
389 390 391 392

    return client;

error:
393
    virObjectUnref(client);
394 395 396 397
    return NULL;
}


398 399 400 401
virNetServerClientPtr virNetServerClientNew(virNetSocketPtr sock,
                                            int auth,
                                            bool readonly,
                                            size_t nrequests_max,
402
#ifdef WITH_GNUTLS
403
                                            virNetTLSContextPtr tls,
404
#endif
405
                                            virNetServerClientPrivNew privNew,
406
                                            virNetServerClientPrivPreExecRestart privPreExecRestart,
407 408 409 410 411
                                            virFreeCallback privFree,
                                            void *privOpaque)
{
    virNetServerClientPtr client;

412
    VIR_DEBUG("sock=%p auth=%d tls=%p", sock, auth,
413
#ifdef WITH_GNUTLS
414 415 416 417 418
              tls
#else
              NULL
#endif
        );
419

420
    if (!(client = virNetServerClientNewInternal(sock, auth,
421
#ifdef WITH_GNUTLS
422 423 424
                                                 tls,
#endif
                                                 readonly, nrequests_max)))
425 426 427 428 429 430 431 432
        return NULL;

    if (privNew) {
        if (!(client->privateData = privNew(client, privOpaque))) {
            virObjectUnref(client);
            return NULL;
        }
        client->privateDataFreeFunc = privFree;
433
        client->privateDataPreExecRestart = privPreExecRestart;
434 435 436 437 438 439
    }

    return client;
}


440 441 442 443 444 445 446 447 448 449 450 451 452 453 454 455 456 457 458 459 460 461 462 463 464 465 466 467 468 469 470 471 472 473 474 475 476 477 478 479 480 481 482
virNetServerClientPtr virNetServerClientNewPostExecRestart(virJSONValuePtr object,
                                                           virNetServerClientPrivNewPostExecRestart privNew,
                                                           virNetServerClientPrivPreExecRestart privPreExecRestart,
                                                           virFreeCallback privFree,
                                                           void *privOpaque)
{
    virJSONValuePtr child;
    virNetServerClientPtr client = NULL;
    virNetSocketPtr sock;
    int auth;
    bool readonly;
    unsigned int nrequests_max;

    if (virJSONValueObjectGetNumberInt(object, "auth", &auth) < 0) {
        virReportError(VIR_ERR_INTERNAL_ERROR, "%s",
                       _("Missing auth field in JSON state document"));
        return NULL;
    }
    if (virJSONValueObjectGetBoolean(object, "readonly", &readonly) < 0) {
        virReportError(VIR_ERR_INTERNAL_ERROR, "%s",
                       _("Missing readonly field in JSON state document"));
        return NULL;
    }
    if (virJSONValueObjectGetNumberUint(object, "nrequests_max",
                                        (unsigned int *)&nrequests_max) < 0) {
        virReportError(VIR_ERR_INTERNAL_ERROR, "%s",
                       _("Missing nrequests_client_max field in JSON state document"));
        return NULL;
    }

    if (!(child = virJSONValueObjectGet(object, "sock"))) {
        virReportError(VIR_ERR_INTERNAL_ERROR, "%s",
                       _("Missing sock field in JSON state document"));
        return NULL;
    }

    if (!(sock = virNetSocketNewPostExecRestart(child))) {
        virObjectUnref(sock);
        return NULL;
    }

    if (!(client = virNetServerClientNewInternal(sock,
                                                 auth,
483
#ifdef WITH_GNUTLS
484 485
                                                 NULL,
#endif
486
                                                 readonly,
487
                                                 nrequests_max))) {
488 489 490 491 492 493 494 495 496 497 498 499 500 501 502 503 504 505 506 507 508 509 510 511 512 513 514 515 516 517 518 519 520 521 522
        virObjectUnref(sock);
        return NULL;
    }
    virObjectUnref(sock);

    if (privNew) {
        if (!(child = virJSONValueObjectGet(object, "privateData"))) {
            virReportError(VIR_ERR_INTERNAL_ERROR, "%s",
                           _("Missing privateData field in JSON state document"));
            goto error;
        }
        if (!(client->privateData = privNew(client, child, privOpaque))) {
            goto error;
        }
        client->privateDataFreeFunc = privFree;
        client->privateDataPreExecRestart = privPreExecRestart;
    }


    return client;

error:
    virObjectUnref(client);
    return NULL;
}


virJSONValuePtr virNetServerClientPreExecRestart(virNetServerClientPtr client)
{
    virJSONValuePtr object = virJSONValueNewObject();
    virJSONValuePtr child;

    if (!object)
        return NULL;

523
    virObjectLock(client);
524 525 526 527 528 529 530 531 532 533 534 535 536 537 538 539 540 541 542 543 544 545 546 547 548

    if (virJSONValueObjectAppendNumberInt(object, "auth", client->auth) < 0)
        goto error;
    if (virJSONValueObjectAppendBoolean(object, "readonly", client->readonly) < 0)
        goto error;
    if (virJSONValueObjectAppendNumberUint(object, "nrequests_max", client->nrequests_max) < 0)
        goto error;

    if (!(child = virNetSocketPreExecRestart(client->sock)))
        goto error;

    if (virJSONValueObjectAppend(object, "sock", child) < 0) {
        virJSONValueFree(child);
        goto error;
    }

    if (client->privateData && client->privateDataPreExecRestart &&
        !(child = client->privateDataPreExecRestart(client, client->privateData)))
        goto error;

    if (virJSONValueObjectAppend(object, "privateData", child) < 0) {
        virJSONValueFree(child);
        goto error;
    }

549
    virObjectUnlock(client);
550 551 552
    return object;

error:
553
    virObjectUnlock(client);
554 555 556 557 558
    virJSONValueFree(object);
    return NULL;
}


559 560 561
int virNetServerClientGetAuth(virNetServerClientPtr client)
{
    int auth;
562
    virObjectLock(client);
563
    auth = client->auth;
564
    virObjectUnlock(client);
565 566 567
    return auth;
}

568 569 570 571 572 573 574
void virNetServerClientSetAuth(virNetServerClientPtr client, int auth)
{
    virObjectLock(client);
    client->auth = auth;
    virObjectUnlock(client);
}

575 576 577
bool virNetServerClientGetReadonly(virNetServerClientPtr client)
{
    bool readonly;
578
    virObjectLock(client);
579
    readonly = client->readonly;
580
    virObjectUnlock(client);
581 582 583 584
    return readonly;
}


585
#ifdef WITH_GNUTLS
586 587 588
bool virNetServerClientHasTLSSession(virNetServerClientPtr client)
{
    bool has;
589
    virObjectLock(client);
590
    has = client->tls ? true : false;
591
    virObjectUnlock(client);
592 593 594
    return has;
}

595 596 597 598 599 600 601 602 603 604

virNetTLSSessionPtr virNetServerClientGetTLSSession(virNetServerClientPtr client)
{
    virNetTLSSessionPtr tls;
    virObjectLock(client);
    tls = client->tls;
    virObjectUnlock(client);
    return tls;
}

605 606 607
int virNetServerClientGetTLSKeySize(virNetServerClientPtr client)
{
    int size = 0;
608
    virObjectLock(client);
609 610
    if (client->tls)
        size = virNetTLSSessionGetKeySize(client->tls);
611
    virObjectUnlock(client);
612 613
    return size;
}
614
#endif
615 616 617

int virNetServerClientGetFD(virNetServerClientPtr client)
{
618
    int fd = -1;
619
    virObjectLock(client);
620 621
    if (client->sock)
        fd = virNetSocketGetFD(client->sock);
622
    virObjectUnlock(client);
623 624 625
    return fd;
}

626 627 628 629 630 631 632 633 634 635 636 637

bool virNetServerClientIsLocal(virNetServerClientPtr client)
{
    bool local = false;
    virObjectLock(client);
    if (client->sock)
        local = virNetSocketIsLocal(client->sock);
    virObjectUnlock(client);
    return local;
}


638
int virNetServerClientGetUNIXIdentity(virNetServerClientPtr client,
639 640
                                      uid_t *uid, gid_t *gid, pid_t *pid,
                                      unsigned long long *timestamp)
641
{
642
    int ret = -1;
643
    virObjectLock(client);
644
    if (client->sock)
645 646 647
        ret = virNetSocketGetUNIXIdentity(client->sock,
                                          uid, gid, pid,
                                          timestamp);
648
    virObjectUnlock(client);
649 650 651
    return ret;
}

652

653 654 655 656
static virIdentityPtr
virNetServerClientCreateIdentity(virNetServerClientPtr client)
{
    char *processid = NULL;
657
    char *processtime = NULL;
658 659 660 661 662 663 664 665 666 667 668 669 670
    char *username = NULL;
    char *groupname = NULL;
#if WITH_SASL
    char *saslname = NULL;
#endif
    char *x509dname = NULL;
    char *seccontext = NULL;
    virIdentityPtr ret = NULL;

    if (client->sock && virNetSocketIsLocal(client->sock)) {
        gid_t gid;
        uid_t uid;
        pid_t pid;
671 672 673 674
        unsigned long long timestamp;
        if (virNetSocketGetUNIXIdentity(client->sock,
                                        &uid, &gid, &pid,
                                        &timestamp) < 0)
675 676 677 678 679 680
            goto cleanup;

        if (!(username = virGetUserName(uid)))
            goto cleanup;
        if (!(groupname = virGetGroupName(gid)))
            goto cleanup;
681 682 683 684 685 686 687
        if (virAsprintf(&processid, "%llu",
                        (unsigned long long)pid) < 0) {
            virReportOOMError();
            goto cleanup;
        }
        if (virAsprintf(&processtime, "%llu",
                        timestamp) < 0) {
688 689 690 691 692 693 694 695 696 697 698 699 700 701 702 703
            virReportOOMError();
            goto cleanup;
        }
    }

#if WITH_SASL
    if (client->sasl) {
        const char *identity = virNetSASLSessionGetIdentity(client->sasl);
        if (identity &&
            !(saslname = strdup(identity))) {
            virReportOOMError();
            goto cleanup;
        }
    }
#endif

704
#if WITH_GNUTLS
705 706 707 708 709 710 711 712
    if (client->tls) {
        const char *identity = virNetTLSSessionGetX509DName(client->tls);
        if (identity &&
            !(x509dname = strdup(identity))) {
            virReportOOMError();
            goto cleanup;
        }
    }
713
#endif
714 715

    if (client->sock &&
716
        virNetSocketGetSELinuxContext(client->sock, &seccontext) < 0)
717 718 719 720 721 722 723 724 725 726 727 728 729 730 731 732 733 734 735 736
        goto cleanup;

    if (!(ret = virIdentityNew()))
        goto cleanup;

    if (username &&
        virIdentitySetAttr(ret,
                           VIR_IDENTITY_ATTR_UNIX_USER_NAME,
                           username) < 0)
        goto error;
    if (groupname &&
        virIdentitySetAttr(ret,
                           VIR_IDENTITY_ATTR_UNIX_GROUP_NAME,
                           groupname) < 0)
        goto error;
    if (processid &&
        virIdentitySetAttr(ret,
                           VIR_IDENTITY_ATTR_UNIX_PROCESS_ID,
                           processid) < 0)
        goto error;
737 738 739 740 741
    if (processtime &&
        virIdentitySetAttr(ret,
                           VIR_IDENTITY_ATTR_UNIX_PROCESS_TIME,
                           processtime) < 0)
        goto error;
742 743 744 745 746 747 748 749 750 751 752 753 754 755
#if HAVE_SASL
    if (saslname &&
        virIdentitySetAttr(ret,
                           VIR_IDENTITY_ATTR_SASL_USER_NAME,
                           saslname) < 0)
        goto error;
#endif
    if (x509dname &&
        virIdentitySetAttr(ret,
                           VIR_IDENTITY_ATTR_X509_DISTINGUISHED_NAME,
                           x509dname) < 0)
        goto error;
    if (seccontext &&
        virIdentitySetAttr(ret,
756
                           VIR_IDENTITY_ATTR_SELINUX_CONTEXT,
757 758 759 760 761 762 763
                           seccontext) < 0)
        goto error;

cleanup:
    VIR_FREE(username);
    VIR_FREE(groupname);
    VIR_FREE(processid);
764
    VIR_FREE(processtime);
765 766 767 768 769 770 771 772 773 774 775 776 777 778 779 780 781 782 783 784 785 786 787 788 789 790 791
    VIR_FREE(seccontext);
#if HAVE_SASL
    VIR_FREE(saslname);
#endif
    VIR_FREE(x509dname);
    return ret;

error:
    virObjectUnref(ret);
    ret = NULL;
    goto cleanup;
}


virIdentityPtr virNetServerClientGetIdentity(virNetServerClientPtr client)
{
    virIdentityPtr ret = NULL;
    virObjectLock(client);
    if (!client->identity)
        client->identity = virNetServerClientCreateIdentity(client);
    if (client->identity)
        ret = virObjectRef(client->identity);
    virObjectUnlock(client);
    return ret;
}


792 793
int virNetServerClientGetSELinuxContext(virNetServerClientPtr client,
                                        char **context)
794 795 796 797 798
{
    int ret = 0;
    *context = NULL;
    virObjectLock(client);
    if (client->sock)
799
        ret = virNetSocketGetSELinuxContext(client->sock, context);
800 801 802 803 804
    virObjectUnlock(client);
    return ret;
}


805 806 807
bool virNetServerClientIsSecure(virNetServerClientPtr client)
{
    bool secure = false;
808
    virObjectLock(client);
809
#if WITH_GNUTLS
810 811
    if (client->tls)
        secure = true;
812
#endif
813
#if WITH_SASL
814 815 816
    if (client->sasl)
        secure = true;
#endif
817
    if (client->sock && virNetSocketIsLocal(client->sock))
818
        secure = true;
819
    virObjectUnlock(client);
820 821 822 823
    return secure;
}


824
#if WITH_SASL
825 826 827 828 829 830 831 832
void virNetServerClientSetSASLSession(virNetServerClientPtr client,
                                      virNetSASLSessionPtr sasl)
{
    /* We don't set the sasl session on the socket here
     * because we need to send out the auth confirmation
     * in the clear. Only once we complete the next 'tx'
     * operation do we switch to SASL mode
     */
833
    virObjectLock(client);
834
    client->sasl = virObjectRef(sasl);
835
    virObjectUnlock(client);
836
}
837 838 839 840 841 842 843 844 845 846


virNetSASLSessionPtr virNetServerClientGetSASLSession(virNetServerClientPtr client)
{
    virNetSASLSessionPtr sasl;
    virObjectLock(client);
    sasl = client->sasl;
    virObjectUnlock(client);
    return sasl;
}
847 848 849 850 851 852
#endif


void *virNetServerClientGetPrivateData(virNetServerClientPtr client)
{
    void *data;
853
    virObjectLock(client);
854
    data = client->privateData;
855
    virObjectUnlock(client);
856 857 858 859
    return data;
}


860 861 862
void virNetServerClientSetCloseHook(virNetServerClientPtr client,
                                    virNetServerClientCloseFunc cf)
{
863
    virObjectLock(client);
864
    client->privateDataCloseFunc = cf;
865
    virObjectUnlock(client);
866 867 868
}


869 870 871 872
void virNetServerClientSetDispatcher(virNetServerClientPtr client,
                                     virNetServerClientDispatchFunc func,
                                     void *opaque)
{
873
    virObjectLock(client);
874 875
    client->dispatchFunc = func;
    client->dispatchOpaque = opaque;
876
    virObjectUnlock(client);
877 878 879 880 881
}


const char *virNetServerClientLocalAddrString(virNetServerClientPtr client)
{
882 883
    if (!client->sock)
        return NULL;
884 885 886 887 888 889
    return virNetSocketLocalAddrString(client->sock);
}


const char *virNetServerClientRemoteAddrString(virNetServerClientPtr client)
{
890 891
    if (!client->sock)
        return NULL;
892 893 894 895
    return virNetSocketRemoteAddrString(client->sock);
}


896
void virNetServerClientDispose(void *obj)
897
{
898
    virNetServerClientPtr client = obj;
899

900 901 902
    PROBE(RPC_SERVER_CLIENT_DISPOSE,
          "client=%p", client);

903 904
    virObjectUnref(client->identity);

905 906 907 908
    if (client->privateData &&
        client->privateDataFreeFunc)
        client->privateDataFreeFunc(client->privateData);

909
#if WITH_SASL
910
    virObjectUnref(client->sasl);
911
#endif
M
Michal Privoznik 已提交
912 913
    if (client->sockTimer > 0)
        virEventRemoveTimeout(client->sockTimer);
914
#if WITH_GNUTLS
915 916
    virObjectUnref(client->tls);
    virObjectUnref(client->tlsCtxt);
917
#endif
918
    virObjectUnref(client->sock);
919
    virObjectUnlock(client);
920 921 922 923 924 925 926 927 928 929 930 931 932
}


/*
 *
 * We don't free stuff here, merely disconnect the client's
 * network socket & resources.
 *
 * Full free of the client is done later in a safe point
 * where it can be guaranteed it is no longer in use
 */
void virNetServerClientClose(virNetServerClientPtr client)
{
933
    virNetServerClientCloseFunc cf;
934
    virKeepAlivePtr ka;
935

936
    virObjectLock(client);
937
    VIR_DEBUG("client=%p", client);
938
    if (!client->sock) {
939
        virObjectUnlock(client);
940 941 942
        return;
    }

943 944 945 946
    if (client->keepalive) {
        virKeepAliveStop(client->keepalive);
        ka = client->keepalive;
        client->keepalive = NULL;
947
        virObjectRef(client);
948
        virObjectUnlock(client);
949
        virObjectUnref(ka);
950
        virObjectLock(client);
951
        virObjectUnref(client);
952 953
    }

954 955
    if (client->privateDataCloseFunc) {
        cf = client->privateDataCloseFunc;
956
        virObjectRef(client);
957
        virObjectUnlock(client);
958
        (cf)(client);
959
        virObjectLock(client);
960
        virObjectUnref(client);
961 962
    }

963 964 965 966 967 968
    /* Do now, even though we don't close the socket
     * until end, to ensure we don't get invoked
     * again due to tls shutdown */
    if (client->sock)
        virNetSocketRemoveIOCallback(client->sock);

969
#if WITH_GNUTLS
970
    if (client->tls) {
971
        virObjectUnref(client->tls);
972 973
        client->tls = NULL;
    }
974
#endif
975
    client->wantClose = true;
976 977 978 979 980 981 982 983 984 985 986 987

    while (client->rx) {
        virNetMessagePtr msg
            = virNetMessageQueueServe(&client->rx);
        virNetMessageFree(msg);
    }
    while (client->tx) {
        virNetMessagePtr msg
            = virNetMessageQueueServe(&client->tx);
        virNetMessageFree(msg);
    }

988
    if (client->sock) {
989
        virObjectUnref(client->sock);
990 991 992
        client->sock = NULL;
    }

993
    virObjectUnlock(client);
994 995 996 997 998 999
}


bool virNetServerClientIsClosed(virNetServerClientPtr client)
{
    bool closed;
1000
    virObjectLock(client);
1001
    closed = client->sock == NULL ? true : false;
1002
    virObjectUnlock(client);
1003 1004 1005
    return closed;
}

1006 1007
void virNetServerClientDelayedClose(virNetServerClientPtr client)
{
1008
    virObjectLock(client);
1009
    client->delayedClose = true;
1010
    virObjectUnlock(client);
1011 1012 1013
}

void virNetServerClientImmediateClose(virNetServerClientPtr client)
1014
{
1015
    virObjectLock(client);
1016
    client->wantClose = true;
1017
    virObjectUnlock(client);
1018 1019 1020 1021 1022
}

bool virNetServerClientWantClose(virNetServerClientPtr client)
{
    bool wantClose;
1023
    virObjectLock(client);
1024
    wantClose = client->wantClose;
1025
    virObjectUnlock(client);
1026 1027 1028 1029 1030 1031
    return wantClose;
}


int virNetServerClientInit(virNetServerClientPtr client)
{
1032
    virObjectLock(client);
1033

1034
#if WITH_GNUTLS
1035
    if (!client->tlsCtxt) {
1036
#endif
1037 1038 1039
        /* Plain socket, so prepare to read first message */
        if (virNetServerClientRegisterEvent(client) < 0)
            goto error;
1040
#if WITH_GNUTLS
1041 1042 1043 1044 1045 1046 1047 1048 1049 1050 1051 1052 1053 1054 1055 1056 1057 1058 1059 1060 1061 1062 1063 1064 1065 1066 1067 1068
    } else {
        int ret;

        if (!(client->tls = virNetTLSSessionNew(client->tlsCtxt,
                                                NULL)))
            goto error;

        virNetSocketSetTLSSession(client->sock,
                                  client->tls);

        /* Begin the TLS handshake. */
        ret = virNetTLSSessionHandshake(client->tls);
        if (ret == 0) {
            /* Unlikely, but ...  Next step is to check the certificate. */
            if (virNetServerClientCheckAccess(client) < 0)
                goto error;

            /* Handshake & cert check OK,  so prepare to read first message */
            if (virNetServerClientRegisterEvent(client) < 0)
                goto error;
        } else if (ret > 0) {
            /* Most likely, need to do more handshake data */
            if (virNetServerClientRegisterEvent(client) < 0)
                goto error;
        } else {
            goto error;
        }
    }
1069
#endif
1070

1071
    virObjectUnlock(client);
1072 1073 1074 1075
    return 0;

error:
    client->wantClose = true;
1076
    virObjectUnlock(client);
1077 1078 1079 1080 1081 1082 1083 1084 1085 1086 1087 1088 1089 1090 1091 1092 1093 1094
    return -1;
}



/*
 * Read data into buffer using wire decoding (plain or TLS)
 *
 * Returns:
 *   -1 on error or EOF
 *    0 on EAGAIN
 *    n number of bytes
 */
static ssize_t virNetServerClientRead(virNetServerClientPtr client)
{
    ssize_t ret;

    if (client->rx->bufferLength <= client->rx->bufferOffset) {
1095 1096 1097
        virReportError(VIR_ERR_RPC,
                       _("unexpected zero/negative length request %lld"),
                       (long long int)(client->rx->bufferLength - client->rx->bufferOffset));
1098 1099 1100 1101 1102 1103 1104 1105 1106 1107 1108 1109 1110 1111 1112 1113 1114 1115 1116 1117 1118 1119
        client->wantClose = true;
        return -1;
    }

    ret = virNetSocketRead(client->sock,
                           client->rx->buffer + client->rx->bufferOffset,
                           client->rx->bufferLength - client->rx->bufferOffset);

    if (ret <= 0)
        return ret;

    client->rx->bufferOffset += ret;
    return ret;
}


/*
 * Read data until we get a complete message to process
 */
static void virNetServerClientDispatchRead(virNetServerClientPtr client)
{
readmore:
1120 1121 1122 1123 1124
    if (client->rx->nfds == 0) {
        if (virNetServerClientRead(client) < 0) {
            client->wantClose = true;
            return; /* Error */
        }
1125 1126 1127 1128 1129 1130 1131
    }

    if (client->rx->bufferOffset < client->rx->bufferLength)
        return; /* Still not read enough */

    /* Either done with length word header */
    if (client->rx->bufferLength == VIR_NET_MESSAGE_LEN_MAX) {
1132 1133
        if (virNetMessageDecodeLength(client->rx) < 0) {
            client->wantClose = true;
1134
            return;
1135
        }
1136 1137 1138 1139 1140 1141 1142 1143 1144

        virNetServerClientUpdateEvent(client);

        /* Try and read payload immediately instead of going back
           into poll() because chances are the data is already
           waiting for us */
        goto readmore;
    } else {
        /* Grab the completed message */
1145
        virNetMessagePtr msg = client->rx;
1146
        virNetMessagePtr response = NULL;
1147
        virNetServerClientFilterPtr filter;
1148
        size_t i;
1149 1150 1151

        /* Decode the header so we can use it for routing decisions */
        if (virNetMessageDecodeHeader(msg) < 0) {
1152
            virNetMessageQueueServe(&client->rx);
1153 1154 1155 1156 1157
            virNetMessageFree(msg);
            client->wantClose = true;
            return;
        }

1158 1159
        /* Now figure out if we need to read more data to get some
         * file descriptors */
1160 1161
        if (msg->header.type == VIR_NET_CALL_WITH_FDS &&
            virNetMessageDecodeNumFDs(msg) < 0) {
1162
            virNetMessageQueueServe(&client->rx);
1163 1164
            virNetMessageFree(msg);
            client->wantClose = true;
1165
            return; /* Error */
1166
        }
1167 1168

        /* Try getting the file descriptors (may fail if blocking) */
1169
        for (i = msg->donefds; i < msg->nfds; i++) {
1170 1171
            int rv;
            if ((rv = virNetSocketRecvFD(client->sock, &(msg->fds[i]))) < 0) {
1172
                virNetMessageQueueServe(&client->rx);
1173 1174 1175 1176
                virNetMessageFree(msg);
                client->wantClose = true;
                return;
            }
1177 1178 1179 1180 1181 1182 1183 1184 1185 1186 1187 1188 1189
            if (rv == 0) /* Blocking */
                break;
            msg->donefds++;
        }

        /* Need to poll() until FDs arrive */
        if (msg->donefds < msg->nfds) {
            /* Because DecodeHeader/NumFDs reset bufferOffset, we
             * put it back to what it was, so everything works
             * again next time we run this method
             */
            client->rx->bufferOffset = client->rx->bufferLength;
            return;
1190 1191
        }

1192 1193
        /* Definitely finished reading, so remove from queue */
        virNetMessageQueueServe(&client->rx);
1194 1195 1196 1197 1198 1199
        PROBE(RPC_SERVER_CLIENT_MSG_RX,
              "client=%p len=%zu prog=%u vers=%u proc=%u type=%u status=%u serial=%u",
              client, msg->bufferLength,
              msg->header.prog, msg->header.vers, msg->header.proc,
              msg->header.type, msg->header.status, msg->header.serial);

1200 1201 1202 1203 1204 1205 1206 1207 1208 1209
        if (virKeepAliveCheckMessage(client->keepalive, msg, &response)) {
            virNetMessageFree(msg);
            client->nrequests--;
            msg = NULL;

            if (response &&
                virNetServerClientSendMessageLocked(client, response) < 0)
                virNetMessageFree(response);
        }

1210
        /* Maybe send off for queue against a filter */
1211 1212 1213 1214 1215 1216 1217 1218 1219 1220 1221 1222 1223 1224 1225
        if (msg) {
            filter = client->filters;
            while (filter) {
                int ret = filter->func(client, msg, filter->opaque);
                if (ret < 0) {
                    virNetMessageFree(msg);
                    msg = NULL;
                    if (ret < 0)
                        client->wantClose = true;
                    break;
                }
                if (ret > 0) {
                    msg = NULL;
                    break;
                }
1226

1227 1228
                filter = filter->next;
            }
1229 1230 1231 1232
        }

        /* Send off to for normal dispatch to workers */
        if (msg) {
1233
            virObjectRef(client);
1234 1235 1236 1237
            if (!client->dispatchFunc ||
                client->dispatchFunc(client, msg, client->dispatchOpaque) < 0) {
                virNetMessageFree(msg);
                client->wantClose = true;
1238
                virObjectUnref(client);
1239 1240 1241 1242 1243 1244
                return;
            }
        }

        /* Possibly need to create another receive buffer */
        if (client->nrequests < client->nrequests_max) {
1245
            if (!(client->rx = virNetMessageNew(true))) {
1246
                client->wantClose = true;
E
Eric Blake 已提交
1247 1248
            } else {
                client->rx->bufferLength = VIR_NET_MESSAGE_LEN_MAX;
1249 1250 1251 1252 1253 1254 1255
                if (VIR_ALLOC_N(client->rx->buffer,
                                client->rx->bufferLength) < 0) {
                    virReportOOMError();
                    client->wantClose = true;
                } else {
                    client->nrequests++;
                }
1256 1257 1258 1259 1260 1261 1262 1263 1264 1265 1266 1267 1268 1269 1270 1271 1272 1273 1274 1275
            }
        }
        virNetServerClientUpdateEvent(client);
    }
}


/*
 * Send client->tx using no encoding
 *
 * Returns:
 *   -1 on error or EOF
 *    0 on EAGAIN
 *    n number of bytes
 */
static ssize_t virNetServerClientWrite(virNetServerClientPtr client)
{
    ssize_t ret;

    if (client->tx->bufferLength < client->tx->bufferOffset) {
1276 1277 1278
        virReportError(VIR_ERR_RPC,
                       _("unexpected zero/negative length request %lld"),
                       (long long int)(client->tx->bufferLength - client->tx->bufferOffset));
1279 1280 1281 1282 1283 1284 1285 1286 1287 1288 1289 1290 1291 1292 1293 1294 1295 1296 1297 1298 1299 1300 1301 1302 1303 1304
        client->wantClose = true;
        return -1;
    }

    if (client->tx->bufferLength == client->tx->bufferOffset)
        return 1;

    ret = virNetSocketWrite(client->sock,
                            client->tx->buffer + client->tx->bufferOffset,
                            client->tx->bufferLength - client->tx->bufferOffset);
    if (ret <= 0)
        return ret; /* -1 error, 0 = egain */

    client->tx->bufferOffset += ret;
    return ret;
}


/*
 * Process all queued client->tx messages until
 * we would block on I/O
 */
static void
virNetServerClientDispatchWrite(virNetServerClientPtr client)
{
    while (client->tx) {
1305 1306 1307 1308 1309 1310 1311 1312 1313
        if (client->tx->bufferOffset < client->tx->bufferLength) {
            ssize_t ret;
            ret = virNetServerClientWrite(client);
            if (ret < 0) {
                client->wantClose = true;
                return;
            }
            if (ret == 0)
                return; /* Would block on write EAGAIN */
1314 1315 1316 1317
        }

        if (client->tx->bufferOffset == client->tx->bufferLength) {
            virNetMessagePtr msg;
1318 1319
            size_t i;

1320
            for (i = client->tx->donefds; i < client->tx->nfds; i++) {
1321 1322
                int rv;
                if ((rv = virNetSocketSendFD(client->sock, client->tx->fds[i])) < 0) {
1323 1324 1325
                    client->wantClose = true;
                    return;
                }
1326 1327 1328
                if (rv == 0) /* Blocking */
                    return;
                client->tx->donefds++;
1329 1330
            }

1331
#if WITH_SASL
1332 1333 1334 1335 1336
            /* Completed this 'tx' operation, so now read for all
             * future rx/tx to be under a SASL SSF layer
             */
            if (client->sasl) {
                virNetSocketSetSASLSession(client->sock, client->sasl);
1337
                virObjectUnref(client->sasl);
1338 1339 1340 1341 1342 1343 1344
                client->sasl = NULL;
            }
#endif

            /* Get finished msg from head of tx queue */
            msg = virNetMessageQueueServe(&client->tx);

1345
            if (msg->tracked) {
1346 1347 1348 1349 1350
                client->nrequests--;
                /* See if the recv queue is currently throttled */
                if (!client->rx &&
                    client->nrequests < client->nrequests_max) {
                    /* Ready to recv more messages */
1351
                    virNetMessageClear(msg);
1352 1353 1354 1355 1356 1357
                    msg->bufferLength = VIR_NET_MESSAGE_LEN_MAX;
                    if (VIR_ALLOC_N(msg->buffer, msg->bufferLength) < 0) {
                        virReportOOMError();
                        virNetMessageFree(msg);
                        return;
                    }
1358 1359 1360 1361 1362 1363 1364 1365 1366
                    client->rx = msg;
                    msg = NULL;
                    client->nrequests++;
                }
            }

            virNetMessageFree(msg);

            virNetServerClientUpdateEvent(client);
1367 1368 1369

            if (client->delayedClose)
                client->wantClose = true;
1370 1371 1372 1373
         }
    }
}

1374

1375
#if WITH_GNUTLS
1376 1377 1378 1379 1380 1381 1382 1383 1384 1385 1386 1387 1388 1389 1390 1391
static void
virNetServerClientDispatchHandshake(virNetServerClientPtr client)
{
    int ret;
    /* Continue the handshake. */
    ret = virNetTLSSessionHandshake(client->tls);
    if (ret == 0) {
        /* Finished.  Next step is to check the certificate. */
        if (virNetServerClientCheckAccess(client) < 0)
            client->wantClose = true;
        else
            virNetServerClientUpdateEvent(client);
    } else if (ret > 0) {
        /* Carry on waiting for more handshake. Update
           the events just in case handshake data flow
           direction has changed */
1392
        virNetServerClientUpdateEvent(client);
1393 1394 1395 1396 1397
    } else {
        /* Fatal error in handshake */
        client->wantClose = true;
    }
}
1398
#endif
1399 1400 1401 1402 1403 1404

static void
virNetServerClientDispatchEvent(virNetSocketPtr sock, int events, void *opaque)
{
    virNetServerClientPtr client = opaque;

1405
    virObjectLock(client);
1406 1407 1408

    if (client->sock != sock) {
        virNetSocketRemoveIOCallback(sock);
1409
        virObjectUnlock(client);
1410 1411 1412 1413 1414
        return;
    }

    if (events & (VIR_EVENT_HANDLE_WRITABLE |
                  VIR_EVENT_HANDLE_READABLE)) {
1415
#if WITH_GNUTLS
1416 1417 1418 1419 1420
        if (client->tls &&
            virNetTLSSessionGetHandshakeStatus(client->tls) !=
            VIR_NET_TLS_HANDSHAKE_COMPLETE) {
            virNetServerClientDispatchHandshake(client);
        } else {
1421
#endif
1422 1423
            if (events & VIR_EVENT_HANDLE_WRITABLE)
                virNetServerClientDispatchWrite(client);
M
Michal Privoznik 已提交
1424 1425
            if (events & VIR_EVENT_HANDLE_READABLE &&
                client->rx)
1426
                virNetServerClientDispatchRead(client);
1427
#if WITH_GNUTLS
1428
        }
1429
#endif
1430 1431 1432 1433 1434 1435 1436 1437
    }

    /* NB, will get HANGUP + READABLE at same time upon
     * disconnect */
    if (events & (VIR_EVENT_HANDLE_ERROR |
                  VIR_EVENT_HANDLE_HANGUP))
        client->wantClose = true;

1438
    virObjectUnlock(client);
1439 1440 1441
}


1442 1443 1444
static int
virNetServerClientSendMessageLocked(virNetServerClientPtr client,
                                    virNetMessagePtr msg)
1445 1446 1447 1448 1449
{
    int ret = -1;
    VIR_DEBUG("msg=%p proc=%d len=%zu offset=%zu",
              msg, msg->header.proc,
              msg->bufferLength, msg->bufferOffset);
1450

1451
    msg->donefds = 0;
1452
    if (client->sock && !client->wantClose) {
1453 1454 1455 1456 1457
        PROBE(RPC_SERVER_CLIENT_MSG_TX_QUEUE,
              "client=%p len=%zu prog=%u vers=%u proc=%u type=%u status=%u serial=%u",
              client, msg->bufferLength,
              msg->header.prog, msg->header.vers, msg->header.proc,
              msg->header.type, msg->header.status, msg->header.serial);
1458 1459 1460 1461 1462 1463
        virNetMessageQueuePush(&client->tx, msg);

        virNetServerClientUpdateEvent(client);
        ret = 0;
    }

1464 1465 1466 1467 1468 1469 1470 1471
    return ret;
}

int virNetServerClientSendMessage(virNetServerClientPtr client,
                                  virNetMessagePtr msg)
{
    int ret;

1472
    virObjectLock(client);
1473
    ret = virNetServerClientSendMessageLocked(client, msg);
1474
    virObjectUnlock(client);
1475

1476 1477 1478 1479 1480 1481 1482
    return ret;
}


bool virNetServerClientNeedAuth(virNetServerClientPtr client)
{
    bool need = false;
1483
    virObjectLock(client);
1484
    if (client->auth)
1485
        need = true;
1486
    virObjectUnlock(client);
1487 1488
    return need;
}
1489 1490 1491 1492 1493 1494 1495 1496 1497 1498 1499 1500 1501 1502 1503 1504 1505 1506 1507 1508 1509 1510 1511 1512


static void
virNetServerClientKeepAliveDeadCB(void *opaque)
{
    virNetServerClientImmediateClose(opaque);
}

static int
virNetServerClientKeepAliveSendCB(void *opaque,
                                  virNetMessagePtr msg)
{
    return virNetServerClientSendMessage(opaque, msg);
}


int
virNetServerClientInitKeepAlive(virNetServerClientPtr client,
                                int interval,
                                unsigned int count)
{
    virKeepAlivePtr ka;
    int ret = -1;

1513
    virObjectLock(client);
1514 1515 1516 1517

    if (!(ka = virKeepAliveNew(interval, count, client,
                               virNetServerClientKeepAliveSendCB,
                               virNetServerClientKeepAliveDeadCB,
1518
                               virObjectFreeCallback)))
1519 1520
        goto cleanup;
    /* keepalive object has a reference to client */
1521
    virObjectRef(client);
1522 1523 1524 1525

    client->keepalive = ka;

cleanup:
1526
    virObjectUnlock(client);
1527 1528 1529 1530 1531 1532 1533 1534

    return ret;
}

int
virNetServerClientStartKeepAlive(virNetServerClientPtr client)
{
    int ret;
1535
    virObjectLock(client);
1536
    ret = virKeepAliveStart(client->keepalive, 0, 0);
1537
    virObjectUnlock(client);
1538 1539
    return ret;
}