1. 17 6月, 2007 1 次提交
    • D
      fix radeon setparam on 32/64 systems, harder. · f4d27817
      David Woodhouse 提交于
      Commit 9b01bd5b introduced a
      compat_ioctl handler for RADEON_SETPARAM, the sole purpose of which was
      to handle the fact that on i386, alignof(uint64_t)==4.
      
      Unfortunately, this handler was installed for _all_ 64-bit
      architectures, instead of only x86_64 and ia64.  And thus it breaks
      32-bit compatibility on every other arch, where 64-bit integers are
      aligned to 8 bytes in 32-bit mode just the same as in 64-bit mode.
      
      Arnd has a cunning plan to use 'compat_u64' with appropriate alignment
      attributes according to the 32-bit ABI, but for now let's just make the
      compat_radeon_cp_setparam routine entirely disappear on 64-bit machines
      whose 32-bit compat support isn't for i386.  It would be a no-op with
      compat_u64 anyway.
      Signed-off-by: NDavid Woodhouse <dwmw2@infradead.org>
      Acked-by: NArnd Bergmann <arnd@arndb.de>
      Cc: Benjamin Herrenschmidt <benh@kernel.crashing.org>
      Cc: Dave Airlie <airlied@gmail.com>
      Signed-off-by: NLinus Torvalds <torvalds@linux-foundation.org>
      f4d27817
  2. 16 6月, 2007 14 次提交
  3. 15 6月, 2007 23 次提交
  4. 14 6月, 2007 2 次提交