Skip to content

K
Kernel

openeuler / Kernel
1 年多 前同步成功

通知 8
Star 0
Fork 0
K
Kernel
切换分支/标签
  1. 18 7月, 2017 3 次提交
  3. 11 10月, 2016 5 次提交
  5. 22 7月, 2016 1 次提交
  7. 29 4月, 2016 2 次提交
  9. 14 3月, 2016 1 次提交
  11. 14 9月, 2015 1 次提交
    • T
      drm/vmwgfx: Fix up user_dmabuf refcounting · 54c12bc3
      由 Thomas Hellstrom 提交于 
      If user space calls unreference on a user_dmabuf it will typically
kill the struct ttm_base_object member which is responsible for the
user-space visibility. However the dmabuf part may still be alive and
refcounted. In some situations, like for shared guest-backed surface
referencing/opening, the driver may try to reference the
struct ttm_base_object member again, causing an immediate kernel warning
and a later kernel NULL pointer dereference.

Fix this by always maintaining a reference on the struct
ttm_base_object member, in situations where it might subsequently be
referenced.

Cc: <stable@vger.kernel.org>
Signed-off-by: NThomas Hellstrom <thellstrom@vmware.com>
Reviewed-by: NBrian Paul <brianp@vmware.com>
Reviewed-by: NSinclair Yeh <syeh@vmware.com>
      54c12bc3
  13. 14 8月, 2015 1 次提交
    • T
      drm/vmwgfx: Fix execbuf locking issues · 3e04e2fe
      由 Thomas Hellstrom 提交于 
      This addresses two issues that cause problems with viewperf maya-03 in
situation with memory pressure.

The first issue causes attempts to unreserve buffers if batched
reservation fails due to, for example, a signal pending. While previously
the ttm_eu api was resistant against this type of error, it is no longer
and the lockdep code will complain about attempting to unreserve buffers
that are not reserved. The issue is resolved by avoid calling
ttm_eu_backoff_reservation in the buffer reserve error path.

The second issue is that the binding_mutex may be held when user-space
fence objects are created and hence during memory reclaims. This may cause
recursive attempts to grab the binding mutex. The issue is resolved by not
holding the binding mutex across fence creation and submission.
Signed-off-by: NThomas Hellstrom <thellstrom@vmware.com>
Reviewed-by: NSinclair Yeh <syeh@vmware.com>
Cc: <stable@vger.kernel.org>
Signed-off-by: NDave Airlie <airlied@redhat.com>
      3e04e2fe
  15. 13 8月, 2015 5 次提交
  17. 05 8月, 2015 7 次提交
  19. 12 3月, 2015 2 次提交
    • C
      drm/vmwgfx: Correctly NULLify dma buffer pointer on failure · da5efffc
      由 Colin Ian King 提交于 
      cppcheck on lines 917 and 977 show an ineffective assignment
to the dma buffer pointer:

[drivers/gpu/drm/vmwgfx/vmwgfx_execbuf.c:917]:
[drivers/gpu/drm/vmwgfx/vmwgfx_execbuf.c:977]:
  (warning) Assignment of function parameter has no effect
  outside the function. Did you forget dereferencing it?

On a successful DMA buffer lookup, the dma buffer pointer is
assigned, however, on failure it currently is left in an
undefined state.

The original intention in the error exit path was to nullify
the pointer on an error (which the original code failed to
do properly). This patch fixes this also ensures all failure
paths nullify the buffer pointer on the error return.

Fortunately the callers to vmw_translate_mob_ptr and
vmw_translate_guest_ptr are checking on a return status and not
on the dma buffer pointer, so the original code worked.
Reviewed-by: NThomas Hellstrom <thellstrom@vmware.com>
Signed-off-by: NColin Ian King <colin.king@canonical.com>
      da5efffc
    • T
      drm/vmwgfx: Fix a couple of lock dependency violations · 5151adb3
      由 Thomas Hellstrom 提交于 
      Experimental lockdep annotation added to the TTM lock has unveiled a
couple of lock dependency violations in the vmwgfx driver. In both
cases it turns out that the device_private::reservation_sem is not
needed so the offending code is moved out of that lock.

Cc: <stable@vger.kernel.org>
Acked-by: NSinclair Yeh <syeh@vmware.com>
Signed-off-by: NThomas Hellstrom <thellstrom@vmware.com>
      5151adb3
  21. 04 12月, 2014 1 次提交
  23. 11 9月, 2014 1 次提交
  25. 02 9月, 2014 2 次提交
  27. 01 9月, 2014 3 次提交
  29. 04 7月, 2014 1 次提交
  31. 24 4月, 2014 1 次提交
  33. 28 3月, 2014 1 次提交
  35. 13 2月, 2014 1 次提交
  37. 12 2月, 2014 1 次提交