1. 08 10月, 2018 37 次提交
  2. 18 9月, 2018 1 次提交
  3. 05 9月, 2018 1 次提交
    • J
      mmc: meson-mx-sdio: fix OF child-node lookup · c483a5cc
      Johan Hovold 提交于
      Use the new of_get_compatible_child() helper to lookup the slot child
      node instead of using of_find_compatible_node(), which searches the
      entire tree from a given start node and thus can return an unrelated
      (i.e. non-child) node.
      
      This also addresses a potential use-after-free (e.g. after probe
      deferral) as the tree-wide helper drops a reference to its first
      argument (i.e. the node of the device being probed).
      
      While at it, also fix up the related slot-node reference leak.
      
      Fixes: ed80a13b ("mmc: meson-mx-sdio: Add a driver for the Amlogic Meson8 and Meson8b SoCs")
      Cc: stable <stable@vger.kernel.org>     # 4.15
      Cc: Carlo Caione <carlo@endlessm.com>
      Cc: Martin Blumenstingl <martin.blumenstingl@googlemail.com>
      Cc: Ulf Hansson <ulf.hansson@linaro.org>
      Acked-by: NMartin Blumenstingl <martin.blumenstingl@googlemail.com>
      Signed-off-by: NJohan Hovold <johan@kernel.org>
      Signed-off-by: NUlf Hansson <ulf.hansson@linaro.org>
      c483a5cc
  4. 04 9月, 2018 1 次提交
    • A
      mmc: omap_hsmmc: fix wakeirq handling on removal · 3c398f3c
      Andreas Kemnade 提交于
      after unbinding mmc I get things like this:
      [  185.294067] mmc1: card 0001 removed
      [  185.305206] omap_hsmmc 480b4000.mmc: wake IRQ with no resume: -13
      
      The wakeirq stays in /proc-interrupts
      
      rebinding shows this:
      [  289.795959] genirq: Flags mismatch irq 112. 0000200a (480b4000.mmc:wakeup) vs. 0000200a (480b4000.mmc:wakeup)
      [  289.808959] omap_hsmmc 480b4000.mmc: Unable to request wake IRQ
      [  289.815338] omap_hsmmc 480b4000.mmc: no SDIO IRQ support, falling back to polling
      
      That bug seems to be introduced by switching from devm_request_irq()
      to generic wakeirq handling.
      
      So let us cleanup at removal.
      Signed-off-by: NAndreas Kemnade <andreas@kemnade.info>
      Fixes: 5b83b223 ("mmc: omap_hsmmc: Change wake-up interrupt to use generic wakeirq")
      Cc: stable@vger.kernel.org # v4.2+
      Signed-off-by: NUlf Hansson <ulf.hansson@linaro.org>
      3c398f3c