whitespace pedantry
Signed-off-by: NStefan Richter <stefanr@s5r6.in-berlin.de>

If "modprobe ohci1394" was quickly followed by "modprobe -r ohci1394",
say with 1 second pause in between, the modprobe -r got stuck in
uninterruptible sleep in kthread_stop.  At the same time the knodemgrd
slept uninterruptibly in bus_rescan_devices_helper.  That's because
driver_detach took the semaphore of the PCI device and
bus_rescan_devices_helper wanted to take the semaphore of the FireWire
host device's parent, which is the same semaphore. This was a regression
since Linux 2.6.16, commit bf74ad5b,
"Hold the device's parent's lock during probe and remove".

The fix (or workaround) adds a dummy driver to the hpsb_host device. Now
bus_rescan_devices_helper won't scan the host device anymore.  This
doesn't hurt since we have no drivers which will bind to these devices
and it is unlikely that there will ever be such a driver.  The dummy
driver is befittingly presented as a representation of ieee1394 itself.

Fixes: http://bugzilla.kernel.org/show_bug.cgi?id=6706Signed-off-by: NStefan Richter <stefanr@s5r6.in-berlin.de>

Signed-off-by: NStefan Richter <stefanr@s5r6.in-berlin.de>

A signed single-bit bitfield doesn't make much sense. Make it unsigned.
Signed-off-by: NLuca Tettamanti <kronos.it@gmail.com>
Signed-off-by: NStefan Richter <stefanr@s5r6.in-berlin.de>

There is no manpower available to reform oui.db into a library for use
in more kernel subsystems.  The low ratio of usefulness to size and the
occasional need to update oui.db from IEEE's official list suggest to
drop oui.db.  I plan to make a userspace script available which
translates the remaining numeric sysfs attributes to names of
organizations.
Signed-off-by: NStefan Richter <stefanr@s5r6.in-berlin.de>

This also means that former parts of ieee1394's API will be subject to
change or removal.
Signed-off-by: NStefan Richter <stefanr@s5r6.in-berlin.de>

Signed-off-by: NStefan Richter <stefanr@s5r6.in-berlin.de>

Known to be affected:
 - libdc1394: prefers video1394 for now, old-style raw1394 support might
   be dropped eventually
 - OpenH323 PWLib, AVC video input module: uses libraw1394's old API
Signed-off-by: NStefan Richter <stefanr@s5r6.in-berlin.de>

There has been an if(...) missing, for ages.
Signed-off-by: NStefan Richter <stefanr@s5r6.in-berlin.de>

Adjust whitespace and line lengths
Signed-off-by: NStefan Richter <stefanr@s5r6.in-berlin.de>

Fixes http://bugzilla.kernel.org/show_bug.cgi?id=7431
iBook G3 threw a machine check exception and put the display backlight
to full brightness after ohci1394 was unloaded and reloaded.
Signed-off-by: NStefan Richter <stefanr@s5r6.in-berlin.de>

Move the body of a function into its only caller.
Signed-off-by: NStefan Richter <stefanr@s5r6.in-berlin.de>

Some people actually look at those comments.
Signed-off-by: NStefan Richter <stefanr@s5r6.in-berlin.de>

It's OK to reorder list_del() and sbp2util_free_command_dma() here.
Signed-off-by: NStefan Richter <stefanr@s5r6.in-berlin.de>

"struct scsi_id_instance_data" represents a logical unit.
Rename it to "struct sbp2_lu", and "scsi_id" to "lu".
Rename some other variables too.
Wrap almost all lines after at most 80 columns.
Signed-off-by: NStefan Richter <stefanr@s5r6.in-berlin.de>

Signed-off-by: NStefan Richter <stefanr@s5r6.in-berlin.de>

It's 2^20 bit/s, not 0.001 bit.
Signed-off-by: NStefan Richter <stefanr@s5r6.in-berlin.de>

Prepend sbp2*_ to anything globally defined in sbp2.c except for some
macros.  Strip sbp2_ from names of struct members.
Signed-off-by: NStefan Richter <stefanr@s5r6.in-berlin.de>

Signed-off-by: NStefan Richter <stefanr@s5r6.in-berlin.de>

And update and reformat remaining comments.
Signed-off-by: NStefan Richter <stefanr@s5r6.in-berlin.de>

This work is not delayed.

Also bring the code format in a state which reduces my work to merge
pending sbp2 patchs.
Signed-off-by: NStefan Richter <stefanr@s5r6.in-berlin.de>

Adjust parentheses, indentation, line lengths.
Signed-off-by: NStefan Richter <stefanr@s5r6.in-berlin.de>

No need to keep them in released sources.
Signed-off-by: NStefan Richter <stefanr@s5r6.in-berlin.de>

Replace some calls to SBP2_ERR and SBP2_WARN by SBP2_INFO.
Remove logging macros SBP2_NOTICE and SBP2_WARN.
Remove direct usage of HPSB_ logging macros.
Signed-off-by: NStefan Richter <stefanr@s5r6.in-berlin.de>

The same case is handled further below in sbp2scsi_complete_command.
Note, the second version behaves slightly different but looks
preferable.  It's an extremely unlikely case by the way.
Signed-off-by: NStefan Richter <stefanr@s5r6.in-berlin.de>

This has been within #if 0 for a long time and is wrong anyway.
Signed-off-by: NStefan Richter <stefanr@s5r6.in-berlin.de>

Remove unnecessary function prototypes.
Remove variable names from function prototypes.
Move declarations from sbp2.h to sbp2.c.
Move definitions of driver templates together near the top of sbp2.c.
Signed-off-by: NStefan Richter <stefanr@s5r6.in-berlin.de>

The queue depth can be read from /sys/bus/scsi/devices/*/queue_depth,
so don't log it.  And the hint about speed improvements is misleading,
at least under current kernels.  If serialization is switched off, read
performance is typically increased by less than 10%.  (I did not test
write performance recently.)  On the other hand, serialize_io=0 is not
yet safe due to some implementation issues that are not trivial to fix.
Signed-off-by: NStefan Richter <stefanr@s5r6.in-berlin.de>

To print irq number no need to transform to string using %d, then print
using %s. Just use %d.
Signed-off-by: NAlexey Dobriyan <adobriyan@gmail.com>

This happens.  No need to log a BUG trace.
Signed-off-by: NStefan Richter <stefanr@s5r6.in-berlin.de>

Signed-off-by: NEric Sesterhenn <snakebyte@gmx.de>
Signed-off-by: NAlexey Dobriyan <adobriyan@gmail.com>
Signed-off-by: NStefan Richter <stefanr@s5r6.in-berlin.de>

 - correct thinko in one of my last commits: cannot use PRINT macro with
   ohci == NULL
 - add log messages on ohci == NULL and on pci_enable_device != 0
 - update log macros from patch "revert fail on error in suspend" to use
   PRINT and DBGMSG where possible
Signed-off-by: NStefan Richter <stefanr@s5r6.in-berlin.de>

Some errors during preparation for suspended state can be skipped with a
warning instead of a failure of the whole suspend transition, notably an
error in pci_set_power_state.
Signed-off-by: NStefan Richter <stefanr@s5r6.in-berlin.de>

Only build IEEE1394 OUI database files if the config option is enabled.
Signed-off-by: NRandy Dunlap <randy.dunlap@oracle.com>
Signed-off-by: NStefan Richter <stefanr@s5r6.in-berlin.de>

Fix printk format warning:
drivers/ieee1394/nodemgr.c:364: warning: long long unsigned int format, u64 arg (arg 3)
Signed-off-by: NRandy Dunlap <randy.dunlap@oracle.com>
Signed-off-by: NStefan Richter <stefanr@s5r6.in-berlin.de>

 - The list "struct class.children" is supposed to be protected by
   class.sem, not by class.subsys.rwsem.

 - nodemgr_remove_uds() iterated over nodemgr_ud_class.children without
   proper protection.  This was never observed as a bug since the code
   is usually only accessed by knodemgrd.  All knodemgrds are currently
   globally serialized.  But userspace can trigger this code too by
   writing to /sys/bus/ieee1394/destroy_node.

 - Clean up access to the FireWire bus type's subsys.rwsem:  Access it
   uniformly via ieee1394_bus_type.  Shrink rwsem protected regions
   where possible.  Expand them where necessary.  The latter wasn't a
   problem so far because knodemgr is globally serialized.

This should harden the interaction of ieee1394 with sysfs and lay ground
for deserialized operation of multiple knodemgrds and for implementation
of subthreads for parallelized scanning and probing.
Signed-off-by: NStefan Richter <stefanr@s5r6.in-berlin.de>

Give better names to local variables.
Signed-off-by: NStefan Richter <stefanr@s5r6.in-berlin.de>

One hunk in "ieee1394: handle sysfs errors" was wrong.
Signed-off-by: NStefan Richter <stefanr@s5r6.in-berlin.de>

Purges the one remaining call to lock_kernel() from the 1394 subsystem.
Signed-off-by: NStefan Richter <stefanr@s5r6.in-berlin.de>

video1394 does not need to take the BKL. The data structures shared between
file_operations and interrupts are already protected through context-specific
spinlocks.

The only other danger is video1394_release() being called during another
operation, however this cannot happen because release is only ever invoked
when the last thread has closed the fd.
Signed-off-by: NDaniel Drake <ddrake@brontes3d.com>
Signed-off-by: NStefan Richter <stefanr@s5r6.in-berlin.de>