1. 06 4月, 2019 1 次提交
    • O
      habanalabs: prevent device PTE read/write during hard-reset · 9f201aba
      Oded Gabbay 提交于
      During hard-reset, contexts are closed as part of the tear-down process.
      After a context is closed, the driver cleans up the page tables of that
      context in the device's DRAM. This action is both dangerous and
      unnecessary.
      
      It is unnecessary, because the device is going through a hard-reset, which
      means the device's DRAM contents are no longer valid and the device's MMU
      is being reset.
      
      It is dangerous, because if the hard-reset came as a result of a PCI
      freeze, this action may cause the entire host machine to hang.
      
      Therefore, prevent all device PTE updates when a hard-reset operation is
      pending.
      Signed-off-by: NOded Gabbay <oded.gabbay@gmail.com>
      9f201aba
  2. 02 4月, 2019 3 次提交
    • O
      habanalabs: refactoring in goya.c · bedd1442
      Oded Gabbay 提交于
      This patch does some refactoring in goya.c to make code more reusable
      between goya code and the goya simulator code (which is not upstreamed).
      
      In addition, the patch removes some dead functions from goya.c which are
      not used by the current upstream code
      Signed-off-by: NOded Gabbay <oded.gabbay@gmail.com>
      bedd1442
    • O
      habanalabs: add goya implementation for debug configuration · 8ba2876d
      Omer Shpigelman 提交于
      This patch adds the ASIC-specific function for GOYA to configure the
      coresight components.
      
      Most of the components have an enabled/disabled flag, depending on whether
      the user wants to enable the component or disable it.
      
      For some of the components, such as ETR and SPMU, the user can also
      request to read values from them. Those values are needed for the user to
      parse the trace data.
      
      The ETR configuration is also checked for security purposes, to make sure
      the trace data is written to the device's DRAM.
      Signed-off-by: NOmer Shpigelman <oshpigelman@habana.ai>
      Signed-off-by: NOded Gabbay <oded.gabbay@gmail.com>
      8ba2876d
    • O
      habanalabs: add new IOCTL for debug, tracing and profiling · 315bc055
      Omer Shpigelman 提交于
      Habanalabs ASICs use the ARM coresight infrastructure to support debug,
      tracing and profiling of neural networks topologies.
      
      Because the coresight is configured using register writes and reads, and
      some of the registers hold sensitive information (e.g. the address in
      the device's DRAM where the trace data is written to), the user must go
      through the kernel driver to configure this mechanism.
      
      This patch implements the common code of the IOCTL and calls the
      ASIC-specific function for the actual H/W configuration.
      
      The IOCTL supports configuration of seven coresight components:
      ETR, ETF, STM, FUNNEL, BMON, SPMU and TIMESTAMP
      
      The user specifies which component he wishes to configure and provides a
      pointer to a structure (located in its process space) that contains the
      relevant configuration.
      
      The common code copies the relevant data from the user-space to kernel
      space and then calls the ASIC-specific function to do the H/W
      configuration.
      
      After the configuration is done, which is usually composed
      of several IOCTL calls depending on what the user wanted to trace, the
      user can start executing the topology. The trace data will be written to
      the user's area in the device's DRAM.
      
      After the tracing operation is complete, and user will call the IOCTL
      again to disable the tracing operation. The user also need to read
      values from registers for some of the components (e.g. the size of the
      trace data in the device's DRAM). In that case, the user will provide a
      pointer to an "output" structure in user-space, which the IOCTL code will
      fill according the to selected component.
      Signed-off-by: NOmer Shpigelman <oshpigelman@habana.ai>
      Signed-off-by: NOded Gabbay <oded.gabbay@gmail.com>
      315bc055
  3. 20 3月, 2019 1 次提交
  4. 08 3月, 2019 1 次提交
    • O
      habanalabs: keep track of the device's dma mask · d9973871
      Oded Gabbay 提交于
      This patch refactors the code that is responsible to set the DMA mask for
      the device.
      
      Upon each change of the dma mask, the driver will save the new value that
      was set. This is needed in order to make sure we don't try to increase the
      mask a second time, in case we failed in the first time. This is
      especially relevant for Power machines, as that may cause a change in
      configuration of the TVT which will break the device.
      
      Goya will first try to set the device's dma mask to 39 bits, so that the
      memory that is allocated on the host machine for communication with the
      device's cpu will be in a bus address which is lower then 39 bits. Later,
      Goya will try to increase that mask to 48 bits, but only if setting the
      mask to 39 bits was successful.
      Signed-off-by: NOded Gabbay <oded.gabbay@gmail.com>
      d9973871
  5. 07 3月, 2019 1 次提交
  6. 06 3月, 2019 1 次提交
  7. 05 3月, 2019 1 次提交
  8. 04 3月, 2019 2 次提交
  9. 24 2月, 2019 2 次提交
  10. 03 3月, 2019 1 次提交
    • O
      habanalabs: cast to expected type · 7c22278e
      Oded Gabbay 提交于
      This patch fix the following sparse warning:
      
      drivers/misc/habanalabs/goya/goya.c:3646:14: warning: incorrect type in
      assignment (different address spaces)
      drivers/misc/habanalabs/goya/goya.c:3646:14:    expected void *base
      drivers/misc/habanalabs/goya/goya.c:3646:14:    got void [noderef] <asn:2> *
      Signed-off-by: NOded Gabbay <oded.gabbay@gmail.com>
      7c22278e
  11. 04 3月, 2019 1 次提交
    • O
      habanalabs: prevent host crash during suspend/resume · 7cb5101e
      Oded Gabbay 提交于
      This patch fixes the implementation of suspend/resume of the device so that
      upon resume of the device, the host won't crash due to PCI completion
      timeout.
      
      Upon suspend, the device is being reset due to PERST. Therefore, upon
      resume, the driver must initialize the PCI controller as if the driver was
      loaded. If the controller is not initialized and the device tries to
      access the device through the PCI bars, the host will crash with PCI
      completion timeout error.
      Signed-off-by: NOded Gabbay <oded.gabbay@gmail.com>
      7cb5101e
  12. 02 3月, 2019 1 次提交
  13. 28 2月, 2019 10 次提交
  14. 27 2月, 2019 1 次提交
    • O
      habanalabs: make functions static or declare them · 5e6e0239
      Oded Gabbay 提交于
      This patch fixes the below sparse warnings by either making the functions
      static or by adding a declaration in the relevant header file.
      
      In addition, the patch removes goya_mmap completely as it doesn't add any
      additional benefit.
      
      Fixes the following sparse warnings:
      
      drivers/misc/habanalabs/habanalabs_drv.c:24:1: warning: symbol 'hl_devs_idr' was not declared. Should it be static?
      drivers/misc/habanalabs/habanalabs_drv.c:25:1: warning: symbol 'hl_devs_idr_lock' was not declared. Should it be static?
      drivers/misc/habanalabs/memory.c:1451:5: warning: symbol 'hl_vm_ctx_init_with_ranges' was not declared. Should it be static?
      drivers/misc/habanalabs/goya/goya.c:396:5: warning: symbol 'goya_send_pci_access_msg' was not declared. Should it be static?
      drivers/misc/habanalabs/goya/goya.c:417:5: warning: symbol 'goya_pci_bars_map' was not declared. Should it be static?
      drivers/misc/habanalabs/goya/goya.c:557:6: warning: symbol 'goya_reset_link_through_bridge' was not declared. Should it be static?
      drivers/misc/habanalabs/goya/goya.c:774:5: warning: symbol 'goya_early_fini' was not declared. Should it be static?
      drivers/misc/habanalabs/goya/goya.c:857:6: warning: symbol 'goya_late_fini' was not declared. Should it be static?
      drivers/misc/habanalabs/goya/goya.c:971:5: warning: symbol 'goya_sw_fini' was not declared. Should it be static?
      drivers/misc/habanalabs/goya/goya.c:1233:5: warning: symbol 'goya_init_cpu_queues' was not declared. Should it be static?
      drivers/misc/habanalabs/goya/goya.c:2914:5: warning: symbol 'goya_suspend' was not declared. Should it be static?
      drivers/misc/habanalabs/goya/goya.c:2939:5: warning: symbol 'goya_resume' was not declared. Should it be static?
      drivers/misc/habanalabs/goya/goya.c:2952:5: warning: symbol 'goya_mmap' was not declared. Should it be static?
      drivers/misc/habanalabs/goya/goya.c:2957:5: warning: symbol 'goya_cb_mmap' was not declared. Should it be static?
      drivers/misc/habanalabs/goya/goya.c:2973:6: warning: symbol 'goya_ring_doorbell' was not declared. Should it be static?
      drivers/misc/habanalabs/goya/goya.c:3063:6: warning: symbol 'goya_flush_pq_write' was not declared. Should it be static?
      drivers/misc/habanalabs/goya/goya.c:3068:6: warning: symbol 'goya_dma_alloc_coherent' was not declared. Should it be static?
      drivers/misc/habanalabs/goya/goya.c:3074:6: warning: symbol 'goya_dma_free_coherent' was not declared. Should it be static?
      drivers/misc/habanalabs/goya/goya.c:3080:6: warning: symbol 'goya_get_int_queue_base' was not declared. Should it be static?
      drivers/misc/habanalabs/goya/goya.c:3138:5: warning: symbol 'goya_send_job_on_qman0' was not declared. Should it be static?
      drivers/misc/habanalabs/goya/goya.c:3295:5: warning: symbol 'goya_test_queue' was not declared. Should it be static?
      drivers/misc/habanalabs/goya/goya.c:3417:6: warning: symbol 'goya_dma_pool_zalloc' was not declared. Should it be static?
      drivers/misc/habanalabs/goya/goya.c:3426:6: warning: symbol 'goya_dma_pool_free' was not declared. Should it be static?
      drivers/misc/habanalabs/goya/goya.c:3432:6: warning: symbol 'goya_cpu_accessible_dma_pool_alloc' was not declared. Should it be static?
      drivers/misc/habanalabs/goya/goya.c:3448:6: warning: symbol 'goya_cpu_accessible_dma_pool_free' was not declared. Should it be static?
      drivers/misc/habanalabs/goya/goya.c:3458:5: warning: symbol 'goya_dma_map_sg' was not declared. Should it be static?
      drivers/misc/habanalabs/goya/goya.c:3467:6: warning: symbol 'goya_dma_unmap_sg' was not declared. Should it be static?
      drivers/misc/habanalabs/goya/goya.c:3473:5: warning: symbol 'goya_get_dma_desc_list_size' was not declared. Should it be static?
      drivers/misc/habanalabs/goya/goya.c:4210:5: warning: symbol 'goya_parse_cb_no_mmu' was not declared. Should it be static?
      drivers/misc/habanalabs/goya/goya.c:4261:5: warning: symbol 'goya_parse_cb_no_ext_quque' was not declared. Should it be static?
      drivers/misc/habanalabs/goya/goya.c:4294:5: warning: symbol 'goya_cs_parser' was not declared. Should it be static?
      drivers/misc/habanalabs/goya/goya.c:4307:6: warning: symbol 'goya_add_end_of_cb_packets' was not declared. Should it be static?
      drivers/misc/habanalabs/goya/goya.c:4334:5: warning: symbol 'goya_context_switch' was not declared. Should it be static?
      drivers/misc/habanalabs/goya/goya.c:4426:6: warning: symbol 'goya_restore_phase_topology' was not declared. Should it be static?
      drivers/misc/habanalabs/goya/goya.c:4460:5: warning: symbol 'goya_debugfs_read32' was not declared. Should it be static?
      drivers/misc/habanalabs/goya/goya.c:4510:5: warning: symbol 'goya_debugfs_write32' was not declared. Should it be static?
      drivers/misc/habanalabs/goya/goya.c:4738:6: warning: symbol 'goya_handle_eqe' was not declared. Should it be static?
      drivers/misc/habanalabs/goya/goya.c:4836:6: warning: symbol 'goya_get_events_stat' was not declared. Should it be static?
      drivers/misc/habanalabs/goya/goya.c:5075:5: warning: symbol 'goya_send_heartbeat' was not declared. Should it be static?
      drivers/misc/habanalabs/goya/goya.c:5253:5: warning: symbol 'goya_get_eeprom_data' was not declared. Should it be static?
      Reported-by: NYueHaibing <yuehaibing@huawei.com>
      Signed-off-by: NOded Gabbay <oded.gabbay@gmail.com>
      Signed-off-by: NGreg Kroah-Hartman <gregkh@linuxfoundation.org>
      5e6e0239
  15. 26 2月, 2019 1 次提交
  16. 23 2月, 2019 1 次提交
  17. 18 2月, 2019 11 次提交
    • O
      habanalabs: add debugfs support · c2164773
      Oded Gabbay 提交于
      This patch adds debugfs support to the driver. It allows the user-space to
      display information that is contained in the internal structures of the
      driver, such as:
      - active command submissions
      - active user virtual memory mappings
      - number of allocated command buffers
      
      It also enables the user to perform reads and writes through Goya's PCI
      bars.
      Reviewed-by: NMike Rapoport <rppt@linux.ibm.com>
      Signed-off-by: NOded Gabbay <oded.gabbay@gmail.com>
      Signed-off-by: NGreg Kroah-Hartman <gregkh@linuxfoundation.org>
      c2164773
    • O
      habanalabs: implement INFO IOCTL · d8dd7b0a
      Oded Gabbay 提交于
      This patch implements the INFO IOCTL. That IOCTL is used by the user to
      query information that is relevant/needed by the user in order to submit
      deep learning jobs to Goya.
      
      The information is divided into several categories, such as H/W IP, Events
      that happened, DDR usage and more.
      Reviewed-by: NMike Rapoport <rppt@linux.ibm.com>
      Signed-off-by: NOded Gabbay <oded.gabbay@gmail.com>
      Signed-off-by: NGreg Kroah-Hartman <gregkh@linuxfoundation.org>
      d8dd7b0a
    • O
      habanalabs: add virtual memory and MMU modules · 0feaf86d
      Omer Shpigelman 提交于
      This patch adds the Virtual Memory and MMU modules.
      
      Goya has an internal MMU which provides process isolation on the internal
      DDR. The internal MMU also performs translations for transactions that go
      from Goya to the Host.
      
      The driver is responsible for allocating and freeing memory on the DDR
      upon user request. It also provides an interface to map and unmap DDR and
      Host memory to the device address space.
      
      The MMU in Goya supports 3-level and 4-level page tables. With 3-level, the
      size of each page is 2MB, while with 4-level the size of each page is 4KB.
      
      In the DDR, the physical pages are always 2MB.
      Reviewed-by: NMike Rapoport <rppt@linux.ibm.com>
      Signed-off-by: NOmer Shpigelman <oshpigelman@habana.ai>
      Signed-off-by: NOded Gabbay <oded.gabbay@gmail.com>
      Signed-off-by: NGreg Kroah-Hartman <gregkh@linuxfoundation.org>
      0feaf86d
    • O
      habanalabs: add command submission module · eff6f4a0
      Oded Gabbay 提交于
      This patch adds the main flow for the user to submit work to the device.
      
      Each work is described by a command submission object (CS). The CS contains
      3 arrays of command buffers: One for execution, and two for context-switch
      (store and restore).
      
      For each CB, the user specifies on which queue to put that CB. In case of
      an internal queue, the entry doesn't contain a pointer to the CB but the
      address in the on-chip memory that the CB resides at.
      
      The driver parses some of the CBs to enforce security restrictions.
      
      The user receives a sequence number that represents the CS object. The user
      can then query the driver regarding the status of the CS, using that
      sequence number.
      
      In case the CS doesn't finish before the timeout expires, the driver will
      perform a soft-reset of the device.
      Reviewed-by: NMike Rapoport <rppt@linux.ibm.com>
      Signed-off-by: NOded Gabbay <oded.gabbay@gmail.com>
      Signed-off-by: NGreg Kroah-Hartman <gregkh@linuxfoundation.org>
      eff6f4a0
    • O
      habanalabs: add device reset support · f8c8c7d5
      Oded Gabbay 提交于
      This patch adds support for doing various on-the-fly reset of Goya.
      
      The driver supports two types of resets:
      1. soft-reset
      2. hard-reset
      
      Soft-reset is done when the device detects a timeout of a command
      submission that was given to the device. The soft-reset process only resets
      the engines that are relevant for the submission of compute jobs, i.e. the
      DMA channels, the TPCs and the MME. The purpose is to bring the device as
      fast as possible to a working state.
      
      Hard-reset is done in several cases:
      1. After soft-reset is done but the device is not responding
      2. When fatal errors occur inside the device, e.g. ECC error
      3. When the driver is removed
      
      Hard-reset performs a reset of the entire chip except for the PCI
      controller and the PLLs. It is a much longer process then soft-reset but it
      helps to recover the device without the need to reboot the Host.
      
      After hard-reset, the driver will restore the max power attribute and in
      case of manual power management, the frequencies that were set.
      
      This patch also adds two entries to the sysfs, which allows the root user
      to initiate a soft or hard reset.
      Reviewed-by: NMike Rapoport <rppt@linux.ibm.com>
      Signed-off-by: NOded Gabbay <oded.gabbay@gmail.com>
      Signed-off-by: NGreg Kroah-Hartman <gregkh@linuxfoundation.org>
      f8c8c7d5
    • O
      habanalabs: add sysfs and hwmon support · d91389bc
      Oded Gabbay 提交于
      This patch add the sysfs and hwmon entries that are exposed by the driver.
      
      Goya has several sensors, from various categories such as temperature,
      voltage, current, etc. The driver exposes those sensors in the standard
      hwmon mechanism.
      
      In addition, the driver exposes a couple of interfaces in sysfs, both for
      configuration and for providing status of the device or driver.
      
      The configuration attributes is for Power Management:
      - Automatic or manual
      - Frequency value when moving to high frequency mode
      - Maximum power the device is allowed to consume
      
      The rest of the attributes are read-only and provide the following
      information:
      - Versions of the various firmwares running on the device
      - Contents of the device's EEPROM
      - The device type (currently only Goya is supported)
      - PCI address of the device (to allow user-space to connect between
        /dev/hlX to PCI address)
      - Status of the device (operational, malfunction, in_reset)
      - How many processes are open on the device's file
      Reviewed-by: NMike Rapoport <rppt@linux.ibm.com>
      Signed-off-by: NOded Gabbay <oded.gabbay@gmail.com>
      Signed-off-by: NGreg Kroah-Hartman <gregkh@linuxfoundation.org>
      d91389bc
    • O
      habanalabs: add event queue and interrupts · 1251f23a
      Oded Gabbay 提交于
      This patch adds support for receiving events from Goya's control CPU and
      for receiving MSI-X interrupts from Goya's DMA engines and CPU.
      
      Goya's PCI controller supports up to 8 MSI-X interrupts, which only 6 of
      them are currently used. The first 5 interrupts are dedicated for Goya's
      DMA engine queues. The 6th interrupt is dedicated for Goya's control CPU.
      
      The DMA queue will signal its MSI-X entry upon each completion of a command
      buffer that was placed on its primary queue. The driver will then mark that
      CB as completed and free the related resources. It will also update the
      command submission object which that CB belongs to.
      
      There is a dedicated event queue (EQ) between the driver and Goya's control
      CPU. The EQ is located on the Host memory. The control CPU writes a new
      entry to the EQ for various reasons, such as ECC error, MMU page fault, Hot
      temperature. After writing the new entry to the EQ, the control CPU will
      trigger its dedicated MSI-X entry to signal the driver that there is a new
      entry in the EQ. The driver will then read the entry and act accordingly.
      Reviewed-by: NMike Rapoport <rppt@linux.ibm.com>
      Signed-off-by: NOded Gabbay <oded.gabbay@gmail.com>
      Signed-off-by: NGreg Kroah-Hartman <gregkh@linuxfoundation.org>
      1251f23a
    • O
      habanalabs: add h/w queues module · 9494a8dd
      Oded Gabbay 提交于
      This patch adds the H/W queues module and the code to initialize Goya's
      various compute and DMA engines and their queues.
      
      Goya has 5 DMA channels, 8 TPC engines and a single MME engine. For each
      channel/engine, there is a H/W queue logic which is used to pass commands
      from the user to the H/W. That logic is called QMAN.
      
      There are two types of QMANs: external and internal. The DMA QMANs are
      considered external while the TPC and MME QMANs are considered internal.
      For each external queue there is a completion queue, which is located on
      the Host memory.
      
      The differences between external and internal QMANs are:
      
      1. The location of the queue's memory. External QMANs are located on the
         Host memory while internal QMANs are located on the on-chip memory.
      
      2. The external QMAN write an entry to a completion queue and sends an
         MSI-X interrupt upon completion of a command buffer that was given to
         it. The internal QMAN doesn't do that.
      Reviewed-by: NMike Rapoport <rppt@linux.ibm.com>
      Signed-off-by: NOded Gabbay <oded.gabbay@gmail.com>
      Signed-off-by: NGreg Kroah-Hartman <gregkh@linuxfoundation.org>
      9494a8dd
    • O
      habanalabs: add basic Goya h/w initialization · 839c4803
      Oded Gabbay 提交于
      This patch adds the basic part of Goya's H/W initialization. It adds code
      that initializes Goya's internal CPU, various registers that are related to
      internal routing, scrambling, workarounds for H/W bugs, etc.
      
      It also initializes Goya's security scheme that prevents the user from
      abusing Goya to steal data from the host, crash the host, change
      Goya's F/W, etc.
      Reviewed-by: NMike Rapoport <rppt@linux.ibm.com>
      Signed-off-by: NOded Gabbay <oded.gabbay@gmail.com>
      Signed-off-by: NGreg Kroah-Hartman <gregkh@linuxfoundation.org>
      839c4803
    • O
      habanalabs: add command buffer module · be5d926b
      Oded Gabbay 提交于
      This patch adds the command buffer (CB) module, which allows the user to
      create and destroy CBs and to map them to the user's process
      address-space.
      
      A command buffer is a memory blocks that reside in DMA-able address-space
      and is physically contiguous so it can be accessed by the device without
      MMU translation. The command buffer memory is allocated using the
      coherent DMA API.
      
      When creating a new CB, the IOCTL returns a handle of it, and the
      user-space process needs to use that handle to mmap the buffer to get a VA
      in the user's address-space.
      
      Before destroying (freeing) a CB, the user must unmap the CB's VA using the
      CB handle.
      
      Each CB has a reference counter, which tracks its usage in command
      submissions and also its mmaps (only a single mmap is allowed).
      
      The driver maintains a pool of pre-allocated CBs in order to reduce
      latency during command submissions. In case the pool is empty, the driver
      will go to the slow-path of allocating a new CB, i.e. calling
      dma_alloc_coherent.
      Reviewed-by: NMike Rapoport <rppt@linux.ibm.com>
      Signed-off-by: NOded Gabbay <oded.gabbay@gmail.com>
      Signed-off-by: NGreg Kroah-Hartman <gregkh@linuxfoundation.org>
      be5d926b
    • O
      habanalabs: add basic Goya support · 99b9d7b4
      Oded Gabbay 提交于
      This patch adds a basic support for the Goya device. The code initializes
      the device's PCI controller and PCI bars. It also initializes various S/W
      structures and adds some basic helper functions.
      Reviewed-by: NMike Rapoport <rppt@linux.ibm.com>
      Signed-off-by: NOded Gabbay <oded.gabbay@gmail.com>
      Signed-off-by: NGreg Kroah-Hartman <gregkh@linuxfoundation.org>
      99b9d7b4