1. 24 11月, 2010 4 次提交
  2. 23 11月, 2010 2 次提交
  3. 18 11月, 2010 1 次提交
  4. 16 11月, 2010 1 次提交
    • J
      Fix gcc 4.5.1 miscompiling drivers/char/i8k.c (again) · 22d3243d
      Jim Bos 提交于
      The fix in commit 6b4e81db ("i8k: Tell gcc that *regs gets
      clobbered") to work around the gcc miscompiling i8k.c to add "+m
      (*regs)" caused register pressure problems and a build failure.
      
      Changing the 'asm' statement to 'asm volatile' instead should prevent
      that and works around the gcc bug as well, so we can remove the "+m".
      
      [ Background on the gcc bug: a memory clobber fails to mark the function
        the asm resides in as non-pure (aka "__attribute__((const))"), so if
        the function does nothing else that triggers the non-pure logic, gcc
        will think that that function has no side effects at all. As a result,
        callers will be mis-compiled.
      
        Adding the "+m" made gcc see that it's not a pure function, and so
        does "asm volatile". The problem was never really the need to mark
        "*regs" as changed, since the memory clobber did that part - the
        problem was just a bug in the gcc "pure" function analysis  - Linus ]
      Signed-off-by: NJim Bos <jim876@xs4all.nl>
      Acked-by: NJakub Jelinek <jakub@redhat.com>
      Cc: Andi Kleen <andi@firstfloor.org>
      Cc: Andreas Schwab <schwab@linux-m68k.org>
      Signed-off-by: NLinus Torvalds <torvalds@linux-foundation.org>
      22d3243d
  5. 15 11月, 2010 1 次提交
  6. 14 11月, 2010 1 次提交
    • J
      i8k: Tell gcc that *regs gets clobbered · 6b4e81db
      Jim Bos 提交于
      More recent GCC caused the i8k driver to stop working, on Slackware
      compiler was upgraded from gcc-4.4.4 to gcc-4.5.1 after which it didn't
      work anymore, meaning the driver didn't load or gave total nonsensical
      output.
      
      As it turned out the asm(..) statement forgot to mention it modifies the
      *regs variable.
      
      Credits to Andi Kleen and Andreas Schwab for providing the fix.
      Signed-off-by: NJim Bos <jim876@xs4all.nl>
      Cc: Andi Kleen <andi@firstfloor.org>
      Cc: Andreas Schwab <schwab@linux-m68k.org>
      Signed-off-by: NLinus Torvalds <torvalds@linux-foundation.org>
      6b4e81db
  7. 12 11月, 2010 1 次提交
  8. 10 11月, 2010 4 次提交
  9. 06 11月, 2010 1 次提交
  10. 05 11月, 2010 2 次提交
  11. 04 11月, 2010 2 次提交
  12. 02 11月, 2010 2 次提交
  13. 31 10月, 2010 1 次提交
  14. 30 10月, 2010 3 次提交
  15. 28 10月, 2010 14 次提交