• L
    NTB: Fix the default port and peer numbers for legacy drivers · fc8b086d
    Logan Gunthorpe 提交于
    When the commit adding ntb_default_port_number() and
    ntb_default_peer_port_number()  entered the kernel there was no
    users of it so it was impossible to tell what the API needed.
    
    When a user finally landed a year later (ntb_pingpong) there were
    more NTB topologies were created and no consideration was considered
    to how other drivers had changed.
    
    Now that there is a user it can be fixed to provide a sensible default
    for the legacy drivers that do not implement ntb_{peer_}port_number().
    Seeing ntb_pingpong doesn't check error codes returning EINVAL was also
    not sensible.
    
    Patches for ntb_pingpong and ntb_perf follow (which are broken
    otherwise) to support hardware that doesn't have port numbers. This is
    important not only to not break support with existing drivers but for
    the cross link topology which, due to its perfect symmetry, cannot
    assign unique port numbers to each side.
    
    Fixes: 1e530119 ("NTB: Add indexed ports NTB API")
    Signed-off-by: NLogan Gunthorpe <logang@deltatee.com>
    Acked-by: NAllen Hubbe <allenbh@gmail.com>
    Tested-by: NAlexander Fomichev <fomichev.ru@gmail.com>
    Signed-off-by: NJon Mason <jdmason@kudzu.us>
    fc8b086d
core.c 7.7 KB