• L
    bfq-iosched: Revert "bfq: Fix computation of shallow depth" · 53f3de01
    Lin Feng 提交于
    stable inclusion
    from stable-5.10.17
    commit d93178df8f754b8ae5b5c804edcd6d4b64aad5a7
    bugzilla: 48169
    
    --------------------------------
    
    [ Upstream commit 388c705b ]
    
    This reverts commit 6d4d2735.
    
    bfq.limit_depth passes word_depths[] as shallow_depth down to sbitmap core
    sbitmap_get_shallow, which uses just the number to limit the scan depth of
    each bitmap word, formula:
    scan_percentage_for_each_word = shallow_depth / (1 << sbimap->shift) * 100%
    
    That means the comments's percentiles 50%, 75%, 18%, 37% of bfq are correct.
    But after commit patch 'bfq: Fix computation of shallow depth', we use
    sbitmap.depth instead, as a example in following case:
    
    sbitmap.depth = 256, map_nr = 4, shift = 6; sbitmap_word.depth = 64.
    The resulsts of computed bfqd->word_depths[] are {128, 192, 48, 96}, and
    three of the numbers exceed core dirver's 'sbitmap_word.depth=64' limit
    nothing.
    Signed-off-by: NLin Feng <linf@wangsu.com>
    Reviewed-by: NJan Kara <jack@suse.cz>
    Signed-off-by: NJens Axboe <axboe@kernel.dk>
    Signed-off-by: NSasha Levin <sashal@kernel.org>
    Signed-off-by: NZheng Zengkai <zhengzengkai@huawei.com>
    Acked-by: NXie XiuQi <xiexiuqi@huawei.com>
    53f3de01
bfq-iosched.c 236.6 KB