spi.c 18.9 KB
Newer Older
1 2 3 4 5 6 7 8 9 10 11 12 13 14 15 16 17 18 19 20 21 22 23 24 25
/*
 * spi.c - SPI init/core code
 *
 * Copyright (C) 2005 David Brownell
 *
 * This program is free software; you can redistribute it and/or modify
 * it under the terms of the GNU General Public License as published by
 * the Free Software Foundation; either version 2 of the License, or
 * (at your option) any later version.
 *
 * This program is distributed in the hope that it will be useful,
 * but WITHOUT ANY WARRANTY; without even the implied warranty of
 * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the
 * GNU General Public License for more details.
 *
 * You should have received a copy of the GNU General Public License
 * along with this program; if not, write to the Free Software
 * Foundation, Inc., 675 Mass Ave, Cambridge, MA 02139, USA.
 */

#include <linux/autoconf.h>
#include <linux/kernel.h>
#include <linux/device.h>
#include <linux/init.h>
#include <linux/cache.h>
26
#include <linux/mutex.h>
27 28 29
#include <linux/spi/spi.h>


30 31 32
/* SPI bustype and spi_master class are registered after board init code
 * provides the SPI device tables, ensuring that both are present by the
 * time controller driver registration causes spi_devices to "enumerate".
33 34 35
 */
static void spidev_release(struct device *dev)
{
36
	struct spi_device	*spi = to_spi_device(dev);
37 38 39 40 41

	/* spi masters may cleanup for released devices */
	if (spi->master->cleanup)
		spi->master->cleanup(spi);

D
David Brownell 已提交
42
	spi_master_put(spi->master);
43 44 45 46 47 48 49 50 51 52 53 54 55 56 57 58 59 60 61 62 63 64 65 66 67 68 69
	kfree(dev);
}

static ssize_t
modalias_show(struct device *dev, struct device_attribute *a, char *buf)
{
	const struct spi_device	*spi = to_spi_device(dev);

	return snprintf(buf, BUS_ID_SIZE + 1, "%s\n", spi->modalias);
}

static struct device_attribute spi_dev_attrs[] = {
	__ATTR_RO(modalias),
	__ATTR_NULL,
};

/* modalias support makes "modprobe $MODALIAS" new-style hotplug work,
 * and the sysfs version makes coldplug work too.
 */

static int spi_match_device(struct device *dev, struct device_driver *drv)
{
	const struct spi_device	*spi = to_spi_device(dev);

	return strncmp(spi->modalias, drv->name, BUS_ID_SIZE) == 0;
}

70
static int spi_uevent(struct device *dev, struct kobj_uevent_env *env)
71 72 73
{
	const struct spi_device		*spi = to_spi_device(dev);

74
	add_uevent_var(env, "MODALIAS=%s", spi->modalias);
75 76 77 78 79
	return 0;
}

#ifdef	CONFIG_PM

80
/*
81 82 83 84 85 86 87
 * NOTE:  the suspend() method for an spi_master controller driver
 * should verify that all its child devices are marked as suspended;
 * suspend requests delivered through sysfs power/state files don't
 * enforce such constraints.
 */
static int spi_suspend(struct device *dev, pm_message_t message)
{
88 89
	int			value;
	struct spi_driver	*drv = to_spi_driver(dev->driver);
90

91
	if (!drv || !drv->suspend)
92 93 94
		return 0;

	/* suspend will stop irqs and dma; no more i/o */
95
	value = drv->suspend(to_spi_device(dev), message);
96 97 98 99 100 101 102
	if (value == 0)
		dev->power.power_state = message;
	return value;
}

static int spi_resume(struct device *dev)
{
103 104
	int			value;
	struct spi_driver	*drv = to_spi_driver(dev->driver);
105

106
	if (!drv || !drv->resume)
107 108 109
		return 0;

	/* resume may restart the i/o queue */
110
	value = drv->resume(to_spi_device(dev));
111 112 113 114 115 116 117 118 119 120 121 122 123 124 125 126 127 128 129 130
	if (value == 0)
		dev->power.power_state = PMSG_ON;
	return value;
}

#else
#define spi_suspend	NULL
#define spi_resume	NULL
#endif

struct bus_type spi_bus_type = {
	.name		= "spi",
	.dev_attrs	= spi_dev_attrs,
	.match		= spi_match_device,
	.uevent		= spi_uevent,
	.suspend	= spi_suspend,
	.resume		= spi_resume,
};
EXPORT_SYMBOL_GPL(spi_bus_type);

131 132 133 134 135 136 137 138 139 140 141 142 143 144 145 146 147 148 149 150 151 152

static int spi_drv_probe(struct device *dev)
{
	const struct spi_driver		*sdrv = to_spi_driver(dev->driver);

	return sdrv->probe(to_spi_device(dev));
}

static int spi_drv_remove(struct device *dev)
{
	const struct spi_driver		*sdrv = to_spi_driver(dev->driver);

	return sdrv->remove(to_spi_device(dev));
}

static void spi_drv_shutdown(struct device *dev)
{
	const struct spi_driver		*sdrv = to_spi_driver(dev->driver);

	sdrv->shutdown(to_spi_device(dev));
}

D
David Brownell 已提交
153 154 155 156 157
/**
 * spi_register_driver - register a SPI driver
 * @sdrv: the driver to register
 * Context: can sleep
 */
158 159 160 161 162 163 164 165 166 167 168 169 170
int spi_register_driver(struct spi_driver *sdrv)
{
	sdrv->driver.bus = &spi_bus_type;
	if (sdrv->probe)
		sdrv->driver.probe = spi_drv_probe;
	if (sdrv->remove)
		sdrv->driver.remove = spi_drv_remove;
	if (sdrv->shutdown)
		sdrv->driver.shutdown = spi_drv_shutdown;
	return driver_register(&sdrv->driver);
}
EXPORT_SYMBOL_GPL(spi_register_driver);

171 172 173 174 175 176 177 178 179 180 181 182 183 184 185
/*-------------------------------------------------------------------------*/

/* SPI devices should normally not be created by SPI device drivers; that
 * would make them board-specific.  Similarly with SPI master drivers.
 * Device registration normally goes into like arch/.../mach.../board-YYY.c
 * with other readonly (flashable) information about mainboard devices.
 */

struct boardinfo {
	struct list_head	list;
	unsigned		n_board_info;
	struct spi_board_info	board_info[0];
};

static LIST_HEAD(board_list);
186
static DEFINE_MUTEX(board_lock);
187 188


D
David Brownell 已提交
189 190 191 192 193 194 195
/**
 * spi_new_device - instantiate one new SPI device
 * @master: Controller to which device is connected
 * @chip: Describes the SPI device
 * Context: can sleep
 *
 * On typical mainboards, this is purely internal; and it's not needed
196 197 198 199
 * after board init creates the hard-wired devices.  Some development
 * platforms may not be able to use spi_register_board_info though, and
 * this is exported so that for example a USB or parport based adapter
 * driver could add devices (which it would learn about out-of-band).
200 201
 *
 * Returns the new device, or NULL.
202
 */
203 204
struct spi_device *spi_new_device(struct spi_master *master,
				  struct spi_board_info *chip)
205 206
{
	struct spi_device	*proxy;
T
Tony Jones 已提交
207
	struct device		*dev = master->dev.parent;
208 209
	int			status;

210 211 212 213 214 215 216 217 218 219 220 221 222 223
	/* NOTE:  caller did any chip->bus_num checks necessary.
	 *
	 * Also, unless we change the return value convention to use
	 * error-or-pointer (not NULL-or-pointer), troubleshootability
	 * suggests syslogged diagnostics are best here (ugh).
	 */

	/* Chipselects are numbered 0..max; validate. */
	if (chip->chip_select >= master->num_chipselect) {
		dev_err(dev, "cs%d > max %d\n",
			chip->chip_select,
			master->num_chipselect);
		return NULL;
	}
224

D
David Brownell 已提交
225
	if (!spi_master_get(master))
226 227 228 229 230 231 232 233 234 235 236
		return NULL;

	proxy = kzalloc(sizeof *proxy, GFP_KERNEL);
	if (!proxy) {
		dev_err(dev, "can't alloc dev for cs%d\n",
			chip->chip_select);
		goto fail;
	}
	proxy->master = master;
	proxy->chip_select = chip->chip_select;
	proxy->max_speed_hz = chip->max_speed_hz;
237
	proxy->mode = chip->mode;
238 239 240 241
	proxy->irq = chip->irq;
	proxy->modalias = chip->modalias;

	snprintf(proxy->dev.bus_id, sizeof proxy->dev.bus_id,
T
Tony Jones 已提交
242
			"%s.%u", master->dev.bus_id,
243 244 245 246 247 248 249 250
			chip->chip_select);
	proxy->dev.parent = dev;
	proxy->dev.bus = &spi_bus_type;
	proxy->dev.platform_data = (void *) chip->platform_data;
	proxy->controller_data = chip->controller_data;
	proxy->controller_state = NULL;
	proxy->dev.release = spidev_release;

251
	/* drivers may modify this initial i/o setup */
252 253
	status = master->setup(proxy);
	if (status < 0) {
254
		dev_err(dev, "can't %s %s, status %d\n",
255 256 257 258 259 260 261 262 263
				"setup", proxy->dev.bus_id, status);
		goto fail;
	}

	/* driver core catches callers that misbehave by defining
	 * devices that already exist.
	 */
	status = device_register(&proxy->dev);
	if (status < 0) {
264
		dev_err(dev, "can't %s %s, status %d\n",
265
				"add", proxy->dev.bus_id, status);
266
		goto fail;
267 268 269
	}
	dev_dbg(dev, "registered child %s\n", proxy->dev.bus_id);
	return proxy;
270 271

fail:
D
David Brownell 已提交
272
	spi_master_put(master);
273 274
	kfree(proxy);
	return NULL;
275 276 277
}
EXPORT_SYMBOL_GPL(spi_new_device);

D
David Brownell 已提交
278 279 280 281 282 283
/**
 * spi_register_board_info - register SPI devices for a given board
 * @info: array of chip descriptors
 * @n: how many descriptors are provided
 * Context: can sleep
 *
284 285 286 287 288 289 290 291 292 293 294 295 296 297 298 299 300 301
 * Board-specific early init code calls this (probably during arch_initcall)
 * with segments of the SPI device table.  Any device nodes are created later,
 * after the relevant parent SPI controller (bus_num) is defined.  We keep
 * this table of devices forever, so that reloading a controller driver will
 * not make Linux forget about these hard-wired devices.
 *
 * Other code can also call this, e.g. a particular add-on board might provide
 * SPI devices through its expansion connector, so code initializing that board
 * would naturally declare its SPI devices.
 *
 * The board info passed can safely be __initdata ... but be careful of
 * any embedded pointers (platform_data, etc), they're copied as-is.
 */
int __init
spi_register_board_info(struct spi_board_info const *info, unsigned n)
{
	struct boardinfo	*bi;

302
	bi = kmalloc(sizeof(*bi) + n * sizeof *info, GFP_KERNEL);
303 304 305
	if (!bi)
		return -ENOMEM;
	bi->n_board_info = n;
306
	memcpy(bi->board_info, info, n * sizeof *info);
307

308
	mutex_lock(&board_lock);
309
	list_add_tail(&bi->list, &board_list);
310
	mutex_unlock(&board_lock);
311 312 313 314 315 316 317
	return 0;
}

/* FIXME someone should add support for a __setup("spi", ...) that
 * creates board info from kernel command lines
 */

318
static void scan_boardinfo(struct spi_master *master)
319 320 321
{
	struct boardinfo	*bi;

322
	mutex_lock(&board_lock);
323 324 325 326 327 328 329
	list_for_each_entry(bi, &board_list, list) {
		struct spi_board_info	*chip = bi->board_info;
		unsigned		n;

		for (n = bi->n_board_info; n > 0; n--, chip++) {
			if (chip->bus_num != master->bus_num)
				continue;
330 331
			/* NOTE: this relies on spi_new_device to
			 * issue diagnostics when given bogus inputs
332 333 334 335
			 */
			(void) spi_new_device(master, chip);
		}
	}
336
	mutex_unlock(&board_lock);
337 338 339 340
}

/*-------------------------------------------------------------------------*/

T
Tony Jones 已提交
341
static void spi_master_release(struct device *dev)
342 343 344
{
	struct spi_master *master;

T
Tony Jones 已提交
345
	master = container_of(dev, struct spi_master, dev);
346 347 348 349 350 351
	kfree(master);
}

static struct class spi_master_class = {
	.name		= "spi_master",
	.owner		= THIS_MODULE,
T
Tony Jones 已提交
352
	.dev_release	= spi_master_release,
353 354 355 356 357 358
};


/**
 * spi_alloc_master - allocate SPI master controller
 * @dev: the controller, possibly using the platform_bus
D
David Brownell 已提交
359
 * @size: how much zeroed driver-private data to allocate; the pointer to this
T
Tony Jones 已提交
360
 *	memory is in the driver_data field of the returned device,
D
David Brownell 已提交
361
 *	accessible with spi_master_get_devdata().
D
David Brownell 已提交
362
 * Context: can sleep
363 364 365
 *
 * This call is used only by SPI master controller drivers, which are the
 * only ones directly touching chip registers.  It's how they allocate
D
dmitry pervushin 已提交
366
 * an spi_master structure, prior to calling spi_register_master().
367 368 369 370 371
 *
 * This must be called from context that can sleep.  It returns the SPI
 * master structure on success, else NULL.
 *
 * The caller is responsible for assigning the bus number and initializing
D
dmitry pervushin 已提交
372
 * the master's methods before calling spi_register_master(); and (after errors
D
David Brownell 已提交
373
 * adding the device) calling spi_master_put() to prevent a memory leak.
374
 */
375
struct spi_master *spi_alloc_master(struct device *dev, unsigned size)
376 377 378
{
	struct spi_master	*master;

D
David Brownell 已提交
379 380 381
	if (!dev)
		return NULL;

382
	master = kzalloc(size + sizeof *master, GFP_KERNEL);
383 384 385
	if (!master)
		return NULL;

T
Tony Jones 已提交
386 387 388
	device_initialize(&master->dev);
	master->dev.class = &spi_master_class;
	master->dev.parent = get_device(dev);
D
David Brownell 已提交
389
	spi_master_set_devdata(master, &master[1]);
390 391 392 393 394 395 396 397

	return master;
}
EXPORT_SYMBOL_GPL(spi_alloc_master);

/**
 * spi_register_master - register SPI master controller
 * @master: initialized master, originally from spi_alloc_master()
D
David Brownell 已提交
398
 * Context: can sleep
399 400 401 402 403 404 405 406 407 408 409 410 411
 *
 * SPI master controllers connect to their drivers using some non-SPI bus,
 * such as the platform bus.  The final stage of probe() in that code
 * includes calling spi_register_master() to hook up to this SPI bus glue.
 *
 * SPI controllers use board specific (often SOC specific) bus numbers,
 * and board-specific addressing for SPI devices combines those numbers
 * with chip select numbers.  Since SPI does not directly support dynamic
 * device identification, boards need configuration tables telling which
 * chip is at which address.
 *
 * This must be called from context that can sleep.  It returns zero on
 * success, else a negative error code (dropping the master's refcount).
D
David Brownell 已提交
412 413
 * After a successful return, the caller is responsible for calling
 * spi_unregister_master().
414
 */
415
int spi_register_master(struct spi_master *master)
416
{
417
	static atomic_t		dyn_bus_id = ATOMIC_INIT((1<<15) - 1);
T
Tony Jones 已提交
418
	struct device		*dev = master->dev.parent;
419 420 421
	int			status = -ENODEV;
	int			dynamic = 0;

D
David Brownell 已提交
422 423 424
	if (!dev)
		return -ENODEV;

425 426 427 428 429 430
	/* even if it's just one always-selected device, there must
	 * be at least one chipselect
	 */
	if (master->num_chipselect == 0)
		return -EINVAL;

431
	/* convention:  dynamically assigned bus IDs count down from the max */
432
	if (master->bus_num < 0) {
433 434 435
		/* FIXME switch to an IDR based scheme, something like
		 * I2C now uses, so we can't run out of "dynamic" IDs
		 */
436
		master->bus_num = atomic_dec_return(&dyn_bus_id);
437
		dynamic = 1;
438 439 440 441 442
	}

	/* register the device, then userspace will see it.
	 * registration fails if the bus ID is in use.
	 */
T
Tony Jones 已提交
443
	snprintf(master->dev.bus_id, sizeof master->dev.bus_id,
444
		"spi%u", master->bus_num);
T
Tony Jones 已提交
445
	status = device_add(&master->dev);
446
	if (status < 0)
447
		goto done;
T
Tony Jones 已提交
448
	dev_dbg(dev, "registered master %s%s\n", master->dev.bus_id,
449 450 451 452 453 454 455 456 457 458 459
			dynamic ? " (dynamic)" : "");

	/* populate children from any spi device tables */
	scan_boardinfo(master);
	status = 0;
done:
	return status;
}
EXPORT_SYMBOL_GPL(spi_register_master);


460
static int __unregister(struct device *dev, void *master_dev)
461 462
{
	/* note: before about 2.6.14-rc1 this would corrupt memory: */
463 464
	if (dev != master_dev)
		spi_unregister_device(to_spi_device(dev));
465 466 467 468 469 470
	return 0;
}

/**
 * spi_unregister_master - unregister SPI master controller
 * @master: the master being unregistered
D
David Brownell 已提交
471
 * Context: can sleep
472 473 474 475 476 477 478 479
 *
 * This call is used only by SPI master controller drivers, which are the
 * only ones directly touching chip registers.
 *
 * This must be called from context that can sleep.
 */
void spi_unregister_master(struct spi_master *master)
{
480 481
	int dummy;

482 483
	dummy = device_for_each_child(master->dev.parent, &master->dev,
					__unregister);
T
Tony Jones 已提交
484
	device_unregister(&master->dev);
485 486 487 488 489 490
}
EXPORT_SYMBOL_GPL(spi_unregister_master);

/**
 * spi_busnum_to_master - look up master associated with bus_num
 * @bus_num: the master's bus number
D
David Brownell 已提交
491
 * Context: can sleep
492 493 494 495 496 497 498 499
 *
 * This call may be used with devices that are registered after
 * arch init time.  It returns a refcounted pointer to the relevant
 * spi_master (which the caller must release), or NULL if there is
 * no such master registered.
 */
struct spi_master *spi_busnum_to_master(u16 bus_num)
{
T
Tony Jones 已提交
500
	struct device		*dev;
501 502 503 504
	struct spi_master	*master = NULL;
	struct spi_master	*m;

	down(&spi_master_class.sem);
T
Tony Jones 已提交
505 506
	list_for_each_entry(dev, &spi_master_class.children, node) {
		m = container_of(dev, struct spi_master, dev);
507 508 509 510 511 512 513
		if (m->bus_num == bus_num) {
			master = spi_master_get(m);
			break;
		}
	}
	up(&spi_master_class.sem);
	return master;
514 515 516 517 518 519
}
EXPORT_SYMBOL_GPL(spi_busnum_to_master);


/*-------------------------------------------------------------------------*/

520 521 522 523 524
static void spi_complete(void *arg)
{
	complete(arg);
}

525 526 527 528
/**
 * spi_sync - blocking/synchronous SPI data transfers
 * @spi: device with which data will be exchanged
 * @message: describes the data transfers
D
David Brownell 已提交
529
 * Context: can sleep
530 531 532 533 534 535 536 537 538 539 540
 *
 * This call may only be used from a context that may sleep.  The sleep
 * is non-interruptible, and has no timeout.  Low-overhead controller
 * drivers may DMA directly into and out of the message buffers.
 *
 * Note that the SPI device's chip select is active during the message,
 * and then is normally disabled between messages.  Drivers for some
 * frequently-used devices may want to minimize costs of selecting a chip,
 * by leaving it selected in anticipation that the next message will go
 * to the same chip.  (That may increase power usage.)
 *
D
David Brownell 已提交
541 542 543
 * Also, the caller is guaranteeing that the memory associated with the
 * message will not be freed before this call returns.
 *
544 545
 * The return value is a negative error code if the message could not be
 * submitted, else zero.  When the value is zero, then message->status is
D
David Brownell 已提交
546
 * also defined;  it's the completion code for the transfer, either zero
547 548 549 550
 * or a negative error code from the controller driver.
 */
int spi_sync(struct spi_device *spi, struct spi_message *message)
{
551
	DECLARE_COMPLETION_ONSTACK(done);
552 553
	int status;

554
	message->complete = spi_complete;
555 556 557 558 559 560 561 562 563
	message->context = &done;
	status = spi_async(spi, message);
	if (status == 0)
		wait_for_completion(&done);
	message->context = NULL;
	return status;
}
EXPORT_SYMBOL_GPL(spi_sync);

564 565
/* portable code must never pass more than 32 bytes */
#define	SPI_BUFSIZ	max(32,SMP_CACHE_BYTES)
566 567 568 569 570 571 572 573 574 575

static u8	*buf;

/**
 * spi_write_then_read - SPI synchronous write followed by read
 * @spi: device with which data will be exchanged
 * @txbuf: data to be written (need not be dma-safe)
 * @n_tx: size of txbuf, in bytes
 * @rxbuf: buffer into which data will be read
 * @n_rx: size of rxbuf, in bytes (need not be dma-safe)
D
David Brownell 已提交
576
 * Context: can sleep
577 578 579 580
 *
 * This performs a half duplex MicroWire style transaction with the
 * device, sending txbuf and then reading rxbuf.  The return value
 * is zero for success, else a negative errno status code.
581
 * This call may only be used from a context that may sleep.
582
 *
D
David Brownell 已提交
583
 * Parameters to this routine are always copied using a small buffer;
D
David Brownell 已提交
584 585
 * portable code should never use this for more than 32 bytes.
 * Performance-sensitive or bulk transfer code should instead use
D
David Brownell 已提交
586
 * spi_{async,sync}() calls with dma-safe buffers.
587 588 589 590 591 592 593 594 595 596 597 598 599 600 601 602 603 604 605
 */
int spi_write_then_read(struct spi_device *spi,
		const u8 *txbuf, unsigned n_tx,
		u8 *rxbuf, unsigned n_rx)
{
	static DECLARE_MUTEX(lock);

	int			status;
	struct spi_message	message;
	struct spi_transfer	x[2];
	u8			*local_buf;

	/* Use preallocated DMA-safe buffer.  We can't avoid copying here,
	 * (as a pure convenience thing), but we can keep heap costs
	 * out of the hot path ...
	 */
	if ((n_tx + n_rx) > SPI_BUFSIZ)
		return -EINVAL;

606 607 608 609 610 611 612 613 614 615 616
	spi_message_init(&message);
	memset(x, 0, sizeof x);
	if (n_tx) {
		x[0].len = n_tx;
		spi_message_add_tail(&x[0], &message);
	}
	if (n_rx) {
		x[1].len = n_rx;
		spi_message_add_tail(&x[1], &message);
	}

617 618 619 620 621 622 623 624 625 626 627 628 629 630 631 632 633 634 635 636 637 638 639 640 641 642 643 644 645 646 647 648
	/* ... unless someone else is using the pre-allocated buffer */
	if (down_trylock(&lock)) {
		local_buf = kmalloc(SPI_BUFSIZ, GFP_KERNEL);
		if (!local_buf)
			return -ENOMEM;
	} else
		local_buf = buf;

	memcpy(local_buf, txbuf, n_tx);
	x[0].tx_buf = local_buf;
	x[1].rx_buf = local_buf + n_tx;

	/* do the i/o */
	status = spi_sync(spi, &message);
	if (status == 0) {
		memcpy(rxbuf, x[1].rx_buf, n_rx);
		status = message.status;
	}

	if (x[0].tx_buf == buf)
		up(&lock);
	else
		kfree(local_buf);

	return status;
}
EXPORT_SYMBOL_GPL(spi_write_then_read);

/*-------------------------------------------------------------------------*/

static int __init spi_init(void)
{
649 650
	int	status;

651
	buf = kmalloc(SPI_BUFSIZ, GFP_KERNEL);
652 653 654 655 656 657 658 659
	if (!buf) {
		status = -ENOMEM;
		goto err0;
	}

	status = bus_register(&spi_bus_type);
	if (status < 0)
		goto err1;
660

661 662 663
	status = class_register(&spi_master_class);
	if (status < 0)
		goto err2;
664
	return 0;
665 666 667 668 669 670 671 672

err2:
	bus_unregister(&spi_bus_type);
err1:
	kfree(buf);
	buf = NULL;
err0:
	return status;
673
}
674

675 676
/* board_info is normally registered in arch_initcall(),
 * but even essential drivers wait till later
677 678 679 680
 *
 * REVISIT only boardinfo really needs static linking. the rest (device and
 * driver registration) _could_ be dynamically linked (modular) ... costs
 * include needing to have boardinfo data structures be much more public.
681 682 683
 */
subsys_initcall(spi_init);