builtin-timechart.c 46.9 KB
Newer Older
A
Arjan van de Ven 已提交
1 2 3 4 5 6 7 8 9 10 11 12 13 14
/*
 * builtin-timechart.c - make an svg timechart of system activity
 *
 * (C) Copyright 2009 Intel Corporation
 *
 * Authors:
 *     Arjan van de Ven <arjan@linux.intel.com>
 *
 * This program is free software; you can redistribute it and/or
 * modify it under the terms of the GNU General Public License
 * as published by the Free Software Foundation; version 2
 * of the License.
 */

15
#include <errno.h>
16
#include <inttypes.h>
17 18
#include <traceevent/event-parse.h>

A
Arjan van de Ven 已提交
19 20 21 22 23 24 25
#include "builtin.h"

#include "util/util.h"

#include "util/color.h"
#include <linux/list.h>
#include "util/cache.h"
26
#include "util/evlist.h"
27
#include "util/evsel.h"
28
#include <linux/kernel.h>
A
Arjan van de Ven 已提交
29
#include <linux/rbtree.h>
30
#include <linux/time64.h>
A
Arjan van de Ven 已提交
31 32 33 34 35
#include "util/symbol.h"
#include "util/callchain.h"

#include "perf.h"
#include "util/header.h"
36
#include <subcmd/parse-options.h>
A
Arjan van de Ven 已提交
37
#include "util/parse-events.h"
38
#include "util/event.h"
39
#include "util/session.h"
A
Arjan van de Ven 已提交
40
#include "util/svghelper.h"
41
#include "util/tool.h"
42
#include "util/data.h"
43
#include "util/debug.h"
A
Arjan van de Ven 已提交
44

45 46 47
#define SUPPORT_OLD_POWER_EVENTS 1
#define PWR_EVENT_EXIT -1

48
struct per_pid;
49
struct power_event;
50
struct wake_event;
51

52 53
struct timechart {
	struct perf_tool	tool;
54
	struct per_pid		*all_data;
55
	struct power_event	*power_events;
56
	struct wake_event	*wake_events;
57 58 59 60 61 62 63 64
	int			proc_num;
	unsigned int		numcpus;
	u64			min_freq,	/* Lowest CPU frequency seen */
				max_freq,	/* Highest CPU frequency seen */
				turbo_frequency,
				first_time, last_time;
	bool			power_only,
				tasks_only,
65 66
				with_backtrace,
				topology;
67
	bool			force;
68
	/* IO related settings */
69 70
	bool			io_only,
				skip_eagain;
71
	u64			io_events;
72 73
	u64			min_time,
				merge_dist;
74
};
A
Arjan van de Ven 已提交
75 76 77

struct per_pidcomm;
struct cpu_sample;
78
struct io_sample;
A
Arjan van de Ven 已提交
79 80 81 82 83 84 85 86 87 88 89 90 91 92 93 94 95 96 97 98

/*
 * Datastructure layout:
 * We keep an list of "pid"s, matching the kernels notion of a task struct.
 * Each "pid" entry, has a list of "comm"s.
 *	this is because we want to track different programs different, while
 *	exec will reuse the original pid (by design).
 * Each comm has a list of samples that will be used to draw
 * final graph.
 */

struct per_pid {
	struct per_pid *next;

	int		pid;
	int		ppid;

	u64		start_time;
	u64		end_time;
	u64		total_time;
99
	u64		total_bytes;
A
Arjan van de Ven 已提交
100 101 102 103 104 105 106 107 108 109 110 111 112
	int		display;

	struct per_pidcomm *all;
	struct per_pidcomm *current;
};


struct per_pidcomm {
	struct per_pidcomm *next;

	u64		start_time;
	u64		end_time;
	u64		total_time;
113 114
	u64		max_bytes;
	u64		total_bytes;
A
Arjan van de Ven 已提交
115 116 117 118 119 120 121 122 123 124

	int		Y;
	int		display;

	long		state;
	u64		state_since;

	char		*comm;

	struct cpu_sample *samples;
125
	struct io_sample  *io_samples;
A
Arjan van de Ven 已提交
126 127 128 129 130 131 132 133 134 135 136 137 138 139 140 141 142 143 144 145 146
};

struct sample_wrapper {
	struct sample_wrapper *next;

	u64		timestamp;
	unsigned char	data[0];
};

#define TYPE_NONE	0
#define TYPE_RUNNING	1
#define TYPE_WAITING	2
#define TYPE_BLOCKED	3

struct cpu_sample {
	struct cpu_sample *next;

	u64 start_time;
	u64 end_time;
	int type;
	int cpu;
147
	const char *backtrace;
A
Arjan van de Ven 已提交
148 149
};

150 151 152 153 154 155 156 157 158 159 160 161 162 163 164 165 166 167 168 169 170
enum {
	IOTYPE_READ,
	IOTYPE_WRITE,
	IOTYPE_SYNC,
	IOTYPE_TX,
	IOTYPE_RX,
	IOTYPE_POLL,
};

struct io_sample {
	struct io_sample *next;

	u64 start_time;
	u64 end_time;
	u64 bytes;
	int type;
	int fd;
	int err;
	int merges;
};

A
Arjan van de Ven 已提交
171 172 173 174 175 176 177 178 179 180 181 182 183 184 185 186 187
#define CSTATE 1
#define PSTATE 2

struct power_event {
	struct power_event *next;
	int type;
	int state;
	u64 start_time;
	u64 end_time;
	int cpu;
};

struct wake_event {
	struct wake_event *next;
	int waker;
	int wakee;
	u64 time;
188
	const char *backtrace;
A
Arjan van de Ven 已提交
189 190
};

191
struct process_filter {
192 193 194
	char			*name;
	int			pid;
	struct process_filter	*next;
195 196 197 198 199
};

static struct process_filter *process_filter;


200
static struct per_pid *find_create_pid(struct timechart *tchart, int pid)
A
Arjan van de Ven 已提交
201
{
202
	struct per_pid *cursor = tchart->all_data;
A
Arjan van de Ven 已提交
203 204 205 206 207 208

	while (cursor) {
		if (cursor->pid == pid)
			return cursor;
		cursor = cursor->next;
	}
209
	cursor = zalloc(sizeof(*cursor));
A
Arjan van de Ven 已提交
210 211
	assert(cursor != NULL);
	cursor->pid = pid;
212 213
	cursor->next = tchart->all_data;
	tchart->all_data = cursor;
A
Arjan van de Ven 已提交
214 215 216
	return cursor;
}

217
static void pid_set_comm(struct timechart *tchart, int pid, char *comm)
A
Arjan van de Ven 已提交
218 219 220
{
	struct per_pid *p;
	struct per_pidcomm *c;
221
	p = find_create_pid(tchart, pid);
A
Arjan van de Ven 已提交
222 223 224 225 226 227 228 229 230 231 232 233 234
	c = p->all;
	while (c) {
		if (c->comm && strcmp(c->comm, comm) == 0) {
			p->current = c;
			return;
		}
		if (!c->comm) {
			c->comm = strdup(comm);
			p->current = c;
			return;
		}
		c = c->next;
	}
235
	c = zalloc(sizeof(*c));
A
Arjan van de Ven 已提交
236 237 238 239 240 241 242
	assert(c != NULL);
	c->comm = strdup(comm);
	p->current = c;
	c->next = p->all;
	p->all = c;
}

243
static void pid_fork(struct timechart *tchart, int pid, int ppid, u64 timestamp)
A
Arjan van de Ven 已提交
244 245
{
	struct per_pid *p, *pp;
246 247
	p = find_create_pid(tchart, pid);
	pp = find_create_pid(tchart, ppid);
A
Arjan van de Ven 已提交
248 249
	p->ppid = ppid;
	if (pp->current && pp->current->comm && !p->current)
250
		pid_set_comm(tchart, pid, pp->current->comm);
A
Arjan van de Ven 已提交
251 252

	p->start_time = timestamp;
253
	if (p->current && !p->current->start_time) {
A
Arjan van de Ven 已提交
254 255 256 257 258
		p->current->start_time = timestamp;
		p->current->state_since = timestamp;
	}
}

259
static void pid_exit(struct timechart *tchart, int pid, u64 timestamp)
A
Arjan van de Ven 已提交
260 261
{
	struct per_pid *p;
262
	p = find_create_pid(tchart, pid);
A
Arjan van de Ven 已提交
263 264 265 266 267
	p->end_time = timestamp;
	if (p->current)
		p->current->end_time = timestamp;
}

268 269 270
static void pid_put_sample(struct timechart *tchart, int pid, int type,
			   unsigned int cpu, u64 start, u64 end,
			   const char *backtrace)
A
Arjan van de Ven 已提交
271 272 273 274 275
{
	struct per_pid *p;
	struct per_pidcomm *c;
	struct cpu_sample *sample;

276
	p = find_create_pid(tchart, pid);
A
Arjan van de Ven 已提交
277 278
	c = p->current;
	if (!c) {
279
		c = zalloc(sizeof(*c));
A
Arjan van de Ven 已提交
280 281 282 283 284 285
		assert(c != NULL);
		p->current = c;
		c->next = p->all;
		p->all = c;
	}

286
	sample = zalloc(sizeof(*sample));
A
Arjan van de Ven 已提交
287 288 289 290 291 292
	assert(sample != NULL);
	sample->start_time = start;
	sample->end_time = end;
	sample->type = type;
	sample->next = c->samples;
	sample->cpu = cpu;
293
	sample->backtrace = backtrace;
A
Arjan van de Ven 已提交
294 295 296 297 298 299 300 301 302 303 304 305 306 307 308 309 310 311 312 313
	c->samples = sample;

	if (sample->type == TYPE_RUNNING && end > start && start > 0) {
		c->total_time += (end-start);
		p->total_time += (end-start);
	}

	if (c->start_time == 0 || c->start_time > start)
		c->start_time = start;
	if (p->start_time == 0 || p->start_time > start)
		p->start_time = start;
}

#define MAX_CPUS 4096

static u64 cpus_cstate_start_times[MAX_CPUS];
static int cpus_cstate_state[MAX_CPUS];
static u64 cpus_pstate_start_times[MAX_CPUS];
static u64 cpus_pstate_state[MAX_CPUS];

314
static int process_comm_event(struct perf_tool *tool,
315
			      union perf_event *event,
316 317
			      struct perf_sample *sample __maybe_unused,
			      struct machine *machine __maybe_unused)
A
Arjan van de Ven 已提交
318
{
319 320
	struct timechart *tchart = container_of(tool, struct timechart, tool);
	pid_set_comm(tchart, event->comm.tid, event->comm.comm);
A
Arjan van de Ven 已提交
321 322
	return 0;
}
323

324
static int process_fork_event(struct perf_tool *tool,
325
			      union perf_event *event,
326 327
			      struct perf_sample *sample __maybe_unused,
			      struct machine *machine __maybe_unused)
A
Arjan van de Ven 已提交
328
{
329 330
	struct timechart *tchart = container_of(tool, struct timechart, tool);
	pid_fork(tchart, event->fork.pid, event->fork.ppid, event->fork.time);
A
Arjan van de Ven 已提交
331 332 333
	return 0;
}

334
static int process_exit_event(struct perf_tool *tool,
335
			      union perf_event *event,
336 337
			      struct perf_sample *sample __maybe_unused,
			      struct machine *machine __maybe_unused)
A
Arjan van de Ven 已提交
338
{
339 340
	struct timechart *tchart = container_of(tool, struct timechart, tool);
	pid_exit(tchart, event->fork.pid, event->fork.time);
A
Arjan van de Ven 已提交
341 342 343
	return 0;
}

344 345 346 347
#ifdef SUPPORT_OLD_POWER_EVENTS
static int use_old_power_events;
#endif

A
Arjan van de Ven 已提交
348 349 350 351 352 353
static void c_state_start(int cpu, u64 timestamp, int state)
{
	cpus_cstate_start_times[cpu] = timestamp;
	cpus_cstate_state[cpu] = state;
}

354
static void c_state_end(struct timechart *tchart, int cpu, u64 timestamp)
A
Arjan van de Ven 已提交
355
{
356 357
	struct power_event *pwr = zalloc(sizeof(*pwr));

A
Arjan van de Ven 已提交
358 359 360 361 362 363 364 365
	if (!pwr)
		return;

	pwr->state = cpus_cstate_state[cpu];
	pwr->start_time = cpus_cstate_start_times[cpu];
	pwr->end_time = timestamp;
	pwr->cpu = cpu;
	pwr->type = CSTATE;
366
	pwr->next = tchart->power_events;
A
Arjan van de Ven 已提交
367

368
	tchart->power_events = pwr;
A
Arjan van de Ven 已提交
369 370
}

371
static void p_state_change(struct timechart *tchart, int cpu, u64 timestamp, u64 new_freq)
A
Arjan van de Ven 已提交
372 373 374 375 376 377
{
	struct power_event *pwr;

	if (new_freq > 8000000) /* detect invalid data */
		return;

378
	pwr = zalloc(sizeof(*pwr));
A
Arjan van de Ven 已提交
379 380 381 382 383 384 385 386
	if (!pwr)
		return;

	pwr->state = cpus_pstate_state[cpu];
	pwr->start_time = cpus_pstate_start_times[cpu];
	pwr->end_time = timestamp;
	pwr->cpu = cpu;
	pwr->type = PSTATE;
387
	pwr->next = tchart->power_events;
A
Arjan van de Ven 已提交
388 389

	if (!pwr->start_time)
390
		pwr->start_time = tchart->first_time;
A
Arjan van de Ven 已提交
391

392
	tchart->power_events = pwr;
A
Arjan van de Ven 已提交
393 394 395 396

	cpus_pstate_state[cpu] = new_freq;
	cpus_pstate_start_times[cpu] = timestamp;

397 398
	if ((u64)new_freq > tchart->max_freq)
		tchart->max_freq = new_freq;
A
Arjan van de Ven 已提交
399

400 401
	if (new_freq < tchart->min_freq || tchart->min_freq == 0)
		tchart->min_freq = new_freq;
A
Arjan van de Ven 已提交
402

403 404
	if (new_freq == tchart->max_freq - 1000)
		tchart->turbo_frequency = tchart->max_freq;
A
Arjan van de Ven 已提交
405 406
}

407 408
static void sched_wakeup(struct timechart *tchart, int cpu, u64 timestamp,
			 int waker, int wakee, u8 flags, const char *backtrace)
A
Arjan van de Ven 已提交
409 410
{
	struct per_pid *p;
411
	struct wake_event *we = zalloc(sizeof(*we));
A
Arjan van de Ven 已提交
412 413 414 415 416

	if (!we)
		return;

	we->time = timestamp;
417
	we->waker = waker;
418
	we->backtrace = backtrace;
A
Arjan van de Ven 已提交
419

420
	if ((flags & TRACE_FLAG_HARDIRQ) || (flags & TRACE_FLAG_SOFTIRQ))
A
Arjan van de Ven 已提交
421 422
		we->waker = -1;

423
	we->wakee = wakee;
424 425
	we->next = tchart->wake_events;
	tchart->wake_events = we;
426
	p = find_create_pid(tchart, we->wakee);
A
Arjan van de Ven 已提交
427 428 429 430 431 432

	if (p && p->current && p->current->state == TYPE_NONE) {
		p->current->state_since = timestamp;
		p->current->state = TYPE_WAITING;
	}
	if (p && p->current && p->current->state == TYPE_BLOCKED) {
433
		pid_put_sample(tchart, p->pid, p->current->state, cpu,
434
			       p->current->state_since, timestamp, NULL);
A
Arjan van de Ven 已提交
435 436 437 438 439
		p->current->state_since = timestamp;
		p->current->state = TYPE_WAITING;
	}
}

440 441 442
static void sched_switch(struct timechart *tchart, int cpu, u64 timestamp,
			 int prev_pid, int next_pid, u64 prev_state,
			 const char *backtrace)
A
Arjan van de Ven 已提交
443 444 445
{
	struct per_pid *p = NULL, *prev_p;

446
	prev_p = find_create_pid(tchart, prev_pid);
A
Arjan van de Ven 已提交
447

448
	p = find_create_pid(tchart, next_pid);
A
Arjan van de Ven 已提交
449 450

	if (prev_p->current && prev_p->current->state != TYPE_NONE)
451
		pid_put_sample(tchart, prev_pid, TYPE_RUNNING, cpu,
452 453
			       prev_p->current->state_since, timestamp,
			       backtrace);
A
Arjan van de Ven 已提交
454 455
	if (p && p->current) {
		if (p->current->state != TYPE_NONE)
456
			pid_put_sample(tchart, next_pid, p->current->state, cpu,
457 458
				       p->current->state_since, timestamp,
				       backtrace);
A
Arjan van de Ven 已提交
459

460 461
		p->current->state_since = timestamp;
		p->current->state = TYPE_RUNNING;
A
Arjan van de Ven 已提交
462 463 464 465 466
	}

	if (prev_p->current) {
		prev_p->current->state = TYPE_NONE;
		prev_p->current->state_since = timestamp;
467
		if (prev_state & 2)
A
Arjan van de Ven 已提交
468
			prev_p->current->state = TYPE_BLOCKED;
469
		if (prev_state == 0)
A
Arjan van de Ven 已提交
470 471 472 473
			prev_p->current->state = TYPE_WAITING;
	}
}

474 475 476 477 478 479 480 481 482 483 484 485 486 487 488 489 490 491 492 493 494
static const char *cat_backtrace(union perf_event *event,
				 struct perf_sample *sample,
				 struct machine *machine)
{
	struct addr_location al;
	unsigned int i;
	char *p = NULL;
	size_t p_len;
	u8 cpumode = PERF_RECORD_MISC_USER;
	struct addr_location tal;
	struct ip_callchain *chain = sample->callchain;
	FILE *f = open_memstream(&p, &p_len);

	if (!f) {
		perror("open_memstream error");
		return NULL;
	}

	if (!chain)
		goto exit;

495
	if (machine__resolve(machine, &al, sample) < 0) {
496 497 498 499 500 501 502 503 504 505 506 507 508 509 510 511 512 513 514 515 516 517 518 519 520 521 522 523 524 525 526 527
		fprintf(stderr, "problem processing %d event, skipping it.\n",
			event->header.type);
		goto exit;
	}

	for (i = 0; i < chain->nr; i++) {
		u64 ip;

		if (callchain_param.order == ORDER_CALLEE)
			ip = chain->ips[i];
		else
			ip = chain->ips[chain->nr - i - 1];

		if (ip >= PERF_CONTEXT_MAX) {
			switch (ip) {
			case PERF_CONTEXT_HV:
				cpumode = PERF_RECORD_MISC_HYPERVISOR;
				break;
			case PERF_CONTEXT_KERNEL:
				cpumode = PERF_RECORD_MISC_KERNEL;
				break;
			case PERF_CONTEXT_USER:
				cpumode = PERF_RECORD_MISC_USER;
				break;
			default:
				pr_debug("invalid callchain context: "
					 "%"PRId64"\n", (s64) ip);

				/*
				 * It seems the callchain is corrupted.
				 * Discard all.
				 */
528
				zfree(&p);
529
				goto exit_put;
530 531 532 533
			}
			continue;
		}

534
		tal.filtered = 0;
535
		thread__find_addr_location(al.thread, cpumode,
536 537 538 539 540 541 542 543
					   MAP__FUNCTION, ip, &tal);

		if (tal.sym)
			fprintf(f, "..... %016" PRIx64 " %s\n", ip,
				tal.sym->name);
		else
			fprintf(f, "..... %016" PRIx64 "\n", ip);
	}
544 545
exit_put:
	addr_location__put(&al);
546 547 548 549 550 551
exit:
	fclose(f);

	return p;
}

552 553
typedef int (*tracepoint_handler)(struct timechart *tchart,
				  struct perf_evsel *evsel,
554 555
				  struct perf_sample *sample,
				  const char *backtrace);
A
Arjan van de Ven 已提交
556

557
static int process_sample_event(struct perf_tool *tool,
558
				union perf_event *event,
559
				struct perf_sample *sample,
560
				struct perf_evsel *evsel,
561
				struct machine *machine)
A
Arjan van de Ven 已提交
562
{
563 564
	struct timechart *tchart = container_of(tool, struct timechart, tool);

565
	if (evsel->attr.sample_type & PERF_SAMPLE_TIME) {
566 567 568 569
		if (!tchart->first_time || tchart->first_time > sample->time)
			tchart->first_time = sample->time;
		if (tchart->last_time < sample->time)
			tchart->last_time = sample->time;
A
Arjan van de Ven 已提交
570
	}
571

572 573
	if (evsel->handler != NULL) {
		tracepoint_handler f = evsel->handler;
574 575
		return f(tchart, evsel, sample,
			 cat_backtrace(event, sample, machine));
576 577 578 579 580 581
	}

	return 0;
}

static int
582 583
process_sample_cpu_idle(struct timechart *tchart __maybe_unused,
			struct perf_evsel *evsel,
584 585
			struct perf_sample *sample,
			const char *backtrace __maybe_unused)
586
{
587 588
	u32 state = perf_evsel__intval(evsel, sample, "state");
	u32 cpu_id = perf_evsel__intval(evsel, sample, "cpu_id");
589

590
	if (state == (u32)PWR_EVENT_EXIT)
591
		c_state_end(tchart, cpu_id, sample->time);
592
	else
593
		c_state_start(cpu_id, sample->time, state);
594 595 596 597
	return 0;
}

static int
598 599
process_sample_cpu_frequency(struct timechart *tchart,
			     struct perf_evsel *evsel,
600 601
			     struct perf_sample *sample,
			     const char *backtrace __maybe_unused)
602
{
603 604
	u32 state = perf_evsel__intval(evsel, sample, "state");
	u32 cpu_id = perf_evsel__intval(evsel, sample, "cpu_id");
605

606
	p_state_change(tchart, cpu_id, sample->time, state);
607 608 609 610
	return 0;
}

static int
611
process_sample_sched_wakeup(struct timechart *tchart,
612
			    struct perf_evsel *evsel,
613 614
			    struct perf_sample *sample,
			    const char *backtrace)
615
{
616 617 618
	u8 flags = perf_evsel__intval(evsel, sample, "common_flags");
	int waker = perf_evsel__intval(evsel, sample, "common_pid");
	int wakee = perf_evsel__intval(evsel, sample, "pid");
619

620
	sched_wakeup(tchart, sample->cpu, sample->time, waker, wakee, flags, backtrace);
621 622
	return 0;
}
A
Arjan van de Ven 已提交
623

624
static int
625
process_sample_sched_switch(struct timechart *tchart,
626
			    struct perf_evsel *evsel,
627 628
			    struct perf_sample *sample,
			    const char *backtrace)
629
{
630 631 632
	int prev_pid = perf_evsel__intval(evsel, sample, "prev_pid");
	int next_pid = perf_evsel__intval(evsel, sample, "next_pid");
	u64 prev_state = perf_evsel__intval(evsel, sample, "prev_state");
A
Arjan van de Ven 已提交
633

634 635
	sched_switch(tchart, sample->cpu, sample->time, prev_pid, next_pid,
		     prev_state, backtrace);
636 637
	return 0;
}
638 639

#ifdef SUPPORT_OLD_POWER_EVENTS
640
static int
641 642
process_sample_power_start(struct timechart *tchart __maybe_unused,
			   struct perf_evsel *evsel,
643 644
			   struct perf_sample *sample,
			   const char *backtrace __maybe_unused)
645
{
646 647
	u64 cpu_id = perf_evsel__intval(evsel, sample, "cpu_id");
	u64 value = perf_evsel__intval(evsel, sample, "value");
648

649
	c_state_start(cpu_id, sample->time, value);
650 651 652 653
	return 0;
}

static int
654
process_sample_power_end(struct timechart *tchart,
655
			 struct perf_evsel *evsel __maybe_unused,
656 657
			 struct perf_sample *sample,
			 const char *backtrace __maybe_unused)
658
{
659
	c_state_end(tchart, sample->cpu, sample->time);
660 661 662 663
	return 0;
}

static int
664 665
process_sample_power_frequency(struct timechart *tchart,
			       struct perf_evsel *evsel,
666 667
			       struct perf_sample *sample,
			       const char *backtrace __maybe_unused)
668
{
669 670
	u64 cpu_id = perf_evsel__intval(evsel, sample, "cpu_id");
	u64 value = perf_evsel__intval(evsel, sample, "value");
671

672
	p_state_change(tchart, cpu_id, sample->time, value);
A
Arjan van de Ven 已提交
673 674
	return 0;
}
675
#endif /* SUPPORT_OLD_POWER_EVENTS */
A
Arjan van de Ven 已提交
676 677 678 679 680

/*
 * After the last sample we need to wrap up the current C/P state
 * and close out each CPU for these.
 */
681
static void end_sample_processing(struct timechart *tchart)
A
Arjan van de Ven 已提交
682 683 684 685
{
	u64 cpu;
	struct power_event *pwr;

686
	for (cpu = 0; cpu <= tchart->numcpus; cpu++) {
687 688 689
		/* C state */
#if 0
		pwr = zalloc(sizeof(*pwr));
A
Arjan van de Ven 已提交
690 691 692 693 694
		if (!pwr)
			return;

		pwr->state = cpus_cstate_state[cpu];
		pwr->start_time = cpus_cstate_start_times[cpu];
695
		pwr->end_time = tchart->last_time;
A
Arjan van de Ven 已提交
696 697
		pwr->cpu = cpu;
		pwr->type = CSTATE;
698
		pwr->next = tchart->power_events;
A
Arjan van de Ven 已提交
699

700
		tchart->power_events = pwr;
A
Arjan van de Ven 已提交
701 702 703
#endif
		/* P state */

704
		pwr = zalloc(sizeof(*pwr));
A
Arjan van de Ven 已提交
705 706 707 708 709
		if (!pwr)
			return;

		pwr->state = cpus_pstate_state[cpu];
		pwr->start_time = cpus_pstate_start_times[cpu];
710
		pwr->end_time = tchart->last_time;
A
Arjan van de Ven 已提交
711 712
		pwr->cpu = cpu;
		pwr->type = PSTATE;
713
		pwr->next = tchart->power_events;
A
Arjan van de Ven 已提交
714 715

		if (!pwr->start_time)
716
			pwr->start_time = tchart->first_time;
A
Arjan van de Ven 已提交
717
		if (!pwr->state)
718
			pwr->state = tchart->min_freq;
719
		tchart->power_events = pwr;
A
Arjan van de Ven 已提交
720 721 722
	}
}

723 724 725 726 727 728 729 730 731 732 733 734 735 736 737 738 739 740 741 742 743 744 745 746 747 748 749 750 751 752 753 754 755 756 757 758 759 760 761 762 763 764 765 766 767 768 769 770 771 772
static int pid_begin_io_sample(struct timechart *tchart, int pid, int type,
			       u64 start, int fd)
{
	struct per_pid *p = find_create_pid(tchart, pid);
	struct per_pidcomm *c = p->current;
	struct io_sample *sample;
	struct io_sample *prev;

	if (!c) {
		c = zalloc(sizeof(*c));
		if (!c)
			return -ENOMEM;
		p->current = c;
		c->next = p->all;
		p->all = c;
	}

	prev = c->io_samples;

	if (prev && prev->start_time && !prev->end_time) {
		pr_warning("Skip invalid start event: "
			   "previous event already started!\n");

		/* remove previous event that has been started,
		 * we are not sure we will ever get an end for it */
		c->io_samples = prev->next;
		free(prev);
		return 0;
	}

	sample = zalloc(sizeof(*sample));
	if (!sample)
		return -ENOMEM;
	sample->start_time = start;
	sample->type = type;
	sample->fd = fd;
	sample->next = c->io_samples;
	c->io_samples = sample;

	if (c->start_time == 0 || c->start_time > start)
		c->start_time = start;

	return 0;
}

static int pid_end_io_sample(struct timechart *tchart, int pid, int type,
			     u64 end, long ret)
{
	struct per_pid *p = find_create_pid(tchart, pid);
	struct per_pidcomm *c = p->current;
773
	struct io_sample *sample, *prev;
774 775 776 777 778 779 780 781 782 783 784 785 786 787 788 789 790 791 792 793 794 795 796

	if (!c) {
		pr_warning("Invalid pidcomm!\n");
		return -1;
	}

	sample = c->io_samples;

	if (!sample) /* skip partially captured events */
		return 0;

	if (sample->end_time) {
		pr_warning("Skip invalid end event: "
			   "previous event already ended!\n");
		return 0;
	}

	if (sample->type != type) {
		pr_warning("Skip invalid end event: invalid event type!\n");
		return 0;
	}

	sample->end_time = end;
797 798 799 800 801 802 803 804 805 806 807 808
	prev = sample->next;

	/* we want to be able to see small and fast transfers, so make them
	 * at least min_time long, but don't overlap them */
	if (sample->end_time - sample->start_time < tchart->min_time)
		sample->end_time = sample->start_time + tchart->min_time;
	if (prev && sample->start_time < prev->end_time) {
		if (prev->err) /* try to make errors more visible */
			sample->start_time = prev->end_time;
		else
			prev->end_time = sample->start_time;
	}
809 810 811 812 813 814 815 816 817 818 819 820 821 822

	if (ret < 0) {
		sample->err = ret;
	} else if (type == IOTYPE_READ || type == IOTYPE_WRITE ||
		   type == IOTYPE_TX || type == IOTYPE_RX) {

		if ((u64)ret > c->max_bytes)
			c->max_bytes = ret;

		c->total_bytes += ret;
		p->total_bytes += ret;
		sample->bytes = ret;
	}

823 824 825 826 827 828 829 830 831 832 833 834 835 836 837 838 839 840
	/* merge two requests to make svg smaller and render-friendly */
	if (prev &&
	    prev->type == sample->type &&
	    prev->err == sample->err &&
	    prev->fd == sample->fd &&
	    prev->end_time + tchart->merge_dist >= sample->start_time) {

		sample->bytes += prev->bytes;
		sample->merges += prev->merges + 1;

		sample->start_time = prev->start_time;
		sample->next = prev->next;
		free(prev);

		if (!sample->err && sample->bytes > c->max_bytes)
			c->max_bytes = sample->bytes;
	}

841 842 843 844 845 846 847 848 849 850 851 852 853 854 855 856 857 858 859 860 861 862 863 864 865 866 867 868 869 870 871 872 873 874 875 876 877 878 879 880 881 882 883 884 885 886 887 888 889 890 891 892 893 894 895 896 897 898 899 900 901 902 903 904 905 906 907 908 909 910 911 912 913 914 915 916 917 918 919 920 921 922 923 924 925 926 927 928 929 930 931 932 933 934 935 936 937 938 939 940 941 942 943 944 945 946 947 948 949 950 951 952 953 954 955 956 957 958 959 960 961 962 963 964 965
	tchart->io_events++;

	return 0;
}

static int
process_enter_read(struct timechart *tchart,
		   struct perf_evsel *evsel,
		   struct perf_sample *sample)
{
	long fd = perf_evsel__intval(evsel, sample, "fd");
	return pid_begin_io_sample(tchart, sample->tid, IOTYPE_READ,
				   sample->time, fd);
}

static int
process_exit_read(struct timechart *tchart,
		  struct perf_evsel *evsel,
		  struct perf_sample *sample)
{
	long ret = perf_evsel__intval(evsel, sample, "ret");
	return pid_end_io_sample(tchart, sample->tid, IOTYPE_READ,
				 sample->time, ret);
}

static int
process_enter_write(struct timechart *tchart,
		    struct perf_evsel *evsel,
		    struct perf_sample *sample)
{
	long fd = perf_evsel__intval(evsel, sample, "fd");
	return pid_begin_io_sample(tchart, sample->tid, IOTYPE_WRITE,
				   sample->time, fd);
}

static int
process_exit_write(struct timechart *tchart,
		   struct perf_evsel *evsel,
		   struct perf_sample *sample)
{
	long ret = perf_evsel__intval(evsel, sample, "ret");
	return pid_end_io_sample(tchart, sample->tid, IOTYPE_WRITE,
				 sample->time, ret);
}

static int
process_enter_sync(struct timechart *tchart,
		   struct perf_evsel *evsel,
		   struct perf_sample *sample)
{
	long fd = perf_evsel__intval(evsel, sample, "fd");
	return pid_begin_io_sample(tchart, sample->tid, IOTYPE_SYNC,
				   sample->time, fd);
}

static int
process_exit_sync(struct timechart *tchart,
		  struct perf_evsel *evsel,
		  struct perf_sample *sample)
{
	long ret = perf_evsel__intval(evsel, sample, "ret");
	return pid_end_io_sample(tchart, sample->tid, IOTYPE_SYNC,
				 sample->time, ret);
}

static int
process_enter_tx(struct timechart *tchart,
		 struct perf_evsel *evsel,
		 struct perf_sample *sample)
{
	long fd = perf_evsel__intval(evsel, sample, "fd");
	return pid_begin_io_sample(tchart, sample->tid, IOTYPE_TX,
				   sample->time, fd);
}

static int
process_exit_tx(struct timechart *tchart,
		struct perf_evsel *evsel,
		struct perf_sample *sample)
{
	long ret = perf_evsel__intval(evsel, sample, "ret");
	return pid_end_io_sample(tchart, sample->tid, IOTYPE_TX,
				 sample->time, ret);
}

static int
process_enter_rx(struct timechart *tchart,
		 struct perf_evsel *evsel,
		 struct perf_sample *sample)
{
	long fd = perf_evsel__intval(evsel, sample, "fd");
	return pid_begin_io_sample(tchart, sample->tid, IOTYPE_RX,
				   sample->time, fd);
}

static int
process_exit_rx(struct timechart *tchart,
		struct perf_evsel *evsel,
		struct perf_sample *sample)
{
	long ret = perf_evsel__intval(evsel, sample, "ret");
	return pid_end_io_sample(tchart, sample->tid, IOTYPE_RX,
				 sample->time, ret);
}

static int
process_enter_poll(struct timechart *tchart,
		   struct perf_evsel *evsel,
		   struct perf_sample *sample)
{
	long fd = perf_evsel__intval(evsel, sample, "fd");
	return pid_begin_io_sample(tchart, sample->tid, IOTYPE_POLL,
				   sample->time, fd);
}

static int
process_exit_poll(struct timechart *tchart,
		  struct perf_evsel *evsel,
		  struct perf_sample *sample)
{
	long ret = perf_evsel__intval(evsel, sample, "ret");
	return pid_end_io_sample(tchart, sample->tid, IOTYPE_POLL,
				 sample->time, ret);
}

A
Arjan van de Ven 已提交
966 967 968
/*
 * Sort the pid datastructure
 */
969
static void sort_pids(struct timechart *tchart)
A
Arjan van de Ven 已提交
970 971 972 973 974 975
{
	struct per_pid *new_list, *p, *cursor, *prev;
	/* sort by ppid first, then by pid, lowest to highest */

	new_list = NULL;

976 977 978
	while (tchart->all_data) {
		p = tchart->all_data;
		tchart->all_data = p->next;
A
Arjan van de Ven 已提交
979 980 981 982 983 984 985 986 987 988 989 990 991 992 993 994 995 996 997 998 999 1000 1001 1002 1003 1004 1005 1006 1007 1008 1009 1010
		p->next = NULL;

		if (new_list == NULL) {
			new_list = p;
			p->next = NULL;
			continue;
		}
		prev = NULL;
		cursor = new_list;
		while (cursor) {
			if (cursor->ppid > p->ppid ||
				(cursor->ppid == p->ppid && cursor->pid > p->pid)) {
				/* must insert before */
				if (prev) {
					p->next = prev->next;
					prev->next = p;
					cursor = NULL;
					continue;
				} else {
					p->next = new_list;
					new_list = p;
					cursor = NULL;
					continue;
				}
			}

			prev = cursor;
			cursor = cursor->next;
			if (!cursor)
				prev->next = p;
		}
	}
1011
	tchart->all_data = new_list;
A
Arjan van de Ven 已提交
1012 1013 1014
}


1015
static void draw_c_p_states(struct timechart *tchart)
A
Arjan van de Ven 已提交
1016 1017
{
	struct power_event *pwr;
1018
	pwr = tchart->power_events;
A
Arjan van de Ven 已提交
1019 1020 1021 1022 1023 1024 1025 1026 1027 1028

	/*
	 * two pass drawing so that the P state bars are on top of the C state blocks
	 */
	while (pwr) {
		if (pwr->type == CSTATE)
			svg_cstate(pwr->cpu, pwr->start_time, pwr->end_time, pwr->state);
		pwr = pwr->next;
	}

1029
	pwr = tchart->power_events;
A
Arjan van de Ven 已提交
1030 1031 1032
	while (pwr) {
		if (pwr->type == PSTATE) {
			if (!pwr->state)
1033
				pwr->state = tchart->min_freq;
A
Arjan van de Ven 已提交
1034 1035 1036 1037 1038 1039
			svg_pstate(pwr->cpu, pwr->start_time, pwr->end_time, pwr->state);
		}
		pwr = pwr->next;
	}
}

1040
static void draw_wakeups(struct timechart *tchart)
A
Arjan van de Ven 已提交
1041 1042 1043 1044 1045
{
	struct wake_event *we;
	struct per_pid *p;
	struct per_pidcomm *c;

1046
	we = tchart->wake_events;
A
Arjan van de Ven 已提交
1047 1048
	while (we) {
		int from = 0, to = 0;
1049
		char *task_from = NULL, *task_to = NULL;
A
Arjan van de Ven 已提交
1050 1051

		/* locate the column of the waker and wakee */
1052
		p = tchart->all_data;
A
Arjan van de Ven 已提交
1053 1054 1055 1056 1057
		while (p) {
			if (p->pid == we->waker || p->pid == we->wakee) {
				c = p->all;
				while (c) {
					if (c->Y && c->start_time <= we->time && c->end_time >= we->time) {
1058
						if (p->pid == we->waker && !from) {
A
Arjan van de Ven 已提交
1059
							from = c->Y;
1060
							task_from = strdup(c->comm);
1061
						}
1062
						if (p->pid == we->wakee && !to) {
A
Arjan van de Ven 已提交
1063
							to = c->Y;
1064
							task_to = strdup(c->comm);
1065
						}
A
Arjan van de Ven 已提交
1066 1067 1068
					}
					c = c->next;
				}
1069 1070 1071 1072 1073 1074 1075 1076 1077 1078 1079 1080
				c = p->all;
				while (c) {
					if (p->pid == we->waker && !from) {
						from = c->Y;
						task_from = strdup(c->comm);
					}
					if (p->pid == we->wakee && !to) {
						to = c->Y;
						task_to = strdup(c->comm);
					}
					c = c->next;
				}
A
Arjan van de Ven 已提交
1081 1082 1083 1084
			}
			p = p->next;
		}

1085 1086 1087 1088 1089 1090 1091 1092 1093
		if (!task_from) {
			task_from = malloc(40);
			sprintf(task_from, "[%i]", we->waker);
		}
		if (!task_to) {
			task_to = malloc(40);
			sprintf(task_to, "[%i]", we->wakee);
		}

A
Arjan van de Ven 已提交
1094
		if (we->waker == -1)
1095
			svg_interrupt(we->time, to, we->backtrace);
A
Arjan van de Ven 已提交
1096
		else if (from && to && abs(from - to) == 1)
1097
			svg_wakeline(we->time, from, to, we->backtrace);
A
Arjan van de Ven 已提交
1098
		else
1099 1100
			svg_partial_wakeline(we->time, from, task_from, to,
					     task_to, we->backtrace);
A
Arjan van de Ven 已提交
1101
		we = we->next;
1102 1103 1104

		free(task_from);
		free(task_to);
A
Arjan van de Ven 已提交
1105 1106 1107
	}
}

1108
static void draw_cpu_usage(struct timechart *tchart)
A
Arjan van de Ven 已提交
1109 1110 1111 1112
{
	struct per_pid *p;
	struct per_pidcomm *c;
	struct cpu_sample *sample;
1113
	p = tchart->all_data;
A
Arjan van de Ven 已提交
1114 1115 1116 1117 1118
	while (p) {
		c = p->all;
		while (c) {
			sample = c->samples;
			while (sample) {
1119 1120 1121 1122
				if (sample->type == TYPE_RUNNING) {
					svg_process(sample->cpu,
						    sample->start_time,
						    sample->end_time,
1123
						    p->pid,
1124 1125 1126
						    c->comm,
						    sample->backtrace);
				}
A
Arjan van de Ven 已提交
1127 1128 1129 1130 1131 1132 1133 1134 1135

				sample = sample->next;
			}
			c = c->next;
		}
		p = p->next;
	}
}

1136 1137 1138 1139 1140 1141 1142 1143 1144 1145 1146 1147 1148 1149 1150 1151 1152 1153 1154 1155 1156 1157 1158 1159 1160
static void draw_io_bars(struct timechart *tchart)
{
	const char *suf;
	double bytes;
	char comm[256];
	struct per_pid *p;
	struct per_pidcomm *c;
	struct io_sample *sample;
	int Y = 1;

	p = tchart->all_data;
	while (p) {
		c = p->all;
		while (c) {
			if (!c->display) {
				c->Y = 0;
				c = c->next;
				continue;
			}

			svg_box(Y, c->start_time, c->end_time, "process3");
			sample = c->io_samples;
			for (sample = c->io_samples; sample; sample = sample->next) {
				double h = (double)sample->bytes / c->max_bytes;

1161 1162 1163 1164
				if (tchart->skip_eagain &&
				    sample->err == -EAGAIN)
					continue;

1165 1166 1167 1168 1169 1170 1171 1172 1173 1174 1175 1176 1177 1178 1179 1180 1181 1182 1183 1184 1185 1186 1187 1188 1189 1190 1191 1192 1193 1194 1195 1196 1197 1198 1199 1200 1201 1202 1203 1204 1205 1206 1207 1208 1209 1210 1211 1212 1213 1214 1215 1216 1217 1218 1219 1220 1221 1222 1223 1224 1225 1226 1227 1228 1229 1230 1231 1232 1233 1234 1235 1236 1237 1238 1239 1240 1241 1242 1243 1244 1245 1246 1247 1248 1249 1250
				if (sample->err)
					h = 1;

				if (sample->type == IOTYPE_SYNC)
					svg_fbox(Y,
						sample->start_time,
						sample->end_time,
						1,
						sample->err ? "error" : "sync",
						sample->fd,
						sample->err,
						sample->merges);
				else if (sample->type == IOTYPE_POLL)
					svg_fbox(Y,
						sample->start_time,
						sample->end_time,
						1,
						sample->err ? "error" : "poll",
						sample->fd,
						sample->err,
						sample->merges);
				else if (sample->type == IOTYPE_READ)
					svg_ubox(Y,
						sample->start_time,
						sample->end_time,
						h,
						sample->err ? "error" : "disk",
						sample->fd,
						sample->err,
						sample->merges);
				else if (sample->type == IOTYPE_WRITE)
					svg_lbox(Y,
						sample->start_time,
						sample->end_time,
						h,
						sample->err ? "error" : "disk",
						sample->fd,
						sample->err,
						sample->merges);
				else if (sample->type == IOTYPE_RX)
					svg_ubox(Y,
						sample->start_time,
						sample->end_time,
						h,
						sample->err ? "error" : "net",
						sample->fd,
						sample->err,
						sample->merges);
				else if (sample->type == IOTYPE_TX)
					svg_lbox(Y,
						sample->start_time,
						sample->end_time,
						h,
						sample->err ? "error" : "net",
						sample->fd,
						sample->err,
						sample->merges);
			}

			suf = "";
			bytes = c->total_bytes;
			if (bytes > 1024) {
				bytes = bytes / 1024;
				suf = "K";
			}
			if (bytes > 1024) {
				bytes = bytes / 1024;
				suf = "M";
			}
			if (bytes > 1024) {
				bytes = bytes / 1024;
				suf = "G";
			}


			sprintf(comm, "%s:%i (%3.1f %sbytes)", c->comm ?: "", p->pid, bytes, suf);
			svg_text(Y, c->start_time, comm);

			c->Y = Y;
			Y++;
			c = c->next;
		}
		p = p->next;
	}
}

1251
static void draw_process_bars(struct timechart *tchart)
A
Arjan van de Ven 已提交
1252 1253 1254 1255 1256 1257
{
	struct per_pid *p;
	struct per_pidcomm *c;
	struct cpu_sample *sample;
	int Y = 0;

1258
	Y = 2 * tchart->numcpus + 2;
A
Arjan van de Ven 已提交
1259

1260
	p = tchart->all_data;
A
Arjan van de Ven 已提交
1261 1262 1263 1264 1265 1266 1267 1268 1269
	while (p) {
		c = p->all;
		while (c) {
			if (!c->display) {
				c->Y = 0;
				c = c->next;
				continue;
			}

1270
			svg_box(Y, c->start_time, c->end_time, "process");
A
Arjan van de Ven 已提交
1271 1272 1273
			sample = c->samples;
			while (sample) {
				if (sample->type == TYPE_RUNNING)
1274 1275 1276 1277
					svg_running(Y, sample->cpu,
						    sample->start_time,
						    sample->end_time,
						    sample->backtrace);
A
Arjan van de Ven 已提交
1278
				if (sample->type == TYPE_BLOCKED)
1279 1280 1281 1282
					svg_blocked(Y, sample->cpu,
						    sample->start_time,
						    sample->end_time,
						    sample->backtrace);
A
Arjan van de Ven 已提交
1283
				if (sample->type == TYPE_WAITING)
1284 1285 1286 1287
					svg_waiting(Y, sample->cpu,
						    sample->start_time,
						    sample->end_time,
						    sample->backtrace);
A
Arjan van de Ven 已提交
1288 1289 1290 1291 1292 1293
				sample = sample->next;
			}

			if (c->comm) {
				char comm[256];
				if (c->total_time > 5000000000) /* 5 seconds */
1294
					sprintf(comm, "%s:%i (%2.2fs)", c->comm, p->pid, c->total_time / (double)NSEC_PER_SEC);
A
Arjan van de Ven 已提交
1295
				else
1296
					sprintf(comm, "%s:%i (%3.1fms)", c->comm, p->pid, c->total_time / (double)NSEC_PER_MSEC);
A
Arjan van de Ven 已提交
1297 1298 1299 1300 1301 1302 1303 1304 1305 1306 1307

				svg_text(Y, c->start_time, comm);
			}
			c->Y = Y;
			Y++;
			c = c->next;
		}
		p = p->next;
	}
}

1308 1309
static void add_process_filter(const char *string)
{
1310 1311
	int pid = strtoull(string, NULL, 10);
	struct process_filter *filt = malloc(sizeof(*filt));
1312 1313 1314 1315 1316 1317 1318 1319 1320 1321 1322 1323 1324 1325 1326 1327 1328 1329 1330 1331 1332 1333 1334 1335 1336 1337 1338 1339

	if (!filt)
		return;

	filt->name = strdup(string);
	filt->pid  = pid;
	filt->next = process_filter;

	process_filter = filt;
}

static int passes_filter(struct per_pid *p, struct per_pidcomm *c)
{
	struct process_filter *filt;
	if (!process_filter)
		return 1;

	filt = process_filter;
	while (filt) {
		if (filt->pid && p->pid == filt->pid)
			return 1;
		if (strcmp(filt->name, c->comm) == 0)
			return 1;
		filt = filt->next;
	}
	return 0;
}

1340
static int determine_display_tasks_filtered(struct timechart *tchart)
1341 1342 1343 1344 1345
{
	struct per_pid *p;
	struct per_pidcomm *c;
	int count = 0;

1346
	p = tchart->all_data;
1347 1348 1349
	while (p) {
		p->display = 0;
		if (p->start_time == 1)
1350
			p->start_time = tchart->first_time;
1351 1352 1353

		/* no exit marker, task kept running to the end */
		if (p->end_time == 0)
1354
			p->end_time = tchart->last_time;
1355 1356 1357 1358 1359 1360 1361

		c = p->all;

		while (c) {
			c->display = 0;

			if (c->start_time == 1)
1362
				c->start_time = tchart->first_time;
1363 1364 1365 1366 1367 1368 1369 1370

			if (passes_filter(p, c)) {
				c->display = 1;
				p->display = 1;
				count++;
			}

			if (c->end_time == 0)
1371
				c->end_time = tchart->last_time;
1372 1373 1374 1375 1376 1377 1378 1379

			c = c->next;
		}
		p = p->next;
	}
	return count;
}

1380
static int determine_display_tasks(struct timechart *tchart, u64 threshold)
A
Arjan van de Ven 已提交
1381 1382 1383 1384 1385
{
	struct per_pid *p;
	struct per_pidcomm *c;
	int count = 0;

1386
	p = tchart->all_data;
A
Arjan van de Ven 已提交
1387 1388 1389
	while (p) {
		p->display = 0;
		if (p->start_time == 1)
1390
			p->start_time = tchart->first_time;
A
Arjan van de Ven 已提交
1391 1392 1393

		/* no exit marker, task kept running to the end */
		if (p->end_time == 0)
1394
			p->end_time = tchart->last_time;
1395
		if (p->total_time >= threshold)
A
Arjan van de Ven 已提交
1396 1397 1398 1399 1400 1401 1402 1403
			p->display = 1;

		c = p->all;

		while (c) {
			c->display = 0;

			if (c->start_time == 1)
1404
				c->start_time = tchart->first_time;
A
Arjan van de Ven 已提交
1405

1406
			if (c->total_time >= threshold) {
A
Arjan van de Ven 已提交
1407 1408 1409 1410 1411
				c->display = 1;
				count++;
			}

			if (c->end_time == 0)
1412
				c->end_time = tchart->last_time;
A
Arjan van de Ven 已提交
1413 1414 1415 1416 1417 1418 1419 1420

			c = c->next;
		}
		p = p->next;
	}
	return count;
}

1421 1422 1423 1424 1425 1426 1427 1428 1429 1430 1431 1432 1433 1434 1435 1436 1437 1438 1439 1440 1441
static int determine_display_io_tasks(struct timechart *timechart, u64 threshold)
{
	struct per_pid *p;
	struct per_pidcomm *c;
	int count = 0;

	p = timechart->all_data;
	while (p) {
		/* no exit marker, task kept running to the end */
		if (p->end_time == 0)
			p->end_time = timechart->last_time;

		c = p->all;

		while (c) {
			c->display = 0;

			if (c->total_bytes >= threshold) {
				c->display = 1;
				count++;
			}
A
Arjan van de Ven 已提交
1442

1443 1444 1445 1446 1447 1448 1449 1450 1451
			if (c->end_time == 0)
				c->end_time = timechart->last_time;

			c = c->next;
		}
		p = p->next;
	}
	return count;
}
A
Arjan van de Ven 已提交
1452

1453
#define BYTES_THRESH (1 * 1024 * 1024)
A
Arjan van de Ven 已提交
1454 1455
#define TIME_THRESH 10000000

1456
static void write_svg_file(struct timechart *tchart, const char *filename)
A
Arjan van de Ven 已提交
1457 1458 1459
{
	u64 i;
	int count;
1460
	int thresh = tchart->io_events ? BYTES_THRESH : TIME_THRESH;
A
Arjan van de Ven 已提交
1461

1462 1463
	if (tchart->power_only)
		tchart->proc_num = 0;
A
Arjan van de Ven 已提交
1464

1465 1466 1467
	/* We'd like to show at least proc_num tasks;
	 * be less picky if we have fewer */
	do {
1468 1469 1470 1471 1472 1473
		if (process_filter)
			count = determine_display_tasks_filtered(tchart);
		else if (tchart->io_events)
			count = determine_display_io_tasks(tchart, thresh);
		else
			count = determine_display_tasks(tchart, thresh);
1474
		thresh /= 10;
1475
	} while (!process_filter && thresh && count < tchart->proc_num);
A
Arjan van de Ven 已提交
1476

1477 1478 1479
	if (!tchart->proc_num)
		count = 0;

1480 1481
	if (tchart->io_events) {
		open_svg(filename, 0, count, tchart->first_time, tchart->last_time);
A
Arjan van de Ven 已提交
1482

1483 1484
		svg_time_grid(0.5);
		svg_io_legenda();
A
Arjan van de Ven 已提交
1485

1486 1487 1488
		draw_io_bars(tchart);
	} else {
		open_svg(filename, tchart->numcpus, count, tchart->first_time, tchart->last_time);
A
Arjan van de Ven 已提交
1489

1490 1491 1492 1493 1494 1495 1496 1497 1498 1499 1500 1501 1502 1503 1504
		svg_time_grid(0);

		svg_legenda();

		for (i = 0; i < tchart->numcpus; i++)
			svg_cpu_box(i, tchart->max_freq, tchart->turbo_frequency);

		draw_cpu_usage(tchart);
		if (tchart->proc_num)
			draw_process_bars(tchart);
		if (!tchart->tasks_only)
			draw_c_p_states(tchart);
		if (tchart->proc_num)
			draw_wakeups(tchart);
	}
A
Arjan van de Ven 已提交
1505 1506 1507 1508

	svg_close();
}

1509 1510 1511 1512 1513 1514 1515 1516 1517 1518 1519 1520
static int process_header(struct perf_file_section *section __maybe_unused,
			  struct perf_header *ph,
			  int feat,
			  int fd __maybe_unused,
			  void *data)
{
	struct timechart *tchart = data;

	switch (feat) {
	case HEADER_NRCPUS:
		tchart->numcpus = ph->env.nr_cpus_avail;
		break;
1521 1522 1523 1524 1525 1526 1527 1528 1529 1530 1531 1532

	case HEADER_CPU_TOPOLOGY:
		if (!tchart->topology)
			break;

		if (svg_build_topology_map(ph->env.sibling_cores,
					   ph->env.nr_sibling_cores,
					   ph->env.sibling_threads,
					   ph->env.nr_sibling_threads))
			fprintf(stderr, "problem building topology\n");
		break;

1533 1534 1535 1536 1537 1538 1539
	default:
		break;
	}

	return 0;
}

1540
static int __cmd_timechart(struct timechart *tchart, const char *output_name)
1541
{
1542 1543 1544 1545 1546 1547 1548 1549 1550 1551
	const struct perf_evsel_str_handler power_tracepoints[] = {
		{ "power:cpu_idle",		process_sample_cpu_idle },
		{ "power:cpu_frequency",	process_sample_cpu_frequency },
		{ "sched:sched_wakeup",		process_sample_sched_wakeup },
		{ "sched:sched_switch",		process_sample_sched_switch },
#ifdef SUPPORT_OLD_POWER_EVENTS
		{ "power:power_start",		process_sample_power_start },
		{ "power:power_end",		process_sample_power_end },
		{ "power:power_frequency",	process_sample_power_frequency },
#endif
1552 1553 1554 1555 1556 1557 1558 1559 1560 1561 1562 1563 1564 1565 1566 1567 1568 1569 1570 1571 1572 1573 1574 1575 1576 1577 1578 1579 1580 1581 1582 1583 1584 1585 1586 1587 1588 1589 1590 1591 1592 1593 1594 1595 1596 1597 1598 1599 1600 1601

		{ "syscalls:sys_enter_read",		process_enter_read },
		{ "syscalls:sys_enter_pread64",		process_enter_read },
		{ "syscalls:sys_enter_readv",		process_enter_read },
		{ "syscalls:sys_enter_preadv",		process_enter_read },
		{ "syscalls:sys_enter_write",		process_enter_write },
		{ "syscalls:sys_enter_pwrite64",	process_enter_write },
		{ "syscalls:sys_enter_writev",		process_enter_write },
		{ "syscalls:sys_enter_pwritev",		process_enter_write },
		{ "syscalls:sys_enter_sync",		process_enter_sync },
		{ "syscalls:sys_enter_sync_file_range",	process_enter_sync },
		{ "syscalls:sys_enter_fsync",		process_enter_sync },
		{ "syscalls:sys_enter_msync",		process_enter_sync },
		{ "syscalls:sys_enter_recvfrom",	process_enter_rx },
		{ "syscalls:sys_enter_recvmmsg",	process_enter_rx },
		{ "syscalls:sys_enter_recvmsg",		process_enter_rx },
		{ "syscalls:sys_enter_sendto",		process_enter_tx },
		{ "syscalls:sys_enter_sendmsg",		process_enter_tx },
		{ "syscalls:sys_enter_sendmmsg",	process_enter_tx },
		{ "syscalls:sys_enter_epoll_pwait",	process_enter_poll },
		{ "syscalls:sys_enter_epoll_wait",	process_enter_poll },
		{ "syscalls:sys_enter_poll",		process_enter_poll },
		{ "syscalls:sys_enter_ppoll",		process_enter_poll },
		{ "syscalls:sys_enter_pselect6",	process_enter_poll },
		{ "syscalls:sys_enter_select",		process_enter_poll },

		{ "syscalls:sys_exit_read",		process_exit_read },
		{ "syscalls:sys_exit_pread64",		process_exit_read },
		{ "syscalls:sys_exit_readv",		process_exit_read },
		{ "syscalls:sys_exit_preadv",		process_exit_read },
		{ "syscalls:sys_exit_write",		process_exit_write },
		{ "syscalls:sys_exit_pwrite64",		process_exit_write },
		{ "syscalls:sys_exit_writev",		process_exit_write },
		{ "syscalls:sys_exit_pwritev",		process_exit_write },
		{ "syscalls:sys_exit_sync",		process_exit_sync },
		{ "syscalls:sys_exit_sync_file_range",	process_exit_sync },
		{ "syscalls:sys_exit_fsync",		process_exit_sync },
		{ "syscalls:sys_exit_msync",		process_exit_sync },
		{ "syscalls:sys_exit_recvfrom",		process_exit_rx },
		{ "syscalls:sys_exit_recvmmsg",		process_exit_rx },
		{ "syscalls:sys_exit_recvmsg",		process_exit_rx },
		{ "syscalls:sys_exit_sendto",		process_exit_tx },
		{ "syscalls:sys_exit_sendmsg",		process_exit_tx },
		{ "syscalls:sys_exit_sendmmsg",		process_exit_tx },
		{ "syscalls:sys_exit_epoll_pwait",	process_exit_poll },
		{ "syscalls:sys_exit_epoll_wait",	process_exit_poll },
		{ "syscalls:sys_exit_poll",		process_exit_poll },
		{ "syscalls:sys_exit_ppoll",		process_exit_poll },
		{ "syscalls:sys_exit_pselect6",		process_exit_poll },
		{ "syscalls:sys_exit_select",		process_exit_poll },
1602
	};
1603 1604 1605
	struct perf_data_file file = {
		.path = input_name,
		.mode = PERF_DATA_MODE_READ,
1606
		.force = tchart->force,
1607 1608 1609
	};

	struct perf_session *session = perf_session__new(&file, false,
1610
							 &tchart->tool);
1611
	int ret = -EINVAL;
A
Arjan van de Ven 已提交
1612

1613
	if (session == NULL)
1614
		return -1;
1615

1616
	symbol__init(&session->header.env);
1617

1618 1619 1620 1621 1622
	(void)perf_header__process_sections(&session->header,
					    perf_data_file__fd(session->file),
					    tchart,
					    process_header);

1623 1624 1625
	if (!perf_session__has_traces(session, "timechart record"))
		goto out_delete;

1626 1627 1628 1629 1630 1631
	if (perf_session__set_tracepoints_handlers(session,
						   power_tracepoints)) {
		pr_err("Initializing session tracepoint handlers failed\n");
		goto out_delete;
	}

1632
	ret = perf_session__process_events(session);
1633
	if (ret)
1634
		goto out_delete;
A
Arjan van de Ven 已提交
1635

1636
	end_sample_processing(tchart);
A
Arjan van de Ven 已提交
1637

1638
	sort_pids(tchart);
A
Arjan van de Ven 已提交
1639

1640
	write_svg_file(tchart, output_name);
A
Arjan van de Ven 已提交
1641

1642
	pr_info("Written %2.1f seconds of trace to %s.\n",
1643
		(tchart->last_time - tchart->first_time) / (double)NSEC_PER_SEC, output_name);
1644 1645 1646
out_delete:
	perf_session__delete(session);
	return ret;
A
Arjan van de Ven 已提交
1647 1648
}

1649 1650 1651 1652 1653 1654 1655 1656 1657 1658 1659 1660 1661 1662 1663 1664 1665 1666 1667 1668 1669 1670 1671 1672 1673 1674 1675 1676 1677 1678 1679 1680 1681 1682 1683 1684 1685 1686 1687 1688 1689 1690 1691 1692 1693 1694 1695 1696 1697 1698 1699 1700 1701 1702 1703 1704 1705 1706 1707 1708 1709 1710 1711 1712 1713 1714 1715 1716 1717 1718 1719 1720 1721 1722 1723 1724 1725 1726 1727 1728 1729 1730 1731 1732 1733 1734 1735 1736 1737 1738 1739 1740 1741 1742 1743 1744 1745 1746 1747 1748 1749 1750 1751 1752 1753 1754 1755 1756 1757 1758 1759 1760 1761 1762 1763 1764 1765 1766 1767 1768 1769 1770 1771 1772 1773 1774 1775 1776 1777
static int timechart__io_record(int argc, const char **argv)
{
	unsigned int rec_argc, i;
	const char **rec_argv;
	const char **p;
	char *filter = NULL;

	const char * const common_args[] = {
		"record", "-a", "-R", "-c", "1",
	};
	unsigned int common_args_nr = ARRAY_SIZE(common_args);

	const char * const disk_events[] = {
		"syscalls:sys_enter_read",
		"syscalls:sys_enter_pread64",
		"syscalls:sys_enter_readv",
		"syscalls:sys_enter_preadv",
		"syscalls:sys_enter_write",
		"syscalls:sys_enter_pwrite64",
		"syscalls:sys_enter_writev",
		"syscalls:sys_enter_pwritev",
		"syscalls:sys_enter_sync",
		"syscalls:sys_enter_sync_file_range",
		"syscalls:sys_enter_fsync",
		"syscalls:sys_enter_msync",

		"syscalls:sys_exit_read",
		"syscalls:sys_exit_pread64",
		"syscalls:sys_exit_readv",
		"syscalls:sys_exit_preadv",
		"syscalls:sys_exit_write",
		"syscalls:sys_exit_pwrite64",
		"syscalls:sys_exit_writev",
		"syscalls:sys_exit_pwritev",
		"syscalls:sys_exit_sync",
		"syscalls:sys_exit_sync_file_range",
		"syscalls:sys_exit_fsync",
		"syscalls:sys_exit_msync",
	};
	unsigned int disk_events_nr = ARRAY_SIZE(disk_events);

	const char * const net_events[] = {
		"syscalls:sys_enter_recvfrom",
		"syscalls:sys_enter_recvmmsg",
		"syscalls:sys_enter_recvmsg",
		"syscalls:sys_enter_sendto",
		"syscalls:sys_enter_sendmsg",
		"syscalls:sys_enter_sendmmsg",

		"syscalls:sys_exit_recvfrom",
		"syscalls:sys_exit_recvmmsg",
		"syscalls:sys_exit_recvmsg",
		"syscalls:sys_exit_sendto",
		"syscalls:sys_exit_sendmsg",
		"syscalls:sys_exit_sendmmsg",
	};
	unsigned int net_events_nr = ARRAY_SIZE(net_events);

	const char * const poll_events[] = {
		"syscalls:sys_enter_epoll_pwait",
		"syscalls:sys_enter_epoll_wait",
		"syscalls:sys_enter_poll",
		"syscalls:sys_enter_ppoll",
		"syscalls:sys_enter_pselect6",
		"syscalls:sys_enter_select",

		"syscalls:sys_exit_epoll_pwait",
		"syscalls:sys_exit_epoll_wait",
		"syscalls:sys_exit_poll",
		"syscalls:sys_exit_ppoll",
		"syscalls:sys_exit_pselect6",
		"syscalls:sys_exit_select",
	};
	unsigned int poll_events_nr = ARRAY_SIZE(poll_events);

	rec_argc = common_args_nr +
		disk_events_nr * 4 +
		net_events_nr * 4 +
		poll_events_nr * 4 +
		argc;
	rec_argv = calloc(rec_argc + 1, sizeof(char *));

	if (rec_argv == NULL)
		return -ENOMEM;

	if (asprintf(&filter, "common_pid != %d", getpid()) < 0)
		return -ENOMEM;

	p = rec_argv;
	for (i = 0; i < common_args_nr; i++)
		*p++ = strdup(common_args[i]);

	for (i = 0; i < disk_events_nr; i++) {
		if (!is_valid_tracepoint(disk_events[i])) {
			rec_argc -= 4;
			continue;
		}

		*p++ = "-e";
		*p++ = strdup(disk_events[i]);
		*p++ = "--filter";
		*p++ = filter;
	}
	for (i = 0; i < net_events_nr; i++) {
		if (!is_valid_tracepoint(net_events[i])) {
			rec_argc -= 4;
			continue;
		}

		*p++ = "-e";
		*p++ = strdup(net_events[i]);
		*p++ = "--filter";
		*p++ = filter;
	}
	for (i = 0; i < poll_events_nr; i++) {
		if (!is_valid_tracepoint(poll_events[i])) {
			rec_argc -= 4;
			continue;
		}

		*p++ = "-e";
		*p++ = strdup(poll_events[i]);
		*p++ = "--filter";
		*p++ = filter;
	}

	for (i = 0; i < (unsigned int)argc; i++)
		*p++ = argv[i];

1778
	return cmd_record(rec_argc, rec_argv);
1779 1780 1781
}


1782
static int timechart__record(struct timechart *tchart, int argc, const char **argv)
1783
{
1784 1785 1786 1787 1788 1789
	unsigned int rec_argc, i, j;
	const char **rec_argv;
	const char **p;
	unsigned int record_elems;

	const char * const common_args[] = {
1790
		"record", "-a", "-R", "-c", "1",
1791 1792 1793
	};
	unsigned int common_args_nr = ARRAY_SIZE(common_args);

1794 1795 1796 1797 1798
	const char * const backtrace_args[] = {
		"-g",
	};
	unsigned int backtrace_args_no = ARRAY_SIZE(backtrace_args);

1799 1800 1801 1802 1803 1804 1805 1806
	const char * const power_args[] = {
		"-e", "power:cpu_frequency",
		"-e", "power:cpu_idle",
	};
	unsigned int power_args_nr = ARRAY_SIZE(power_args);

	const char * const old_power_args[] = {
#ifdef SUPPORT_OLD_POWER_EVENTS
1807 1808 1809 1810
		"-e", "power:power_start",
		"-e", "power:power_end",
		"-e", "power:power_frequency",
#endif
1811 1812 1813 1814
	};
	unsigned int old_power_args_nr = ARRAY_SIZE(old_power_args);

	const char * const tasks_args[] = {
1815 1816 1817
		"-e", "sched:sched_wakeup",
		"-e", "sched:sched_switch",
	};
1818
	unsigned int tasks_args_nr = ARRAY_SIZE(tasks_args);
1819 1820 1821 1822 1823

#ifdef SUPPORT_OLD_POWER_EVENTS
	if (!is_valid_tracepoint("power:cpu_idle") &&
	    is_valid_tracepoint("power:power_start")) {
		use_old_power_events = 1;
1824 1825 1826
		power_args_nr = 0;
	} else {
		old_power_args_nr = 0;
1827 1828
	}
#endif
1829

1830
	if (tchart->power_only)
1831 1832
		tasks_args_nr = 0;

1833
	if (tchart->tasks_only) {
1834 1835 1836 1837
		power_args_nr = 0;
		old_power_args_nr = 0;
	}

1838
	if (!tchart->with_backtrace)
1839 1840
		backtrace_args_no = 0;

1841
	record_elems = common_args_nr + tasks_args_nr +
1842
		power_args_nr + old_power_args_nr + backtrace_args_no;
1843 1844

	rec_argc = record_elems + argc;
1845 1846
	rec_argv = calloc(rec_argc + 1, sizeof(char *));

1847 1848 1849
	if (rec_argv == NULL)
		return -ENOMEM;

1850 1851 1852 1853
	p = rec_argv;
	for (i = 0; i < common_args_nr; i++)
		*p++ = strdup(common_args[i]);

1854 1855 1856
	for (i = 0; i < backtrace_args_no; i++)
		*p++ = strdup(backtrace_args[i]);

1857 1858 1859 1860 1861
	for (i = 0; i < tasks_args_nr; i++)
		*p++ = strdup(tasks_args[i]);

	for (i = 0; i < power_args_nr; i++)
		*p++ = strdup(power_args[i]);
1862

1863 1864
	for (i = 0; i < old_power_args_nr; i++)
		*p++ = strdup(old_power_args[i]);
1865

1866
	for (j = 0; j < (unsigned int)argc; j++)
1867 1868
		*p++ = argv[j];

1869
	return cmd_record(rec_argc, rec_argv);
1870 1871
}

1872
static int
1873 1874
parse_process(const struct option *opt __maybe_unused, const char *arg,
	      int __maybe_unused unset)
1875 1876 1877 1878 1879 1880
{
	if (arg)
		add_process_filter(arg);
	return 0;
}

1881 1882 1883 1884 1885 1886 1887 1888 1889 1890 1891 1892 1893 1894 1895 1896 1897
static int
parse_highlight(const struct option *opt __maybe_unused, const char *arg,
		int __maybe_unused unset)
{
	unsigned long duration = strtoul(arg, NULL, 0);

	if (svg_highlight || svg_highlight_name)
		return -1;

	if (duration)
		svg_highlight = duration;
	else
		svg_highlight_name = strdup(arg);

	return 0;
}

1898 1899 1900 1901 1902 1903 1904 1905 1906
static int
parse_time(const struct option *opt, const char *arg, int __maybe_unused unset)
{
	char unit = 'n';
	u64 *value = opt->value;

	if (sscanf(arg, "%" PRIu64 "%cs", value, &unit) > 0) {
		switch (unit) {
		case 'm':
1907
			*value *= NSEC_PER_MSEC;
1908 1909
			break;
		case 'u':
1910
			*value *= NSEC_PER_USEC;
1911 1912 1913 1914 1915 1916 1917 1918 1919 1920 1921
			break;
		case 'n':
			break;
		default:
			return -1;
		}
	}

	return 0;
}

1922
int cmd_timechart(int argc, const char **argv)
1923
{
1924 1925 1926 1927 1928 1929
	struct timechart tchart = {
		.tool = {
			.comm		 = process_comm_event,
			.fork		 = process_fork_event,
			.exit		 = process_exit_event,
			.sample		 = process_sample_event,
1930
			.ordered_events	 = true,
1931 1932
		},
		.proc_num = 15,
1933
		.min_time = NSEC_PER_MSEC,
1934
		.merge_dist = 1000,
1935
	};
1936
	const char *output_name = "output.svg";
1937 1938 1939 1940 1941
	const struct option timechart_common_options[] = {
	OPT_BOOLEAN('P', "power-only", &tchart.power_only, "output power data only"),
	OPT_BOOLEAN('T', "tasks-only", &tchart.tasks_only, "output processes data only"),
	OPT_END()
	};
1942
	const struct option timechart_options[] = {
1943 1944 1945
	OPT_STRING('i', "input", &input_name, "file", "input file name"),
	OPT_STRING('o', "output", &output_name, "file", "output file name"),
	OPT_INTEGER('w', "width", &svg_page_width, "page width"),
1946 1947 1948
	OPT_CALLBACK(0, "highlight", NULL, "duration or task name",
		      "highlight tasks. Pass duration in ns or process name.",
		       parse_highlight),
1949 1950 1951
	OPT_CALLBACK('p', "process", NULL, "process",
		      "process selector. Pass a pid or process name.",
		       parse_process),
1952 1953 1954
	OPT_CALLBACK(0, "symfs", NULL, "directory",
		     "Look for files with symbols relative to this directory",
		     symbol__config_symfs),
1955
	OPT_INTEGER('n', "proc-num", &tchart.proc_num,
1956
		    "min. number of tasks to print"),
1957 1958
	OPT_BOOLEAN('t', "topology", &tchart.topology,
		    "sort CPUs according to topology"),
1959 1960 1961 1962 1963 1964 1965 1966
	OPT_BOOLEAN(0, "io-skip-eagain", &tchart.skip_eagain,
		    "skip EAGAIN errors"),
	OPT_CALLBACK(0, "io-min-time", &tchart.min_time, "time",
		     "all IO faster than min-time will visually appear longer",
		     parse_time),
	OPT_CALLBACK(0, "io-merge-dist", &tchart.merge_dist, "time",
		     "merge events that are merge-dist us apart",
		     parse_time),
1967
	OPT_BOOLEAN('f', "force", &tchart.force, "don't complain, do it"),
1968
	OPT_PARENT(timechart_common_options),
1969
	};
1970 1971
	const char * const timechart_subcommands[] = { "record", NULL };
	const char *timechart_usage[] = {
1972 1973 1974
		"perf timechart [<options>] {record}",
		NULL
	};
1975
	const struct option timechart_record_options[] = {
1976 1977
	OPT_BOOLEAN('I', "io-only", &tchart.io_only,
		    "record only IO data"),
1978
	OPT_BOOLEAN('g', "callchain", &tchart.with_backtrace, "record callchain"),
1979
	OPT_PARENT(timechart_common_options),
1980
	};
1981
	const char * const timechart_record_usage[] = {
1982 1983 1984
		"perf timechart record [<options>]",
		NULL
	};
1985 1986
	argc = parse_options_subcommand(argc, argv, timechart_options, timechart_subcommands,
			timechart_usage, PARSE_OPT_STOP_AT_NON_OPTION);
A
Arjan van de Ven 已提交
1987

1988
	if (tchart.power_only && tchart.tasks_only) {
1989 1990 1991 1992
		pr_err("-P and -T options cannot be used at the same time.\n");
		return -1;
	}

1993
	if (argc && !strncmp(argv[0], "rec", 3)) {
1994 1995
		argc = parse_options(argc, argv, timechart_record_options,
				     timechart_record_usage,
1996 1997
				     PARSE_OPT_STOP_AT_NON_OPTION);

1998
		if (tchart.power_only && tchart.tasks_only) {
1999 2000 2001 2002
			pr_err("-P and -T options cannot be used at the same time.\n");
			return -1;
		}

2003 2004 2005 2006
		if (tchart.io_only)
			return timechart__io_record(argc, argv);
		else
			return timechart__record(&tchart, argc, argv);
2007 2008
	} else if (argc)
		usage_with_options(timechart_usage, timechart_options);
A
Arjan van de Ven 已提交
2009 2010 2011

	setup_pager();

2012
	return __cmd_timechart(&tchart, output_name);
A
Arjan van de Ven 已提交
2013
}