intel_sprite.c 31.9 KB
Newer Older
1 2 3 4 5 6 7 8 9 10 11 12 13 14 15 16 17 18 19 20 21 22 23 24 25 26 27 28 29 30 31
/*
 * Copyright © 2011 Intel Corporation
 *
 * Permission is hereby granted, free of charge, to any person obtaining a
 * copy of this software and associated documentation files (the "Software"),
 * to deal in the Software without restriction, including without limitation
 * the rights to use, copy, modify, merge, publish, distribute, sublicense,
 * and/or sell copies of the Software, and to permit persons to whom the
 * Software is furnished to do so, subject to the following conditions:
 *
 * The above copyright notice and this permission notice (including the next
 * paragraph) shall be included in all copies or substantial portions of the
 * Software.
 *
 * THE SOFTWARE IS PROVIDED "AS IS", WITHOUT WARRANTY OF ANY KIND, EXPRESS OR
 * IMPLIED, INCLUDING BUT NOT LIMITED TO THE WARRANTIES OF MERCHANTABILITY,
 * FITNESS FOR A PARTICULAR PURPOSE AND NONINFRINGEMENT.  IN NO EVENT SHALL
 * THE AUTHORS OR COPYRIGHT HOLDERS BE LIABLE FOR ANY CLAIM, DAMAGES OR OTHER
 * LIABILITY, WHETHER IN AN ACTION OF CONTRACT, TORT OR OTHERWISE, ARISING FROM,
 * OUT OF OR IN CONNECTION WITH THE SOFTWARE OR THE USE OR OTHER DEALINGS IN THE
 * SOFTWARE.
 *
 * Authors:
 *   Jesse Barnes <jbarnes@virtuousgeek.org>
 *
 * New plane/sprite handling.
 *
 * The older chips had a separate interface for programming plane related
 * registers; newer ones are much simpler and we can use the new DRM plane
 * support.
 */
32 33 34
#include <drm/drmP.h>
#include <drm/drm_crtc.h>
#include <drm/drm_fourcc.h>
35
#include <drm/drm_rect.h>
36
#include <drm/drm_atomic.h>
37
#include <drm/drm_plane_helper.h>
38
#include "intel_drv.h"
39
#include <drm/i915_drm.h>
40 41
#include "i915_drv.h"

42 43 44 45 46 47 48 49 50 51 52 53 54 55
static bool
format_is_yuv(uint32_t format)
{
	switch (format) {
	case DRM_FORMAT_YUYV:
	case DRM_FORMAT_UYVY:
	case DRM_FORMAT_VYUY:
	case DRM_FORMAT_YVYU:
		return true;
	default:
		return false;
	}
}

56 57 58 59 60 61 62 63 64
static int usecs_to_scanlines(const struct drm_display_mode *mode, int usecs)
{
	/* paranoia */
	if (!mode->crtc_htotal)
		return 1;

	return DIV_ROUND_UP(usecs * mode->crtc_clock, 1000 * mode->crtc_htotal);
}

65 66 67 68 69 70 71 72 73 74 75 76 77 78 79 80
/**
 * intel_pipe_update_start() - start update of a set of display registers
 * @crtc: the crtc of which the registers are going to be updated
 * @start_vbl_count: vblank counter return pointer used for error checking
 *
 * Mark the start of an update to pipe registers that should be updated
 * atomically regarding vblank. If the next vblank will happens within
 * the next 100 us, this function waits until the vblank passes.
 *
 * After a successful call to this function, interrupts will be disabled
 * until a subsequent call to intel_pipe_update_end(). That is done to
 * avoid random delays. The value written to @start_vbl_count should be
 * supplied to intel_pipe_update_end() for error checking.
 *
 * Return: true if the call was successful
 */
81
bool intel_pipe_update_start(struct intel_crtc *crtc, uint32_t *start_vbl_count)
82 83
{
	struct drm_device *dev = crtc->base.dev;
84
	const struct drm_display_mode *mode = &crtc->config->base.adjusted_mode;
85 86 87
	enum pipe pipe = crtc->pipe;
	long timeout = msecs_to_jiffies_timeout(1);
	int scanline, min, max, vblank_start;
88
	wait_queue_head_t *wq = drm_crtc_vblank_waitqueue(&crtc->base);
89 90 91 92 93 94 95 96 97 98 99 100 101
	DEFINE_WAIT(wait);

	vblank_start = mode->crtc_vblank_start;
	if (mode->flags & DRM_MODE_FLAG_INTERLACE)
		vblank_start = DIV_ROUND_UP(vblank_start, 2);

	/* FIXME needs to be calibrated sensibly */
	min = vblank_start - usecs_to_scanlines(mode, 100);
	max = vblank_start - 1;

	if (min <= 0 || max <= 0)
		return false;

102
	if (WARN_ON(drm_crtc_vblank_get(&crtc->base)))
103 104 105 106
		return false;

	local_irq_disable();

107 108
	trace_i915_pipe_update_start(crtc, min, max);

109 110 111 112 113 114
	for (;;) {
		/*
		 * prepare_to_wait() has a memory barrier, which guarantees
		 * other CPUs can see the task state update by the time we
		 * read the scanline.
		 */
115
		prepare_to_wait(wq, &wait, TASK_UNINTERRUPTIBLE);
116 117 118 119 120 121 122 123 124 125 126 127 128 129 130 131 132 133

		scanline = intel_get_crtc_scanline(crtc);
		if (scanline < min || scanline > max)
			break;

		if (timeout <= 0) {
			DRM_ERROR("Potential atomic update failure on pipe %c\n",
				  pipe_name(crtc->pipe));
			break;
		}

		local_irq_enable();

		timeout = schedule_timeout(timeout);

		local_irq_disable();
	}

134
	finish_wait(wq, &wait);
135

136
	drm_crtc_vblank_put(&crtc->base);
137 138 139

	*start_vbl_count = dev->driver->get_vblank_counter(dev, pipe);

140 141
	trace_i915_pipe_update_vblank_evaded(crtc, min, max, *start_vbl_count);

142 143 144
	return true;
}

145 146 147 148 149 150 151 152 153
/**
 * intel_pipe_update_end() - end update of a set of display registers
 * @crtc: the crtc of which the registers were updated
 * @start_vbl_count: start vblank counter (used for error checking)
 *
 * Mark the end of an update started with intel_pipe_update_start(). This
 * re-enables interrupts and verifies the update was actually completed
 * before a vblank using the value of @start_vbl_count.
 */
154
void intel_pipe_update_end(struct intel_crtc *crtc, u32 start_vbl_count)
155 156 157 158 159
{
	struct drm_device *dev = crtc->base.dev;
	enum pipe pipe = crtc->pipe;
	u32 end_vbl_count = dev->driver->get_vblank_counter(dev, pipe);

160 161
	trace_i915_pipe_update_end(crtc, end_vbl_count);

162 163 164 165 166 167 168
	local_irq_enable();

	if (start_vbl_count != end_vbl_count)
		DRM_ERROR("Atomic update failure on pipe %c (start=%u end=%u)\n",
			  pipe_name(pipe), start_vbl_count, end_vbl_count);
}

169 170 171
static void
skl_update_plane(struct drm_plane *drm_plane, struct drm_crtc *crtc,
		 struct drm_framebuffer *fb,
172
		 int crtc_x, int crtc_y,
173 174 175 176 177 178 179
		 unsigned int crtc_w, unsigned int crtc_h,
		 uint32_t x, uint32_t y,
		 uint32_t src_w, uint32_t src_h)
{
	struct drm_device *dev = drm_plane->dev;
	struct drm_i915_private *dev_priv = dev->dev_private;
	struct intel_plane *intel_plane = to_intel_plane(drm_plane);
180
	struct drm_i915_gem_object *obj = intel_fb_obj(fb);
181 182
	const int pipe = intel_plane->pipe;
	const int plane = intel_plane->plane + 1;
183
	u32 plane_ctl, stride_div, stride;
184
	int pixel_size = drm_format_plane_cpp(fb->pixel_format, 0);
185 186
	const struct drm_intel_sprite_colorkey *key =
		&to_intel_plane_state(drm_plane->state)->ckey;
187
	unsigned long surf_addr;
188 189 190
	u32 tile_height, plane_offset, plane_size;
	unsigned int rotation;
	int x_offset, y_offset;
191 192
	struct intel_crtc_state *crtc_state = to_intel_crtc(crtc)->config;
	int scaler_id;
193

194 195
	plane_ctl = PLANE_CTL_ENABLE |
		PLANE_CTL_PIPE_CSC_ENABLE;
196

197 198
	plane_ctl |= skl_plane_ctl_format(fb->pixel_format);
	plane_ctl |= skl_plane_ctl_tiling(fb->modifier[0]);
199

200
	rotation = drm_plane->state->rotation;
201
	plane_ctl |= skl_plane_ctl_rotation(rotation);
202 203 204 205 206

	intel_update_sprite_watermarks(drm_plane, crtc, src_w, src_h,
				       pixel_size, true,
				       src_w != crtc_w || src_h != crtc_h);

207 208 209
	stride_div = intel_fb_stride_alignment(dev, fb->modifier[0],
					       fb->pixel_format);

210 211
	scaler_id = to_intel_plane_state(drm_plane->state)->scaler_id;

212 213 214 215 216 217
	/* Sizes are 0 based */
	src_w--;
	src_h--;
	crtc_w--;
	crtc_h--;

218 219 220 221 222 223 224 225 226 227 228
	if (key->flags) {
		I915_WRITE(PLANE_KEYVAL(pipe, plane), key->min_value);
		I915_WRITE(PLANE_KEYMAX(pipe, plane), key->max_value);
		I915_WRITE(PLANE_KEYMSK(pipe, plane), key->channel_mask);
	}

	if (key->flags & I915_SET_COLORKEY_DESTINATION)
		plane_ctl |= PLANE_CTL_KEY_ENABLE_DESTINATION;
	else if (key->flags & I915_SET_COLORKEY_SOURCE)
		plane_ctl |= PLANE_CTL_KEY_ENABLE_SOURCE;

229 230
	surf_addr = intel_plane_obj_offset(intel_plane, obj);

231 232
	if (intel_rotation_90_or_270(rotation)) {
		/* stride: Surface height in tiles */
233 234
		tile_height = intel_tile_height(dev, fb->pixel_format,
						fb->modifier[0]);
235 236 237 238 239 240 241 242 243 244 245 246 247 248 249
		stride = DIV_ROUND_UP(fb->height, tile_height);
		plane_size = (src_w << 16) | src_h;
		x_offset = stride * tile_height - y - (src_h + 1);
		y_offset = x;
	} else {
		stride = fb->pitches[0] / stride_div;
		plane_size = (src_h << 16) | src_w;
		x_offset = x;
		y_offset = y;
	}
	plane_offset = y_offset << 16 | x_offset;

	I915_WRITE(PLANE_OFFSET(pipe, plane), plane_offset);
	I915_WRITE(PLANE_STRIDE(pipe, plane), stride);
	I915_WRITE(PLANE_SIZE(pipe, plane), plane_size);
250 251 252 253 254 255 256 257 258 259 260 261 262 263 264 265 266 267 268 269

	/* program plane scaler */
	if (scaler_id >= 0) {
		uint32_t ps_ctrl = 0;

		DRM_DEBUG_KMS("plane = %d PS_PLANE_SEL(plane) = 0x%x\n", plane,
			PS_PLANE_SEL(plane));
		ps_ctrl = PS_SCALER_EN | PS_PLANE_SEL(plane) |
			crtc_state->scaler_state.scalers[scaler_id].mode;
		I915_WRITE(SKL_PS_CTRL(pipe, scaler_id), ps_ctrl);
		I915_WRITE(SKL_PS_PWR_GATE(pipe, scaler_id), 0);
		I915_WRITE(SKL_PS_WIN_POS(pipe, scaler_id), (crtc_x << 16) | crtc_y);
		I915_WRITE(SKL_PS_WIN_SZ(pipe, scaler_id),
			((crtc_w + 1) << 16)|(crtc_h + 1));

		I915_WRITE(PLANE_POS(pipe, plane), 0);
	} else {
		I915_WRITE(PLANE_POS(pipe, plane), (crtc_y << 16) | crtc_x);
	}

270
	I915_WRITE(PLANE_CTL(pipe, plane), plane_ctl);
271
	I915_WRITE(PLANE_SURF(pipe, plane), surf_addr);
272 273 274 275
	POSTING_READ(PLANE_SURF(pipe, plane));
}

static void
276
skl_disable_plane(struct drm_plane *dplane, struct drm_crtc *crtc)
277
{
278
	struct drm_device *dev = dplane->dev;
279
	struct drm_i915_private *dev_priv = dev->dev_private;
280
	struct intel_plane *intel_plane = to_intel_plane(dplane);
281 282 283
	const int pipe = intel_plane->pipe;
	const int plane = intel_plane->plane + 1;

284
	I915_WRITE(PLANE_CTL(pipe, plane), 0);
285

286 287
	I915_WRITE(PLANE_SURF(pipe, plane), 0);
	POSTING_READ(PLANE_SURF(pipe, plane));
288

289
	intel_update_sprite_watermarks(dplane, crtc, 0, 0, 0, false, false);
290 291
}

292 293 294 295 296 297 298 299 300 301 302 303 304 305 306 307 308 309 310 311 312 313 314 315 316 317 318 319 320 321 322 323 324 325 326 327 328 329 330
static void
chv_update_csc(struct intel_plane *intel_plane, uint32_t format)
{
	struct drm_i915_private *dev_priv = intel_plane->base.dev->dev_private;
	int plane = intel_plane->plane;

	/* Seems RGB data bypasses the CSC always */
	if (!format_is_yuv(format))
		return;

	/*
	 * BT.601 limited range YCbCr -> full range RGB
	 *
	 * |r|   | 6537 4769     0|   |cr  |
	 * |g| = |-3330 4769 -1605| x |y-64|
	 * |b|   |    0 4769  8263|   |cb  |
	 *
	 * Cb and Cr apparently come in as signed already, so no
	 * need for any offset. For Y we need to remove the offset.
	 */
	I915_WRITE(SPCSCYGOFF(plane), SPCSC_OOFF(0) | SPCSC_IOFF(-64));
	I915_WRITE(SPCSCCBOFF(plane), SPCSC_OOFF(0) | SPCSC_IOFF(0));
	I915_WRITE(SPCSCCROFF(plane), SPCSC_OOFF(0) | SPCSC_IOFF(0));

	I915_WRITE(SPCSCC01(plane), SPCSC_C1(4769) | SPCSC_C0(6537));
	I915_WRITE(SPCSCC23(plane), SPCSC_C1(-3330) | SPCSC_C0(0));
	I915_WRITE(SPCSCC45(plane), SPCSC_C1(-1605) | SPCSC_C0(4769));
	I915_WRITE(SPCSCC67(plane), SPCSC_C1(4769) | SPCSC_C0(0));
	I915_WRITE(SPCSCC8(plane), SPCSC_C0(8263));

	I915_WRITE(SPCSCYGICLAMP(plane), SPCSC_IMAX(940) | SPCSC_IMIN(64));
	I915_WRITE(SPCSCCBICLAMP(plane), SPCSC_IMAX(448) | SPCSC_IMIN(-448));
	I915_WRITE(SPCSCCRICLAMP(plane), SPCSC_IMAX(448) | SPCSC_IMIN(-448));

	I915_WRITE(SPCSCYGOCLAMP(plane), SPCSC_OMAX(1023) | SPCSC_OMIN(0));
	I915_WRITE(SPCSCCBOCLAMP(plane), SPCSC_OMAX(1023) | SPCSC_OMIN(0));
	I915_WRITE(SPCSCCROCLAMP(plane), SPCSC_OMAX(1023) | SPCSC_OMIN(0));
}

331
static void
332 333
vlv_update_plane(struct drm_plane *dplane, struct drm_crtc *crtc,
		 struct drm_framebuffer *fb,
334
		 int crtc_x, int crtc_y,
335 336 337 338 339 340 341
		 unsigned int crtc_w, unsigned int crtc_h,
		 uint32_t x, uint32_t y,
		 uint32_t src_w, uint32_t src_h)
{
	struct drm_device *dev = dplane->dev;
	struct drm_i915_private *dev_priv = dev->dev_private;
	struct intel_plane *intel_plane = to_intel_plane(dplane);
342
	struct drm_i915_gem_object *obj = intel_fb_obj(fb);
343 344 345 346 347
	int pipe = intel_plane->pipe;
	int plane = intel_plane->plane;
	u32 sprctl;
	unsigned long sprsurf_offset, linear_offset;
	int pixel_size = drm_format_plane_cpp(fb->pixel_format, 0);
348 349
	const struct drm_intel_sprite_colorkey *key =
		&to_intel_plane_state(dplane->state)->ckey;
350

351
	sprctl = SP_ENABLE;
352 353 354 355 356 357 358 359 360 361 362 363 364 365 366 367 368 369 370 371 372 373 374 375 376 377 378 379 380 381 382 383 384 385 386 387 388 389 390 391 392 393 394 395

	switch (fb->pixel_format) {
	case DRM_FORMAT_YUYV:
		sprctl |= SP_FORMAT_YUV422 | SP_YUV_ORDER_YUYV;
		break;
	case DRM_FORMAT_YVYU:
		sprctl |= SP_FORMAT_YUV422 | SP_YUV_ORDER_YVYU;
		break;
	case DRM_FORMAT_UYVY:
		sprctl |= SP_FORMAT_YUV422 | SP_YUV_ORDER_UYVY;
		break;
	case DRM_FORMAT_VYUY:
		sprctl |= SP_FORMAT_YUV422 | SP_YUV_ORDER_VYUY;
		break;
	case DRM_FORMAT_RGB565:
		sprctl |= SP_FORMAT_BGR565;
		break;
	case DRM_FORMAT_XRGB8888:
		sprctl |= SP_FORMAT_BGRX8888;
		break;
	case DRM_FORMAT_ARGB8888:
		sprctl |= SP_FORMAT_BGRA8888;
		break;
	case DRM_FORMAT_XBGR2101010:
		sprctl |= SP_FORMAT_RGBX1010102;
		break;
	case DRM_FORMAT_ABGR2101010:
		sprctl |= SP_FORMAT_RGBA1010102;
		break;
	case DRM_FORMAT_XBGR8888:
		sprctl |= SP_FORMAT_RGBX8888;
		break;
	case DRM_FORMAT_ABGR8888:
		sprctl |= SP_FORMAT_RGBA8888;
		break;
	default:
		/*
		 * If we get here one of the upper layers failed to filter
		 * out the unsupported plane formats
		 */
		BUG();
		break;
	}

396 397 398 399 400 401
	/*
	 * Enable gamma to match primary/cursor plane behaviour.
	 * FIXME should be user controllable via propertiesa.
	 */
	sprctl |= SP_GAMMA_ENABLE;

402 403 404
	if (obj->tiling_mode != I915_TILING_NONE)
		sprctl |= SP_TILED;

405 406
	intel_update_sprite_watermarks(dplane, crtc, src_w, src_h,
				       pixel_size, true,
407 408
				       src_w != crtc_w || src_h != crtc_h);

409 410 411 412 413 414 415
	/* Sizes are 0 based */
	src_w--;
	src_h--;
	crtc_w--;
	crtc_h--;

	linear_offset = y * fb->pitches[0] + x * pixel_size;
416 417
	sprsurf_offset = intel_gen4_compute_page_offset(dev_priv,
							&x, &y,
418 419 420 421 422
							obj->tiling_mode,
							pixel_size,
							fb->pitches[0]);
	linear_offset -= sprsurf_offset;

423
	if (dplane->state->rotation == BIT(DRM_ROTATE_180)) {
424 425 426 427 428 429 430
		sprctl |= SP_ROTATE_180;

		x += src_w;
		y += src_h;
		linear_offset += src_h * fb->pitches[0] + src_w * pixel_size;
	}

431 432 433 434 435 436 437 438 439
	if (key->flags) {
		I915_WRITE(SPKEYMINVAL(pipe, plane), key->min_value);
		I915_WRITE(SPKEYMAXVAL(pipe, plane), key->max_value);
		I915_WRITE(SPKEYMSK(pipe, plane), key->channel_mask);
	}

	if (key->flags & I915_SET_COLORKEY_SOURCE)
		sprctl |= SP_SOURCE_KEY;

440 441 442
	if (IS_CHERRYVIEW(dev) && pipe == PIPE_B)
		chv_update_csc(intel_plane, fb->pixel_format);

443 444 445
	I915_WRITE(SPSTRIDE(pipe, plane), fb->pitches[0]);
	I915_WRITE(SPPOS(pipe, plane), (crtc_y << 16) | crtc_x);

446 447 448 449 450
	if (obj->tiling_mode != I915_TILING_NONE)
		I915_WRITE(SPTILEOFF(pipe, plane), (y << 16) | x);
	else
		I915_WRITE(SPLINOFF(pipe, plane), linear_offset);

451 452
	I915_WRITE(SPCONSTALPHA(pipe, plane), 0);

453 454
	I915_WRITE(SPSIZE(pipe, plane), (crtc_h << 16) | crtc_w);
	I915_WRITE(SPCNTR(pipe, plane), sprctl);
455 456
	I915_WRITE(SPSURF(pipe, plane), i915_gem_obj_ggtt_offset(obj) +
		   sprsurf_offset);
457
	POSTING_READ(SPSURF(pipe, plane));
458 459 460
}

static void
461
vlv_disable_plane(struct drm_plane *dplane, struct drm_crtc *crtc)
462 463 464 465 466 467 468
{
	struct drm_device *dev = dplane->dev;
	struct drm_i915_private *dev_priv = dev->dev_private;
	struct intel_plane *intel_plane = to_intel_plane(dplane);
	int pipe = intel_plane->pipe;
	int plane = intel_plane->plane;

469 470
	I915_WRITE(SPCNTR(pipe, plane), 0);

471
	I915_WRITE(SPSURF(pipe, plane), 0);
472
	POSTING_READ(SPSURF(pipe, plane));
473

474
	intel_update_sprite_watermarks(dplane, crtc, 0, 0, 0, false, false);
475 476
}

477
static void
478 479
ivb_update_plane(struct drm_plane *plane, struct drm_crtc *crtc,
		 struct drm_framebuffer *fb,
480
		 int crtc_x, int crtc_y,
481 482 483 484 485 486 487
		 unsigned int crtc_w, unsigned int crtc_h,
		 uint32_t x, uint32_t y,
		 uint32_t src_w, uint32_t src_h)
{
	struct drm_device *dev = plane->dev;
	struct drm_i915_private *dev_priv = dev->dev_private;
	struct intel_plane *intel_plane = to_intel_plane(plane);
488
	struct drm_i915_gem_object *obj = intel_fb_obj(fb);
489
	enum pipe pipe = intel_plane->pipe;
490
	u32 sprctl, sprscale = 0;
491
	unsigned long sprsurf_offset, linear_offset;
V
Ville Syrjälä 已提交
492
	int pixel_size = drm_format_plane_cpp(fb->pixel_format, 0);
493 494
	const struct drm_intel_sprite_colorkey *key =
		&to_intel_plane_state(plane->state)->ckey;
495

496
	sprctl = SPRITE_ENABLE;
497 498 499

	switch (fb->pixel_format) {
	case DRM_FORMAT_XBGR8888:
500
		sprctl |= SPRITE_FORMAT_RGBX888 | SPRITE_RGB_ORDER_RGBX;
501 502
		break;
	case DRM_FORMAT_XRGB8888:
503
		sprctl |= SPRITE_FORMAT_RGBX888;
504 505 506 507 508 509 510 511 512 513 514 515 516 517
		break;
	case DRM_FORMAT_YUYV:
		sprctl |= SPRITE_FORMAT_YUV422 | SPRITE_YUV_ORDER_YUYV;
		break;
	case DRM_FORMAT_YVYU:
		sprctl |= SPRITE_FORMAT_YUV422 | SPRITE_YUV_ORDER_YVYU;
		break;
	case DRM_FORMAT_UYVY:
		sprctl |= SPRITE_FORMAT_YUV422 | SPRITE_YUV_ORDER_UYVY;
		break;
	case DRM_FORMAT_VYUY:
		sprctl |= SPRITE_FORMAT_YUV422 | SPRITE_YUV_ORDER_VYUY;
		break;
	default:
518
		BUG();
519 520
	}

521 522 523 524 525 526
	/*
	 * Enable gamma to match primary/cursor plane behaviour.
	 * FIXME should be user controllable via propertiesa.
	 */
	sprctl |= SPRITE_GAMMA_ENABLE;

527 528 529
	if (obj->tiling_mode != I915_TILING_NONE)
		sprctl |= SPRITE_TILED;

530
	if (IS_HASWELL(dev) || IS_BROADWELL(dev))
531 532 533 534
		sprctl &= ~SPRITE_TRICKLE_FEED_DISABLE;
	else
		sprctl |= SPRITE_TRICKLE_FEED_DISABLE;

535
	if (IS_HASWELL(dev) || IS_BROADWELL(dev))
536 537
		sprctl |= SPRITE_PIPE_CSC_ENABLE;

538 539
	intel_update_sprite_watermarks(plane, crtc, src_w, src_h, pixel_size,
				       true,
540 541
				       src_w != crtc_w || src_h != crtc_h);

542 543 544 545 546 547
	/* Sizes are 0 based */
	src_w--;
	src_h--;
	crtc_w--;
	crtc_h--;

548
	if (crtc_w != src_w || crtc_h != src_h)
549 550
		sprscale = SPRITE_SCALE_ENABLE | (src_w << 16) | src_h;

551
	linear_offset = y * fb->pitches[0] + x * pixel_size;
552
	sprsurf_offset =
553 554
		intel_gen4_compute_page_offset(dev_priv,
					       &x, &y, obj->tiling_mode,
555
					       pixel_size, fb->pitches[0]);
556 557
	linear_offset -= sprsurf_offset;

558
	if (plane->state->rotation == BIT(DRM_ROTATE_180)) {
559 560 561 562 563 564 565 566 567 568 569
		sprctl |= SPRITE_ROTATE_180;

		/* HSW and BDW does this automagically in hardware */
		if (!IS_HASWELL(dev) && !IS_BROADWELL(dev)) {
			x += src_w;
			y += src_h;
			linear_offset += src_h * fb->pitches[0] +
				src_w * pixel_size;
		}
	}

570 571 572 573 574 575 576 577 578 579 580
	if (key->flags) {
		I915_WRITE(SPRKEYVAL(pipe), key->min_value);
		I915_WRITE(SPRKEYMAX(pipe), key->max_value);
		I915_WRITE(SPRKEYMSK(pipe), key->channel_mask);
	}

	if (key->flags & I915_SET_COLORKEY_DESTINATION)
		sprctl |= SPRITE_DEST_KEY;
	else if (key->flags & I915_SET_COLORKEY_SOURCE)
		sprctl |= SPRITE_SOURCE_KEY;

581 582 583
	I915_WRITE(SPRSTRIDE(pipe), fb->pitches[0]);
	I915_WRITE(SPRPOS(pipe), (crtc_y << 16) | crtc_x);

584 585
	/* HSW consolidates SPRTILEOFF and SPRLINOFF into a single SPROFFSET
	 * register */
586
	if (IS_HASWELL(dev) || IS_BROADWELL(dev))
587
		I915_WRITE(SPROFFSET(pipe), (y << 16) | x);
588
	else if (obj->tiling_mode != I915_TILING_NONE)
589
		I915_WRITE(SPRTILEOFF(pipe), (y << 16) | x);
590 591
	else
		I915_WRITE(SPRLINOFF(pipe), linear_offset);
592

593
	I915_WRITE(SPRSIZE(pipe), (crtc_h << 16) | crtc_w);
594 595
	if (intel_plane->can_scale)
		I915_WRITE(SPRSCALE(pipe), sprscale);
596
	I915_WRITE(SPRCTL(pipe), sprctl);
597 598
	I915_WRITE(SPRSURF(pipe),
		   i915_gem_obj_ggtt_offset(obj) + sprsurf_offset);
599
	POSTING_READ(SPRSURF(pipe));
600 601 602
}

static void
603
ivb_disable_plane(struct drm_plane *plane, struct drm_crtc *crtc)
604 605 606 607 608 609 610 611
{
	struct drm_device *dev = plane->dev;
	struct drm_i915_private *dev_priv = dev->dev_private;
	struct intel_plane *intel_plane = to_intel_plane(plane);
	int pipe = intel_plane->pipe;

	I915_WRITE(SPRCTL(pipe), I915_READ(SPRCTL(pipe)) & ~SPRITE_ENABLE);
	/* Can't leave the scaler enabled... */
612 613
	if (intel_plane->can_scale)
		I915_WRITE(SPRSCALE(pipe), 0);
614

615 616
	I915_WRITE(SPRSURF(pipe), 0);
	POSTING_READ(SPRSURF(pipe));
617 618 619
}

static void
620 621
ilk_update_plane(struct drm_plane *plane, struct drm_crtc *crtc,
		 struct drm_framebuffer *fb,
622
		 int crtc_x, int crtc_y,
623 624 625 626 627 628 629
		 unsigned int crtc_w, unsigned int crtc_h,
		 uint32_t x, uint32_t y,
		 uint32_t src_w, uint32_t src_h)
{
	struct drm_device *dev = plane->dev;
	struct drm_i915_private *dev_priv = dev->dev_private;
	struct intel_plane *intel_plane = to_intel_plane(plane);
630
	struct drm_i915_gem_object *obj = intel_fb_obj(fb);
V
Ville Syrjälä 已提交
631
	int pipe = intel_plane->pipe;
632
	unsigned long dvssurf_offset, linear_offset;
633
	u32 dvscntr, dvsscale;
V
Ville Syrjälä 已提交
634
	int pixel_size = drm_format_plane_cpp(fb->pixel_format, 0);
635 636
	const struct drm_intel_sprite_colorkey *key =
		&to_intel_plane_state(plane->state)->ckey;
637

638
	dvscntr = DVS_ENABLE;
639 640 641

	switch (fb->pixel_format) {
	case DRM_FORMAT_XBGR8888:
642
		dvscntr |= DVS_FORMAT_RGBX888 | DVS_RGB_ORDER_XBGR;
643 644
		break;
	case DRM_FORMAT_XRGB8888:
645
		dvscntr |= DVS_FORMAT_RGBX888;
646 647 648 649 650 651 652 653 654 655 656 657 658 659
		break;
	case DRM_FORMAT_YUYV:
		dvscntr |= DVS_FORMAT_YUV422 | DVS_YUV_ORDER_YUYV;
		break;
	case DRM_FORMAT_YVYU:
		dvscntr |= DVS_FORMAT_YUV422 | DVS_YUV_ORDER_YVYU;
		break;
	case DRM_FORMAT_UYVY:
		dvscntr |= DVS_FORMAT_YUV422 | DVS_YUV_ORDER_UYVY;
		break;
	case DRM_FORMAT_VYUY:
		dvscntr |= DVS_FORMAT_YUV422 | DVS_YUV_ORDER_VYUY;
		break;
	default:
660
		BUG();
661 662
	}

663 664 665 666 667 668
	/*
	 * Enable gamma to match primary/cursor plane behaviour.
	 * FIXME should be user controllable via propertiesa.
	 */
	dvscntr |= DVS_GAMMA_ENABLE;

669 670 671
	if (obj->tiling_mode != I915_TILING_NONE)
		dvscntr |= DVS_TILED;

672 673
	if (IS_GEN6(dev))
		dvscntr |= DVS_TRICKLE_FEED_DISABLE; /* must disable */
674

675 676
	intel_update_sprite_watermarks(plane, crtc, src_w, src_h,
				       pixel_size, true,
677 678
				       src_w != crtc_w || src_h != crtc_h);

679 680 681 682 683 684
	/* Sizes are 0 based */
	src_w--;
	src_h--;
	crtc_w--;
	crtc_h--;

685
	dvsscale = 0;
686
	if (crtc_w != src_w || crtc_h != src_h)
687 688
		dvsscale = DVS_SCALE_ENABLE | (src_w << 16) | src_h;

689
	linear_offset = y * fb->pitches[0] + x * pixel_size;
690
	dvssurf_offset =
691 692
		intel_gen4_compute_page_offset(dev_priv,
					       &x, &y, obj->tiling_mode,
693
					       pixel_size, fb->pitches[0]);
694 695
	linear_offset -= dvssurf_offset;

696
	if (plane->state->rotation == BIT(DRM_ROTATE_180)) {
697 698 699 700 701 702 703
		dvscntr |= DVS_ROTATE_180;

		x += src_w;
		y += src_h;
		linear_offset += src_h * fb->pitches[0] + src_w * pixel_size;
	}

704 705 706 707 708 709 710 711 712 713 714
	if (key->flags) {
		I915_WRITE(DVSKEYVAL(pipe), key->min_value);
		I915_WRITE(DVSKEYMAX(pipe), key->max_value);
		I915_WRITE(DVSKEYMSK(pipe), key->channel_mask);
	}

	if (key->flags & I915_SET_COLORKEY_DESTINATION)
		dvscntr |= DVS_DEST_KEY;
	else if (key->flags & I915_SET_COLORKEY_SOURCE)
		dvscntr |= DVS_SOURCE_KEY;

715 716 717
	I915_WRITE(DVSSTRIDE(pipe), fb->pitches[0]);
	I915_WRITE(DVSPOS(pipe), (crtc_y << 16) | crtc_x);

718
	if (obj->tiling_mode != I915_TILING_NONE)
719
		I915_WRITE(DVSTILEOFF(pipe), (y << 16) | x);
720 721
	else
		I915_WRITE(DVSLINOFF(pipe), linear_offset);
722 723 724 725

	I915_WRITE(DVSSIZE(pipe), (crtc_h << 16) | crtc_w);
	I915_WRITE(DVSSCALE(pipe), dvsscale);
	I915_WRITE(DVSCNTR(pipe), dvscntr);
726 727
	I915_WRITE(DVSSURF(pipe),
		   i915_gem_obj_ggtt_offset(obj) + dvssurf_offset);
728
	POSTING_READ(DVSSURF(pipe));
729 730 731
}

static void
732
ilk_disable_plane(struct drm_plane *plane, struct drm_crtc *crtc)
733 734 735 736 737 738
{
	struct drm_device *dev = plane->dev;
	struct drm_i915_private *dev_priv = dev->dev_private;
	struct intel_plane *intel_plane = to_intel_plane(plane);
	int pipe = intel_plane->pipe;

739
	I915_WRITE(DVSCNTR(pipe), 0);
740 741
	/* Disable the scaler */
	I915_WRITE(DVSSCALE(pipe), 0);
742

743
	I915_WRITE(DVSSURF(pipe), 0);
744
	POSTING_READ(DVSSURF(pipe));
745 746 747
}

static int
748
intel_check_sprite_plane(struct drm_plane *plane,
749
			 struct intel_crtc_state *crtc_state,
750
			 struct intel_plane_state *state)
751
{
752
	struct drm_device *dev = plane->dev;
753 754
	struct drm_crtc *crtc = state->base.crtc;
	struct intel_crtc *intel_crtc = to_intel_crtc(crtc);
755
	struct intel_plane *intel_plane = to_intel_plane(plane);
756
	struct drm_framebuffer *fb = state->base.fb;
757 758 759 760 761 762
	int crtc_x, crtc_y;
	unsigned int crtc_w, crtc_h;
	uint32_t src_x, src_y, src_w, src_h;
	struct drm_rect *src = &state->src;
	struct drm_rect *dst = &state->dst;
	const struct drm_rect *clip = &state->clip;
763 764
	int hscale, vscale;
	int max_scale, min_scale;
765
	bool can_scale;
766 767 768 769
	int pixel_size;

	if (!fb) {
		state->visible = false;
770
		return 0;
771
	}
772

773 774 775
	/* Don't modify another pipe's plane */
	if (intel_plane->pipe != intel_crtc->pipe) {
		DRM_DEBUG_KMS("Wrong plane <-> crtc mapping\n");
776
		return -EINVAL;
777
	}
778

779 780 781
	/* FIXME check all gen limits */
	if (fb->width < 3 || fb->height < 3 || fb->pitches[0] > 16384) {
		DRM_DEBUG_KMS("Unsuitable framebuffer for plane\n");
782
		return -EINVAL;
783
	}
784

785 786 787
	/* setup can_scale, min_scale, max_scale */
	if (INTEL_INFO(dev)->gen >= 9) {
		/* use scaler when colorkey is not required */
788
		if (state->ckey.flags == I915_SET_COLORKEY_NONE) {
789 790 791 792 793 794 795 796 797 798 799 800 801 802
			can_scale = 1;
			min_scale = 1;
			max_scale = skl_max_scale(intel_crtc, crtc_state);
		} else {
			can_scale = 0;
			min_scale = DRM_PLANE_HELPER_NO_SCALING;
			max_scale = DRM_PLANE_HELPER_NO_SCALING;
		}
	} else {
		can_scale = intel_plane->can_scale;
		max_scale = intel_plane->max_downscale << 16;
		min_scale = intel_plane->can_scale ? 1 : (1 << 16);
	}

803 804 805 806 807
	/*
	 * FIXME the following code does a bunch of fuzzy adjustments to the
	 * coordinates and sizes. We probably need some way to decide whether
	 * more strict checking should be done instead.
	 */
808
	drm_rect_rotate(src, fb->width << 16, fb->height << 16,
809
			state->base.rotation);
810

811
	hscale = drm_rect_calc_hscale_relaxed(src, dst, min_scale, max_scale);
812
	BUG_ON(hscale < 0);
813

814
	vscale = drm_rect_calc_vscale_relaxed(src, dst, min_scale, max_scale);
815
	BUG_ON(vscale < 0);
816

817
	state->visible = drm_rect_clip_scaled(src, dst, clip, hscale, vscale);
818

819 820 821 822
	crtc_x = dst->x1;
	crtc_y = dst->y1;
	crtc_w = drm_rect_width(dst);
	crtc_h = drm_rect_height(dst);
823

824
	if (state->visible) {
825
		/* check again in case clipping clamped the results */
826
		hscale = drm_rect_calc_hscale(src, dst, min_scale, max_scale);
827 828
		if (hscale < 0) {
			DRM_DEBUG_KMS("Horizontal scaling factor out of limits\n");
829 830
			drm_rect_debug_print(src, true);
			drm_rect_debug_print(dst, false);
831 832 833 834

			return hscale;
		}

835
		vscale = drm_rect_calc_vscale(src, dst, min_scale, max_scale);
836 837
		if (vscale < 0) {
			DRM_DEBUG_KMS("Vertical scaling factor out of limits\n");
838 839
			drm_rect_debug_print(src, true);
			drm_rect_debug_print(dst, false);
840 841 842 843

			return vscale;
		}

844
		/* Make the source viewport size an exact multiple of the scaling factors. */
845 846 847
		drm_rect_adjust_size(src,
				     drm_rect_width(dst) * hscale - drm_rect_width(src),
				     drm_rect_height(dst) * vscale - drm_rect_height(src));
848

849
		drm_rect_rotate_inv(src, fb->width << 16, fb->height << 16,
850
				    state->base.rotation);
851

852
		/* sanity check to make sure the src viewport wasn't enlarged */
853 854 855 856
		WARN_ON(src->x1 < (int) state->base.src_x ||
			src->y1 < (int) state->base.src_y ||
			src->x2 > (int) state->base.src_x + state->base.src_w ||
			src->y2 > (int) state->base.src_y + state->base.src_h);
857 858 859 860 861 862 863

		/*
		 * Hardware doesn't handle subpixel coordinates.
		 * Adjust to (macro)pixel boundary, but be careful not to
		 * increase the source viewport size, because that could
		 * push the downscaling factor out of bounds.
		 */
864 865 866 867
		src_x = src->x1 >> 16;
		src_w = drm_rect_width(src) >> 16;
		src_y = src->y1 >> 16;
		src_h = drm_rect_height(src) >> 16;
868 869 870 871 872 873 874 875 876

		if (format_is_yuv(fb->pixel_format)) {
			src_x &= ~1;
			src_w &= ~1;

			/*
			 * Must keep src and dst the
			 * same if we can't scale.
			 */
877
			if (!can_scale)
878 879 880
				crtc_w &= ~1;

			if (crtc_w == 0)
881
				state->visible = false;
882 883 884 885
		}
	}

	/* Check size restrictions when scaling */
886
	if (state->visible && (src_w != crtc_w || src_h != crtc_h)) {
887 888
		unsigned int width_bytes;

889
		WARN_ON(!can_scale);
890 891 892 893

		/* FIXME interlacing min height is 6 */

		if (crtc_w < 3 || crtc_h < 3)
894
			state->visible = false;
895 896

		if (src_w < 3 || src_h < 3)
897
			state->visible = false;
898

899
		pixel_size = drm_format_plane_cpp(fb->pixel_format, 0);
900 901
		width_bytes = ((src_x * pixel_size) & 63) +
					src_w * pixel_size;
902

903 904
		if (INTEL_INFO(dev)->gen < 9 && (src_w > 2048 || src_h > 2048 ||
		    width_bytes > 4096 || fb->pitches[0] > 4096)) {
905 906 907 908 909
			DRM_DEBUG_KMS("Source dimensions exceed hardware limits\n");
			return -EINVAL;
		}
	}

910
	if (state->visible) {
911 912 913 914
		src->x1 = src_x << 16;
		src->x2 = (src_x + src_w) << 16;
		src->y1 = src_y << 16;
		src->y2 = (src_y + src_h) << 16;
915 916 917 918 919 920 921 922 923 924
	}

	dst->x1 = crtc_x;
	dst->x2 = crtc_x + crtc_w;
	dst->y1 = crtc_y;
	dst->y2 = crtc_y + crtc_h;

	return 0;
}

925 926 927 928
static void
intel_commit_sprite_plane(struct drm_plane *plane,
			  struct intel_plane_state *state)
{
929
	struct drm_crtc *crtc = state->base.crtc;
930
	struct intel_plane *intel_plane = to_intel_plane(plane);
931
	struct drm_framebuffer *fb = state->base.fb;
932

933 934
	crtc = crtc ? crtc : plane->crtc;

935
	plane->fb = fb;
936

937
	if (!crtc->state->active)
938 939 940 941 942 943 944 945 946 947 948 949
		return;

	if (state->visible) {
		intel_plane->update_plane(plane, crtc, fb,
					  state->dst.x1, state->dst.y1,
					  drm_rect_width(&state->dst),
					  drm_rect_height(&state->dst),
					  state->src.x1 >> 16,
					  state->src.y1 >> 16,
					  drm_rect_width(&state->src) >> 16,
					  drm_rect_height(&state->src) >> 16);
	} else {
950
		intel_plane->disable_plane(plane, crtc);
951
	}
952 953
}

954 955 956 957 958
int intel_sprite_set_colorkey(struct drm_device *dev, void *data,
			      struct drm_file *file_priv)
{
	struct drm_intel_sprite_colorkey *set = data;
	struct drm_plane *plane;
959 960 961
	struct drm_plane_state *plane_state;
	struct drm_atomic_state *state;
	struct drm_modeset_acquire_ctx ctx;
962 963 964 965 966 967
	int ret = 0;

	/* Make sure we don't try to enable both src & dest simultaneously */
	if ((set->flags & (I915_SET_COLORKEY_DESTINATION | I915_SET_COLORKEY_SOURCE)) == (I915_SET_COLORKEY_DESTINATION | I915_SET_COLORKEY_SOURCE))
		return -EINVAL;

968 969 970 971
	if (IS_VALLEYVIEW(dev) &&
	    set->flags & I915_SET_COLORKEY_DESTINATION)
		return -EINVAL;

R
Rob Clark 已提交
972
	plane = drm_plane_find(dev, set->plane_id);
973 974
	if (!plane || plane->type != DRM_PLANE_TYPE_OVERLAY)
		return -ENOENT;
975

976
	drm_modeset_acquire_init(&ctx, 0);
977

978 979 980 981
	state = drm_atomic_state_alloc(plane->dev);
	if (!state) {
		ret = -ENOMEM;
		goto out;
982
	}
983 984 985 986 987 988 989 990 991
	state->acquire_ctx = &ctx;

	while (1) {
		plane_state = drm_atomic_get_plane_state(state, plane);
		ret = PTR_ERR_OR_ZERO(plane_state);
		if (!ret) {
			to_intel_plane_state(plane_state)->ckey = *set;
			ret = drm_atomic_commit(state);
		}
992

993 994
		if (ret != -EDEADLK)
			break;
995

996 997 998
		drm_atomic_state_clear(state);
		drm_modeset_backoff(&ctx);
	}
999

1000 1001
	if (ret)
		drm_atomic_state_free(state);
1002

1003 1004 1005 1006
out:
	drm_modeset_drop_locks(&ctx);
	drm_modeset_acquire_fini(&ctx);
	return ret;
1007 1008
}

1009
static const uint32_t ilk_plane_formats[] = {
1010 1011 1012 1013 1014 1015 1016
	DRM_FORMAT_XRGB8888,
	DRM_FORMAT_YUYV,
	DRM_FORMAT_YVYU,
	DRM_FORMAT_UYVY,
	DRM_FORMAT_VYUY,
};

1017
static const uint32_t snb_plane_formats[] = {
1018 1019 1020 1021 1022 1023 1024 1025
	DRM_FORMAT_XBGR8888,
	DRM_FORMAT_XRGB8888,
	DRM_FORMAT_YUYV,
	DRM_FORMAT_YVYU,
	DRM_FORMAT_UYVY,
	DRM_FORMAT_VYUY,
};

1026
static const uint32_t vlv_plane_formats[] = {
1027 1028 1029 1030 1031 1032 1033 1034 1035 1036 1037 1038 1039
	DRM_FORMAT_RGB565,
	DRM_FORMAT_ABGR8888,
	DRM_FORMAT_ARGB8888,
	DRM_FORMAT_XBGR8888,
	DRM_FORMAT_XRGB8888,
	DRM_FORMAT_XBGR2101010,
	DRM_FORMAT_ABGR2101010,
	DRM_FORMAT_YUYV,
	DRM_FORMAT_YVYU,
	DRM_FORMAT_UYVY,
	DRM_FORMAT_VYUY,
};

1040 1041 1042 1043 1044 1045 1046 1047 1048 1049 1050 1051
static uint32_t skl_plane_formats[] = {
	DRM_FORMAT_RGB565,
	DRM_FORMAT_ABGR8888,
	DRM_FORMAT_ARGB8888,
	DRM_FORMAT_XBGR8888,
	DRM_FORMAT_XRGB8888,
	DRM_FORMAT_YUYV,
	DRM_FORMAT_YVYU,
	DRM_FORMAT_UYVY,
	DRM_FORMAT_VYUY,
};

1052
int
1053
intel_plane_init(struct drm_device *dev, enum pipe pipe, int plane)
1054 1055
{
	struct intel_plane *intel_plane;
1056
	struct intel_plane_state *state;
1057
	unsigned long possible_crtcs;
1058 1059
	const uint32_t *plane_formats;
	int num_plane_formats;
1060 1061
	int ret;

1062
	if (INTEL_INFO(dev)->gen < 5)
1063 1064
		return -ENODEV;

1065
	intel_plane = kzalloc(sizeof(*intel_plane), GFP_KERNEL);
1066 1067 1068
	if (!intel_plane)
		return -ENOMEM;

1069 1070
	state = intel_create_plane_state(&intel_plane->base);
	if (!state) {
1071 1072 1073
		kfree(intel_plane);
		return -ENOMEM;
	}
1074
	intel_plane->base.state = &state->base;
1075

1076 1077 1078
	switch (INTEL_INFO(dev)->gen) {
	case 5:
	case 6:
1079
		intel_plane->can_scale = true;
1080
		intel_plane->max_downscale = 16;
1081 1082 1083 1084 1085 1086 1087 1088 1089 1090 1091 1092 1093
		intel_plane->update_plane = ilk_update_plane;
		intel_plane->disable_plane = ilk_disable_plane;

		if (IS_GEN6(dev)) {
			plane_formats = snb_plane_formats;
			num_plane_formats = ARRAY_SIZE(snb_plane_formats);
		} else {
			plane_formats = ilk_plane_formats;
			num_plane_formats = ARRAY_SIZE(ilk_plane_formats);
		}
		break;

	case 7:
B
Ben Widawsky 已提交
1094
	case 8:
1095
		if (IS_IVYBRIDGE(dev)) {
1096
			intel_plane->can_scale = true;
1097 1098 1099 1100 1101
			intel_plane->max_downscale = 2;
		} else {
			intel_plane->can_scale = false;
			intel_plane->max_downscale = 1;
		}
1102 1103 1104 1105 1106 1107 1108 1109 1110 1111 1112 1113 1114 1115

		if (IS_VALLEYVIEW(dev)) {
			intel_plane->update_plane = vlv_update_plane;
			intel_plane->disable_plane = vlv_disable_plane;

			plane_formats = vlv_plane_formats;
			num_plane_formats = ARRAY_SIZE(vlv_plane_formats);
		} else {
			intel_plane->update_plane = ivb_update_plane;
			intel_plane->disable_plane = ivb_disable_plane;

			plane_formats = snb_plane_formats;
			num_plane_formats = ARRAY_SIZE(snb_plane_formats);
		}
1116
		break;
1117
	case 9:
1118
		intel_plane->can_scale = true;
1119 1120
		intel_plane->update_plane = skl_update_plane;
		intel_plane->disable_plane = skl_disable_plane;
1121
		state->scaler_id = -1;
1122 1123 1124 1125

		plane_formats = skl_plane_formats;
		num_plane_formats = ARRAY_SIZE(skl_plane_formats);
		break;
1126
	default:
1127
		kfree(intel_plane);
1128
		return -ENODEV;
1129 1130 1131
	}

	intel_plane->pipe = pipe;
1132
	intel_plane->plane = plane;
1133 1134
	intel_plane->check_plane = intel_check_sprite_plane;
	intel_plane->commit_plane = intel_commit_sprite_plane;
1135
	possible_crtcs = (1 << pipe);
1136
	ret = drm_universal_plane_init(dev, &intel_plane->base, possible_crtcs,
1137
				       &intel_plane_funcs,
1138 1139
				       plane_formats, num_plane_formats,
				       DRM_PLANE_TYPE_OVERLAY);
1140
	if (ret) {
1141
		kfree(intel_plane);
1142 1143 1144
		goto out;
	}

1145
	intel_create_rotation_property(dev, intel_plane);
1146

1147 1148
	drm_plane_helper_add(&intel_plane->base, &intel_plane_helper_funcs);

1149
out:
1150 1151
	return ret;
}