setup-pci.c 15.5 KB
Newer Older
L
Linus Torvalds 已提交
1
/*
2 3 4
 *  Copyright (C) 1998-2000  Andre Hedrick <andre@linux-ide.org>
 *  Copyright (C) 1995-1998  Mark Lord
 *  Copyright (C)      2007  Bartlomiej Zolnierkiewicz
5
 *
L
Linus Torvalds 已提交
6 7 8 9 10 11 12 13 14 15 16 17 18 19 20 21 22 23 24 25
 *  May be copied or modified under the terms of the GNU General Public License
 */

#include <linux/types.h>
#include <linux/kernel.h>
#include <linux/pci.h>
#include <linux/init.h>
#include <linux/interrupt.h>
#include <linux/ide.h>
#include <linux/dma-mapping.h>

#include <asm/io.h>

/**
 *	ide_setup_pci_baseregs	-	place a PCI IDE controller native
 *	@dev: PCI device of interface to switch native
 *	@name: Name of interface
 *
 *	We attempt to place the PCI interface into PCI native mode. If
 *	we succeed the BARs are ok and the controller is in PCI mode.
26
 *	Returns 0 on success or an errno code.
L
Linus Torvalds 已提交
27 28 29 30
 *
 *	FIXME: if we program the interface and then fail to set the BARS
 *	we don't switch it back to legacy mode. Do we actually care ??
 */
31 32

static int ide_setup_pci_baseregs(struct pci_dev *dev, const char *name)
L
Linus Torvalds 已提交
33 34 35 36 37 38 39 40 41 42 43 44 45 46 47 48 49 50 51 52 53 54 55 56 57 58 59
{
	u8 progif = 0;

	/*
	 * Place both IDE interfaces into PCI "native" mode:
	 */
	if (pci_read_config_byte(dev, PCI_CLASS_PROG, &progif) ||
			 (progif & 5) != 5) {
		if ((progif & 0xa) != 0xa) {
			printk(KERN_INFO "%s: device not capable of full "
				"native PCI mode\n", name);
			return -EOPNOTSUPP;
		}
		printk("%s: placing both ports into native PCI mode\n", name);
		(void) pci_write_config_byte(dev, PCI_CLASS_PROG, progif|5);
		if (pci_read_config_byte(dev, PCI_CLASS_PROG, &progif) ||
		    (progif & 5) != 5) {
			printk(KERN_ERR "%s: rewrite of PROGIF failed, wanted "
				"0x%04x, got 0x%04x\n",
				name, progif|5, progif);
			return -EOPNOTSUPP;
		}
	}
	return 0;
}

#ifdef CONFIG_BLK_DEV_IDEDMA_PCI
60 61 62 63 64 65 66 67 68 69
static void ide_pci_clear_simplex(unsigned long dma_base, const char *name)
{
	u8 dma_stat = inb(dma_base + 2);

	outb(dma_stat & 0x60, dma_base + 2);
	dma_stat = inb(dma_base + 2);
	if (dma_stat & 0x80)
		printk(KERN_INFO "%s: simplex device: DMA forced\n", name);
}

L
Linus Torvalds 已提交
70
/**
71
 *	ide_pci_dma_base	-	setup BMIBA
72
 *	@hwif: IDE interface
73
 *	@d: IDE port info
L
Linus Torvalds 已提交
74
 *
75
 *	Fetch the DMA Bus-Master-I/O-Base-Address (BMIBA) from PCI space.
L
Linus Torvalds 已提交
76 77
 */

78
unsigned long ide_pci_dma_base(ide_hwif_t *hwif, const struct ide_port_info *d)
L
Linus Torvalds 已提交
79
{
80 81
	struct pci_dev *dev = to_pci_dev(hwif->dev);
	unsigned long dma_base = 0;
L
Linus Torvalds 已提交
82

83
	if (hwif->host_flags & IDE_HFLAG_MMIO)
L
Linus Torvalds 已提交
84 85 86 87 88
		return hwif->dma_base;

	if (hwif->mate && hwif->mate->dma_base) {
		dma_base = hwif->mate->dma_base - (hwif->channel ? 0 : 8);
	} else {
89 90 91 92
		u8 baridx = (d->host_flags & IDE_HFLAG_CS5520) ? 2 : 4;

		dma_base = pci_resource_start(dev, baridx);

93
		if (dma_base == 0) {
94
			printk(KERN_ERR "%s: DMA base is invalid\n", d->name);
95 96
			return 0;
		}
L
Linus Torvalds 已提交
97 98
	}

99 100 101
	if (hwif->channel)
		dma_base += 8;

102 103 104 105 106 107 108 109 110
	return dma_base;
}
EXPORT_SYMBOL_GPL(ide_pci_dma_base);

int ide_pci_check_simplex(ide_hwif_t *hwif, const struct ide_port_info *d)
{
	u8 dma_stat;

	if (d->host_flags & (IDE_HFLAG_MMIO | IDE_HFLAG_CS5520))
111 112 113
		goto out;

	if (d->host_flags & IDE_HFLAG_CLEAR_SIMPLEX) {
114
		ide_pci_clear_simplex(hwif->dma_base, d->name);
115 116 117 118 119 120 121 122 123 124 125 126 127
		goto out;
	}

	/*
	 * If the device claims "simplex" DMA, this means that only one of
	 * the two interfaces can be trusted with DMA at any point in time
	 * (so we should enable DMA only on one of the two interfaces).
	 *
	 * FIXME: At this point we haven't probed the drives so we can't make
	 * the appropriate decision.  Really we should defer this problem until
	 * we tune the drive then try to grab DMA ownership if we want to be
	 * the DMA end.  This has to be become dynamic to handle hot-plug.
	 */
128
	dma_stat = hwif->tp_ops->read_sff_dma_status(hwif);
129 130
	if ((dma_stat & 0x80) && hwif->mate && hwif->mate->dma_base) {
		printk(KERN_INFO "%s: simplex device: DMA disabled\n", d->name);
131
		return -1;
L
Linus Torvalds 已提交
132
	}
133
out:
134
	return 0;
L
Linus Torvalds 已提交
135
}
136
EXPORT_SYMBOL_GPL(ide_pci_check_simplex);
137 138 139 140

/*
 * Set up BM-DMA capability (PnP BIOS should have done this)
 */
141
int ide_pci_set_master(struct pci_dev *dev, const char *name)
142 143 144 145 146 147 148 149 150 151 152 153 154 155 156 157 158 159
{
	u16 pcicmd;

	pci_read_config_word(dev, PCI_COMMAND, &pcicmd);

	if ((pcicmd & PCI_COMMAND_MASTER) == 0) {
		pci_set_master(dev);

		if (pci_read_config_word(dev, PCI_COMMAND, &pcicmd) ||
		    (pcicmd & PCI_COMMAND_MASTER) == 0) {
			printk(KERN_ERR "%s: error updating PCICMD on %s\n",
					name, pci_name(dev));
			return -EIO;
		}
	}

	return 0;
}
160
EXPORT_SYMBOL_GPL(ide_pci_set_master);
L
Linus Torvalds 已提交
161 162
#endif /* CONFIG_BLK_DEV_IDEDMA_PCI */

163
void ide_setup_pci_noise(struct pci_dev *dev, const struct ide_port_info *d)
L
Linus Torvalds 已提交
164
{
165 166 167
	printk(KERN_INFO "%s: IDE controller (0x%04x:0x%04x rev 0x%02x) at "
			 " PCI slot %s\n", d->name, dev->vendor, dev->device,
			 dev->revision, pci_name(dev));
L
Linus Torvalds 已提交
168 169 170 171 172 173 174
}
EXPORT_SYMBOL_GPL(ide_setup_pci_noise);


/**
 *	ide_pci_enable	-	do PCI enables
 *	@dev: PCI device
175
 *	@d: IDE port info
L
Linus Torvalds 已提交
176 177
 *
 *	Enable the IDE PCI device. We attempt to enable the device in full
178 179 180
 *	but if that fails then we only need IO space. The PCI code should
 *	have setup the proper resources for us already for controllers in
 *	legacy mode.
181
 *
L
Linus Torvalds 已提交
182 183
 *	Returns zero on success or an error code
 */
184

185
static int ide_pci_enable(struct pci_dev *dev, const struct ide_port_info *d)
L
Linus Torvalds 已提交
186
{
187
	int ret, bars;
L
Linus Torvalds 已提交
188 189

	if (pci_enable_device(dev)) {
190
		ret = pci_enable_device_io(dev);
L
Linus Torvalds 已提交
191 192 193 194 195 196 197 198 199
		if (ret < 0) {
			printk(KERN_WARNING "%s: (ide_setup_pci_device:) "
				"Could not enable device.\n", d->name);
			goto out;
		}
		printk(KERN_WARNING "%s: BIOS configuration fixed.\n", d->name);
	}

	/*
200 201 202
	 * assume all devices can do 32-bit DMA for now, we can add
	 * a DMA mask field to the struct ide_port_info if we need it
	 * (or let lower level driver set the DMA mask)
L
Linus Torvalds 已提交
203 204 205 206 207 208 209
	 */
	ret = pci_set_dma_mask(dev, DMA_32BIT_MASK);
	if (ret < 0) {
		printk(KERN_ERR "%s: can't set dma mask\n", d->name);
		goto out;
	}

210 211 212 213
	if (d->host_flags & IDE_HFLAG_SINGLE)
		bars = (1 << 2) - 1;
	else
		bars = (1 << 4) - 1;
L
Linus Torvalds 已提交
214

215 216 217 218 219 220 221 222 223 224
	if ((d->host_flags & IDE_HFLAG_NO_DMA) == 0) {
		if (d->host_flags & IDE_HFLAG_CS5520)
			bars |= (1 << 2);
		else
			bars |= (1 << 4);
	}

	ret = pci_request_selected_regions(dev, bars, d->name);
	if (ret < 0)
		printk(KERN_ERR "%s: can't reserve resources\n", d->name);
L
Linus Torvalds 已提交
225 226 227 228 229 230 231
out:
	return ret;
}

/**
 *	ide_pci_configure	-	configure an unconfigured device
 *	@dev: PCI device
232
 *	@d: IDE port info
L
Linus Torvalds 已提交
233 234 235 236
 *
 *	Enable and configure the PCI device we have been passed.
 *	Returns zero on success or an error code.
 */
237

238
static int ide_pci_configure(struct pci_dev *dev, const struct ide_port_info *d)
L
Linus Torvalds 已提交
239 240 241 242 243 244 245 246 247
{
	u16 pcicmd = 0;
	/*
	 * PnP BIOS was *supposed* to have setup this device, but we
	 * can do it ourselves, so long as the BIOS has assigned an IRQ
	 * (or possibly the device is using a "legacy header" for IRQs).
	 * Maybe the user deliberately *disabled* the device,
	 * but we'll eventually ignore it again if no drives respond.
	 */
248 249
	if (ide_setup_pci_baseregs(dev, d->name) ||
	    pci_write_config_word(dev, PCI_COMMAND, pcicmd | PCI_COMMAND_IO)) {
L
Linus Torvalds 已提交
250 251 252 253 254 255 256 257 258 259 260 261 262 263 264 265
		printk(KERN_INFO "%s: device disabled (BIOS)\n", d->name);
		return -ENODEV;
	}
	if (pci_read_config_word(dev, PCI_COMMAND, &pcicmd)) {
		printk(KERN_ERR "%s: error accessing PCI regs\n", d->name);
		return -EIO;
	}
	if (!(pcicmd & PCI_COMMAND_IO)) {
		printk(KERN_ERR "%s: unable to enable IDE controller\n", d->name);
		return -ENXIO;
	}
	return 0;
}

/**
 *	ide_pci_check_iomem	-	check a register is I/O
266 267 268
 *	@dev: PCI device
 *	@d: IDE port info
 *	@bar: BAR number
L
Linus Torvalds 已提交
269
 *
270 271
 *	Checks if a BAR is configured and points to MMIO space. If so,
 *	return an error code. Otherwise return 0
L
Linus Torvalds 已提交
272
 */
273

274 275
static int ide_pci_check_iomem(struct pci_dev *dev, const struct ide_port_info *d,
			       int bar)
L
Linus Torvalds 已提交
276 277
{
	ulong flags = pci_resource_flags(dev, bar);
278

L
Linus Torvalds 已提交
279 280 281 282
	/* Unconfigured ? */
	if (!flags || pci_resource_len(dev, bar) == 0)
		return 0;

283 284
	/* I/O space */
	if (flags & IORESOURCE_IO)
L
Linus Torvalds 已提交
285
		return 0;
286

L
Linus Torvalds 已提交
287 288 289 290 291 292 293
	/* Bad */
	return -EINVAL;
}

/**
 *	ide_hwif_configure	-	configure an IDE interface
 *	@dev: PCI device holding interface
294
 *	@d: IDE port info
295 296
 *	@port: port number
 *	@irq: PCI IRQ
297
 *	@hw: hw_regs_t instance corresponding to this port
L
Linus Torvalds 已提交
298 299 300 301 302 303 304
 *
 *	Perform the initial set up for the hardware interface structure. This
 *	is done per interface port rather than per PCI device. There may be
 *	more than one port per device.
 *
 *	Returns the new hardware interface structure, or NULL on a failure
 */
305

306 307
static ide_hwif_t *ide_hwif_configure(struct pci_dev *dev,
				      const struct ide_port_info *d,
308 309
				      unsigned int port, int irq,
				      hw_regs_t *hw)
L
Linus Torvalds 已提交
310 311 312 313
{
	unsigned long ctl = 0, base = 0;
	ide_hwif_t *hwif;

314
	if ((d->host_flags & IDE_HFLAG_ISA_PORTS) == 0) {
315 316 317 318 319 320
		if (ide_pci_check_iomem(dev, d, 2 * port) ||
		    ide_pci_check_iomem(dev, d, 2 * port + 1)) {
			printk(KERN_ERR "%s: I/O baseregs (BIOS) are reported "
					"as MEM for port %d!\n", d->name, port);
			return NULL;
		}
321

L
Linus Torvalds 已提交
322 323
		ctl  = pci_resource_start(dev, 2*port+1);
		base = pci_resource_start(dev, 2*port);
324
	} else {
L
Linus Torvalds 已提交
325 326 327 328
		/* Use default values */
		ctl = port ? 0x374 : 0x3f4;
		base = port ? 0x170 : 0x1f0;
	}
329

330 331 332 333 334 335
	if (!base || !ctl) {
		printk(KERN_ERR "%s: bad PCI BARs for port %d, skipping\n",
				d->name, port);
		return NULL;
	}

336 337 338 339 340 341
	memset(hw, 0, sizeof(*hw));
	hw->irq = irq;
	hw->dev = &dev->dev;
	hw->chipset = d->chipset ? d->chipset : ide_pci;
	ide_std_init_ports(hw, base, ctl | 2);

342
	hwif = ide_find_port_slot(d);
343
	if (hwif == NULL)
344
		return NULL;
345

346
	hwif->chipset = hw->chipset;
347

L
Linus Torvalds 已提交
348 349 350
	return hwif;
}

351
#ifdef CONFIG_BLK_DEV_IDEDMA_PCI
L
Linus Torvalds 已提交
352 353
/**
 *	ide_hwif_setup_dma	-	configure DMA interface
354
 *	@hwif: IDE interface
355
 *	@d: IDE port info
L
Linus Torvalds 已提交
356 357 358 359 360
 *
 *	Set up the DMA base for the interface. Enable the master bits as
 *	necessary and attempt to bring the device DMA into a ready to use
 *	state
 */
361

362
int ide_hwif_setup_dma(ide_hwif_t *hwif, const struct ide_port_info *d)
L
Linus Torvalds 已提交
363
{
364
	struct pci_dev *dev = to_pci_dev(hwif->dev);
L
Linus Torvalds 已提交
365

366
	if ((d->host_flags & IDE_HFLAG_NO_AUTODMA) == 0 ||
L
Linus Torvalds 已提交
367 368
	    ((dev->class >> 8) == PCI_CLASS_STORAGE_IDE &&
	     (dev->class & 0x80))) {
369
		unsigned long base = ide_pci_dma_base(hwif, d);
370

371 372 373 374 375 376 377 378 379
		if (base == 0)
			return -1;

		hwif->dma_base = base;

		if (ide_pci_check_simplex(hwif, d) < 0)
			return -1;

		if (ide_pci_set_master(dev, d->name) < 0)
380
			return -1;
381

382
		if (hwif->host_flags & IDE_HFLAG_MMIO)
383 384 385 386 387 388 389
			printk(KERN_INFO "    %s: MMIO-DMA\n", hwif->name);
		else
			printk(KERN_INFO "    %s: BM-DMA at 0x%04lx-0x%04lx\n",
					 hwif->name, base, base + 7);

		hwif->extra_base = base + (hwif->channel ? 8 : 16);

390 391
		if (ide_allocate_dma_engine(hwif))
			return -1;
392

393
		hwif->dma_ops = &sff_dma_ops;
394
	}
395

396
	return 0;
397
}
398
#endif /* CONFIG_BLK_DEV_IDEDMA_PCI */
L
Linus Torvalds 已提交
399 400 401 402

/**
 *	ide_setup_pci_controller	-	set up IDE PCI
 *	@dev: PCI device
403
 *	@d: IDE port info
L
Linus Torvalds 已提交
404 405 406 407 408 409 410
 *	@noisy: verbose flag
 *	@config: returned as 1 if we configured the hardware
 *
 *	Set up the PCI and controller side of the IDE interface. This brings
 *	up the PCI side of the device, checks that the device is enabled
 *	and enables it if need be
 */
411

412
static int ide_setup_pci_controller(struct pci_dev *dev, const struct ide_port_info *d, int noisy, int *config)
L
Linus Torvalds 已提交
413 414 415 416 417 418 419 420 421 422 423 424 425 426 427 428 429 430 431 432 433 434 435 436 437 438 439 440 441 442 443
{
	int ret;
	u16 pcicmd;

	if (noisy)
		ide_setup_pci_noise(dev, d);

	ret = ide_pci_enable(dev, d);
	if (ret < 0)
		goto out;

	ret = pci_read_config_word(dev, PCI_COMMAND, &pcicmd);
	if (ret < 0) {
		printk(KERN_ERR "%s: error accessing PCI regs\n", d->name);
		goto out;
	}
	if (!(pcicmd & PCI_COMMAND_IO)) {	/* is device disabled? */
		ret = ide_pci_configure(dev, d);
		if (ret < 0)
			goto out;
		*config = 1;
		printk(KERN_INFO "%s: device enabled (Linux)\n", d->name);
	}

out:
	return ret;
}

/**
 *	ide_pci_setup_ports	-	configure ports/devices on PCI IDE
 *	@dev: PCI device
444
 *	@d: IDE port info
L
Linus Torvalds 已提交
445
 *	@pciirq: IRQ line
446
 *	@idx: ATA index table to update
447 448
 *	@hw: hw_regs_t instances corresponding to this PCI IDE device
 *	@hws: hw_regs_t pointers table to update
L
Linus Torvalds 已提交
449 450 451 452 453 454 455 456 457
 *
 *	Scan the interfaces attached to this device and do any
 *	necessary per port setup. Attach the devices and ask the
 *	generic DMA layer to do its work for us.
 *
 *	Normally called automaticall from do_ide_pci_setup_device,
 *	but is also used directly as a helper function by some controllers
 *	where the chipset setup is not the default PCI IDE one.
 */
458

459 460
void ide_pci_setup_ports(struct pci_dev *dev, const struct ide_port_info *d,
			 int pciirq, u8 *idx, hw_regs_t *hw, hw_regs_t **hws)
L
Linus Torvalds 已提交
461
{
462
	int channels = (d->host_flags & IDE_HFLAG_SINGLE) ? 1 : 2, port;
463
	ide_hwif_t *hwif;
L
Linus Torvalds 已提交
464 465 466 467 468
	u8 tmp;

	/*
	 * Set up the IDE ports
	 */
469

470
	for (port = 0; port < channels; ++port) {
471 472
		const ide_pci_enablebit_t *e = &(d->enablebits[port]);

L
Linus Torvalds 已提交
473
		if (e->reg && (pci_read_config_byte(dev, e->reg, &tmp) ||
474 475
		    (tmp & e->mask) != e->val)) {
			printk(KERN_INFO "%s: IDE port disabled\n", d->name);
L
Linus Torvalds 已提交
476
			continue;	/* port not enabled */
477
		}
L
Linus Torvalds 已提交
478

479
		hwif = ide_hwif_configure(dev, d, port, pciirq, hw + port);
480
		if (hwif == NULL)
L
Linus Torvalds 已提交
481 482
			continue;

483
		*(hws + port) = hw + port;
484
		*(idx + port) = hwif->index;
485
	}
L
Linus Torvalds 已提交
486 487 488 489 490 491 492 493 494 495
}
EXPORT_SYMBOL_GPL(ide_pci_setup_ports);

/*
 * ide_setup_pci_device() looks at the primary/secondary interfaces
 * on a PCI IDE device and, if they are enabled, prepares the IDE driver
 * for use with them.  This generic code works for most PCI chipsets.
 *
 * One thing that is not standardized is the location of the
 * primary/secondary interface "enable/disable" bits.  For chipsets that
496
 * we "know" about, this information is in the struct ide_port_info;
L
Linus Torvalds 已提交
497 498
 * for all other chipsets, we just assume both interfaces are enabled.
 */
499
static int do_ide_setup_pci_device(struct pci_dev *dev,
500
				   const struct ide_port_info *d,
501
				   u8 noisy)
L
Linus Torvalds 已提交
502 503 504 505 506 507 508 509 510 511 512 513 514 515 516 517 518 519 520 521 522 523 524 525 526 527 528 529 530 531 532 533 534 535 536 537 538 539 540 541 542 543 544 545 546 547 548 549
{
	int tried_config = 0;
	int pciirq, ret;

	ret = ide_setup_pci_controller(dev, d, noisy, &tried_config);
	if (ret < 0)
		goto out;

	/*
	 * Can we trust the reported IRQ?
	 */
	pciirq = dev->irq;

	/* Is it an "IDE storage" device in non-PCI mode? */
	if ((dev->class >> 8) == PCI_CLASS_STORAGE_IDE && (dev->class & 5) != 5) {
		if (noisy)
			printk(KERN_INFO "%s: not 100%% native mode: "
				"will probe irqs later\n", d->name);
		/*
		 * This allows offboard ide-pci cards the enable a BIOS,
		 * verify interrupt settings of split-mirror pci-config
		 * space, place chipset into init-mode, and/or preserve
		 * an interrupt if the card is not native ide support.
		 */
		ret = d->init_chipset ? d->init_chipset(dev, d->name) : 0;
		if (ret < 0)
			goto out;
		pciirq = ret;
	} else if (tried_config) {
		if (noisy)
			printk(KERN_INFO "%s: will probe irqs later\n", d->name);
		pciirq = 0;
	} else if (!pciirq) {
		if (noisy)
			printk(KERN_WARNING "%s: bad irq (%d): will probe later\n",
				d->name, pciirq);
		pciirq = 0;
	} else {
		if (d->init_chipset) {
			ret = d->init_chipset(dev, d->name);
			if (ret < 0)
				goto out;
		}
		if (noisy)
			printk(KERN_INFO "%s: 100%% native mode on irq %d\n",
				d->name, pciirq);
	}

550
	ret = pciirq;
L
Linus Torvalds 已提交
551 552 553 554
out:
	return ret;
}

555
int ide_setup_pci_device(struct pci_dev *dev, const struct ide_port_info *d)
L
Linus Torvalds 已提交
556
{
557
	u8 idx[4] = { 0xff, 0xff, 0xff, 0xff };
558
	hw_regs_t hw[4], *hws[] = { NULL, NULL, NULL, NULL };
L
Linus Torvalds 已提交
559 560
	int ret;

561 562 563 564
	ret = do_ide_setup_pci_device(dev, d, 1);

	if (ret >= 0) {
		/* FIXME: silent failure can happen */
565
		ide_pci_setup_ports(dev, d, ret, &idx[0], &hw[0], &hws[0]);
L
Linus Torvalds 已提交
566

567
		ide_device_add(idx, d, hws);
568
	}
L
Linus Torvalds 已提交
569 570 571 572 573 574

	return ret;
}
EXPORT_SYMBOL_GPL(ide_setup_pci_device);

int ide_setup_pci_devices(struct pci_dev *dev1, struct pci_dev *dev2,
575
			  const struct ide_port_info *d)
L
Linus Torvalds 已提交
576 577 578
{
	struct pci_dev *pdev[] = { dev1, dev2 };
	int ret, i;
579
	hw_regs_t hw[4], *hws[] = { NULL, NULL, NULL, NULL };
580
	u8 idx[4] = { 0xff, 0xff, 0xff, 0xff };
L
Linus Torvalds 已提交
581 582

	for (i = 0; i < 2; i++) {
583 584
		ret = do_ide_setup_pci_device(pdev[i], d, !i);

L
Linus Torvalds 已提交
585 586 587 588 589 590
		/*
		 * FIXME: Mom, mom, they stole me the helper function to undo
		 * do_ide_setup_pci_device() on the first device!
		 */
		if (ret < 0)
			goto out;
591 592

		/* FIXME: silent failure can happen */
593 594
		ide_pci_setup_ports(pdev[i], d, ret, &idx[i*2], &hw[i*2],
				    &hws[i*2]);
L
Linus Torvalds 已提交
595 596
	}

597
	ide_device_add(idx, d, hws);
L
Linus Torvalds 已提交
598 599 600 601
out:
	return ret;
}
EXPORT_SYMBOL_GPL(ide_setup_pci_devices);