intel_workarounds.c 60.4 KB
Newer Older
1 2 3 4 5 6 7
/*
 * SPDX-License-Identifier: MIT
 *
 * Copyright © 2014-2018 Intel Corporation
 */

#include "i915_drv.h"
8
#include "intel_context.h"
9
#include "intel_engine_pm.h"
10
#include "intel_gpu_commands.h"
11
#include "intel_gt.h"
12
#include "intel_ring.h"
13 14 15 16 17 18 19 20 21 22 23 24 25 26 27 28 29 30 31 32 33 34 35 36 37 38 39 40 41 42 43 44
#include "intel_workarounds.h"

/**
 * DOC: Hardware workarounds
 *
 * This file is intended as a central place to implement most [1]_ of the
 * required workarounds for hardware to work as originally intended. They fall
 * in five basic categories depending on how/when they are applied:
 *
 * - Workarounds that touch registers that are saved/restored to/from the HW
 *   context image. The list is emitted (via Load Register Immediate commands)
 *   everytime a new context is created.
 * - GT workarounds. The list of these WAs is applied whenever these registers
 *   revert to default values (on GPU reset, suspend/resume [2]_, etc..).
 * - Display workarounds. The list is applied during display clock-gating
 *   initialization.
 * - Workarounds that whitelist a privileged register, so that UMDs can manage
 *   them directly. This is just a special case of a MMMIO workaround (as we
 *   write the list of these to/be-whitelisted registers to some special HW
 *   registers).
 * - Workaround batchbuffers, that get executed automatically by the hardware
 *   on every HW context restore.
 *
 * .. [1] Please notice that there are other WAs that, due to their nature,
 *    cannot be applied from a central place. Those are peppered around the rest
 *    of the code, as needed.
 *
 * .. [2] Technically, some registers are powercontext saved & restored, so they
 *    survive a suspend/resume. In practice, writing them again is not too
 *    costly and simplifies things. We can revisit this in the future.
 *
 * Layout
45
 * ~~~~~~
46 47 48 49 50 51 52 53 54 55
 *
 * Keep things in this file ordered by WA type, as per the above (context, GT,
 * display, register whitelist, batchbuffer). Then, inside each type, keep the
 * following order:
 *
 * - Infrastructure functions and macros
 * - WAs per platform in standard gen/chrono order
 * - Public functions to init or apply the given workaround type.
 */

56
static void wa_init_start(struct i915_wa_list *wal, const char *name, const char *engine_name)
57 58
{
	wal->name = name;
59
	wal->engine_name = engine_name;
60 61
}

62 63
#define WA_LIST_CHUNK (1 << 4)

64 65
static void wa_init_finish(struct i915_wa_list *wal)
{
66 67 68 69 70 71 72 73 74 75 76 77
	/* Trim unused entries. */
	if (!IS_ALIGNED(wal->count, WA_LIST_CHUNK)) {
		struct i915_wa *list = kmemdup(wal->list,
					       wal->count * sizeof(*list),
					       GFP_KERNEL);

		if (list) {
			kfree(wal->list);
			wal->list = list;
		}
	}

78 79 80
	if (!wal->count)
		return;

81 82
	DRM_DEBUG_DRIVER("Initialized %u %s workarounds on %s\n",
			 wal->wa_count, wal->name, wal->engine_name);
83 84
}

85
static void _wa_add(struct i915_wa_list *wal, const struct i915_wa *wa)
86
{
87 88
	unsigned int addr = i915_mmio_reg_offset(wa->reg);
	unsigned int start = 0, end = wal->count;
89
	const unsigned int grow = WA_LIST_CHUNK;
90 91 92 93 94 95 96 97 98 99 100 101 102 103
	struct i915_wa *wa_;

	GEM_BUG_ON(!is_power_of_2(grow));

	if (IS_ALIGNED(wal->count, grow)) { /* Either uninitialized or full. */
		struct i915_wa *list;

		list = kmalloc_array(ALIGN(wal->count + 1, grow), sizeof(*wa),
				     GFP_KERNEL);
		if (!list) {
			DRM_ERROR("No space for workaround init!\n");
			return;
		}

104
		if (wal->list) {
105
			memcpy(list, wal->list, sizeof(*wa) * wal->count);
106 107
			kfree(wal->list);
		}
108 109 110

		wal->list = list;
	}
111 112 113 114

	while (start < end) {
		unsigned int mid = start + (end - start) / 2;

115
		if (i915_mmio_reg_offset(wal->list[mid].reg) < addr) {
116
			start = mid + 1;
117
		} else if (i915_mmio_reg_offset(wal->list[mid].reg) > addr) {
118 119
			end = mid;
		} else {
120
			wa_ = &wal->list[mid];
121

122 123
			if ((wa->clr | wa_->clr) && !(wa->clr & ~wa_->clr)) {
				DRM_ERROR("Discarding overwritten w/a for reg %04x (clear: %08x, set: %08x)\n",
124
					  i915_mmio_reg_offset(wa_->reg),
125
					  wa_->clr, wa_->set);
126

127
				wa_->set &= ~wa->clr;
128 129
			}

130
			wal->wa_count++;
131 132
			wa_->set |= wa->set;
			wa_->clr |= wa->clr;
133
			wa_->read |= wa->read;
134 135 136
			return;
		}
	}
137

138 139 140
	wal->wa_count++;
	wa_ = &wal->list[wal->count++];
	*wa_ = *wa;
141

142 143 144 145 146
	while (wa_-- > wal->list) {
		GEM_BUG_ON(i915_mmio_reg_offset(wa_[0].reg) ==
			   i915_mmio_reg_offset(wa_[1].reg));
		if (i915_mmio_reg_offset(wa_[1].reg) >
		    i915_mmio_reg_offset(wa_[0].reg))
147
			break;
148

149
		swap(wa_[1], wa_[0]);
150
	}
151 152
}

153 154
static void wa_add(struct i915_wa_list *wal, i915_reg_t reg,
		   u32 clear, u32 set, u32 read_mask)
155 156
{
	struct i915_wa wa = {
157
		.reg  = reg,
158 159
		.clr  = clear,
		.set  = set,
160
		.read = read_mask,
161 162 163 164 165
	};

	_wa_add(wal, &wa);
}

166
static void
167
wa_write_clr_set(struct i915_wa_list *wal, i915_reg_t reg, u32 clear, u32 set)
168
{
169
	wa_add(wal, reg, clear, set, clear);
170 171
}

172
static void
173 174
wa_write(struct i915_wa_list *wal, i915_reg_t reg, u32 set)
{
175
	wa_write_clr_set(wal, reg, ~0, set);
176 177 178 179
}

static void
wa_write_or(struct i915_wa_list *wal, i915_reg_t reg, u32 set)
180
{
181
	wa_write_clr_set(wal, reg, set, set);
182 183
}

184 185 186
static void
wa_write_clr(struct i915_wa_list *wal, i915_reg_t reg, u32 clr)
{
187
	wa_write_clr_set(wal, reg, clr, 0);
188 189
}

190 191 192 193 194 195 196 197 198 199 200
/*
 * WA operations on "masked register". A masked register has the upper 16 bits
 * documented as "masked" in b-spec. Its purpose is to allow writing to just a
 * portion of the register without a rmw: you simply write in the upper 16 bits
 * the mask of bits you are going to modify.
 *
 * The wa_masked_* family of functions already does the necessary operations to
 * calculate the mask based on the parameters passed, so user only has to
 * provide the lower 16 bits of that register.
 */

201
static void
202
wa_masked_en(struct i915_wa_list *wal, i915_reg_t reg, u32 val)
203
{
204
	wa_add(wal, reg, 0, _MASKED_BIT_ENABLE(val), val);
205 206 207
}

static void
208
wa_masked_dis(struct i915_wa_list *wal, i915_reg_t reg, u32 val)
209
{
210
	wa_add(wal, reg, 0, _MASKED_BIT_DISABLE(val), val);
211 212
}

213 214 215 216
static void
wa_masked_field_set(struct i915_wa_list *wal, i915_reg_t reg,
		    u32 mask, u32 val)
{
217
	wa_add(wal, reg, 0, _MASKED_FIELD(mask, val), mask);
218
}
219

220 221 222
static void gen6_ctx_workarounds_init(struct intel_engine_cs *engine,
				      struct i915_wa_list *wal)
{
223
	wa_masked_en(wal, INSTPM, INSTPM_FORCE_ORDERING);
224 225 226 227 228
}

static void gen7_ctx_workarounds_init(struct intel_engine_cs *engine,
				      struct i915_wa_list *wal)
{
229
	wa_masked_en(wal, INSTPM, INSTPM_FORCE_ORDERING);
230 231
}

232 233
static void gen8_ctx_workarounds_init(struct intel_engine_cs *engine,
				      struct i915_wa_list *wal)
234
{
235
	wa_masked_en(wal, INSTPM, INSTPM_FORCE_ORDERING);
236 237

	/* WaDisableAsyncFlipPerfMode:bdw,chv */
238
	wa_masked_en(wal, MI_MODE, ASYNC_FLIP_PERF_DISABLE);
239 240

	/* WaDisablePartialInstShootdown:bdw,chv */
241 242
	wa_masked_en(wal, GEN8_ROW_CHICKEN,
		     PARTIAL_INSTRUCTION_SHOOTDOWN_DISABLE);
243 244 245 246 247 248 249

	/* Use Force Non-Coherent whenever executing a 3D context. This is a
	 * workaround for for a possible hang in the unlikely event a TLB
	 * invalidation occurs during a PSD flush.
	 */
	/* WaForceEnableNonCoherent:bdw,chv */
	/* WaHdcDisableFetchWhenMasked:bdw,chv */
250 251 252
	wa_masked_en(wal, HDC_CHICKEN0,
		     HDC_DONOT_FETCH_MEM_WHEN_MASKED |
		     HDC_FORCE_NON_COHERENT);
253 254 255 256 257 258 259 260 261

	/* From the Haswell PRM, Command Reference: Registers, CACHE_MODE_0:
	 * "The Hierarchical Z RAW Stall Optimization allows non-overlapping
	 *  polygons in the same 8x4 pixel/sample area to be processed without
	 *  stalling waiting for the earlier ones to write to Hierarchical Z
	 *  buffer."
	 *
	 * This optimization is off by default for BDW and CHV; turn it on.
	 */
262
	wa_masked_dis(wal, CACHE_MODE_0_GEN7, HIZ_RAW_STALL_OPT_DISABLE);
263 264

	/* Wa4x4STCOptimizationDisable:bdw,chv */
265
	wa_masked_en(wal, CACHE_MODE_1, GEN8_4x4_STC_OPTIMIZATION_DISABLE);
266 267 268 269 270 271 272 273 274

	/*
	 * BSpec recommends 8x4 when MSAA is used,
	 * however in practice 16x4 seems fastest.
	 *
	 * Note that PS/WM thread counts depend on the WIZ hashing
	 * disable bit, which we don't touch here, but it's good
	 * to keep in mind (see 3DSTATE_PS and 3DSTATE_WM).
	 */
275
	wa_masked_field_set(wal, GEN7_GT_MODE,
276 277 278 279
			    GEN6_WIZ_HASHING_MASK,
			    GEN6_WIZ_HASHING_16x4);
}

280 281
static void bdw_ctx_workarounds_init(struct intel_engine_cs *engine,
				     struct i915_wa_list *wal)
282
{
283
	struct drm_i915_private *i915 = engine->i915;
284

285
	gen8_ctx_workarounds_init(engine, wal);
286 287

	/* WaDisableThreadStallDopClockGating:bdw (pre-production) */
288
	wa_masked_en(wal, GEN8_ROW_CHICKEN, STALL_DOP_GATING_DISABLE);
289 290 291

	/* WaDisableDopClockGating:bdw
	 *
292
	 * Also see the related UCGTCL1 write in bdw_init_clock_gating()
293 294
	 * to disable EUTC clock gating.
	 */
295 296
	wa_masked_en(wal, GEN7_ROW_CHICKEN2,
		     DOP_CLOCK_GATING_DISABLE);
297

298 299
	wa_masked_en(wal, HALF_SLICE_CHICKEN3,
		     GEN8_SAMPLER_POWER_BYPASS_DIS);
300

301 302 303 304 305
	wa_masked_en(wal, HDC_CHICKEN0,
		     /* WaForceContextSaveRestoreNonCoherent:bdw */
		     HDC_FORCE_CONTEXT_SAVE_RESTORE_NON_COHERENT |
		     /* WaDisableFenceDestinationToSLM:bdw (pre-prod) */
		     (IS_BDW_GT3(i915) ? HDC_FENCE_DEST_SLM_DISABLE : 0));
306 307
}

308 309
static void chv_ctx_workarounds_init(struct intel_engine_cs *engine,
				     struct i915_wa_list *wal)
310
{
311
	gen8_ctx_workarounds_init(engine, wal);
312 313

	/* WaDisableThreadStallDopClockGating:chv */
314
	wa_masked_en(wal, GEN8_ROW_CHICKEN, STALL_DOP_GATING_DISABLE);
315 316

	/* Improve HiZ throughput on CHV. */
317
	wa_masked_en(wal, HIZ_CHICKEN, CHV_HZ_8X8_MODE_IN_1X);
318 319
}

320 321
static void gen9_ctx_workarounds_init(struct intel_engine_cs *engine,
				      struct i915_wa_list *wal)
322
{
323 324 325
	struct drm_i915_private *i915 = engine->i915;

	if (HAS_LLC(i915)) {
326 327 328 329 330
		/* WaCompressedResourceSamplerPbeMediaNewHashMode:skl,kbl
		 *
		 * Must match Display Engine. See
		 * WaCompressedResourceDisplayNewHashMode.
		 */
331 332 333 334
		wa_masked_en(wal, COMMON_SLICE_CHICKEN2,
			     GEN9_PBE_COMPRESSED_HASH_SELECTION);
		wa_masked_en(wal, GEN9_HALF_SLICE_CHICKEN7,
			     GEN9_SAMPLER_HASH_COMPRESSED_READ_ADDR);
335 336 337 338
	}

	/* WaClearFlowControlGpgpuContextSave:skl,bxt,kbl,glk,cfl */
	/* WaDisablePartialInstShootdown:skl,bxt,kbl,glk,cfl */
339 340 341
	wa_masked_en(wal, GEN8_ROW_CHICKEN,
		     FLOW_CONTROL_ENABLE |
		     PARTIAL_INSTRUCTION_SHOOTDOWN_DISABLE);
342 343 344

	/* WaEnableYV12BugFixInHalfSliceChicken7:skl,bxt,kbl,glk,cfl */
	/* WaEnableSamplerGPGPUPreemptionSupport:skl,bxt,kbl,cfl */
345 346 347
	wa_masked_en(wal, GEN9_HALF_SLICE_CHICKEN7,
		     GEN9_ENABLE_YV12_BUGFIX |
		     GEN9_ENABLE_GPGPU_PREEMPTION);
348 349 350

	/* Wa4x4STCOptimizationDisable:skl,bxt,kbl,glk,cfl */
	/* WaDisablePartialResolveInVc:skl,bxt,kbl,cfl */
351 352 353
	wa_masked_en(wal, CACHE_MODE_1,
		     GEN8_4x4_STC_OPTIMIZATION_DISABLE |
		     GEN9_PARTIAL_RESOLVE_IN_VC_DISABLE);
354 355

	/* WaCcsTlbPrefetchDisable:skl,bxt,kbl,glk,cfl */
356 357
	wa_masked_dis(wal, GEN9_HALF_SLICE_CHICKEN5,
		      GEN9_CCS_TLB_PREFETCH_ENABLE);
358 359

	/* WaForceContextSaveRestoreNonCoherent:skl,bxt,kbl,cfl */
360 361 362
	wa_masked_en(wal, HDC_CHICKEN0,
		     HDC_FORCE_CONTEXT_SAVE_RESTORE_NON_COHERENT |
		     HDC_FORCE_CSR_NON_COHERENT_OVR_DISABLE);
363 364 365 366 367 368 369 370 371 372 373 374 375 376 377

	/* WaForceEnableNonCoherent and WaDisableHDCInvalidation are
	 * both tied to WaForceContextSaveRestoreNonCoherent
	 * in some hsds for skl. We keep the tie for all gen9. The
	 * documentation is a bit hazy and so we want to get common behaviour,
	 * even though there is no clear evidence we would need both on kbl/bxt.
	 * This area has been source of system hangs so we play it safe
	 * and mimic the skl regardless of what bspec says.
	 *
	 * Use Force Non-Coherent whenever executing a 3D context. This
	 * is a workaround for a possible hang in the unlikely event
	 * a TLB invalidation occurs during a PSD flush.
	 */

	/* WaForceEnableNonCoherent:skl,bxt,kbl,cfl */
378 379
	wa_masked_en(wal, HDC_CHICKEN0,
		     HDC_FORCE_NON_COHERENT);
380 381

	/* WaDisableSamplerPowerBypassForSOPingPong:skl,bxt,kbl,cfl */
382 383 384 385
	if (IS_SKYLAKE(i915) ||
	    IS_KABYLAKE(i915) ||
	    IS_COFFEELAKE(i915) ||
	    IS_COMETLAKE(i915))
386 387
		wa_masked_en(wal, HALF_SLICE_CHICKEN3,
			     GEN8_SAMPLER_POWER_BYPASS_DIS);
388 389

	/* WaDisableSTUnitPowerOptimization:skl,bxt,kbl,glk,cfl */
390
	wa_masked_en(wal, HALF_SLICE_CHICKEN2, GEN8_ST_PO_DISABLE);
391 392 393 394 395 396 397 398 399 400 401 402 403

	/*
	 * Supporting preemption with fine-granularity requires changes in the
	 * batch buffer programming. Since we can't break old userspace, we
	 * need to set our default preemption level to safe value. Userspace is
	 * still able to use more fine-grained preemption levels, since in
	 * WaEnablePreemptionGranularityControlByUMD we're whitelisting the
	 * per-ctx register. As such, WaDisable{3D,GPGPU}MidCmdPreemption are
	 * not real HW workarounds, but merely a way to start using preemption
	 * while maintaining old contract with userspace.
	 */

	/* WaDisable3DMidCmdPreemption:skl,bxt,glk,cfl,[cnl] */
404
	wa_masked_dis(wal, GEN8_CS_CHICKEN1, GEN9_PREEMPT_3D_OBJECT_LEVEL);
405 406

	/* WaDisableGPGPUMidCmdPreemption:skl,bxt,blk,cfl,[cnl] */
407
	wa_masked_field_set(wal, GEN8_CS_CHICKEN1,
408 409 410
			    GEN9_PREEMPT_GPGPU_LEVEL_MASK,
			    GEN9_PREEMPT_GPGPU_COMMAND_LEVEL);

411
	/* WaClearHIZ_WM_CHICKEN3:bxt,glk */
412
	if (IS_GEN9_LP(i915))
413
		wa_masked_en(wal, GEN9_WM_CHICKEN3, GEN9_FACTOR_IN_CLR_VAL_HIZ);
414 415
}

416 417
static void skl_tune_iz_hashing(struct intel_engine_cs *engine,
				struct i915_wa_list *wal)
418
{
419
	struct intel_gt *gt = engine->gt;
420 421 422 423 424 425 426 427 428 429
	u8 vals[3] = { 0, 0, 0 };
	unsigned int i;

	for (i = 0; i < 3; i++) {
		u8 ss;

		/*
		 * Only consider slices where one, and only one, subslice has 7
		 * EUs
		 */
430
		if (!is_power_of_2(gt->info.sseu.subslice_7eu[i]))
431 432 433 434 435 436 437 438
			continue;

		/*
		 * subslice_7eu[i] != 0 (because of the check above) and
		 * ss_max == 4 (maximum number of subslices possible per slice)
		 *
		 * ->    0 <= ss <= 3;
		 */
439
		ss = ffs(gt->info.sseu.subslice_7eu[i]) - 1;
440 441 442 443
		vals[i] = 3 - ss;
	}

	if (vals[0] == 0 && vals[1] == 0 && vals[2] == 0)
444
		return;
445 446

	/* Tune IZ hashing. See intel_device_info_runtime_init() */
447
	wa_masked_field_set(wal, GEN7_GT_MODE,
448 449 450 451 452 453 454 455
			    GEN9_IZ_HASHING_MASK(2) |
			    GEN9_IZ_HASHING_MASK(1) |
			    GEN9_IZ_HASHING_MASK(0),
			    GEN9_IZ_HASHING(2, vals[2]) |
			    GEN9_IZ_HASHING(1, vals[1]) |
			    GEN9_IZ_HASHING(0, vals[0]));
}

456 457
static void skl_ctx_workarounds_init(struct intel_engine_cs *engine,
				     struct i915_wa_list *wal)
458
{
459 460
	gen9_ctx_workarounds_init(engine, wal);
	skl_tune_iz_hashing(engine, wal);
461
}
462

463 464
static void bxt_ctx_workarounds_init(struct intel_engine_cs *engine,
				     struct i915_wa_list *wal)
465
{
466
	gen9_ctx_workarounds_init(engine, wal);
467

468
	/* WaDisableThreadStallDopClockGating:bxt */
469 470
	wa_masked_en(wal, GEN8_ROW_CHICKEN,
		     STALL_DOP_GATING_DISABLE);
471 472

	/* WaToEnableHwFixForPushConstHWBug:bxt */
473 474
	wa_masked_en(wal, COMMON_SLICE_CHICKEN2,
		     GEN8_SBE_DISABLE_REPLAY_BUF_OPTIMIZATION);
475 476
}

477 478
static void kbl_ctx_workarounds_init(struct intel_engine_cs *engine,
				     struct i915_wa_list *wal)
479
{
480
	struct drm_i915_private *i915 = engine->i915;
481

482
	gen9_ctx_workarounds_init(engine, wal);
483

484
	/* WaToEnableHwFixForPushConstHWBug:kbl */
485
	if (IS_KBL_GT_STEP(i915, STEP_C0, STEP_FOREVER))
486 487
		wa_masked_en(wal, COMMON_SLICE_CHICKEN2,
			     GEN8_SBE_DISABLE_REPLAY_BUF_OPTIMIZATION);
488

489
	/* WaDisableSbeCacheDispatchPortSharing:kbl */
490 491
	wa_masked_en(wal, GEN7_HALF_SLICE_CHICKEN1,
		     GEN7_SBE_SS_CACHE_DISPATCH_PORT_SHARING_DISABLE);
492 493
}

494 495
static void glk_ctx_workarounds_init(struct intel_engine_cs *engine,
				     struct i915_wa_list *wal)
496
{
497
	gen9_ctx_workarounds_init(engine, wal);
498 499

	/* WaToEnableHwFixForPushConstHWBug:glk */
500 501
	wa_masked_en(wal, COMMON_SLICE_CHICKEN2,
		     GEN8_SBE_DISABLE_REPLAY_BUF_OPTIMIZATION);
502 503
}

504 505
static void cfl_ctx_workarounds_init(struct intel_engine_cs *engine,
				     struct i915_wa_list *wal)
506
{
507
	gen9_ctx_workarounds_init(engine, wal);
508 509

	/* WaToEnableHwFixForPushConstHWBug:cfl */
510 511
	wa_masked_en(wal, COMMON_SLICE_CHICKEN2,
		     GEN8_SBE_DISABLE_REPLAY_BUF_OPTIMIZATION);
512

513
	/* WaDisableSbeCacheDispatchPortSharing:cfl */
514 515
	wa_masked_en(wal, GEN7_HALF_SLICE_CHICKEN1,
		     GEN7_SBE_SS_CACHE_DISPATCH_PORT_SHARING_DISABLE);
516 517
}

518 519
static void cnl_ctx_workarounds_init(struct intel_engine_cs *engine,
				     struct i915_wa_list *wal)
520
{
521
	/* WaForceContextSaveRestoreNonCoherent:cnl */
522 523
	wa_masked_en(wal, CNL_HDC_CHICKEN0,
		     HDC_FORCE_CONTEXT_SAVE_RESTORE_NON_COHERENT);
524 525

	/* WaDisableReplayBufferBankArbitrationOptimization:cnl */
526 527
	wa_masked_en(wal, COMMON_SLICE_CHICKEN2,
		     GEN8_SBE_DISABLE_REPLAY_BUF_OPTIMIZATION);
528 529

	/* WaPushConstantDereferenceHoldDisable:cnl */
530
	wa_masked_en(wal, GEN7_ROW_CHICKEN2, PUSH_CONSTANT_DEREF_DISABLE);
531

532
	/* FtrEnableFastAnisoL1BankingFix:cnl */
533
	wa_masked_en(wal, HALF_SLICE_CHICKEN3, CNL_FAST_ANISO_L1_BANKING_FIX);
534 535

	/* WaDisable3DMidCmdPreemption:cnl */
536
	wa_masked_dis(wal, GEN8_CS_CHICKEN1, GEN9_PREEMPT_3D_OBJECT_LEVEL);
537 538

	/* WaDisableGPGPUMidCmdPreemption:cnl */
539
	wa_masked_field_set(wal, GEN8_CS_CHICKEN1,
540 541 542 543
			    GEN9_PREEMPT_GPGPU_LEVEL_MASK,
			    GEN9_PREEMPT_GPGPU_COMMAND_LEVEL);

	/* WaDisableEarlyEOT:cnl */
544
	wa_masked_en(wal, GEN8_ROW_CHICKEN, DISABLE_EARLY_EOT);
545 546
}

547 548
static void icl_ctx_workarounds_init(struct intel_engine_cs *engine,
				     struct i915_wa_list *wal)
549
{
550 551
	struct drm_i915_private *i915 = engine->i915;

552 553 554 555 556 557
	/* WaDisableBankHangMode:icl */
	wa_write(wal,
		 GEN8_L3CNTLREG,
		 intel_uncore_read(engine->uncore, GEN8_L3CNTLREG) |
		 GEN8_ERRDETBCTRL);

558 559 560
	/* Wa_1604370585:icl (pre-prod)
	 * Formerly known as WaPushConstantDereferenceHoldDisable
	 */
561
	if (IS_ICL_REVID(i915, ICL_REVID_A0, ICL_REVID_B0))
562 563
		wa_masked_en(wal, GEN7_ROW_CHICKEN2,
			     PUSH_CONSTANT_DEREF_DISABLE);
564 565 566 567 568 569 570 571

	/* WaForceEnableNonCoherent:icl
	 * This is not the same workaround as in early Gen9 platforms, where
	 * lacking this could cause system hangs, but coherency performance
	 * overhead is high and only a few compute workloads really need it
	 * (the register is whitelisted in hardware now, so UMDs can opt in
	 * for coherency if they have a good reason).
	 */
572
	wa_masked_en(wal, ICL_HDC_MODE, HDC_FORCE_NON_COHERENT);
573

574 575 576
	/* Wa_2006611047:icl (pre-prod)
	 * Formerly known as WaDisableImprovedTdlClkGating
	 */
577
	if (IS_ICL_REVID(i915, ICL_REVID_A0, ICL_REVID_A0))
578 579
		wa_masked_en(wal, GEN7_ROW_CHICKEN2,
			     GEN11_TDL_CLOCK_GATING_FIX_DISABLE);
580

O
Oscar Mateo 已提交
581
	/* Wa_2006665173:icl (pre-prod) */
582
	if (IS_ICL_REVID(i915, ICL_REVID_A0, ICL_REVID_A0))
583 584
		wa_masked_en(wal, GEN11_COMMON_SLICE_CHICKEN3,
			     GEN11_BLEND_EMB_FIX_DISABLE_IN_RCC);
585 586

	/* WaEnableFloatBlendOptimization:icl */
587 588 589 590
	wa_write_clr_set(wal,
			 GEN10_CACHE_MODE_SS,
			 0, /* write-only, so skip validation */
			 _MASKED_BIT_ENABLE(FLOAT_BLEND_OPTIMIZATION_ENABLE));
591 592

	/* WaDisableGPGPUMidThreadPreemption:icl */
593
	wa_masked_field_set(wal, GEN8_CS_CHICKEN1,
594 595
			    GEN9_PREEMPT_GPGPU_LEVEL_MASK,
			    GEN9_PREEMPT_GPGPU_THREAD_GROUP_LEVEL);
596 597

	/* allow headerless messages for preemptible GPGPU context */
598 599
	wa_masked_en(wal, GEN10_SAMPLER_MODE,
		     GEN11_SAMPLER_ENABLE_HEADLESS_MSG);
M
Matt Roper 已提交
600 601 602

	/* Wa_1604278689:icl,ehl */
	wa_write(wal, IVB_FBC_RT_BASE, 0xFFFFFFFF & ~ILK_FBC_RT_VALID);
603 604 605
	wa_write_clr_set(wal, IVB_FBC_RT_BASE_UPPER,
			 0, /* write-only register; skip validation */
			 0xFFFFFFFF);
M
Matt Roper 已提交
606 607 608

	/* Wa_1406306137:icl,ehl */
	wa_masked_en(wal, GEN9_ROW_CHICKEN4, GEN11_DIS_PICK_2ND_EU);
609 610
}

611 612
static void gen12_ctx_workarounds_init(struct intel_engine_cs *engine,
				       struct i915_wa_list *wal)
613
{
614 615 616 617 618 619 620 621
	/*
	 * Wa_1409142259:tgl
	 * Wa_1409347922:tgl
	 * Wa_1409252684:tgl
	 * Wa_1409217633:tgl
	 * Wa_1409207793:tgl
	 * Wa_1409178076:tgl
	 * Wa_1408979724:tgl
622 623
	 * Wa_14010443199:rkl
	 * Wa_14010698770:rkl
624
	 */
625 626
	wa_masked_en(wal, GEN11_COMMON_SLICE_CHICKEN3,
		     GEN12_DISABLE_CPS_AWARE_COLOR_PIPE);
627

628
	/* WaDisableGPGPUMidThreadPreemption:gen12 */
629
	wa_masked_field_set(wal, GEN8_CS_CHICKEN1,
630 631 632 633 634 635 636 637 638
			    GEN9_PREEMPT_GPGPU_LEVEL_MASK,
			    GEN9_PREEMPT_GPGPU_THREAD_GROUP_LEVEL);
}

static void tgl_ctx_workarounds_init(struct intel_engine_cs *engine,
				     struct i915_wa_list *wal)
{
	gen12_ctx_workarounds_init(engine, wal);

639
	/*
640 641 642 643
	 * Wa_1604555607:tgl,rkl
	 *
	 * Note that the implementation of this workaround is further modified
	 * according to the FF_MODE2 guidance given by Wa_1608008084:gen12.
644 645
	 * FF_MODE2 register will return the wrong value when read. The default
	 * value for this register is zero for all fields and there are no bit
646 647
	 * masks. So instead of doing a RMW we should just write the GS Timer
	 * and TDS timer values for Wa_1604555607 and Wa_16011163337.
648
	 */
649 650 651 652 653
	wa_add(wal,
	       FF_MODE2,
	       FF_MODE2_GS_TIMER_MASK | FF_MODE2_TDS_TIMER_MASK,
	       FF_MODE2_GS_TIMER_224  | FF_MODE2_TDS_TIMER_128,
	       0);
654 655
}

656 657 658 659 660 661
static void dg1_ctx_workarounds_init(struct intel_engine_cs *engine,
				     struct i915_wa_list *wal)
{
	gen12_ctx_workarounds_init(engine, wal);

	/* Wa_1409044764 */
662 663
	wa_masked_dis(wal, GEN11_COMMON_SLICE_CHICKEN3,
		      DG1_FLOAT_POINT_BLEND_OPT_STRICT_MODE_EN);
664 665

	/* Wa_22010493298 */
666 667
	wa_masked_en(wal, HIZ_CHICKEN,
		     DG1_HZ_READ_SUPPRESSION_OPTIMIZATION_DISABLE);
668 669 670 671 672 673 674 675 676 677

	/*
	 * Wa_16011163337
	 *
	 * Like in tgl_ctx_workarounds_init(), read verification is ignored due
	 * to Wa_1608008084.
	 */
	wa_add(wal,
	       FF_MODE2,
	       FF_MODE2_GS_TIMER_MASK, FF_MODE2_GS_TIMER_224, 0);
678 679
}

680 681 682 683
static void
__intel_engine_init_ctx_wa(struct intel_engine_cs *engine,
			   struct i915_wa_list *wal,
			   const char *name)
684
{
685 686
	struct drm_i915_private *i915 = engine->i915;

687 688 689
	if (engine->class != RENDER_CLASS)
		return;

690
	wa_init_start(wal, name, engine->name);
691

692 693
	if (IS_DG1(i915))
		dg1_ctx_workarounds_init(engine, wal);
694 695
	else if (IS_ALDERLAKE_S(i915) || IS_ROCKETLAKE(i915) ||
		 IS_TIGERLAKE(i915))
696
		tgl_ctx_workarounds_init(engine, wal);
697 698
	else if (IS_GEN(i915, 12))
		gen12_ctx_workarounds_init(engine, wal);
699
	else if (IS_GEN(i915, 11))
700
		icl_ctx_workarounds_init(engine, wal);
701
	else if (IS_CANNONLAKE(i915))
702
		cnl_ctx_workarounds_init(engine, wal);
703
	else if (IS_COFFEELAKE(i915) || IS_COMETLAKE(i915))
704
		cfl_ctx_workarounds_init(engine, wal);
705
	else if (IS_GEMINILAKE(i915))
706
		glk_ctx_workarounds_init(engine, wal);
707
	else if (IS_KABYLAKE(i915))
708
		kbl_ctx_workarounds_init(engine, wal);
709
	else if (IS_BROXTON(i915))
710
		bxt_ctx_workarounds_init(engine, wal);
711
	else if (IS_SKYLAKE(i915))
712
		skl_ctx_workarounds_init(engine, wal);
713
	else if (IS_CHERRYVIEW(i915))
714
		chv_ctx_workarounds_init(engine, wal);
715
	else if (IS_BROADWELL(i915))
716
		bdw_ctx_workarounds_init(engine, wal);
717 718 719 720
	else if (IS_GEN(i915, 7))
		gen7_ctx_workarounds_init(engine, wal);
	else if (IS_GEN(i915, 6))
		gen6_ctx_workarounds_init(engine, wal);
721 722
	else if (INTEL_GEN(i915) < 8)
		return;
723
	else
724
		MISSING_CASE(INTEL_GEN(i915));
725

726
	wa_init_finish(wal);
727 728
}

729 730 731 732 733
void intel_engine_init_ctx_wa(struct intel_engine_cs *engine)
{
	__intel_engine_init_ctx_wa(engine, &engine->ctx_wa_list, "context");
}

734
int intel_engine_emit_ctx_wa(struct i915_request *rq)
735
{
736 737 738
	struct i915_wa_list *wal = &rq->engine->ctx_wa_list;
	struct i915_wa *wa;
	unsigned int i;
739
	u32 *cs;
740
	int ret;
741

742
	if (wal->count == 0)
743 744 745
		return 0;

	ret = rq->engine->emit_flush(rq, EMIT_BARRIER);
746 747 748
	if (ret)
		return ret;

749
	cs = intel_ring_begin(rq, (wal->count * 2 + 2));
750 751 752
	if (IS_ERR(cs))
		return PTR_ERR(cs);

753 754 755
	*cs++ = MI_LOAD_REGISTER_IMM(wal->count);
	for (i = 0, wa = wal->list; i < wal->count; i++, wa++) {
		*cs++ = i915_mmio_reg_offset(wa->reg);
756
		*cs++ = wa->set;
757 758 759 760 761 762 763 764 765 766 767 768
	}
	*cs++ = MI_NOOP;

	intel_ring_advance(rq, cs);

	ret = rq->engine->emit_flush(rq, EMIT_BARRIER);
	if (ret)
		return ret;

	return 0;
}

769
static void
770 771
gen4_gt_workarounds_init(struct drm_i915_private *i915,
			 struct i915_wa_list *wal)
772
{
773 774 775 776 777 778 779 780
	/* WaDisable_RenderCache_OperationalFlush:gen4,ilk */
	wa_masked_dis(wal, CACHE_MODE_0, RC_OP_FLUSH_ENABLE);
}

static void
g4x_gt_workarounds_init(struct drm_i915_private *i915, struct i915_wa_list *wal)
{
	gen4_gt_workarounds_init(i915, wal);
781

782
	/* WaDisableRenderCachePipelinedFlush:g4x,ilk */
783
	wa_masked_en(wal, CACHE_MODE_0, CM0_PIPELINED_RENDER_FLUSH_DISABLE);
784
}
785

786 787 788 789 790 791
static void
ilk_gt_workarounds_init(struct drm_i915_private *i915, struct i915_wa_list *wal)
{
	g4x_gt_workarounds_init(i915, wal);

	wa_masked_en(wal, _3D_CHICKEN2, _3D_CHICKEN2_WM_READ_PIPELINED);
792 793
}

794 795 796 797 798
static void
snb_gt_workarounds_init(struct drm_i915_private *i915, struct i915_wa_list *wal)
{
}

799 800 801 802 803 804 805 806 807 808 809 810 811 812 813 814
static void
ivb_gt_workarounds_init(struct drm_i915_private *i915, struct i915_wa_list *wal)
{
	/* Apply the WaDisableRHWOOptimizationForRenderHang:ivb workaround. */
	wa_masked_dis(wal,
		      GEN7_COMMON_SLICE_CHICKEN1,
		      GEN7_CSC1_RHWO_OPT_DISABLE_IN_RCC);

	/* WaApplyL3ControlAndL3ChickenMode:ivb */
	wa_write(wal, GEN7_L3CNTLREG1, GEN7_WA_FOR_GEN7_L3_CONTROL);
	wa_write(wal, GEN7_L3_CHICKEN_MODE_REGISTER, GEN7_WA_L3_CHICKEN_MODE);

	/* WaForceL3Serialization:ivb */
	wa_write_clr(wal, GEN7_L3SQCREG4, L3SQ_URB_READ_CAM_MATCH_DISABLE);
}

815 816 817 818 819 820 821 822 823 824 825 826 827
static void
vlv_gt_workarounds_init(struct drm_i915_private *i915, struct i915_wa_list *wal)
{
	/* WaForceL3Serialization:vlv */
	wa_write_clr(wal, GEN7_L3SQCREG4, L3SQ_URB_READ_CAM_MATCH_DISABLE);

	/*
	 * WaIncreaseL3CreditsForVLVB0:vlv
	 * This is the hardware default actually.
	 */
	wa_write(wal, GEN7_L3SQCREG1, VLV_B0_WA_L3SQCREG1_VALUE);
}

828 829 830 831 832 833 834 835 836 837 838 839 840 841 842
static void
hsw_gt_workarounds_init(struct drm_i915_private *i915, struct i915_wa_list *wal)
{
	/* L3 caching of data atomics doesn't work -- disable it. */
	wa_write(wal, HSW_SCRATCH1, HSW_SCRATCH1_L3_DATA_ATOMICS_DISABLE);

	wa_add(wal,
	       HSW_ROW_CHICKEN3, 0,
	       _MASKED_BIT_ENABLE(HSW_ROW_CHICKEN3_L3_GLOBAL_ATOMICS_DISABLE),
		0 /* XXX does this reg exist? */);

	/* WaVSRefCountFullforceMissDisable:hsw */
	wa_write_clr(wal, GEN7_FF_THREAD_MODE, GEN7_FF_VS_REF_CNT_FFME);
}

843 844
static void
gen9_gt_workarounds_init(struct drm_i915_private *i915, struct i915_wa_list *wal)
845
{
846
	/* WaDisableKillLogic:bxt,skl,kbl */
847
	if (!IS_COFFEELAKE(i915) && !IS_COMETLAKE(i915))
848 849 850
		wa_write_or(wal,
			    GAM_ECOCHK,
			    ECOCHK_DIS_TLB);
851

852
	if (HAS_LLC(i915)) {
853 854 855 856 857
		/* WaCompressedResourceSamplerPbeMediaNewHashMode:skl,kbl
		 *
		 * Must match Display Engine. See
		 * WaCompressedResourceDisplayNewHashMode.
		 */
858 859 860
		wa_write_or(wal,
			    MMCD_MISC_CTRL,
			    MMCD_PCLA | MMCD_HOTSPOT_EN);
861 862 863
	}

	/* WaDisableHDCInvalidation:skl,bxt,kbl,cfl */
864 865 866
	wa_write_or(wal,
		    GAM_ECOCHK,
		    BDW_DISABLE_HDC_INVALIDATION);
867 868
}

869 870
static void
skl_gt_workarounds_init(struct drm_i915_private *i915, struct i915_wa_list *wal)
871
{
872
	gen9_gt_workarounds_init(i915, wal);
873 874

	/* WaDisableGafsUnitClkGating:skl */
875 876 877
	wa_write_or(wal,
		    GEN7_UCGCTL4,
		    GEN8_EU_GAUNIT_CLOCK_GATE_DISABLE);
878 879

	/* WaInPlaceDecompressionHang:skl */
880 881 882 883
	if (IS_SKL_REVID(i915, SKL_REVID_H0, REVID_FOREVER))
		wa_write_or(wal,
			    GEN9_GAMT_ECO_REG_RW_IA,
			    GAMT_ECO_ENABLE_IN_PLACE_DECOMPRESS);
884 885
}

886 887
static void
bxt_gt_workarounds_init(struct drm_i915_private *i915, struct i915_wa_list *wal)
888
{
889
	gen9_gt_workarounds_init(i915, wal);
890 891

	/* WaInPlaceDecompressionHang:bxt */
892 893 894
	wa_write_or(wal,
		    GEN9_GAMT_ECO_REG_RW_IA,
		    GAMT_ECO_ENABLE_IN_PLACE_DECOMPRESS);
895 896
}

897 898
static void
kbl_gt_workarounds_init(struct drm_i915_private *i915, struct i915_wa_list *wal)
899
{
900
	gen9_gt_workarounds_init(i915, wal);
901

902
	/* WaDisableDynamicCreditSharing:kbl */
903
	if (IS_KBL_GT_STEP(i915, 0, STEP_B0))
904 905 906
		wa_write_or(wal,
			    GAMT_CHKN_BIT_REG,
			    GAMT_CHKN_DISABLE_DYNAMIC_CREDIT_SHARING);
907

908
	/* WaDisableGafsUnitClkGating:kbl */
909 910 911
	wa_write_or(wal,
		    GEN7_UCGCTL4,
		    GEN8_EU_GAUNIT_CLOCK_GATE_DISABLE);
912

913
	/* WaInPlaceDecompressionHang:kbl */
914 915 916
	wa_write_or(wal,
		    GEN9_GAMT_ECO_REG_RW_IA,
		    GAMT_ECO_ENABLE_IN_PLACE_DECOMPRESS);
917
}
918

919 920
static void
glk_gt_workarounds_init(struct drm_i915_private *i915, struct i915_wa_list *wal)
921
{
922
	gen9_gt_workarounds_init(i915, wal);
923 924
}

925 926
static void
cfl_gt_workarounds_init(struct drm_i915_private *i915, struct i915_wa_list *wal)
927
{
928
	gen9_gt_workarounds_init(i915, wal);
929 930

	/* WaDisableGafsUnitClkGating:cfl */
931 932 933
	wa_write_or(wal,
		    GEN7_UCGCTL4,
		    GEN8_EU_GAUNIT_CLOCK_GATE_DISABLE);
934

935
	/* WaInPlaceDecompressionHang:cfl */
936 937 938
	wa_write_or(wal,
		    GEN9_GAMT_ECO_REG_RW_IA,
		    GAMT_ECO_ENABLE_IN_PLACE_DECOMPRESS);
939
}
940

941
static void
942
wa_init_mcr(struct drm_i915_private *i915, struct i915_wa_list *wal)
943
{
944
	const struct sseu_dev_info *sseu = &i915->gt.info.sseu;
945 946 947 948
	unsigned int slice, subslice;
	u32 l3_en, mcr, mcr_mask;

	GEM_BUG_ON(INTEL_GEN(i915) < 10);
949

950 951 952 953 954 955
	/*
	 * WaProgramMgsrForL3BankSpecificMmioReads: cnl,icl
	 * L3Banks could be fused off in single slice scenario. If that is
	 * the case, we might need to program MCR select to a valid L3Bank
	 * by default, to make sure we correctly read certain registers
	 * later on (in the range 0xB100 - 0xB3FF).
956
	 *
957
	 * WaProgramMgsrForCorrectSliceSpecificMmioReads:cnl,icl
958 959 960 961 962 963 964 965
	 * Before any MMIO read into slice/subslice specific registers, MCR
	 * packet control register needs to be programmed to point to any
	 * enabled s/ss pair. Otherwise, incorrect values will be returned.
	 * This means each subsequent MMIO read will be forwarded to an
	 * specific s/ss combination, but this is OK since these registers
	 * are consistent across s/ss in almost all cases. In the rare
	 * occasions, such as INSTDONE, where this value is dependent
	 * on s/ss combo, the read should be done with read_subslice_reg.
966 967 968 969 970 971 972 973 974 975
	 *
	 * Since GEN8_MCR_SELECTOR contains dual-purpose bits which select both
	 * to which subslice, or to which L3 bank, the respective mmio reads
	 * will go, we have to find a common index which works for both
	 * accesses.
	 *
	 * Case where we cannot find a common index fortunately should not
	 * happen in production hardware, so we only emit a warning instead of
	 * implementing something more complex that requires checking the range
	 * of every MMIO read.
976
	 */
977 978 979 980 981 982

	if (INTEL_GEN(i915) >= 10 && is_power_of_2(sseu->slice_mask)) {
		u32 l3_fuse =
			intel_uncore_read(&i915->uncore, GEN10_MIRROR_FUSE3) &
			GEN10_L3BANK_MASK;

983
		drm_dbg(&i915->drm, "L3 fuse = %x\n", l3_fuse);
984 985 986 987 988 989
		l3_en = ~(l3_fuse << GEN10_L3BANK_PAIR_COUNT | l3_fuse);
	} else {
		l3_en = ~0;
	}

	slice = fls(sseu->slice_mask) - 1;
S
Stuart Summers 已提交
990
	subslice = fls(l3_en & intel_sseu_get_subslices(sseu, slice));
991
	if (!subslice) {
992 993
		drm_warn(&i915->drm,
			 "No common index found between subslice mask %x and L3 bank mask %x!\n",
S
Stuart Summers 已提交
994
			 intel_sseu_get_subslices(sseu, slice), l3_en);
995
		subslice = fls(l3_en);
996
		drm_WARN_ON(&i915->drm, !subslice);
997 998 999 1000 1001 1002 1003 1004 1005 1006 1007
	}
	subslice--;

	if (INTEL_GEN(i915) >= 11) {
		mcr = GEN11_MCR_SLICE(slice) | GEN11_MCR_SUBSLICE(subslice);
		mcr_mask = GEN11_MCR_SLICE_MASK | GEN11_MCR_SUBSLICE_MASK;
	} else {
		mcr = GEN8_MCR_SLICE(slice) | GEN8_MCR_SUBSLICE(subslice);
		mcr_mask = GEN8_MCR_SLICE_MASK | GEN8_MCR_SUBSLICE_MASK;
	}

1008
	drm_dbg(&i915->drm, "MCR slice/subslice = %x\n", mcr);
1009

1010
	wa_write_clr_set(wal, GEN8_MCR_SELECTOR, mcr_mask, mcr);
1011 1012
}

1013 1014
static void
cnl_gt_workarounds_init(struct drm_i915_private *i915, struct i915_wa_list *wal)
1015
{
1016
	wa_init_mcr(i915, wal);
1017

1018
	/* WaInPlaceDecompressionHang:cnl */
1019 1020 1021
	wa_write_or(wal,
		    GEN9_GAMT_ECO_REG_RW_IA,
		    GAMT_ECO_ENABLE_IN_PLACE_DECOMPRESS);
1022 1023
}

1024 1025
static void
icl_gt_workarounds_init(struct drm_i915_private *i915, struct i915_wa_list *wal)
1026
{
1027
	wa_init_mcr(i915, wal);
1028

1029
	/* WaInPlaceDecompressionHang:icl */
1030 1031 1032
	wa_write_or(wal,
		    GEN9_GAMT_ECO_REG_RW_IA,
		    GAMT_ECO_ENABLE_IN_PLACE_DECOMPRESS);
1033

1034
	/* WaModifyGamTlbPartitioning:icl */
1035 1036 1037 1038
	wa_write_clr_set(wal,
			 GEN11_GACB_PERF_CTRL,
			 GEN11_HASH_CTRL_MASK,
			 GEN11_HASH_CTRL_BIT0 | GEN11_HASH_CTRL_BIT4);
O
Oscar Mateo 已提交
1039

O
Oscar Mateo 已提交
1040 1041 1042
	/* Wa_1405766107:icl
	 * Formerly known as WaCL2SFHalfMaxAlloc
	 */
1043 1044 1045 1046
	wa_write_or(wal,
		    GEN11_LSN_UNSLCVC,
		    GEN11_LSN_UNSLCVC_GAFS_HALF_SF_MAXALLOC |
		    GEN11_LSN_UNSLCVC_GAFS_HALF_CL2_MAXALLOC);
O
Oscar Mateo 已提交
1047 1048 1049 1050

	/* Wa_220166154:icl
	 * Formerly known as WaDisCtxReload
	 */
1051 1052 1053
	wa_write_or(wal,
		    GEN8_GAMW_ECO_DEV_RW_IA,
		    GAMW_ECO_DEV_CTX_RELOAD_DISABLE);
O
Oscar Mateo 已提交
1054 1055

	/* Wa_1405779004:icl (pre-prod) */
1056 1057 1058 1059
	if (IS_ICL_REVID(i915, ICL_REVID_A0, ICL_REVID_A0))
		wa_write_or(wal,
			    SLICE_UNIT_LEVEL_CLKGATE,
			    MSCUNIT_CLKGATE_DIS);
O
Oscar Mateo 已提交
1060

O
Oscar Mateo 已提交
1061
	/* Wa_1406838659:icl (pre-prod) */
1062 1063 1064 1065
	if (IS_ICL_REVID(i915, ICL_REVID_A0, ICL_REVID_B0))
		wa_write_or(wal,
			    INF_UNIT_LEVEL_CLKGATE,
			    CGPSF_CLKGATE_DIS);
1066

O
Oscar Mateo 已提交
1067 1068 1069
	/* Wa_1406463099:icl
	 * Formerly known as WaGamTlbPendError
	 */
1070 1071 1072
	wa_write_or(wal,
		    GAMT_CHKN_BIT_REG,
		    GAMT_CHKN_DISABLE_L3_COH_PIPE);
M
Mika Kuoppala 已提交
1073

1074 1075
	/* Wa_1607087056:icl,ehl,jsl */
	if (IS_ICELAKE(i915) ||
1076
		IS_JSL_EHL_REVID(i915, EHL_REVID_A0, EHL_REVID_A0)) {
1077 1078 1079 1080
		wa_write_or(wal,
			    SLICE_UNIT_LEVEL_CLKGATE,
			    L3_CLKGATE_DIS | L3_CR2X_CLKGATE_DIS);
	}
1081 1082
}

1083
static void
1084 1085
gen12_gt_workarounds_init(struct drm_i915_private *i915,
			  struct i915_wa_list *wal)
1086
{
1087
	wa_init_mcr(i915, wal);
1088 1089 1090 1091 1092 1093
}

static void
tgl_gt_workarounds_init(struct drm_i915_private *i915, struct i915_wa_list *wal)
{
	gen12_gt_workarounds_init(i915, wal);
1094

M
Mika Kuoppala 已提交
1095
	/* Wa_1409420604:tgl */
1096
	if (IS_TGL_UY_GT_STEPPING(i915, STEP_A0, STEP_A0))
M
Mika Kuoppala 已提交
1097 1098 1099
		wa_write_or(wal,
			    SUBSLICE_UNIT_LEVEL_CLKGATE2,
			    CPSSUNIT_CLKGATE_DIS);
M
Mika Kuoppala 已提交
1100

1101
	/* Wa_1607087056:tgl also know as BUG:1409180338 */
1102
	if (IS_TGL_UY_GT_STEPPING(i915, STEP_A0, STEP_A0))
M
Mika Kuoppala 已提交
1103 1104 1105
		wa_write_or(wal,
			    SLICE_UNIT_LEVEL_CLKGATE,
			    L3_CLKGATE_DIS | L3_CR2X_CLKGATE_DIS);
1106 1107

	/* Wa_1408615072:tgl[a0] */
1108
	if (IS_TGL_UY_GT_STEPPING(i915, STEP_A0, STEP_A0))
1109 1110
		wa_write_or(wal, UNSLICE_UNIT_LEVEL_CLKGATE2,
			    VSUNIT_CLKGATE_DIS_TGL);
1111 1112
}

1113 1114 1115 1116 1117 1118 1119 1120 1121 1122 1123 1124 1125 1126 1127 1128 1129 1130 1131 1132 1133 1134 1135 1136
static void
dg1_gt_workarounds_init(struct drm_i915_private *i915, struct i915_wa_list *wal)
{
	gen12_gt_workarounds_init(i915, wal);

	/* Wa_1607087056:dg1 */
	if (IS_DG1_REVID(i915, DG1_REVID_A0, DG1_REVID_A0))
		wa_write_or(wal,
			    SLICE_UNIT_LEVEL_CLKGATE,
			    L3_CLKGATE_DIS | L3_CR2X_CLKGATE_DIS);

	/* Wa_1409420604:dg1 */
	if (IS_DG1(i915))
		wa_write_or(wal,
			    SUBSLICE_UNIT_LEVEL_CLKGATE2,
			    CPSSUNIT_CLKGATE_DIS);

	/* Wa_1408615072:dg1 */
	/* Empirical testing shows this register is unaffected by engine reset. */
	if (IS_DG1(i915))
		wa_write_or(wal, UNSLICE_UNIT_LEVEL_CLKGATE2,
			    VSUNIT_CLKGATE_DIS_TGL);
}

1137 1138
static void
gt_init_workarounds(struct drm_i915_private *i915, struct i915_wa_list *wal)
1139
{
1140 1141 1142
	if (IS_DG1(i915))
		dg1_gt_workarounds_init(i915, wal);
	else if (IS_TIGERLAKE(i915))
1143
		tgl_gt_workarounds_init(i915, wal);
1144 1145
	else if (IS_GEN(i915, 12))
		gen12_gt_workarounds_init(i915, wal);
1146
	else if (IS_GEN(i915, 11))
1147
		icl_gt_workarounds_init(i915, wal);
1148
	else if (IS_CANNONLAKE(i915))
1149
		cnl_gt_workarounds_init(i915, wal);
1150
	else if (IS_COFFEELAKE(i915) || IS_COMETLAKE(i915))
1151 1152 1153 1154 1155 1156 1157 1158 1159
		cfl_gt_workarounds_init(i915, wal);
	else if (IS_GEMINILAKE(i915))
		glk_gt_workarounds_init(i915, wal);
	else if (IS_KABYLAKE(i915))
		kbl_gt_workarounds_init(i915, wal);
	else if (IS_BROXTON(i915))
		bxt_gt_workarounds_init(i915, wal);
	else if (IS_SKYLAKE(i915))
		skl_gt_workarounds_init(i915, wal);
1160 1161
	else if (IS_HASWELL(i915))
		hsw_gt_workarounds_init(i915, wal);
1162 1163
	else if (IS_VALLEYVIEW(i915))
		vlv_gt_workarounds_init(i915, wal);
1164 1165
	else if (IS_IVYBRIDGE(i915))
		ivb_gt_workarounds_init(i915, wal);
1166 1167
	else if (IS_GEN(i915, 6))
		snb_gt_workarounds_init(i915, wal);
1168 1169
	else if (IS_GEN(i915, 5))
		ilk_gt_workarounds_init(i915, wal);
1170 1171 1172 1173
	else if (IS_G4X(i915))
		g4x_gt_workarounds_init(i915, wal);
	else if (IS_GEN(i915, 4))
		gen4_gt_workarounds_init(i915, wal);
1174 1175
	else if (INTEL_GEN(i915) <= 8)
		return;
1176
	else
1177
		MISSING_CASE(INTEL_GEN(i915));
1178 1179 1180 1181 1182
}

void intel_gt_init_workarounds(struct drm_i915_private *i915)
{
	struct i915_wa_list *wal = &i915->gt_wa_list;
1183

1184
	wa_init_start(wal, "GT", "global");
1185
	gt_init_workarounds(i915, wal);
1186 1187 1188 1189
	wa_init_finish(wal);
}

static enum forcewake_domains
1190
wal_get_fw_for_rmw(struct intel_uncore *uncore, const struct i915_wa_list *wal)
1191 1192 1193 1194 1195 1196
{
	enum forcewake_domains fw = 0;
	struct i915_wa *wa;
	unsigned int i;

	for (i = 0, wa = wal->list; i < wal->count; i++, wa++)
1197
		fw |= intel_uncore_forcewake_for_reg(uncore,
1198 1199 1200 1201 1202 1203 1204
						     wa->reg,
						     FW_REG_READ |
						     FW_REG_WRITE);

	return fw;
}

1205 1206 1207
static bool
wa_verify(const struct i915_wa *wa, u32 cur, const char *name, const char *from)
{
1208
	if ((cur ^ wa->set) & wa->read) {
1209
		DRM_ERROR("%s workaround lost on %s! (reg[%x]=0x%x, relevant bits were 0x%x vs expected 0x%x)\n",
1210
			  name, from, i915_mmio_reg_offset(wa->reg),
1211
			  cur, cur & wa->read, wa->set & wa->read);
1212 1213 1214 1215 1216 1217 1218

		return false;
	}

	return true;
}

1219
static void
1220
wa_list_apply(struct intel_uncore *uncore, const struct i915_wa_list *wal)
1221 1222 1223 1224 1225 1226 1227 1228 1229
{
	enum forcewake_domains fw;
	unsigned long flags;
	struct i915_wa *wa;
	unsigned int i;

	if (!wal->count)
		return;

1230
	fw = wal_get_fw_for_rmw(uncore, wal);
1231

1232 1233
	spin_lock_irqsave(&uncore->lock, flags);
	intel_uncore_forcewake_get__locked(uncore, fw);
1234 1235

	for (i = 0, wa = wal->list; i < wal->count; i++, wa++) {
1236 1237 1238 1239
		if (wa->clr)
			intel_uncore_rmw_fw(uncore, wa->reg, wa->clr, wa->set);
		else
			intel_uncore_write_fw(uncore, wa->reg, wa->set);
1240 1241 1242 1243
		if (IS_ENABLED(CONFIG_DRM_I915_DEBUG_GEM))
			wa_verify(wa,
				  intel_uncore_read_fw(uncore, wa->reg),
				  wal->name, "application");
1244 1245
	}

1246 1247
	intel_uncore_forcewake_put__locked(uncore, fw);
	spin_unlock_irqrestore(&uncore->lock, flags);
1248 1249
}

1250
void intel_gt_apply_workarounds(struct intel_gt *gt)
1251
{
1252
	wa_list_apply(gt->uncore, &gt->i915->gt_wa_list);
1253 1254
}

1255
static bool wa_list_verify(struct intel_uncore *uncore,
1256 1257 1258 1259 1260 1261 1262 1263
			   const struct i915_wa_list *wal,
			   const char *from)
{
	struct i915_wa *wa;
	unsigned int i;
	bool ok = true;

	for (i = 0, wa = wal->list; i < wal->count; i++, wa++)
1264 1265 1266
		ok &= wa_verify(wa,
				intel_uncore_read(uncore, wa->reg),
				wal->name, from);
1267 1268 1269 1270

	return ok;
}

1271
bool intel_gt_verify_workarounds(struct intel_gt *gt, const char *from)
1272
{
1273
	return wa_list_verify(gt->uncore, &gt->i915->gt_wa_list, from);
1274 1275
}

1276
__maybe_unused
C
Chris Wilson 已提交
1277
static bool is_nonpriv_flags_valid(u32 flags)
1278 1279 1280 1281 1282 1283 1284 1285 1286 1287 1288 1289 1290
{
	/* Check only valid flag bits are set */
	if (flags & ~RING_FORCE_TO_NONPRIV_MASK_VALID)
		return false;

	/* NB: Only 3 out of 4 enum values are valid for access field */
	if ((flags & RING_FORCE_TO_NONPRIV_ACCESS_MASK) ==
	    RING_FORCE_TO_NONPRIV_ACCESS_INVALID)
		return false;

	return true;
}

1291
static void
1292
whitelist_reg_ext(struct i915_wa_list *wal, i915_reg_t reg, u32 flags)
1293
{
1294 1295 1296
	struct i915_wa wa = {
		.reg = reg
	};
1297

1298 1299
	if (GEM_DEBUG_WARN_ON(wal->count >= RING_MAX_NONPRIV_SLOTS))
		return;
1300

1301 1302 1303
	if (GEM_DEBUG_WARN_ON(!is_nonpriv_flags_valid(flags)))
		return;

1304
	wa.reg.reg |= flags;
1305
	_wa_add(wal, &wa);
1306 1307
}

1308 1309 1310
static void
whitelist_reg(struct i915_wa_list *wal, i915_reg_t reg)
{
1311
	whitelist_reg_ext(wal, reg, RING_FORCE_TO_NONPRIV_ACCESS_RW);
1312 1313
}

1314
static void gen9_whitelist_build(struct i915_wa_list *w)
1315 1316
{
	/* WaVFEStateAfterPipeControlwithMediaStateClear:skl,bxt,glk,cfl */
1317
	whitelist_reg(w, GEN9_CTX_PREEMPT_REG);
1318 1319

	/* WaEnablePreemptionGranularityControlByUMD:skl,bxt,kbl,cfl,[cnl] */
1320
	whitelist_reg(w, GEN8_CS_CHICKEN1);
1321 1322

	/* WaAllowUMDToModifyHDCChicken1:skl,bxt,kbl,glk,cfl */
1323
	whitelist_reg(w, GEN8_HDC_CHICKEN1);
1324 1325 1326

	/* WaSendPushConstantsFromMMIO:skl,bxt */
	whitelist_reg(w, COMMON_SLICE_CHICKEN2);
1327 1328
}

1329
static void skl_whitelist_build(struct intel_engine_cs *engine)
1330
{
1331 1332 1333 1334 1335
	struct i915_wa_list *w = &engine->whitelist;

	if (engine->class != RENDER_CLASS)
		return;

1336
	gen9_whitelist_build(w);
1337 1338

	/* WaDisableLSQCROPERFforOCL:skl */
1339
	whitelist_reg(w, GEN8_L3SQCREG4);
1340 1341
}

1342
static void bxt_whitelist_build(struct intel_engine_cs *engine)
1343
{
1344 1345 1346 1347
	if (engine->class != RENDER_CLASS)
		return;

	gen9_whitelist_build(&engine->whitelist);
1348 1349
}

1350
static void kbl_whitelist_build(struct intel_engine_cs *engine)
1351
{
1352 1353 1354 1355 1356
	struct i915_wa_list *w = &engine->whitelist;

	if (engine->class != RENDER_CLASS)
		return;

1357
	gen9_whitelist_build(w);
1358

1359
	/* WaDisableLSQCROPERFforOCL:kbl */
1360
	whitelist_reg(w, GEN8_L3SQCREG4);
1361 1362
}

1363
static void glk_whitelist_build(struct intel_engine_cs *engine)
1364
{
1365 1366 1367 1368 1369
	struct i915_wa_list *w = &engine->whitelist;

	if (engine->class != RENDER_CLASS)
		return;

1370
	gen9_whitelist_build(w);
1371

1372
	/* WA #0862: Userspace has to set "Barrier Mode" to avoid hangs. */
1373
	whitelist_reg(w, GEN9_SLICE_COMMON_ECO_CHICKEN1);
1374
}
1375

1376
static void cfl_whitelist_build(struct intel_engine_cs *engine)
1377
{
1378 1379
	struct i915_wa_list *w = &engine->whitelist;

1380 1381 1382
	if (engine->class != RENDER_CLASS)
		return;

1383 1384 1385 1386 1387 1388 1389 1390 1391 1392 1393 1394
	gen9_whitelist_build(w);

	/*
	 * WaAllowPMDepthAndInvocationCountAccessFromUMD:cfl,whl,cml,aml
	 *
	 * This covers 4 register which are next to one another :
	 *   - PS_INVOCATION_COUNT
	 *   - PS_INVOCATION_COUNT_UDW
	 *   - PS_DEPTH_COUNT
	 *   - PS_DEPTH_COUNT_UDW
	 */
	whitelist_reg_ext(w, PS_INVOCATION_COUNT,
1395
			  RING_FORCE_TO_NONPRIV_ACCESS_RD |
1396
			  RING_FORCE_TO_NONPRIV_RANGE_4);
1397 1398
}

1399 1400 1401 1402 1403 1404 1405 1406 1407 1408 1409 1410
static void cml_whitelist_build(struct intel_engine_cs *engine)
{
	struct i915_wa_list *w = &engine->whitelist;

	if (engine->class != RENDER_CLASS)
		whitelist_reg_ext(w,
				  RING_CTX_TIMESTAMP(engine->mmio_base),
				  RING_FORCE_TO_NONPRIV_ACCESS_RD);

	cfl_whitelist_build(engine);
}

1411
static void cnl_whitelist_build(struct intel_engine_cs *engine)
1412
{
1413 1414 1415 1416 1417
	struct i915_wa_list *w = &engine->whitelist;

	if (engine->class != RENDER_CLASS)
		return;

1418
	/* WaEnablePreemptionGranularityControlByUMD:cnl */
1419 1420 1421
	whitelist_reg(w, GEN8_CS_CHICKEN1);
}

1422
static void icl_whitelist_build(struct intel_engine_cs *engine)
1423
{
1424 1425
	struct i915_wa_list *w = &engine->whitelist;

1426 1427 1428 1429 1430 1431 1432 1433 1434 1435
	switch (engine->class) {
	case RENDER_CLASS:
		/* WaAllowUMDToModifyHalfSliceChicken7:icl */
		whitelist_reg(w, GEN9_HALF_SLICE_CHICKEN7);

		/* WaAllowUMDToModifySamplerMode:icl */
		whitelist_reg(w, GEN10_SAMPLER_MODE);

		/* WaEnableStateCacheRedirectToCS:icl */
		whitelist_reg(w, GEN9_SLICE_COMMON_ECO_CHICKEN1);
1436 1437 1438 1439 1440 1441 1442 1443 1444 1445 1446

		/*
		 * WaAllowPMDepthAndInvocationCountAccessFromUMD:icl
		 *
		 * This covers 4 register which are next to one another :
		 *   - PS_INVOCATION_COUNT
		 *   - PS_INVOCATION_COUNT_UDW
		 *   - PS_DEPTH_COUNT
		 *   - PS_DEPTH_COUNT_UDW
		 */
		whitelist_reg_ext(w, PS_INVOCATION_COUNT,
1447
				  RING_FORCE_TO_NONPRIV_ACCESS_RD |
1448
				  RING_FORCE_TO_NONPRIV_RANGE_4);
1449 1450 1451 1452 1453
		break;

	case VIDEO_DECODE_CLASS:
		/* hucStatusRegOffset */
		whitelist_reg_ext(w, _MMIO(0x2000 + engine->mmio_base),
1454
				  RING_FORCE_TO_NONPRIV_ACCESS_RD);
1455 1456
		/* hucUKernelHdrInfoRegOffset */
		whitelist_reg_ext(w, _MMIO(0x2014 + engine->mmio_base),
1457
				  RING_FORCE_TO_NONPRIV_ACCESS_RD);
1458 1459
		/* hucStatus2RegOffset */
		whitelist_reg_ext(w, _MMIO(0x23B0 + engine->mmio_base),
1460
				  RING_FORCE_TO_NONPRIV_ACCESS_RD);
1461 1462 1463
		whitelist_reg_ext(w,
				  RING_CTX_TIMESTAMP(engine->mmio_base),
				  RING_FORCE_TO_NONPRIV_ACCESS_RD);
1464 1465 1466
		break;

	default:
1467 1468 1469
		whitelist_reg_ext(w,
				  RING_CTX_TIMESTAMP(engine->mmio_base),
				  RING_FORCE_TO_NONPRIV_ACCESS_RD);
1470 1471
		break;
	}
1472 1473
}

1474 1475
static void tgl_whitelist_build(struct intel_engine_cs *engine)
{
1476 1477 1478 1479 1480 1481
	struct i915_wa_list *w = &engine->whitelist;

	switch (engine->class) {
	case RENDER_CLASS:
		/*
		 * WaAllowPMDepthAndInvocationCountAccessFromUMD:tgl
1482
		 * Wa_1408556865:tgl
1483 1484 1485 1486 1487 1488 1489 1490 1491 1492
		 *
		 * This covers 4 registers which are next to one another :
		 *   - PS_INVOCATION_COUNT
		 *   - PS_INVOCATION_COUNT_UDW
		 *   - PS_DEPTH_COUNT
		 *   - PS_DEPTH_COUNT_UDW
		 */
		whitelist_reg_ext(w, PS_INVOCATION_COUNT,
				  RING_FORCE_TO_NONPRIV_ACCESS_RD |
				  RING_FORCE_TO_NONPRIV_RANGE_4);
1493 1494 1495

		/* Wa_1808121037:tgl */
		whitelist_reg(w, GEN7_COMMON_SLICE_CHICKEN1);
1496 1497 1498

		/* Wa_1806527549:tgl */
		whitelist_reg(w, HIZ_CHICKEN);
1499 1500
		break;
	default:
1501 1502 1503
		whitelist_reg_ext(w,
				  RING_CTX_TIMESTAMP(engine->mmio_base),
				  RING_FORCE_TO_NONPRIV_ACCESS_RD);
1504 1505
		break;
	}
1506 1507
}

1508 1509 1510 1511 1512 1513 1514 1515 1516 1517 1518 1519 1520 1521
static void dg1_whitelist_build(struct intel_engine_cs *engine)
{
	struct i915_wa_list *w = &engine->whitelist;

	tgl_whitelist_build(engine);

	/* GEN:BUG:1409280441:dg1 */
	if (IS_DG1_REVID(engine->i915, DG1_REVID_A0, DG1_REVID_A0) &&
	    (engine->class == RENDER_CLASS ||
	     engine->class == COPY_ENGINE_CLASS))
		whitelist_reg_ext(w, RING_ID(engine->mmio_base),
				  RING_FORCE_TO_NONPRIV_ACCESS_RD);
}

1522
void intel_engine_init_whitelist(struct intel_engine_cs *engine)
1523 1524
{
	struct drm_i915_private *i915 = engine->i915;
1525
	struct i915_wa_list *w = &engine->whitelist;
1526

1527
	wa_init_start(w, "whitelist", engine->name);
1528

1529 1530 1531
	if (IS_DG1(i915))
		dg1_whitelist_build(engine);
	else if (IS_GEN(i915, 12))
1532 1533
		tgl_whitelist_build(engine);
	else if (IS_GEN(i915, 11))
1534
		icl_whitelist_build(engine);
1535
	else if (IS_CANNONLAKE(i915))
1536
		cnl_whitelist_build(engine);
1537 1538 1539
	else if (IS_COMETLAKE(i915))
		cml_whitelist_build(engine);
	else if (IS_COFFEELAKE(i915))
1540
		cfl_whitelist_build(engine);
1541
	else if (IS_GEMINILAKE(i915))
1542
		glk_whitelist_build(engine);
1543
	else if (IS_KABYLAKE(i915))
1544
		kbl_whitelist_build(engine);
1545
	else if (IS_BROXTON(i915))
1546
		bxt_whitelist_build(engine);
1547
	else if (IS_SKYLAKE(i915))
1548
		skl_whitelist_build(engine);
1549 1550
	else if (INTEL_GEN(i915) <= 8)
		return;
1551 1552
	else
		MISSING_CASE(INTEL_GEN(i915));
1553

1554
	wa_init_finish(w);
1555 1556
}

1557
void intel_engine_apply_whitelist(struct intel_engine_cs *engine)
1558
{
1559
	const struct i915_wa_list *wal = &engine->whitelist;
1560
	struct intel_uncore *uncore = engine->uncore;
1561
	const u32 base = engine->mmio_base;
1562
	struct i915_wa *wa;
1563 1564
	unsigned int i;

1565
	if (!wal->count)
1566
		return;
1567

1568
	for (i = 0, wa = wal->list; i < wal->count; i++, wa++)
1569 1570 1571
		intel_uncore_write(uncore,
				   RING_FORCE_TO_NONPRIV(base, i),
				   i915_mmio_reg_offset(wa->reg));
1572

1573 1574
	/* And clear the rest just in case of garbage */
	for (; i < RING_MAX_NONPRIV_SLOTS; i++)
1575 1576 1577
		intel_uncore_write(uncore,
				   RING_FORCE_TO_NONPRIV(base, i),
				   i915_mmio_reg_offset(RING_NOPID(base)));
1578 1579
}

1580 1581
static void
rcs_engine_wa_init(struct intel_engine_cs *engine, struct i915_wa_list *wal)
1582 1583 1584
{
	struct drm_i915_private *i915 = engine->i915;

1585
	if (IS_DG1_REVID(i915, DG1_REVID_A0, DG1_REVID_A0) ||
1586
	    IS_TGL_UY_GT_STEPPING(i915, STEP_A0, STEP_A0)) {
1587
		/*
1588 1589
		 * Wa_1607138336:tgl[a0],dg1[a0]
		 * Wa_1607063988:tgl[a0],dg1[a0]
1590
		 */
M
Mika Kuoppala 已提交
1591 1592 1593
		wa_write_or(wal,
			    GEN9_CTX_PREEMPT_REG,
			    GEN12_DISABLE_POSH_BUSY_FF_DOP_CG);
1594
	}
1595

1596
	if (IS_TGL_UY_GT_STEPPING(i915, STEP_A0, STEP_A0)) {
R
Radhakrishna Sripada 已提交
1597 1598 1599 1600 1601 1602 1603
		/*
		 * Wa_1606679103:tgl
		 * (see also Wa_1606682166:icl)
		 */
		wa_write_or(wal,
			    GEN7_SARCHKMD,
			    GEN7_DISABLE_SAMPLER_PREFETCH);
1604 1605
	}

1606 1607 1608
	if (IS_ALDERLAKE_S(i915) || IS_DG1(i915) ||
	    IS_ROCKETLAKE(i915) || IS_TIGERLAKE(i915)) {
		/* Wa_1606931601:tgl,rkl,dg1,adl-s */
1609 1610
		wa_masked_en(wal, GEN7_ROW_CHICKEN2, GEN12_DISABLE_EARLY_READ);

1611 1612 1613 1614
		/*
		 * Wa_1407928979:tgl A*
		 * Wa_18011464164:tgl[B0+],dg1[B0+]
		 * Wa_22010931296:tgl[B0+],dg1[B0+]
1615
		 * Wa_14010919138:rkl,dg1,adl-s
1616 1617 1618
		 */
		wa_write_or(wal, GEN7_FF_THREAD_MODE,
			    GEN12_FF_TESSELATION_DOP_GATE_DISABLE);
1619 1620 1621

		/*
		 * Wa_1606700617:tgl,dg1
1622
		 * Wa_22010271021:tgl,rkl,dg1, adl-s
1623 1624 1625 1626
		 */
		wa_masked_en(wal,
			     GEN9_CS_DEBUG_MODE1,
			     FF_DOP_CLOCK_GATE_DISABLE);
1627 1628
	}

1629
	if (IS_ALDERLAKE_S(i915) || IS_DG1_REVID(i915, DG1_REVID_A0, DG1_REVID_A0) ||
1630
	    IS_ROCKETLAKE(i915) || IS_TIGERLAKE(i915)) {
1631
		/* Wa_1409804808:tgl,rkl,dg1[a0],adl-s */
1632 1633
		wa_masked_en(wal, GEN7_ROW_CHICKEN2,
			     GEN12_PUSH_CONST_DEREF_HOLD_DIS);
1634

1635 1636
		/*
		 * Wa_1409085225:tgl
1637
		 * Wa_14010229206:tgl,rkl,dg1[a0],adl-s
1638 1639
		 */
		wa_masked_en(wal, GEN9_ROW_CHICKEN4, GEN12_DISABLE_TDL_PUSH);
1640 1641
	}

1642

1643 1644
	if (IS_DG1_REVID(i915, DG1_REVID_A0, DG1_REVID_A0) ||
	    IS_ROCKETLAKE(i915) || IS_TIGERLAKE(i915)) {
1645 1646 1647
		/*
		 * Wa_1607030317:tgl
		 * Wa_1607186500:tgl
1648 1649 1650 1651 1652 1653
		 * Wa_1607297627:tgl,rkl,dg1[a0]
		 *
		 * On TGL and RKL there are multiple entries for this WA in the
		 * BSpec; some indicate this is an A0-only WA, others indicate
		 * it applies to all steppings so we trust the "all steppings."
		 * For DG1 this only applies to A0.
1654 1655 1656 1657 1658
		 */
		wa_masked_en(wal,
			     GEN6_RC_SLEEP_PSMI_CONTROL,
			     GEN12_WAIT_FOR_EVENT_POWER_DOWN_DISABLE |
			     GEN8_RC_SEMA_IDLE_MSG_DISABLE);
1659 1660
	}

1661 1662 1663 1664 1665 1666 1667
	if (IS_DG1(i915) || IS_ROCKETLAKE(i915) || IS_TIGERLAKE(i915)) {
		/* Wa_1406941453:tgl,rkl,dg1 */
		wa_masked_en(wal,
			     GEN10_SAMPLER_MODE,
			     ENABLE_SMALLPL);
	}

1668
	if (IS_GEN(i915, 11)) {
1669 1670 1671 1672 1673 1674
		/* This is not an Wa. Enable for better image quality */
		wa_masked_en(wal,
			     _3D_CHICKEN3,
			     _3D_CHICKEN3_AA_LINE_QUALITY_FIX_ENABLE);

		/* WaPipelineFlushCoherentLines:icl */
1675 1676 1677
		wa_write_or(wal,
			    GEN8_L3SQCREG4,
			    GEN8_LQSC_FLUSH_COHERENT_LINES);
1678 1679 1680 1681 1682 1683 1684 1685 1686 1687 1688 1689 1690

		/*
		 * Wa_1405543622:icl
		 * Formerly known as WaGAPZPriorityScheme
		 */
		wa_write_or(wal,
			    GEN8_GARBCNTL,
			    GEN11_ARBITRATION_PRIO_ORDER_MASK);

		/*
		 * Wa_1604223664:icl
		 * Formerly known as WaL3BankAddressHashing
		 */
1691 1692 1693 1694 1695 1696 1697 1698
		wa_write_clr_set(wal,
				 GEN8_GARBCNTL,
				 GEN11_HASH_CTRL_EXCL_MASK,
				 GEN11_HASH_CTRL_EXCL_BIT0);
		wa_write_clr_set(wal,
				 GEN11_GLBLINVL,
				 GEN11_BANK_HASH_ADDR_EXCL_MASK,
				 GEN11_BANK_HASH_ADDR_EXCL_BIT0);
1699 1700 1701 1702 1703

		/*
		 * Wa_1405733216:icl
		 * Formerly known as WaDisableCleanEvicts
		 */
1704 1705 1706
		wa_write_or(wal,
			    GEN8_L3SQCREG4,
			    GEN11_LQSC_CLEAN_EVICT_DISABLE);
1707 1708 1709 1710 1711 1712 1713 1714 1715 1716 1717 1718

		/* WaForwardProgressSoftReset:icl */
		wa_write_or(wal,
			    GEN10_SCRATCH_LNCF2,
			    PMFLUSHDONE_LNICRSDROP |
			    PMFLUSH_GAPL3UNBLOCK |
			    PMFLUSHDONE_LNEBLK);

		/* Wa_1406609255:icl (pre-prod) */
		if (IS_ICL_REVID(i915, ICL_REVID_A0, ICL_REVID_B0))
			wa_write_or(wal,
				    GEN7_SARCHKMD,
1719 1720 1721 1722 1723 1724
				    GEN7_DISABLE_DEMAND_PREFETCH);

		/* Wa_1606682166:icl */
		wa_write_or(wal,
			    GEN7_SARCHKMD,
			    GEN7_DISABLE_SAMPLER_PREFETCH);
T
Tvrtko Ursulin 已提交
1725 1726

		/* Wa_1409178092:icl */
1727 1728 1729 1730
		wa_write_clr_set(wal,
				 GEN11_SCRATCH2,
				 GEN11_COHERENT_PARTIAL_WRITE_MERGE_ENABLE,
				 0);
1731 1732 1733 1734 1735 1736 1737 1738 1739

		/* WaEnable32PlaneMode:icl */
		wa_masked_en(wal, GEN9_CSFE_CHICKEN1_RCS,
			     GEN11_ENABLE_32_PLANE_MODE);

		/*
		 * Wa_1408615072:icl,ehl  (vsunit)
		 * Wa_1407596294:icl,ehl  (hsunit)
		 */
1740 1741
		wa_write_or(wal, UNSLICE_UNIT_LEVEL_CLKGATE,
			    VSUNIT_CLKGATE_DIS | HSUNIT_CLKGATE_DIS);
1742 1743

		/* Wa_1407352427:icl,ehl */
1744 1745
		wa_write_or(wal, UNSLICE_UNIT_LEVEL_CLKGATE2,
			    PSDUNIT_CLKGATE_DIS);
1746 1747 1748 1749 1750

		/* Wa_1406680159:icl,ehl */
		wa_write_or(wal,
			    SUBSLICE_UNIT_LEVEL_CLKGATE,
			    GWUNIT_CLKGATE_DIS);
1751 1752 1753 1754 1755 1756 1757 1758

		/*
		 * Wa_1408767742:icl[a2..forever],ehl[all]
		 * Wa_1605460711:icl[a0..c0]
		 */
		wa_write_or(wal,
			    GEN7_FF_THREAD_MODE,
			    GEN12_FF_TESSELATION_DOP_GATE_DISABLE);
M
Matt Atwood 已提交
1759 1760

		/* Wa_22010271021:ehl */
1761
		if (IS_JSL_EHL(i915))
M
Matt Atwood 已提交
1762 1763 1764
			wa_masked_en(wal,
				     GEN9_CS_DEBUG_MODE1,
				     FF_DOP_CLOCK_GATE_DISABLE);
1765 1766
	}

1767 1768
	if (IS_GEN_RANGE(i915, 9, 12)) {
		/* FtrPerCtxtPreemptionGranularityControl:skl,bxt,kbl,cfl,cnl,icl,tgl */
1769 1770 1771 1772 1773
		wa_masked_en(wal,
			     GEN7_FF_SLICE_CS_CHICKEN1,
			     GEN9_FFSC_PERCTX_PREEMPT_CTRL);
	}

1774 1775 1776 1777
	if (IS_SKYLAKE(i915) ||
	    IS_KABYLAKE(i915) ||
	    IS_COFFEELAKE(i915) ||
	    IS_COMETLAKE(i915)) {
1778 1779 1780 1781 1782 1783 1784 1785 1786 1787 1788 1789 1790
		/* WaEnableGapsTsvCreditFix:skl,kbl,cfl */
		wa_write_or(wal,
			    GEN8_GARBCNTL,
			    GEN9_GAPS_TSV_CREDIT_DISABLE);
	}

	if (IS_BROXTON(i915)) {
		/* WaDisablePooledEuLoadBalancingFix:bxt */
		wa_masked_en(wal,
			     FF_SLICE_CS_CHICKEN2,
			     GEN9_POOLED_EU_LOAD_BALANCING_FIX_DISABLE);
	}

1791
	if (IS_GEN(i915, 9)) {
1792 1793 1794 1795 1796 1797 1798 1799 1800 1801 1802 1803
		/* WaContextSwitchWithConcurrentTLBInvalidate:skl,bxt,kbl,glk,cfl */
		wa_masked_en(wal,
			     GEN9_CSFE_CHICKEN1_RCS,
			     GEN9_PREEMPT_GPGPU_SYNC_SWITCH_DISABLE);

		/* WaEnableLbsSlaRetryTimerDecrement:skl,bxt,kbl,glk,cfl */
		wa_write_or(wal,
			    BDW_SCRATCH1,
			    GEN9_LBS_SLA_RETRY_TIMER_DECREMENT_ENABLE);

		/* WaProgramL3SqcReg1DefaultForPerf:bxt,glk */
		if (IS_GEN9_LP(i915))
1804 1805 1806 1807 1808
			wa_write_clr_set(wal,
					 GEN8_L3SQCREG1,
					 L3_PRIO_CREDITS_MASK,
					 L3_GENERAL_PRIO_CREDITS(62) |
					 L3_HIGH_PRIO_CREDITS(2));
1809 1810 1811 1812 1813

		/* WaOCLCoherentLineFlush:skl,bxt,kbl,cfl */
		wa_write_or(wal,
			    GEN8_L3SQCREG4,
			    GEN8_LQSC_FLUSH_COHERENT_LINES);
1814 1815 1816 1817 1818 1819 1820 1821

		/* Disable atomics in L3 to prevent unrecoverable hangs */
		wa_write_clr_set(wal, GEN9_SCRATCH_LNCF1,
				 GEN9_LNCF_NONIA_COHERENT_ATOMICS_ENABLE, 0);
		wa_write_clr_set(wal, GEN8_L3SQCREG4,
				 GEN8_LQSQ_NONIA_COHERENT_ATOMICS_ENABLE, 0);
		wa_write_clr_set(wal, GEN9_SCRATCH1,
				 EVICTION_PERF_FIX_ENABLE, 0);
1822
	}
1823

1824 1825 1826 1827 1828 1829 1830 1831 1832 1833 1834 1835
	if (IS_HASWELL(i915)) {
		/* WaSampleCChickenBitEnable:hsw */
		wa_masked_en(wal,
			     HALF_SLICE_CHICKEN3, HSW_SAMPLE_C_PERFORMANCE);

		wa_masked_dis(wal,
			      CACHE_MODE_0_GEN7,
			      /* enable HiZ Raw Stall Optimization */
			      HIZ_RAW_STALL_OPT_DISABLE);

		/* WaDisable4x2SubspanOptimization:hsw */
		wa_masked_en(wal, CACHE_MODE_1, PIXEL_SUBSPAN_COLLECT_OPT_DISABLE);
1836 1837 1838 1839 1840 1841 1842
	}

	if (IS_VALLEYVIEW(i915)) {
		/* WaDisableEarlyCull:vlv */
		wa_masked_en(wal,
			     _3D_CHICKEN3,
			     _3D_CHICKEN_SF_DISABLE_OBJEND_CULL);
1843 1844

		/*
1845
		 * WaVSThreadDispatchOverride:ivb,vlv
1846
		 *
1847 1848
		 * This actually overrides the dispatch
		 * mode for all thread types.
1849
		 */
1850 1851 1852 1853 1854 1855 1856 1857 1858 1859 1860 1861 1862
		wa_write_clr_set(wal,
				 GEN7_FF_THREAD_MODE,
				 GEN7_FF_SCHED_MASK,
				 GEN7_FF_TS_SCHED_HW |
				 GEN7_FF_VS_SCHED_HW |
				 GEN7_FF_DS_SCHED_HW);

		/* WaPsdDispatchEnable:vlv */
		/* WaDisablePSDDualDispatchEnable:vlv */
		wa_masked_en(wal,
			     GEN7_HALF_SLICE_CHICKEN1,
			     GEN7_MAX_PS_THREAD_DEP |
			     GEN7_PSD_SINGLE_PORT_DISPATCH_ENABLE);
1863 1864
	}

1865 1866
	if (IS_IVYBRIDGE(i915)) {
		/* WaDisableEarlyCull:ivb */
1867 1868 1869 1870
		wa_masked_en(wal,
			     _3D_CHICKEN3,
			     _3D_CHICKEN_SF_DISABLE_OBJEND_CULL);

1871 1872 1873 1874 1875 1876 1877
		if (0) { /* causes HiZ corruption on ivb:gt1 */
			/* enable HiZ Raw Stall Optimization */
			wa_masked_dis(wal,
				      CACHE_MODE_0_GEN7,
				      HIZ_RAW_STALL_OPT_DISABLE);
		}

1878 1879 1880 1881 1882 1883 1884 1885 1886 1887 1888 1889 1890
		/*
		 * WaVSThreadDispatchOverride:ivb,vlv
		 *
		 * This actually overrides the dispatch
		 * mode for all thread types.
		 */
		wa_write_clr_set(wal,
				 GEN7_FF_THREAD_MODE,
				 GEN7_FF_SCHED_MASK,
				 GEN7_FF_TS_SCHED_HW |
				 GEN7_FF_VS_SCHED_HW |
				 GEN7_FF_DS_SCHED_HW);

1891 1892 1893 1894 1895 1896 1897 1898 1899 1900 1901 1902 1903 1904
		/* WaDisablePSDDualDispatchEnable:ivb */
		if (IS_IVB_GT1(i915))
			wa_masked_en(wal,
				     GEN7_HALF_SLICE_CHICKEN1,
				     GEN7_PSD_SINGLE_PORT_DISPATCH_ENABLE);
	}

	if (IS_GEN(i915, 7)) {
		/* WaBCSVCSTlbInvalidationMode:ivb,vlv,hsw */
		wa_masked_en(wal,
			     GFX_MODE_GEN7,
			     GFX_TLB_INVALIDATE_EXPLICIT | GFX_REPLAY_MODE);

		/* WaDisable_RenderCache_OperationalFlush:ivb,vlv,hsw */
1905 1906 1907 1908
		wa_masked_dis(wal, CACHE_MODE_0_GEN7, RC_OP_FLUSH_ENABLE);

		/*
		 * BSpec says this must be set, even though
1909
		 * WaDisable4x2SubspanOptimization:ivb,hsw
1910 1911 1912 1913 1914 1915 1916 1917 1918 1919 1920 1921 1922 1923 1924 1925 1926 1927 1928 1929
		 * WaDisable4x2SubspanOptimization isn't listed for VLV.
		 */
		wa_masked_en(wal,
			     CACHE_MODE_1,
			     PIXEL_SUBSPAN_COLLECT_OPT_DISABLE);

		/*
		 * BSpec recommends 8x4 when MSAA is used,
		 * however in practice 16x4 seems fastest.
		 *
		 * Note that PS/WM thread counts depend on the WIZ hashing
		 * disable bit, which we don't touch here, but it's good
		 * to keep in mind (see 3DSTATE_PS and 3DSTATE_WM).
		 */
		wa_add(wal, GEN7_GT_MODE, 0,
		       _MASKED_FIELD(GEN6_WIZ_HASHING_MASK,
				     GEN6_WIZ_HASHING_16x4),
		       GEN6_WIZ_HASHING_16x4);
	}

1930 1931 1932 1933 1934 1935 1936 1937 1938 1939 1940 1941 1942 1943 1944 1945 1946 1947 1948 1949 1950 1951
	if (IS_GEN_RANGE(i915, 6, 7))
		/*
		 * We need to disable the AsyncFlip performance optimisations in
		 * order to use MI_WAIT_FOR_EVENT within the CS. It should
		 * already be programmed to '1' on all products.
		 *
		 * WaDisableAsyncFlipPerfMode:snb,ivb,hsw,vlv
		 */
		wa_masked_en(wal,
			     MI_MODE,
			     ASYNC_FLIP_PERF_DISABLE);

	if (IS_GEN(i915, 6)) {
		/*
		 * Required for the hardware to program scanline values for
		 * waiting
		 * WaEnableFlushTlbInvalidationMode:snb
		 */
		wa_masked_en(wal,
			     GFX_MODE,
			     GFX_TLB_INVALIDATE_EXPLICIT);

1952 1953 1954 1955 1956 1957 1958 1959 1960 1961 1962 1963 1964 1965 1966 1967 1968 1969 1970 1971 1972 1973 1974 1975 1976 1977 1978 1979 1980 1981 1982 1983 1984
		/* WaDisableHiZPlanesWhenMSAAEnabled:snb */
		wa_masked_en(wal,
			     _3D_CHICKEN,
			     _3D_CHICKEN_HIZ_PLANE_DISABLE_MSAA_4X_SNB);

		wa_masked_en(wal,
			     _3D_CHICKEN3,
			     /* WaStripsFansDisableFastClipPerformanceFix:snb */
			     _3D_CHICKEN3_SF_DISABLE_FASTCLIP_CULL |
			     /*
			      * Bspec says:
			      * "This bit must be set if 3DSTATE_CLIP clip mode is set
			      * to normal and 3DSTATE_SF number of SF output attributes
			      * is more than 16."
			      */
			     _3D_CHICKEN3_SF_DISABLE_PIPELINED_ATTR_FETCH);

		/*
		 * BSpec recommends 8x4 when MSAA is used,
		 * however in practice 16x4 seems fastest.
		 *
		 * Note that PS/WM thread counts depend on the WIZ hashing
		 * disable bit, which we don't touch here, but it's good
		 * to keep in mind (see 3DSTATE_PS and 3DSTATE_WM).
		 */
		wa_add(wal,
		       GEN6_GT_MODE, 0,
		       _MASKED_FIELD(GEN6_WIZ_HASHING_MASK, GEN6_WIZ_HASHING_16x4),
		       GEN6_WIZ_HASHING_16x4);

		/* WaDisable_RenderCache_OperationalFlush:snb */
		wa_masked_dis(wal, CACHE_MODE_0, RC_OP_FLUSH_ENABLE);

1985 1986 1987 1988 1989 1990 1991 1992 1993 1994 1995 1996 1997 1998 1999 2000 2001
		/*
		 * From the Sandybridge PRM, volume 1 part 3, page 24:
		 * "If this bit is set, STCunit will have LRA as replacement
		 *  policy. [...] This bit must be reset. LRA replacement
		 *  policy is not supported."
		 */
		wa_masked_dis(wal,
			      CACHE_MODE_0,
			      CM0_STC_EVICT_DISABLE_LRA_SNB);
	}

	if (IS_GEN_RANGE(i915, 4, 6))
		/* WaTimedSingleVertexDispatch:cl,bw,ctg,elk,ilk,snb */
		wa_add(wal, MI_MODE,
		       0, _MASKED_BIT_ENABLE(VS_TIMER_DISPATCH),
		       /* XXX bit doesn't stick on Broadwater */
		       IS_I965G(i915) ? 0 : VS_TIMER_DISPATCH);
2002 2003 2004 2005 2006 2007 2008 2009 2010 2011 2012 2013 2014 2015 2016

	if (IS_GEN(i915, 4))
		/*
		 * Disable CONSTANT_BUFFER before it is loaded from the context
		 * image. For as it is loaded, it is executed and the stored
		 * address may no longer be valid, leading to a GPU hang.
		 *
		 * This imposes the requirement that userspace reload their
		 * CONSTANT_BUFFER on every batch, fortunately a requirement
		 * they are already accustomed to from before contexts were
		 * enabled.
		 */
		wa_add(wal, ECOSKPD,
		       0, _MASKED_BIT_ENABLE(ECO_CONSTANT_BUFFER_SR_DISABLE),
		       0 /* XXX bit doesn't stick on Broadwater */);
2017 2018
}

2019 2020
static void
xcs_engine_wa_init(struct intel_engine_cs *engine, struct i915_wa_list *wal)
2021 2022 2023 2024
{
	struct drm_i915_private *i915 = engine->i915;

	/* WaKBLVECSSemaphoreWaitPoll:kbl */
2025
	if (IS_KBL_GT_STEP(i915, STEP_A0, STEP_E0)) {
2026 2027 2028 2029 2030 2031
		wa_write(wal,
			 RING_SEMA_WAIT_POLL(engine->mmio_base),
			 1);
	}
}

2032 2033 2034
static void
engine_init_workarounds(struct intel_engine_cs *engine, struct i915_wa_list *wal)
{
2035
	if (I915_SELFTEST_ONLY(INTEL_GEN(engine->i915) < 4))
2036 2037
		return;

2038
	if (engine->class == RENDER_CLASS)
2039 2040 2041 2042 2043
		rcs_engine_wa_init(engine, wal);
	else
		xcs_engine_wa_init(engine, wal);
}

2044 2045 2046 2047
void intel_engine_init_workarounds(struct intel_engine_cs *engine)
{
	struct i915_wa_list *wal = &engine->wa_list;

2048
	if (INTEL_GEN(engine->i915) < 4)
2049 2050
		return;

2051
	wa_init_start(wal, "engine", engine->name);
2052
	engine_init_workarounds(engine, wal);
2053 2054 2055 2056 2057
	wa_init_finish(wal);
}

void intel_engine_apply_workarounds(struct intel_engine_cs *engine)
{
2058
	wa_list_apply(engine->uncore, &engine->wa_list);
2059 2060
}

2061
struct mcr_range {
M
Matt Roper 已提交
2062 2063
	u32 start;
	u32 end;
2064 2065 2066
};

static const struct mcr_range mcr_ranges_gen8[] = {
M
Matt Roper 已提交
2067 2068 2069 2070 2071 2072 2073 2074
	{ .start = 0x5500, .end = 0x55ff },
	{ .start = 0x7000, .end = 0x7fff },
	{ .start = 0x9400, .end = 0x97ff },
	{ .start = 0xb000, .end = 0xb3ff },
	{ .start = 0xe000, .end = 0xe7ff },
	{},
};

2075 2076 2077 2078 2079 2080 2081 2082 2083
static const struct mcr_range mcr_ranges_gen12[] = {
	{ .start =  0x8150, .end =  0x815f },
	{ .start =  0x9520, .end =  0x955f },
	{ .start =  0xb100, .end =  0xb3ff },
	{ .start =  0xde80, .end =  0xe8ff },
	{ .start = 0x24a00, .end = 0x24a7f },
	{},
};

2084 2085
static bool mcr_range(struct drm_i915_private *i915, u32 offset)
{
2086
	const struct mcr_range *mcr_ranges;
M
Matt Roper 已提交
2087 2088
	int i;

2089 2090 2091 2092 2093
	if (INTEL_GEN(i915) >= 12)
		mcr_ranges = mcr_ranges_gen12;
	else if (INTEL_GEN(i915) >= 8)
		mcr_ranges = mcr_ranges_gen8;
	else
M
Matt Roper 已提交
2094 2095
		return false;

2096
	/*
M
Matt Roper 已提交
2097
	 * Registers in these ranges are affected by the MCR selector
2098 2099 2100
	 * which only controls CPU initiated MMIO. Routing does not
	 * work for CS access so we cannot verify them on this path.
	 */
2101 2102 2103
	for (i = 0; mcr_ranges[i].start; i++)
		if (offset >= mcr_ranges[i].start &&
		    offset <= mcr_ranges[i].end)
M
Matt Roper 已提交
2104
			return true;
2105 2106 2107 2108

	return false;
}

2109 2110 2111 2112 2113
static int
wa_list_srm(struct i915_request *rq,
	    const struct i915_wa_list *wal,
	    struct i915_vma *vma)
{
2114
	struct drm_i915_private *i915 = rq->engine->i915;
2115
	unsigned int i, count = 0;
2116 2117 2118 2119
	const struct i915_wa *wa;
	u32 srm, *cs;

	srm = MI_STORE_REGISTER_MEM | MI_SRM_LRM_GLOBAL_GTT;
2120
	if (INTEL_GEN(i915) >= 8)
2121 2122
		srm++;

2123 2124 2125 2126 2127 2128
	for (i = 0, wa = wal->list; i < wal->count; i++, wa++) {
		if (!mcr_range(i915, i915_mmio_reg_offset(wa->reg)))
			count++;
	}

	cs = intel_ring_begin(rq, 4 * count);
2129 2130 2131 2132
	if (IS_ERR(cs))
		return PTR_ERR(cs);

	for (i = 0, wa = wal->list; i < wal->count; i++, wa++) {
2133 2134 2135 2136 2137
		u32 offset = i915_mmio_reg_offset(wa->reg);

		if (mcr_range(i915, offset))
			continue;

2138
		*cs++ = srm;
2139
		*cs++ = offset;
2140 2141 2142 2143 2144 2145 2146 2147
		*cs++ = i915_ggtt_offset(vma) + sizeof(u32) * i;
		*cs++ = 0;
	}
	intel_ring_advance(rq, cs);

	return 0;
}

2148
static int engine_wa_list_verify(struct intel_context *ce,
2149 2150 2151 2152 2153 2154
				 const struct i915_wa_list * const wal,
				 const char *from)
{
	const struct i915_wa *wa;
	struct i915_request *rq;
	struct i915_vma *vma;
2155
	struct i915_gem_ww_ctx ww;
2156 2157 2158 2159 2160 2161 2162
	unsigned int i;
	u32 *results;
	int err;

	if (!wal->count)
		return 0;

2163 2164
	vma = __vm_create_scratch_for_read(&ce->engine->gt->ggtt->vm,
					   wal->count * sizeof(u32));
2165 2166 2167
	if (IS_ERR(vma))
		return PTR_ERR(vma);

2168
	intel_engine_pm_get(ce->engine);
2169 2170 2171 2172 2173 2174 2175 2176 2177
	i915_gem_ww_ctx_init(&ww, false);
retry:
	err = i915_gem_object_lock(vma->obj, &ww);
	if (err == 0)
		err = intel_context_pin_ww(ce, &ww);
	if (err)
		goto err_pm;

	rq = i915_request_create(ce);
2178 2179
	if (IS_ERR(rq)) {
		err = PTR_ERR(rq);
2180
		goto err_unpin;
2181 2182
	}

2183 2184 2185
	err = i915_request_await_object(rq, vma->obj, true);
	if (err == 0)
		err = i915_vma_move_to_active(vma, rq, EXEC_OBJECT_WRITE);
2186 2187
	if (err == 0)
		err = wa_list_srm(rq, wal, vma);
2188

2189
	i915_request_get(rq);
2190 2191
	if (err)
		i915_request_set_error_once(rq, err);
2192
	i915_request_add(rq);
2193 2194 2195 2196

	if (err)
		goto err_rq;

2197
	if (i915_request_wait(rq, 0, HZ / 5) < 0) {
2198
		err = -ETIME;
2199
		goto err_rq;
2200 2201 2202 2203 2204
	}

	results = i915_gem_object_pin_map(vma->obj, I915_MAP_WB);
	if (IS_ERR(results)) {
		err = PTR_ERR(results);
2205
		goto err_rq;
2206 2207 2208
	}

	err = 0;
2209
	for (i = 0, wa = wal->list; i < wal->count; i++, wa++) {
2210
		if (mcr_range(rq->engine->i915, i915_mmio_reg_offset(wa->reg)))
2211 2212
			continue;

2213 2214
		if (!wa_verify(wa, results[i], wal->name, from))
			err = -ENXIO;
2215
	}
2216 2217 2218

	i915_gem_object_unpin_map(vma->obj);

2219 2220
err_rq:
	i915_request_put(rq);
2221 2222 2223 2224 2225 2226 2227 2228 2229 2230
err_unpin:
	intel_context_unpin(ce);
err_pm:
	if (err == -EDEADLK) {
		err = i915_gem_ww_ctx_backoff(&ww);
		if (!err)
			goto retry;
	}
	i915_gem_ww_ctx_fini(&ww);
	intel_engine_pm_put(ce->engine);
2231 2232 2233 2234 2235 2236 2237 2238
	i915_vma_unpin(vma);
	i915_vma_put(vma);
	return err;
}

int intel_engine_verify_workarounds(struct intel_engine_cs *engine,
				    const char *from)
{
2239 2240 2241
	return engine_wa_list_verify(engine->kernel_context,
				     &engine->wa_list,
				     from);
2242 2243
}

2244
#if IS_ENABLED(CONFIG_DRM_I915_SELFTEST)
2245
#include "selftest_workarounds.c"
2246
#endif