namei.c 25.7 KB
Newer Older
M
Miklos Szeredi 已提交
1 2 3 4 5 6 7 8 9 10
/*
 * Copyright (C) 2011 Novell Inc.
 * Copyright (C) 2016 Red Hat, Inc.
 *
 * This program is free software; you can redistribute it and/or modify it
 * under the terms of the GNU General Public License version 2 as published by
 * the Free Software Foundation.
 */

#include <linux/fs.h>
11
#include <linux/cred.h>
A
Amir Goldstein 已提交
12
#include <linux/ctype.h>
M
Miklos Szeredi 已提交
13 14
#include <linux/namei.h>
#include <linux/xattr.h>
M
Miklos Szeredi 已提交
15
#include <linux/ratelimit.h>
16 17
#include <linux/mount.h>
#include <linux/exportfs.h>
M
Miklos Szeredi 已提交
18 19
#include "overlayfs.h"

20 21 22 23 24 25
struct ovl_lookup_data {
	struct qstr name;
	bool is_dir;
	bool opaque;
	bool stop;
	bool last;
M
Miklos Szeredi 已提交
26
	char *redirect;
27
};
M
Miklos Szeredi 已提交
28

M
Miklos Szeredi 已提交
29 30 31 32 33 34 35 36 37 38 39 40
static int ovl_check_redirect(struct dentry *dentry, struct ovl_lookup_data *d,
			      size_t prelen, const char *post)
{
	int res;
	char *s, *next, *buf = NULL;

	res = vfs_getxattr(dentry, OVL_XATTR_REDIRECT, NULL, 0);
	if (res < 0) {
		if (res == -ENODATA || res == -EOPNOTSUPP)
			return 0;
		goto fail;
	}
41
	buf = kzalloc(prelen + res + strlen(post) + 1, GFP_KERNEL);
M
Miklos Szeredi 已提交
42 43 44 45 46 47 48 49 50 51 52 53 54 55 56 57 58
	if (!buf)
		return -ENOMEM;

	if (res == 0)
		goto invalid;

	res = vfs_getxattr(dentry, OVL_XATTR_REDIRECT, buf, res);
	if (res < 0)
		goto fail;
	if (res == 0)
		goto invalid;
	if (buf[0] == '/') {
		for (s = buf; *s++ == '/'; s = next) {
			next = strchrnul(s, '/');
			if (s == next)
				goto invalid;
		}
59 60 61 62 63 64 65 66 67
		/*
		 * One of the ancestor path elements in an absolute path
		 * lookup in ovl_lookup_layer() could have been opaque and
		 * that will stop further lookup in lower layers (d->stop=true)
		 * But we have found an absolute redirect in decendant path
		 * element and that should force continue lookup in lower
		 * layers (reset d->stop).
		 */
		d->stop = false;
M
Miklos Szeredi 已提交
68 69 70 71 72 73 74 75 76 77 78 79 80 81 82 83 84 85 86 87 88 89 90 91 92 93 94
	} else {
		if (strchr(buf, '/') != NULL)
			goto invalid;

		memmove(buf + prelen, buf, res);
		memcpy(buf, d->name.name, prelen);
	}

	strcat(buf, post);
	kfree(d->redirect);
	d->redirect = buf;
	d->name.name = d->redirect;
	d->name.len = strlen(d->redirect);

	return 0;

err_free:
	kfree(buf);
	return 0;
fail:
	pr_warn_ratelimited("overlayfs: failed to get redirect (%i)\n", res);
	goto err_free;
invalid:
	pr_warn_ratelimited("overlayfs: invalid redirect (%s)\n", buf);
	goto err_free;
}

95 96
static int ovl_acceptable(void *ctx, struct dentry *dentry)
{
97 98 99 100 101 102 103 104 105 106 107 108 109
	/*
	 * A non-dir origin may be disconnected, which is fine, because
	 * we only need it for its unique inode number.
	 */
	if (!d_is_dir(dentry))
		return 1;

	/* Don't decode a deleted empty directory */
	if (d_unhashed(dentry))
		return 0;

	/* Check if directory belongs to the layer we are decoding from */
	return is_subdir(dentry, ((struct vfsmount *)ctx)->mnt_root);
110 111
}

112 113 114 115 116 117 118
/*
 * Check validity of an overlay file handle buffer.
 *
 * Return 0 for a valid file handle.
 * Return -ENODATA for "origin unknown".
 * Return <0 for an invalid file handle.
 */
119
int ovl_check_fh_len(struct ovl_fh *fh, int fh_len)
120 121 122 123 124 125 126 127 128 129 130 131 132 133 134 135 136 137 138
{
	if (fh_len < sizeof(struct ovl_fh) || fh_len < fh->len)
		return -EINVAL;

	if (fh->magic != OVL_FH_MAGIC)
		return -EINVAL;

	/* Treat larger version and unknown flags as "origin unknown" */
	if (fh->version > OVL_FH_VERSION || fh->flags & ~OVL_FH_FLAG_ALL)
		return -ENODATA;

	/* Treat endianness mismatch as "origin unknown" */
	if (!(fh->flags & OVL_FH_FLAG_ANY_ENDIAN) &&
	    (fh->flags & OVL_FH_FLAG_BIG_ENDIAN) != OVL_FH_FLAG_CPU_ENDIAN)
		return -ENODATA;

	return 0;
}

139
static struct ovl_fh *ovl_get_fh(struct dentry *dentry, const char *name)
140
{
141
	int res, err;
142 143
	struct ovl_fh *fh = NULL;

144
	res = vfs_getxattr(dentry, name, NULL, 0);
145 146 147 148 149 150 151 152 153
	if (res < 0) {
		if (res == -ENODATA || res == -EOPNOTSUPP)
			return NULL;
		goto fail;
	}
	/* Zero size value means "copied up but origin unknown" */
	if (res == 0)
		return NULL;

154
	fh = kzalloc(res, GFP_KERNEL);
155 156 157
	if (!fh)
		return ERR_PTR(-ENOMEM);

158
	res = vfs_getxattr(dentry, name, fh, res);
159 160 161
	if (res < 0)
		goto fail;

162 163 164 165
	err = ovl_check_fh_len(fh, res);
	if (err < 0) {
		if (err == -ENODATA)
			goto out;
166
		goto invalid;
167
	}
168

169 170 171 172 173 174 175 176 177 178 179 180 181 182
	return fh;

out:
	kfree(fh);
	return NULL;

fail:
	pr_warn_ratelimited("overlayfs: failed to get origin (%i)\n", res);
	goto out;
invalid:
	pr_warn_ratelimited("overlayfs: invalid origin (%*phN)\n", res, fh);
	goto out;
}

183 184
struct dentry *ovl_decode_real_fh(struct ovl_fh *fh, struct vfsmount *mnt,
				  bool connected)
185
{
186
	struct dentry *real;
187 188
	int bytes;

189 190 191 192
	/*
	 * Make sure that the stored uuid matches the uuid of the lower
	 * layer where file handle will be decoded.
	 */
193
	if (!uuid_equal(&fh->uuid, &mnt->mnt_sb->s_uuid))
194
		return NULL;
195

196
	bytes = (fh->len - offsetof(struct ovl_fh, fid));
197 198
	real = exportfs_decode_fh(mnt, (struct fid *)fh->fid,
				  bytes >> 2, (int)fh->type,
199
				  connected ? ovl_acceptable : NULL, mnt);
200 201 202 203 204 205 206 207 208 209 210
	if (IS_ERR(real)) {
		/*
		 * Treat stale file handle to lower file as "origin unknown".
		 * upper file handle could become stale when upper file is
		 * unlinked and this information is needed to handle stale
		 * index entries correctly.
		 */
		if (real == ERR_PTR(-ESTALE) &&
		    !(fh->flags & OVL_FH_FLAG_PATH_UPPER))
			real = NULL;
		return real;
211 212
	}

213 214
	if (ovl_dentry_weird(real)) {
		dput(real);
215 216
		return NULL;
	}
217

218
	return real;
219 220
}

221 222 223 224 225
static bool ovl_is_opaquedir(struct dentry *dentry)
{
	return ovl_check_dir_xattr(dentry, OVL_XATTR_OPAQUE);
}

226 227
static int ovl_lookup_single(struct dentry *base, struct ovl_lookup_data *d,
			     const char *name, unsigned int namelen,
M
Miklos Szeredi 已提交
228
			     size_t prelen, const char *post,
229 230 231 232
			     struct dentry **ret)
{
	struct dentry *this;
	int err;
233
	bool last_element = !post[0];
234 235 236 237 238 239 240 241 242 243 244 245 246 247 248 249 250 251 252 253 254 255 256 257 258

	this = lookup_one_len_unlocked(name, base, namelen);
	if (IS_ERR(this)) {
		err = PTR_ERR(this);
		this = NULL;
		if (err == -ENOENT || err == -ENAMETOOLONG)
			goto out;
		goto out_err;
	}
	if (!this->d_inode)
		goto put_and_out;

	if (ovl_dentry_weird(this)) {
		/* Don't support traversing automounts and other weirdness */
		err = -EREMOTE;
		goto out_err;
	}
	if (ovl_is_whiteout(this)) {
		d->stop = d->opaque = true;
		goto put_and_out;
	}
	if (!d_can_lookup(this)) {
		d->stop = true;
		if (d->is_dir)
			goto put_and_out;
259 260 261 262 263 264

		/*
		 * NB: handle failure to lookup non-last element when non-dir
		 * redirects become possible
		 */
		WARN_ON(!last_element);
265 266
		goto out;
	}
267 268
	if (last_element)
		d->is_dir = true;
269 270 271 272
	if (d->last)
		goto out;

	if (ovl_is_opaquedir(this)) {
273 274 275
		d->stop = true;
		if (last_element)
			d->opaque = true;
276 277
		goto out;
	}
M
Miklos Szeredi 已提交
278 279 280
	err = ovl_check_redirect(this, d, prelen, post);
	if (err)
		goto out_err;
281 282 283 284 285 286 287 288 289 290 291 292 293 294 295 296 297
out:
	*ret = this;
	return 0;

put_and_out:
	dput(this);
	this = NULL;
	goto out;

out_err:
	dput(this);
	return err;
}

static int ovl_lookup_layer(struct dentry *base, struct ovl_lookup_data *d,
			    struct dentry **ret)
{
298 299
	/* Counting down from the end, since the prefix can change */
	size_t rem = d->name.len - 1;
M
Miklos Szeredi 已提交
300 301 302
	struct dentry *dentry = NULL;
	int err;

303
	if (d->name.name[0] != '/')
M
Miklos Szeredi 已提交
304 305 306
		return ovl_lookup_single(base, d, d->name.name, d->name.len,
					 0, "", ret);

307 308
	while (!IS_ERR_OR_NULL(base) && d_can_lookup(base)) {
		const char *s = d->name.name + d->name.len - rem;
M
Miklos Szeredi 已提交
309
		const char *next = strchrnul(s, '/');
310 311
		size_t thislen = next - s;
		bool end = !next[0];
M
Miklos Szeredi 已提交
312

313 314
		/* Verify we did not go off the rails */
		if (WARN_ON(s[-1] != '/'))
M
Miklos Szeredi 已提交
315 316
			return -EIO;

317 318
		err = ovl_lookup_single(base, d, s, thislen,
					d->name.len - rem, next, &base);
M
Miklos Szeredi 已提交
319 320 321 322
		dput(dentry);
		if (err)
			return err;
		dentry = base;
323 324 325 326 327 328 329
		if (end)
			break;

		rem -= thislen + 1;

		if (WARN_ON(rem >= d->name.len))
			return -EIO;
M
Miklos Szeredi 已提交
330 331 332
	}
	*ret = dentry;
	return 0;
333 334
}

335

336
int ovl_check_origin_fh(struct ovl_fs *ofs, struct ovl_fh *fh, bool connected,
337
			struct dentry *upperdentry, struct ovl_path **stackp)
338
{
339 340
	struct dentry *origin = NULL;
	int i;
341

342
	for (i = 0; i < ofs->numlower; i++) {
343 344
		origin = ovl_decode_real_fh(fh, ofs->lower_layers[i].mnt,
					    connected);
345 346 347 348 349
		if (origin)
			break;
	}

	if (!origin)
350 351 352 353
		return -ESTALE;
	else if (IS_ERR(origin))
		return PTR_ERR(origin);

354
	if (upperdentry && !ovl_is_whiteout(upperdentry) &&
355 356
	    ((d_inode(origin)->i_mode ^ d_inode(upperdentry)->i_mode) & S_IFMT))
		goto invalid;
357

358
	if (!*stackp)
359
		*stackp = kmalloc(sizeof(struct ovl_path), GFP_KERNEL);
360 361 362 363
	if (!*stackp) {
		dput(origin);
		return -ENOMEM;
	}
364 365 366 367
	**stackp = (struct ovl_path){
		.dentry = origin,
		.layer = &ofs->lower_layers[i]
	};
368 369

	return 0;
370 371 372 373 374 375 376 377 378

invalid:
	pr_warn_ratelimited("overlayfs: invalid origin (%pd2, ftype=%x, origin ftype=%x).\n",
			    upperdentry, d_inode(upperdentry)->i_mode & S_IFMT,
			    d_inode(origin)->i_mode & S_IFMT);
	dput(origin);
	return -EIO;
}

379
static int ovl_check_origin(struct ovl_fs *ofs, struct dentry *upperdentry,
380 381
			    struct ovl_path **stackp, unsigned int *ctrp)
{
382
	struct ovl_fh *fh = ovl_get_fh(upperdentry, OVL_XATTR_ORIGIN);
383 384 385 386 387
	int err;

	if (IS_ERR_OR_NULL(fh))
		return PTR_ERR(fh);

388
	err = ovl_check_origin_fh(ofs, fh, false, upperdentry, stackp);
389 390 391 392 393 394 395 396 397 398 399 400 401
	kfree(fh);

	if (err) {
		if (err == -ESTALE)
			return 0;
		return err;
	}

	if (WARN_ON(*ctrp))
		return -EIO;

	*ctrp = 1;
	return 0;
402 403
}

404
/*
405
 * Verify that @fh matches the file handle stored in xattr @name.
406 407
 * Return 0 on match, -ESTALE on mismatch, < 0 on error.
 */
408 409
static int ovl_verify_fh(struct dentry *dentry, const char *name,
			 const struct ovl_fh *fh)
410
{
411
	struct ovl_fh *ofh = ovl_get_fh(dentry, name);
412 413 414 415 416 417 418 419 420 421 422 423 424 425 426 427
	int err = 0;

	if (!ofh)
		return -ENODATA;

	if (IS_ERR(ofh))
		return PTR_ERR(ofh);

	if (fh->len != ofh->len || memcmp(fh, ofh, fh->len))
		err = -ESTALE;

	kfree(ofh);
	return err;
}

/*
428
 * Verify that @real dentry matches the file handle stored in xattr @name.
429
 *
430 431
 * If @set is true and there is no stored file handle, encode @real and store
 * file handle in xattr @name.
432
 *
433
 * Return 0 on match, -ESTALE on mismatch, -ENODATA on no xattr, < 0 on error.
434
 */
435 436
int ovl_verify_set_fh(struct dentry *dentry, const char *name,
		      struct dentry *real, bool is_upper, bool set)
437 438 439 440 441
{
	struct inode *inode;
	struct ovl_fh *fh;
	int err;

442
	fh = ovl_encode_real_fh(real, is_upper);
443 444 445 446
	err = PTR_ERR(fh);
	if (IS_ERR(fh))
		goto fail;

447
	err = ovl_verify_fh(dentry, name, fh);
448
	if (set && err == -ENODATA)
449
		err = ovl_do_setxattr(dentry, name, fh, fh->len, 0);
450 451 452 453 454 455 456 457
	if (err)
		goto fail;

out:
	kfree(fh);
	return err;

fail:
458 459 460 461
	inode = d_inode(real);
	pr_warn_ratelimited("overlayfs: failed to verify %s (%pd2, ino=%lu, err=%i)\n",
			    is_upper ? "upper" : "origin", real,
			    inode ? inode->i_ino : 0, err);
462 463 464
	goto out;
}

465
/* Get upper dentry from index */
466
struct dentry *ovl_index_upper(struct ovl_fs *ofs, struct dentry *index)
467 468 469 470 471 472 473 474 475 476 477
{
	struct ovl_fh *fh;
	struct dentry *upper;

	if (!d_is_dir(index))
		return dget(index);

	fh = ovl_get_fh(index, OVL_XATTR_UPPER);
	if (IS_ERR_OR_NULL(fh))
		return ERR_CAST(fh);

478
	upper = ovl_decode_real_fh(fh, ofs->upper_mnt, true);
479 480 481 482 483 484 485 486 487 488 489 490 491 492 493
	kfree(fh);

	if (IS_ERR_OR_NULL(upper))
		return upper ?: ERR_PTR(-ESTALE);

	if (!d_is_dir(upper)) {
		pr_warn_ratelimited("overlayfs: invalid index upper (%pd2, upper=%pd2).\n",
				    index, upper);
		dput(upper);
		return ERR_PTR(-EIO);
	}

	return upper;
}

A
Amir Goldstein 已提交
494 495 496 497 498 499
/* Is this a leftover from create/whiteout of directory index entry? */
static bool ovl_is_temp_index(struct dentry *index)
{
	return index->d_name.name[0] == '#';
}

500 501 502 503 504
/*
 * Verify that an index entry name matches the origin file handle stored in
 * OVL_XATTR_ORIGIN and that origin file handle can be decoded to lower path.
 * Return 0 on match, -ESTALE on mismatch or stale origin, < 0 on error.
 */
505
int ovl_verify_index(struct ovl_fs *ofs, struct dentry *index)
506 507 508
{
	struct ovl_fh *fh = NULL;
	size_t len;
509 510
	struct ovl_path origin = { };
	struct ovl_path *stack = &origin;
511
	struct dentry *upper = NULL;
512 513 514 515 516
	int err;

	if (!d_inode(index))
		return 0;

A
Amir Goldstein 已提交
517 518 519 520 521
	/* Cleanup leftover from index create/cleanup attempt */
	err = -ESTALE;
	if (ovl_is_temp_index(index))
		goto fail;

522
	err = -EINVAL;
523 524 525 526 527
	if (index->d_name.len < sizeof(struct ovl_fh)*2)
		goto fail;

	err = -ENOMEM;
	len = index->d_name.len / 2;
528
	fh = kzalloc(len, GFP_KERNEL);
529 530 531 532
	if (!fh)
		goto fail;

	err = -EINVAL;
533 534 535 536 537
	if (hex2bin((u8 *)fh, index->d_name.name, len))
		goto fail;

	err = ovl_check_fh_len(fh, len);
	if (err)
538 539
		goto fail;

540 541 542 543 544 545 546 547
	/*
	 * Whiteout index entries are used as an indication that an exported
	 * overlay file handle should be treated as stale (i.e. after unlink
	 * of the overlay inode). These entries contain no origin xattr.
	 */
	if (ovl_is_whiteout(index))
		goto out;

548 549 550 551 552 553 554 555 556 557 558 559 560 561 562 563 564
	/*
	 * Verifying directory index entries are not stale is expensive, so
	 * only verify stale dir index if NFS export is enabled.
	 */
	if (d_is_dir(index) && !ofs->config.nfs_export)
		goto out;

	/*
	 * Directory index entries should have 'upper' xattr pointing to the
	 * real upper dir. Non-dir index entries are hardlinks to the upper
	 * real inode. For non-dir index, we can read the copy up origin xattr
	 * directly from the index dentry, but for dir index we first need to
	 * decode the upper directory.
	 */
	upper = ovl_index_upper(ofs, index);
	if (IS_ERR_OR_NULL(upper)) {
		err = PTR_ERR(upper);
565 566 567 568 569 570 571 572 573
		/*
		 * Directory index entries with no 'upper' xattr need to be
		 * removed. When dir index entry has a stale 'upper' xattr,
		 * we assume that upper dir was removed and we treat the dir
		 * index as orphan entry that needs to be whited out.
		 */
		if (err == -ESTALE)
			goto orphan;
		else if (!err)
574
			err = -ESTALE;
575
		goto fail;
576
	}
577

578 579
	err = ovl_verify_fh(upper, OVL_XATTR_ORIGIN, fh);
	dput(upper);
580 581 582
	if (err)
		goto fail;

583 584
	/* Check if non-dir index is orphan and don't warn before cleaning it */
	if (!d_is_dir(index) && d_inode(index)->i_nlink == 1) {
585
		err = ovl_check_origin_fh(ofs, fh, false, index, &stack);
586 587 588 589
		if (err)
			goto fail;

		if (ovl_get_nlink(origin.dentry, index, 0) == 0)
590
			goto orphan;
591
	}
592

593
out:
594
	dput(origin.dentry);
595 596 597 598
	kfree(fh);
	return err;

fail:
599 600
	pr_warn_ratelimited("overlayfs: failed to verify index (%pd2, ftype=%x, err=%i)\n",
			    index, d_inode(index)->i_mode & S_IFMT, err);
601
	goto out;
602 603 604 605 606 607 608

orphan:
	pr_warn_ratelimited("overlayfs: orphan index entry (%pd2, ftype=%x, nlink=%u)\n",
			    index, d_inode(index)->i_mode & S_IFMT,
			    d_inode(index)->i_nlink);
	err = -ENOENT;
	goto out;
609 610
}

611 612 613 614
static int ovl_get_index_name_fh(struct ovl_fh *fh, struct qstr *name)
{
	char *n, *s;

K
Kees Cook 已提交
615
	n = kcalloc(fh->len, 2, GFP_KERNEL);
616 617 618 619 620 621 622 623 624 625
	if (!n)
		return -ENOMEM;

	s  = bin2hex(n, fh, fh->len);
	*name = (struct qstr) QSTR_INIT(n, s - n);

	return 0;

}

626 627 628 629 630 631 632 633 634 635 636 637 638 639 640 641 642 643
/*
 * Lookup in indexdir for the index entry of a lower real inode or a copy up
 * origin inode. The index entry name is the hex representation of the lower
 * inode file handle.
 *
 * If the index dentry in negative, then either no lower aliases have been
 * copied up yet, or aliases have been copied up in older kernels and are
 * not indexed.
 *
 * If the index dentry for a copy up origin inode is positive, but points
 * to an inode different than the upper inode, then either the upper inode
 * has been copied up and not indexed or it was indexed, but since then
 * index dir was cleared. Either way, that index cannot be used to indentify
 * the overlay inode.
 */
int ovl_get_index_name(struct dentry *origin, struct qstr *name)
{
	struct ovl_fh *fh;
644
	int err;
645

646
	fh = ovl_encode_real_fh(origin, false);
647 648 649
	if (IS_ERR(fh))
		return PTR_ERR(fh);

650
	err = ovl_get_index_name_fh(fh, name);
651

652
	kfree(fh);
653
	return err;
654 655 656 657 658 659 660 661 662 663 664 665 666 667 668 669 670 671 672 673 674 675 676 677 678 679 680 681 682
}

/* Lookup index by file handle for NFS export */
struct dentry *ovl_get_index_fh(struct ovl_fs *ofs, struct ovl_fh *fh)
{
	struct dentry *index;
	struct qstr name;
	int err;

	err = ovl_get_index_name_fh(fh, &name);
	if (err)
		return ERR_PTR(err);

	index = lookup_one_len_unlocked(name.name, ofs->indexdir, name.len);
	kfree(name.name);
	if (IS_ERR(index)) {
		if (PTR_ERR(index) == -ENOENT)
			index = NULL;
		return index;
	}

	if (d_is_negative(index))
		err = 0;
	else if (ovl_is_whiteout(index))
		err = -ESTALE;
	else if (ovl_dentry_weird(index))
		err = -EIO;
	else
		return index;
683

684 685
	dput(index);
	return ERR_PTR(err);
686 687
}

688 689
struct dentry *ovl_lookup_index(struct ovl_fs *ofs, struct dentry *upper,
				struct dentry *origin, bool verify)
690 691 692 693
{
	struct dentry *index;
	struct inode *inode;
	struct qstr name;
694
	bool is_dir = d_is_dir(origin);
695 696 697 698 699 700 701 702
	int err;

	err = ovl_get_index_name(origin, &name);
	if (err)
		return ERR_PTR(err);

	index = lookup_one_len_unlocked(name.name, ofs->indexdir, name.len);
	if (IS_ERR(index)) {
703
		err = PTR_ERR(index);
704 705 706 707
		if (err == -ENOENT) {
			index = NULL;
			goto out;
		}
708 709 710 711 712 713 714
		pr_warn_ratelimited("overlayfs: failed inode index lookup (ino=%lu, key=%*s, err=%i);\n"
				    "overlayfs: mount with '-o index=off' to disable inodes index.\n",
				    d_inode(origin)->i_ino, name.len, name.name,
				    err);
		goto out;
	}

715
	inode = d_inode(index);
716
	if (d_is_negative(index)) {
717
		goto out_dput;
718 719 720 721 722 723 724 725 726 727
	} else if (ovl_is_whiteout(index) && !verify) {
		/*
		 * When index lookup is called with !verify for decoding an
		 * overlay file handle, a whiteout index implies that decode
		 * should treat file handle as stale and no need to print a
		 * warning about it.
		 */
		dput(index);
		index = ERR_PTR(-ESTALE);
		goto out;
728 729 730 731 732 733 734 735 736 737 738 739
	} else if (ovl_dentry_weird(index) || ovl_is_whiteout(index) ||
		   ((inode->i_mode ^ d_inode(origin)->i_mode) & S_IFMT)) {
		/*
		 * Index should always be of the same file type as origin
		 * except for the case of a whiteout index. A whiteout
		 * index should only exist if all lower aliases have been
		 * unlinked, which means that finding a lower origin on lookup
		 * whose index is a whiteout should be treated as an error.
		 */
		pr_warn_ratelimited("overlayfs: bad index found (index=%pd2, ftype=%x, origin ftype=%x).\n",
				    index, d_inode(index)->i_mode & S_IFMT,
				    d_inode(origin)->i_mode & S_IFMT);
740
		goto fail;
741
	} else if (is_dir && verify) {
742 743 744 745 746
		if (!upper) {
			pr_warn_ratelimited("overlayfs: suspected uncovered redirected dir found (origin=%pd2, index=%pd2).\n",
					    origin, index);
			goto fail;
		}
747

748 749 750 751 752 753 754 755 756 757 758 759
		/* Verify that dir index 'upper' xattr points to upper dir */
		err = ovl_verify_upper(index, upper, false);
		if (err) {
			if (err == -ESTALE) {
				pr_warn_ratelimited("overlayfs: suspected multiply redirected dir found (upper=%pd2, origin=%pd2, index=%pd2).\n",
						    upper, origin, index);
			}
			goto fail;
		}
	} else if (upper && d_inode(upper) != inode) {
		goto out_dput;
	}
760 761 762 763
out:
	kfree(name.name);
	return index;

764 765 766 767 768
out_dput:
	dput(index);
	index = NULL;
	goto out;

769 770 771 772 773 774
fail:
	dput(index);
	index = ERR_PTR(-EIO);
	goto out;
}

M
Miklos Szeredi 已提交
775 776 777 778 779 780 781 782 783 784 785 786 787 788 789 790
/*
 * Returns next layer in stack starting from top.
 * Returns -1 if this is the last layer.
 */
int ovl_path_next(int idx, struct dentry *dentry, struct path *path)
{
	struct ovl_entry *oe = dentry->d_fsdata;

	BUG_ON(idx < 0);
	if (idx == 0) {
		ovl_path_upper(dentry, path);
		if (path->dentry)
			return oe->numlower ? 1 : -1;
		idx++;
	}
	BUG_ON(idx > oe->numlower);
791 792
	path->dentry = oe->lowerstack[idx - 1].dentry;
	path->mnt = oe->lowerstack[idx - 1].layer->mnt;
M
Miklos Szeredi 已提交
793 794 795 796

	return (idx < oe->numlower) ? idx + 1 : -1;
}

797 798 799 800 801 802 803 804 805 806 807 808 809 810 811 812 813 814 815 816 817
/* Fix missing 'origin' xattr */
static int ovl_fix_origin(struct dentry *dentry, struct dentry *lower,
			  struct dentry *upper)
{
	int err;

	if (ovl_check_origin_xattr(upper))
		return 0;

	err = ovl_want_write(dentry);
	if (err)
		return err;

	err = ovl_set_origin(dentry, lower, upper);
	if (!err)
		err = ovl_set_impure(dentry->d_parent, upper->d_parent);

	ovl_drop_write(dentry);
	return err;
}

M
Miklos Szeredi 已提交
818 819 820 821 822
struct dentry *ovl_lookup(struct inode *dir, struct dentry *dentry,
			  unsigned int flags)
{
	struct ovl_entry *oe;
	const struct cred *old_cred;
M
Miklos Szeredi 已提交
823
	struct ovl_fs *ofs = dentry->d_sb->s_fs_info;
M
Miklos Szeredi 已提交
824
	struct ovl_entry *poe = dentry->d_parent->d_fsdata;
825
	struct ovl_entry *roe = dentry->d_sb->s_root->d_fsdata;
826
	struct ovl_path *stack = NULL;
M
Miklos Szeredi 已提交
827
	struct dentry *upperdir, *upperdentry = NULL;
828
	struct dentry *origin = NULL;
829
	struct dentry *index = NULL;
M
Miklos Szeredi 已提交
830 831 832
	unsigned int ctr = 0;
	struct inode *inode = NULL;
	bool upperopaque = false;
M
Miklos Szeredi 已提交
833
	char *upperredirect = NULL;
M
Miklos Szeredi 已提交
834 835 836
	struct dentry *this;
	unsigned int i;
	int err;
837 838 839 840 841
	struct ovl_lookup_data d = {
		.name = dentry->d_name,
		.is_dir = false,
		.opaque = false,
		.stop = false,
842
		.last = ofs->config.redirect_follow ? false : !poe->numlower,
M
Miklos Szeredi 已提交
843
		.redirect = NULL,
844
	};
M
Miklos Szeredi 已提交
845

M
Miklos Szeredi 已提交
846 847 848
	if (dentry->d_name.len > ofs->namelen)
		return ERR_PTR(-ENAMETOOLONG);

M
Miklos Szeredi 已提交
849
	old_cred = ovl_override_creds(dentry->d_sb);
850
	upperdir = ovl_dentry_upper(dentry->d_parent);
M
Miklos Szeredi 已提交
851
	if (upperdir) {
852 853
		err = ovl_lookup_layer(upperdir, &d, &upperdentry);
		if (err)
M
Miklos Szeredi 已提交
854 855
			goto out;

856 857 858 859
		if (upperdentry && unlikely(ovl_dentry_remote(upperdentry))) {
			dput(upperdentry);
			err = -EREMOTE;
			goto out;
M
Miklos Szeredi 已提交
860
		}
861 862
		if (upperdentry && !d.is_dir) {
			BUG_ON(!d.stop || d.redirect);
863 864 865 866 867 868 869 870 871 872
			/*
			 * Lookup copy up origin by decoding origin file handle.
			 * We may get a disconnected dentry, which is fine,
			 * because we only need to hold the origin inode in
			 * cache and use its inode number.  We may even get a
			 * connected dentry, that is not under any of the lower
			 * layers root.  That is also fine for using it's inode
			 * number - it's the same as if we held a reference
			 * to a dentry in lower layer that was moved under us.
			 */
873
			err = ovl_check_origin(ofs, upperdentry, &stack, &ctr);
874
			if (err)
875
				goto out_put_upper;
876
		}
M
Miklos Szeredi 已提交
877 878

		if (d.redirect) {
879
			err = -ENOMEM;
M
Miklos Szeredi 已提交
880 881 882 883
			upperredirect = kstrdup(d.redirect, GFP_KERNEL);
			if (!upperredirect)
				goto out_put_upper;
			if (d.redirect[0] == '/')
884
				poe = roe;
M
Miklos Szeredi 已提交
885
		}
886
		upperopaque = d.opaque;
M
Miklos Szeredi 已提交
887 888
	}

889
	if (!d.stop && poe->numlower) {
M
Miklos Szeredi 已提交
890
		err = -ENOMEM;
891
		stack = kcalloc(ofs->numlower, sizeof(struct ovl_path),
892
				GFP_KERNEL);
M
Miklos Szeredi 已提交
893 894 895 896
		if (!stack)
			goto out_put_upper;
	}

897
	for (i = 0; !d.stop && i < poe->numlower; i++) {
898
		struct ovl_path lower = poe->lowerstack[i];
M
Miklos Szeredi 已提交
899

900 901 902 903 904
		if (!ofs->config.redirect_follow)
			d.last = i == poe->numlower - 1;
		else
			d.last = lower.layer->idx == roe->numlower;

905
		err = ovl_lookup_layer(lower.dentry, &d, &this);
906
		if (err)
M
Miklos Szeredi 已提交
907
			goto out_put;
M
Miklos Szeredi 已提交
908

M
Miklos Szeredi 已提交
909 910 911
		if (!this)
			continue;

912 913 914 915 916 917 918 919 920 921 922 923
		/*
		 * If no origin fh is stored in upper of a merge dir, store fh
		 * of lower dir and set upper parent "impure".
		 */
		if (upperdentry && !ctr && !ofs->noxattr) {
			err = ovl_fix_origin(dentry, this, upperdentry);
			if (err) {
				dput(this);
				goto out_put;
			}
		}

924 925
		/*
		 * When "verify_lower" feature is enabled, do not merge with a
926 927
		 * lower dir that does not match a stored origin xattr. In any
		 * case, only verified origin is used for index lookup.
928 929 930 931 932 933 934
		 */
		if (upperdentry && !ctr && ovl_verify_lower(dentry->d_sb)) {
			err = ovl_verify_origin(upperdentry, this, false);
			if (err) {
				dput(this);
				break;
			}
935 936 937

			/* Bless lower dir as verified origin */
			origin = this;
938 939
		}

M
Miklos Szeredi 已提交
940
		stack[ctr].dentry = this;
941
		stack[ctr].layer = lower.layer;
M
Miklos Szeredi 已提交
942
		ctr++;
M
Miklos Szeredi 已提交
943

944 945 946 947 948 949 950 951 952 953 954 955
		/*
		 * Following redirects can have security consequences: it's like
		 * a symlink into the lower layer without the permission checks.
		 * This is only a problem if the upper layer is untrusted (e.g
		 * comes from an USB drive).  This can allow a non-readable file
		 * or directory to become readable.
		 *
		 * Only following redirects when redirects are enabled disables
		 * this attack vector when not necessary.
		 */
		err = -EPERM;
		if (d.redirect && !ofs->config.redirect_follow) {
956 957
			pr_warn_ratelimited("overlayfs: refusing to follow redirect for (%pd2)\n",
					    dentry);
958 959 960
			goto out_put;
		}

961 962 963
		if (d.stop)
			break;

964 965
		if (d.redirect && d.redirect[0] == '/' && poe != roe) {
			poe = roe;
M
Miklos Szeredi 已提交
966
			/* Find the current layer on the root dentry */
967
			i = lower.layer->idx - 1;
M
Miklos Szeredi 已提交
968
		}
M
Miklos Szeredi 已提交
969 970
	}

971 972 973 974 975 976 977 978
	/*
	 * Lookup index by lower inode and verify it matches upper inode.
	 * We only trust dir index if we verified that lower dir matches
	 * origin, otherwise dir index entries may be inconsistent and we
	 * ignore them. Always lookup index of non-dir and non-upper.
	 */
	if (ctr && (!upperdentry || !d.is_dir))
		origin = stack[0].dentry;
979

980 981
	if (origin && ovl_indexdir(dentry->d_sb) &&
	    (!d.is_dir || ovl_index_all(dentry->d_sb))) {
982
		index = ovl_lookup_index(ofs, upperdentry, origin, true);
983 984 985 986 987 988 989
		if (IS_ERR(index)) {
			err = PTR_ERR(index);
			index = NULL;
			goto out_put;
		}
	}

M
Miklos Szeredi 已提交
990 991 992 993 994
	oe = ovl_alloc_entry(ctr);
	err = -ENOMEM;
	if (!oe)
		goto out_put;

995
	memcpy(oe->lowerstack, stack, sizeof(struct ovl_path) * ctr);
M
Miklos Szeredi 已提交
996
	dentry->d_fsdata = oe;
M
Miklos Szeredi 已提交
997

998 999 1000
	if (upperopaque)
		ovl_dentry_set_opaque(dentry);

1001 1002 1003
	if (upperdentry)
		ovl_dentry_set_upper_alias(dentry);
	else if (index)
1004 1005
		upperdentry = dget(index);

M
Miklos Szeredi 已提交
1006
	if (upperdentry || ctr) {
1007 1008 1009 1010 1011 1012 1013 1014
		struct ovl_inode_params oip = {
			.upperdentry = upperdentry,
			.lowerpath = stack,
			.index = index,
			.numlower = ctr,
		};

		inode = ovl_get_inode(dentry->d_sb, &oip);
1015 1016
		err = PTR_ERR(inode);
		if (IS_ERR(inode))
M
Miklos Szeredi 已提交
1017
			goto out_free_oe;
M
Miklos Szeredi 已提交
1018

1019 1020 1021 1022 1023
		/*
		 * NB: handle redirected hard links when non-dir redirects
		 * become possible
		 */
		WARN_ON(OVL_I(inode)->redirect);
M
Miklos Szeredi 已提交
1024
		OVL_I(inode)->redirect = upperredirect;
M
Miklos Szeredi 已提交
1025 1026 1027
	}

	revert_creds(old_cred);
1028
	dput(index);
M
Miklos Szeredi 已提交
1029
	kfree(stack);
M
Miklos Szeredi 已提交
1030
	kfree(d.redirect);
1031
	return d_splice_alias(inode, dentry);
M
Miklos Szeredi 已提交
1032 1033

out_free_oe:
M
Miklos Szeredi 已提交
1034
	dentry->d_fsdata = NULL;
M
Miklos Szeredi 已提交
1035 1036
	kfree(oe);
out_put:
1037
	dput(index);
M
Miklos Szeredi 已提交
1038 1039 1040 1041 1042
	for (i = 0; i < ctr; i++)
		dput(stack[i].dentry);
	kfree(stack);
out_put_upper:
	dput(upperdentry);
M
Miklos Szeredi 已提交
1043
	kfree(upperredirect);
M
Miklos Szeredi 已提交
1044
out:
M
Miklos Szeredi 已提交
1045
	kfree(d.redirect);
M
Miklos Szeredi 已提交
1046 1047 1048 1049 1050 1051 1052 1053
	revert_creds(old_cred);
	return ERR_PTR(err);
}

bool ovl_lower_positive(struct dentry *dentry)
{
	struct ovl_entry *poe = dentry->d_parent->d_fsdata;
	const struct qstr *name = &dentry->d_name;
1054
	const struct cred *old_cred;
M
Miklos Szeredi 已提交
1055 1056 1057 1058 1059 1060 1061 1062 1063
	unsigned int i;
	bool positive = false;
	bool done = false;

	/*
	 * If dentry is negative, then lower is positive iff this is a
	 * whiteout.
	 */
	if (!dentry->d_inode)
1064
		return ovl_dentry_is_opaque(dentry);
M
Miklos Szeredi 已提交
1065 1066

	/* Negative upper -> positive lower */
1067
	if (!ovl_dentry_upper(dentry))
M
Miklos Szeredi 已提交
1068 1069
		return true;

1070
	old_cred = ovl_override_creds(dentry->d_sb);
M
Miklos Szeredi 已提交
1071 1072 1073 1074 1075 1076 1077 1078 1079 1080 1081 1082 1083 1084 1085 1086 1087 1088 1089 1090 1091 1092 1093 1094 1095 1096 1097 1098 1099
	/* Positive upper -> have to look up lower to see whether it exists */
	for (i = 0; !done && !positive && i < poe->numlower; i++) {
		struct dentry *this;
		struct dentry *lowerdir = poe->lowerstack[i].dentry;

		this = lookup_one_len_unlocked(name->name, lowerdir,
					       name->len);
		if (IS_ERR(this)) {
			switch (PTR_ERR(this)) {
			case -ENOENT:
			case -ENAMETOOLONG:
				break;

			default:
				/*
				 * Assume something is there, we just couldn't
				 * access it.
				 */
				positive = true;
				break;
			}
		} else {
			if (this->d_inode) {
				positive = !ovl_is_whiteout(this);
				done = true;
			}
			dput(this);
		}
	}
1100
	revert_creds(old_cred);
M
Miklos Szeredi 已提交
1101 1102 1103

	return positive;
}