namei.c 25.3 KB
Newer Older
M
Miklos Szeredi 已提交
1 2 3 4 5 6 7 8 9 10
/*
 * Copyright (C) 2011 Novell Inc.
 * Copyright (C) 2016 Red Hat, Inc.
 *
 * This program is free software; you can redistribute it and/or modify it
 * under the terms of the GNU General Public License version 2 as published by
 * the Free Software Foundation.
 */

#include <linux/fs.h>
11
#include <linux/cred.h>
A
Amir Goldstein 已提交
12
#include <linux/ctype.h>
M
Miklos Szeredi 已提交
13 14
#include <linux/namei.h>
#include <linux/xattr.h>
M
Miklos Szeredi 已提交
15
#include <linux/ratelimit.h>
16 17
#include <linux/mount.h>
#include <linux/exportfs.h>
M
Miklos Szeredi 已提交
18 19
#include "overlayfs.h"

20 21 22 23 24 25
struct ovl_lookup_data {
	struct qstr name;
	bool is_dir;
	bool opaque;
	bool stop;
	bool last;
M
Miklos Szeredi 已提交
26
	char *redirect;
27
};
M
Miklos Szeredi 已提交
28

M
Miklos Szeredi 已提交
29 30 31 32 33 34 35 36 37 38 39 40
static int ovl_check_redirect(struct dentry *dentry, struct ovl_lookup_data *d,
			      size_t prelen, const char *post)
{
	int res;
	char *s, *next, *buf = NULL;

	res = vfs_getxattr(dentry, OVL_XATTR_REDIRECT, NULL, 0);
	if (res < 0) {
		if (res == -ENODATA || res == -EOPNOTSUPP)
			return 0;
		goto fail;
	}
41
	buf = kzalloc(prelen + res + strlen(post) + 1, GFP_KERNEL);
M
Miklos Szeredi 已提交
42 43 44 45 46 47 48 49 50 51 52 53 54 55 56 57 58
	if (!buf)
		return -ENOMEM;

	if (res == 0)
		goto invalid;

	res = vfs_getxattr(dentry, OVL_XATTR_REDIRECT, buf, res);
	if (res < 0)
		goto fail;
	if (res == 0)
		goto invalid;
	if (buf[0] == '/') {
		for (s = buf; *s++ == '/'; s = next) {
			next = strchrnul(s, '/');
			if (s == next)
				goto invalid;
		}
59 60 61 62 63 64 65 66 67
		/*
		 * One of the ancestor path elements in an absolute path
		 * lookup in ovl_lookup_layer() could have been opaque and
		 * that will stop further lookup in lower layers (d->stop=true)
		 * But we have found an absolute redirect in decendant path
		 * element and that should force continue lookup in lower
		 * layers (reset d->stop).
		 */
		d->stop = false;
M
Miklos Szeredi 已提交
68 69 70 71 72 73 74 75 76 77 78 79 80 81 82 83 84 85 86 87 88 89 90 91 92 93 94
	} else {
		if (strchr(buf, '/') != NULL)
			goto invalid;

		memmove(buf + prelen, buf, res);
		memcpy(buf, d->name.name, prelen);
	}

	strcat(buf, post);
	kfree(d->redirect);
	d->redirect = buf;
	d->name.name = d->redirect;
	d->name.len = strlen(d->redirect);

	return 0;

err_free:
	kfree(buf);
	return 0;
fail:
	pr_warn_ratelimited("overlayfs: failed to get redirect (%i)\n", res);
	goto err_free;
invalid:
	pr_warn_ratelimited("overlayfs: invalid redirect (%s)\n", buf);
	goto err_free;
}

95 96
static int ovl_acceptable(void *ctx, struct dentry *dentry)
{
97 98 99 100 101 102 103 104 105 106 107 108 109
	/*
	 * A non-dir origin may be disconnected, which is fine, because
	 * we only need it for its unique inode number.
	 */
	if (!d_is_dir(dentry))
		return 1;

	/* Don't decode a deleted empty directory */
	if (d_unhashed(dentry))
		return 0;

	/* Check if directory belongs to the layer we are decoding from */
	return is_subdir(dentry, ((struct vfsmount *)ctx)->mnt_root);
110 111
}

112 113 114 115 116 117 118
/*
 * Check validity of an overlay file handle buffer.
 *
 * Return 0 for a valid file handle.
 * Return -ENODATA for "origin unknown".
 * Return <0 for an invalid file handle.
 */
119
int ovl_check_fh_len(struct ovl_fh *fh, int fh_len)
120 121 122 123 124 125 126 127 128 129 130 131 132 133 134 135 136 137 138
{
	if (fh_len < sizeof(struct ovl_fh) || fh_len < fh->len)
		return -EINVAL;

	if (fh->magic != OVL_FH_MAGIC)
		return -EINVAL;

	/* Treat larger version and unknown flags as "origin unknown" */
	if (fh->version > OVL_FH_VERSION || fh->flags & ~OVL_FH_FLAG_ALL)
		return -ENODATA;

	/* Treat endianness mismatch as "origin unknown" */
	if (!(fh->flags & OVL_FH_FLAG_ANY_ENDIAN) &&
	    (fh->flags & OVL_FH_FLAG_BIG_ENDIAN) != OVL_FH_FLAG_CPU_ENDIAN)
		return -ENODATA;

	return 0;
}

139
static struct ovl_fh *ovl_get_fh(struct dentry *dentry, const char *name)
140
{
141
	int res, err;
142 143
	struct ovl_fh *fh = NULL;

144
	res = vfs_getxattr(dentry, name, NULL, 0);
145 146 147 148 149 150 151 152 153
	if (res < 0) {
		if (res == -ENODATA || res == -EOPNOTSUPP)
			return NULL;
		goto fail;
	}
	/* Zero size value means "copied up but origin unknown" */
	if (res == 0)
		return NULL;

154
	fh = kzalloc(res, GFP_KERNEL);
155 156 157
	if (!fh)
		return ERR_PTR(-ENOMEM);

158
	res = vfs_getxattr(dentry, name, fh, res);
159 160 161
	if (res < 0)
		goto fail;

162 163 164 165
	err = ovl_check_fh_len(fh, res);
	if (err < 0) {
		if (err == -ENODATA)
			goto out;
166
		goto invalid;
167
	}
168

169 170 171 172 173 174 175 176 177 178 179 180 181 182
	return fh;

out:
	kfree(fh);
	return NULL;

fail:
	pr_warn_ratelimited("overlayfs: failed to get origin (%i)\n", res);
	goto out;
invalid:
	pr_warn_ratelimited("overlayfs: invalid origin (%*phN)\n", res, fh);
	goto out;
}

183 184
struct dentry *ovl_decode_real_fh(struct ovl_fh *fh, struct vfsmount *mnt,
				  bool connected)
185
{
186
	struct dentry *real;
187 188
	int bytes;

189 190 191 192
	/*
	 * Make sure that the stored uuid matches the uuid of the lower
	 * layer where file handle will be decoded.
	 */
193
	if (!uuid_equal(&fh->uuid, &mnt->mnt_sb->s_uuid))
194
		return NULL;
195

196
	bytes = (fh->len - offsetof(struct ovl_fh, fid));
197 198
	real = exportfs_decode_fh(mnt, (struct fid *)fh->fid,
				  bytes >> 2, (int)fh->type,
199
				  connected ? ovl_acceptable : NULL, mnt);
200 201 202 203 204 205 206 207 208 209 210
	if (IS_ERR(real)) {
		/*
		 * Treat stale file handle to lower file as "origin unknown".
		 * upper file handle could become stale when upper file is
		 * unlinked and this information is needed to handle stale
		 * index entries correctly.
		 */
		if (real == ERR_PTR(-ESTALE) &&
		    !(fh->flags & OVL_FH_FLAG_PATH_UPPER))
			real = NULL;
		return real;
211 212
	}

213 214
	if (ovl_dentry_weird(real)) {
		dput(real);
215 216
		return NULL;
	}
217

218
	return real;
219 220
}

221 222 223 224 225
static bool ovl_is_opaquedir(struct dentry *dentry)
{
	return ovl_check_dir_xattr(dentry, OVL_XATTR_OPAQUE);
}

226 227
static int ovl_lookup_single(struct dentry *base, struct ovl_lookup_data *d,
			     const char *name, unsigned int namelen,
M
Miklos Szeredi 已提交
228
			     size_t prelen, const char *post,
229 230 231 232 233 234 235 236 237 238 239 240 241 242 243 244 245 246 247 248 249 250 251 252 253 254 255 256 257 258 259 260 261 262 263 264
			     struct dentry **ret)
{
	struct dentry *this;
	int err;

	this = lookup_one_len_unlocked(name, base, namelen);
	if (IS_ERR(this)) {
		err = PTR_ERR(this);
		this = NULL;
		if (err == -ENOENT || err == -ENAMETOOLONG)
			goto out;
		goto out_err;
	}
	if (!this->d_inode)
		goto put_and_out;

	if (ovl_dentry_weird(this)) {
		/* Don't support traversing automounts and other weirdness */
		err = -EREMOTE;
		goto out_err;
	}
	if (ovl_is_whiteout(this)) {
		d->stop = d->opaque = true;
		goto put_and_out;
	}
	if (!d_can_lookup(this)) {
		d->stop = true;
		if (d->is_dir)
			goto put_and_out;
		goto out;
	}
	d->is_dir = true;
	if (!d->last && ovl_is_opaquedir(this)) {
		d->stop = d->opaque = true;
		goto out;
	}
M
Miklos Szeredi 已提交
265 266 267
	err = ovl_check_redirect(this, d, prelen, post);
	if (err)
		goto out_err;
268 269 270 271 272 273 274 275 276 277 278 279 280 281 282 283 284
out:
	*ret = this;
	return 0;

put_and_out:
	dput(this);
	this = NULL;
	goto out;

out_err:
	dput(this);
	return err;
}

static int ovl_lookup_layer(struct dentry *base, struct ovl_lookup_data *d,
			    struct dentry **ret)
{
285 286
	/* Counting down from the end, since the prefix can change */
	size_t rem = d->name.len - 1;
M
Miklos Szeredi 已提交
287 288 289
	struct dentry *dentry = NULL;
	int err;

290
	if (d->name.name[0] != '/')
M
Miklos Szeredi 已提交
291 292 293
		return ovl_lookup_single(base, d, d->name.name, d->name.len,
					 0, "", ret);

294 295
	while (!IS_ERR_OR_NULL(base) && d_can_lookup(base)) {
		const char *s = d->name.name + d->name.len - rem;
M
Miklos Szeredi 已提交
296
		const char *next = strchrnul(s, '/');
297 298
		size_t thislen = next - s;
		bool end = !next[0];
M
Miklos Szeredi 已提交
299

300 301
		/* Verify we did not go off the rails */
		if (WARN_ON(s[-1] != '/'))
M
Miklos Szeredi 已提交
302 303
			return -EIO;

304 305
		err = ovl_lookup_single(base, d, s, thislen,
					d->name.len - rem, next, &base);
M
Miklos Szeredi 已提交
306 307 308 309
		dput(dentry);
		if (err)
			return err;
		dentry = base;
310 311 312 313 314 315 316
		if (end)
			break;

		rem -= thislen + 1;

		if (WARN_ON(rem >= d->name.len))
			return -EIO;
M
Miklos Szeredi 已提交
317 318 319
	}
	*ret = dentry;
	return 0;
320 321
}

322

323
int ovl_check_origin_fh(struct ovl_fs *ofs, struct ovl_fh *fh, bool connected,
324
			struct dentry *upperdentry, struct ovl_path **stackp)
325
{
326 327
	struct dentry *origin = NULL;
	int i;
328

329
	for (i = 0; i < ofs->numlower; i++) {
330 331
		origin = ovl_decode_real_fh(fh, ofs->lower_layers[i].mnt,
					    connected);
332 333 334 335 336
		if (origin)
			break;
	}

	if (!origin)
337 338 339 340
		return -ESTALE;
	else if (IS_ERR(origin))
		return PTR_ERR(origin);

341
	if (upperdentry && !ovl_is_whiteout(upperdentry) &&
342 343
	    ((d_inode(origin)->i_mode ^ d_inode(upperdentry)->i_mode) & S_IFMT))
		goto invalid;
344

345
	if (!*stackp)
346
		*stackp = kmalloc(sizeof(struct ovl_path), GFP_KERNEL);
347 348 349 350
	if (!*stackp) {
		dput(origin);
		return -ENOMEM;
	}
351 352 353 354
	**stackp = (struct ovl_path){
		.dentry = origin,
		.layer = &ofs->lower_layers[i]
	};
355 356

	return 0;
357 358 359 360 361 362 363 364 365

invalid:
	pr_warn_ratelimited("overlayfs: invalid origin (%pd2, ftype=%x, origin ftype=%x).\n",
			    upperdentry, d_inode(upperdentry)->i_mode & S_IFMT,
			    d_inode(origin)->i_mode & S_IFMT);
	dput(origin);
	return -EIO;
}

366
static int ovl_check_origin(struct ovl_fs *ofs, struct dentry *upperdentry,
367 368
			    struct ovl_path **stackp, unsigned int *ctrp)
{
369
	struct ovl_fh *fh = ovl_get_fh(upperdentry, OVL_XATTR_ORIGIN);
370 371 372 373 374
	int err;

	if (IS_ERR_OR_NULL(fh))
		return PTR_ERR(fh);

375
	err = ovl_check_origin_fh(ofs, fh, false, upperdentry, stackp);
376 377 378 379 380 381 382 383 384 385 386 387 388
	kfree(fh);

	if (err) {
		if (err == -ESTALE)
			return 0;
		return err;
	}

	if (WARN_ON(*ctrp))
		return -EIO;

	*ctrp = 1;
	return 0;
389 390
}

391
/*
392
 * Verify that @fh matches the file handle stored in xattr @name.
393 394
 * Return 0 on match, -ESTALE on mismatch, < 0 on error.
 */
395 396
static int ovl_verify_fh(struct dentry *dentry, const char *name,
			 const struct ovl_fh *fh)
397
{
398
	struct ovl_fh *ofh = ovl_get_fh(dentry, name);
399 400 401 402 403 404 405 406 407 408 409 410 411 412 413 414
	int err = 0;

	if (!ofh)
		return -ENODATA;

	if (IS_ERR(ofh))
		return PTR_ERR(ofh);

	if (fh->len != ofh->len || memcmp(fh, ofh, fh->len))
		err = -ESTALE;

	kfree(ofh);
	return err;
}

/*
415
 * Verify that @real dentry matches the file handle stored in xattr @name.
416
 *
417 418
 * If @set is true and there is no stored file handle, encode @real and store
 * file handle in xattr @name.
419
 *
420
 * Return 0 on match, -ESTALE on mismatch, -ENODATA on no xattr, < 0 on error.
421
 */
422 423
int ovl_verify_set_fh(struct dentry *dentry, const char *name,
		      struct dentry *real, bool is_upper, bool set)
424 425 426 427 428
{
	struct inode *inode;
	struct ovl_fh *fh;
	int err;

429
	fh = ovl_encode_real_fh(real, is_upper);
430 431 432 433
	err = PTR_ERR(fh);
	if (IS_ERR(fh))
		goto fail;

434
	err = ovl_verify_fh(dentry, name, fh);
435
	if (set && err == -ENODATA)
436
		err = ovl_do_setxattr(dentry, name, fh, fh->len, 0);
437 438 439 440 441 442 443 444
	if (err)
		goto fail;

out:
	kfree(fh);
	return err;

fail:
445 446 447 448
	inode = d_inode(real);
	pr_warn_ratelimited("overlayfs: failed to verify %s (%pd2, ino=%lu, err=%i)\n",
			    is_upper ? "upper" : "origin", real,
			    inode ? inode->i_ino : 0, err);
449 450 451
	goto out;
}

452
/* Get upper dentry from index */
453
struct dentry *ovl_index_upper(struct ovl_fs *ofs, struct dentry *index)
454 455 456 457 458 459 460 461 462 463 464
{
	struct ovl_fh *fh;
	struct dentry *upper;

	if (!d_is_dir(index))
		return dget(index);

	fh = ovl_get_fh(index, OVL_XATTR_UPPER);
	if (IS_ERR_OR_NULL(fh))
		return ERR_CAST(fh);

465
	upper = ovl_decode_real_fh(fh, ofs->upper_mnt, true);
466 467 468 469 470 471 472 473 474 475 476 477 478 479 480
	kfree(fh);

	if (IS_ERR_OR_NULL(upper))
		return upper ?: ERR_PTR(-ESTALE);

	if (!d_is_dir(upper)) {
		pr_warn_ratelimited("overlayfs: invalid index upper (%pd2, upper=%pd2).\n",
				    index, upper);
		dput(upper);
		return ERR_PTR(-EIO);
	}

	return upper;
}

A
Amir Goldstein 已提交
481 482 483 484 485 486
/* Is this a leftover from create/whiteout of directory index entry? */
static bool ovl_is_temp_index(struct dentry *index)
{
	return index->d_name.name[0] == '#';
}

487 488 489 490 491
/*
 * Verify that an index entry name matches the origin file handle stored in
 * OVL_XATTR_ORIGIN and that origin file handle can be decoded to lower path.
 * Return 0 on match, -ESTALE on mismatch or stale origin, < 0 on error.
 */
492
int ovl_verify_index(struct ovl_fs *ofs, struct dentry *index)
493 494 495
{
	struct ovl_fh *fh = NULL;
	size_t len;
496 497
	struct ovl_path origin = { };
	struct ovl_path *stack = &origin;
498
	struct dentry *upper = NULL;
499 500 501 502 503
	int err;

	if (!d_inode(index))
		return 0;

A
Amir Goldstein 已提交
504 505 506 507 508
	/* Cleanup leftover from index create/cleanup attempt */
	err = -ESTALE;
	if (ovl_is_temp_index(index))
		goto fail;

509
	err = -EINVAL;
510 511 512 513 514
	if (index->d_name.len < sizeof(struct ovl_fh)*2)
		goto fail;

	err = -ENOMEM;
	len = index->d_name.len / 2;
515
	fh = kzalloc(len, GFP_KERNEL);
516 517 518 519
	if (!fh)
		goto fail;

	err = -EINVAL;
520 521 522 523 524
	if (hex2bin((u8 *)fh, index->d_name.name, len))
		goto fail;

	err = ovl_check_fh_len(fh, len);
	if (err)
525 526
		goto fail;

527 528 529 530 531 532 533 534
	/*
	 * Whiteout index entries are used as an indication that an exported
	 * overlay file handle should be treated as stale (i.e. after unlink
	 * of the overlay inode). These entries contain no origin xattr.
	 */
	if (ovl_is_whiteout(index))
		goto out;

535 536 537 538 539 540 541 542 543 544 545 546 547 548 549 550 551
	/*
	 * Verifying directory index entries are not stale is expensive, so
	 * only verify stale dir index if NFS export is enabled.
	 */
	if (d_is_dir(index) && !ofs->config.nfs_export)
		goto out;

	/*
	 * Directory index entries should have 'upper' xattr pointing to the
	 * real upper dir. Non-dir index entries are hardlinks to the upper
	 * real inode. For non-dir index, we can read the copy up origin xattr
	 * directly from the index dentry, but for dir index we first need to
	 * decode the upper directory.
	 */
	upper = ovl_index_upper(ofs, index);
	if (IS_ERR_OR_NULL(upper)) {
		err = PTR_ERR(upper);
552 553 554 555 556 557 558 559 560
		/*
		 * Directory index entries with no 'upper' xattr need to be
		 * removed. When dir index entry has a stale 'upper' xattr,
		 * we assume that upper dir was removed and we treat the dir
		 * index as orphan entry that needs to be whited out.
		 */
		if (err == -ESTALE)
			goto orphan;
		else if (!err)
561
			err = -ESTALE;
562
		goto fail;
563
	}
564

565 566
	err = ovl_verify_fh(upper, OVL_XATTR_ORIGIN, fh);
	dput(upper);
567 568 569
	if (err)
		goto fail;

570 571
	/* Check if non-dir index is orphan and don't warn before cleaning it */
	if (!d_is_dir(index) && d_inode(index)->i_nlink == 1) {
572
		err = ovl_check_origin_fh(ofs, fh, false, index, &stack);
573 574 575 576
		if (err)
			goto fail;

		if (ovl_get_nlink(origin.dentry, index, 0) == 0)
577
			goto orphan;
578
	}
579

580
out:
581
	dput(origin.dentry);
582 583 584 585
	kfree(fh);
	return err;

fail:
586 587
	pr_warn_ratelimited("overlayfs: failed to verify index (%pd2, ftype=%x, err=%i)\n",
			    index, d_inode(index)->i_mode & S_IFMT, err);
588
	goto out;
589 590 591 592 593 594 595

orphan:
	pr_warn_ratelimited("overlayfs: orphan index entry (%pd2, ftype=%x, nlink=%u)\n",
			    index, d_inode(index)->i_mode & S_IFMT,
			    d_inode(index)->i_nlink);
	err = -ENOENT;
	goto out;
596 597
}

598 599 600 601 602 603 604 605 606 607 608 609 610 611 612
static int ovl_get_index_name_fh(struct ovl_fh *fh, struct qstr *name)
{
	char *n, *s;

	n = kzalloc(fh->len * 2, GFP_KERNEL);
	if (!n)
		return -ENOMEM;

	s  = bin2hex(n, fh, fh->len);
	*name = (struct qstr) QSTR_INIT(n, s - n);

	return 0;

}

613 614 615 616 617 618 619 620 621 622 623 624 625 626 627 628 629 630
/*
 * Lookup in indexdir for the index entry of a lower real inode or a copy up
 * origin inode. The index entry name is the hex representation of the lower
 * inode file handle.
 *
 * If the index dentry in negative, then either no lower aliases have been
 * copied up yet, or aliases have been copied up in older kernels and are
 * not indexed.
 *
 * If the index dentry for a copy up origin inode is positive, but points
 * to an inode different than the upper inode, then either the upper inode
 * has been copied up and not indexed or it was indexed, but since then
 * index dir was cleared. Either way, that index cannot be used to indentify
 * the overlay inode.
 */
int ovl_get_index_name(struct dentry *origin, struct qstr *name)
{
	struct ovl_fh *fh;
631
	int err;
632

633
	fh = ovl_encode_real_fh(origin, false);
634 635 636
	if (IS_ERR(fh))
		return PTR_ERR(fh);

637
	err = ovl_get_index_name_fh(fh, name);
638

639
	kfree(fh);
640
	return err;
641 642 643 644 645 646 647 648 649 650 651 652 653 654 655 656 657 658 659 660 661 662 663 664 665 666 667 668 669
}

/* Lookup index by file handle for NFS export */
struct dentry *ovl_get_index_fh(struct ovl_fs *ofs, struct ovl_fh *fh)
{
	struct dentry *index;
	struct qstr name;
	int err;

	err = ovl_get_index_name_fh(fh, &name);
	if (err)
		return ERR_PTR(err);

	index = lookup_one_len_unlocked(name.name, ofs->indexdir, name.len);
	kfree(name.name);
	if (IS_ERR(index)) {
		if (PTR_ERR(index) == -ENOENT)
			index = NULL;
		return index;
	}

	if (d_is_negative(index))
		err = 0;
	else if (ovl_is_whiteout(index))
		err = -ESTALE;
	else if (ovl_dentry_weird(index))
		err = -EIO;
	else
		return index;
670

671 672
	dput(index);
	return ERR_PTR(err);
673 674
}

675 676
struct dentry *ovl_lookup_index(struct ovl_fs *ofs, struct dentry *upper,
				struct dentry *origin, bool verify)
677 678 679 680
{
	struct dentry *index;
	struct inode *inode;
	struct qstr name;
681
	bool is_dir = d_is_dir(origin);
682 683 684 685 686 687 688 689
	int err;

	err = ovl_get_index_name(origin, &name);
	if (err)
		return ERR_PTR(err);

	index = lookup_one_len_unlocked(name.name, ofs->indexdir, name.len);
	if (IS_ERR(index)) {
690
		err = PTR_ERR(index);
691 692 693 694
		if (err == -ENOENT) {
			index = NULL;
			goto out;
		}
695 696 697 698 699 700 701
		pr_warn_ratelimited("overlayfs: failed inode index lookup (ino=%lu, key=%*s, err=%i);\n"
				    "overlayfs: mount with '-o index=off' to disable inodes index.\n",
				    d_inode(origin)->i_ino, name.len, name.name,
				    err);
		goto out;
	}

702
	inode = d_inode(index);
703
	if (d_is_negative(index)) {
704
		goto out_dput;
705 706 707 708 709 710 711 712 713 714
	} else if (ovl_is_whiteout(index) && !verify) {
		/*
		 * When index lookup is called with !verify for decoding an
		 * overlay file handle, a whiteout index implies that decode
		 * should treat file handle as stale and no need to print a
		 * warning about it.
		 */
		dput(index);
		index = ERR_PTR(-ESTALE);
		goto out;
715 716 717 718 719 720 721 722 723 724 725 726
	} else if (ovl_dentry_weird(index) || ovl_is_whiteout(index) ||
		   ((inode->i_mode ^ d_inode(origin)->i_mode) & S_IFMT)) {
		/*
		 * Index should always be of the same file type as origin
		 * except for the case of a whiteout index. A whiteout
		 * index should only exist if all lower aliases have been
		 * unlinked, which means that finding a lower origin on lookup
		 * whose index is a whiteout should be treated as an error.
		 */
		pr_warn_ratelimited("overlayfs: bad index found (index=%pd2, ftype=%x, origin ftype=%x).\n",
				    index, d_inode(index)->i_mode & S_IFMT,
				    d_inode(origin)->i_mode & S_IFMT);
727
		goto fail;
728
	} else if (is_dir && verify) {
729 730 731 732 733
		if (!upper) {
			pr_warn_ratelimited("overlayfs: suspected uncovered redirected dir found (origin=%pd2, index=%pd2).\n",
					    origin, index);
			goto fail;
		}
734

735 736 737 738 739 740 741 742 743 744 745 746
		/* Verify that dir index 'upper' xattr points to upper dir */
		err = ovl_verify_upper(index, upper, false);
		if (err) {
			if (err == -ESTALE) {
				pr_warn_ratelimited("overlayfs: suspected multiply redirected dir found (upper=%pd2, origin=%pd2, index=%pd2).\n",
						    upper, origin, index);
			}
			goto fail;
		}
	} else if (upper && d_inode(upper) != inode) {
		goto out_dput;
	}
747 748 749 750
out:
	kfree(name.name);
	return index;

751 752 753 754 755
out_dput:
	dput(index);
	index = NULL;
	goto out;

756 757 758 759 760 761
fail:
	dput(index);
	index = ERR_PTR(-EIO);
	goto out;
}

M
Miklos Szeredi 已提交
762 763 764 765 766 767 768 769 770 771 772 773 774 775 776 777
/*
 * Returns next layer in stack starting from top.
 * Returns -1 if this is the last layer.
 */
int ovl_path_next(int idx, struct dentry *dentry, struct path *path)
{
	struct ovl_entry *oe = dentry->d_fsdata;

	BUG_ON(idx < 0);
	if (idx == 0) {
		ovl_path_upper(dentry, path);
		if (path->dentry)
			return oe->numlower ? 1 : -1;
		idx++;
	}
	BUG_ON(idx > oe->numlower);
778 779
	path->dentry = oe->lowerstack[idx - 1].dentry;
	path->mnt = oe->lowerstack[idx - 1].layer->mnt;
M
Miklos Szeredi 已提交
780 781 782 783

	return (idx < oe->numlower) ? idx + 1 : -1;
}

784 785 786 787 788 789 790 791 792 793 794 795 796 797 798 799 800 801 802 803 804
/* Fix missing 'origin' xattr */
static int ovl_fix_origin(struct dentry *dentry, struct dentry *lower,
			  struct dentry *upper)
{
	int err;

	if (ovl_check_origin_xattr(upper))
		return 0;

	err = ovl_want_write(dentry);
	if (err)
		return err;

	err = ovl_set_origin(dentry, lower, upper);
	if (!err)
		err = ovl_set_impure(dentry->d_parent, upper->d_parent);

	ovl_drop_write(dentry);
	return err;
}

M
Miklos Szeredi 已提交
805 806 807 808 809
struct dentry *ovl_lookup(struct inode *dir, struct dentry *dentry,
			  unsigned int flags)
{
	struct ovl_entry *oe;
	const struct cred *old_cred;
M
Miklos Szeredi 已提交
810
	struct ovl_fs *ofs = dentry->d_sb->s_fs_info;
M
Miklos Szeredi 已提交
811
	struct ovl_entry *poe = dentry->d_parent->d_fsdata;
812
	struct ovl_entry *roe = dentry->d_sb->s_root->d_fsdata;
813
	struct ovl_path *stack = NULL;
M
Miklos Szeredi 已提交
814
	struct dentry *upperdir, *upperdentry = NULL;
815
	struct dentry *origin = NULL;
816
	struct dentry *index = NULL;
M
Miklos Szeredi 已提交
817 818 819
	unsigned int ctr = 0;
	struct inode *inode = NULL;
	bool upperopaque = false;
M
Miklos Szeredi 已提交
820
	char *upperredirect = NULL;
M
Miklos Szeredi 已提交
821 822 823
	struct dentry *this;
	unsigned int i;
	int err;
824 825 826 827 828
	struct ovl_lookup_data d = {
		.name = dentry->d_name,
		.is_dir = false,
		.opaque = false,
		.stop = false,
829
		.last = ofs->config.redirect_follow ? false : !poe->numlower,
M
Miklos Szeredi 已提交
830
		.redirect = NULL,
831
	};
M
Miklos Szeredi 已提交
832

M
Miklos Szeredi 已提交
833 834 835
	if (dentry->d_name.len > ofs->namelen)
		return ERR_PTR(-ENAMETOOLONG);

M
Miklos Szeredi 已提交
836
	old_cred = ovl_override_creds(dentry->d_sb);
837
	upperdir = ovl_dentry_upper(dentry->d_parent);
M
Miklos Szeredi 已提交
838
	if (upperdir) {
839 840
		err = ovl_lookup_layer(upperdir, &d, &upperdentry);
		if (err)
M
Miklos Szeredi 已提交
841 842
			goto out;

843 844 845 846
		if (upperdentry && unlikely(ovl_dentry_remote(upperdentry))) {
			dput(upperdentry);
			err = -EREMOTE;
			goto out;
M
Miklos Szeredi 已提交
847
		}
848 849
		if (upperdentry && !d.is_dir) {
			BUG_ON(!d.stop || d.redirect);
850 851 852 853 854 855 856 857 858 859
			/*
			 * Lookup copy up origin by decoding origin file handle.
			 * We may get a disconnected dentry, which is fine,
			 * because we only need to hold the origin inode in
			 * cache and use its inode number.  We may even get a
			 * connected dentry, that is not under any of the lower
			 * layers root.  That is also fine for using it's inode
			 * number - it's the same as if we held a reference
			 * to a dentry in lower layer that was moved under us.
			 */
860
			err = ovl_check_origin(ofs, upperdentry, &stack, &ctr);
861
			if (err)
862
				goto out_put_upper;
863
		}
M
Miklos Szeredi 已提交
864 865

		if (d.redirect) {
866
			err = -ENOMEM;
M
Miklos Szeredi 已提交
867 868 869 870
			upperredirect = kstrdup(d.redirect, GFP_KERNEL);
			if (!upperredirect)
				goto out_put_upper;
			if (d.redirect[0] == '/')
871
				poe = roe;
M
Miklos Szeredi 已提交
872
		}
873
		upperopaque = d.opaque;
M
Miklos Szeredi 已提交
874 875
	}

876
	if (!d.stop && poe->numlower) {
M
Miklos Szeredi 已提交
877
		err = -ENOMEM;
878
		stack = kcalloc(ofs->numlower, sizeof(struct ovl_path),
879
				GFP_KERNEL);
M
Miklos Szeredi 已提交
880 881 882 883
		if (!stack)
			goto out_put_upper;
	}

884
	for (i = 0; !d.stop && i < poe->numlower; i++) {
885
		struct ovl_path lower = poe->lowerstack[i];
M
Miklos Szeredi 已提交
886

887 888 889 890 891
		if (!ofs->config.redirect_follow)
			d.last = i == poe->numlower - 1;
		else
			d.last = lower.layer->idx == roe->numlower;

892
		err = ovl_lookup_layer(lower.dentry, &d, &this);
893
		if (err)
M
Miklos Szeredi 已提交
894
			goto out_put;
M
Miklos Szeredi 已提交
895

M
Miklos Szeredi 已提交
896 897 898
		if (!this)
			continue;

899 900 901 902 903 904 905 906 907 908 909 910
		/*
		 * If no origin fh is stored in upper of a merge dir, store fh
		 * of lower dir and set upper parent "impure".
		 */
		if (upperdentry && !ctr && !ofs->noxattr) {
			err = ovl_fix_origin(dentry, this, upperdentry);
			if (err) {
				dput(this);
				goto out_put;
			}
		}

911 912
		/*
		 * When "verify_lower" feature is enabled, do not merge with a
913 914
		 * lower dir that does not match a stored origin xattr. In any
		 * case, only verified origin is used for index lookup.
915 916 917 918 919 920 921
		 */
		if (upperdentry && !ctr && ovl_verify_lower(dentry->d_sb)) {
			err = ovl_verify_origin(upperdentry, this, false);
			if (err) {
				dput(this);
				break;
			}
922 923 924

			/* Bless lower dir as verified origin */
			origin = this;
925 926
		}

M
Miklos Szeredi 已提交
927
		stack[ctr].dentry = this;
928
		stack[ctr].layer = lower.layer;
M
Miklos Szeredi 已提交
929
		ctr++;
M
Miklos Szeredi 已提交
930

931 932 933 934 935 936 937 938 939 940 941 942
		/*
		 * Following redirects can have security consequences: it's like
		 * a symlink into the lower layer without the permission checks.
		 * This is only a problem if the upper layer is untrusted (e.g
		 * comes from an USB drive).  This can allow a non-readable file
		 * or directory to become readable.
		 *
		 * Only following redirects when redirects are enabled disables
		 * this attack vector when not necessary.
		 */
		err = -EPERM;
		if (d.redirect && !ofs->config.redirect_follow) {
943 944
			pr_warn_ratelimited("overlayfs: refusing to follow redirect for (%pd2)\n",
					    dentry);
945 946 947
			goto out_put;
		}

948 949 950
		if (d.stop)
			break;

951 952
		if (d.redirect && d.redirect[0] == '/' && poe != roe) {
			poe = roe;
M
Miklos Szeredi 已提交
953
			/* Find the current layer on the root dentry */
954
			i = lower.layer->idx - 1;
M
Miklos Szeredi 已提交
955
		}
M
Miklos Szeredi 已提交
956 957
	}

958 959 960 961 962 963 964 965
	/*
	 * Lookup index by lower inode and verify it matches upper inode.
	 * We only trust dir index if we verified that lower dir matches
	 * origin, otherwise dir index entries may be inconsistent and we
	 * ignore them. Always lookup index of non-dir and non-upper.
	 */
	if (ctr && (!upperdentry || !d.is_dir))
		origin = stack[0].dentry;
966

967 968
	if (origin && ovl_indexdir(dentry->d_sb) &&
	    (!d.is_dir || ovl_index_all(dentry->d_sb))) {
969
		index = ovl_lookup_index(ofs, upperdentry, origin, true);
970 971 972 973 974 975 976
		if (IS_ERR(index)) {
			err = PTR_ERR(index);
			index = NULL;
			goto out_put;
		}
	}

M
Miklos Szeredi 已提交
977 978 979 980 981
	oe = ovl_alloc_entry(ctr);
	err = -ENOMEM;
	if (!oe)
		goto out_put;

982
	memcpy(oe->lowerstack, stack, sizeof(struct ovl_path) * ctr);
M
Miklos Szeredi 已提交
983
	dentry->d_fsdata = oe;
M
Miklos Szeredi 已提交
984

985 986 987
	if (upperopaque)
		ovl_dentry_set_opaque(dentry);

988 989 990
	if (upperdentry)
		ovl_dentry_set_upper_alias(dentry);
	else if (index)
991 992
		upperdentry = dget(index);

M
Miklos Szeredi 已提交
993
	if (upperdentry || ctr) {
994 995
		if (ctr)
			origin = stack[0].dentry;
996 997
		inode = ovl_get_inode(dentry->d_sb, upperdentry, origin, index,
				      ctr);
998 999
		err = PTR_ERR(inode);
		if (IS_ERR(inode))
M
Miklos Szeredi 已提交
1000
			goto out_free_oe;
M
Miklos Szeredi 已提交
1001 1002

		OVL_I(inode)->redirect = upperredirect;
1003 1004
		if (index)
			ovl_set_flag(OVL_INDEX, inode);
M
Miklos Szeredi 已提交
1005 1006 1007
	}

	revert_creds(old_cred);
1008
	dput(index);
M
Miklos Szeredi 已提交
1009
	kfree(stack);
M
Miklos Szeredi 已提交
1010
	kfree(d.redirect);
1011
	return d_splice_alias(inode, dentry);
M
Miklos Szeredi 已提交
1012 1013

out_free_oe:
M
Miklos Szeredi 已提交
1014
	dentry->d_fsdata = NULL;
M
Miklos Szeredi 已提交
1015 1016
	kfree(oe);
out_put:
1017
	dput(index);
M
Miklos Szeredi 已提交
1018 1019 1020 1021 1022
	for (i = 0; i < ctr; i++)
		dput(stack[i].dentry);
	kfree(stack);
out_put_upper:
	dput(upperdentry);
M
Miklos Szeredi 已提交
1023
	kfree(upperredirect);
M
Miklos Szeredi 已提交
1024
out:
M
Miklos Szeredi 已提交
1025
	kfree(d.redirect);
M
Miklos Szeredi 已提交
1026 1027 1028 1029 1030 1031 1032 1033
	revert_creds(old_cred);
	return ERR_PTR(err);
}

bool ovl_lower_positive(struct dentry *dentry)
{
	struct ovl_entry *poe = dentry->d_parent->d_fsdata;
	const struct qstr *name = &dentry->d_name;
1034
	const struct cred *old_cred;
M
Miklos Szeredi 已提交
1035 1036 1037 1038 1039 1040 1041 1042 1043
	unsigned int i;
	bool positive = false;
	bool done = false;

	/*
	 * If dentry is negative, then lower is positive iff this is a
	 * whiteout.
	 */
	if (!dentry->d_inode)
1044
		return ovl_dentry_is_opaque(dentry);
M
Miklos Szeredi 已提交
1045 1046

	/* Negative upper -> positive lower */
1047
	if (!ovl_dentry_upper(dentry))
M
Miklos Szeredi 已提交
1048 1049
		return true;

1050
	old_cred = ovl_override_creds(dentry->d_sb);
M
Miklos Szeredi 已提交
1051 1052 1053 1054 1055 1056 1057 1058 1059 1060 1061 1062 1063 1064 1065 1066 1067 1068 1069 1070 1071 1072 1073 1074 1075 1076 1077 1078 1079
	/* Positive upper -> have to look up lower to see whether it exists */
	for (i = 0; !done && !positive && i < poe->numlower; i++) {
		struct dentry *this;
		struct dentry *lowerdir = poe->lowerstack[i].dentry;

		this = lookup_one_len_unlocked(name->name, lowerdir,
					       name->len);
		if (IS_ERR(this)) {
			switch (PTR_ERR(this)) {
			case -ENOENT:
			case -ENAMETOOLONG:
				break;

			default:
				/*
				 * Assume something is there, we just couldn't
				 * access it.
				 */
				positive = true;
				break;
			}
		} else {
			if (this->d_inode) {
				positive = !ovl_is_whiteout(this);
				done = true;
			}
			dput(this);
		}
	}
1080
	revert_creds(old_cred);
M
Miklos Szeredi 已提交
1081 1082 1083

	return positive;
}