Signed-off-by: NCleber Rosa <crosa@redhat.com>

Signed-off-by: NCleber Rosa <crosa@redhat.com>

Signed-off-by: NCleber Rosa <crosa@redhat.com>

And the requirement target for "check", given that it's already
called from the selftests/checkall script.
Signed-off-by: NCleber Rosa <crosa@redhat.com>

These are superior than the ones defined in the test, and using them
removes the duplicate code.
Signed-off-by: NCleber Rosa <crosa@redhat.com>

The network utility used to (attempt to) get a free port defaults to
picking sequential ports.  But, that's not a requirement of this test.
When running tests in parallel, the same port may get allocated when a
sequential approach is used, and that is greatly minimized when random
ports are requested.
Signed-off-by: NCleber Rosa <crosa@redhat.com>

When working on a private fork and topic branches, it's helpful to not
have this limitation, and have builds triggered for them.

For the main repo, it should not a problem given that branches are not
often (only on LTS releases), and those are also desirable to have
builds run.
Signed-off-by: NCleber Rosa <crosa@redhat.com>

Signed-off-by: NCleber Rosa <crosa@redhat.com>

Signed-off-by: NCleber Rosa <crosa@redhat.com>

Which are only necessary under Python 2, and thus, not needed
anymore.
Signed-off-by: NCleber Rosa <crosa@redhat.com>

The previous working dropping Python 2, removed the explicit
requirement of the six module, but because stevedore depends
on it, it would still be installed.

Now, every trace of explicit six usage has been removed.
Signed-off-by: NCleber Rosa <crosa@redhat.com>

Signed-off-by: NJan Richter <jarichte@redhat.com>

As there's no reason for this file to be executable.

Reference: https://github.com/avocado-framework/avocado/issues/3064Signed-off-by: NCleber Rosa <crosa@redhat.com>

Signed-off-by: NCleber Rosa <crosa@redhat.com>

Signed-off-by: NCleber Rosa <crosa@redhat.com>

Added append_file, append_one_line functions to genio.
There are situations where files with more than one line
are to be created with some filtered data. In those
situations, the existing functions namely write_file,
write_one_line are not helping.
Signed-off-by: NNageswara R Sastry <rnsastry@linux.vnet.ibm.com>

Settings Dispatcher: move it to its own module

Signed-off-by: NCleber Rosa <crosa@redhat.com>

Signed-off-by: NCleber Rosa <crosa@redhat.com>

fixed redhat distro version check in Rhel8.0
/etc/redhat-release output pattern changed

cat /etc/redhat-release
Red Hat Enterprise Linux release 8.0 Beta (Ootpa)

changed regex pattern which handle Rhel8 case as well
Signed-off-by: NPraveen K Pandey <praveen@linux.vnet.ibm.com>

Signed-off-by: NCleber Rosa <crosa@redhat.com>

Because of deprecation according to author.

Reference: https://github.com/avocado-framework/avocado/issues/3074Signed-off-by: NCleber Rosa <crosa@redhat.com>

There's no need to keep the special conditions for Python 2, now that
it's not supported anymore.
Signed-off-by: NCleber Rosa <crosa@redhat.com>

This test actually works fine under Python 3, the skip was not
properly lifted before.
Signed-off-by: NCleber Rosa <crosa@redhat.com>

We can now just use the module name as in Python 3 standard library.
Signed-off-by: NCleber Rosa <crosa@redhat.com>

The Python version used to run Avocado is not being respected in this
test.
Signed-off-by: NCleber Rosa <crosa@redhat.com>

Signed-off-by: NCleber Rosa <crosa@redhat.com>

Signed-off-by: NCleber Rosa <crosa@redhat.com>

When the recent_mock() utility was introduced, I may have missed the
fact that it would be possible to mock builtins.open().  Or, it may
be that was only possible in Python 3.

Anyway, now that we only support Python 3, let's just mock
builtins.open() and drop this custom decorator.
Signed-off-by: NCleber Rosa <crosa@redhat.com>

This avoids the circular import that was originally a problem, and
removes the "weird" SettingsDispatcher assignment to itself, while
still adding documentation to keep this and the other dispatchers
"linked".

Reference: https://github.com/avocado-framework/avocado/issues/3065Signed-off-by: NCleber Rosa <crosa@redhat.com>

Signed-off-by: NCleber Rosa <crosa@redhat.com>

The build of a given image, when given to avocado.utils.vmimage.get()
is incorrectly being assigned the same version number.
Signed-off-by: NCleber Rosa <crosa@redhat.com>

Signed-off-by: NCleber Rosa <crosa@redhat.com>

Signed-off-by: NCleber Rosa <crosa@redhat.com>

Signed-off-by: NCleber Rosa <crosa@redhat.com>

Signed-off-by: NCleber Rosa <crosa@redhat.com>

Signed-off-by: NCleber Rosa <crosa@redhat.com>

Signed-off-by: NCleber Rosa <crosa@redhat.com>

Signed-off-by: NCleber Rosa <crosa@redhat.com>

And the compatiblity helper six.  With Python 2 gone, a number of
package changes are also introduced, so that the packages are always
named python3-<suffix>.

Also, because it would be confusing not having an "avocado" script,
and to conform with the system wide change introduced by distros that
now offer Python 3 by default, the scripts are no longer called
avocado-3 (or avocado-3.x), but simply "avocado".
Signed-off-by: NCleber Rosa <crosa@redhat.com>