Merge remote-tracking branch 'clebergnu/lgtm_alerts'

Signed-off-by: NCleber Rosa <crosa@redhat.com>

avocado/utils/gdb.py

@@ -427,7 +427,7 @@ class GDB(object):
 
         self.send_gdb_command(command)
         responses = self.read_until_break()
-        result_response = None
+        result_response_received = False
 
         for line in responses:
             # If the line can not be properly parsed, it is *most likely*
@@ -442,10 +442,11 @@ class GDB(object):
                     parsed_response.record_type == 'stream'):
                 cmd.stream_messages.append(parsed_response)
             elif parsed_response.type == 'result':
-                if result_response is not None:
+                if result_response_received:
                     # raise an exception here, because no two result
                     # responses should come from a single command AFAIK
                     raise Exception("Many result responses to a single cmd")
+                result_response_received = True
                 cmd.result = parsed_response
             else:
                 self.async_messages.append(parsed_response)

avocado/utils/iso9660.py

@@ -34,7 +34,6 @@ import sys
 import tempfile
 
 from . import process
-from . import path as utils_path
 
 
 try:
@@ -130,7 +129,6 @@ class BaseIso9660(object):
     """
 
     def __init__(self, path):
-        utils_path.check_readable(path)
         self.path = path
 
     def read(self, path):
@@ -382,7 +380,7 @@ class ISO9660PyCDLib(MixInMntDirMount, BaseIso9660):
     def __init__(self, path):
         if not has_pycdlib():
             raise RuntimeError('This class requires the pycdlib library')
-        self.path = path
+        super(ISO9660PyCDLib, self).__init__(path)
         self._iso = None
         self._iso_opened_for_create = False
 

avocado/utils/process.py

@@ -1149,11 +1149,10 @@ class GDBSubProcess(object):
 
                 elif gdb.is_break_hit(parsed_msg):
                     # waits on fifo read() until end of debug session is notified
-                    r = self.handle_break_hit(parsed_msg)
-                    if r == 'C':
+                    if self.handle_break_hit(parsed_msg) == 'C':
                         self.gdb.connect(self.gdb_server.port)
                         if self._is_thread_stopped():
-                            r = self.gdb.cli_cmd("continue")
+                            self.gdb.cli_cmd("continue")
                         else:
                             log.warn('Binary "%s" terminated inside the '
                                      'debugger before avocado was resumed. '
@@ -1169,7 +1168,7 @@ class GDBSubProcess(object):
 
                 elif gdb.is_fatal_signal(parsed_msg):
                     # waits on fifo read() until end of debug session is notified
-                    r = self.handle_fatal_signal(parsed_msg)
+                    self.handle_fatal_signal(parsed_msg)
                     log.warn('Because "%s" received a fatal signal, this test '
                              'is going to be skipped.', self.binary)
                     # pylint: disable=E0702