We did change the short name identifiers that are displayed
in `avocado plugins`. Let's update so people don't get lost.
Signed-off-by: NLucas Meneghel Rodrigues <lmr@redhat.com>

In module avocado.core.plugins.builtin, There is a calling of
os.listdir() to iterate files in the installed python directory.

If avocado is installed in an .egg file which is compressed, it will
fail to load because that path does not really exists.

To avoid this failure, this patch set zip_safe to False explicitly.
So setuptools will install package to a real directory instead of a
zipped .egg file.
Signed-off-by: NHao Liu <hliu@redhat.com>

docs: Add Multiplexation to WritingTests.html#basic-example

Currently the yaml contents in this page is missing '!mux'
keyword, run as-is will show users errors. Fixing by adding
keyword '!mux' to the yaml content.
Signed-off-by: NSrikanth Aithal <sraithal@linux.vnet.ibm.com>

selftests/run: Ensure bad statuses trigger an exit code != 0

The way we built the unittest runner will happily
ignore errors, which is bad from a CI standpoint.
Let's ensure that errors don't go unnoticed by
analyzing the results object and see if it's got
errors or failures.
Signed-off-by: NLucas Meneghel Rodrigues <lmr@redhat.com>

Makefile: Allow different paths

Some people clone repositories to different names, which breaks the
"make link" functionality. This patch uses dynamic variables to support
such usage.
Signed-off-by: NLukáš Doktor <ldoktor@redhat.com>

RFC: Makefile: Move "make link" to plugins

This patch removes the hardcoded plugin linking and instead queries all
../!(avocado)/Makefile files to link or unlink the plugins. This should
help people to deploy own plugins in the same fashion without the need
to modify avocado's main Makefile.
Signed-off-by: NLukáš Doktor <ldoktor@redhat.com>

avocado.core.data_dir: Make data dir to honor settings when running f…

We should be honoring the setting in the avocado config files
if running from git repos.
Signed-off-by: NLucas Meneghel Rodrigues <lmr@redhat.com>

docs: Configuration - Add note about alternate config locations

If avocado is running from git repos, instead of a regular
system wide install, in tree config files will be used instead
of the system wide config files. Make that clear in the documentation.
Signed-off-by: NLucas Meneghel Rodrigues <lmr@redhat.com>

Add simple script to see the "core" and "utils" unittest code coverage.
Signed-off-by: NLukáš Doktor <ldoktor@redhat.com>

selftests/functional/test_interrupt.py: Fix NoSuchProcess bug

If between psutil.procs() and the instantiation of the Process
object the given pid has terminated, we'll get a NoSuchProcess
error from psutils. Let's expand the list comprehension to avoid
getting caught by such a condition.
Signed-off-by: NLucas Meneghel Rodrigues <lmr@redhat.com>

Use standard unittest (and setuptools) for execution of selftests 

All other tests (unit and functional) are based on unittest. Let's do
the same to this one, so that the default unittest discover code finds
it and runs it.
Signed-off-by: NCleber Rosa <crosa@redhat.com>

Even though I may be the one to blame about coming up with this
"simple import magic", I believe it was a mistake and we should get
rid of them.

There are a couple of other ways to actually do development out of
of a source tree, including running unittests that do not require
this amount of boiler plate code. Examples include just setting
the PYTHONPATH environment variable to actually run (setuptools based)
`python setup.py develop`.

The little bits of what looks like the import magic that was left, is
not really import magic. It's just that functional tests need to locate
the Avocado source tree base directory to run the test runner from it.
Signed-off-by: NCleber Rosa <crosa@redhat.com>

One standard setuptools command is "test". That command does some useful
setup and then runs the test in a verbose mode.

There are a couple of reasons for activating that, including that
setuptools can help us support a Python 3 version of Avocado by
running 2to3 and even custom fixers before running the tests, or even
builds and installs.
Signed-off-by: NCleber Rosa <crosa@redhat.com>

The unittest module, and unittest2 backport on Python 2.6, is capable of
finding unittests and running them. So, effectively, we do not need nose
at all.

This patch removes the dependency on nose, replacing the run script
with a version based solely on the unittest module.

One change of functionality is that run now looks and runs tests in the
standard selftests directories (unit, functional, doc), and does not
accept command line arguments. If one wants to run a subset of them,
it's pretty easy to just use the unittest module for that:

 $ python -m unittest discover -s selftests/unit
Signed-off-by: NCleber Rosa <crosa@redhat.com>

When running this functional test with the standard unittest
discovery/runner it produces output that conflicts with the runner
output.

It looks like this output is not necessary for the test itself, and
not that helpful for debugging purposes, so, let's just silence it.
Signed-off-by: NCleber Rosa <crosa@redhat.com>

To be honest, our test code could still be kept in the same directories and
have the same names. But I think we can improve two things here:

1) Flatten a little bit the directory structure of selftests. Two path
components are being dropped here: "all" and "avocado". So that
"selftests/all/functional/avocado" becomes simply
"selftests/functional".

2) File names match what is, by default, recognized by unittest (the
Standard Library module) based discovery of tests. That means that
doc_build_test.py becomes test_doc_build.py. Not a big deal IMHO.
Signed-off-by: NCleber Rosa <crosa@redhat.com>

[V3] Fix Ctrl+C for realz

Add functional automated tests for the Ctrl+C feature.
They use aexpect and psutil, so add their dependencies
to the relevant requirement files.
Signed-off-by: NLucas Meneghel Rodrigues <lmr@redhat.com>

examples/linuxbuild.py: Revert self.srcdir override

avocado.core.output: Fix mistake introduced in aa110812

Add some functional tests that ensure that we don't
get caught by mistakes made when modifying the human
test reporting code again (or at least, not by the
obvious ones).
Signed-off-by: NLucas Meneghel Rodrigues <lmr@redhat.com>

Inner Runner implementation [v2]

The correct mapping for FAIL tests is term_support.fail_str,
not term_support.error_str. This will make FAIL tests to
report as FAIL again.
Signed-off-by: NLucas Meneghel Rodrigues <lmr@redhat.com>

With ldoktor's fix 136a78b6 this is unnecessary and we
risk it being confused for people looking at the
examples.
Signed-off-by: NLucas Meneghel Rodrigues <lmr@redhat.com>

[V2] Output tweaks

avocado.core.job: Print variants after the tree representation

Change docs to show an output that reflects the current
state of avocado.
Signed-off-by: NLucas Meneghel Rodrigues <lmr@redhat.com>

Display the variants after the tree representation in the job log.
Signed-off-by: NLucas Meneghel Rodrigues <lmr@redhat.com>

[V2] avocado.core.job: Log avocado temporary dir

Display the temporary directory in the job log.
Signed-off-by: NLucas Meneghel Rodrigues <lmr@redhat.com>