Settings Dispatcher: move it to its own module

Signed-off-by: NCleber Rosa <crosa@redhat.com>

Signed-off-by: NCleber Rosa <crosa@redhat.com>

fixed redhat distro version check in Rhel8.0
/etc/redhat-release output pattern changed

cat /etc/redhat-release
Red Hat Enterprise Linux release 8.0 Beta (Ootpa)

changed regex pattern which handle Rhel8 case as well
Signed-off-by: NPraveen K Pandey <praveen@linux.vnet.ibm.com>

Signed-off-by: NCleber Rosa <crosa@redhat.com>

Because of deprecation according to author.

Reference: https://github.com/avocado-framework/avocado/issues/3074Signed-off-by: NCleber Rosa <crosa@redhat.com>

There's no need to keep the special conditions for Python 2, now that
it's not supported anymore.
Signed-off-by: NCleber Rosa <crosa@redhat.com>

This test actually works fine under Python 3, the skip was not
properly lifted before.
Signed-off-by: NCleber Rosa <crosa@redhat.com>

We can now just use the module name as in Python 3 standard library.
Signed-off-by: NCleber Rosa <crosa@redhat.com>

The Python version used to run Avocado is not being respected in this
test.
Signed-off-by: NCleber Rosa <crosa@redhat.com>

Signed-off-by: NCleber Rosa <crosa@redhat.com>

Signed-off-by: NCleber Rosa <crosa@redhat.com>

This avoids the circular import that was originally a problem, and
removes the "weird" SettingsDispatcher assignment to itself, while
still adding documentation to keep this and the other dispatchers
"linked".

Reference: https://github.com/avocado-framework/avocado/issues/3065Signed-off-by: NCleber Rosa <crosa@redhat.com>

Signed-off-by: NCleber Rosa <crosa@redhat.com>

The build of a given image, when given to avocado.utils.vmimage.get()
is incorrectly being assigned the same version number.
Signed-off-by: NCleber Rosa <crosa@redhat.com>

Signed-off-by: NCleber Rosa <crosa@redhat.com>

Signed-off-by: NCleber Rosa <crosa@redhat.com>

Signed-off-by: NCleber Rosa <crosa@redhat.com>

Signed-off-by: NCleber Rosa <crosa@redhat.com>

Signed-off-by: NCleber Rosa <crosa@redhat.com>

Signed-off-by: NCleber Rosa <crosa@redhat.com>

Signed-off-by: NCleber Rosa <crosa@redhat.com>

And the compatiblity helper six.  With Python 2 gone, a number of
package changes are also introduced, so that the packages are always
named python3-<suffix>.

Also, because it would be confusing not having an "avocado" script,
and to conform with the system wide change introduced by distros that
now offer Python 3 by default, the scripts are no longer called
avocado-3 (or avocado-3.x), but simply "avocado".
Signed-off-by: NCleber Rosa <crosa@redhat.com>

This basically means that any pushes to the 69lts branch will also
generate a new Travis CI job.
Signed-off-by: NCleber Rosa <crosa@redhat.com>

So that we can start testing newer Python versions and more
up to date platforms.
Signed-off-by: NCleber Rosa <crosa@redhat.com>

Signed-off-by: NCleber Rosa <crosa@redhat.com>

And avoid checking for the existence (and readability) of the ISO file
on other backends, given that now it's possible to create ISO files.
Signed-off-by: NCleber Rosa <crosa@redhat.com>

The check for duplicate responses coming from a gdb command is
currently not effective, given that the "response already received"
flag is never set.

This was spotted by an lgtm.com alert.
Signed-off-by: NCleber Rosa <crosa@redhat.com>

The command result gets assigned to variables that are either not
used, or used only once.
Signed-off-by: NCleber Rosa <crosa@redhat.com>

Besides Copr, which provides a build status badge, let's also
(proudly) display the ratings and issues that lgtm gives us.
Signed-off-by: NCleber Rosa <crosa@redhat.com>

And by removing the data, we won't have any test to be run, so
we're also removing the test itself.
Signed-off-by: NCleber Rosa <crosa@redhat.com>

We only run tests on Python >= 3.4, so let's not attempt to support
anything else.
Signed-off-by: NCleber Rosa <crosa@redhat.com>

The E1136 (unsubscriptable-object) error on pylint is described as
being "emitted when a subscripted value doesn't support subscription
(i.e. doesn't define __getitem__ method or __class_getitem__ for a
class)".

But that is not the case here, so assuming it's a false positive,
let's ignore this check.
Signed-off-by: NCleber Rosa <crosa@redhat.com>

It was introduced in 8f8d668b, but stoped being used in 6681f2d6.
Signed-off-by: NCleber Rosa <crosa@redhat.com>

There's no need for the first assignments to the `TERM_SUPPORT`
and `STD_OUTPUT` variables.
Signed-off-by: NCleber Rosa <crosa@redhat.com>

Commit 9401c928 removed Python 2.6 support, but this bit remained.
Signed-off-by: NCleber Rosa <crosa@redhat.com>

Signed-off-by: NCleber Rosa <crosa@redhat.com>

The pylint version in use requires a specific version (or a not
so greater version) of astroid.  When the astroid version is not
pinned, astroid version 2.2.4 currently gets installed.

Then, pylint (and thus inspektor) fails with:

  'Import' object has no attribute 'infer_name_module'

Let's bump the pylint version (already pinned) and pin a compatible
astroid version too.
Signed-off-by: NCleber Rosa <crosa@redhat.com>

Signed-off-by: NCleber Rosa <crosa@redhat.com>

Signed-off-by: NCleber Rosa <crosa@redhat.com>