avocado.core.remoter: Avoid repeating of the remote command

Currently the remote loop is missing "break" so it resends the same
command until the timeout is reached.

While working on this I recreated the loop so it supports None timeout,
which is required for some operations.
Signed-off-by: NLukáš Doktor <ldoktor@redhat.com>

examples.tests: Rename failtest_nasty* to errortest_nasty*

The name was not correct as the test should error-out.
Signed-off-by: NLukáš Doktor <ldoktor@redhat.com>

avocado.core.test: Avoid passing ugly exceptions

Spec files Update

Signed-off-by: NLucas Meneghel Rodrigues <lmr@redhat.com>

With the recent changes in how the unittest suite runs,
now all functional test suites run on new COPR builds.
Let's include the dependencies necessary for the tests
to run.
Signed-off-by: NLucas Meneghel Rodrigues <lmr@redhat.com>

avocado.core.remoter: Handle fabric NetworkError properly

avocado.utils.process: Add missing parenthesis

Signed-off-by: NHao Liu <hliu@redhat.com>

selftests/test_interrupt.py: Make test compatible with psutils 0.6

Fedora 21 ships psutils 0.6, that has the API psutil.get_pid_list()
instead of psutil.pids(). Let's make both compatible, for the sake
of running unittests on COPR builds.
Signed-off-by: NLucas Meneghel Rodrigues <lmr@redhat.com>

Signed-off-by: NLucas Meneghel Rodrigues <lmr@redhat.com>

examples/testplans/release.json: Change vt plugin identifiers

We did change the short name identifiers that are displayed
in `avocado plugins`. Let's update so people don't get lost.
Signed-off-by: NLucas Meneghel Rodrigues <lmr@redhat.com>

avocado.core.plugins: Print traceback on failure

On plugin import failure we get the error message, which in case of
IOError is: "IOError: [Errno 2] No such file or directory". We have to
debug it or add some prints to discover, what happened. Let's add
optional traceback print in the same fashion as the "loader" does.
(the output is ignored unless the user enables "avocado.app.tracebacks")
Signed-off-by: NLukáš Doktor <ldoktor@redhat.com>

Currently when one passes exception, which is not instance of Exception,
avocado proceeds and returns "INTERRUPTED" test instead of "ERROR". This
for example happens when old-style-class is used as exception. This
patch uses pure "except" without any argument to catch such exceptions
and then it wraps them in "exceptions.TestError" instead.

The same applies to "setUp" and "tearDown", they only use different
class as a wrapper.
Signed-off-by: NLukáš Doktor <ldoktor@redhat.com>

The response of very slow machine with uninitilized sshd causes fabric
to raise NetworkError even though timeout was not yet reached. This
patch calls fabric in loop until the timeout is exhausted.
Signed-off-by: NLukáš Doktor <ldoktor@redhat.com>

Initialize "root" logger as "NullHandler" to prevent other libraries
from initializing. Avocado adds file or stream handlers when it
requires them (avocado-vt).
Signed-off-by: NLukáš Doktor <ldoktor@redhat.com>

In module avocado.core.plugins.builtin, There is a calling of
os.listdir() to iterate files in the installed python directory.

If avocado is installed in an .egg file which is compressed, it will
fail to load because that path does not really exists.

To avoid this failure, this patch set zip_safe to False explicitly.
So setuptools will install package to a real directory instead of a
zipped .egg file.
Signed-off-by: NHao Liu <hliu@redhat.com>

docs: Add Multiplexation to WritingTests.html#basic-example

Currently the yaml contents in this page is missing '!mux'
keyword, run as-is will show users errors. Fixing by adding
keyword '!mux' to the yaml content.
Signed-off-by: NSrikanth Aithal <sraithal@linux.vnet.ibm.com>

selftests/run: Ensure bad statuses trigger an exit code != 0

The way we built the unittest runner will happily
ignore errors, which is bad from a CI standpoint.
Let's ensure that errors don't go unnoticed by
analyzing the results object and see if it's got
errors or failures.
Signed-off-by: NLucas Meneghel Rodrigues <lmr@redhat.com>

Makefile: Allow different paths

Some people clone repositories to different names, which breaks the
"make link" functionality. This patch uses dynamic variables to support
such usage.
Signed-off-by: NLukáš Doktor <ldoktor@redhat.com>

RFC: Makefile: Move "make link" to plugins

This patch removes the hardcoded plugin linking and instead queries all
../!(avocado)/Makefile files to link or unlink the plugins. This should
help people to deploy own plugins in the same fashion without the need
to modify avocado's main Makefile.
Signed-off-by: NLukáš Doktor <ldoktor@redhat.com>

avocado.core.data_dir: Make data dir to honor settings when running f…

We should be honoring the setting in the avocado config files
if running from git repos.
Signed-off-by: NLucas Meneghel Rodrigues <lmr@redhat.com>

docs: Configuration - Add note about alternate config locations

If avocado is running from git repos, instead of a regular
system wide install, in tree config files will be used instead
of the system wide config files. Make that clear in the documentation.
Signed-off-by: NLucas Meneghel Rodrigues <lmr@redhat.com>

Add simple script to see the "core" and "utils" unittest code coverage.
Signed-off-by: NLukáš Doktor <ldoktor@redhat.com>

selftests/functional/test_interrupt.py: Fix NoSuchProcess bug

If between psutil.procs() and the instantiation of the Process
object the given pid has terminated, we'll get a NoSuchProcess
error from psutils. Let's expand the list comprehension to avoid
getting caught by such a condition.
Signed-off-by: NLucas Meneghel Rodrigues <lmr@redhat.com>