Signed-off-by: NLukáš Doktor <ldoktor@redhat.com>

* https://github.com/avocado-framework/avocado:
  data_dir: use a directory intended for writable content

Signed-off-by: NCleber Rosa <crosa@redhat.com>

Signed-off-by: NAmador Pahim <apahim@redhat.com>

The FileLoader heuristic to find test is quite complicated and there was
one uncovered branch which did not report anything. Let's avoid this by
reporting `MissingTest` at the end of the execution unless we specify
otherwise (by return).
Signed-off-by: NLukáš Doktor <ldoktor@redhat.com>

The MissingTest is yielded by TestLoaderProxy, but it was implemented
and described in FileLoader, which caused troubles when FileLoader was
not being used. This simple fix allows TestLoaderProxy to define basic
mappings and adds MissingTest to it.
Signed-off-by: NLukáš Doktor <ldoktor@redhat.com>

Signed-off-by: NCleber Rosa <crosa@redhat.com>

Avocado's "data_dir" has always been meant for readable **and** writable
content.

Right now, this is broken because the system wide default for
"base_dir" (data_dir's parent) is set to /usr/share/avocado, and
consequently, "data_dir" is set to /usr/share/avocado/data.

Let's use "/var/lib/avocado" for the "base_dir", and
"/var/lib/avocado/data" for the "data_dir".  Content intended to be
read-only, such as example tests and wrappers, are still set to
/usr/share/avocado.

This has been tested with Avocado-VT, making the result of system
wide content, such as test providers and downloadable files be
put under "/var/lib/avocado/data/avocado-vt".

Reference: https://trello.com/c/KU1DvSAzSigned-off-by: NCleber Rosa <crosa@redhat.com>

Signed-off-by: NAmador Pahim <apahim@redhat.com>

Signed-off-by: NLukáš Doktor <ldoktor@redhat.com>

* https://github.com/avocado-framework/avocado:
  python-avocado.spec: fix excluded files for optional plugin packages

Commit 7a249b7c removed files that were intended to be packaged in the
optional plugin packages.  By doing so, they ended up in the main
package.

This fixes that issue, and puts both the directories with the
package and module name (which differ) into each optional plugin
package file listing.
Signed-off-by: NCleber Rosa <crosa@redhat.com>

The option "--loaders" accepts either loader plugin or plugin followed
by test type. Listing both at the same time was a bit confusing so this
patch lists them per-plugin.
Signed-off-by: NLukáš Doktor <ldoktor@redhat.com>

Signed-off-by: NLukáš Doktor <ldoktor@redhat.com>

* https://github.com/avocado-framework/avocado:
  fix output on unknown tests

When the tests references cannot be resolved to a test_suite, the
results plugins should not output anything.

Reference: https://trello.com/c/oMQsQHC6Signed-off-by: NAmador Pahim <apahim@redhat.com>

Signed-off-by: NCleber Rosa <crosa@redhat.com>

We prove that `post_tests` will always be executed when `pre_tests` was.
Let's remove the unnecessary `__del__` handling of teststmpdir.
Signed-off-by: NLukáš Doktor <ldoktor@redhat.com>

This adds the documentation of pre/post tests plugin interface including
the conditions under which they are or are not executed.
Signed-off-by: NLukáš Doktor <ldoktor@redhat.com>

This commit enables the left-behind-temporary-dirs check between each
test. As all selftests are executed as a single process the BORG class
keeps the TMP dir of the unit-tests. To avoid results spoiled by this
fact this commit adds a force-cleanup of the tmp dir tracker overriding
the BORG internal state, which is not really nice, but for selftests
acceptable.

The method to clean it was especially named
"unittest_refresh_dir_tracker" to emphasize it should not be used
outside of unittest.
Signed-off-by: NLukáš Doktor <ldoktor@redhat.com>

In some tests we override the job workflow, let's make sure the
post_tests is executed whenever pre_test was.
Signed-off-by: NLukáš Doktor <ldoktor@redhat.com>

Remove the temporary script files which are not located in tmpdirs.
Signed-off-by: NLukáš Doktor <ldoktor@redhat.com>

This commit modifies the optional_plugins to depend on VERSION files
located in their main directories and adds "propagate-version" target to
Makefile to update the VERSION files for optional as well as "linkable"
plugins, if VERSION file was present.
Signed-off-by: NLukáš Doktor <ldoktor@redhat.com>

Signed-off-by: NLukáš Doktor <ldoktor@redhat.com>

* https://github.com/avocado-framework/avocado:
  SPEC file: sync how we build snapshot and release packages

Use the combination of path-ordered leaves names and a hash of combined
fingerprint as variant_id. This should improve human-readability of the
results and also it should produce machine-friendly unique names, which
change when values in variant are modified.

Because the leaves names are ordered by path, the order of yaml file
does not affect the variant_id. On the other hand any modified/added
value changes the fingerprint and therefor variant_id.

Important feature is also that the variant still contains the
default_params, but the variant-id is not affected by it.
Signed-off-by: NLukáš Doktor <ldoktor@redhat.com>

The TreeEnvironment uses default-dict representation, which uses
__repr__ on items. This is not really human friendly and more
importantly it contains dynamic data (object id) which changes per
execution and we are using environment in fingerprint, which does not
really work well for TreeNodeDebug. This patch replaces the __repr__
with __str__ which improves the readability and avoids the dynamic data.
Signed-off-by: NLukáš Doktor <ldoktor@redhat.com>

The TreeNode.fingerprint() generates string, which represents the value
of the node. The idea is to represent the content of the node and it's
environment and such for the purpose of evaluating, whether other node
is alike.
Signed-off-by: NLukáš Doktor <ldoktor@redhat.com>

Downstream (Fedora and EPEL) RPM packages have had a different way
of building release (by default) and snapshot packages by editing
the SPEC file.

Let's sync with them, while also allowing snapshot packages to be
built from our usual `make rpm` command.  Release builds are still
supported with `make rpm-release`.
Signed-off-by: NCleber Rosa <crosa@redhat.com>

Signed-off-by: NLukáš Doktor <ldoktor@redhat.com>

* https://github.com/avocado-framework/avocado:
  Altered the way linux_modules checks loaded module
  linux_modules returns parameter type

Signed-off-by: NLukáš Doktor <ldoktor@redhat.com>

* https://github.com/avocado-framework/avocado:
  utils: Add "get_interfaces_in_pci_address" method to pci.py

Signed-off-by: NAmador Pahim <apahim@redhat.com>

Signed-off-by: NCleber Rosa <crosa@redhat.com>

Signed-off-by: NCleber Rosa <crosa@redhat.com>

Using more than one docstrig directive makes Avocado to use only the
first one. This patch makes the safeloader to handle multiple docstring
directives (i.e. `🥑 enable` and `🥑 tags=foo`).

Reference: https://trello.com/c/6FpySXuCSigned-off-by: NAmador Pahim <apahim@redhat.com>

Add a new function, which takes pci_address and pci_class as
i/P and returns corresponding pci_interface
Signed-off-by: NVenkat R B <vrbagal1@linux.vnet.ibm.com>

avocado/utils/linux_modules: module_is_loaded() was using
loaded_module_info() to check if a module is loaded or not,
which is a roundabout approach, and prints some unnecessary
information as well.
Made it to read /proc/modules to check this.
Signed-off-by: NNarasimhan V <sim@linux.vnet.ibm.com>

avocado/utils/linux_modules: In addition to parameters, their
types are also returned by loaded_module_info()
Signed-off-by: NNarasimhan V <sim@linux.vnet.ibm.com>

Signed-off-by: NAmador Pahim <apahim@redhat.com>

Currently the `selftests/run_coverage` only reports unit coverage. This
patch allows specifying custom `avocado` command in selftests and uses
it to run coverage to also include the functional tests to results.
Signed-off-by: NLukáš Doktor <ldoktor@redhat.com>

Signed-off-by: NCleber Rosa <crosa@redhat.com>

`system-out` should be in the same level as `failure`, but we are
creating it as a `failure` child.

This patch puts system-out in the same level as `failure` and adds the
functional test to validate all the xunit outputs against the
junit-4.xsd schema.
Signed-off-by: NAmador Pahim <apahim@redhat.com>

Let's move the junit schema file to .data so we can reuse it for
functional tests.
Signed-off-by: NAmador Pahim <apahim@redhat.com>

Signed-off-by: NAmador Pahim <apahim@redhat.com>