rewriter.cpp 21.0 KB
Newer Older
D
duke 已提交
1
/*
2
 * Copyright (c) 1998, 2014, Oracle and/or its affiliates. All rights reserved.
D
duke 已提交
3 4 5 6 7 8 9 10 11 12 13 14 15 16 17 18
 * DO NOT ALTER OR REMOVE COPYRIGHT NOTICES OR THIS FILE HEADER.
 *
 * This code is free software; you can redistribute it and/or modify it
 * under the terms of the GNU General Public License version 2 only, as
 * published by the Free Software Foundation.
 *
 * This code is distributed in the hope that it will be useful, but WITHOUT
 * ANY WARRANTY; without even the implied warranty of MERCHANTABILITY or
 * FITNESS FOR A PARTICULAR PURPOSE.  See the GNU General Public License
 * version 2 for more details (a copy is included in the LICENSE file that
 * accompanied this code).
 *
 * You should have received a copy of the GNU General Public License version
 * 2 along with this work; if not, write to the Free Software Foundation,
 * Inc., 51 Franklin St, Fifth Floor, Boston, MA 02110-1301 USA.
 *
19 20 21
 * Please contact Oracle, 500 Oracle Parkway, Redwood Shores, CA 94065 USA
 * or visit www.oracle.com if you need additional information or have any
 * questions.
D
duke 已提交
22 23 24
 *
 */

25 26 27 28 29 30 31
#include "precompiled.hpp"
#include "interpreter/bytecodes.hpp"
#include "interpreter/interpreter.hpp"
#include "interpreter/rewriter.hpp"
#include "memory/gcLocker.hpp"
#include "memory/resourceArea.hpp"
#include "oops/generateOopMap.hpp"
32
#include "prims/methodHandles.hpp"
D
duke 已提交
33

34
// Computes a CPC map (new_index -> original_index) for constant pool entries
D
duke 已提交
35
// that are referred to by the interpreter at runtime via the constant pool cache.
36 37 38 39
// Also computes a CP map (original_index -> new_index).
// Marks entries in CP which require additional processing.
void Rewriter::compute_index_maps() {
  const int length  = _pool->length();
40
  init_maps(length);
41
  bool saw_mh_symbol = false;
D
duke 已提交
42
  for (int i = 0; i < length; i++) {
43 44 45
    int tag = _pool->tag_at(i).value();
    switch (tag) {
      case JVM_CONSTANT_InterfaceMethodref:
D
duke 已提交
46 47
      case JVM_CONSTANT_Fieldref          : // fall through
      case JVM_CONSTANT_Methodref         : // fall through
48 49 50
        add_cp_cache_entry(i);
        break;
      case JVM_CONSTANT_String:
51 52
      case JVM_CONSTANT_MethodHandle      : // fall through
      case JVM_CONSTANT_MethodType        : // fall through
53
        add_resolved_references_entry(i);
54
        break;
55 56 57 58
      case JVM_CONSTANT_Utf8:
        if (_pool->symbol_at(i) == vmSymbols::java_lang_invoke_MethodHandle())
          saw_mh_symbol = true;
        break;
D
duke 已提交
59 60
    }
  }
61

62 63 64
  // Record limits of resolved reference map for constant pool cache indices
  record_map_limits();

65 66
  guarantee((int)_cp_cache_map.length()-1 <= (int)((u2)-1),
            "all cp cache indexes fit in a u2");
67

68 69
  if (saw_mh_symbol)
    _method_handle_invokers.initialize(length, (int)0);
D
duke 已提交
70 71
}

72
// Unrewrite the bytecodes if an error occurs.
73
void Rewriter::restore_bytecodes() {
74
  int len = _methods->length();
75
  bool invokespecial_error = false;
76 77

  for (int i = len-1; i >= 0; i--) {
78
    Method* method = _methods->at(i);
79 80
    scan_method(method, true, &invokespecial_error);
    assert(!invokespecial_error, "reversing should not get an invokespecial error");
81 82
  }
}
D
duke 已提交
83

84 85
// Creates a constant pool cache given a CPC map
void Rewriter::make_constant_pool_cache(TRAPS) {
86 87
  ClassLoaderData* loader_data = _pool->pool_holder()->class_loader_data();
  ConstantPoolCache* cache =
88 89
      ConstantPoolCache::allocate(loader_data, _cp_cache_map,
                                  _invokedynamic_cp_cache_map,
90
                                  _invokedynamic_references_map, CHECK);
91 92 93 94 95

  // initialize object cache in constant pool
  _pool->initialize_resolved_references(loader_data, _resolved_references_map,
                                        _resolved_reference_limit,
                                        CHECK);
96 97
  _pool->set_cache(cache);
  cache->set_constant_pool(_pool());
D
duke 已提交
98 99 100 101 102 103 104 105 106 107 108 109 110 111 112 113 114 115 116 117 118 119 120 121 122 123 124 125 126 127 128 129 130 131 132 133 134 135 136 137 138 139 140
}



// The new finalization semantics says that registration of
// finalizable objects must be performed on successful return from the
// Object.<init> constructor.  We could implement this trivially if
// <init> were never rewritten but since JVMTI allows this to occur, a
// more complicated solution is required.  A special return bytecode
// is used only by Object.<init> to signal the finalization
// registration point.  Additionally local 0 must be preserved so it's
// available to pass to the registration function.  For simplicty we
// require that local 0 is never overwritten so it's available as an
// argument for registration.

void Rewriter::rewrite_Object_init(methodHandle method, TRAPS) {
  RawBytecodeStream bcs(method);
  while (!bcs.is_last_bytecode()) {
    Bytecodes::Code opcode = bcs.raw_next();
    switch (opcode) {
      case Bytecodes::_return: *bcs.bcp() = Bytecodes::_return_register_finalizer; break;

      case Bytecodes::_istore:
      case Bytecodes::_lstore:
      case Bytecodes::_fstore:
      case Bytecodes::_dstore:
      case Bytecodes::_astore:
        if (bcs.get_index() != 0) continue;

        // fall through
      case Bytecodes::_istore_0:
      case Bytecodes::_lstore_0:
      case Bytecodes::_fstore_0:
      case Bytecodes::_dstore_0:
      case Bytecodes::_astore_0:
        THROW_MSG(vmSymbols::java_lang_IncompatibleClassChangeError(),
                  "can't overwrite local 0 in Object.<init>");
        break;
    }
  }
}


141
// Rewrite a classfile-order CP index into a native-order CPC index.
142
void Rewriter::rewrite_member_reference(address bcp, int offset, bool reverse) {
143
  address p = bcp + offset;
144 145 146 147
  if (!reverse) {
    int  cp_index    = Bytes::get_Java_u2(p);
    int  cache_index = cp_entry_to_cp_cache(cp_index);
    Bytes::put_native_u2(p, cache_index);
148
    if (!_method_handle_invokers.is_empty())
149
      maybe_rewrite_invokehandle(p - 1, cp_index, cache_index, reverse);
150 151 152 153
  } else {
    int cache_index = Bytes::get_native_u2(p);
    int pool_index = cp_cache_entry_pool_index(cache_index);
    Bytes::put_Java_u2(p, pool_index);
154
    if (!_method_handle_invokers.is_empty())
155
      maybe_rewrite_invokehandle(p - 1, pool_index, cache_index, reverse);
156 157 158
  }
}

159 160 161 162 163 164
// If the constant pool entry for invokespecial is InterfaceMethodref,
// we need to add a separate cpCache entry for its resolution, because it is
// different than the resolution for invokeinterface with InterfaceMethodref.
// These cannot share cpCache entries.  It's unclear if all invokespecial to
// InterfaceMethodrefs would resolve to the same thing so a new cpCache entry
// is created for each one.  This was added with lambda.
165
void Rewriter::rewrite_invokespecial(address bcp, int offset, bool reverse, bool* invokespecial_error) {
166 167 168
  address p = bcp + offset;
  if (!reverse) {
    int cp_index = Bytes::get_Java_u2(p);
169
    if (_pool->tag_at(cp_index).is_interface_method()) {
170 171
    int cache_index = add_invokespecial_cp_cache_entry(cp_index);
    if (cache_index != (int)(jushort) cache_index) {
172
      *invokespecial_error = true;
173 174 175
    }
    Bytes::put_native_u2(p, cache_index);
  } else {
176 177 178 179
      rewrite_member_reference(bcp, offset, reverse);
    }
  } else {
    rewrite_member_reference(bcp, offset, reverse);
180 181 182
  }
}

183 184

// Adjust the invocation bytecode for a signature-polymorphic method (MethodHandle.invoke, etc.)
185
void Rewriter::maybe_rewrite_invokehandle(address opc, int cp_index, int cache_index, bool reverse) {
186 187 188 189 190 191 192 193 194 195 196 197
  if (!reverse) {
    if ((*opc) == (u1)Bytecodes::_invokevirtual ||
        // allow invokespecial as an alias, although it would be very odd:
        (*opc) == (u1)Bytecodes::_invokespecial) {
      assert(_pool->tag_at(cp_index).is_method(), "wrong index");
      // Determine whether this is a signature-polymorphic method.
      if (cp_index >= _method_handle_invokers.length())  return;
      int status = _method_handle_invokers[cp_index];
      assert(status >= -1 && status <= 1, "oob tri-state");
      if (status == 0) {
        if (_pool->klass_ref_at_noresolve(cp_index) == vmSymbols::java_lang_invoke_MethodHandle() &&
            MethodHandles::is_signature_polymorphic_name(SystemDictionary::MethodHandle_klass(),
198 199
                                                         _pool->name_ref_at(cp_index))) {
          // we may need a resolved_refs entry for the appendix
200
          add_invokedynamic_resolved_references_entries(cp_index, cache_index);
201
          status = +1;
202
        } else {
203
          status = -1;
204
        }
205 206 207 208 209 210 211 212 213 214 215 216 217 218 219 220 221
        _method_handle_invokers[cp_index] = status;
      }
      // We use a special internal bytecode for such methods (if non-static).
      // The basic reason for this is that such methods need an extra "appendix" argument
      // to transmit the call site's intended call type.
      if (status > 0) {
        (*opc) = (u1)Bytecodes::_invokehandle;
      }
    }
  } else {
    // Do not need to look at cp_index.
    if ((*opc) == (u1)Bytecodes::_invokehandle) {
      (*opc) = (u1)Bytecodes::_invokevirtual;
      // Ignore corner case of original _invokespecial instruction.
      // This is safe because (a) the signature polymorphic method was final, and
      // (b) the implementation of MethodHandle will not call invokespecial on it.
    }
222
  }
223 224 225
}


226
void Rewriter::rewrite_invokedynamic(address bcp, int offset, bool reverse) {
227
  address p = bcp + offset;
228 229 230
  assert(p[-1] == Bytecodes::_invokedynamic, "not invokedynamic bytecode");
  if (!reverse) {
    int cp_index = Bytes::get_Java_u2(p);
231
    int cache_index = add_invokedynamic_cp_cache_entry(cp_index);
232
    int resolved_index = add_invokedynamic_resolved_references_entries(cp_index, cache_index);
233 234 235 236 237 238 239 240 241
    // Replace the trailing four bytes with a CPC index for the dynamic
    // call site.  Unlike other CPC entries, there is one per bytecode,
    // not just one per distinct CP entry.  In other words, the
    // CPC-to-CP relation is many-to-one for invokedynamic entries.
    // This means we must use a larger index size than u2 to address
    // all these entries.  That is the main reason invokedynamic
    // must have a five-byte instruction format.  (Of course, other JVM
    // implementations can use the bytes for other purposes.)
    // Note: We use native_u4 format exclusively for 4-byte indexes.
242 243 244 245 246
    Bytes::put_native_u4(p, ConstantPool::encode_invokedynamic_index(cache_index));
    // add the bcp in case we need to patch this bytecode if we also find a
    // invokespecial/InterfaceMethodref in the bytecode stream
    _patch_invokedynamic_bcps->push(p);
    _patch_invokedynamic_refs->push(resolved_index);
247
  } else {
248
    int cache_index = ConstantPool::decode_invokedynamic_index(
249
                        Bytes::get_native_u4(p));
250 251 252
    // We will reverse the bytecode rewriting _after_ adjusting them.
    // Adjust the cache index by offset to the invokedynamic entries in the
    // cpCache plus the delta if the invokedynamic bytecodes were adjusted.
253 254
    int adjustment = cp_cache_delta() + _first_iteration_cp_cache_limit;
    int cp_index = invokedynamic_cp_cache_entry_pool_index(cache_index - adjustment);
255
    assert(_pool->tag_at(cp_index).is_invoke_dynamic(), "wrong index");
256 257
    // zero out 4 bytes
    Bytes::put_Java_u4(p, 0);
258
    Bytes::put_Java_u2(p, cp_index);
259
  }
260 261
}

262 263 264 265 266 267 268 269 270 271 272 273 274 275 276 277 278 279 280 281 282 283 284 285 286 287 288 289
void Rewriter::patch_invokedynamic_bytecodes() {
  // If the end of the cp_cache is the same as after initializing with the
  // cpool, nothing needs to be done.  Invokedynamic bytecodes are at the
  // correct offsets. ie. no invokespecials added
  int delta = cp_cache_delta();
  if (delta > 0) {
    int length = _patch_invokedynamic_bcps->length();
    assert(length == _patch_invokedynamic_refs->length(),
           "lengths should match");
    for (int i = 0; i < length; i++) {
      address p = _patch_invokedynamic_bcps->at(i);
      int cache_index = ConstantPool::decode_invokedynamic_index(
                          Bytes::get_native_u4(p));
      Bytes::put_native_u4(p, ConstantPool::encode_invokedynamic_index(cache_index + delta));

      // invokedynamic resolved references map also points to cp cache and must
      // add delta to each.
      int resolved_index = _patch_invokedynamic_refs->at(i);
      for (int entry = 0; entry < ConstantPoolCacheEntry::_indy_resolved_references_entries; entry++) {
        assert(_invokedynamic_references_map[resolved_index+entry] == cache_index,
             "should be the same index");
        _invokedynamic_references_map.at_put(resolved_index+entry,
                                             cache_index + delta);
      }
    }
  }
}

290

291
// Rewrite some ldc bytecodes to _fast_aldc
292 293 294 295 296 297 298
void Rewriter::maybe_rewrite_ldc(address bcp, int offset, bool is_wide,
                                 bool reverse) {
  if (!reverse) {
    assert((*bcp) == (is_wide ? Bytecodes::_ldc_w : Bytecodes::_ldc), "not ldc bytecode");
    address p = bcp + offset;
    int cp_index = is_wide ? Bytes::get_Java_u2(p) : (u1)(*p);
    constantTag tag = _pool->tag_at(cp_index).value();
299
    if (tag.is_method_handle() || tag.is_method_type() || tag.is_string()) {
300
      int ref_index = cp_entry_to_resolved_references(cp_index);
301 302
      if (is_wide) {
        (*bcp) = Bytecodes::_fast_aldc_w;
303 304
        assert(ref_index == (u2)ref_index, "index overflow");
        Bytes::put_native_u2(p, ref_index);
305 306
      } else {
        (*bcp) = Bytecodes::_fast_aldc;
307 308
        assert(ref_index == (u1)ref_index, "index overflow");
        (*p) = (u1)ref_index;
309 310 311 312 313 314 315
      }
    }
  } else {
    Bytecodes::Code rewritten_bc =
              (is_wide ? Bytecodes::_fast_aldc_w : Bytecodes::_fast_aldc);
    if ((*bcp) == rewritten_bc) {
      address p = bcp + offset;
316 317
      int ref_index = is_wide ? Bytes::get_native_u2(p) : (u1)(*p);
      int pool_index = resolved_references_entry_to_pool_index(ref_index);
318 319 320 321 322 323 324 325 326
      if (is_wide) {
        (*bcp) = Bytecodes::_ldc_w;
        assert(pool_index == (u2)pool_index, "index overflow");
        Bytes::put_Java_u2(p, pool_index);
      } else {
        (*bcp) = Bytecodes::_ldc;
        assert(pool_index == (u1)pool_index, "index overflow");
        (*p) = (u1)pool_index;
      }
327 328 329 330 331
    }
  }
}


D
duke 已提交
332
// Rewrites a method given the index_map information
333
void Rewriter::scan_method(Method* method, bool reverse, bool* invokespecial_error) {
D
duke 已提交
334 335 336 337 338 339

  int nof_jsrs = 0;
  bool has_monitor_bytecodes = false;

  {
    // We cannot tolerate a GC in this block, because we've
340
    // cached the bytecodes in 'code_base'. If the Method*
D
duke 已提交
341 342 343 344 345 346 347 348 349 350 351
    // moves, the bytecodes will also move.
    No_Safepoint_Verifier nsv;
    Bytecodes::Code c;

    // Bytecodes and their length
    const address code_base = method->code_base();
    const int code_length = method->code_size();

    int bc_length;
    for (int bci = 0; bci < code_length; bci += bc_length) {
      address bcp = code_base + bci;
352
      int prefix_length = 0;
D
duke 已提交
353 354 355 356 357 358 359 360
      c = (Bytecodes::Code)(*bcp);

      // Since we have the code, see if we can get the length
      // directly. Some more complicated bytecodes will report
      // a length of zero, meaning we need to make another method
      // call to calculate the length.
      bc_length = Bytecodes::length_for(c);
      if (bc_length == 0) {
361
        bc_length = Bytecodes::length_at(method, bcp);
D
duke 已提交
362 363 364 365 366

        // length_at will put us at the bytecode after the one modified
        // by 'wide'. We don't currently examine any of the bytecodes
        // modified by wide, but in case we do in the future...
        if (c == Bytecodes::_wide) {
367
          prefix_length = 1;
D
duke 已提交
368 369 370 371 372 373 374 375 376
          c = (Bytecodes::Code)bcp[1];
        }
      }

      assert(bc_length != 0, "impossible bytecode length");

      switch (c) {
        case Bytecodes::_lookupswitch   : {
#ifndef CC_INTERP
377
          Bytecode_lookupswitch bc(method, bcp);
378
          (*bcp) = (
379
            bc.number_of_pairs() < BinarySwitchThreshold
D
duke 已提交
380 381 382
            ? Bytecodes::_fast_linearswitch
            : Bytecodes::_fast_binaryswitch
          );
383 384 385 386 387 388 389
#endif
          break;
        }
        case Bytecodes::_fast_linearswitch:
        case Bytecodes::_fast_binaryswitch: {
#ifndef CC_INTERP
          (*bcp) = Bytecodes::_lookupswitch;
D
duke 已提交
390 391 392
#endif
          break;
        }
393 394

        case Bytecodes::_invokespecial  : {
395
          rewrite_invokespecial(bcp, prefix_length+1, reverse, invokespecial_error);
396 397 398
          break;
        }

D
duke 已提交
399 400 401 402 403
        case Bytecodes::_getstatic      : // fall through
        case Bytecodes::_putstatic      : // fall through
        case Bytecodes::_getfield       : // fall through
        case Bytecodes::_putfield       : // fall through
        case Bytecodes::_invokevirtual  : // fall through
404 405
        case Bytecodes::_invokestatic   :
        case Bytecodes::_invokeinterface:
406
        case Bytecodes::_invokehandle   : // if reverse=true
407
          rewrite_member_reference(bcp, prefix_length+1, reverse);
408 409
          break;
        case Bytecodes::_invokedynamic:
410
          rewrite_invokedynamic(bcp, prefix_length+1, reverse);
D
duke 已提交
411
          break;
412
        case Bytecodes::_ldc:
413
        case Bytecodes::_fast_aldc:  // if reverse=true
414
          maybe_rewrite_ldc(bcp, prefix_length+1, false, reverse);
415 416
          break;
        case Bytecodes::_ldc_w:
417
        case Bytecodes::_fast_aldc_w:  // if reverse=true
418
          maybe_rewrite_ldc(bcp, prefix_length+1, true, reverse);
419
          break;
D
duke 已提交
420 421 422 423 424 425 426 427 428 429 430 431 432 433 434 435 436
        case Bytecodes::_jsr            : // fall through
        case Bytecodes::_jsr_w          : nof_jsrs++;                   break;
        case Bytecodes::_monitorenter   : // fall through
        case Bytecodes::_monitorexit    : has_monitor_bytecodes = true; break;
      }
    }
  }

  // Update access flags
  if (has_monitor_bytecodes) {
    method->set_has_monitor_bytecodes();
  }

  // The present of a jsr bytecode implies that the method might potentially
  // have to be rewritten, so we run the oopMapGenerator on the method
  if (nof_jsrs > 0) {
    method->set_has_jsrs();
437
    // Second pass will revisit this method.
438
    assert(method->has_jsrs(), "didn't we just set this?");
439 440
  }
}
D
duke 已提交
441

442 443
// After constant pool is created, revisit methods containing jsrs.
methodHandle Rewriter::rewrite_jsrs(methodHandle method, TRAPS) {
444
  ResourceMark rm(THREAD);
445 446 447 448 449 450 451
  ResolveOopMapConflicts romc(method);
  methodHandle original_method = method;
  method = romc.do_potential_rewrite(CHECK_(methodHandle()));
  // Update monitor matching info.
  if (romc.monitor_safe()) {
    method->set_guaranteed_monitor_matching();
  }
D
duke 已提交
452 453 454 455

  return method;
}

456
void Rewriter::rewrite_bytecodes(TRAPS) {
457
  assert(_pool->cache() == NULL, "constant pool cache must not be set yet");
D
duke 已提交
458

459
  // determine index maps for Method* rewriting
460
  compute_index_maps();
D
duke 已提交
461

462
  if (RegisterFinalizersAtInit && _klass->name() == vmSymbols::java_lang_Object()) {
463
    bool did_rewrite = false;
464
    int i = _methods->length();
D
duke 已提交
465
    while (i-- > 0) {
466
      Method* method = _methods->at(i);
D
duke 已提交
467 468 469 470 471
      if (method->intrinsic_id() == vmIntrinsics::_Object_init) {
        // rewrite the return bytecodes of Object.<init> to register the
        // object for finalization if needed.
        methodHandle m(THREAD, method);
        rewrite_Object_init(m, CHECK);
472
        did_rewrite = true;
D
duke 已提交
473 474 475
        break;
      }
    }
476
    assert(did_rewrite, "must find Object::<init> to rewrite it");
D
duke 已提交
477 478
  }

479
  // rewrite methods, in two passes
480
  int len = _methods->length();
481
  bool invokespecial_error = false;
482

483
  for (int i = len-1; i >= 0; i--) {
484
    Method* method = _methods->at(i);
485 486 487 488 489 490 491 492 493 494
    scan_method(method, false, &invokespecial_error);
    if (invokespecial_error) {
      // If you get an error here, there is no reversing bytecodes
      // This exception is stored for this class and no further attempt is
      // made at verifying or rewriting.
      THROW_MSG(vmSymbols::java_lang_InternalError(),
                "This classfile overflows invokespecial for interfaces "
                "and cannot be loaded");
      return;
     }
495 496
  }

497 498 499
  // May have to fix invokedynamic bytecodes if invokestatic/InterfaceMethodref
  // entries had to be added.
  patch_invokedynamic_bytecodes();
500 501 502 503 504 505 506 507 508 509 510 511 512 513 514 515 516 517 518 519 520 521 522
}

void Rewriter::rewrite(instanceKlassHandle klass, TRAPS) {
  ResourceMark rm(THREAD);
  Rewriter     rw(klass, klass->constants(), klass->methods(), CHECK);
  // (That's all, folks.)
}


Rewriter::Rewriter(instanceKlassHandle klass, constantPoolHandle cpool, Array<Method*>* methods, TRAPS)
  : _klass(klass),
    _pool(cpool),
    _methods(methods)
{

  // Rewrite bytecodes - exception here exits.
  rewrite_bytecodes(CHECK);

  // Stress restoring bytecodes
  if (StressRewriter) {
    restore_bytecodes();
    rewrite_bytecodes(CHECK);
  }
523

524
  // allocate constant pool cache, now that we've seen all the bytecodes
525 526 527 528 529
  make_constant_pool_cache(THREAD);

  // Restore bytecodes to their unrewritten state if there are exceptions
  // rewriting bytecodes or allocating the cpCache
  if (HAS_PENDING_EXCEPTION) {
530
    restore_bytecodes();
531 532 533
    return;
  }

534 535 536 537
  // Relocate after everything, but still do this under the is_rewritten flag,
  // so methods with jsrs in custom class lists in aren't attempted to be
  // rewritten in the RO section of the shared archive.
  // Relocated bytecodes don't have to be restored, only the cp cache entries
538
  int len = _methods->length();
539
  for (int i = len-1; i >= 0; i--) {
540
    methodHandle m(THREAD, _methods->at(i));
541 542

    if (m->has_jsrs()) {
543 544 545 546 547
      m = rewrite_jsrs(m, THREAD);
      // Restore bytecodes to their unrewritten state if there are exceptions
      // relocating bytecodes.  If some are relocated, that is ok because that
      // doesn't affect constant pool to cpCache rewriting.
      if (HAS_PENDING_EXCEPTION) {
548
        restore_bytecodes();
549 550
        return;
      }
D
duke 已提交
551
      // Method might have gotten rewritten.
552
      methods->at_put(i, m());
D
duke 已提交
553 554 555
    }
  }
}