1. 20 9月, 2009 16 次提交
  2. 19 9月, 2009 22 次提交
  3. 18 9月, 2009 2 次提交
    • L
      pty_write: don't do a tty_wakeup() when the buffers are full · 202c4675
      Linus Torvalds 提交于
      Commit ac89a917 ("pty: don't limit the writes to 'pty_space()' inside
      'pty_write()'") removed the pty_space() checking, in order to let the
      regular tty buffer code limit the buffering itself.
      
      That was all good, but as a subtle side effect it meant that we'd be
      doing a tty_wakeup() even in the case where the buffers were all filled
      up, and didn't actually make any progress on the write.
      
      Which sounds innocuous, but it interacts very badly with the ppp_async
      code, which has an infinite loop in ppp_async_push() that tries to push
      out data to the tty.  When we call tty_wakeup(), that loop ends up
      thinking that progress was made (see the subtle interactions between
      XMIT_WAKEUP and 'tty_stuffed' for details).  End result: one unhappy ppp
      user.
      
      Fixed by noticing when tty_insert_flip_string() didn't actually do
      anything, and then not doing any more processing (including, very much
      not calling tty_wakeup()).
      Bisected-and-tested-by: NPeter Volkov <pva@gentoo.org>
      Cc: stable@kernel.org (2.6.31)
      Signed-off-by: NLinus Torvalds <torvalds@linux-foundation.org>
      202c4675
    • W
      [WATCHDOG] sizeof cleanup · e04ab958
      Wim Van Sebroeck 提交于
      Use sizeof(*) instead of sizeof * (See Codingstyle documentation).
      Signed-off-by: NWim Van Sebroeck <wim@iguana.be>
      e04ab958