- 23 3月, 2014 29 次提交
-
-
由 Sean Paul 提交于
This creates a new display hook called create_connector. The purpose is to allow the display driver to create its own drm_connector instead of using the exynos_drm_connector. This moves things closer to completely removing the exynos_drm_connector abstraction. Signed-off-by: NSean Paul <seanpaul@chromium.org> Signed-off-by: NInki Dae <inki.dae@samsung.com>
-
由 Sean Paul 提交于
This patch removes all of the suspend/resume logic from the individual drivers and consolidates it in drm_drv. This consolidation reduces the number of functions which enable/disable the hardware to just one -- the dpms callback. This ensures that we always power up/down in a consistent manner. Signed-off-by: NSean Paul <seanpaul@chromium.org> Signed-off-by: NInki Dae <inki.dae@samsung.com>
-
由 Sean Paul 提交于
This patch separates the fimd_activate function into poweron/poweroff functions to be more consistent with the other drivers in exynos drm. It also properly cleans up after failures in poweron. The functions have also been shuffled around such that they are all in the same spot in the file and poweron/poweroff can be called from the dpms function. Signed-off-by: NSean Paul <seanpaul@chromium.org> Signed-off-by: NInki Dae <inki.dae@samsung.com>
-
由 Sean Paul 提交于
This patch implements the dpms display callback for the DP driver. Signed-off-by: NSean Paul <seanpaul@chromium.org> Signed-off-by: NInki Dae <inki.dae@samsung.com>
-
由 Sean Paul 提交于
This patch moves the exynos_drm_display implementation from fimd into the dp driver. This will allow for tighter integration of the dp driver into the exynos drm driver. Signed-off-by: NSean Paul <seanpaul@chromium.org> Signed-off-by: NInki Dae <inki.dae@samsung.com>
-
由 Sean Paul 提交于
This patch moves the code from video/ to drm/. This is required the DP driver needs to power on/off in the correct order in relation to fimd. This will also allow the DP driver to participate in drm modeset as well as provide accurate connection detection and edid. Signed-off-by: NSean Paul <seanpaul@chromium.org> Signed-off-by: NInki Dae <inki.dae@samsung.com>
-
由 Sean Paul 提交于
This patch removes a few fimd_context members which are either entirely unused or unneeded. Signed-off-by: NSean Paul <seanpaul@chromium.org> Signed-off-by: NInki Dae <inki.dae@samsung.com>
-
由 Sean Paul 提交于
This patch uses the mode passed into mode_set to configure fimd instead of directly using the panel from context. This will allow us to move the exynos_drm_display implementation out of fimd, where it doesn't belong. Signed-off-by: NSean Paul <seanpaul@chromium.org> Signed-off-by: NInki Dae <inki.dae@samsung.com>
-
由 Sean Paul 提交于
This patch adds a new manager callback for mode_fixup and pipes it through exynos_drm_crtc. This will allow the manager drivers to alter the mode during modeset. Signed-off-by: NSean Paul <seanpaul@chromium.org> Signed-off-by: NInki Dae <inki.dae@samsung.com>
-
由 Sean Paul 提交于
This patch adds a mode_set callback to the manager operations which sets the crtc's current mode to the manager driver. This will allow the fimd driver to set its mode using values from drm, instead of the dt. Signed-off-by: NSean Paul <seanpaul@chromium.org> Signed-off-by: NInki Dae <inki.dae@samsung.com>
-
由 Sean Paul 提交于
This patch moves the code which disables unused crtc planes from the encoder to the crtc. Since there is a 1:1 encoder/crtc mapping in exynos, the only valid crtc change the pre-existing code could catch is disconnecting an active crtc from the encoder. Thus it is functionally equivalent to just disable all planes attached to a crtc when the crtc is disabled. Signed-off-by: NSean Paul <seanpaul@chromium.org> Signed-off-by: NInki Dae <inki.dae@samsung.com>
-
由 Sean Paul 提交于
This patch changes the manual copying of mode to adjusted_mode in mode_fixup to use drm_mode_copy instead of handling things manually. Signed-off-by: NSean Paul <seanpaul@chromium.org> Signed-off-by: NInki Dae <inki.dae@samsung.com>
-
由 Sean Paul 提交于
This patch trims exynos_drm_hdmi out of the driver. The reason it existed in the first place was to make up for the mixture of display/overlay/manager ops being spread across hdmi and mixer. With that code now rationalized, mixer and hdmi map directly to exynos_drm_crtc and exynos_drm_encoder, respectively. Since there is a 1:1 mapping, we no longer need this layer. Signed-off-by: NSean Paul <seanpaul@chromium.org> Signed-off-by: NInki Dae <inki.dae@samsung.com>
-
由 Daniel Kurtz 提交于
The i2c client was previously being passed into the hdmi driver via a dedicated i2c driver, and then a global variable. This patch removes all of that and just uses the device tree to get the i2c_client. This patch also properly references the client so we don't lose it before we're done with it. Signed-off-by: NDaniel Kurtz <djkurtz@chromium.org> [seanpaul changed to phandle lookup instead of using of node name] Signed-off-by: NSean Paul <seanpaul@chromium.org> Signed-off-by: NInki Dae <inki.dae@samsung.com>
-
由 Sean Paul 提交于
This patch splits display and manager from subdrv. The result is that crtc functions can directly call into manager callbacks and encoder functions can directly call into display callbacks. This will allow us to remove the exynos_drm_hdmi shim and support mixer/hdmi & fimd/dp with common code. Signed-off-by: NSean Paul <seanpaul@chromium.org> Signed-off-by: NInki Dae <inki.dae@samsung.com>
-
由 Sean Paul 提交于
Change all instances of possible_crtcs in the exynos drm driver to be unsigned long. This matches the type used in the drm layer. Signed-off-by: NSean Paul <seanpaul@chromium.org> Reviewed-by: NTomasz Figa <t.figa@samsung.com> Signed-off-by: NInki Dae <inki.dae@samsung.com>
-
由 Sean Paul 提交于
This patch removes the dpms state tracking in encoder. This state is at best confusing and at worst incorrect since the display drivers can turn on and off without propagating the value. Signed-off-by: NSean Paul <seanpaul@chromium.org> Reviewed-by: NTomasz Figa <t.figa@samsung.com> Signed-off-by: NInki Dae <inki.dae@samsung.com>
-
由 Sean Paul 提交于
This patch renames the display_op power_on to dpms to accurately reflect what the function does. The side-effect of this patch is that the new hdmi dpms callback is now invoked twice in the dpms path. This is safe and will be dealt with when the exynos_drm shim goes away. Signed-off-by: NSean Paul <seanpaul@chromium.org> Reviewed-by: NTomasz Figa <t.figa@samsung.com> Signed-off-by: NInki Dae <inki.dae@samsung.com>
-
由 Sean Paul 提交于
This patch removes the call from encoder dpms into connector dpms (which will then call back into encoder dpms through the helper function). The callback is likely to keep connector->dpms in the right state when initiating dpms from crtc or encoder, but this isn't the right way to do it. This patch is the first step towards rationalizing power management in the exynos drm driver. Signed-off-by: NSean Paul <seanpaul@chromium.org> Reviewed-by: NTomasz Figa <t.figa@samsung.com> Signed-off-by: NInki Dae <inki.dae@samsung.com>
-
由 Sean Paul 提交于
This patch removes the apply() manager callback in favor of putting the relevant commits in the individual drivers. This will mitigate some of the difference between the suspend/resume path and the dpms path Signed-off-by: NSean Paul <seanpaul@chromium.org> Reviewed-by: NTomasz Figa <t.figa@samsung.com> Signed-off-by: NInki Dae <inki.dae@samsung.com>
-
由 Sean Paul 提交于
This patch changes the manager ops callbacks from accepting the subdrv device pointer to taking a pointer to the manager. This will allow us to move closer to decoupling manager/display from subdrv, and subsequently decoupling the crtc/plane from the encoder. Signed-off-by: NSean Paul <seanpaul@chromium.org> Signed-off-by: NInki Dae <inki.dae@samsung.com>
-
由 Sean Paul 提交于
This patch implements the initialize callback in the hdmi and mixer manager. This allows us to get rid of drm_dev in the drm_hdmi level and track it in the mixer and hdmi drivers. This is one of the things holding back the complete removal of the drm_hdmi layer. Signed-off-by: NSean Paul <seanpaul@chromium.org> Signed-off-by: NInki Dae <inki.dae@samsung.com>
-
由 Sean Paul 提交于
This patch implements the intitialize manager op in fimd. This will allow us to keep track of drm_dev in context instead of using subdev, which in turn makes it easier to remove subdev from fimd. Signed-off-by: NSean Paul <seanpaul@chromium.org> Signed-off-by: NInki Dae <inki.dae@samsung.com>
-
由 Sean Paul 提交于
This patch adds an initialize function to the manager and display operations. This allows them to keep track of drm_device in their local context, as well as adds an initialization hook right after the encoder is created. Signed-off-by: NSean Paul <seanpaul@chromium.org> Reviewed-by: NTomasz Figa <t.figa@samsung.com> Signed-off-by: NInki Dae <inki.dae@samsung.com>
-
由 Sean Paul 提交于
This patch merges overlay_ops into manager_ops. In all cases, overlay_ops is implemented in the same place as manager ops, it doesn't serve a functional purpose, and doesn't make things more clear. Signed-off-by: NSean Paul <seanpaul@chromium.org> Signed-off-by: NInki Dae <inki.dae@samsung.com>
-
由 Stephane Marchesin 提交于
Signed-off-by: NStephane Marchesin <marcheu@chromium.org> Signed-off-by: NSean Paul <seanpaul@chromium.org> Signed-off-by: NInki Dae <inki.dae@samsung.com>
-
由 Shirish S 提交于
Now that the drm_display_mode also provides aspect ratio for all resolutions, this patch adds its usage to set the active aspect ratio of AVI info frame packets as per CEA-861-D standard's Table 9. This is also needed to abide by the 7-27 compliance test of HDMI. Signed-off-by: NShirish S <s.shirish@samsung.com> Reviewed-by: NTomasz Figa <t.figa@samsung.com> Signed-off-by: NInki Dae <inki.dae@samsung.com>
-
由 Shirish S 提交于
This patch adds support for the below mentioned pixel clocks in Exynos5250. Without them, following display modes won¡¯t be supported: 71 MHz - 1280x800@60Hz RB 73.25 MHz - 800x600@120Hz RB 88.75 MHz - 1440x900@60Hz RB 115.5 MHz - 1024x768@120Hz RB 119 MHz - 1680x1050@60Hz RB Signed-off-by: NShirish S <s.shirish@samsung.com> Reviewed-by: NTomasz Figa <t.figa@samsung.com> Signed-off-by: NInki Dae <inki.dae@samsung.com>
-
由 Daniel Kurtz 提交于
The following commit [0] fixed a use-after-free, but left the subdrv open in the error path. [0] commit 6ca605f7 drm/exynos: Fix freeing issues in exynos_drm_drv.c Signed-off-by: NDaniel Kurtz <djkurtz@chromium.org> Acked-by: NSachin Kamat <sachin.kamat@linaro.org> Signed-off-by: NInki Dae <inki.dae@samsung.com>
-
- 22 3月, 2014 3 次提交
-
-
由 Dave Airlie 提交于
Since Daniel documented things with a sledge hammer, we got lots of nice backtraces in suspend/resume operations, I've check the callers of this and they all seems safe to me, This fixes one set of warns I reported. Reviewed-by: NDaniel Vetter <daniel.vetter@ffwll.ch> Signed-off-by: NDave Airlie <airlied@redhat.com>
-
由 Daniel Vetter 提交于
The locking in drm_fb_helper_initial_config is a bit troublesome for a few reasons: - We can't just wrap the entire function up into modeset locks since the fbdev registration might call down into fbcon code, which then through our ->set_par implementation needs to be able to grab all modeset locks. So we'd have a neat deadlock. - This implies though that all current callers don't hold any modeset locks by necessity, so we have free reign to grab any modeset locks we need to grab. - The private state of the fbdev helper doesn't need any protection through locks, since once we have the fbdev registered it is mostly invariant or protected through the modeset locking in ->set_par and other callbacks. We can fully rely on driver having non-racy setup sequences here. For the initial config computation we actually may not grab locks since drivers which provide their own magic sauce (like i915) might need to grab locks themselves. - We should grab locks though when we probe outputs. Currently there's not much risk, but already now userspace could start poking at sysfs files and so probe concurrently. I expect that in the future driver init will be much more async, and since probing is really time-consuming this is a prime candidate. - We must not hold any crtc->mutex locks while calling probe functions since those might need to lock a crtc for e.g. load detection. i915 is such a driver. Also it's the probing calls which hit upon piles of new locking asserts I've recently added in commit 62ff94a5 Author: Daniel Vetter <daniel.vetter@ffwll.ch> Date: Thu Jan 23 22:18:47 2014 +0100 drm/crtc-helper: remove LOCKING from kerneldoc and commit 63951385 Author: Daniel Vetter <daniel.vetter@ffwll.ch> Date: Thu Jan 23 15:14:15 2014 +0100 drm/doc: Repleace LOCKING kerneldoc sections in drm_modes.c Hence the right fix is to grab the mode_config mutex, but only that and only right around the probe calls. It seems to be sufficient to shut up all the locking WARNINGs I see on i915 and nouveau in drm_fb_helper_initial_config. Signed-off-by: NDaniel Vetter <daniel.vetter@ffwll.ch> Tested-by: NThierry Reding <treding@nvidia.com> Signed-off-by: NDave Airlie <airlied@redhat.com>
-
由 Daniel Vetter 提交于
We have two calling contexts for thise function: - In the crtc helper code itself as part of the ->set_config implementation. In this calling context all modeset locks are already held, as they should. - In drivers not implementing fastboot before the fbdev/fbcon setup and initialization. This has been added for all drivers in commit 76a39dbf Author: Daniel Vetter <daniel.vetter@ffwll.ch> Date: Sun Jan 20 23:12:54 2013 +0100 drm/fb-helper: don't disable everything in initial_config In this calling context we do not hold any modeset locks since the immediately following call to initialize the fbev emulation grabs all these locks themselves. - There are two exceptions to the above rule: shmob doesn't have fbdev emulation support. I've manually checked the callchain up to the driver load function and no kms locks are held. The right fix therefore is to split this helper into an internal and external version and add the required locking to the function exported to drivers. This remedies locking inconsistencies exposed by me adding locking WARNs as part of the recent kerneldoc abi polishing done in commit 62ff94a5 Author: Daniel Vetter <daniel.vetter@ffwll.ch> Date: Thu Jan 23 22:18:47 2014 +0100 drm/crtc-helper: remove LOCKING from kerneldoc and commit 63951385 Author: Daniel Vetter <daniel.vetter@ffwll.ch> Date: Thu Jan 23 15:14:15 2014 +0100 drm/doc: Repleace LOCKING kerneldoc sections in drm_modes.c v2: It helps when I actually git add the entire thing. Cc: Chris Wilson <chris@chris-wilson.co.uk> Signed-off-by: NDaniel Vetter <daniel.vetter@ffwll.ch> Reviewed-by: NChris Wilson <chris@chris-wilson.co.uk> Tested-by: NThierry Reding <treding@nvidia.com> Signed-off-by: NDave Airlie <airlied@redhat.com>
-
- 20 3月, 2014 1 次提交
-
-
由 Dave Airlie 提交于
Not sure why git didn't flag this, but the result of automerge from 3.14-rc7 screwed up the radeon init procedure. Reported-by: Fireburn on #radeon Signed-off-by: NDave Airlie <airlied@redhat.com>
-
- 18 3月, 2014 7 次提交
-
-
由 Joonyoung Shim 提交于
The sg_table made when gem cma is created isn't used anywhere. The sgt of struct drm_gem_cma_object will have only sg_tabel imported. Signed-off-by: NJoonyoung Shim <jy0922.shim@samsung.com> Acked-by: NLaurent Pinchart <laurent.pinchart@ideasonboard.com> Signed-off-by: NDave Airlie <airlied@redhat.com>
-
由 David Herrmann 提交于
These are unused and can safely be dropped. DRM core verifies they're non-NULL before it calls them. Cc: Patrik Jakobsson <patrik.r.jakobsson@gmail.com> Signed-off-by: NDavid Herrmann <dh.herrmann@gmail.com> Signed-off-by: NPatrik Jakobsson <patrik.r.jakobsson@gmail.com>
-
由 Arthur Borsboom 提交于
Improve readability by adding/changing inline documentation Signed-off-by: NArthur Borsboom <arthurborsboom@gmail.com> Signed-off-by: NPatrik Jakobsson <patrik.r.jakobsson@gmail.com>
-
由 Arthur Borsboom 提交于
Code cleanup by following i915 constant/variable names and ordering Code cleanup by following directions from kernel doc: Codingstyle Code cleanup by following directions from kernel doc: DRM Signed-off-by: NArthur Borsboom <arthurborsboom@gmail.com> Signed-off-by: NPatrik Jakobsson <patrik.r.jakobsson@gmail.com>
-
由 Arthur Borsboom 提交于
Removed centralized exiting of function (goto statement), since it was the only used in one single location with only a return statement. Signed-off-by: NArthur Borsboom <arthurborsboom@gmail.com> Signed-off-by: NPatrik Jakobsson <patrik.r.jakobsson@gmail.com>
-
由 Patrik Jakobsson 提交于
Signed-off-by: NPatrik Jakobsson <patrik.r.jakobsson@gmail.com>
-
由 Patrik Jakobsson 提交于
Signed-off-by: NPatrik Jakobsson <patrik.r.jakobsson@gmail.com>
-