1. 19 4月, 2016 1 次提交
    • I
      drm/i915/ddi: Fix eDP VDD handling during booting and suspend/resume · bf93ba67
      Imre Deak 提交于
      The driver's VDD on/off logic assumes that whenever the VDD is on we
      also hold an AUX power domain reference. Since BIOS can leave the VDD on
      during booting and resuming and on DDI platforms we won't take a
      corresponding power reference, the above assumption won't hold on those
      platforms and an eventual delayed VDD off work will do an extraneous AUX
      power domain put resulting in a refcount underflow. Fix this the same
      way we did this for non-DDI DP encoders:
      
      commit 6d93c0c4 ("drm/i915: fix VDD state tracking after system
      resume")
      
      At the same time call the DP encoder suspend handler the same way as the
      non-DDI DP encoders do to flush any pending VDD off work. Leaving the
      work running may cause a HW access where we don't expect this (at a point
      where power domains are suspended already).
      
      While at it remove an unnecessary function call indirection.
      
      This fixed for me AUX refcount underflow problems on BXT during
      suspend/resume.
      
      CC: Ville Syrjälä <ville.syrjala@linux.intel.com>
      CC: stable@vger.kernel.org
      Signed-off-by: NImre Deak <imre.deak@intel.com>
      Reviewed-by: NVille Syrjälä <ville.syrjala@linux.intel.com>
      Link: http://patchwork.freedesktop.org/patch/msgid/1460963062-13211-4-git-send-email-imre.deak@intel.com
      bf93ba67
  2. 15 4月, 2016 1 次提交
  3. 13 4月, 2016 2 次提交
  4. 01 4月, 2016 5 次提交
  5. 29 3月, 2016 2 次提交
  6. 17 3月, 2016 1 次提交
  7. 16 3月, 2016 1 次提交
  8. 09 3月, 2016 2 次提交
  9. 08 3月, 2016 1 次提交
  10. 07 3月, 2016 1 次提交
  11. 04 3月, 2016 5 次提交
  12. 01 3月, 2016 1 次提交
  13. 22 2月, 2016 1 次提交
  14. 17 2月, 2016 2 次提交
  15. 16 2月, 2016 2 次提交
  16. 15 2月, 2016 1 次提交
  17. 13 2月, 2016 1 次提交
  18. 11 2月, 2016 1 次提交
  19. 03 2月, 2016 1 次提交
  20. 30 1月, 2016 1 次提交
  21. 20 1月, 2016 1 次提交
  22. 14 1月, 2016 1 次提交
  23. 12 1月, 2016 1 次提交
  24. 16 12月, 2015 1 次提交
  25. 11 12月, 2015 2 次提交
    • V
      drm: Pass 'name' to drm_encoder_init() · 13a3d91f
      Ville Syrjälä 提交于
      Done with coccinelle for the most part. However, it thinks '...' is
      part of the semantic patch, so I put an 'int DOTDOTDOT' placeholder
      in its place and got rid of it with sed afterwards.
      
      @@
      identifier dev, encoder, funcs;
      @@
       int drm_encoder_init(struct drm_device *dev,
                            struct drm_encoder *encoder,
                            const struct drm_encoder_funcs *funcs,
                            int encoder_type
      +                     ,const char *name, int DOTDOTDOT
                            )
      { ... }
      
      @@
      identifier dev, encoder, funcs;
      @@
       int drm_encoder_init(struct drm_device *dev,
                            struct drm_encoder *encoder,
                            const struct drm_encoder_funcs *funcs,
                            int encoder_type
      +                     ,const char *name, int DOTDOTDOT
                            );
      
      @@
      expression E1, E2, E3, E4;
      @@
       drm_encoder_init(E1, E2, E3, E4
      +                 ,NULL
                        )
      
      v2: Add ', or NULL...' to @name kernel doc (Jani)
          Annotate the function with __printf() attribute (Jani)
      Signed-off-by: NVille Syrjälä <ville.syrjala@linux.intel.com>
      Signed-off-by: NDaniel Vetter <daniel.vetter@ffwll.ch>
      Link: http://patchwork.freedesktop.org/patch/msgid/1449670818-2966-1-git-send-email-ville.syrjala@linux.intel.com
      13a3d91f
    • R
      drm/i915: Fix random aux transactions failures. · 14e01889
      Rodrigo Vivi 提交于
      Mainly aux communications on sink_crc
      were failing a lot randomly on recent platforms.
      The first solution was to try to use intel_dp_dpcd_read_wake, but then
      it was suggested to move retries to drm level.
      
      Since drm level was already taking care of retries and didn't want
      to through random retries on that level the second solution was to
      put the retries at aux_transfer layer what was nacked.
      
      So I realized we had so many retries in different places and
      started to organize that a bit. During this organization I noticed
      that we weren't handing at all the case were the message size was
      zeroed. And this was exactly the case that was affecting sink_crc.
      
      Also we weren't respect BSPec who says this size message = 0 or > 20
      are forbidden.
      
      It is a fact that we still have no clue why we are getting this
      forbidden value there. But anyway we need to handle that for now
      so we return -EBUSY and drm level takes care of the retries that
      are already in place.
      
      v2: Print debug messsage when this case is reached as suggested
          by Jani.
      v3: This patch is crucial to make PSR test cases reliably working
          on SKL. So split this patch from the aux re-org series and add
          a FIXME as a promisse to continue that effort besides reminding
          to remove the sleep when that is merged.
      v4: Use a bigger usleep range so kernel doesn't need to be interrupted
          on a exact time, as suggested by Paulo.
          But anyway we should discuss the better time
          ranges on the EBUSY handle re-org at drm level since this one here
          is temporary.
      v5: s/1000,1500/1000, 1500/ (by Paulo).
      
      Cc: Paulo Zanoni <paulo.r.zanoni@intel.com>
      Cc: Jani Nikula <jani.nikula@intel.com>
      Cc: Daniel Vetter <daniel.vetter@ffwll.ch>
      Signed-off-by: NRodrigo Vivi <rodrigo.vivi@intel.com>
      Tested-by: Daniel Stone <daniels@collabora.com> # SKL
      Signed-off-by: NRodrigo Vivi <rodrigo.vivi@intel.com>
      Reviewed-by: NPaulo Zanoni <paulo.r.zanoni@intel.com>
      Link: http://patchwork.freedesktop.org/patch/msgid/1449774747-2772-1-git-send-email-rodrigo.vivi@intel.com
      14e01889
  26. 10 12月, 2015 1 次提交
    • T
      drm/i915: Add reverse mapping between port and intel_encoder · 0bdf5a05
      Takashi Iwai 提交于
      This patch adds a reverse mapping from a digital port number to
      intel_encoder object containing the corresponding intel_digital_port.
      It simplifies the query of the encoder a lot.
      
      Note that, even if it's a valid digital port, the dig_port_map[] might
      point still to NULL -- usually it implies a DP MST port.  Due to this
      fact, the NULL check in each place has no WARN_ON() and just skips the
      port.  Once when the situation changes in future, we might introduce
      WARN_ON() for a more strict check.
      Signed-off-by: NTakashi Iwai <tiwai@suse.de>
      0bdf5a05