1. 04 11月, 2008 1 次提交
  2. 25 9月, 2008 1 次提交
    • M
      [netdrvr] atl1e: Don't take the mdio_lock in atl1e_probe · f382a0a8
      Matthew Wilcox 提交于
      Lockdep warns about the mdio_lock taken with interrupts enabled then later
      taken from interrupt context.  Initially, I considered changing these
      to spin_lock_irq/spin_unlock_irq, but then I looked at atl1e_phy_init()
      and saw that it calls msleep().  Sleeping while holding a spinlock is
      not allowed either.
      
      In the probe path, we haven't registered the interrupt handler, so
      it can't poke at this card yet.  It's before we call register_netdev(),
      so I don't think any other threads can reach this card either.  If I'm
      right, we don't need a spinlock at all.
      Signed-off-by: NMatthew Wilcox <willy@linux.intel.com>
      Signed-off-by: NJeff Garzik <jgarzik@redhat.com>
      f382a0a8
  3. 27 8月, 2008 1 次提交
  4. 14 8月, 2008 1 次提交
    • A
      [netdrvr] uninline atl1e_setup_mac_ctrl() · 1595ab5d
      Adrian Bunk 提交于
      There doesn't seem to be a compelling reason why atl1e_setup_mac_ctrl()
      is marked as "inline":
      
      It's not used in any place where speed would matter much, and as long as
      it has only one caller non-ancient gcc versions anyway inline it
      automatically.
      
      This patch fixes the following compile error with gcc 3.4:
      
      <--  snip  -->
      
      ...
        CC      drivers/net/atl1e/atl1e_main.o
      atl1e_main.c: In function `atl1e_check_link':
      atl1e_main.c:50: sorry, unimplemented: inlining failed in call to
      atl1e_main.c:196: sorry, unimplemented: called from here
      make[4]: *** [drivers/net/atl1e/atl1e_main.o] Error 1
      
      <--  snip  -->
      Reported-by: NAdrian Bunk <bunk@kernel.org>
      Signed-off-by: NAdrian Bunk <bunk@kernel.org>
      Signed-off-by: NJeff Garzik <jgarzik@redhat.com>
      1595ab5d
  5. 10 8月, 2008 1 次提交
    • A
      uninline atl1e_setup_mac_ctrl() · e6ca2328
      Adrian Bunk 提交于
      There doesn't seem to be a compelling reason why atl1e_setup_mac_ctrl()
      is marked as "inline":
      
      It's not used in any place where speed would matter much, and as long as
      it has only one caller non-ancient gcc versions anyway inline it
      automatically.
      
      This patch fixes the following compile error with gcc 3.4:
      
          CC      drivers/net/atl1e/atl1e_main.o
        atl1e_main.c: In function `atl1e_check_link':
        atl1e_main.c:50: sorry, unimplemented: inlining failed in call to
        atl1e_main.c:196: sorry, unimplemented: called from here
      Reported-by: NAdrian Bunk <bunk@kernel.org>
      Signed-off-by: NAdrian Bunk <bunk@kernel.org>
      Signed-off-by: NLinus Torvalds <torvalds@linux-foundation.org>
      e6ca2328
  6. 23 7月, 2008 2 次提交
新手
引导
客服 返回
顶部