Commit 63779436 ("drivers: replace NIPQUAD()") accidentally replaced
some HIPQUAD()s, causing IP addresses to be printed in reverse order.
Add temporary local vars until the byteswapping can be pushed further
up the stack.
Signed-off-by: NHarvey Harrison <harvey.harrison@gmail.com>
Signed-off-by: NRoland Dreier <rolandd@cisco.com>

When I review ocfs2 code, find there are 2 typos to "successfull".  After
doing grep "successfull " in kernel tree, 22 typos found totally -- great
minds always think alike :)

This patch fixes all the similar typos. Thanks for Randy's ack and comments.
Signed-off-by: NColy Li <coyli@suse.de>
Acked-by: NRandy Dunlap <randy.dunlap@oracle.com>
Acked-by: NRoland Dreier <rolandd@cisco.com>
Cc: Jeremy Kerr <jk@ozlabs.org>
Cc: Jeff Garzik <jeff@garzik.org>
Cc: Heiko Carstens <heiko.carstens@de.ibm.com>
Cc: Martin Schwidefsky <schwidefsky@de.ibm.com>
Cc: Theodore Ts'o <tytso@mit.edu>
Cc: Mark Fasheh <mfasheh@suse.com>
Cc: Vlad Yasevich <vladislav.yasevich@hp.com>
Cc: Sridhar Samudrala <sri@us.ibm.com>
Signed-off-by: NAndrew Morton <akpm@linux-foundation.org>
Signed-off-by: NLinus Torvalds <torvalds@linux-foundation.org>

When we removed the network device argument from several
NAPI interfaces in 908a7a16
("net: Remove unused netdev arg from some NAPI interfaces.")
several drivers now started getting unused variable warnings.

This fixes those up.
Signed-off-by: NDavid S. Miller <davem@davemloft.net>

There is no lock protecting tx_free_list thus causing a system crash
when skb_dequeue() is called and the list is empty.  Since it did not give
any performance boost under heavy load, remove it to simplify the code.
Replace get_free_pkt() with dev_alloc_skb() to allocate MAX_CM_BUFFER skb
for connection establishment/teardown as well as MPA request/response.
Signed-off-by: NFaisal Latif <faisal.latif@intel.com>
Signed-off-by: NChien Tung <chien.tin.tung@intel.com>
Signed-off-by: NRoland Dreier <rolandd@cisco.com>

When the napi api was changed to separate its 1:1 binding to the net_device
struct, the netif_rx_[prep|schedule|complete] api failed to remove the now
vestigual net_device structure parameter.  This patch cleans up that api by
properly removing it..
Signed-off-by: NNeil Horman <nhorman@tuxdriver.com>
Signed-off-by: NDavid S. Miller <davem@davemloft.net>

Wrap NES_DEBUG and assert macros with do while (0) to avoid ambiguous
else.  No one is using sk_buff * returned from form_cm_frame(), so
drop the return.  drop_packet() should not be incrementing reset
counter on receiving a FIN.
Signed-off-by: NChien Tung <chien.tin.tung@intel.com>
Signed-off-by: NRoland Dreier <rolandd@cisco.com>

Check for loopback connection in make_cm_node().
Signed-off-by: NChien Tung <chien.tin.tung@intel.com>
Signed-off-by: NRoland Dreier <rolandd@cisco.com>

Between the first empty list check and locking the list, the list can
change.  Check it again after it is locked to make sure the list is
still not empty.
Signed-off-by: NFaisal Latif <faisal.latif@intel.com>
Signed-off-by: NChien Tung <chien.tin.tung@intel.com>
Signed-off-by: NRoland Dreier <rolandd@cisco.com>

ANVL testing showed we are not handling all cm_node states during
connection establishment.  Add missing state handlers and fix sequence
number send reset in handle_tcp_options().
Signed-off-by: NFaisal Latif <faisal.latif@intel.com>
Signed-off-by: NChien Tung <chien.tin.tung@intel.com>
Signed-off-by: NRoland Dreier <rolandd@cisco.com>

Under heavy traffic, there is a small windows when an APBVT entry is
not yet removed and a new connection is established.  Packets for the
new connection are dropped until APBVT entry is removed.  This patch
will forward the packets instead of dropping them.
Signed-off-by: NFaisal Latif <faisal.latif@intel.com>
Signed-off-by: NChien Tung <chien.tin.tung@intel.com>
Signed-off-by: NRoland Dreier <rolandd@cisco.com>

In passive open, after indicating MPA request to rdma_cm, an incoming
RST would fire a reset event to rdma_cm causing it to crash, since the
current state is not connected.  The solution is to wait for
nes_accept() or nes_reject() before firing the reset event.  If
nes_accept() or nes_reject() is already done, then the reset event
will be fired when RST is processed.
Signed-off-by: NFaisal Latif <faisal.latif@intel.com>
Signed-off-by: NChien Tung <chien.tin.tung@intel.com>
Signed-off-by: NRoland Dreier <rolandd@cisco.com>

While processing connected_nodes list, we would release the lock when
we need to send reset to remote partner.  That created a window where
the list can be modified.  Change this into a two step process: place
nodes that need processing on a local list then process the local list.
Signed-off-by: NFaisal Latif <faisal.latif@intel.com>
Signed-off-by: NChien Tung <chien.tin.tung@intel.com>
Signed-off-by: NRoland Dreier <rolandd@cisco.com>

Use nes_free_cqp_request() instead of open coding.  Change some
continue to break in nes_cm_timer_tick, because send_entry used to be
a list processed in a loop (so continue went to the next item).  Now
it is a single item, so using break is correct.
Signed-off-by: NFaisal Latif <faisal.latif@intel.com>
Signed-off-by: NChien Tung <chien.tin.tung@intel.com>
Signed-off-by: NRoland Dreier <rolandd@cisco.com>

Under heavy load, there is an compatibility issue regarding PCIe write
credits with certain chipsets.  It can be mitigated by limiting read
requests to 256 Bytes.

This workaround is always enabled for Tbird2 on Gladius.  We also add
a module parameter to enable workaround for non-Gladius cards.
Signed-off-by: NChien Tung <chien.tin.tung@intel.com>
Signed-off-by: NRoland Dreier <rolandd@cisco.com>

Fix CQ allocation for multicast receive queue applications.  Before
this patch, the CQ was not lined up with the right NIC.
Signed-off-by: NVadim Makhervaks <vadim.makhervaks@intel.com>
Signed-off-by: NChien Tung <chien.tin.tung@intel.com>
Signed-off-by: NRoland Dreier <rolandd@cisco.com>

    * Roll back allocated structures on failures.
    * Use GFP_ATOMIC instead of GFP_KERNEL since we are holding a lock.
    * Acquire nesadapter->pbl_lock when modifying PBL counters.
    * Decrement PBL counters on deallocation.
Signed-off-by: NChien Tung <chien.tin.tung@intel.com>
Signed-off-by: NRoland Dreier <rolandd@cisco.com>

Signed-off-by: NIlpo Järvinen <ilpo.jarvinen@helsinki.fi>
Signed-off-by: NRoland Dreier <rolandd@cisco.com>

Using NIPQUAD() with NIPQUAD_FMT, %d.%d.%d.%d or %u.%u.%u.%u
can be replaced with %pI4
Signed-off-by: NHarvey Harrison <harvey.harrison@gmail.com>
Signed-off-by: NDavid S. Miller <davem@davemloft.net>

As a bonus, removes some unnecessary byteswapping.
Signed-off-by: NHarvey Harrison <harvey.harrison@gmail.com>
Signed-off-by: NDavid S. Miller <davem@davemloft.net>

This converts pretty much everything to print_mac. There were
a few things that had conflicts which I have just dropped for
now, no harm done.

I've built an allyesconfig with this and looked at the files
that weren't built very carefully, but it's a huge patch.
Signed-off-by: NJohannes Berg <johannes@sipsolutions.net>
Signed-off-by: NDavid S. Miller <davem@davemloft.net>

Referencing cm_node after it is freed via rem_ref_cm_node() causes a
slab corruption.  There is no need to set cm_node->cm_id to NULL in
mini_cm_close().
Signed-off-by: NChien Tung <ctung@neteffect.com>
Signed-off-by: NRoland Dreier <rolandd@cisco.com>

error_module is 5 bits wide not 4.  The corresponding crit_error_count
array is correct with 32 entries.
Signed-off-by: NChien Tung <ctung@neteffect.com>
--
 drivers/infiniband/hw/nes/nes_hw.c |    2 +-
 1 files changed, 1 insertions(+), 1 deletions(-)
Signed-off-by: NRoland Dreier <rolandd@cisco.com>

Fix routed RDMA connections to destinations where the next hop is not
the final destination.  Use neigh_*() to properly locate neighbor.
Signed-off-by: NBob Sharp <bsharp@neteffect.com>
Signed-off-by: NSweta Bhatt <sweta.bhatt@einfochips.com>
Signed-off-by: NChien Tung <ctung@neteffect.com>

Change management of perfect filter table to allow enhanced
performance applications.
Signed-off-by: NVadim Makhervaks <vmakhervaks@neteffect.com>
Signed-off-by: NSweta Bhatt <sweta.bhatt@einfochips.com>
Signed-off-by: NChien Tung <ctung@neteffect.com>
Signed-off-by: NRoland Dreier <rolandd@cisco.com>

Handle async error NES_AEQE_AEID_AMP_BOUNDS_VIOLATION.
Signed-off-by: NFaisal Latif <flatif@neteffect.com>
Signed-off-by: NSweta Bhatt <sweta.bhatt@einfochips.com>
Signed-off-by: NChien Tung <ctung@neteffect.com>
Signed-off-by: NRoland Dreier <rolandd@cisco.com>

Mask off a critical error after 100 critical error interrupts to
keep the system "sane".
Signed-off-by: NSweta Bhatt <sweta.bhatt@einfochips.com>
Signed-off-by: NChien Tung <ctung@neteffect.com>
Signed-off-by: NRoland Dreier <rolandd@cisco.com>

Mask off MAC interrupts on netdev_stop to prevent spurious MAC interrupts
on unload/reload of iw_nes.
Signed-off-by: NSweta Bhatt <sweta.bhatt@einfochips.com>
Signed-off-by: NChien Tung <ctung@neteffect.com>
Signed-off-by: NRoland Dreier <rolandd@cisco.com>

Signed-off-by: NSweta Bhatt <sweta.bhatt@einfochips.com>
Signed-off-by: NChien Tung <ctung@neteffect.com>
Signed-off-by: NRoland Dreier <rolandd@cisco.com>

Fill in firmware version for ethtool_drvinfo.
Signed-off-by: NSweta Bhatt <sweta.bhatt@einfochips.com>
Signed-off-by: NChien Tung <ctung@neteffect.com>
Signed-off-by: NRoland Dreier <rolandd@cisco.com>

Use timer value set via ethtool intead of #defines.
Signed-off-by: NJohn Lacombe <jlacombe@neteffect.com>
Signed-off-by: NSweta Bhatt <sweta.bhatt@einfochips.com>
Signed-off-by: NChien Tung <ctung@neteffect.com>
Signed-off-by: NRoland Dreier <rolandd@cisco.com>

Use correct define for max TSO fragments.
Signed-off-by: NBob Sharp <bsharp@neteffect.com>
Signed-off-by: NSweta Bhatt <sweta.bhatt@einfochips.com>
Signed-off-by: NChien Tung <ctung@neteffect.com>
Signed-off-by: NRoland Dreier <rolandd@cisco.com>

Re-enable multicast and unicast after changing MTU.
Signed-off-by: NBob Sharp <bsharp@neteffect.com>
Signed-off-by: NSweta Bhatt <sweta.bhatt@einfochips.com>
Signed-off-by: NChien Tung <ctung@neteffect.com>
Signed-off-by: NRoland Dreier <rolandd@cisco.com>

Signed-off-by: NBob Sharp <bsharp@neteffect.com>
Signed-off-by: NSweta Bhatt <sweta.bhatt@einfochips.com>
Signed-off-by: NChien Tung <ctung@neteffect.com>
Signed-off-by: NRoland Dreier <rolandd@cisco.com>

Clear MDC bits before setting them to a new value.  Adjust MDC value
for 10G.
Signed-off-by: NSweta Bhatt <sweta.bhatt@einfochips.com>
Signed-off-by: NChien Tung <ctung@neteffect.com>
Signed-off-by: NRoland Dreier <rolandd@cisco.com>

Add a module parameter wqm_quanta.  It controls the number of segments
transmitted at a time.
Signed-off-by: NSweta Bhatt <sweta.bhatt@einfochips.com>
Signed-off-by: NChien Tung <ctung@neteffect.com>
Signed-off-by: NRoland Dreier <rolandd@cisco.com>

Change permission to 0644 so root can set mpa_version, disable_mpa_crc,
send_first, and nes_drv_opt at runtime.
Signed-off-by: NSweta Bhatt <sweta.bhatt@einfochips.com>
Signed-off-by: NChien Tung <ctung@neteffect.com>
Signed-off-by: NRoland Dreier <rolandd@cisco.com>

Add support for NetEffect 4 port 1G HP blade card.  The mapping
between physical port and MAC is different from the standup card.
Signed-off-by: NChien Tung <ctung@neteffect.com>
Signed-off-by: NRoland Dreier <rolandd@cisco.com>

Signed-off-by: NFaisal Latif <flatif@neteffect.com>
Signed-off-by: NRoland Dreier <rolandd@cisco.com>

A break after a return serves no purpose, remove it.
Signed-off-by: NJulia Lawall <julia@diku.dk>
Reviewed-by: NRichard Genoud <richard.genoud@gmail.com>
Signed-off-by: NRoland Dreier <rolandd@cisco.com>

Fix QP not being destroyed properly on the client, which leads to
userspace programs hanging on exit.  This is a missing chunk from the
connection management rewrite in commit 6492cdf3 ("RDMA/nes: CM
connection setup/teardown rework").
Signed-off-by: NFaisal Latif <flatif@neteffect.com>
Signed-off-by: NRoland Dreier <rolandd@cisco.com>