1. 04 5月, 2012 5 次提交
  2. 03 5月, 2012 1 次提交
    • A
      ixgbe: Fix use after free on module remove · af94bf6d
      Alexander Duyck 提交于
      While testing the TCP changes I had to fix an issue in order to be able to
      load and unload the module.
      
      The recent patch that added thermal sensor support added a use after free
      bug on module unload with an 82598 adapter in the system.  To resolve the
      issue I have updated the code so that when we free the info_kobj we set it
      back to NULL.
      
      I suspect there are likely other bugs present, but I will leave that for
      another patch that can undergo more testing.
      
      I am submitting this directly to net-next since this fixes a fairly serious
      bug that will lock up the ixgbe module until the system is rebooted.
      Signed-off-by: NAlexander Duyck <alexander.h.duyck@intel.com>
      Cc: Jeff Kirsher <jeffrey.t.kirsher@intel.com>
      Signed-off-by: NDavid S. Miller <davem@davemloft.net>
      af94bf6d
  3. 02 5月, 2012 4 次提交
  4. 27 4月, 2012 1 次提交
  5. 18 4月, 2012 2 次提交
  6. 16 4月, 2012 3 次提交
  7. 14 4月, 2012 2 次提交
  8. 04 4月, 2012 2 次提交
  9. 28 3月, 2012 3 次提交
  10. 20 3月, 2012 3 次提交
    • A
      ixgbe: Fix issues with SR-IOV loopback when flow control is disabled · 8f4a0a3d
      Alexander Duyck 提交于
      This patch allows us to avoid a Tx hang when SR-IOV is enabled.  This hang
      can be triggered by sending small packets at a rate that was triggering Rx
      missed errors from the adapter while the internal Tx switch and at least
      one VF are enabled.
      
      This was all due to the fact that under heavy stress the Rx FIFO never
      drained below the flow control high water mark.  This resulted in the Tx
      FIFO being head of line blocked due to the fact that it relies on the flow
      control high water mark to determine when it is acceptable for the Tx to
      place a packet in the Rx FIFO.
      
      The resolution for this is to set the FCRTH value to the RXPBSIZE - 32 so
      that even if the ring is almost completely full we can still place Tx
      packets on the Rx ring and drop incoming Rx traffic if we do not have
      sufficient space available in the Rx FIFO.
      Signed-off-by: NAlexander Duyck <alexander.h.duyck@intel.com>
      Tested-by: NSibai Li <sibai.li@intel.com>
      Signed-off-by: NJeff Kirsher <jeffrey.t.kirsher@intel.com>
      Signed-off-by: NDavid S. Miller <davem@davemloft.net>
      8f4a0a3d
    • J
      ixgbe: fix namespace issues when FCoE/DCB is not enabled · 8af3c33f
      Jeff Kirsher 提交于
      Resolve namespace issues when FCoE or DCB is not enabled.
      The issue is with certain configurations we end up with namespace
      problems. A simple example:
      
      ixgbe_main.c
       - defines func A()
       - uses func A()
      
      ixgbe_fcoe.c
       - uses func A()
      
      ixgbe.h
       - has prototype for func A()
      
      For default (FCoE included) all is good.  But when it isn't the namespace
      checker complains about how func A() could be static.
      
      To resolve this, created a ixgbe_lib file to contain functions used
      by DCB/FCoE and their helper functions so that they are always in
      namespace whether or not DCB/FCoE is enabled.
      Signed-off-by: NJeff Kirsher <jeffrey.t.kirsher@intel.com>
      Tested-by: NPhil Schmitt <phillip.j.schmitt@intel.com>
      8af3c33f
    • A
      ixgbe: Correct flag values set by ixgbe_fix_features · 567d2de2
      Alexander Duyck 提交于
      This patch replaces the variable name data with the variable name features
      for ixgbe_fix_features and ixgbe_set_features.  This helps to make some
      issues more obvious such as the fact that we were disabling Rx VLAN tag
      stripping when we should have been forcing it to be enabled when DCB is
      enabled.
      
      In addition there was deprecated code present that was disabling the LRO
      flag if we had the itr value set too low.  I have updated this logic so
      that we will now allow the LRO flag to be set, but will not enable RSC
      until the rx-usecs value is high enough to allow enough time for Rx packet
      coalescing.
      Signed-off-by: NAlexander Duyck <alexander.h.duyck@intel.com>
      Tested-by: NStephen Ko <stephen.s.ko@intel.com>
      Signed-off-by: NJeff Kirsher <jeffrey.t.kirsher@intel.com>
      567d2de2
  11. 19 3月, 2012 8 次提交
  12. 17 3月, 2012 6 次提交