Under heavy traffic, there is a small windows when an APBVT entry is
not yet removed and a new connection is established.  Packets for the
new connection are dropped until APBVT entry is removed.  This patch
will forward the packets instead of dropping them.
Signed-off-by: NFaisal Latif <faisal.latif@intel.com>
Signed-off-by: NChien Tung <chien.tin.tung@intel.com>
Signed-off-by: NRoland Dreier <rolandd@cisco.com>

In passive open, after indicating MPA request to rdma_cm, an incoming
RST would fire a reset event to rdma_cm causing it to crash, since the
current state is not connected.  The solution is to wait for
nes_accept() or nes_reject() before firing the reset event.  If
nes_accept() or nes_reject() is already done, then the reset event
will be fired when RST is processed.
Signed-off-by: NFaisal Latif <faisal.latif@intel.com>
Signed-off-by: NChien Tung <chien.tin.tung@intel.com>
Signed-off-by: NRoland Dreier <rolandd@cisco.com>

While processing connected_nodes list, we would release the lock when
we need to send reset to remote partner.  That created a window where
the list can be modified.  Change this into a two step process: place
nodes that need processing on a local list then process the local list.
Signed-off-by: NFaisal Latif <faisal.latif@intel.com>
Signed-off-by: NChien Tung <chien.tin.tung@intel.com>
Signed-off-by: NRoland Dreier <rolandd@cisco.com>

Use nes_free_cqp_request() instead of open coding.  Change some
continue to break in nes_cm_timer_tick, because send_entry used to be
a list processed in a loop (so continue went to the next item).  Now
it is a single item, so using break is correct.
Signed-off-by: NFaisal Latif <faisal.latif@intel.com>
Signed-off-by: NChien Tung <chien.tin.tung@intel.com>
Signed-off-by: NRoland Dreier <rolandd@cisco.com>

Under heavy load, there is an compatibility issue regarding PCIe write
credits with certain chipsets.  It can be mitigated by limiting read
requests to 256 Bytes.

This workaround is always enabled for Tbird2 on Gladius.  We also add
a module parameter to enable workaround for non-Gladius cards.
Signed-off-by: NChien Tung <chien.tin.tung@intel.com>
Signed-off-by: NRoland Dreier <rolandd@cisco.com>

Fix CQ allocation for multicast receive queue applications.  Before
this patch, the CQ was not lined up with the right NIC.
Signed-off-by: NVadim Makhervaks <vadim.makhervaks@intel.com>
Signed-off-by: NChien Tung <chien.tin.tung@intel.com>
Signed-off-by: NRoland Dreier <rolandd@cisco.com>

    * Roll back allocated structures on failures.
    * Use GFP_ATOMIC instead of GFP_KERNEL since we are holding a lock.
    * Acquire nesadapter->pbl_lock when modifying PBL counters.
    * Decrement PBL counters on deallocation.
Signed-off-by: NChien Tung <chien.tin.tung@intel.com>
Signed-off-by: NRoland Dreier <rolandd@cisco.com>

Signed-off-by: NIlpo Järvinen <ilpo.jarvinen@helsinki.fi>
Signed-off-by: NRoland Dreier <rolandd@cisco.com>

Referencing cm_node after it is freed via rem_ref_cm_node() causes a
slab corruption.  There is no need to set cm_node->cm_id to NULL in
mini_cm_close().
Signed-off-by: NChien Tung <ctung@neteffect.com>
Signed-off-by: NRoland Dreier <rolandd@cisco.com>

error_module is 5 bits wide not 4.  The corresponding crit_error_count
array is correct with 32 entries.
Signed-off-by: NChien Tung <ctung@neteffect.com>
--
 drivers/infiniband/hw/nes/nes_hw.c |    2 +-
 1 files changed, 1 insertions(+), 1 deletions(-)
Signed-off-by: NRoland Dreier <rolandd@cisco.com>

Fix routed RDMA connections to destinations where the next hop is not
the final destination.  Use neigh_*() to properly locate neighbor.
Signed-off-by: NBob Sharp <bsharp@neteffect.com>
Signed-off-by: NSweta Bhatt <sweta.bhatt@einfochips.com>
Signed-off-by: NChien Tung <ctung@neteffect.com>

Change management of perfect filter table to allow enhanced
performance applications.
Signed-off-by: NVadim Makhervaks <vmakhervaks@neteffect.com>
Signed-off-by: NSweta Bhatt <sweta.bhatt@einfochips.com>
Signed-off-by: NChien Tung <ctung@neteffect.com>
Signed-off-by: NRoland Dreier <rolandd@cisco.com>

Handle async error NES_AEQE_AEID_AMP_BOUNDS_VIOLATION.
Signed-off-by: NFaisal Latif <flatif@neteffect.com>
Signed-off-by: NSweta Bhatt <sweta.bhatt@einfochips.com>
Signed-off-by: NChien Tung <ctung@neteffect.com>
Signed-off-by: NRoland Dreier <rolandd@cisco.com>

Mask off a critical error after 100 critical error interrupts to
keep the system "sane".
Signed-off-by: NSweta Bhatt <sweta.bhatt@einfochips.com>
Signed-off-by: NChien Tung <ctung@neteffect.com>
Signed-off-by: NRoland Dreier <rolandd@cisco.com>

Mask off MAC interrupts on netdev_stop to prevent spurious MAC interrupts
on unload/reload of iw_nes.
Signed-off-by: NSweta Bhatt <sweta.bhatt@einfochips.com>
Signed-off-by: NChien Tung <ctung@neteffect.com>
Signed-off-by: NRoland Dreier <rolandd@cisco.com>

Signed-off-by: NSweta Bhatt <sweta.bhatt@einfochips.com>
Signed-off-by: NChien Tung <ctung@neteffect.com>
Signed-off-by: NRoland Dreier <rolandd@cisco.com>

Fill in firmware version for ethtool_drvinfo.
Signed-off-by: NSweta Bhatt <sweta.bhatt@einfochips.com>
Signed-off-by: NChien Tung <ctung@neteffect.com>
Signed-off-by: NRoland Dreier <rolandd@cisco.com>

Use timer value set via ethtool intead of #defines.
Signed-off-by: NJohn Lacombe <jlacombe@neteffect.com>
Signed-off-by: NSweta Bhatt <sweta.bhatt@einfochips.com>
Signed-off-by: NChien Tung <ctung@neteffect.com>
Signed-off-by: NRoland Dreier <rolandd@cisco.com>

Use correct define for max TSO fragments.
Signed-off-by: NBob Sharp <bsharp@neteffect.com>
Signed-off-by: NSweta Bhatt <sweta.bhatt@einfochips.com>
Signed-off-by: NChien Tung <ctung@neteffect.com>
Signed-off-by: NRoland Dreier <rolandd@cisco.com>

Re-enable multicast and unicast after changing MTU.
Signed-off-by: NBob Sharp <bsharp@neteffect.com>
Signed-off-by: NSweta Bhatt <sweta.bhatt@einfochips.com>
Signed-off-by: NChien Tung <ctung@neteffect.com>
Signed-off-by: NRoland Dreier <rolandd@cisco.com>

Signed-off-by: NBob Sharp <bsharp@neteffect.com>
Signed-off-by: NSweta Bhatt <sweta.bhatt@einfochips.com>
Signed-off-by: NChien Tung <ctung@neteffect.com>
Signed-off-by: NRoland Dreier <rolandd@cisco.com>

Clear MDC bits before setting them to a new value.  Adjust MDC value
for 10G.
Signed-off-by: NSweta Bhatt <sweta.bhatt@einfochips.com>
Signed-off-by: NChien Tung <ctung@neteffect.com>
Signed-off-by: NRoland Dreier <rolandd@cisco.com>

Add a module parameter wqm_quanta.  It controls the number of segments
transmitted at a time.
Signed-off-by: NSweta Bhatt <sweta.bhatt@einfochips.com>
Signed-off-by: NChien Tung <ctung@neteffect.com>
Signed-off-by: NRoland Dreier <rolandd@cisco.com>

Change permission to 0644 so root can set mpa_version, disable_mpa_crc,
send_first, and nes_drv_opt at runtime.
Signed-off-by: NSweta Bhatt <sweta.bhatt@einfochips.com>
Signed-off-by: NChien Tung <ctung@neteffect.com>
Signed-off-by: NRoland Dreier <rolandd@cisco.com>

Add support for NetEffect 4 port 1G HP blade card.  The mapping
between physical port and MAC is different from the standup card.
Signed-off-by: NChien Tung <ctung@neteffect.com>
Signed-off-by: NRoland Dreier <rolandd@cisco.com>

Signed-off-by: NFaisal Latif <flatif@neteffect.com>
Signed-off-by: NRoland Dreier <rolandd@cisco.com>

A break after a return serves no purpose, remove it.
Signed-off-by: NJulia Lawall <julia@diku.dk>
Reviewed-by: NRichard Genoud <richard.genoud@gmail.com>
Signed-off-by: NRoland Dreier <rolandd@cisco.com>

Fix QP not being destroyed properly on the client, which leads to
userspace programs hanging on exit.  This is a missing chunk from the
connection management rewrite in commit 6492cdf3 ("RDMA/nes: CM
connection setup/teardown rework").
Signed-off-by: NFaisal Latif <flatif@neteffect.com>
Signed-off-by: NRoland Dreier <rolandd@cisco.com>

This patch lets the files using linux/version.h match the files that
#include it.
Signed-off-by: NAdrian Bunk <bunk@kernel.org>
Signed-off-by: NLinus Torvalds <torvalds@linux-foundation.org>

Major rework of CM connection setup/teardown.  We had a number of issues
with MPI applications not starting/terminating properly over time.
With these changes we were able to run longer on larger clusters.

* Remove memory allocation from nes_connect() and nes_cm_connect().
* Fix mini_cm_dec_refcnt_listen() when destroying listener.
* Remove unnecessary code from schedule_nes_timer() and nes_cm_timer_tick().
* Functionalize mini_cm_recv_pkt() and process_packet().
* Clean up cm_node->ref_count usage.
* Reuse skbs if available.
Signed-off-by: NFaisal Latif <flatif@neteffect.com>
Signed-off-by: NRoland Dreier <rolandd@cisco.com>

- Change the IB_DEVICE_ZERO_STAG flag to the transport-neutral name
  IB_DEVICE_LOCAL_DMA_LKEY, which is used by iWARP RNICs to indicate 0
  STag support and IB HCAs to indicate reserved L_Key support.

- Add a u32 local_dma_lkey member to struct ib_device.  Drivers fill
  this in with the appropriate local DMA L_Key (if they support it).

- Fix up the drivers using this flag.
Signed-off-by: NSteve Wise <swise@opengridcomputing.com>
Signed-off-by: NRoland Dreier <rolandd@cisco.com>

Every caller of nes_post_cqp_request() passed it NES_CQP_REQUEST_RING_DOORBELL,
so just remove that parameter and always ring the doorbell.
Signed-off-by: NRoland Dreier <rolandd@cisco.com>
Acked-by: NFaisal Latif <flatif@neteffect.com>

The iw_nes driver repeats the logic

	if (atomic_dec_and_test(&cqp_request->refcount)) {
		if (cqp_request->dynamic) {
			kfree(cqp_request);
		} else {
			spin_lock_irqsave(&nesdev->cqp.lock, flags);
			list_add_tail(&cqp_request->list, &nesdev->cqp_avail_reqs);
			spin_unlock_irqrestore(&nesdev->cqp.lock, flags);
		}
	}

over and over.  Wrap this up in functions nes_free_cqp_request() and
nes_put_cqp_request() to simplify such code.

In addition to making the source smaller and more readable, this shrinks
the compiled code quite a bit:

add/remove: 2/0 grow/shrink: 0/13 up/down: 164/-1692 (-1528)
function                                     old     new   delta
nes_free_cqp_request                           -     147    +147
nes_put_cqp_request                            -      17     +17
nes_modify_qp                               2316    2293     -23
nes_hw_modify_qp                             737     657     -80
nes_dereg_mr                                 945     860     -85
flush_wqes                                   501     416     -85
nes_manage_apbvt                             648     560     -88
nes_reg_mr                                  1117    1026     -91
nes_cqp_ce_handler                           927     769    -158
nes_alloc_mw                                1052     884    -168
nes_create_qp                               5314    5141    -173
nes_alloc_fmr                               2212    2035    -177
nes_destroy_cq                              1097     918    -179
nes_create_cq                               2787    2598    -189
nes_dealloc_mw                               762     566    -196
Signed-off-by: NRoland Dreier <rolandd@cisco.com>
Acked-by: NFaisal Latif <flatif@neteffect.com>

Remove an explicit memset(..., 0, ...) of a 'listener' structure
allocated with kzalloc().
Signed-off-by: NChristophe Jaillet <christophe.jaillet@wanadoo.fr>
Acked-by: NFaisal Latif <faisal@neteffect.com>
Signed-off-by: NRoland Dreier <rolandd@cisco.com>

nes_reg_user_mr() should fail if page_count becomes >= 1024 * 512
rather than just testing for strict >, because page_count is
essentially used as an index into an array with 1024 * 512 entries, so
allowing the loop to continue with page_count == 1024 * 512 means that
memory after the end of the array is corrupted.  This leads to a crash
triggerable by a userspace application that requests registration of a
too-big region.

Also get rid of the call to pci_free_consistent() here to avoid
corrupting state with a double free, since the same memory will be
freed in the code jumped to at reg_user_mr_err.
Signed-off-by: NRoland Dreier <rolandd@cisco.com>

Fix some bugs with the max_aggr module parameter added with LRO support:

 - The module parameter value ignored and not actually used to set
   lro_mgr.max_aggr.
 - MODULE_PARM_DESC had a typo "_mro_" instead of "_lro_" so it didn't
   end up describing the actual module parameter.
 - The nes_lro_max_aggr variable was declared as unsigned, but the
   module_param line said "int" instead of "uint" for the type.
 - The default value for the parameter was stuck in the permissions
   field of module_param, which led to nonsensical permissions for the
   file under /sys/module/iw_nes/param.
 - The parameter was used in only one file but defined in another, which
   led to the variable being global for no good reason.  Move everything
   related to the parameter to the file nes_hw.c where it is actually
   used.
Signed-off-by: NRoland Dreier <rolandd@cisco.com>

Various cleanups:
	- Change // to /* .. */
	- Place whitespace around binary operators.
	- Trim down a few long lines.
	- Some minor alignment formatting for better readability.
	- Remove some silly tabs.
Signed-off-by: NGlenn Streiff <gstreiff@neteffect.com>
Signed-off-by: NRoland Dreier <rolandd@cisco.com>

This patch enables the iw_nes module for NetEffect RNICs to support
additional PHYs including SFP+ (referred to as ARGUS in the code).
Signed-off-by: NEric Schneider <eric.schneider@neteffect.com>
Signed-off-by: NGlenn Streiff <gstreiff@neteffect.com>
Signed-off-by: NRoland Dreier <rolandd@cisco.com>

Signed-off-by: Faisal Latif <flatif@neteffect.com.
Signed-off-by: NGlenn Streiff <gstreiff@neteffect.com>
Signed-off-by: NRoland Dreier <rolandd@cisco.com>

Add a new parameter, dmasync, to the ib_umem_get() prototype.  Use dmasync = 1
when mapping user-allocated CQs with ib_umem_get().
Signed-off-by: NArthur Kepner <akepner@sgi.com>
Cc: Tony Luck <tony.luck@intel.com>
Cc: Jesse Barnes <jbarnes@virtuousgeek.org>
Cc: Jes Sorensen <jes@sgi.com>
Cc: Randy Dunlap <randy.dunlap@oracle.com>
Cc: Roland Dreier <rdreier@cisco.com>
Cc: James Bottomley <James.Bottomley@HansenPartnership.com>
Cc: David Miller <davem@davemloft.net>
Cc: Benjamin Herrenschmidt <benh@kernel.crashing.org>
Cc: Grant Grundler <grundler@parisc-linux.org>
Cc: Michael Ellerman <michael@ellerman.id.au>
Signed-off-by: NAndrew Morton <akpm@linux-foundation.org>
Signed-off-by: NLinus Torvalds <torvalds@linux-foundation.org>