1. 12 10月, 2010 1 次提交
    • J
      omap: dma: Fix buffering disable bit setting for omap24xx · 3e57f162
      Jarkko Nikula 提交于
      An errata workaround for omap24xx is not setting the buffering disable bit
      25 what is the purpose but channel enable bit 7 instead.
      
      Background for this fix is the DMA stalling issue with ASoC omap-mcbsp
      driver. Peter Ujfalusi <peter.ujfalusi@nokia.com> has found an issue in
      recording that the DMA stall could happen if there were a buffer overrun
      detected by ALSA and the DMA was stopped and restarted due that. This
      problem is known to occur on both OMAP2420 and OMAP3. It can recover on
      OMAP3 after dma free, dma request and reconfiguration cycle. However, on
      OMAP2420 it seems that only way to recover is a reset.
      
      Problem was not visible before the commit c12abc01. That commit changed that
      the McBSP transmitter/receiver is released from reset only when needed. That
      is, only enabled McBSP transmitter without transmission was able to prevent
      this DMA stall problem in receiving side and underlying problem did not show
      up until now. McBSP transmitter itself seems to no be reason since DMA
      stall does not recover by enabling the transmission after stall.
      
      Debugging showed that there were a DMA write active during DMA stop time and
      it never completed even when restarting the DMA. Experimenting showed that
      the DMA buffering disable bit could be used to avoid stalling when using
      source synchronized transfers. However that could have performance hit and
      OMAP3 TRM states that buffering disable is not allowed for destination
      synchronized transfers so subsequent patch will implement a method to
      complete DMA writes when stopping.
      
      This patch is based on assumtion that complete lock-up on OMAP2420 is
      different but related problem. I don't have access to OMAP2420 errata but
      I believe this old workaround here is put for a reason but unfortunately
      a wrong bit was typed and problem showed up only now.
      Signed-off-by: NJarkko Nikula <jhnikula@gmail.com>
      Signed-off-by: NPeter Ujfalusi <peter.ujfalusi@nokia.com>
      Acked-by: NManjunath Kondaiah G <manjugk@ti.com>
      Signed-off-by: NTony Lindgren <tony@atomide.com>
      3e57f162
  2. 02 8月, 2010 1 次提交
  3. 21 5月, 2010 2 次提交
  4. 23 4月, 2010 1 次提交
  5. 30 3月, 2010 1 次提交
    • T
      include cleanup: Update gfp.h and slab.h includes to prepare for breaking... · 5a0e3ad6
      Tejun Heo 提交于
      include cleanup: Update gfp.h and slab.h includes to prepare for breaking implicit slab.h inclusion from percpu.h
      
      percpu.h is included by sched.h and module.h and thus ends up being
      included when building most .c files.  percpu.h includes slab.h which
      in turn includes gfp.h making everything defined by the two files
      universally available and complicating inclusion dependencies.
      
      percpu.h -> slab.h dependency is about to be removed.  Prepare for
      this change by updating users of gfp and slab facilities include those
      headers directly instead of assuming availability.  As this conversion
      needs to touch large number of source files, the following script is
      used as the basis of conversion.
      
        http://userweb.kernel.org/~tj/misc/slabh-sweep.py
      
      The script does the followings.
      
      * Scan files for gfp and slab usages and update includes such that
        only the necessary includes are there.  ie. if only gfp is used,
        gfp.h, if slab is used, slab.h.
      
      * When the script inserts a new include, it looks at the include
        blocks and try to put the new include such that its order conforms
        to its surrounding.  It's put in the include block which contains
        core kernel includes, in the same order that the rest are ordered -
        alphabetical, Christmas tree, rev-Xmas-tree or at the end if there
        doesn't seem to be any matching order.
      
      * If the script can't find a place to put a new include (mostly
        because the file doesn't have fitting include block), it prints out
        an error message indicating which .h file needs to be added to the
        file.
      
      The conversion was done in the following steps.
      
      1. The initial automatic conversion of all .c files updated slightly
         over 4000 files, deleting around 700 includes and adding ~480 gfp.h
         and ~3000 slab.h inclusions.  The script emitted errors for ~400
         files.
      
      2. Each error was manually checked.  Some didn't need the inclusion,
         some needed manual addition while adding it to implementation .h or
         embedding .c file was more appropriate for others.  This step added
         inclusions to around 150 files.
      
      3. The script was run again and the output was compared to the edits
         from #2 to make sure no file was left behind.
      
      4. Several build tests were done and a couple of problems were fixed.
         e.g. lib/decompress_*.c used malloc/free() wrappers around slab
         APIs requiring slab.h to be added manually.
      
      5. The script was run on all .h files but without automatically
         editing them as sprinkling gfp.h and slab.h inclusions around .h
         files could easily lead to inclusion dependency hell.  Most gfp.h
         inclusion directives were ignored as stuff from gfp.h was usually
         wildly available and often used in preprocessor macros.  Each
         slab.h inclusion directive was examined and added manually as
         necessary.
      
      6. percpu.h was updated not to include slab.h.
      
      7. Build test were done on the following configurations and failures
         were fixed.  CONFIG_GCOV_KERNEL was turned off for all tests (as my
         distributed build env didn't work with gcov compiles) and a few
         more options had to be turned off depending on archs to make things
         build (like ipr on powerpc/64 which failed due to missing writeq).
      
         * x86 and x86_64 UP and SMP allmodconfig and a custom test config.
         * powerpc and powerpc64 SMP allmodconfig
         * sparc and sparc64 SMP allmodconfig
         * ia64 SMP allmodconfig
         * s390 SMP allmodconfig
         * alpha SMP allmodconfig
         * um on x86_64 SMP allmodconfig
      
      8. percpu.h modifications were reverted so that it could be applied as
         a separate patch and serve as bisection point.
      
      Given the fact that I had only a couple of failures from tests on step
      6, I'm fairly confident about the coverage of this conversion patch.
      If there is a breakage, it's likely to be something in one of the arch
      headers which should be easily discoverable easily on most builds of
      the specific arch.
      Signed-off-by: NTejun Heo <tj@kernel.org>
      Guess-its-ok-by: NChristoph Lameter <cl@linux-foundation.org>
      Cc: Ingo Molnar <mingo@redhat.com>
      Cc: Lee Schermerhorn <Lee.Schermerhorn@hp.com>
      5a0e3ad6
  6. 24 2月, 2010 3 次提交
  7. 16 2月, 2010 1 次提交
  8. 20 1月, 2010 1 次提交
  9. 12 12月, 2009 1 次提交
  10. 04 12月, 2009 1 次提交
  11. 12 11月, 2009 4 次提交
  12. 11 11月, 2009 1 次提交
  13. 23 10月, 2009 1 次提交
  14. 21 10月, 2009 1 次提交
    • T
      omap: headers: Move remaining headers from include/mach to include/plat · ce491cf8
      Tony Lindgren 提交于
      Move the remaining headers under plat-omap/include/mach
      to plat-omap/include/plat. Also search and replace the
      files using these headers to include using the right path.
      
      This was done with:
      
      #!/bin/bash
      mach_dir_old="arch/arm/plat-omap/include/mach"
      plat_dir_new="arch/arm/plat-omap/include/plat"
      headers=$(cd $mach_dir_old && ls *.h)
      omap_dirs="arch/arm/*omap*/ \
      drivers/video/omap \
      sound/soc/omap"
      other_files="drivers/leds/leds-ams-delta.c \
      drivers/mfd/menelaus.c \
      drivers/mfd/twl4030-core.c \
      drivers/mtd/nand/ams-delta.c"
      
      for header in $headers; do
      	old="#include <mach\/$header"
      	new="#include <plat\/$header"
      	for dir in $omap_dirs; do
      		find $dir -type f -name \*.[chS] | \
      			xargs sed -i "s/$old/$new/"
      	done
      	find drivers/ -type f -name \*omap*.[chS] | \
      		xargs sed -i "s/$old/$new/"
      	for file in $other_files; do
      		sed -i "s/$old/$new/" $file
      	done
      done
      
      for header in $(ls $mach_dir_old/*.h); do
      	git mv $header $plat_dir_new/
      done
      Signed-off-by: NTony Lindgren <tony@atomide.com>
      ce491cf8
  15. 20 10月, 2009 1 次提交
  16. 15 10月, 2009 1 次提交
  17. 29 8月, 2009 1 次提交
  18. 25 8月, 2009 1 次提交
  19. 10 8月, 2009 1 次提交
  20. 23 6月, 2009 1 次提交
  21. 29 5月, 2009 3 次提交
  22. 24 4月, 2009 1 次提交
  23. 24 3月, 2009 3 次提交
  24. 30 1月, 2009 2 次提交
  25. 15 1月, 2009 1 次提交
  26. 11 12月, 2008 1 次提交
  27. 30 11月, 2008 1 次提交
    • R
      [ARM] Hide ISA DMA API when ISA_DMA_API is unset · dcea83ad
      Russell King 提交于
      When ISA_DMA_API is unset, we're not implementing the ISA DMA API,
      so there's no point in publishing the prototypes via asm/dma.h, nor
      including the machine dependent parts of that API.
      
      This allows us to remove a lot of mach/dma.h files which don't contain
      any useful code.  Unfortunately though, some platforms put their own
      private non-ISA definitions into mach/dma.h, so we leave these behind
      and fix the appropriate #include statments.
      Signed-off-by: NRussell King <rmk+kernel@arm.linux.org.uk>
      dcea83ad
  28. 06 9月, 2008 2 次提交