This option was there for debugging race conditions,
just remove it, and assume TX_FLOW is always enabled.
Signed-off-by: NMike Sinkovsky <msink@permonline.ru>
Signed-off-by: NDavid S. Miller <davem@davemloft.net>

Both drivers need to depend upon HAS_IOMEM, otherwise we
get a build failure on platforms like S390.

All the driver specific config options need to depend upon
the drivers themselves.
Reported-by: NStephen Rothwell <sfr@canb.auug.org.au>
Signed-off-by: NDavid S. Miller <davem@davemloft.net>

Signed-off-by: NDavid S. Miller <davem@davemloft.net>

Signed-off-by: NFrancois Romieu <romieu@fr.zoreil.com>
Cc: Jon Mason <mason@myri.com>
Acked-by: NAndrew Gallatin <gallatin@myri.com>

- pci_resource_start() can be removed from sis900_get_mac_addr() because
  the IO range is maped and stored into the device private struct early
  in the device probe function.
- the driver contains a few direct accesses to low IO ports that forbid
  to re(#)define the usual out{l, w, b} macros.
Signed-off-by: NFrancois Romieu <romieu@fr.zoreil.com>
Cc: Daniele Venzano <venza@brownhat.org>

This is a pure PCI driver, no ISA here.
Signed-off-by: NFrancois Romieu <romieu@fr.zoreil.com>
Acked-by: NGrant Grundler <grundler@parisc-linux.org>

Signed-off-by: NFrancois Romieu <romieu@fr.zoreil.com>

The bulk of the patch comes from the __iomem changes.

- the phy read and write operations were carrying the chip id deep
  down the call chain. Let's waste a pointer and contain the flying
  spaghetti monster.
- phy_{read, write}_1bit only need to access the DCR9 register. The loss
  of generality here should not hurt.
- removed a leftover printk of the EISA era. This is a pure PCI device.
Signed-off-by: NFrancois Romieu <romieu@fr.zoreil.com>
Acked-by: NGrant Grundler <grundler@parisc-linux.org>

The eeprom registers always use the same PCI bar whereas the general
registers may either use the same mapping as the eeprom registers or
a different one. It is thus possible to simplify parse_eeprom().
Signed-off-by: NFrancois Romieu <romieu@fr.zoreil.com>

Signed-off-by: NFrancois Romieu <romieu@fr.zoreil.com>

It's useless to check mem_start on a newly allocated device.
Signed-off-by: NFrancois Romieu <romieu@fr.zoreil.com>
Cc: Tim Hockin <thockin@hockin.org>

The device private data pointer can not be NULL in smsc9420_open().
Signed-off-by: NFrancois Romieu <romieu@fr.zoreil.com>
Cc: Steve Glendinning <steve.glendinning@smsc.com>

Signed-off-by: NFrancois Romieu <romieu@fr.zoreil.com>
Acked-by: NGrant Grundler <grundler@parisc-linux.org>

Signed-off-by: NFrancois Romieu <romieu@fr.zoreil.com>
Acked-by: NGrant Grundler <grundler@parisc-linux.org>

- unbalanced pci_disable_device
- PCI ressources were not released
- mismatching pci_alloc_.../kfree pairs are replaced by DMA alloc helpers.
Signed-off-by: NFrancois Romieu <romieu@fr.zoreil.com>
Ack-by: NGrant Grundler <grundler@parisc-linux.org>

Signed-off-by: NFrancois Romieu <romieu@fr.zoreil.com>
Ack-by: NGrant Grundler <grundler@parisc-linux.org>

Signed-off-by: NFrancois Romieu <romieu@fr.zoreil.com>

Signed-off-by: NFrancois Romieu <romieu@fr.zoreil.com>
Ack-by: NGrant Grundler <grundler@parisc-linux.org>

Signed-off-by: NFrancois Romieu <romieu@fr.zoreil.com>

Signed-off-by: NFrancois Romieu <romieu@fr.zoreil.com>

Signed-off-by: NFrancois Romieu <romieu@fr.zoreil.com>

Signed-off-by: NFrancois Romieu <romieu@fr.zoreil.com>
Acked-by: NMichael Chan <mchan@broadcom.com>

Some settings are duplicated between ethtool link management and module
options. The latter is trimmed. The half duplex, speed and autonegotiation
defaults are kept unchanged.
Signed-off-by: NFrancois Romieu <romieu@fr.zoreil.com>
Cc: Ion Badulescu <ionut@badula.org>

It's useless to check mem_start on a newly allocated device as well.
Signed-off-by: NFrancois Romieu <romieu@fr.zoreil.com>
Cc: Ion Badulescu <ionut@badula.org>

Signed-off-by: NFrancois Romieu <romieu@fr.zoreil.com>

Signed-off-by: NFrancois Romieu <romieu@fr.zoreil.com>

Signed-off-by: NFrancois Romieu <romieu@fr.zoreil.com>
Cc: Jon Mason <jdmason@kudzu.us>

Signed-off-by: NFrancois Romieu <romieu@fr.zoreil.com>
Cc: Jay Cliburn <jcliburn@gmail.com>
Cc: Chris Snook <chris.snook@gmail.com>

Signed-off-by: NFrancois Romieu <romieu@fr.zoreil.com>

Signed-off-by: NFrancois Romieu <romieu@fr.zoreil.com>
Cc: Jon Mason <jdmason@kudzu.us>

Signed-off-by: NFrancois Romieu <romieu@fr.zoreil.com>

Signed-off-by: NFrancois Romieu <romieu@fr.zoreil.com>
Cc: David Lv <DavidLv@viatech.com.cn>

Signed-off-by: NFrancois Romieu <romieu@fr.zoreil.com>

Signed-off-by: NFrancois Romieu <romieu@fr.zoreil.com>
Cc: David Lv <DavidLv@viatech.com.cn>

Signed-off-by: NFrancois Romieu <romieu@fr.zoreil.com>
Cc: Jay Cliburn <jcliburn@gmail.com>
Cc: Chris Snook <chris.snook@gmail.com>

Signed-off-by: NFrancois Romieu <romieu@fr.zoreil.com>

Signed-off-by: NFrancois Romieu <romieu@fr.zoreil.com>
Cc: Andy Gospodarek <andy@greyhouse.net>

Signed-off-by: NFrancois Romieu <romieu@fr.zoreil.com>

Reported-by: NStephen Rothwell <sfr@canb.auug.org.au>
Signed-off-by: NGiuseppe Cavallaro <peppe.cavallaro@st.com>
Signed-off-by: NDavid S. Miller <davem@davemloft.net>

Reported-by: NPaul Gortmaker <paul.gortmaker@windriver.com>
Signed-off-by: NDavid S. Miller <davem@davemloft.net>