1. 06 1月, 2012 1 次提交
  2. 04 11月, 2011 2 次提交
    • J
      hwmon: (lm90) Make code more readable · b2589ab0
      Jean Delvare 提交于
      Clean up the code to make it more readable:
      * Remove reg_ and new_ prefixes from variable names, they made the
        names longer, causing extra line breaks, while not adding much
        value.
      * Introduce struct device dev* = &client->dev in two functions, to
        avoid repeating client->dev everywhere in these functions.
      Signed-off-by: NJean Delvare <khali@linux-fr.org>
      Acked-by: NGuenter Roeck <guenter.roeck@ericsson.com>
      b2589ab0
    • J
      hwmon: (lm90) Fix warnings · 8dc089d6
      Jean Delvare 提交于
      With some configuration option combinations, we get the following
      warnings:
      
      drivers/hwmon/lm90.c: In function 'lm90_detect':
      drivers/hwmon/lm90.c:1114: warning: 'chip_id' may be used uninitialized
      in this function
      drivers/hwmon/lm90.c:1114: warning: 'reg_config1' may be used
      uninitialized in this function
      drivers/hwmon/lm90.c:1114: warning: 'reg_convrate' may be used
      uninitialized in this function
      drivers/hwmon/lm90.c:1187: warning: 'reg_emerg2' may be used
      uninitialized in this function
      drivers/hwmon/lm90.c:1187: warning: 'reg_status2' may be used
      uninitialized in this function
      
      We can solve these easily by reading the register values first and
      checking for errors later. These errors should be very rare, even in
      the case of failed detection, so this change has no impact on
      performance. And this makes checkpatch.pl happier.
      Reported-by: NGuenter Roeck <guenter.roeck@ericsson.com>
      Signed-off-by: NJean Delvare <khali@linux-fr.org>
      Acked-by: NGuenter Roeck <guenter.roeck@ericsson.com>
      8dc089d6
  3. 29 7月, 2011 3 次提交
  4. 28 7月, 2011 1 次提交
  5. 29 4月, 2011 1 次提交
  6. 31 3月, 2011 1 次提交
  7. 29 10月, 2010 12 次提交
  8. 28 5月, 2010 1 次提交
  9. 06 3月, 2010 3 次提交
  10. 15 12月, 2009 3 次提交
  11. 10 12月, 2009 1 次提交
  12. 12 3月, 2009 1 次提交
  13. 27 10月, 2008 2 次提交
    • J
      hwmon: (lm90) Add support for the LM99 16 degree offset · 97ae60bb
      Jean Delvare 提交于
      The LM99 differs from the LM86, LM89 and LM90 in that it reports
      remote temperatures (temp2) 16 degrees lower than they really are. So
      far we have been cheating and handled this in userspace but it really
      should be handled by the driver directly.
      Signed-off-by: NJean Delvare <khali@linux-fr.org>
      Cc: Matthew Garrett <mjg59@srcf.ucam.org>
      97ae60bb
    • J
      hwmon: (lm90) Fix handling of hysteresis value · ec38fa2b
      Jean Delvare 提交于
      There are several problems in the way the hysteresis value is handled
      by the lm90 driver:
      
      * In show_temphyst(), specific handling of the MAX6646 is missing, so
        the hysteresis is reported incorrectly if the critical temperature
        is over 127 degrees C.
      * In set_temphyst(), the new hysteresis register value is written to
        the chip but data->temp_hyst isn't updated accordingly, so there is
        a short period of time (up to 2 seconds) where the old hystereris
        value will be returned while the new one is already active.
      * In set_temphyst(), the critical temperature which is used as a base
        to compute the value of the hysteresis register lacks
        device-specific handling. As a result, the value of the hysteresis
        register might be incorrect for the ADT7461 and MAX6646 chips.
      
      Fix these 3 bugs.
      Signed-off-by: NJean Delvare <khali@linux-fr.org>
      Cc: Ben Hutchings <bhutchings@solarflare.com>
      Cc: Nate Case <ncase@xes-inc.com>
      ec38fa2b
  14. 17 10月, 2008 8 次提交