1. 18 1月, 2009 1 次提交
  2. 06 1月, 2009 1 次提交
  3. 03 1月, 2009 1 次提交
  4. 31 10月, 2008 1 次提交
  5. 28 10月, 2008 2 次提交
  6. 23 9月, 2008 1 次提交
    • A
      x86, NMI watchdog: setup before enabling NMI watchdog · b3e15bde
      Aristeu Rozanski 提交于
      There's a small window when NMI watchdog is being set up that if any NMIs
      are triggered, the NMI code will make make use of not initalized wd_ops
      elements:
      	void setup_apic_nmi_watchdog(void *unused)
      	{
      		if (__get_cpu_var(wd_enabled))
      			return;
      
      		/* cheap hack to support suspend/resume */
      		/* if cpu0 is not active neither should the other cpus */
      		if (smp_processor_id() != 0 && atomic_read(&nmi_active) <= 0)
      			return;
      
      		switch (nmi_watchdog) {
      		case NMI_LOCAL_APIC:
      			/* enable it before to avoid race with handler */
      -->			__get_cpu_var(wd_enabled) = 1;
      -->			if (lapic_watchdog_init(nmi_hz) < 0) {
      (...)
      	asmlinkage notrace __kprobes void default_do_nmi(struct pt_regs *regs)
      	{
      	(...)
      			if (nmi_watchdog_tick(regs, reason))
      				return;
      (...)
      	notrace __kprobes int
      	nmi_watchdog_tick(struct pt_regs *regs, unsigned reason)
      	{
      	(...)
      		if (!__get_cpu_var(wd_enabled))
      			return rc;
      		switch (nmi_watchdog) {
      		case NMI_LOCAL_APIC:
      			rc |= lapic_wd_event(nmi_hz);
      (...)
      int lapic_wd_event(unsigned nmi_hz)
      {
      	struct nmi_watchdog_ctlblk *wd = &__get_cpu_var(nmi_watchdog_ctlblk);
      	u64 ctr;
      
      -->	rdmsrl(wd->perfctr_msr, ctr);
      
      and wd->*_msr will be initialized on each processor type specific setup, after
      enabling NMIs for PMIs. Since the counter was just set, the chances of an
      performance counter generated NMI is minimal, but any other unknown NMI would
      trigger the problem. This patch fixes the problem by setting everything up
      before enabling performance counter generated NMIs and will set wd_enabled
      using a callback function.
      Signed-off-by: NAristeu Rozanski <aris@redhat.com>
      Acked-by: NDon Zickus <dzickus@redhat.com>
      Acked-by: NPrarit Bhargava <prarit@redhat.com>
      Acked-by: NVivek Goyal <vgoyal@redhat.com>
      Signed-off-by: NIngo Molnar <mingo@elte.hu>
      b3e15bde
  7. 15 8月, 2008 2 次提交
    • I
      x86, nmi: clean UP NMI watchdog failure message · 8bb85190
      Ingo Molnar 提交于
      clean up the failure message - and redirect people to bugzilla
      instead of lkml.
      Signed-off-by: NIngo Molnar <mingo@elte.hu>
      8bb85190
    • A
      x86, NMI: fix watchdog failure message · 15636668
      Aristeu Rozanski 提交于
      > it just won't work at boot time - the second logic unit will be stuck:
      >
      > Booting processor 1/2 APIC 0x1
      > Initializing CPU#1
      > Calibrating delay using timer specific routine.. 5586.12 BogoMIPS (lpj=2793063)
      > CPU: Trace cache: 12K uops, L1 D cache: 16K
      > CPU: L2 cache: 1024K
      > CPU: Physical Processor ID: 0
      > CPU: Processor Core ID: 1
      > CPU1: Thermal monitoring enabled (TM1)
      >               Intel(R) Pentium(R) D CPU 2.80GHz stepping 04
      > Brought up 2 CPUs
      > testing NMI watchdog ... <4>WARNING: CPU#1: NMI appears to be stuck (0->0)!
      
      while at it... - fix that newline
      Signed-off-by: NAristeu Rozanski <aris@redhat.com>
      Cc: jvillalo@redhat.com
      Signed-off-by: NIngo Molnar <mingo@elte.hu>
      15636668
  8. 20 7月, 2008 1 次提交
  9. 18 7月, 2008 1 次提交
    • M
      x86: APIC: remove apic_write_around(); use alternatives · 593f4a78
      Maciej W. Rozycki 提交于
      Use alternatives to select the workaround for the 11AP Pentium erratum
      for the affected steppings on the fly rather than build time.  Remove the
      X86_GOOD_APIC configuration option and replace all the calls to
      apic_write_around() with plain apic_write(), protecting accesses to the
      ESR as appropriate due to the 3AP Pentium erratum.  Remove
      apic_read_around() and all its invocations altogether as not needed.
      Remove apic_write_atomic() and all its implementing backends.  The use of
      ASM_OUTPUT2() is not strictly needed for input constraints, but I have
      used it for readability's sake.
      
      I had the feeling no one else was brave enough to do it, so I went ahead
      and here it is.  Verified by checking the generated assembly and tested
      with both a 32-bit and a 64-bit configuration, also with the 11AP
      "feature" forced on and verified with gdb on /proc/kcore to work as
      expected (as an 11AP machines are quite hard to get hands on these days).
      Some script complained about the use of "volatile", but apic_write() needs
      it for the same reason and is effectively a replacement for writel(), so I
      have disregarded it.
      
      I am not sure what the policy wrt defconfig files is, they are generated
      and there is risk of a conflict resulting from an unrelated change, so I
      have left changes to them out.  The option will get removed from them at
      the next run.
      
      Some testing with machines other than mine will be needed to avoid some
      stupid mistake, but despite its volume, the change is not really that
      intrusive, so I am fairly confident that because it works for me, it will
      everywhere.
      Signed-off-by: NMaciej W. Rozycki <macro@linux-mips.org>
      Signed-off-by: NIngo Molnar <mingo@elte.hu>
      593f4a78
  10. 12 7月, 2008 1 次提交
  11. 08 7月, 2008 3 次提交
  12. 19 6月, 2008 1 次提交
  13. 12 6月, 2008 1 次提交
  14. 05 6月, 2008 2 次提交
    • M
      x86, nmi: fix build · 75b9f5d2
      mingo@elte.hu 提交于
      fix:
      
      arch/x86/kernel/built-in.o: In function `proc_nmi_enabled':
      : undefined reference to `nmi_watchdog_default'
      arch/x86/kernel/built-in.o: In function `native_smp_prepare_cpus':
      : undefined reference to `nmi_watchdog_default'
      Signed-off-by: NIngo Molnar <mingo@elte.hu>
      75b9f5d2
    • C
      x86: nmi - consolidate nmi_watchdog_default for 32bit mode · 3ed3f062
      Cyrill Gorcunov 提交于
      64bit mode bootstrap code does set nmi_watchdog to NMI_NONE
      by default and doing the same on 32bit mode is safe too.
      Such an action saves us from several #ifdef.
      
      Btw, my previous commit
      
      commit 19ec673c
      Author: Cyrill Gorcunov <gorcunov@gmail.com>
      Date:   Wed May 28 23:00:47 2008 +0400
      
          x86: nmi - fix incorrect NMI watchdog used by default
      
      did not fix the problem completely, moreover it
      introduced additional bug - nmi_watchdog would be
      set to either NMI_LOCAL_APIC or NMI_IO_APIC
      _regardless_ to boot option if being enabled thru
      /proc/sys/kernel/nmi_watchdog. Sorry for that.
      Fix it too.
      Signed-off-by: NCyrill Gorcunov <gorcunov@gmail.com>
      Cc: mingo@redhat.com
      Cc: hpa@zytor.com
      Cc: macro@linux-mips.org
      Signed-off-by: NThomas Gleixner <tglx@linutronix.de>
      3ed3f062
  15. 02 6月, 2008 2 次提交
  16. 29 5月, 2008 1 次提交
  17. 26 5月, 2008 8 次提交
  18. 13 5月, 2008 1 次提交
  19. 20 4月, 2008 1 次提交
  20. 17 4月, 2008 4 次提交
  21. 19 2月, 2008 1 次提交
  22. 30 1月, 2008 1 次提交
  23. 25 1月, 2008 1 次提交
  24. 22 1月, 2008 1 次提交