Convert calls to free_irq so that the second argument is the same as the
last argument of the corresponding call to request_irq.  Without this
property, free_irq does nothing.
Signed-off-by: NJulia Lawall <Julia.Lawall@lip6.fr>
Signed-off-by: NFlorian Tobias Schandinat <FlorianSchandinat@gmx.de>

Supporting runtime PM is very nice, but that's not a reason not to
implement system suspend/resume properly.
Reported-by: NGuennadi Liakhovetski <g.liakhovetski@gmx.de>
Signed-off-by: NLaurent Pinchart <laurent.pinchart@ideasonboard.com>

The meram_register(), meram_unregister() and meram_update() operations
check that the pointers they get from the caller are not NULL. Those
checks can be remove, as the caller already ensures that the pointers
are valid.

The platform sanity checks can also be removed, as the operations can't
be accessed without valid platform data anyway.
Signed-off-by: NLaurent Pinchart <laurent.pinchart@ideasonboard.com>

Remove the RGB or Y/C base address update from the meram_register()
operation, as this belongs to the meram_update() operation.
Signed-off-by: NLaurent Pinchart <laurent.pinchart@ideasonboard.com>

Instead of copying the whole platform data structure to struct
sh_mobile_lcdc_chan, store a const pointer to the channel platform data.

MERAM configuration information needs to be changed at runtime, so copy
it to struct sh_mobile_lcdc_chan.
Signed-off-by: NLaurent Pinchart <laurent.pinchart@ideasonboard.com>

Instead of manually specifying the ICBs to use in platform data,
allocate them automatically at runtime. The range of reserved ICBs (for
instance to be used through UIO), if any, is passed in the platform data
reserved_icbs field as a bitmask.

The MERAM registration function now returns a pointer to an opaque MERAM
object, which is passed to the update and unregistration functions.
Signed-off-by: NLaurent Pinchart <laurent.pinchart@ideasonboard.com>

Instead of requiring the users to hardcode MERAM allocation in platform
data, allocate blocks at runtime using genalloc.
Signed-off-by: NLaurent Pinchart <laurent.pinchart@ideasonboard.com>

And rename a couple of constants to make prefixes more uniform.
Signed-off-by: NLaurent Pinchart <laurent.pinchart@ideasonboard.com>

Let the compiler decide which complex functions to inline, and constify
constant static arrays.
Signed-off-by: NLaurent Pinchart <laurent.pinchart@ideasonboard.com>

The new structure stores ICB parameters for ICBs.

Instead of modifying the struct sh_mobile_meram_cfg instances passed by
callers, store the ICB parameters internally and make the public API
take const pointers to sh_mobile_meram_cfg.
Signed-off-by: NLaurent Pinchart <laurent.pinchart@ideasonboard.com>

Make sure current_reg == 0/1 always mean register set A/B through all
the code.
Signed-off-by: NLaurent Pinchart <laurent.pinchart@ideasonboard.com>

Many variables, such as loop counters, sizes and offsets, should be
unsigned integers. Make them so.
Signed-off-by: NLaurent Pinchart <laurent.pinchart@ideasonboard.com>

The structure describe ICB configuration, no ICB objects themselves.
Rename it to sh_mobile_meram_icb_cfg in preparation for the addition of
an ICB structure.

All the structure fields are unsigned integers, make them so.
Signed-off-by: NLaurent Pinchart <laurent.pinchart@ideasonboard.com>

Make sure the registers and MERAM spaces are reserved before using them.
Signed-off-by: NLaurent Pinchart <laurent.pinchart@ideasonboard.com>

The sh_mobile_wait_for_vsync() function isn't related to the fbdev API,
make it generic by passing a channel pointer instead of an fb_info
pointer.
Signed-off-by: NLaurent Pinchart <laurent.pinchart@ideasonboard.com>

Store the frame buffer configuration (colorspace, visible/virtual
horizontal and vertical resolutions and line pitch) in the
sh_mobile_lcdc_chan structure, and use it instead of accessing fb_info.
Signed-off-by: NLaurent Pinchart <laurent.pinchart@ideasonboard.com>

The dma_map_sg() and dma_unmap_sg() functions need a pointer to the
physical device.
Signed-off-by: NLaurent Pinchart <laurent.pinchart@ideasonboard.com>

Signed-off-by: NLaurent Pinchart <laurent.pinchart@ideasonboard.com>

Store the active format in the channel structure, and use it instead of
parsing info->var all over the place when the format is needed.
Signed-off-by: NLaurent Pinchart <laurent.pinchart@ideasonboard.com>

The function returns a pointer to a structure describing a format based
on its fourcc. Use the function where applicable instead of hardcoded
switch-case statements.
Signed-off-by: NLaurent Pinchart <laurent.pinchart@ideasonboard.com>

Group fields by purpose, and make the separation between core fields and
FB-related fields clear.
Signed-off-by: NLaurent Pinchart <laurent.pinchart@ideasonboard.com>

The struct sh_mobile_lcdc_chan_cfg platform data contains a list of
video modes. Name the lcd_cfg and num_cfg fields to reflect that they
describe video modes.
Signed-off-by: NLaurent Pinchart <laurent.pinchart@ideasonboard.com>

Embed struct fb_videomode instead of struct fb_var_screeninfo in struct
sh_mobile_lcdc_chan to store the display mode.
Signed-off-by: NLaurent Pinchart <laurent.pinchart@ideasonboard.com>

The LCDC fb_info structure is only used to retrieve the default video
mode in case none of the modes advertised by EDID information is
acceptable. Pass a pointer to the default mode through the
sh_mobile_lcdc_entity structure instead.
Signed-off-by: NLaurent Pinchart <laurent.pinchart@ideasonboard.com>

The struct sh_hdmi mode field is only used after being assigned by the
EDID read code. There is thus no need to initialize it from the LCDC
display var in the display on handler.
Signed-off-by: NLaurent Pinchart <laurent.pinchart@ideasonboard.com>

Pass pointers to struct fb_videomode and struct fb_monspecs instead of
struct fb_var_screeninfo to the notify callback.
Signed-off-by: NLaurent Pinchart <laurent.pinchart@ideasonboard.com>

Instead of accessing the LCDC channel and fb_info structures directly,
use the LCDC notification callback to inform the LCDC driver about
display-related events.
Signed-off-by: NLaurent Pinchart <laurent.pinchart@ideasonboard.com>

The callback implements 3 notification events:

- SH_MOBILE_LCDC_EVENT_DISPLAY_CONNECT notifies the LCDC that the
  display has been connected
- SH_MOBILE_LCDC_EVENT_DISPLAY_DISCONNECT notifies the LCDC that the
  display has been disconnected
- SH_MOBILE_LCDC_EVENT_DISPLAY_MODE notifies that LCDC that a display
  mode has been detected
Signed-off-by: NLaurent Pinchart <laurent.pinchart@ideasonboard.com>

Return true if the display is connected and false otherwise. Set the fb
info state to FBINFO_STATE_SUSPENDED in the sh_mobile_lcdc driver when
the display is not connected.
Signed-off-by: NLaurent Pinchart <laurent.pinchart@ideasonboard.com>

The parameter is unused, remove it.
Signed-off-by: NLaurent Pinchart <laurent.pinchart@ideasonboard.com>

The fb_info parameter passed to the display_on operation will be
removed, don't use it.
Signed-off-by: NLaurent Pinchart <laurent.pinchart@ideasonboard.com>

The field will be used by the transmitter drivers to access
sh_mobile_lcdc_chan fields such as fb_info.
Signed-off-by: NLaurent Pinchart <laurent.pinchart@ideasonboard.com>

Update board code accordingly.
Signed-off-by: NLaurent Pinchart <laurent.pinchart@ideasonboard.com>

Update board code accordingly.
Signed-off-by: NLaurent Pinchart <laurent.pinchart@ideasonboard.com>

The field is unused, remove it. Update board code accordingly.
Signed-off-by: NLaurent Pinchart <laurent.pinchart@ideasonboard.com>

The field is unused, remove it.
Signed-off-by: NLaurent Pinchart <laurent.pinchart@ideasonboard.com>

The display_on/off operations are now accessed through the
sh_mobile_lcdc_entity operations.
Signed-off-by: NLaurent Pinchart <laurent.pinchart@ideasonboard.com>

The display_on/off operations are now accessed through the
sh_mobile_lcdc_entity operations.
Signed-off-by: NLaurent Pinchart <laurent.pinchart@ideasonboard.com>

Pass a pointer to the transmitter device through platform data, retrieve
the corresponding sh_mobile_lcdc_entity structure in the probe method
and call the transmitter display_on/off methods directly.
Signed-off-by: NLaurent Pinchart <laurent.pinchart@ideasonboard.com>

Signed-off-by: NLaurent Pinchart <laurent.pinchart@ideasonboard.com>