1. 06 3月, 2014 4 次提交
  2. 08 11月, 2013 1 次提交
    • M
      [media] dvb-frontends: Don't use dynamic static allocation · 37ebaf68
      Mauro Carvalho Chehab 提交于
      Dynamic static allocation is evil, as Kernel stack is too low, and
      compilation complains about it on some archs:
      	drivers/media/dvb-frontends/af9013.c:77:1: warning: 'af9013_wr_regs_i2c' uses dynamic stack allocation [enabled by default]
      	drivers/media/dvb-frontends/af9033.c:188:1: warning: 'af9033_wr_reg_val_tab' uses dynamic stack allocation [enabled by default]
      	drivers/media/dvb-frontends/af9033.c:68:1: warning: 'af9033_wr_regs' uses dynamic stack allocation [enabled by default]
      	drivers/media/dvb-frontends/bcm3510.c:230:1: warning: 'bcm3510_do_hab_cmd' uses dynamic stack allocation [enabled by default]
      	drivers/media/dvb-frontends/cxd2820r_core.c:84:1: warning: 'cxd2820r_rd_regs_i2c.isra.1' uses dynamic stack allocation [enabled by default]
      	drivers/media/dvb-frontends/rtl2830.c:56:1: warning: 'rtl2830_wr' uses dynamic stack allocation [enabled by default]
      	drivers/media/dvb-frontends/rtl2832.c:187:1: warning: 'rtl2832_wr' uses dynamic stack allocation [enabled by default]
      	drivers/media/dvb-frontends/tda10071.c:52:1: warning: 'tda10071_wr_regs' uses dynamic stack allocation [enabled by default]
      	drivers/media/dvb-frontends/tda10071.c:84:1: warning: 'tda10071_rd_regs' uses dynamic stack allocation [enabled by default]
      Instead, let's enforce a limit for the buffer. Considering that I2C
      transfers are generally limited, and that devices used on USB has a
      max data length of 64 bytes for	the control URBs.
      So, it seem safe to use 64 bytes as the hard limit for all those devices.
       On most cases, the limit is a way lower than that, but	this limit
      is small enough to not affect the Kernel stack, and it is a no brain
      limit, as using smaller ones would require to either carefully each
      driver or to take a look on each datasheet.
      Signed-off-by: NMauro Carvalho Chehab <m.chehab@samsung.com>
      Reviewed-by: NHans Verkuil <hans.verkuil@cisco.com>
      Reviewed-by: NAntti Palosaari <crope@iki.fi>
      Signed-off-by: NMauro Carvalho Chehab <m.chehab@samsung.com>
      37ebaf68
  3. 31 10月, 2013 1 次提交
  4. 17 4月, 2013 3 次提交
  5. 28 10月, 2012 1 次提交
  6. 28 9月, 2012 1 次提交
  7. 24 9月, 2012 3 次提交
  8. 15 9月, 2012 3 次提交
  9. 10 9月, 2012 1 次提交
  10. 14 8月, 2012 1 次提交
  11. 31 7月, 2012 1 次提交
  12. 05 7月, 2012 2 次提交