- 17 3月, 2008 9 次提交
-
-
由 Jay Cliburn 提交于
Make needlessly global functions static. In a couple of cases this requires removing forward declarations and reordering functions. Signed-off-by: NJay Cliburn <jacliburn@bellsouth.net> Acked-by: NChris Snook <csnook@redhat.com> Signed-off-by: NJeff Garzik <jeff@garzik.org>
-
由 Jay Cliburn 提交于
Add some debug printks if we encounter a potentially bad receive return descriptor. Signed-off-by: NJay Cliburn <jacliburn@bellsouth.net> Acked-by: NChris Snook <csnook@redhat.com> Signed-off-by: NJeff Garzik <jeff@garzik.org>
-
由 Jay Cliburn 提交于
Use netif_msg_* for console messages emitted by the driver. Add a parameter to allow control of messaging at driver startup, and also add the ability to control it with ethtool. Signed-off-by: NJay Cliburn <jacliburn@bellsouth.net> Acked-by: NChris Snook <csnook@redhat.com> Signed-off-by: NJeff Garzik <jeff@garzik.org>
-
由 Jay Cliburn 提交于
Use skb->csum_start for tx checksum offload preparation. Also swap the variables css and cso so they hold the intended values of csum start and offset, respectively. Signed-off-by: NJay Cliburn <jacliburn@bellsouth.net> Acked-by: NChris Snook <csnook@redhat.com> Signed-off-by: NJeff Garzik <jeff@garzik.org>
-
由 Jay Cliburn 提交于
The transmit packet descriptor consists of four 32-bit words, with word 3 upper bits overloaded depending upon the condition of its bits 3 and 4. The driver currently duplicates all word 2 and some word 3 register bit definitions unnecessarily and also uses a set of nested structures in its definition of the TPD without good cause. This patch adds a lengthy comment describing the TPD, eliminates duplicate TPD bit definitions, and simplifies the TPD structure itself. It also expands the TSO check to correctly handle custom checksum versus TSO processing using the revised TPD definitions. Finally, shorten some variable names in the transmit processing path to reduce line lengths, rename some variables to better describe their purpose (e.g., nseg versus m), and add a comment or two to better describe what the code is doing. Signed-off-by: NJay Cliburn <jacliburn@bellsouth.net> Acked-by: NChris Snook <csnook@redhat.com> Signed-off-by: NJeff Garzik <jeff@garzik.org>
-
由 Jay Cliburn 提交于
Add the ethtool register dump option to the atl1 driver. Signed-off-by: NJay Cliburn <jacliburn@bellsouth.net> Acked-by: NChris Snook <csnook@redhat.com> Signed-off-by: NJeff Garzik <jeff@garzik.org>
-
由 Jay Cliburn 提交于
The L1 tx packet descriptor expects TCP Header Length to be expressed as a number of 32-bit dwords. The atl1 driver uses tcp_hdrlen() to populate the field, but tcp_hdrlen() returns the header length in bytes, not in dwords. Add a shift to convert tcp_hdrlen() to dwords when we write it to the tpd. Also, some of our bit assignments are made to the wrong tpd words. Change those to the correct words. Finally, since all this fixes TSO, enable TSO by default. Signed-off-by: NJay Cliburn <jacliburn@bellsouth.net> Acked-by: NChris Snook <csnook@redhat.com> Signed-off-by: NJeff Garzik <jeff@garzik.org>
-
由 Jay Cliburn 提交于
The future atl2 driver and the existing atl1 driver can share certain functions and definitions. Move these shareable functions and definitions out of atl1-specific files and into atlx.c and atlx.h. Some transitory hackery will be present until atl2 is merged. Reduce the number of source files by moving ethtool, hw, and param functions from separate files into atl1_main.c, then rename it to just atl1.c. Move all atl1-specific definitions from atl1_hw.h to atl1.h. Finally, clean up to make checkpatch.pl happy. Signed-off-by: NChris Snook <csnook@redhat.com> Signed-off-by: NJay Cliburn <jacliburn@bellsouth.net> Signed-off-by: NJeff Garzik <jeff@garzik.org>
-
由 Jay Cliburn 提交于
In preparation for a future Atheros L2 NIC driver (called atl2), relocate the atl1 driver into a new /drivers/net/atlx directory that will ultimately be shared with the future atl2 driver. Signed-off-by: NChris Snook <csnook@redhat.com> Signed-off-by: NJay Cliburn <jacliburn@bellsouth.net> Signed-off-by: NJeff Garzik <jeff@garzik.org>
-
- 19 1月, 2008 1 次提交
-
-
由 Jay Cliburn 提交于
The driver sets up the hardware to accept a frame with max length equal to MTU + Ethernet header + FCS + VLAN tag, but we neglect to add the VLAN tag size to the ingress buffer. When a VLAN-tagged frame arrives, the hardware passes it, but bad things happen because the buffer is too small. This patch fixes that. Thanks to David Harris for reporting the bug and testing the fix. Tested-by: NDavid Harris <david.harris@cpni-inc.com> Signed-off-by: NJay Cliburn <jacliburn@bellsouth.net> Signed-off-by: NJeff Garzik <jeff@garzik.org>
-
- 11 10月, 2007 4 次提交
-
-
由 Stephen Hemminger 提交于
Fix some of the easy warnings in network device drivers. Signed-off-by: NStephen Hemminger <shemminger@linux-foundation.org> Signed-off-by: NJeff Garzik <jeff@garzik.org>
-
由 Chris Snook 提交于
Document the fact that atl1 uses a single shared register for the high 32 bits of 64-bit DMA addresses, making 64-bit DMA more trouble than it's worth. Signed-off-by: NChris Snook <csnook@redhat.com> Signed-off-by: NJeff Garzik <jeff@garzik.org>
-
由 Ralf Baechle 提交于
It's been a useless no-op for long enough in 2.6 so I figured it's time to remove it. The number of people that could object because they're maintaining unified 2.4 and 2.6 drivers is probably rather small. [ Handled drivers added by netdev tree and some missed IRDA cases... -DaveM ] Signed-off-by: NRalf Baechle <ralf@linux-mips.org> Signed-off-by: NJeff Garzik <jeff@garzik.org> Signed-off-by: NDavid S. Miller <davem@davemloft.net>
-
由 Jesper Juhl 提交于
This patch cleans up duplicate includes in drivers/net/ Signed-off-by: NJesper Juhl <jesper.juhl@gmail.com> Acked-by: N"John W. Linville" <linville@tuxdriver.com> Signed-off-by: NAndrew Morton <akpm@linux-foundation.org> Signed-off-by: NJeff Garzik <jeff@garzik.org>
-
- 13 9月, 2007 1 次提交
-
-
由 Luca Tettamanti 提交于
64-bit DMA causes data corruption with atl1. We don't know why, and Atheros is working on it. For now, just use 32-bit DMA. This is a big hack that is probably wrong, but it stops the bleeding. Signed-off-by: NLuca Tettamanti <kronos.it@gmail.com> Acked-by: NChris Snook <csnook@redhat.com> Acked-by: NJay Cliburn <jacliburn@bellsouth.net> Signed-off-by: NJeff Garzik <jeff@garzik.org>
-
- 08 8月, 2007 1 次提交
-
-
由 Ingo Molnar 提交于
use the simpler spin_trylock_irqsave() API to get the adapter lock. [ this is also a fix for -rt where adapter->lock is a sleeping lock. ] Signed-off-by: NIngo Molnar <mingo@elte.hu> Signed-off-by: NJay Cliburn <jacliburn@bellsouth.net> Signed-off-by: NJeff Garzik <jeff@garzik.org>
-
- 25 7月, 2007 5 次提交
-
-
由 Chris Snook 提交于
Sparse (correctly) thinks this function should be static. Make it so. Signed-off-by: NChris Snook <csnook@redhat.com> Signed-off-by: NJeff Garzik <jeff@garzik.org>
-
由 Jay Cliburn 提交于
Use constants already provided by the kernel for ethernet related lengths. Signed-off-by: NJay Cliburn <jacliburn@bellsouth.net> Signed-off-by: NJeff Garzik <jeff@garzik.org>
-
由 Jay Cliburn 提交于
Change the threshold number of descriptors used to trigger CMB writes. The vendor reports that under certain conditions this will reduce the number of unnecessary tx interrupts and improve rx performance. This change is lifted directly from vendor version 1.2.40.2 of the L1 driver. Signed-off-by: NJay Cliburn <jacliburn@bellsouth.net> Signed-off-by: NJeff Garzik <jeff@garzik.org>
-
由 Jay Cliburn 提交于
The DMA engine setup contains a typo that can result in an incorrect dmaw_block setting. Signed-off-by: NJay Cliburn <jacliburn@bellsouth.net> Signed-off-by: NJeff Garzik <jeff@garzik.org>
-
由 Jay Cliburn 提交于
Change tpd_avail() to atl1_tpd_avail(). Signed-off-by: NJay Cliburn <jacliburn@bellsouth.net> Signed-off-by: NJeff Garzik <jeff@garzik.org>
-
- 18 7月, 2007 1 次提交
-
-
由 Al Viro 提交于
Signed-off-by: NAl Viro <viro@zeniv.linux.org.uk> Signed-off-by: NLinus Torvalds <torvalds@linux-foundation.org>
-
- 17 7月, 2007 5 次提交
-
-
由 Jay Cliburn 提交于
Reorder functions in atl1_main into more logical groupings to make the code easier to follow. This patch is large, but it's harmless; it neither adds nor removes any functionality whatsoever. Signed-off-by: NJay Cliburn <jacliburn@bellsouth.net> Signed-off-by: NJeff Garzik <jeff@garzik.org>
-
由 Jay Cliburn 提交于
Move excessively indented code to separate functions. Also move ring pointer initialization to its own function. Signed-off-by: NJay Cliburn <jacliburn@bellsouth.net> Signed-off-by: NJeff Garzik <jeff@garzik.org>
-
由 Jay Cliburn 提交于
Fix indentation, remove dead code, improve some comments, change dev_dbg to dev_printk. Signed-off-by: NJay Cliburn <jacliburn@bellsouth.net> Signed-off-by: NJeff Garzik <jeff@garzik.org>
-
由 Jay Cliburn 提交于
Remove unused structure members, improve comments, break long comment lines, rename a constant to be consistent with others in the file. Signed-off-by: NJay Cliburn <jacliburn@bellsouth.net> Signed-off-by: NJeff Garzik <jeff@garzik.org>
-
由 Jay Cliburn 提交于
Remove unnecessary irq_sem code. Signed-off-by: NChris Snook <csnook@redhat.com> Signed-off-by: NJay Cliburn <jacliburn@bellsouth.net> Signed-off-by: NJeff Garzik <jeff@garzik.org>
-
- 12 7月, 2007 1 次提交
-
-
由 Auke Kok 提交于
Instead of all drivers reading pci config space to get the revision ID, they can now use the pci_device->revision member. This exposes some issues where drivers where reading a word or a dword for the revision number, and adding useless error-handling around the read. Some drivers even just read it for no purpose of all. In devices where the revision ID is being copied over and used in what appears to be the equivalent of hotpath, I have left the copy code and the cached copy as not to influence the driver's performance. Compile tested with make all{yes,mod}config on x86_64 and i386. Signed-off-by: NAuke Kok <auke-jan.h.kok@intel.com> Acked-by: NDave Jones <davej@redhat.com> Signed-off-by: NGreg Kroah-Hartman <gregkh@suse.de>
-
- 11 7月, 2007 1 次提交
-
-
由 Alexey Dobriyan 提交于
Signed-off-by: NAlexey Dobriyan <adobriyan@sw.ru> Signed-off-by: NJeff Garzik <jeff@garzik.org>
-
- 03 6月, 2007 1 次提交
-
-
由 Stephen Hemminger 提交于
This driver has unneeded stubs for VLAN filtering. Signed-off-by: NStephen Hemminger <shemminger@linux-foundation.org> Signed-off-by: NJeff Garzik <jeff@garzik.org>
-
- 10 5月, 2007 1 次提交
-
-
由 Alexey Dobriyan 提交于
Copied from b44 driver, but it works: netconsole: device eth0 not up yet, forcing it atl1: eth0 link is up 100 Mbps full duplex netconsole: network logging started Signed-off-by: NAlexey Dobriyan <adobriyan@gmail.com> Signed-off-by: NJeff Garzik <jeff@garzik.org>
-
- 08 5月, 2007 1 次提交
-
-
由 Jay Cliburn 提交于
Use dev_printk macros for PCI related errors, warnings, debug and info console messages. Signed-off-by: NJay Cliburn <jacliburn@bellsouth.net> Signed-off-by: NJeff Garzik <jeff@garzik.org>
-
- 26 4月, 2007 7 次提交
-
-
由 Herbert Xu 提交于
When csum_offset was introduced we did a conversion from csum to csum_offset where applicable. A couple of drivers were missed in this process. It was harmless to begin with since the two fields coincided. Now that we've made them different with the addition of csum_start, the missed drivers must be converted or they can't send packets out at all that require checksum offload. Signed-off-by: NHerbert Xu <herbert@gondor.apana.org.au> Signed-off-by: NDavid S. Miller <davem@davemloft.net>
-
由 Arnaldo Carvalho de Melo 提交于
Signed-off-by: NArnaldo Carvalho de Melo <acme@redhat.com> Signed-off-by: NDavid S. Miller <davem@davemloft.net>
-
由 Arnaldo Carvalho de Melo 提交于
The ip_hdrlen() buddy, created to reduce the number of skb->h.th-> uses and to avoid the longer, open coded equivalent. Ditched a no-op in bnx2 in the process. I wonder if we should have a BUG_ON(skb->h.th->doff < 5) in tcp_optlen()... Signed-off-by: NArnaldo Carvalho de Melo <acme@redhat.com> Signed-off-by: NDavid S. Miller <davem@davemloft.net>
-
由 Arnaldo Carvalho de Melo 提交于
For the quite common 'skb->h.raw - skb->data' sequence. Signed-off-by: NArnaldo Carvalho de Melo <acme@redhat.com> Signed-off-by: NDavid S. Miller <davem@davemloft.net>
-
由 Arnaldo Carvalho de Melo 提交于
Signed-off-by: NArnaldo Carvalho de Melo <acme@redhat.com> Signed-off-by: NDavid S. Miller <davem@davemloft.net>
-
由 Arnaldo Carvalho de Melo 提交于
For the quite common 'skb->nh.raw - skb->data' sequence. Signed-off-by: NArnaldo Carvalho de Melo <acme@redhat.com> Signed-off-by: NDavid S. Miller <davem@davemloft.net>
-
由 Arnaldo Carvalho de Melo 提交于
One less thing for drivers writers to worry about. Signed-off-by: NArnaldo Carvalho de Melo <acme@redhat.com> Signed-off-by: NDavid S. Miller <davem@davemloft.net>
-
- 29 3月, 2007 1 次提交
-
-
由 Chris Snook 提交于
Some atl1 boards get their MAC address written directly to the register by the BIOS during POST, rather than storing it in EEPROM that's accessible to the driver. If the MAC register on one of these boards is changed and then the module is unloaded, the permanent MAC address will be forgotten until the box is rebooted. We should save the permanent address during removal if we've been messing with it. Signed-off-by: NChris Snook <csnook@redhat.com> Signed-off-by: NJeff Garzik <jeff@garzik.org>
-