1. 24 3月, 2015 2 次提交
    • I
      drm/i915: move clearing of RPS interrupt bits from disable to reset time · 096fad9e
      Imre Deak 提交于
      The logical place for clearing the RPS latched interrupt bits is when
      resetting the RPS interrupts, so move the corresponding part from the RPS
      disable function to the reset function. During resetting we already
      cleared the IIR bits, so the only thing missing there was clearing pm_iir.
      
      Note that we call gen6_disable_rps_interrupts() also during driver load
      and resume time via intel_uncore_sanitize() when i915 interrupts are
      still not installed. If there are any pending RPS bits at this point
      (which after this patch wouldn't be cleared) they will be cleared by the
      reset code via the interrupt preinstall hooks.
      Signed-off-by: NImre Deak <imre.deak@intel.com>
      Signed-off-by: NDaniel Vetter <daniel.vetter@ffwll.ch>
      096fad9e
    • I
      drm/i915: fix race when clearing RPS IIR bits · 58072ccb
      Imre Deak 提交于
      When disabling RPS interrupts there is a race where we disable RPS
      inerrupts while the interrupt handler is running and the handler has
      already latched the pending RPS interrupt from the master IIR register.
      Afterwards the disabling path clears the PM IIR bits, making the state
      of pending interrupts inconsistent from the interrupt handler's point of
      view. This triggers the following warning: "The master control interrupt
      lied (PM)!".
      
      To fix this make sure that any running interrupt handler (which may
      have already latched the master IIR) finishes before clearing the IIR
      bits.
      
      Bugzilla: https://bugs.freedesktop.org/show_bug.cgi?id=87347Signed-off-by: NImre Deak <imre.deak@intel.com>
      Signed-off-by: NDaniel Vetter <daniel.vetter@ffwll.ch>
      58072ccb
  2. 23 3月, 2015 8 次提交
  3. 20 3月, 2015 30 次提交