• R
    iwlwifi: do not send sync command while holding spinlock · bba98871
    Reinette Chatre 提交于
    commit 10c994ca70e8e94bbc85a5bf13de5911ee8de4d2 "iwlwifi: fix remove key
    error" fixed an error reported by mac80211 during interface down. The fix
    involved changing an async command to synchronous. Unfortunately this was
    inside a spinlock section in which we cannot sleep.
    
    Modify the sending of the command back to async. This causes the mac80211
    error "mac80211-phy0: failed to remove key (0, ff:ff:ff:ff:ff:ff) from
    hardware (-16)." to return. This error is not serious since this occurs
    during interface down and the keys will be cleared anyway when ucode is
    unloaded. Having this error message is thus less serious than a potential
    deadlock introduced when sleeping while holding a spinlock. We will have to
    find another fix for that error.
    
    This is a revert of the abovementioned commit.
    Signed-off-by: NReinette Chatre <reinette.chatre@intel.com>
    Signed-off-by: NJohn W. Linville <linville@tuxdriver.com>
    bba98871
iwl-sta.c 32.9 KB