intel_dvo.c 16.4 KB
Newer Older
J
Jesse Barnes 已提交
1 2 3 4 5 6 7 8 9 10 11 12 13 14 15 16 17 18 19 20 21 22 23 24 25 26 27
/*
 * Copyright 2006 Dave Airlie <airlied@linux.ie>
 * Copyright © 2006-2007 Intel Corporation
 *
 * Permission is hereby granted, free of charge, to any person obtaining a
 * copy of this software and associated documentation files (the "Software"),
 * to deal in the Software without restriction, including without limitation
 * the rights to use, copy, modify, merge, publish, distribute, sublicense,
 * and/or sell copies of the Software, and to permit persons to whom the
 * Software is furnished to do so, subject to the following conditions:
 *
 * The above copyright notice and this permission notice (including the next
 * paragraph) shall be included in all copies or substantial portions of the
 * Software.
 *
 * THE SOFTWARE IS PROVIDED "AS IS", WITHOUT WARRANTY OF ANY KIND, EXPRESS OR
 * IMPLIED, INCLUDING BUT NOT LIMITED TO THE WARRANTIES OF MERCHANTABILITY,
 * FITNESS FOR A PARTICULAR PURPOSE AND NONINFRINGEMENT.  IN NO EVENT SHALL
 * THE AUTHORS OR COPYRIGHT HOLDERS BE LIABLE FOR ANY CLAIM, DAMAGES OR OTHER
 * LIABILITY, WHETHER IN AN ACTION OF CONTRACT, TORT OR OTHERWISE, ARISING
 * FROM, OUT OF OR IN CONNECTION WITH THE SOFTWARE OR THE USE OR OTHER
 * DEALINGS IN THE SOFTWARE.
 *
 * Authors:
 *	Eric Anholt <eric@anholt.net>
 */
#include <linux/i2c.h>
28
#include <linux/slab.h>
29
#include <drm/drmP.h>
30
#include <drm/drm_atomic_helper.h>
31
#include <drm/drm_crtc.h>
J
Jesse Barnes 已提交
32
#include "intel_drv.h"
33
#include <drm/i915_drm.h>
J
Jesse Barnes 已提交
34 35 36 37 38 39
#include "i915_drv.h"
#include "dvo.h"

#define SIL164_ADDR	0x38
#define CH7xxx_ADDR	0x76
#define TFP410_ADDR	0x38
40
#define NS2501_ADDR     0x38
J
Jesse Barnes 已提交
41

C
Chris Wilson 已提交
42
static const struct intel_dvo_device intel_dvo_devices[] = {
J
Jesse Barnes 已提交
43 44 45 46
	{
		.type = INTEL_DVO_CHIP_TMDS,
		.name = "sil164",
		.dvo_reg = DVOC,
47
		.dvo_srcdim_reg = DVOC_SRCDIM,
J
Jesse Barnes 已提交
48 49 50 51 52 53 54
		.slave_addr = SIL164_ADDR,
		.dev_ops = &sil164_ops,
	},
	{
		.type = INTEL_DVO_CHIP_TMDS,
		.name = "ch7xxx",
		.dvo_reg = DVOC,
55
		.dvo_srcdim_reg = DVOC_SRCDIM,
J
Jesse Barnes 已提交
56 57 58
		.slave_addr = CH7xxx_ADDR,
		.dev_ops = &ch7xxx_ops,
	},
59 60 61 62
	{
		.type = INTEL_DVO_CHIP_TMDS,
		.name = "ch7xxx",
		.dvo_reg = DVOC,
63
		.dvo_srcdim_reg = DVOC_SRCDIM,
64 65 66
		.slave_addr = 0x75, /* For some ch7010 */
		.dev_ops = &ch7xxx_ops,
	},
J
Jesse Barnes 已提交
67 68 69 70
	{
		.type = INTEL_DVO_CHIP_LVDS,
		.name = "ivch",
		.dvo_reg = DVOA,
71
		.dvo_srcdim_reg = DVOA_SRCDIM,
J
Jesse Barnes 已提交
72 73 74 75 76 77 78
		.slave_addr = 0x02, /* Might also be 0x44, 0x84, 0xc4 */
		.dev_ops = &ivch_ops,
	},
	{
		.type = INTEL_DVO_CHIP_TMDS,
		.name = "tfp410",
		.dvo_reg = DVOC,
79
		.dvo_srcdim_reg = DVOC_SRCDIM,
J
Jesse Barnes 已提交
80 81 82 83 84 85 86
		.slave_addr = TFP410_ADDR,
		.dev_ops = &tfp410_ops,
	},
	{
		.type = INTEL_DVO_CHIP_LVDS,
		.name = "ch7017",
		.dvo_reg = DVOC,
87
		.dvo_srcdim_reg = DVOC_SRCDIM,
J
Jesse Barnes 已提交
88
		.slave_addr = 0x75,
89
		.gpio = GMBUS_PIN_DPB,
J
Jesse Barnes 已提交
90
		.dev_ops = &ch7017_ops,
91 92 93 94
	},
	{
	        .type = INTEL_DVO_CHIP_TMDS,
		.name = "ns2501",
V
Ville Syrjälä 已提交
95
		.dvo_reg = DVOB,
96
		.dvo_srcdim_reg = DVOB_SRCDIM,
97 98 99
		.slave_addr = NS2501_ADDR,
		.dev_ops = &ns2501_ops,
       }
J
Jesse Barnes 已提交
100 101
};

C
Chris Wilson 已提交
102 103 104 105 106
struct intel_dvo {
	struct intel_encoder base;

	struct intel_dvo_device dev;

107 108
	struct intel_connector *attached_connector;

C
Chris Wilson 已提交
109 110 111
	bool panel_wants_dither;
};

112
static struct intel_dvo *enc_to_dvo(struct intel_encoder *encoder)
C
Chris Wilson 已提交
113
{
114
	return container_of(encoder, struct intel_dvo, base);
C
Chris Wilson 已提交
115 116
}

117 118
static struct intel_dvo *intel_attached_dvo(struct drm_connector *connector)
{
119
	return enc_to_dvo(intel_attached_encoder(connector));
120 121
}

122
static bool intel_dvo_connector_get_hw_state(struct intel_connector *connector)
J
Jesse Barnes 已提交
123
{
124
	struct drm_device *dev = connector->base.dev;
125
	struct drm_i915_private *dev_priv = to_i915(dev);
126
	struct intel_dvo *intel_dvo = intel_attached_dvo(&connector->base);
127 128 129 130 131 132
	u32 tmp;

	tmp = I915_READ(intel_dvo->dev.dvo_reg);

	if (!(tmp & DVO_ENABLE))
		return false;
133 134 135 136 137 138 139 140

	return intel_dvo->dev.dev_ops->get_hw_state(&intel_dvo->dev);
}

static bool intel_dvo_get_hw_state(struct intel_encoder *encoder,
				   enum pipe *pipe)
{
	struct drm_device *dev = encoder->base.dev;
141
	struct drm_i915_private *dev_priv = to_i915(dev);
142
	struct intel_dvo *intel_dvo = enc_to_dvo(encoder);
143 144 145 146 147 148 149 150 151 152 153 154
	u32 tmp;

	tmp = I915_READ(intel_dvo->dev.dvo_reg);

	if (!(tmp & DVO_ENABLE))
		return false;

	*pipe = PORT_TO_PIPE(tmp);

	return true;
}

155
static void intel_dvo_get_config(struct intel_encoder *encoder,
156
				 struct intel_crtc_state *pipe_config)
157
{
158
	struct drm_i915_private *dev_priv = to_i915(encoder->base.dev);
159
	struct intel_dvo *intel_dvo = enc_to_dvo(encoder);
160 161 162 163 164 165 166 167 168 169 170 171
	u32 tmp, flags = 0;

	tmp = I915_READ(intel_dvo->dev.dvo_reg);
	if (tmp & DVO_HSYNC_ACTIVE_HIGH)
		flags |= DRM_MODE_FLAG_PHSYNC;
	else
		flags |= DRM_MODE_FLAG_NHSYNC;
	if (tmp & DVO_VSYNC_ACTIVE_HIGH)
		flags |= DRM_MODE_FLAG_PVSYNC;
	else
		flags |= DRM_MODE_FLAG_NVSYNC;

172
	pipe_config->base.adjusted_mode.flags |= flags;
173

174
	pipe_config->base.adjusted_mode.crtc_clock = pipe_config->port_clock;
175 176
}

177 178 179
static void intel_disable_dvo(struct intel_encoder *encoder,
			      struct intel_crtc_state *old_crtc_state,
			      struct drm_connector_state *old_conn_state)
180
{
181
	struct drm_i915_private *dev_priv = to_i915(encoder->base.dev);
182
	struct intel_dvo *intel_dvo = enc_to_dvo(encoder);
183
	i915_reg_t dvo_reg = intel_dvo->dev.dvo_reg;
184 185 186 187 188 189 190
	u32 temp = I915_READ(dvo_reg);

	intel_dvo->dev.dev_ops->dpms(&intel_dvo->dev, false);
	I915_WRITE(dvo_reg, temp & ~DVO_ENABLE);
	I915_READ(dvo_reg);
}

191 192 193
static void intel_enable_dvo(struct intel_encoder *encoder,
			     struct intel_crtc_state *pipe_config,
			     struct drm_connector_state *conn_state)
194
{
195
	struct drm_i915_private *dev_priv = to_i915(encoder->base.dev);
196
	struct intel_dvo *intel_dvo = enc_to_dvo(encoder);
197
	struct intel_crtc *crtc = to_intel_crtc(encoder->base.crtc);
198
	i915_reg_t dvo_reg = intel_dvo->dev.dvo_reg;
J
Jesse Barnes 已提交
199 200
	u32 temp = I915_READ(dvo_reg);

201
	intel_dvo->dev.dev_ops->mode_set(&intel_dvo->dev,
202 203
					 &crtc->config->base.mode,
					 &crtc->config->base.adjusted_mode);
204

205 206 207
	I915_WRITE(dvo_reg, temp | DVO_ENABLE);
	I915_READ(dvo_reg);

208 209 210
	intel_dvo->dev.dev_ops->dpms(&intel_dvo->dev, true);
}

211 212 213
static enum drm_mode_status
intel_dvo_mode_valid(struct drm_connector *connector,
		     struct drm_display_mode *mode)
J
Jesse Barnes 已提交
214
{
215
	struct intel_dvo *intel_dvo = intel_attached_dvo(connector);
216 217
	const struct drm_display_mode *fixed_mode =
		to_intel_connector(connector)->panel.fixed_mode;
M
Mika Kahola 已提交
218 219
	int max_dotclk = to_i915(connector->dev)->max_dotclk_freq;
	int target_clock = mode->clock;
J
Jesse Barnes 已提交
220 221 222 223 224 225

	if (mode->flags & DRM_MODE_FLAG_DBLSCAN)
		return MODE_NO_DBLESCAN;

	/* XXX: Validate clock range */

226 227
	if (fixed_mode) {
		if (mode->hdisplay > fixed_mode->hdisplay)
J
Jesse Barnes 已提交
228
			return MODE_PANEL;
229
		if (mode->vdisplay > fixed_mode->vdisplay)
J
Jesse Barnes 已提交
230
			return MODE_PANEL;
M
Mika Kahola 已提交
231

232
		target_clock = fixed_mode->clock;
J
Jesse Barnes 已提交
233 234
	}

M
Mika Kahola 已提交
235 236 237
	if (target_clock > max_dotclk)
		return MODE_CLOCK_HIGH;

C
Chris Wilson 已提交
238
	return intel_dvo->dev.dev_ops->mode_valid(&intel_dvo->dev, mode);
J
Jesse Barnes 已提交
239 240
}

241
static bool intel_dvo_compute_config(struct intel_encoder *encoder,
242
				     struct intel_crtc_state *pipe_config)
J
Jesse Barnes 已提交
243
{
244
	struct intel_dvo *intel_dvo = enc_to_dvo(encoder);
245 246
	const struct drm_display_mode *fixed_mode =
		intel_dvo->attached_connector->panel.fixed_mode;
247
	struct drm_display_mode *adjusted_mode = &pipe_config->base.adjusted_mode;
J
Jesse Barnes 已提交
248 249 250 251 252 253

	/* If we have timings from the BIOS for the panel, put them in
	 * to the adjusted mode.  The CRTC will be set up for this mode,
	 * with the panel scaling set up to source from the H/VDisplay
	 * of the original mode.
	 */
254 255
	if (fixed_mode)
		intel_fixed_panel_mode(fixed_mode, adjusted_mode);
J
Jesse Barnes 已提交
256 257 258 259

	return true;
}

260 261 262
static void intel_dvo_pre_enable(struct intel_encoder *encoder,
				 struct intel_crtc_state *pipe_config,
				 struct drm_connector_state *conn_state)
J
Jesse Barnes 已提交
263
{
264
	struct drm_device *dev = encoder->base.dev;
265
	struct drm_i915_private *dev_priv = to_i915(dev);
266
	struct intel_crtc *crtc = to_intel_crtc(encoder->base.crtc);
267
	const struct drm_display_mode *adjusted_mode = &crtc->config->base.adjusted_mode;
268 269
	struct intel_dvo *intel_dvo = enc_to_dvo(encoder);
	int pipe = crtc->pipe;
J
Jesse Barnes 已提交
270
	u32 dvo_val;
271 272
	i915_reg_t dvo_reg = intel_dvo->dev.dvo_reg;
	i915_reg_t dvo_srcdim_reg = intel_dvo->dev.dvo_srcdim_reg;
J
Jesse Barnes 已提交
273 274 275 276 277 278 279 280 281 282 283 284 285 286 287 288

	/* Save the data order, since I don't know what it should be set to. */
	dvo_val = I915_READ(dvo_reg) &
		  (DVO_PRESERVE_MASK | DVO_DATA_ORDER_GBRG);
	dvo_val |= DVO_DATA_ORDER_FP | DVO_BORDER_ENABLE |
		   DVO_BLANK_ACTIVE_HIGH;

	if (pipe == 1)
		dvo_val |= DVO_PIPE_B_SELECT;
	dvo_val |= DVO_PIPE_STALL;
	if (adjusted_mode->flags & DRM_MODE_FLAG_PHSYNC)
		dvo_val |= DVO_HSYNC_ACTIVE_HIGH;
	if (adjusted_mode->flags & DRM_MODE_FLAG_PVSYNC)
		dvo_val |= DVO_VSYNC_ACTIVE_HIGH;

	/*I915_WRITE(DVOB_SRCDIM,
289 290
	  (adjusted_mode->crtc_hdisplay << DVO_SRCDIM_HORIZONTAL_SHIFT) |
	  (adjusted_mode->crtc_vdisplay << DVO_SRCDIM_VERTICAL_SHIFT));*/
J
Jesse Barnes 已提交
291
	I915_WRITE(dvo_srcdim_reg,
292 293
		   (adjusted_mode->crtc_hdisplay << DVO_SRCDIM_HORIZONTAL_SHIFT) |
		   (adjusted_mode->crtc_vdisplay << DVO_SRCDIM_VERTICAL_SHIFT));
J
Jesse Barnes 已提交
294 295 296 297 298 299 300 301 302
	/*I915_WRITE(DVOB, dvo_val);*/
	I915_WRITE(dvo_reg, dvo_val);
}

/**
 * Detect the output connection on our DVO device.
 *
 * Unimplemented.
 */
303
static enum drm_connector_status
304
intel_dvo_detect(struct drm_connector *connector, bool force)
J
Jesse Barnes 已提交
305
{
306
	struct intel_dvo *intel_dvo = intel_attached_dvo(connector);
307
	DRM_DEBUG_KMS("[CONNECTOR:%d:%s]\n",
308
		      connector->base.id, connector->name);
C
Chris Wilson 已提交
309
	return intel_dvo->dev.dev_ops->detect(&intel_dvo->dev);
J
Jesse Barnes 已提交
310 311 312 313
}

static int intel_dvo_get_modes(struct drm_connector *connector)
{
314
	struct drm_i915_private *dev_priv = to_i915(connector->dev);
315 316
	const struct drm_display_mode *fixed_mode =
		to_intel_connector(connector)->panel.fixed_mode;
J
Jesse Barnes 已提交
317 318 319 320 321 322

	/* We should probably have an i2c driver get_modes function for those
	 * devices which will have a fixed set of modes determined by the chip
	 * (TV-out, for example), but for now with just TMDS and LVDS,
	 * that's not the case.
	 */
323
	intel_ddc_get_modes(connector,
324
			    intel_gmbus_get_adapter(dev_priv, GMBUS_PIN_DPC));
J
Jesse Barnes 已提交
325 326 327
	if (!list_empty(&connector->probed_modes))
		return 1;

328
	if (fixed_mode) {
J
Jesse Barnes 已提交
329
		struct drm_display_mode *mode;
330
		mode = drm_mode_duplicate(connector->dev, fixed_mode);
J
Jesse Barnes 已提交
331 332 333 334 335
		if (mode) {
			drm_mode_probed_add(connector, mode);
			return 1;
		}
	}
C
Chris Wilson 已提交
336

J
Jesse Barnes 已提交
337 338 339
	return 0;
}

C
Chris Wilson 已提交
340
static void intel_dvo_destroy(struct drm_connector *connector)
J
Jesse Barnes 已提交
341 342
{
	drm_connector_cleanup(connector);
343
	intel_panel_fini(&to_intel_connector(connector)->panel);
344
	kfree(connector);
J
Jesse Barnes 已提交
345 346 347
}

static const struct drm_connector_funcs intel_dvo_connector_funcs = {
348
	.dpms = drm_atomic_helper_connector_dpms,
J
Jesse Barnes 已提交
349
	.detect = intel_dvo_detect,
350
	.late_register = intel_connector_register,
351
	.early_unregister = intel_connector_unregister,
J
Jesse Barnes 已提交
352 353
	.destroy = intel_dvo_destroy,
	.fill_modes = drm_helper_probe_single_connector_modes,
354
	.atomic_get_property = intel_connector_atomic_get_property,
355
	.atomic_destroy_state = drm_atomic_helper_connector_destroy_state,
356
	.atomic_duplicate_state = drm_atomic_helper_connector_duplicate_state,
J
Jesse Barnes 已提交
357 358 359 360 361 362 363
};

static const struct drm_connector_helper_funcs intel_dvo_connector_helper_funcs = {
	.mode_valid = intel_dvo_mode_valid,
	.get_modes = intel_dvo_get_modes,
};

364
static void intel_dvo_enc_destroy(struct drm_encoder *encoder)
J
Jesse Barnes 已提交
365
{
366
	struct intel_dvo *intel_dvo = enc_to_dvo(to_intel_encoder(encoder));
C
Chris Wilson 已提交
367 368 369 370 371

	if (intel_dvo->dev.dev_ops->destroy)
		intel_dvo->dev.dev_ops->destroy(&intel_dvo->dev);

	intel_encoder_destroy(encoder);
J
Jesse Barnes 已提交
372 373 374 375 376 377 378 379 380 381 382 383 384
}

static const struct drm_encoder_funcs intel_dvo_enc_funcs = {
	.destroy = intel_dvo_enc_destroy,
};

/**
 * Attempts to get a fixed panel timing for LVDS (currently only the i830).
 *
 * Other chips with DVO LVDS will need to extend this to deal with the LVDS
 * chip being on DVOB/C and having multiple pipes.
 */
static struct drm_display_mode *
C
Chris Wilson 已提交
385
intel_dvo_get_current_mode(struct drm_connector *connector)
J
Jesse Barnes 已提交
386 387
{
	struct drm_device *dev = connector->dev;
388
	struct drm_i915_private *dev_priv = to_i915(dev);
389
	struct intel_dvo *intel_dvo = intel_attached_dvo(connector);
C
Chris Wilson 已提交
390
	uint32_t dvo_val = I915_READ(intel_dvo->dev.dvo_reg);
J
Jesse Barnes 已提交
391 392 393 394 395 396 397 398 399
	struct drm_display_mode *mode = NULL;

	/* If the DVO port is active, that'll be the LVDS, so we can pull out
	 * its timings to get how the BIOS set up the panel.
	 */
	if (dvo_val & DVO_ENABLE) {
		struct drm_crtc *crtc;
		int pipe = (dvo_val & DVO_PIPE_B_SELECT) ? 1 : 0;

400
		crtc = intel_get_crtc_for_pipe(dev, pipe);
J
Jesse Barnes 已提交
401 402 403 404 405 406 407 408 409 410 411
		if (crtc) {
			mode = intel_crtc_mode_get(dev, crtc);
			if (mode) {
				mode->type |= DRM_MODE_TYPE_PREFERRED;
				if (dvo_val & DVO_HSYNC_ACTIVE_HIGH)
					mode->flags |= DRM_MODE_FLAG_PHSYNC;
				if (dvo_val & DVO_VSYNC_ACTIVE_HIGH)
					mode->flags |= DRM_MODE_FLAG_PVSYNC;
			}
		}
	}
C
Chris Wilson 已提交
412

J
Jesse Barnes 已提交
413 414 415
	return mode;
}

416 417 418 419 420 421 422 423 424 425 426 427
static char intel_dvo_port_name(i915_reg_t dvo_reg)
{
	if (i915_mmio_reg_equal(dvo_reg, DVOA))
		return 'A';
	else if (i915_mmio_reg_equal(dvo_reg, DVOB))
		return 'B';
	else if (i915_mmio_reg_equal(dvo_reg, DVOC))
		return 'C';
	else
		return '?';
}

J
Jesse Barnes 已提交
428 429
void intel_dvo_init(struct drm_device *dev)
{
430
	struct drm_i915_private *dev_priv = to_i915(dev);
431
	struct intel_encoder *intel_encoder;
C
Chris Wilson 已提交
432
	struct intel_dvo *intel_dvo;
433
	struct intel_connector *intel_connector;
J
Jesse Barnes 已提交
434 435
	int i;
	int encoder_type = DRM_MODE_ENCODER_NONE;
C
Chris Wilson 已提交
436

437
	intel_dvo = kzalloc(sizeof(*intel_dvo), GFP_KERNEL);
C
Chris Wilson 已提交
438
	if (!intel_dvo)
J
Jesse Barnes 已提交
439 440
		return;

441
	intel_connector = intel_connector_alloc();
442
	if (!intel_connector) {
C
Chris Wilson 已提交
443
		kfree(intel_dvo);
444 445 446
		return;
	}

447 448
	intel_dvo->attached_connector = intel_connector;

C
Chris Wilson 已提交
449 450
	intel_encoder = &intel_dvo->base;

451 452
	intel_encoder->disable = intel_disable_dvo;
	intel_encoder->enable = intel_enable_dvo;
453
	intel_encoder->get_hw_state = intel_dvo_get_hw_state;
454
	intel_encoder->get_config = intel_dvo_get_config;
455
	intel_encoder->compute_config = intel_dvo_compute_config;
456
	intel_encoder->pre_enable = intel_dvo_pre_enable;
457
	intel_connector->get_hw_state = intel_dvo_connector_get_hw_state;
458

J
Jesse Barnes 已提交
459 460
	/* Now, try to find a controller */
	for (i = 0; i < ARRAY_SIZE(intel_dvo_devices); i++) {
461
		struct drm_connector *connector = &intel_connector->base;
C
Chris Wilson 已提交
462
		const struct intel_dvo_device *dvo = &intel_dvo_devices[i];
463
		struct i2c_adapter *i2c;
J
Jesse Barnes 已提交
464
		int gpio;
465
		bool dvoinit;
466
		enum pipe pipe;
467
		uint32_t dpll[I915_MAX_PIPES];
J
Jesse Barnes 已提交
468 469 470 471 472

		/* Allow the I2C driver info to specify the GPIO to be used in
		 * special cases, but otherwise default to what's defined
		 * in the spec.
		 */
473
		if (intel_gmbus_is_valid_pin(dev_priv, dvo->gpio))
J
Jesse Barnes 已提交
474 475
			gpio = dvo->gpio;
		else if (dvo->type == INTEL_DVO_CHIP_LVDS)
476
			gpio = GMBUS_PIN_SSC;
J
Jesse Barnes 已提交
477
		else
478
			gpio = GMBUS_PIN_DPB;
J
Jesse Barnes 已提交
479 480 481 482 483

		/* Set up the I2C bus necessary for the chip we're probing.
		 * It appears that everything is on GPIOE except for panels
		 * on i830 laptops, which are on GPIOB (DVOA).
		 */
484
		i2c = intel_gmbus_get_adapter(dev_priv, gpio);
J
Jesse Barnes 已提交
485

C
Chris Wilson 已提交
486
		intel_dvo->dev = *dvo;
487 488 489 490 491 492

		/* GMBUS NAK handling seems to be unstable, hence let the
		 * transmitter detection run in bit banging mode for now.
		 */
		intel_gmbus_force_bit(i2c, true);

493 494 495 496 497 498 499 500 501 502
		/* ns2501 requires the DVO 2x clock before it will
		 * respond to i2c accesses, so make sure we have
		 * have the clock enabled before we attempt to
		 * initialize the device.
		 */
		for_each_pipe(dev_priv, pipe) {
			dpll[pipe] = I915_READ(DPLL(pipe));
			I915_WRITE(DPLL(pipe), dpll[pipe] | DPLL_DVO_2X_MODE);
		}

503 504
		dvoinit = dvo->dev_ops->init(&intel_dvo->dev, i2c);

505 506 507 508 509
		/* restore the DVO 2x clock state to original */
		for_each_pipe(dev_priv, pipe) {
			I915_WRITE(DPLL(pipe), dpll[pipe]);
		}

510 511 512
		intel_gmbus_force_bit(i2c, false);

		if (!dvoinit)
J
Jesse Barnes 已提交
513 514
			continue;

515 516 517 518
		drm_encoder_init(dev, &intel_encoder->base,
				 &intel_dvo_enc_funcs, encoder_type,
				 "DVO %c", intel_dvo_port_name(dvo->dvo_reg));

519 520
		intel_encoder->type = INTEL_OUTPUT_DVO;
		intel_encoder->crtc_mask = (1 << 0) | (1 << 1);
J
Jesse Barnes 已提交
521 522
		switch (dvo->type) {
		case INTEL_DVO_CHIP_TMDS:
523 524
			intel_encoder->cloneable = (1 << INTEL_OUTPUT_ANALOG) |
				(1 << INTEL_OUTPUT_DVO);
J
Jesse Barnes 已提交
525 526 527 528 529 530
			drm_connector_init(dev, connector,
					   &intel_dvo_connector_funcs,
					   DRM_MODE_CONNECTOR_DVII);
			encoder_type = DRM_MODE_ENCODER_TMDS;
			break;
		case INTEL_DVO_CHIP_LVDS:
531
			intel_encoder->cloneable = 0;
J
Jesse Barnes 已提交
532 533 534 535 536 537 538 539 540 541 542 543 544
			drm_connector_init(dev, connector,
					   &intel_dvo_connector_funcs,
					   DRM_MODE_CONNECTOR_LVDS);
			encoder_type = DRM_MODE_ENCODER_LVDS;
			break;
		}

		drm_connector_helper_add(connector,
					 &intel_dvo_connector_helper_funcs);
		connector->display_info.subpixel_order = SubPixelHorizontalRGB;
		connector->interlace_allowed = false;
		connector->doublescan_allowed = false;

545
		intel_connector_attach_encoder(intel_connector, intel_encoder);
J
Jesse Barnes 已提交
546 547 548 549 550 551 552 553
		if (dvo->type == INTEL_DVO_CHIP_LVDS) {
			/* For our LVDS chipsets, we should hopefully be able
			 * to dig the fixed panel mode out of the BIOS data.
			 * However, it's in a different format from the BIOS
			 * data on chipsets with integrated LVDS (stored in AIM
			 * headers, likely), so for now, just get the current
			 * mode being output through DVO.
			 */
554 555 556
			intel_panel_init(&intel_connector->panel,
					 intel_dvo_get_current_mode(connector),
					 NULL);
C
Chris Wilson 已提交
557
			intel_dvo->panel_wants_dither = true;
J
Jesse Barnes 已提交
558 559 560 561 562
		}

		return;
	}

563
	drm_encoder_cleanup(&intel_encoder->base);
C
Chris Wilson 已提交
564
	kfree(intel_dvo);
565
	kfree(intel_connector);
J
Jesse Barnes 已提交
566
}